From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120])
 by mx.groups.io with SMTP id smtpd.web12.1549.1575451948121544555
 for <devel@edk2.groups.io>;
 Wed, 04 Dec 2019 01:32:28 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UngmgWc0;
 spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1575451947;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=DbI1FM012O3PwBgZa+JN6S+NojAnT5P63a2IIeGnsLE=;
	b=UngmgWc0FyLgrdECWyNDU388kq8QCAH9KvLRoIdsornJRRPHVlQnkDtOfoOu7LtuNEjLbH
	6IQYDnrfUSbi9GNLJY6Zyj5JlkVB2EX9AGfHU3XgyB9/czbuBbWG1oEnbywj59nYAQC8Vp
	tpt3QBtj4pSsfrHx7PZEa8Jk9CbDl4Q=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-180-E0WHZXdwMsOYiiGBWQ_ClQ-1; Wed, 04 Dec 2019 04:32:25 -0500
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3028B801E72;
	Wed,  4 Dec 2019 09:32:24 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-154.ams2.redhat.com [10.36.116.154])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 8747519C68;
	Wed,  4 Dec 2019 09:32:23 +0000 (UTC)
Subject: Re: [edk2-devel] Public-Service-Announcement: send-email issues with Git 2.22.0+
To: devel@edk2.groups.io, nathaniel.l.desimone@intel.com
References: <02A34F284D1DA44BB705E61F7180EF0AB5C14981@ORSMSX114.amr.corp.intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <29f5334f-8f6d-b873-aac1-d30ad161ca4e@redhat.com>
Date: Wed, 4 Dec 2019 10:32:22 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <02A34F284D1DA44BB705E61F7180EF0AB5C14981@ORSMSX114.amr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-MC-Unique: E0WHZXdwMsOYiiGBWQ_ClQ-1
X-Mimecast-Spam-Score: 0
Content-Language: en-US
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 12/04/19 05:31, Nate DeSimone wrote:
> Hi Everyone,
> 
> I have been dealing with a very frustrating issue recently where all of my "CR LF" line endings get erroneously converted into "LF LF" once I send my patch to the mailing list. I have discovered the root cause for this problem. The issue is the following commit to git itself:
> 
> https://github.com/git/git/commit/5983ddc165221c3ec2a4299b65cfb2ecc1ce7765
> 
> This change is present in git version 2.20.0 or later, per the release notes:
> 
> https://github.com/git/git/blob/v2.22.0/Documentation/RelNotes/2.22.0.txt
> 
> With this change, if you leave sendemail.transferEncoding set to the default value of "auto", then git will inspect the body of your email. If it finds a '\r' character in the message, then it converts the entire message content into Quoted-Printable encoding. It appears that when groups.io converts the QP encoding back to text format, the '\r' characters somehow become '\n'. To workaround this make sure to set the following configuration option:
> 
> git config --global sendemail.transferEncoding 8bit
> 
> This will prevent send-email from converting the message into QP encoding, allowing the patches to pass through to the mailing list unharmed. Hope that saves other people a few hours of frustration.

Thanks!
Laszlo