From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ma1-aaemail-dr-lapp03.apple.com (ma1-aaemail-dr-lapp03.apple.com [17.171.2.72]) by mx.groups.io with SMTP id smtpd.web10.13996.1594224186642958057 for ; Wed, 08 Jul 2020 09:03:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@apple.com header.s=20180706 header.b=aR8xZgJ0; spf=pass (domain: apple.com, ip: 17.171.2.72, mailfrom: afish@apple.com) Received: from pps.filterd (ma1-aaemail-dr-lapp03.apple.com [127.0.0.1]) by ma1-aaemail-dr-lapp03.apple.com (8.16.0.42/8.16.0.42) with SMTP id 068G2Aof020212; Wed, 8 Jul 2020 09:03:02 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=from : message-id : content-type : mime-version : subject : date : in-reply-to : cc : to : references; s=20180706; bh=uq2UgXOoJMo38UpQy9t2Uqkp1xmxwKtKsZSCl9UTUJg=; b=aR8xZgJ0tB6Eau/jC5vJfASo0jzx15jB3KTdLvkue2pq61zrObRAXiX7Soh63jf1ocvS Jeshe/opQiuoa6PO/1AlOR/xUWQwVMgxdAj2McBlnBsonfLiWfcOH0ycRH9YiNYtIyIG HJCm4ZaugL+Fhg4q19nnm0lSs+GoIYxrbuLGeJwdDFORhXNsJqVyMfBW7wXt46B9Scll Kn2fcMIkx8RpdJaOgykBkmRQqftsptBUIrZ5ZjHaHgftIJ4Uw79wcZnzAzVJeHTtTAg7 NwCf6ilNN90TSeHFnsDdvHyg9hqp0xv70MLPx3YBE42sOeiRmI4I5J4i/vn3lVefbo5G 0Q== Received: from rn-mailsvcp-mta-lapp03.rno.apple.com (rn-mailsvcp-mta-lapp03.rno.apple.com [10.225.203.151]) by ma1-aaemail-dr-lapp03.apple.com with ESMTP id 322rrwtdsm-9 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Wed, 08 Jul 2020 09:03:02 -0700 Received: from rn-mailsvcp-mmp-lapp01.rno.apple.com (rn-mailsvcp-mmp-lapp01.rno.apple.com [17.179.253.14]) by rn-mailsvcp-mta-lapp03.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPS id <0QD5000U2R91JEF0@rn-mailsvcp-mta-lapp03.rno.apple.com>; Wed, 08 Jul 2020 09:03:01 -0700 (PDT) Received: from process_milters-daemon.rn-mailsvcp-mmp-lapp01.rno.apple.com by rn-mailsvcp-mmp-lapp01.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) id <0QD500000QX6GN00@rn-mailsvcp-mmp-lapp01.rno.apple.com>; Wed, 08 Jul 2020 09:03:01 -0700 (PDT) X-Va-A: X-Va-T-CD: e0acb9dc03d22e4581b62f3d752335f3 X-Va-E-CD: adfca8f3d6e4981c8b8f11998074b6fc X-Va-R-CD: 852fabb7bcee8e144af12996d825685a X-Va-CD: 0 X-Va-ID: a799420c-8df6-4be5-a48b-4e3a1e38a0dc X-V-A: X-V-T-CD: e0acb9dc03d22e4581b62f3d752335f3 X-V-E-CD: adfca8f3d6e4981c8b8f11998074b6fc X-V-R-CD: 852fabb7bcee8e144af12996d825685a X-V-CD: 0 X-V-ID: 5f1cf2b8-17a7-497c-b810-26aa103d9db7 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-07-08_13:2020-07-08,2020-07-08 signatures=0 Received: from [17.235.22.2] (unknown [17.235.22.2]) by rn-mailsvcp-mmp-lapp01.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPSA id <0QD500ES0R8Y3M00@rn-mailsvcp-mmp-lapp01.rno.apple.com>; Wed, 08 Jul 2020 09:03:00 -0700 (PDT) From: "Andrew Fish" Message-id: <2A448161-9916-4CC1-A13E-BE3CDC3308AC@apple.com> MIME-version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools/Conf: Remove C-Code-File.AcpiTable rule Date: Wed, 08 Jul 2020 09:02:58 -0700 In-reply-to: Cc: Laszlo Ersek , "bob.c.feng@intel.com" , "liming.gao@intel.com" , nd To: edk2-devel-groups-io , pierre.gondois@arm.com References: <20200625081922.66596-1-pierre.gondois@arm.com> <8a2134d9-eff9-2e39-02a3-df1211db349c@redhat.com> X-Mailer: Apple Mail (2.3608.80.23.2.2) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-07-08_13:2020-07-08,2020-07-08 signatures=0 Content-type: multipart/alternative; boundary="Apple-Mail=_36C600F6-F93D-42F2-9D9F-D4DA2A092469" --Apple-Mail=_36C600F6-F93D-42F2-9D9F-D4DA2A092469 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jun 25, 2020, at 3:44 AM, PierreGondois wrot= e: >=20 > Hello Laszlo, > I couldn't find any trace of a ".act" file being created/deleted/modifie= d in edk2 or edk2-platforms. I guess the whole f0373115cc9c commit could be= reverted. > f0373115cc9c commit was authored by "lgao4". Maybe Liming will know more= about it. >=20 Pierre, I=E2=80=99ve got non open source platforms that use *.act file extension.= =20 My guess is ?.act was in use for Adaptive Differential Pulse Code Modulati= on compressed audio files and maybe it was inconvenient, so ?.aslc got adde= d. Seems like at some point in the past .act audio files were popular in Ch= ina so maybe clicking on a *.act file launches an audio player vs. a text e= ditor.=20 In general my preference would be to not change supported exte= nsions as that could break other projects that depend on the edk2 build sys= tem. Given [C-Code-File.AcpiTable] is unreachable (and does not support Xco= de :) ) it would make sense to remove that.=20 My guess is ?.aslc got added and the edk2 got cleaned up, but other projec= ts probably based themselves on older projects that used ?.act files and co= pied them over and modified them, but never got around to updating the exte= nsion? Thanks, Andrew Fish > Regards, > Pierre >=20 > -----Original Message----- > From: Laszlo Ersek >=20 > Sent: Thursday, June 25, 2020 11:01 AM > To: devel@edk2.groups.io ; Pierre Gondois <= Pierre.Gondois@arm.com > > Cc: bob.c.feng@intel.com ; liming.gao@intel= .com ; nd > > Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools/Conf: Remove C-Code-F= ile.AcpiTable rule >=20 > On 06/25/20 10:19, PierreGondois wrote: >> From: Pierre Gondois >>=20 >> When trying to build a module with the MODULE_TYPE set to: >> MODULE_TYPE =3D AcpiTable >>=20 >> the build fails with the following error: >> [ModulePath].inf(-1): error 3001: MODULE_TYPE AcpiTable is not=20 >> supported for EDK II, valid values are: >> BASE SEC PEI_CORE PEIM DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER >> DXE_SAL_DRIVER DXE_SMM_DRIVER UEFI_DRIVER UEFI_APPLICATION >> USER_DEFINED HOST_APPLICATION SMM_CORE MM_STANDALONE >> MM_CORE_STANDALONE >>=20 >> Indeed, the "SUP_MODULE_LIST" variable available in=20 >> edk2/BaseTools/Source/Python/Common/DataType.py does not include any=20 >> "AcpiTable". >> The "C-Code-File.AcpiTable" rule described in=20 >> edk2/BaseTools/Conf/build_rule.template might be outdated. >> Plus there is no mention of "AcpiTable" module in the INF=20 >> specification. >>=20 >> Signed-off-by: Pierre Gondois >> --- >>=20 >> The changes can be seen at:=20 >> https://github.com/PierreARM/edk2/commits/831_Remove_C_AcpiTable_build >> _rule_v1 >>=20 >> Notes: >> v1: >> - Remove AcpiTable rule. [Pierre] >>=20 >> BaseTools/Conf/build_rule.template | 20 -------------------- >> 1 file changed, 20 deletions(-) >>=20 >> diff --git a/BaseTools/Conf/build_rule.template=20 >> b/BaseTools/Conf/build_rule.template >> index=20 >> 0822b681fcd9f61c6508e6f93ffc31fa70fd7059..32984eb3f33fd9d110da54975fc9 >> 0325addb8ecc 100755 >> --- a/BaseTools/Conf/build_rule.template >> +++ b/BaseTools/Conf/build_rule.template >> @@ -437,26 +437,6 @@ >> "$(ASL)" $(ASL_FLAGS) $(ASL_OUTFLAGS)${dst} $(OUTPUT_DIR)(+)${s= _dir}(+)${s_base}.iiii >> -AmlToHex $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.aml >>=20 >> -[C-Code-File.AcpiTable] >> - >> - ?.c >> - >> - >> - $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.acpi >> - >> - >> - $(MAKE_FILE) >> - >> - >> - "$(ASLCC)" $(DEPS_FLAGS) /Fo$(OUTPUT_DIR)(+)${s_dir}(+)${s_bas= e}.obj $(ASLCC_FLAGS) $(DEPS_FLAGS) $(INC) ${src} >> - "$(ASLDLINK)" /OUT:$(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(= ASLDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj >> - "$(GENFW)" -o ${dst} -c $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.d= ll $(GENFW_FLAGS) >> - >> - >> - "$(ASLCC)" $(DEPS_FLAGS) -c -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_= base}.obj $(CC_FLAGS) $(ASLCC_FLAGS) $(DEPS_FLAGS) $(INC) ${src} >> - "$(ASLDLINK)" -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(AS= LDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj >> - "$(GENFW)" -o ${dst} -c $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.d= ll $(GENFW_FLAGS) >> - >> [Acpi-Table-Code-File] >> >> ?.aslc, ?.act >>=20 >=20 > Should we remove "?.act" from under "Acpi-Table-Code-File", too? >=20 > Because, if you run "git-blame" on the file, the code being removed come= s originally from commit f0373115cc9c ("Add the special build rule for Acpi= Table C Source file.", 2008-09-01). And that commit added "?.act" under "Ac= pi-Table-Code-File". >=20 > (I don't know if the "?.act" addition in that commit was due to bad patc= h structuring (i.e., if it was unrelated to AcpiTable modules, and should h= ave been a separate patch), or somehow indeed related to AcpiTable modules.= The commit doesn't explain.) >=20 > Thanks > Laszlo >=20 >=20 >=20 --Apple-Mail=_36C600F6-F93D-42F2-9D9F-D4DA2A092469 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On Jun 25, 2= 020, at 3:44 AM, PierreGondois <pierre.gondois@arm.com> wrote:

Hello Laszlo,
I couldn't find any trace of a ".act"= file being created/deleted/modified in edk2 or edk2-platforms. I guess the= whole f0373115cc9c commit could be reverted.
f0373115cc9c commit was authored by "lgao4". Maybe L= iming will know more about it.


Pierre,

I=E2=80=99ve = got non open source platforms that use *.act file extension. 

My guess is ?.act was in use for Adaptive = Differential Pulse Code Modulation compressed audio files and maybe it was = inconvenient, so ?.aslc got added. Seems like at some point in the past .ac= t audio files were popular in China so maybe clicking on a *.act file launc= hes an audio player vs. a text editor. 

In general my preference would be to not change supported <InputFi= le> extensions as that could break other projects that depend on the edk= 2 build system. Given [C-Code-File.AcpiTable] is unreachable (and does= not support Xcode :) ) it would make sense to remove that. 

My guess is ?.aslc got added and the edk2 got cl= eaned up, but other projects probably based themselves on older projects th= at used ?.act files and copied them over and modified them, but never got a= round to updating the extension?

Thanks= ,

Andrew Fish

=

<= span style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size:= 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; = letter-spacing: normal; text-align: start; text-indent: 0px; text-transform= : none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: = 0px; text-decoration: none; float: none; display: inline !important;" class= = =3D"">Regards,
Pierre<= /span>

-----Original Message-----
From: Laszlo Ersek <lersek@redhat.com= > Sent: Thursday, June 25, 2020 1= 1:01 AM
To: devel@edk2.group= s.io; Pierre Gondois <Pierre.Gondois@arm.= com>
Cc:=  bob.c.= feng@intel.com; liming.gao@intel.com; nd <nd@ar= m.com>
Su= bject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools/Conf: Remove C-Code-File.A= cpiTable rule

On 06/25/20 10:19, PierreGondois wrote:
From: Pierre Go= ndois <pierre.gondo= is@arm.com>

When trying to build a modu= le with the MODULE_TYPE set to:
 MODULE_TYPE =3D AcpiTab= le

the build fails with the following error:[ModulePath].inf(-1): error 3001: MODULE_TYPE AcpiTable is not=  
supported= for EDK II, valid values are:
BASE SEC PEI_CORE PEIM DXE_COR= E DXE_DRIVER DXE_RUNTIME_DRIVER  
DXE_SAL_DRIVER DXE_SMM= _DRIVER UEFI_DRIVER UEFI_APPLICATION  
USER_DEFINED HOST= _APPLICATION SMM_CORE MM_STANDALONE  
MM_CORE_STANDALONE=

Indeed, the "SUP_MODULE_LIST" variable availa= ble in 
edk= 2/BaseTools/Source/Python/Common/DataType.py does not include any 
"AcpiTable".
The "C-Code-File.AcpiTable" rule described in 
edk2/BaseTools/Conf/build_rule.= template might be outdated.
Plus there is no mention of "Acpi= Table" module in the INF =
specification.

Signed-off-by: P= ierre Gondois <pier= re.gondois@arm.com>
---

T= he changes can be seen at: 
https://github.com/PierreARM/edk2/commi= ts/831_Remove_C_AcpiTable_build
_rule_v1
Notes:
   v1:
 = ;   - Remove AcpiTable rule. [Pierre]

BaseTools/Conf/build_rule.template | 20 --------------------
1 file changed, 20 deletions(-)

diff --= git a/BaseTools/Conf/build_rule.template 
b/BaseTools/Conf/build_rule.template
index 
0822b681fcd9f61c6508e6f93ffc31fa70fd7059..32984eb3f33fd9d110da54975fc90325addb8ecc 100755
--- a/BaseTools/Conf/build_r= ule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -437,26 +437,6 @@
     &nb= sp;  "$(ASL)" $(ASL_FLAGS) $(ASL_OUTFLAGS)${dst} $(OUTPUT_DIR)(+)= ${s_dir}(+)${s_base}.iiii
      = ;  -AmlToHex $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.aml

-[C-Code-File.AcpiTable]
-   &nbs= p;<InputFile>
-       &nb= sp;?.c
-
-    <OutputFile>=
-        $(OUTPUT_DIR)(+)= ${s_dir}(+)${s_base}.acpi
-
-    = ;<ExtraDependency>
-      &nbs= p; $(MAKE_FILE)
-
-    <= Command.MSFT, Command.INTEL>
-     &nb= sp;  "$(ASLCC)" $(DEPS_FLAGS) /Fo$(OUTPUT_DIR)(+)${s_dir}(+)${s_b= ase}.obj $(ASLCC_FLAGS) $(DEPS_FLAGS) $(INC) ${src}
-  &= nbsp;     "$(ASLDLINK)" /OUT:$(OUTPUT_DIR)(+)${s_d= ir}(+)${s_base}.dll $(ASLDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.= obj
-        "$(GENFW)" -o= ${dst} -c $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(GENFW_FLAGS)
-
-    <Command.GCC>
-        "$(ASLCC)" $(DEPS_FLAGS) -c -= o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj $(CC_FLAGS) $(ASLCC_FLAGS) $(DEP= S_FLAGS) $(INC) ${src}
-       =  "$(ASLDLINK)" -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(ASLDLINK_= FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj
-   = ;     "$(GENFW)" -o ${dst} -c $(OUTPUT_DIR)(+)${s_= dir}(+)${s_base}.dll $(GENFW_FLAGS)
-
[Acpi-Tab= le-Code-File]
    <InputFile>
        ?.aslc, ?.act


Should we remove "?.act" from under "Acpi-Table-Code-File", too?

Because, if you run "git-blame" on the file, the code being = removed comes originally from commit f0373115cc9c ("Add the special build r= ule for AcpiTable C Source file.", 2008-09-01). And that commit added "?.ac= t" under "Acpi-Table-Code-File".

(I don't know if the "?.ac= t" addition in that commit was due to bad patch structuring (i.e., if it wa= s unrelated to AcpiTable modules, and should have been a separate patch), o= r somehow indeed related to AcpiTable modules. The commit doesn't explain.)=

Thanks
Laszlo



--Apple-Mail=_36C600F6-F93D-42F2-9D9F-D4DA2A092469--