public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Pranav Madhu <Pranav.Madhu@arm.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Leif Lindholm <leif@nuviainc.com>, nd <nd@arm.com>
Subject: Re: [edk2-platforms][PATCH V2 2/6] Platform/Sgi: fix the list of CPU devices on RD-V1-MC platform
Date: Mon, 12 Apr 2021 11:21:10 +0000	[thread overview]
Message-ID: <2C730F05-59C9-4675-9805-632BD984B634@arm.com> (raw)
In-Reply-To: <20210401053543.17308-3-pranav.madhu@arm.com>

Hi Pranav,

Thank you for this patch.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 01/04/2021, 06:36, "Pranav Madhu" <pranav.madhu@arm.com> wrote:

    RD-V1-MC platform has four CPUs in each of its four coherently connected
    chips. So remove a incorrect CPU device entry in DSDT table that lists a
    additional non-existent CPU.

    Signed-off-by: Pranav Madhu <pranav.madhu@arm.com>
    ---
     Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl | 6 ------
     1 file changed, 6 deletions(-)

    diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl b/Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl
    index aef6473857b0..9bf57d05a646 100644
    --- a/Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl
    +++ b/Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl
    @@ -109,11 +109,5 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARMSGI",
           Name (_UID, 15)
           Name (_STA, 0xF)
         }
    -
    -    Device (CP16) { // Zeus core 16
    -      Name (_HID, "ACPI0007")
    -      Name (_UID, 16)
    -      Name (_STA, 0xF)
    -    }
       } // Scope(_SB)
     }
    -- 
    2.17.1



  reply	other threads:[~2021-04-12 11:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01  5:35 [edk2-platforms][PATCH V2 0/6] Platform/Sgi: improvements in RD platform support Pranav Madhu
2021-04-01  5:35 ` [edk2-platforms][PATCH V2 1/6] Platform/Sgi: include SSDT table for RD-V1 platform Pranav Madhu
2021-04-01  5:35 ` [edk2-platforms][PATCH V2 2/6] Platform/Sgi: fix the list of CPU devices on RD-V1-MC platform Pranav Madhu
2021-04-12 11:21   ` Sami Mujawar [this message]
2021-04-01  5:35 ` [edk2-platforms][PATCH V2 3/6] Platform/Sgi: fix CPU acpi-id for " Pranav Madhu
2021-04-12 11:21   ` Sami Mujawar
2021-04-01  5:35 ` [edk2-platforms][PATCH V2 4/6] Platform/Sgi: update ACPI table revision Pranav Madhu
2021-04-01  5:35 ` [edk2-platforms][PATCH V2 5/6] Platform/Sgi: define PCD for timer interrupt numbers Pranav Madhu
2021-04-12 11:21   ` Sami Mujawar
2021-04-01  5:35 ` [edk2-platforms][PATCH V2 6/6] Platform/Sgi: add SMMU and timer entries to memory description table Pranav Madhu
2021-04-12 11:21   ` Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2C730F05-59C9-4675-9805-632BD984B634@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox