From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Leif Lindholm <quic_llindhol@quicinc.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Ard Biesheuvel" <ardb+tianocore@kernel.org>, nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: fix typo in Arm SetJump
Date: Tue, 3 Oct 2023 11:22:26 +0000 [thread overview]
Message-ID: <2DFCF010-6B09-4F93-827B-41F4352154C9@arm.com> (raw)
In-Reply-To: <20231003103918.450453-1-quic_llindhol@quicinc.com>
Hi Leif,
Thank you for this fix.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 03/10/2023, 11:39, "Leif Lindholm" <quic_llindhol@quicinc.com <mailto:quic_llindhol@quicinc.com>> wrote:
RO -> R0
Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com <mailto:quic_llindhol@quicinc.com>>
Reported-by: Philippe Mathieu-Daudé <philmd@linaro.org <mailto:philmd@linaro.org>>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org <mailto:ardb+tianocore@kernel.org>>
Cc: Sami Mujawar <sami.mujawar@arm.com <mailto:sami.mujawar@arm.com>>
---
MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
index 15eb3dc28fb7..f89cfa231bbc 100644
--- a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
+++ b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
@@ -33,7 +33,7 @@
SetJump
MOV R3, R13
STM R0, {R3-R12,R14}
- MOV RO, #0
+ MOV R0, #0
BX LR
;/**
--
2.30.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109278): https://edk2.groups.io/g/devel/message/109278
Mute This Topic: https://groups.io/mt/101731199/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-10-03 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 10:39 [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: fix typo in Arm SetJump Leif Lindholm
2023-10-03 11:22 ` Sami Mujawar [this message]
2023-10-03 11:57 ` Leif Lindholm
2023-10-03 12:33 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2DFCF010-6B09-4F93-827B-41F4352154C9@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox