From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=17.151.62.68; helo=nwk-aaemail-lapp03.apple.com; envelope-from=afish@apple.com; receiver=edk2-devel@lists.01.org Received: from nwk-aaemail-lapp03.apple.com (nwk-aaemail-lapp03.apple.com [17.151.62.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A2833211DBDEF for ; Wed, 13 Mar 2019 07:11:34 -0700 (PDT) Received: from pps.filterd (nwk-aaemail-lapp03.apple.com [127.0.0.1]) by nwk-aaemail-lapp03.apple.com (8.16.0.27/8.16.0.27) with SMTP id x2DE1vnP053748; Wed, 13 Mar 2019 07:11:33 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=mime-version : content-type : sender : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=20180706; bh=km/6Zu4Sh1jqzFmM2xb62Uk9k6M5+V+xoQrEElr5Ii0=; b=vCrcDjYMBBsmTYXTbiP2u3ZJf2S7WfMQjs0qwAtoYOFf+bwUgGfYicbLyIaWlevADxAy jfizaQkN2AhIX9xj1P89KeNnGigl3nvLQI0e+/nvI9Ak1x1c2tmacNIqQHmn25UE3+Ds xrRh3WU6C3EKgZLgPyHAUl0hYCEomvLazgoK56yhfDnW9XwJpL1ND4cNay+RZoJB//rS 9/pHrcIt3JMqO3TW+KZzahBeTeZ+zCGNMPzxl9/f4JrYK0CXaVLOGzY4jjPhGrQORlIX bhw4jBpDYANh5ycLJSYh/3G14oOVvdpqijFJoRuqWoiRQNbkP2f1IJplMToz9uKPMe0g pw== Received: from ma1-mtap-s01.corp.apple.com (ma1-mtap-s01.corp.apple.com [17.40.76.5]) by nwk-aaemail-lapp03.apple.com with ESMTP id 2r4x13m8y4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Wed, 13 Mar 2019 07:11:33 -0700 MIME-version: 1.0 Received: from nwk-mmpp-sz13.apple.com (nwk-mmpp-sz13.apple.com [17.128.115.216]) by ma1-mtap-s01.corp.apple.com (Oracle Communications Messaging Server 8.0.2.3.20181024 64bit (built Oct 24 2018)) with ESMTPS id <0POB001P3638TH20@ma1-mtap-s01.corp.apple.com>; Wed, 13 Mar 2019 07:11:33 -0700 (PDT) Received: from process_milters-daemon.nwk-mmpp-sz13.apple.com by nwk-mmpp-sz13.apple.com (Oracle Communications Messaging Server 8.0.2.3.20181024 64bit (built Oct 24 2018)) id <0POB007005T6YU00@nwk-mmpp-sz13.apple.com>; Wed, 13 Mar 2019 07:11:32 -0700 (PDT) X-Va-A: X-Va-T-CD: e34de0293c2634dfc6f40e0ce6b89986 X-Va-E-CD: 5404bf19811b0c7d4f6265e7543038f1 X-Va-R-CD: 3c8985c6b6f860ae09f3dbe733a404e6 X-Va-CD: 0 X-Va-ID: 7d2c0113-66bb-4b21-8e13-57d103ee9ebf X-V-A: X-V-T-CD: cc8371a471bbf9c5ec8c0c954ebbb01c X-V-E-CD: 5404bf19811b0c7d4f6265e7543038f1 X-V-R-CD: 3c8985c6b6f860ae09f3dbe733a404e6 X-V-CD: 0 X-V-ID: f9126077-2a97-4439-9f8b-4ba8de358b37 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-13_09:,, signatures=0 Received: from [17.234.53.112] (unknown [17.234.53.112]) by nwk-mmpp-sz13.apple.com (Oracle Communications Messaging Server 8.0.2.3.20181024 64bit (built Oct 24 2018)) with ESMTPSA id <0POB00J0F638JD10@nwk-mmpp-sz13.apple.com>; Wed, 13 Mar 2019 07:11:32 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish In-reply-to: <47e72b0d-2257-3149-0741-0a06f3ffde18@gmail.com> Date: Wed, 13 Mar 2019 07:11:28 -0700 Cc: edk2-devel@lists.01.org Message-id: <2E47E189-7FCA-45E4-97AA-77CE13BABF33@apple.com> References: <47e72b0d-2257-3149-0741-0a06f3ffde18@gmail.com> To: "Andrew J. Hutton" X-Mailer: Apple Mail (2.3445.6.18) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-03-13_09:, , signatures=0 Subject: Re: F29 Build Issue. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Mar 2019 14:11:34 -0000 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: quoted-printable Andrew, This looks like a newer warning added in GCC 8 -Wall? BaseTools/Source/C/GenVtf/GenVtf.h:46:#define FIT_SIGNATURE = "_FIT_ "=20 So it looks like the intent is to copy the 8 chars in the string, but = not the NULL. That is the intent of -Werror=3Dstringop-truncation. I think this code needs to replace strncpy with memcpy. Please file a = bugzilla: https://bugzilla.tianocore.org Thanks, Andrew Fish > On Mar 13, 2019, at 6:27 AM, Andrew J. Hutton = wrote: >=20 > Unsure if this is a missing build dependency (since there doesn't = appear to be a check for this) am I missing a make dep or configure step = somewhere? >=20 > This is stock F29, following the website instructions; the make -C = BaseTools/Source/C results in the following errror: >=20 > make[1]: Entering directory = '/home/ajh/KVM/Clover/edk2/BaseTools/Source/C/GenVtf' > cc -c -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror = -Wno-deprecated-declarations -nostdlib -c -g -I .. -I ../Include/Common = -I ../Include/ -I ../Include/IndustryStandard -I ../Common/ -I .. -I . = -I ../Include/X64/ GenVtf.c -o GenVtf.o > GenVtf.c: In function =E2=80=98CreateFitTableAndInitialize=E2=80=99: > GenVtf.c:1473:3: error: =E2=80=98strncpy=E2=80=99 output truncated = before terminating nul copying 8 bytes from a string of the same length = [-Werror=3Dstringop-truncation] > strncpy ((CHAR8 *) &FitStartPtr->CompAddress, FIT_SIGNATURE, 8); = // "_FIT_ " > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > make[1]: *** [../Makefiles/footer.makefile:27: GenVtf.o] Error 1 > make[1]: Leaving directory = '/home/ajh/KVM/Clover/edk2/BaseTools/Source/C/GenVtf' > make: *** [GNUmakefile:73: GenVtf] Error 2 > make: Leaving directory '/home/ajh/KVM/Clover/edk2/BaseTools/Source/C' >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel