public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: "Ni, Ray" <ray.ni@intel.com>, "Lou, Yun" <yun.lou@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Eric" <eric.dong@intel.com>,
	"Kumar, Rahul1" <rahul1.kumar@intel.com>
Subject: Re: [PATCH v1 2/2] UefiCpuPkg/CpuCacheInfoLib: Add new CpuCacheInfoLib.
Date: Fri, 20 Nov 2020 11:56:33 +0100	[thread overview]
Message-ID: <2a19f84f-a539-e316-55cd-2027716f8b08@redhat.com> (raw)
In-Reply-To: <PH0PR11MB493605275C30AEFCD972AF4B8CFF0@PH0PR11MB4936.namprd11.prod.outlook.com>

On 11/20/20 06:06, Ni, Ray wrote:
> Laszlo,
> The library can be used by code that produces SMBIOS_TABLE_TYPE7 SMBIOS table.

Great information, thank you! Exactly the kind that I wanted to hear.

Please add this sentence to the commit message (either via a v2 posting,
or at merge time, as you see fit).

Thanks!
Laszlo

> It's true that right now such code is not in open source.
> 
> Thanks,
> Ray
> 
>> -----Original Message-----
>> From: Laszlo Ersek <lersek@redhat.com>
>> Sent: Thursday, November 19, 2020 5:52 PM
>> To: Lou, Yun <yun.lou@intel.com>; devel@edk2.groups.io
>> Cc: Ni, Ray <ray.ni@intel.com>; Dong, Eric <eric.dong@intel.com>; Kumar, Rahul1 <rahul1.kumar@intel.com>
>> Subject: Re: [PATCH v1 2/2] UefiCpuPkg/CpuCacheInfoLib: Add new CpuCacheInfoLib.
>>
>> On 11/19/20 03:36, jasonlouyun wrote:
>>> This library uses a platform agnostic algorithm to get CPU cache
>>> information. It provides user with an API(GetCpuCacheInfo) to get
>>> detailed CPU cache information by each package, each core type
>>> included in this package, and each cache level & type.
>>>
>>> Signed-off-by: Jason Lou <yun.lou@intel.com>
>>> Cc: Ray Ni <ray.ni@intel.com>
>>> Cc: Eric Dong <eric.dong@intel.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Rahul Kumar <rahul1.kumar@intel.com>
>>> ---
>>>  UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c         | 602 ++++++++++++++++++++
>>>  UefiCpuPkg/Library/CpuCacheInfoLib/DxeCpuCacheInfoLib.c      | 131 +++++
>>>  UefiCpuPkg/Library/CpuCacheInfoLib/PeiCpuCacheInfoLib.c      | 130 +++++
>>>  UefiCpuPkg/Include/Library/CpuCacheInfoLib.h                 |  68 +++
>>>  UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.uni       |  15 +
>>>  UefiCpuPkg/Library/CpuCacheInfoLib/DxeCpuCacheInfoLib.inf    |  43 ++
>>>  UefiCpuPkg/Library/CpuCacheInfoLib/InternalCpuCacheInfoLib.h |  64 +++
>>>  UefiCpuPkg/Library/CpuCacheInfoLib/PeiCpuCacheInfoLib.inf    |  43 ++
>>>  UefiCpuPkg/UefiCpuPkg.dec                                    |   3 +
>>>  UefiCpuPkg/UefiCpuPkg.dsc                                    |   4 +
>>>  10 files changed, 1103 insertions(+)
>>
>> I defer this review to the other UefiCpuPkg reviewers / maintainers.
>>
>> Two superficial suggestions:
>>
>> - please file a TianoCore feature request BZ, and reference it in the
>> commit messages in this series
>>
>> - *at least one* of the commit message and the bugzilla ticket, but
>> preferably both, should describe the use case. In other words, what
>> platforms intend to use the new library (especially if they are open
>> source in edk2-platforms or otherwise), and what use cases will benefit
>> from having cache information.
>>
>> Otherwise, this library is just dead code in edk2. I don't insist that
>> the consumers of this library be open source, but I do insist that
>> *something* be publicly explained about the use case.
>>
>> Thanks
>> Laszlo
> 


  reply	other threads:[~2020-11-20 10:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19  2:36 [PATCH v1 1/2] MdePkg/Cpuid.h: Add CPUID_HYBRID_INFORMATION Leaf(0x1A) jasonlouyun
2020-11-19  2:36 ` [PATCH v1 2/2] UefiCpuPkg/CpuCacheInfoLib: Add new CpuCacheInfoLib jasonlouyun
2020-11-19  9:52   ` Laszlo Ersek
2020-11-20  5:06     ` Ni, Ray
2020-11-20 10:56       ` Laszlo Ersek [this message]
2020-12-01  7:57   ` Ni, Ray
2020-11-20  5:45 ` 回复: [PATCH v1 1/2] MdePkg/Cpuid.h: Add CPUID_HYBRID_INFORMATION Leaf(0x1A) gaoliming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a19f84f-a539-e316-55cd-2027716f8b08@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox