From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web09.23566.1605869801349427049 for ; Fri, 20 Nov 2020 02:56:41 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=TGZ/wLss; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605869800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W73l/1CvtsPkZIu2Gd8bV8GgEEVb80CKqfSVEYICqQA=; b=TGZ/wLssOQnF7T/6rvSd4HrcHDpXoW3A8mTG2mbddBD12u/uYas9Q6+gwAtqFMJsVuktxN iw6q5Y7l/YiSLQVq8UthOETJF7arQwS2CUN7QBM/9w1qTwHe0xbFIt+ulm4zDDlO+dgDss 1fSgD1CBNh0bxn7Qj5imXj7sdtwmrpU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-467-IdWcPNDBMJmLpW5thfhEvg-1; Fri, 20 Nov 2020 05:56:38 -0500 X-MC-Unique: IdWcPNDBMJmLpW5thfhEvg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A2CBB801B13; Fri, 20 Nov 2020 10:56:36 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-10.ams2.redhat.com [10.36.115.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3AF385D9C6; Fri, 20 Nov 2020 10:56:34 +0000 (UTC) Subject: Re: [PATCH v1 2/2] UefiCpuPkg/CpuCacheInfoLib: Add new CpuCacheInfoLib. To: "Ni, Ray" , "Lou, Yun" , "devel@edk2.groups.io" Cc: "Dong, Eric" , "Kumar, Rahul1" References: <20201119023658.926-1-yun.lou@intel.com> <20201119023658.926-2-yun.lou@intel.com> <6d4f24d4-5433-184d-7c24-7413af22dcdb@redhat.com> From: "Laszlo Ersek" Message-ID: <2a19f84f-a539-e316-55cd-2027716f8b08@redhat.com> Date: Fri, 20 Nov 2020 11:56:33 +0100 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/20/20 06:06, Ni, Ray wrote: > Laszlo, > The library can be used by code that produces SMBIOS_TABLE_TYPE7 SMBIOS table. Great information, thank you! Exactly the kind that I wanted to hear. Please add this sentence to the commit message (either via a v2 posting, or at merge time, as you see fit). Thanks! Laszlo > It's true that right now such code is not in open source. > > Thanks, > Ray > >> -----Original Message----- >> From: Laszlo Ersek >> Sent: Thursday, November 19, 2020 5:52 PM >> To: Lou, Yun ; devel@edk2.groups.io >> Cc: Ni, Ray ; Dong, Eric ; Kumar, Rahul1 >> Subject: Re: [PATCH v1 2/2] UefiCpuPkg/CpuCacheInfoLib: Add new CpuCacheInfoLib. >> >> On 11/19/20 03:36, jasonlouyun wrote: >>> This library uses a platform agnostic algorithm to get CPU cache >>> information. It provides user with an API(GetCpuCacheInfo) to get >>> detailed CPU cache information by each package, each core type >>> included in this package, and each cache level & type. >>> >>> Signed-off-by: Jason Lou >>> Cc: Ray Ni >>> Cc: Eric Dong >>> Cc: Laszlo Ersek >>> Cc: Rahul Kumar >>> --- >>> UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c | 602 ++++++++++++++++++++ >>> UefiCpuPkg/Library/CpuCacheInfoLib/DxeCpuCacheInfoLib.c | 131 +++++ >>> UefiCpuPkg/Library/CpuCacheInfoLib/PeiCpuCacheInfoLib.c | 130 +++++ >>> UefiCpuPkg/Include/Library/CpuCacheInfoLib.h | 68 +++ >>> UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.uni | 15 + >>> UefiCpuPkg/Library/CpuCacheInfoLib/DxeCpuCacheInfoLib.inf | 43 ++ >>> UefiCpuPkg/Library/CpuCacheInfoLib/InternalCpuCacheInfoLib.h | 64 +++ >>> UefiCpuPkg/Library/CpuCacheInfoLib/PeiCpuCacheInfoLib.inf | 43 ++ >>> UefiCpuPkg/UefiCpuPkg.dec | 3 + >>> UefiCpuPkg/UefiCpuPkg.dsc | 4 + >>> 10 files changed, 1103 insertions(+) >> >> I defer this review to the other UefiCpuPkg reviewers / maintainers. >> >> Two superficial suggestions: >> >> - please file a TianoCore feature request BZ, and reference it in the >> commit messages in this series >> >> - *at least one* of the commit message and the bugzilla ticket, but >> preferably both, should describe the use case. In other words, what >> platforms intend to use the new library (especially if they are open >> source in edk2-platforms or otherwise), and what use cases will benefit >> from having cache information. >> >> Otherwise, this library is just dead code in edk2. I don't insist that >> the consumers of this library be open source, but I do insist that >> *something* be publicly explained about the use case. >> >> Thanks >> Laszlo >