From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.91]) by mx.groups.io with SMTP id smtpd.web09.9165.1633598051205034631 for ; Thu, 07 Oct 2021 02:14:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@os.amperecomputing.com header.s=selector2 header.b=lY7GJ0C0; spf=pass (domain: os.amperecomputing.com, ip: 40.107.236.91, mailfrom: nhi@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HlPD9SM3taB33KP3i7+zeuE9N/jUWY6iaPNojhGZf7YlIswjrq28CcxNbk6zjsQuh7Jh9oDvImcinyZcNa4jqkow0tWd6onxPXK1lmMThzwAaV/P2gfdKrAknIclIseoIQQA5Ee5a1XLL+owtjJyHh3eIczqBpnq/TZEIvfnsF+HKiXDIO9gm8N+AwNUKplTHLecFyGRrrqurMDsH2Ul0pO3/gKWz4ilJUR2f8l+GCmRrJOT4ZO8YxrXqrbQ3E2MM5YJBzCj2P4vxxO3djCgJyjTYF6HYaSnxEM1irETNTizOWbQynm3Tc6lc6Aeu5kJuw8hBV2NSSkGF5p2wWaIGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AQpKMUVDn7os1egeeKk7Qpj9rAutWY0M9ZZhVAAv1FQ=; b=YzjkBjR1tzSUkh2xXuADNlrdDOICrld8ulncwNKH7HBWooobduO0pv/V81s//Ba2C4CV+JcWX9xA0jwfUy/a+MIEQb9fm8q+m6e/ht5LrrnQyjOT7t+0QaoefwmJuvS0aY3h4z0LkGxQZxgye99rWtyV3xNcWqKNu5j1ktIw0B/KDWQnqk/9fJXxtr6xceA1ERkJHE6Vmv9n9qeSo5m/lykBLYDinSUOOOYP9W/xKiQ08tCdYyIb3zP1D2mWuECqHiTwexhNm1A2tUjooR1+QzajArVFTvQog7/VsHO36l5JUDPriwl7dmvy/dPGVgQp38AlI1slifki5CgmGWTDsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AQpKMUVDn7os1egeeKk7Qpj9rAutWY0M9ZZhVAAv1FQ=; b=lY7GJ0C003FH1V9QQWOFzBGbqye4ScnVqYCbSqT5wGLojQz9iTcZyV7TXf7Ft4UCWBPjCR3HlBbtj9n4ek4QzUo8XmeRB2OVKf9FW+28GrMhM4ZgwvvcQ1KLrGdVYLoBM3ztvQDC0OuDYqIr6mZleczn8ZROEEXfHk+a7A6GsMM= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=os.amperecomputing.com; Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by PH0PR01MB7460.prod.exchangelabs.com (2603:10b6:510:f3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Thu, 7 Oct 2021 09:14:07 +0000 Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::254c:9533:7f35:aee]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::254c:9533:7f35:aee%4]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021 09:14:07 +0000 Subject: Re: [edk2-devel] [PATCH v3 12/28] AmpereAltraPkg: Add Ac01PcieLib library instance To: Leif Lindholm Cc: devel@edk2.groups.io, patches@amperecomputing.com, vunguyen@os.amperecomputing.com, Thang Nguyen , Chuong Tran , Phong Vo , Michael D Kinney , Ard Biesheuvel , Nate DeSimone References: <20210915155527.8176-1-nhi@os.amperecomputing.com> <20210915155527.8176-13-nhi@os.amperecomputing.com> <20210923134931.gzxueebb4axflhdi@leviathan> <20211005195953.eqmym4dkkkpqatik@leviathan> <20211007090629.uxvy2vghq76tetvd@leviathan> From: "Nhi Pham" Message-ID: <2a70c40c-52db-456d-e387-0fd84d9d9c31@os.amperecomputing.com> Date: Thu, 7 Oct 2021 16:13:54 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20211007090629.uxvy2vghq76tetvd@leviathan> X-ClientProxiedBy: SG2PR06CA0212.apcprd06.prod.outlook.com (2603:1096:4:68::20) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) Return-Path: nhi@os.amperecomputing.com MIME-Version: 1.0 Received: from [IPv6:2405:4802:91b7:33b0:442c:647c:8de4:5a2b] (2405:4802:91b7:33b0:442c:647c:8de4:5a2b) by SG2PR06CA0212.apcprd06.prod.outlook.com (2603:1096:4:68::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22 via Frontend Transport; Thu, 7 Oct 2021 09:14:03 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 32a921f0-68b6-498a-6e43-08d98972d09d X-MS-TrafficTypeDiagnostic: PH0PR01MB7460: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WHViUzxBQAHFHAupjd/GHcA268oY49c/paIu+tNtOUbKebA53tTB8SYtokbTXeE5QCyRjFIpCx8inZ4ToS95EMhsRu3hX25GnVbk7SGUa/Zk4EII0CrxpYEogncZ4Cr7128+fwY3qJ2axg44UGxeEusjdX6LHXUZanm4nnKJvKdOTo/or8fj7M+uTG4E1XYUI17vllOSjSavBCvGwqCeThY0uLVJObNBQ1T7FfwleVMWbljSY+MVbNRD7jq7iFQMiGqHiYhX2Z/oDQonOTjF3Aks7GbIr6wepm57mEDmzWYFOcLeTUKjRoEoqNEheEn6P7wY/EvBWyqtMSHKo1OXnmLqgV6ViQ69acr18C/9kBLkTXMKUhOiANH4ZWFL9f4T4wpw0+jWcH9t14gXm34bghHnKzGmFLKM8a4edZTS2Y+NLzblcgBtDqSSXW9d/XlGKUpQhNbjCVtY6/2G8h9CO4nwKMRoRXqaWbk6ai2th24eK/59J2uV9VMkJRw2K/oiConoPA28mySHxyBvnFYcN7ROy6uu5wMY7tvoFkSFZciLOBcfBHTJ6dTndbZcEOgg2tOG5baxhTCwv4sp+RrZ0YD7UUKBKBUDih8heb6y44UOWSIqrgblLA98yfm1mSbwBNAJeh10tBMO5Sf0mH8iqViz/MSlQGqYNofYTQhd9AxtBKAfOG8hbI+5GaZ/ZeoP1BcDhOnASTsSCcoYs+jGNoaOspcQx3BOlp0OQ5VH4KOTKHiw6qn/m2tk/evv0Ctz X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB7287.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(508600001)(5660300002)(83380400001)(316002)(31686004)(6486002)(2906002)(2616005)(4326008)(6916009)(8676002)(4744005)(66556008)(66946007)(86362001)(38100700002)(6666004)(31696002)(186003)(8936002)(52116002)(54906003)(53546011)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWQxVHdaSW5oUm83Rk5DRFJLeEVpcmcwK1NvVFp5MGwvLzBOU0RTQ1JDQzNZ?= =?utf-8?B?Ry9KZDltQ2NZckFJZXVFSlk4eXZ0WGZuQktyVHd2cmxoV0NWblpCWDB6V0h4?= =?utf-8?B?K01UZEZDQ3gxUVliZHI5OWdiYUZ2SVhQTC9CNE5EUWY1cUhRc1ZoWjBSOVdO?= =?utf-8?B?WEtGQmFxdjF4NW80ZFhMSVlaY0pMVXVZL0hYSCtsVXdicjJpSW5uMXJZcDhL?= =?utf-8?B?aGhMK1czNFdibmJSNnQ4TS82a2lRYXR4TTVndXJETU9pZm9ZZXc0MmVoekxp?= =?utf-8?B?dVZiWDh0MEoxSU9tVmRISXlIcHFjaHpWT1pOVldyckgrcDkwVjdncTV5NVd0?= =?utf-8?B?L1Q5M3ZhK1ZkektBRmpOZEJ1b0ZDbStyZEl4NElSUzhDQUpFQnVXY05xRlF1?= =?utf-8?B?a0N5Qm4rNkI2UVdsOEpYTmxzalEybXZuNVN2a2Qzck9TN3Z5Q2RPQTgrUDRM?= =?utf-8?B?WHB4ejFyNHVjb1ZCb3hlTXo1KzFSRjh0dWw0cWNqZWh3MnFnVVZoWENzTHJj?= =?utf-8?B?L2VpYTNsVUhjcGIzQTVEeHlPRWoxNzB5MWN2eEZncDFZNGJrZUs2cHJPaUtK?= =?utf-8?B?dEUxSHBTVHdiTDhSUy8wWGdveHNOa3BKMTdSdERoeEFTbjh4MVJHQmNpKzVo?= =?utf-8?B?OXVFVE5iYmxrakVETTN2L3hRNEE0eGQrTHczUGZJVk1VNUs1S1VCVCtrcUN1?= =?utf-8?B?WVVyRmZIKzBqVy9nWTBYeVd0aTdiQ2xxNkdTQzVaMjZMOWs0cVVldDdzemgr?= =?utf-8?B?TTFmclVld0R3bzZDcWYyRnRLelpyTnF2SFQ2TGY1emR1azArNkh0UTd1bVdY?= =?utf-8?B?RnZaVUFNMHpGdEFzZGRYT1dmdnJsSWR1Ny9pRTNQV0dOTVg0YjFtVjZEZzBi?= =?utf-8?B?NmhqaVByTG4yampYSU9QWW94ZjRRdERqOUVnV2d1QkluSFl3NzcxTmxyZ3V3?= =?utf-8?B?bGtlTnErcHNwZ1lXdWF0VzhWVEVUWTVidVp5cllNN0JZSEcrKy9yYVFrdGsr?= =?utf-8?B?QmJ3N1pOVlc2eC9aYTA4NVp0N2JXNjZkMVFLMnRqVHFXcXBKd05rdnJJNlVh?= =?utf-8?B?YlJCV1NhR0tKT1hralg2ZUM2a0JFN01ySkJnZGZNcTMxUjlmNng3NDZlb3Fz?= =?utf-8?B?eGJxbTh2M1JuN3V3WmdHdjd5MlZ0NUNoMVFKTjBBWWNrRmNSUm1BUE14aXRE?= =?utf-8?B?NkdJVHdmcDZLR1VlYXo4dHZaVkJIZzR3ZzFybE9oNDRKVWcwOWNRRDFwV0RY?= =?utf-8?B?TG84c0Ric0lpZjVVN1RuSGtscWRzTlpDaFFMcGQ1SGZuMHd5OEQ0VXJPcTM3?= =?utf-8?B?U3lSMFlmbXNwT0pVM2FZRnE2dWNEZmRLdUVPQU91ZGw1SzNrMkFRK3o4SitN?= =?utf-8?B?NEJ5UEpKVVROK0szUUIvdU5acGtIM2NDY2F4ZTRlNzB2bGN1WGh4SHJpdVhQ?= =?utf-8?B?WE41KzJNRXFPM3VTcWxMZFduWVpTU2l5UTIyQ0UveWVUMWwySlpwTUtBTnEx?= =?utf-8?B?ZDJ5cHZNYjFRcGhhanZJUUc5SnpPNDZNOENoWXZwSW9aTWgxd3MzWmJXc0hr?= =?utf-8?B?ZEJFaDZlSytmTlNwdUxMbEJzelJDS1ZyWXJiRDZtUzd6VGQrRXlZWE5nSW54?= =?utf-8?B?NjlMQXl4L2tPK3V6OERuaEVyejEyK3FwUGhma3RKd0xGcnNuQkpxVEpYQWZQ?= =?utf-8?B?OENBZDR3TFdDb1JLaWZ1NTBiL2diZHlYdWV2bjlDVnFZbzI3dVNtTzlHNU9H?= =?utf-8?B?WVlWMFRydEUxKzRLcVBtb1NGcHJCRk5SWE5ucU41eEkyVWlMRUZ2NFV1N2NP?= =?utf-8?B?YzVUcXB4czkrbXJQdTZDUU0wSS9BY3lpNE9LUWl0alpCMzZpQ1FGQUp0VXhV?= =?utf-8?Q?ph5umsv6EjOwY?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32a921f0-68b6-498a-6e43-08d98972d09d X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 09:14:07.1111 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WXlEGPNRklY1x4YoqMobxynYnUA0qm32vteJQP1h1j4uZf5XPqiBToovD1XYnwYorUynSQ6K2CalAQ+/Q6NlMhafM+fh6iwv6YtYHwiUJR8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB7460 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 07/10/2021 16:06, Leif Lindholm wrote: > On Wed, Oct 06, 2021 at 19:55:53 +0700, Nhi Pham wrote: >>> Would it be possible for PHYLib to link in ArmArchTimerLib directly >>> and wrap this there instead? Something about this integration just >>> feels kind of backwards to me. >> Thanks Leif. That's great idea. >> >> I will wrap it and re-send the patchset for PHYLib in the edk2-non-osi >> repository as well. > Thanks! > > Actually, if you do that, can you have a look at the coding style of > some the enums in > Silicon/Ampere/AmpereAltraBinPkg/Include/Library/PciePhyLib.h ? > They have enumerations in UPPER_CASE_WITH_UNDERSCORES instead of > CamelCase. Yes, sure. I will fix it. Best regards, Nhi > > I noticed these after giving my r-b, so didn't bother bringing it up, > but if you're refreshing the patch anyway... > > / > Leif