From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.7886.1659712097371670577 for ; Fri, 05 Aug 2022 08:08:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=eO8gyjNI; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 700F820FFE33; Fri, 5 Aug 2022 08:08:15 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 700F820FFE33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1659712096; bh=BhYI9tWrtncyjWK38csfNmOzVBpVDWWmkeLI3JVFtjg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eO8gyjNIZvEWj/MYE30IdxBvo4cubzAGeqrU3vZkcfjQEzjJHpzYrWTOKVoLlv9+0 wQWgiopfIefoeuKkRy1KVdpDZJ06ozFdJWruRODPGyf0PtpqgKJtX7NsmxoxhqvTsE e+xYQgoZEkb2A+RI8tslH7Nb+ZO16j1qXYitURbc= Message-ID: <2a8acbbb-22b8-e9e6-3b1d-ba6ffbcec1bc@linux.microsoft.com> Date: Fri, 5 Aug 2022 11:08:14 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v1 0/5] Add support to build PRM for AARCH64 using GCC To: Sami Mujawar , devel@edk2.groups.io Cc: ardb+tianocore@kernel.org, nathaniel.l.desimone@intel.com, ankit.sinha@intel.com, npham@amperecomputing.com, loc.ho@amperecomputing.com, jose.marinho@arm.com, Samer.El-Haj-Mahmoud@arm.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, nd@arm.com References: <20220803143547.27772-1-sami.mujawar@arm.com> From: "Michael Kubacki" In-Reply-To: <20220803143547.27772-1-sami.mujawar@arm.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Sami, I see you created a PR that is marked as draft with these changes: https://github.com/tianocore/edk2/pull/3167 When you're ready for them to be submitted, if you could please create a non-draft PR with the review tags added, I'd be happy to push it. Thanks, Michael On 8/3/2022 10:35 AM, Sami Mujawar wrote: > This patch series adds support to build PRM for AARCH64 using GCC. > > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/2238_aarch64_prm_support_v1 > > Jose Marinho (5): > Basetools/GenFw: Allow AARCH64 builds to use the --prm flag > PrmPkg: Enable external visibility on PRM symbols > PrmPkg: Build Prm Samples with GCC for AARCH64 > PrmPkg: Support AArch64 builds using GCC > PrmPkg: Add details on AArch64 build to the Readme. > > BaseTools/Source/C/GenFw/Elf64Convert.c | 6 ++--- > PrmPkg/Include/Prm.h | 3 +++ > PrmPkg/PrmPkg.ci.yaml | 1 + > PrmPkg/PrmPkg.dsc | 24 +++++++++++++++++--- > PrmPkg/Readme.md | 11 +++++++++ > PrmPkg/Samples/PrmSampleAcpiParameterBufferModule/PrmSampleAcpiParameterBufferModule.inf | 4 ++++ > PrmPkg/Samples/PrmSampleContextBufferModule/PrmSampleContextBufferModule.inf | 4 ++++ > 7 files changed, 47 insertions(+), 6 deletions(-) >