Re: [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to describe QEMU debug console

[Laszlo Ersek <lersek@redhat.com>]

On 11/16/16 03:10, Liming Gao wrote:
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  OvmfPkg/AcpiTables/AcpiTables.inf | 4 ++++
>  OvmfPkg/AcpiTables/Dsdt.asl       | 2 +-
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/AcpiTables/AcpiTables.inf b/OvmfPkg/AcpiTables/AcpiTables.inf
> index 1187a14..2c604c3 100644
> --- a/OvmfPkg/AcpiTables/AcpiTables.inf
> +++ b/OvmfPkg/AcpiTables/AcpiTables.inf
> @@ -37,4 +37,8 @@
>  
>  [Packages]
>    MdePkg/MdePkg.dec
> +  OvmfPkg/OvmfPkg.dec
> +
> +[Pcd]
> +  gUefiOvmfPkgTokenSpaceGuid.PcdDebugIoPort
>  
> diff --git a/OvmfPkg/AcpiTables/Dsdt.asl b/OvmfPkg/AcpiTables/Dsdt.asl
> index 2c3a314..0397722 100644
> --- a/OvmfPkg/AcpiTables/Dsdt.asl
> +++ b/OvmfPkg/AcpiTables/Dsdt.asl
> @@ -581,7 +581,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 1, "INTEL ", "OVMF    ", 4) {
>              IO (Decode16, 0x278, 0x278, 0x00, 0x08)
>              IO (Decode16, 0x370, 0x370, 0x00, 0x02)
>              IO (Decode16, 0x378, 0x378, 0x00, 0x08)
> -            IO (Decode16, 0x402, 0x402, 0x00, 0x01)        // QEMU debug console, should use FixedPcdGet16 (PcdDebugIoPort)
> +            IO (Decode16, FixedPcdGet16 (PcdDebugIoPort), FixedPcdGet16 (PcdDebugIoPort), 0x00, 0x01)
>              IO (Decode16, 0x440, 0x440, 0x00, 0x10)
>              IO (Decode16, 0x678, 0x678, 0x00, 0x08)
>              IO (Decode16, 0x778, 0x778, 0x00, 0x08)
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Commit ad13d7d2d4a1.

Thank you, Liming!
Laszlo