From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id CDAD281EA0
 for <edk2-devel@ml01.01.org>; Wed, 16 Nov 2016 08:18:08 -0800 (PST)
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
 (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 7DC94C05005E;
 Wed, 16 Nov 2016 16:18:13 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-80.phx2.redhat.com
 [10.3.116.80])
 by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 uAGGICSe016720; Wed, 16 Nov 2016 11:18:12 -0500
To: Liming Gao <liming.gao@intel.com>
References: <1479262207-25836-1-git-send-email-liming.gao@intel.com>
Cc: edk2-devel@ml01.01.org
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <2a98ed18-2ed0-5a49-8a28-5bd9d1917e26@redhat.com>
Date: Wed, 16 Nov 2016 17:18:11 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1479262207-25836-1-git-send-email-liming.gao@intel.com>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.31]); Wed, 16 Nov 2016 16:18:13 +0000 (UTC)
Subject: Re: [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to describe QEMU debug console
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Nov 2016 16:18:08 -0000
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 11/16/16 03:10, Liming Gao wrote:
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  OvmfPkg/AcpiTables/AcpiTables.inf | 4 ++++
>  OvmfPkg/AcpiTables/Dsdt.asl       | 2 +-
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/AcpiTables/AcpiTables.inf b/OvmfPkg/AcpiTables/AcpiTables.inf
> index 1187a14..2c604c3 100644
> --- a/OvmfPkg/AcpiTables/AcpiTables.inf
> +++ b/OvmfPkg/AcpiTables/AcpiTables.inf
> @@ -37,4 +37,8 @@
>  
>  [Packages]
>    MdePkg/MdePkg.dec
> +  OvmfPkg/OvmfPkg.dec
> +
> +[Pcd]
> +  gUefiOvmfPkgTokenSpaceGuid.PcdDebugIoPort
>  
> diff --git a/OvmfPkg/AcpiTables/Dsdt.asl b/OvmfPkg/AcpiTables/Dsdt.asl
> index 2c3a314..0397722 100644
> --- a/OvmfPkg/AcpiTables/Dsdt.asl
> +++ b/OvmfPkg/AcpiTables/Dsdt.asl
> @@ -581,7 +581,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 1, "INTEL ", "OVMF    ", 4) {
>              IO (Decode16, 0x278, 0x278, 0x00, 0x08)
>              IO (Decode16, 0x370, 0x370, 0x00, 0x02)
>              IO (Decode16, 0x378, 0x378, 0x00, 0x08)
> -            IO (Decode16, 0x402, 0x402, 0x00, 0x01)        // QEMU debug console, should use FixedPcdGet16 (PcdDebugIoPort)
> +            IO (Decode16, FixedPcdGet16 (PcdDebugIoPort), FixedPcdGet16 (PcdDebugIoPort), 0x00, 0x01)
>              IO (Decode16, 0x440, 0x440, 0x00, 0x10)
>              IO (Decode16, 0x678, 0x678, 0x00, 0x08)
>              IO (Decode16, 0x778, 0x778, 0x00, 0x08)
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Commit ad13d7d2d4a1.

Thank you, Liming!
Laszlo