From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (EUR02-VE1-obe.outbound.protection.outlook.com [40.107.2.48]) by mx.groups.io with SMTP id smtpd.web09.3776.1631954977856230389 for ; Sat, 18 Sep 2021 01:49:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=wNEAbPtf; spf=pass (domain: arm.com, ip: 40.107.2.48, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+0d1/OUtkjezyWMY7Gb0a2o+5XFuTk5hV8oqwVKqW9c=; b=wNEAbPtfluTgcLe8VRSaLs2pVDcZvDns72lgpymRsgojWiA14Cm11oPCS8bxY8vlBhCZIfMNOe3aye3H3kX/RvNCKkUIM6GMHNON6OfdVN0ddlXuLt1uzMhuEh0xuaVU3zUauXbYJ4eQiq4K+oqplyZXzRaDlT7Ifu1p/NcSvLI= Received: from DB6PR0301CA0097.eurprd03.prod.outlook.com (2603:10a6:6:30::44) by AS8PR08MB6439.eurprd08.prod.outlook.com (2603:10a6:20b:338::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Sat, 18 Sep 2021 08:49:20 +0000 Received: from DB5EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:30:cafe::fa) by DB6PR0301CA0097.outlook.office365.com (2603:10a6:6:30::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Sat, 18 Sep 2021 08:49:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT013.mail.protection.outlook.com (10.152.20.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Sat, 18 Sep 2021 08:49:16 +0000 Received: ("Tessian outbound 010023020eef:v103"); Sat, 18 Sep 2021 08:49:16 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 544a44452290aefc X-CR-MTA-TID: 64aa7808 Received: from 23f831113ce0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2E86CE0F-F231-44B8-A5C1-CF091430E2B3.1; Sat, 18 Sep 2021 08:49:05 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 23f831113ce0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 18 Sep 2021 08:49:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=huxTqyr+wmO6w2URPtrHIweM+KtmFBtNMT7cKIRGHLF042rOi6NOxvLevoOTjOhxcjmZnnaX9r1kOOGUXnNOuMn7six0vvmPeq1svn7EM2i3IG+qWt9Oe8+meeCEaXlo6srozv6tyhS7iN5/FqGHg3cMPT/FGhioUhdNAInwm9G82rrG96loUt7jBv+hSZ8dp8o1ptZD3ERzQmj0ELwkRUsXNRQ0AFQ79IeM2DeYFxzyIGKEtWwiIrKrno1wQXxbeshDGBu8fogZJb8q3qv1Pai/+OVrhfVtEOqwOBCEx2UDxMH+ztOB/IaMPlAvNHgrxKwSBUXafVpHbWAQDjatCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+0d1/OUtkjezyWMY7Gb0a2o+5XFuTk5hV8oqwVKqW9c=; b=W1Tn5DmS2DBed0AeiRd6fVwEuGsc0p9YlEIaoDg6zWbA8btyfp8p92JfhySKDM2PFgf8cpZ46dS9Kx4mHiV8w3uJK3OIaE5MXH/1KFzNO2fLRymLruYXwcf+sla1bLKIlChx2A4wfNa5ozOBND/WX3n8bE27JodpWO9R0M2vlo+evT4rzijQJcobIblnbVNMYgFdX4df8gh1egBPuSO2yDWGMsm9nB4EVJhtPZfqzyO+oEt4c1Gs59wPiNg8hVOTq3w6KEEBR+SK1+lRY2WklnKVLXfQYEaI3TXZIB4Xjxo58Kw0RhrNwB5MyDof5AIWSxnfU9KGS9edm+kyl/+bHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+0d1/OUtkjezyWMY7Gb0a2o+5XFuTk5hV8oqwVKqW9c=; b=wNEAbPtfluTgcLe8VRSaLs2pVDcZvDns72lgpymRsgojWiA14Cm11oPCS8bxY8vlBhCZIfMNOe3aye3H3kX/RvNCKkUIM6GMHNON6OfdVN0ddlXuLt1uzMhuEh0xuaVU3zUauXbYJ4eQiq4K+oqplyZXzRaDlT7Ifu1p/NcSvLI= Authentication-Results-Original: linux.vnet.ibm.com; dkim=none (message not signed) header.d=none;linux.vnet.ibm.com; dmarc=none action=none header.from=arm.com; Received: from AM9PR08MB6802.eurprd08.prod.outlook.com (2603:10a6:20b:308::14) by AM0PR08MB3699.eurprd08.prod.outlook.com (2603:10a6:208:10c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Sat, 18 Sep 2021 08:49:03 +0000 Received: from AM9PR08MB6802.eurprd08.prod.outlook.com ([fe80::4e5:e0a2:3a63:26c7]) by AM9PR08MB6802.eurprd08.prod.outlook.com ([fe80::4e5:e0a2:3a63:26c7%5]) with mapi id 15.20.4523.018; Sat, 18 Sep 2021 08:49:03 +0000 Subject: Re: [RFC PATCH 2/3] ArmVirtPkg: Reference new TPM classes in the build system for compilation To: Stefan Berger , devel@edk2.groups.io Cc: marcandre.lureau@redhat.com, kraxel@redhat.com, jiewen.yao@intel.com, ardb+tianocore@kernel.org, leif@nuviainc.com, Stefan Berger References: <20210916211752.2714332-1-stefanb@linux.ibm.com> <20210916211752.2714332-3-stefanb@linux.ibm.com> From: "Sami Mujawar" Message-ID: <2aa2bea6-d2a9-363c-ce05-2d6dd3c8c2fe@arm.com> Date: Sat, 18 Sep 2021 09:49:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210916211752.2714332-3-stefanb@linux.ibm.com> X-ClientProxiedBy: LO2P265CA0130.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9f::22) To AM9PR08MB6802.eurprd08.prod.outlook.com (2603:10a6:20b:308::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.1.196.43] (217.140.106.53) by LO2P265CA0130.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Sat, 18 Sep 2021 08:49:03 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 02b43ef8-9800-4e29-76f6-08d97a81329c X-MS-TrafficTypeDiagnostic: AM0PR08MB3699:|AS8PR08MB6439: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: eK/VMIa/rXIsd386hWJZjW2HvzgOwB5+bHO8BnplYOmTE/zNtwdI1ygdAxtEvt4j8BiFiqnS3QL9fIql6GZJQ93oBVFDyA4LvVHAFEla82B7T1T095lKQD82clRKtLMB7c2mq/shPsImd6ufw+L+zCSYdoIUgmTMBdK/vqK5SvrCsQEoOaNsVGi99LCCgFgsjj5c3dMTfe9tfcMM2TJz9H+IEDlhp/ajoiksw4dsOWrjJZQsZPYTcPXXUCq6MyjG7i9fluIYXAySsogO/qn32mftUb8zCYuNXSBXP0Ij9otyg80C1o/SzGBkTrlWYY4YI/EfcuTfsx+qBF3+M2qm90UGphMH/GP3lj2fureJc5scpEQgYg4rGmrrbkZP35qmeDS0T+dCG9h1x6DNuEFnPiRDTexeTo813BAVmbrPeQdDMY/k8ohtAvznZPA8kKR4a02BYa1Lv4hZmO24HMWpfj9g7oDCiMxLGqPHXry0RzybFq8Ils2zuRh+7auzIBj1erBAIEZlVG5+XbokymU2ApEgLFZXkNqpInCffwtRdyWbznF56VE4xS4/dyuF8OR4d4PXlvsPn1O0RRK9JWpMeQKkxoT11eXeD0FewIDlMof92lMTu38q+0E4Wk7otB5viDgZ1IfRuze3IMURsUHfZzNpZpH+sVGU50JLvTqYus7T6FbsMWOuNGrcBwk/N3LqjMIk6AUg/GkAgBIvhnEFpe44I4UFQ9c37lgDrqScnNYlQBaSDInAB/aqqZxTQuBN5s+DWeRDnsncc9A//nWRSw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR08MB6802.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(39860400002)(376002)(346002)(396003)(86362001)(956004)(16576012)(8676002)(44832011)(2906002)(2616005)(31686004)(38100700002)(478600001)(31696002)(316002)(4326008)(6666004)(52116002)(6486002)(36756003)(38350700002)(5660300002)(26005)(66946007)(8936002)(186003)(66556008)(83380400001)(53546011)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3699 Original-Authentication-Results: linux.vnet.ibm.com; dkim=none (message not signed) header.d=none;linux.vnet.ibm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: ba839a89-d0d6-436c-ab37-08d97a812a7d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3RvHY+oCy5gVhGpDVphjV2orl8Yq7+uorI7K8A/R2NJ8aet2N56iQf+yoMNI9WIsAOu19MCDHdPTwpMQC2siIg0lZKrbMSOK2G72uKdvVEGvzRctaXdAFFBlEMT8KgwpnPieGB+ccNSBF5i7ukyP0Szuk7V19oQWuTvjU4EyzmN4/V0dinsfrXTFNlXIQcw6FMYEtmpq5wVMiYq7RJ/DD8Ya6DK8QPufEZVEiRO2VewLwzS492Oz9WwO4RniNrzWhBz7zeTlnGRgwVjGUDNGXuHs42IdO6nqft+lWRWQVxjGsXi0RfGx+bzRPET3tfLpBzVCfWPLWWrQeMTff35yrszePoiv2uzPlm6UGBJ3rh1vZwIu3Faj9Q5pozHKRkwsaMAZ/nsZbys1EdpEOunHBe+UFMzppvTWHcB90QuMxkzmKChHBR14JzunuqCAeEBl2P7j/NOUFWr53qu2f3Hyh0niXzLkE9CHcqcgdqbcABA9n9zfcyJMosLLhHdLOL6yjuCJVDR7LJsAe7iUKNgcW+CDA/d/5aaAW7MHiGLD6BzjcyG3Y7ZMi0JVwUzHgld7a0EjLmFUqB9lrrKuiTkLifJx0z11Zq09eyGOhiFJ7ysdLaeNzvbfDjD5ougkMGpyZiB7MFYSILwfIQEXEH4jjbMLCoUytU4OyJ3VL8Egc+z0vz7G3Oi/c2SdnQczPC0nmOv6bO8fAAbIOWFtLdSh7Jgj+6CSO0gIelm3mNOGEQM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(136003)(346002)(376002)(396003)(36840700001)(46966006)(86362001)(478600001)(2906002)(16576012)(53546011)(44832011)(82740400003)(356005)(81166007)(316002)(26005)(5660300002)(31696002)(31686004)(956004)(36860700001)(8676002)(8936002)(186003)(6486002)(6666004)(70206006)(4326008)(336012)(82310400003)(36756003)(70586007)(83380400001)(47076005)(2616005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2021 08:49:16.7950 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 02b43ef8-9800-4e29-76f6-08d97a81329c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6439 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB Hi Stefan, Thank you for this patch. Please find my response inline marked [SAMI]. With that updated, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/09/2021 10:17 PM, Stefan Berger wrote: > From: Stefan Berger [SAMI] Is it possible to add the bugzilla reference here, please? Also it would be very helpful to add the message from the cover letter here as the coverletter would not be part of the patch in git. > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Gerd Hoffmann > Signed-off-by: Stefan Berger > --- > ArmVirtPkg/ArmVirtCloudHv.dsc | 1 + > ArmVirtPkg/ArmVirtQemu.dsc | 2 ++ > ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + > ArmVirtPkg/ArmVirtXen.dsc | 1 + > .../Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + > 5 files changed, 6 insertions(+) > > diff --git a/ArmVirtPkg/ArmVirtCloudHv.dsc b/ArmVirtPkg/ArmVirtCloudHv.ds= c > index f292ba6079..45bf8562e7 100644 > --- a/ArmVirtPkg/ArmVirtCloudHv.dsc > +++ b/ArmVirtPkg/ArmVirtCloudHv.dsc > @@ -55,6 +55,7 @@ > PciHostBridgeUtilityLib|ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilit= yLib/ArmVirtPciHostBridgeUtilityLib.inf > > > > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasu= rementLibNull.inf > > + TpmPlatformHierarchyLib|ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyL= ibNull/PeiDxeTpmPlatformHierarchyLib.inf > > > > !include MdePkg/MdeLibs.dsc.inc > > > > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index 97539edef7..bbe60b1bad 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -86,8 +86,10 @@ > Tpm2CommandLib|SecurityPkg/Library/Tpm2CommandLib/Tpm2CommandLib.inf > > Tcg2PhysicalPresenceLib|OvmfPkg/Library/Tcg2PhysicalPresenceLibQemu/D= xeTcg2PhysicalPresenceLib.inf > > TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeas= urementLib.inf > > + TpmPlatformHierarchyLib|SecurityPkg/Library/PeiDxeTpmPlatformHierarchy= Lib/PeiDxeTpmPlatformHierarchyLib.inf > > !else > > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasu= rementLibNull.inf > > + TpmPlatformHierarchyLib|ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyL= ibNull/PeiDxeTpmPlatformHierarchyLib.inf > > !endif > > > > [LibraryClasses.common.PEIM] > > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKer= nel.dsc > index 28064199c8..d537d9f194 100644 > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > @@ -80,6 +80,7 @@ > PciHostBridgeLib|ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBri= dgeLib.inf > > PciHostBridgeUtilityLib|OvmfPkg/Library/PciHostBridgeUtilityLib/PciHo= stBridgeUtilityLib.inf > > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasu= rementLibNull.inf > > + TpmPlatformHierarchyLib|ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyL= ibNull/PeiDxeTpmPlatformHierarchyLib.inf > > > > [LibraryClasses.common.DXE_DRIVER] > > ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeRe= portStatusCodeLib.inf > > diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc > index 2b07a5ba19..81289e6838 100644 > --- a/ArmVirtPkg/ArmVirtXen.dsc > +++ b/ArmVirtPkg/ArmVirtXen.dsc > @@ -50,6 +50,7 @@ > PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/Platform= BootManagerLib.inf > > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/Custom= izedDisplayLib.inf > > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasu= rementLibNull.inf > > + TpmPlatformHierarchyLib|ArmVirtPkg/Library/PeiDxeTpmPlatformHierarchyL= ibNull/PeiDxeTpmPlatformHierarchyLib.inf > > > > [LibraryClasses.common.UEFI_DRIVER] > > UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf > > diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManage= rLib.inf b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib= .inf > index 11f52e019b..9f54224d3e 100644 > --- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.in= f > +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.in= f > @@ -33,6 +33,7 @@ > MdeModulePkg/MdeModulePkg.dec > > MdePkg/MdePkg.dec > > OvmfPkg/OvmfPkg.dec > > + SecurityPkg/SecurityPkg.dec > > ShellPkg/ShellPkg.dec > > > > [LibraryClasses] > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.