Re: [edk2-devel] [PATCH 2/2] DxeMain: Fix the bug that StackGuard is not enabled

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Ray,

Thank you for this patch.

This change looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 13/06/2022 04:39 am, Ni, Ray via groups.io wrote:
> Commit e7abb94d1 removed InitializeCpuExceptionHandlersEx
> and updated DxeMain to call InitializeCpuExceptionHandlers
> for exception setup. But the old behavior that calls *Ex() sets
> up the stack guard as well. To match the old behavior,
> the patch calls InitializeSeparateExceptionStacks.
>
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> ---
>   MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c b/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c
> index 83f49d7c00..0a1f3d79e2 100644
> --- a/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c
> +++ b/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c
> @@ -256,6 +256,14 @@ DxeMain (
>     Status = InitializeCpuExceptionHandlers (VectorInfoList);
>
>     ASSERT_EFI_ERROR (Status);
>
>   
>
> +  //
>
> +  // Setup Stack Guard
>
> +  //
>
> +  if (PcdGetBool (PcdCpuStackGuard)) {
>
> +    Status = InitializeSeparateExceptionStacks (NULL);
>
> +    ASSERT_EFI_ERROR (Status);
>
> +  }
>
> +
>
>     //
>
>     // Initialize Debug Agent to support source level debug in DXE phase
>
>     //
>