From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.64]) by mx.groups.io with SMTP id smtpd.web12.4618.1655119709616824394 for ; Mon, 13 Jun 2022 04:28:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=7+EkCxF6; spf=pass (domain: arm.com, ip: 40.107.21.64, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nyLXISC5KgdBoigz9TBp4Bn+OkNjRiPtjh0hUlQags4gsr5c2j/I4OgS9n8K9edCCUppamTet3GKrQ4d1QArndCilW1Tg3/T2ceWW6fTVagzPZSIeW9n7UN3LZR9SH1OlN4MjOcxvAw07zbSuoUPwcNiZetaacx9HgQVDwCkdg6QvwSEVdPs0VWYJnDX/i5jesVagAFHzyfP+1WOpylgDjj1Agb4So7ZgHUXAjX/jMD02Y4Ld21DEOav2NPfDb5QjjmiD9AhcZAtWmATS1sIIn3GOaShcjRTLtsXHjdVaAce211ol4MwUgZb/RafCmFvvaVwyGgbkPxhEgfpFeGcJg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8X9MQxW1FWNuBoBWmy1wipsAQVJsYY9MKODsQTj9pNM=; b=Un2nenWeaTbEyTwv4yvzT9gYDwUYXWmLLDq3sUKZwQpYLHdDJ4tE1Pl5VDCYt9mtqrnMUEOGv2Gct5SSW+5Tr63g02YNLPp9VT8jtYOVZN5VrA3DEs6bsxH1+iYtKiTFgcd9WVrrohIgvx9lAbOpskM6sQSmGr2jE7KgdIzoGsXkZ4tCZn3+fqS7nazadUyZ8jyy5icAFZZCDKF+DSWOkodaS4yswBV88OKQFvFmYkq0nAa3+NWploGTT/0qGfwsmewzYDGZhE+JvmGfcAIJuceAH/EjvH1pRTjtkLlTv+ATjdhjTyetBSDcrgBdLPoIE074VNWy9VHqQtOZVDQlZg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8X9MQxW1FWNuBoBWmy1wipsAQVJsYY9MKODsQTj9pNM=; b=7+EkCxF6V6QZX6+ighoQkr1/A9WNeolTVqxOxgl+CKPdh5rRLxRE4jV6PGz0EXZ6mAOUhlNj/cWN1/UuRnNMF3lr7FeXgxILVPeZmyT1HTvkPFizi4beov3nQr1KzzRkgO3wZvD8Kx+Q7vir6LaI+mqjc9eOvSvpgQuNFP0UCQ8= Received: from DB3PR08CA0005.eurprd08.prod.outlook.com (2603:10a6:8::18) by AS4PR08MB7784.eurprd08.prod.outlook.com (2603:10a6:20b:518::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.11; Mon, 13 Jun 2022 11:28:26 +0000 Received: from DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:0:cafe::43) by DB3PR08CA0005.outlook.office365.com (2603:10a6:8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.12 via Frontend Transport; Mon, 13 Jun 2022 11:28:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT057.mail.protection.outlook.com (100.127.142.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.12 via Frontend Transport; Mon, 13 Jun 2022 11:28:26 +0000 Received: ("Tessian outbound 4ab5a053767b:v120"); Mon, 13 Jun 2022 11:28:26 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c8bddf245dee2350 X-CR-MTA-TID: 64aa7808 Received: from 9071dafc547f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4B0AF7B2-0CC7-4E32-BD71-A7D59B65E301.1; Mon, 13 Jun 2022 11:28:19 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9071dafc547f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 13 Jun 2022 11:28:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DWycT2BTiOiV4OGO6pggbbG8QGG9jU2dT7a2OmaUSk3BljdqlaD2CFjqhVZj60Y4ldobWcSIL7erRdu6ZS13u3+LWGlVvTZFIrPDhxArsqeCw3Phf8dhIONKA4VejmoQ3S5yZo5mqei1VH1uRIEA5K8sFmMdTFDrZwvd3t0P7aml94BhYvQe/oXi3Ldv1VA6e9tIFB/KrKvJkVYilGKOpJJpcIVz0TSIByAL57rKWMTrmZHKVJPxSZoepULwpZq89axWWv3e4IWMMqIdpxJQ1Sz9U7N7wn7tREVsWAbpra83/f5bYzj5BZkMtgEJUeR3WnjCOJh5VXhbRFzxdvA+lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8X9MQxW1FWNuBoBWmy1wipsAQVJsYY9MKODsQTj9pNM=; b=VETr7mKR2km8m/e4GxTYDFERFXVshv0+dFIrBv8BO6kw+7M27mzssNenPpOWVw97yVGQru+EUcg7shcDcUvQ4K6tqJV1dC6++1/pmlsMqjKFx53aB5WZPozQePsGYNELNuDSvc5RblFL2WzgSDtZDNl4cIbiY20oyFKltawfv6lFEsatytVKX9JDwYQqhbYMtpH72K4XriGk73sEA+xvpySiMb7G+VrfNGzJr9jMAjSTQtP3kFwDLmBAUuG6GYzs/BWai24CMjRp2g4m/p7OjohT8KVz+eInopNWWexlmAgnZ8F+mmDQY56xraOVctPLFCTHkN3/ZOpWzx1OvJfBAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8X9MQxW1FWNuBoBWmy1wipsAQVJsYY9MKODsQTj9pNM=; b=7+EkCxF6V6QZX6+ighoQkr1/A9WNeolTVqxOxgl+CKPdh5rRLxRE4jV6PGz0EXZ6mAOUhlNj/cWN1/UuRnNMF3lr7FeXgxILVPeZmyT1HTvkPFizi4beov3nQr1KzzRkgO3wZvD8Kx+Q7vir6LaI+mqjc9eOvSvpgQuNFP0UCQ8= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB3414.eurprd08.prod.outlook.com (2603:10a6:20b:49::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.20; Mon, 13 Jun 2022 11:28:16 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::fc42:db38:98b1:3729]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::fc42:db38:98b1:3729%3]) with mapi id 15.20.5332.020; Mon, 13 Jun 2022 11:28:16 +0000 Message-ID: <2aa6417d-c3ce-abf3-a656-ba6a6b601910@arm.com> Date: Mon, 13 Jun 2022 12:28:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [edk2-devel] [PATCH 2/2] DxeMain: Fix the bug that StackGuard is not enabled To: devel@edk2.groups.io, ray.ni@intel.com Cc: Jian J Wang , Liming Gao , Leif Lindholm , Ard Biesheuvel , nd@arm.com References: <20220613033903.1395-1-ray.ni@intel.com> <20220613033903.1395-3-ray.ni@intel.com> From: "Sami Mujawar" In-Reply-To: <20220613033903.1395-3-ray.ni@intel.com> X-ClientProxiedBy: LO4P123CA0148.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::9) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 571a4c92-f7ee-4e3c-b017-08da4d2fd560 X-MS-TrafficTypeDiagnostic: AM6PR08MB3414:EE_|DBAEUR03FT057:EE_|AS4PR08MB7784:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JnPPBItpUqV658eUzM3Aje46E0NcCC27Y7J8Q6NLoPX4y/KOk86APIyy9yDGnK1lAaEzCVCfk7BvWbfrCvbVZB3yrRvp74G+KBlNxJAniFpDSb5nY9RbzLIuB8BR2uK4VbN9j9QQW5qXZ1hrD1X9eRitqxgz2MAUXOVqlb1jXENiRbtQ4XZGpwSyhWB+ijPq/UPSNND20opLUgoNhgXRaPnA7FeJjD7skmzuJV0yZkX231g1iuhrCrKe7Q4YNp5TRrU9Z6lLMZ6ZiN8vC4ZXCcVBBu+dMQpH9HLH8agemRGLIbEu7l37TKlxWzBiTehc5F5fGdXC98X/78EHimwL866FRwbcN4ikRUPXcGUj4WEfsXe4B1kFKKY/SGFY/v0Re3+2ACJ0QgI9K40F0PQrfIe2fu/31KfTc064O0pt7hnNIAMPRYsyA0NmLB/Ebe6y2tQzPMdrUEHxkTBrOuNrCUhCLafrHq/NdT+900Jem+REF7TcDabYPg/fO4jfvT7v1tFxFQXwWHP17ltCr6zY/6Cgl9yA+oK4A8thO/ZpwidpuxhHitWSCK6BUJqR5yC9DSeinA+SNupJ++zuZqHZawcVl0956LpRbrl04BVeIG/+dAcXmcdocQk+jJyZotguw/vrJ5+3iUSVbrs0NRzPhrSGJdj61K3a1QAY7S6hn+TDl6FZms1Hg7/svQ9KkpGP3EUH7DZVpAGEU+PTC9IBpivnKQDXKBZpH52PrULaYYE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(83380400001)(2616005)(186003)(36756003)(38100700002)(31696002)(44832011)(8936002)(5660300002)(66556008)(2906002)(66946007)(6486002)(508600001)(6512007)(26005)(54906003)(4326008)(6506007)(8676002)(66476007)(316002)(53546011)(31686004)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3414 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 36a434ad-86e6-440d-39d1-08da4d2fcf79 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5rMkCR+0IpN56RrTvSbIpxJsaWy7pGPS19e3PIbVthxsJH7OO/34tFS5FhH+KC/l13gofVhGXWU+ulLXfE1SDcmR5IATq5S9nfec4ytu8XuoY5sf7U05Q7/LkT8+XexbuYsS3YndpPcHbmzn/dtvYZuyx9nfc/w0HpMEwXXBF8c+Lj7VRqrMhVMe+x7MRMUdRg/KkGwLsm3cv8s0g2c8Wgp+YQItcTe9FTmuNu0RISiOjRnFbkUMQM/wb3LYF9Ft1tBVXA+7F3znhsNVTrZrG+YsVjjkCwHokeG134JlfZSuBdXpptplGdxk5nQ1ORIK9Aros5Y1khQzenV91Pqo1J7/0p9F2TXrmmBHcZo9/OISvlp/zQ2QAN9Lx5Nl9KgmZRe7NAwnUTwyMfW5/sAQlekP1LkyUqE6FdEuvLpBKlAo9FrQjn/wClphczOi6hmJQu23MjzvNS7mIqfxnJtgCZWH39drvuOR51Io9eOCG9QjQr8WoPxkySh3QopslQXkX7XFt30Aa4vki15EMOLgITo8+G3SvZw7Sw4C7ZfEzZzw0UlGw1JGlsz+U4C+0Yd1+OVQzgve1vRvW/CrxMxAmGgbIlTo0w0clYtDHylpi39yYXbN5vfU7mm8IA93fQMCr3dldjk06qDz/pOUo+aghZhQQC2V5D2y34GWhk4RDkLov7bt8hzVvyCxX6I1ZCXQs1WrNZMk7/PJUztvfQMGrg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(40470700004)(36840700001)(46966006)(4326008)(8676002)(31696002)(8936002)(70586007)(70206006)(81166007)(6506007)(2616005)(5660300002)(86362001)(356005)(186003)(40460700003)(53546011)(31686004)(6486002)(508600001)(44832011)(6512007)(36756003)(26005)(82310400005)(336012)(316002)(36860700001)(54906003)(2906002)(83380400001)(47076005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2022 11:28:26.4719 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 571a4c92-f7ee-4e3c-b017-08da4d2fd560 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7784 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ray, Thank you for this patch. This change looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 13/06/2022 04:39 am, Ni, Ray via groups.io wrote: > Commit e7abb94d1 removed InitializeCpuExceptionHandlersEx > and updated DxeMain to call InitializeCpuExceptionHandlers > for exception setup. But the old behavior that calls *Ex() sets > up the stack guard as well. To match the old behavior, > the patch calls InitializeSeparateExceptionStacks. > > Signed-off-by: Ray Ni > Reviewed-by: Jian J Wang > Cc: Liming Gao > --- > MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c b/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c > index 83f49d7c00..0a1f3d79e2 100644 > --- a/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c > +++ b/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c > @@ -256,6 +256,14 @@ DxeMain ( > Status = InitializeCpuExceptionHandlers (VectorInfoList); > > ASSERT_EFI_ERROR (Status); > > > > + // > > + // Setup Stack Guard > > + // > > + if (PcdGetBool (PcdCpuStackGuard)) { > > + Status = InitializeSeparateExceptionStacks (NULL); > > + ASSERT_EFI_ERROR (Status); > > + } > > + > > // > > // Initialize Debug Agent to support source level debug in DXE phase > > // >