From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120])
 by mx.groups.io with SMTP id smtpd.web11.175.1585693796212325733
 for <devel@edk2.groups.io>;
 Tue, 31 Mar 2020 15:29:56 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FxLiNudB;
 spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1585693795;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vtM01NvJnAFaNhUmS1x9Rmj1RjPAGUsiz7RE+DooMyo=;
	b=FxLiNudBAB1OPuK6Pn32iAzWyvWKqlZMXZLffV7KG5SnnWJbieVqCdq1s2EADmVP/bwv2q
	qQ1A3sBy53C6WBjZueJzTrPkhz3UkHjaOKK+llPvuPK6mY2n65fyMR+/QpLLLBNKNn5IEy
	hvG8Q3d+IwjxeuDlvVSQCJBzIjPNm1s=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-217-RlM6x-s9PFeQqlB69bnzrA-1; Tue, 31 Mar 2020 18:29:52 -0400
X-MC-Unique: RlM6x-s9PFeQqlB69bnzrA-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9FDB2DBA5;
	Tue, 31 Mar 2020 22:29:51 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-131.ams2.redhat.com [10.36.115.131])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 9F85460BE0;
	Tue, 31 Mar 2020 22:29:50 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
 "devel@edk2.groups.io" <devel@edk2.groups.io>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>,
 "macarl@microsoft.com" <macarl@microsoft.com>
References: <03f18a49-6bd6-e753-e1bf-7e061d13f200@redhat.com>
 <14537.1585603662366515487@groups.io>
 <CAKv+Gu8RTs4uW027jaqERHsT6mBB+XNd+vtHSb+ZvtogkF19tg@mail.gmail.com>
 <276d435b-4d94-0899-9710-1584d7baeb3c@redhat.com>
 <E92EE9817A31E24EB0585FDF735412F5B9EF1F47@ORSMSX113.amr.corp.intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <2ab960a0-c158-a95a-d5eb-3da63a06eb3c@redhat.com>
Date: Wed, 1 Apr 2020 00:29:49 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9EF1F47@ORSMSX113.amr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 03/31/20 16:36, Kinney, Michael D wrote:
> ARM and AARCH64 have a compiler intrinsic lib that is linked against all modules.
> 
> [LibraryClasses.ARM, LibraryClasses.AARCH64]
>   #
>   # It is not possible to prevent ARM compiler calls to generic intrinsic functions.
>   # This library provides the instrinsic functions generated by a given compiler.
>   # [LibraryClasses.ARM] and NULL mean link this library into all ARM images.
>   #
>   NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
> 
> Can we use this same technique for IA32/X64

It's not a problem for in-tree platforms (I do hope the edk2 patch
series will include the patch for OvmfPkg), but it will require all
out-of-tree platforms to be updated.

> VS builds?

Yes; I think the library instance should consist of one totally empty C
file, and an |MSFT specific C file providing the external definition of
_fltused. When building for GCC, the lib instance should compile to an
empty object (archive) file.

In my opinion, of course.

Thanks
Laszlo