From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Pranav Madhu <pranav.madhu@arm.com>, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>, nd <nd@arm.com>
Subject: Re: [edk2-platforms][PATCH V4 00/11] Add SMBIOS tables for Arm's Reference Design platforms
Date: Tue, 1 Jun 2021 15:29:21 +0100 [thread overview]
Message-ID: <2ad3abec-04e4-7574-eb39-b60512b4ee68@arm.com> (raw)
In-Reply-To: <20210524142816.9967-1-pranav.madhu@arm.com>
Pushed as 86984c17d562..8cdd4cb7c71e, with minor changes to patch 4 and 7.
Thanks.
Regards,
Sami Mujawar
On 24/05/2021 03:28 PM, Pranav Madhu wrote:
> Changes since V3:
> - Add UpdateMemorySize API to update memory size information as suggested by Sami.
>
> Changes since V2:
> - Addressed comments from Sami
> - Picked up Sami's reviewed-by tags.
>
> Changes since V1:
> - Rebase the patches on top of latest master branch
>
> SMBIOS provides basic hardware and firmware configuration information
> through table-driven data structure. This patch series adds SMBIOS
> support for Arm's SGI/RD platforms.
>
> The first patch in this series defines platform-id values for the
> RD-N2 platform library header. The second patch add SgiGetProductId API,
> which is used by the SMBIOS driver to distinguish between the platforms,
> and install the right table. The third patch in this series adds SMBIOS
> driver support that allows for installation of multiple SMBIOS tables.
> And subsequent patches in this series add SMBIOS tables, which are
> mandatory as per Arm serverready SBBR specification.
>
> Link to github branch with the patches in this series -
> https://github.com/Pranav-Madhu/edk2-platforms/tree/topics/rd_smbios
>
> Pranav Madhu (11):
> Platform/Sgi: Define RD-N2 platform id values
> Platform/Sgi: Add GetProductId API for SGI/RD Platforms
> Platform/Sgi: Add Initial SMBIOS support
> Platform/Sgi: Add SMBIOS Type1 Table
> Platform/Sgi: Add SMBIOS Type3 Table
> Platform/Sgi: Add SMBIOS Type4 Table
> Platform/Sgi: Add SMBIOS Type7 Table
> Platform/Sgi: Add SMBIOS Type16 Table
> Platform/Sgi: Add SMBIOS Type17 Table
> Platform/Sgi: Add SMBIOS Type19 Table
> Platform/Sgi: Add SMBIOS Type32 Table
>
> Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 11 +
> Platform/ARM/SgiPkg/SgiPlatform.fdf | 8 +-
> .../SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 62 +++
> .../SmbiosPlatformDxe/SmbiosPlatformDxe.h | 197 +++++++++
> Platform/ARM/SgiPkg/Include/SgiPlatform.h | 36 +-
> .../SmbiosPlatformDxe/SmbiosPlatformDxe.c | 106 +++++
> .../SmbiosPlatformDxe/Type0BiosInformation.c | 135 ++++++
> .../Type16PhysicalMemoryArray.c | 106 +++++
> .../SmbiosPlatformDxe/Type17MemoryDevice.c | 409 ++++++++++++++++++
> .../Type19MemoryArrayMappedAddress.c | 97 +++++
> .../Type1SystemInformation.c | 142 ++++++
> .../Type32SystemBootInformation.c | 84 ++++
> .../SmbiosPlatformDxe/Type3SystemEnclosure.c | 103 +++++
> .../Type4ProcessorInformation.c | 219 ++++++++++
> .../SmbiosPlatformDxe/Type7CacheInformation.c | 342 +++++++++++++++
> .../SgiPkg/Library/PlatformLib/PlatformLib.c | 86 +++-
> 16 files changed, 2140 insertions(+), 3 deletions(-)
> create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf
> create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h
> create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type0BiosInformation.c
> create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type16PhysicalMemoryArray.c
> create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type17MemoryDevice.c
> create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type19MemoryArrayMappedAddress.c
> create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c
> create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type32SystemBootInformation.c
> create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type3SystemEnclosure.c
> create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c
> create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c
>
prev parent reply other threads:[~2021-06-01 14:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 14:28 [edk2-platforms][PATCH V4 00/11] Add SMBIOS tables for Arm's Reference Design platforms Pranav Madhu
2021-05-24 14:28 ` [edk2-platforms][PATCH V4 01/11] Platform/Sgi: Define RD-N2 platform id values Pranav Madhu
2021-05-24 14:28 ` [edk2-platforms][PATCH V4 02/11] Platform/Sgi: Add GetProductId API for SGI/RD Platforms Pranav Madhu
2021-05-24 14:28 ` [edk2-platforms][PATCH V4 03/11] Platform/Sgi: Add Initial SMBIOS support Pranav Madhu
2021-05-24 14:28 ` [edk2-platforms][PATCH V4 04/11] Platform/Sgi: Add SMBIOS Type1 Table Pranav Madhu
2021-05-24 14:28 ` [edk2-platforms][PATCH V4 05/11] Platform/Sgi: Add SMBIOS Type3 Table Pranav Madhu
2021-05-24 14:28 ` [edk2-platforms][PATCH V4 06/11] Platform/Sgi: Add SMBIOS Type4 Table Pranav Madhu
2021-05-24 14:28 ` [edk2-platforms][PATCH V4 07/11] Platform/Sgi: Add SMBIOS Type7 Table Pranav Madhu
2021-05-24 14:28 ` [edk2-platforms][PATCH V4 08/11] Platform/Sgi: Add SMBIOS Type16 Table Pranav Madhu
2021-05-24 14:28 ` [edk2-platforms][PATCH V4 09/11] Platform/Sgi: Add SMBIOS Type17 Table Pranav Madhu
2021-05-24 14:28 ` [edk2-platforms][PATCH V4 10/11] Platform/Sgi: Add SMBIOS Type19 Table Pranav Madhu
2021-05-24 14:28 ` [edk2-platforms][PATCH V4 11/11] Platform/Sgi: Add SMBIOS Type32 Table Pranav Madhu
2021-05-24 15:16 ` [edk2-platforms][PATCH V4 00/11] Add SMBIOS tables for Arm's Reference Design platforms Sami Mujawar
2021-06-01 14:29 ` Sami Mujawar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ad3abec-04e4-7574-eb39-b60512b4ee68@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox