From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smarthost01c.ixn.mail.zen.net.uk (smarthost01c.ixn.mail.zen.net.uk [212.23.1.22]) by mx.groups.io with SMTP id smtpd.web10.7685.1645689539525026027 for ; Wed, 23 Feb 2022 23:59:00 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=permerror, err=parse error for token &{10 18 sdn.klaviyomail.com}: permanent DNS error (domain: starlabs.systems, ip: 212.23.1.22, mailfrom: sean@starlabs.systems) Received: from [217.155.46.38] (helo=sean-StarBook.lan) by smarthost01c.ixn.mail.zen.net.uk with esmtp (Exim 4.90_1) (envelope-from ) id 1nN91b-0004iD-Bo; Thu, 24 Feb 2022 07:58:55 +0000 From: "Sean Rhodes" To: devel@edk2.groups.io Cc: guo.dong@intel.com, Sean Rhodes , Hao A Wu , Ray Ni , Jian J Wang , Liming Gao , Matt DeVillier Subject: [PATCH 1/2] MdeModulePkg/SdMmcPciHcDxe: Make timeout for SD card configurable Date: Thu, 24 Feb 2022 07:58:51 +0000 Message-Id: <2ae73e745893fd40f73f75390d1f16b5c36296f5.1645689532.git.sean@starlabs.systems> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Originating-smarthost01c-IP: [217.155.46.38] Feedback-ID: 217.155.46.38 Content-Transfer-Encoding: quoted-printable The default 1s timeout can delay boot splash on some hardware with no benefit. Cc: Hao A Wu Cc: Ray Ni Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Matt DeVillier Signed-off-by: Sean Rhodes --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 3 ++- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf | 4 ++++ MdeModulePkg/MdeModulePkg.dec | 4 ++++ MdeModulePkg/MdeModulePkg.uni | 4 ++++ 4 files changed, 14 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h b/MdeModule= Pkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h index 85e09cf114..b76c7cffa2 100644 --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h @@ -24,6 +24,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include =0D #include =0D #include =0D +#include =0D =0D #include =0D #include =0D @@ -49,7 +50,7 @@ extern EDKII_SD_MMC_OVERRIDE *mOverride; //=0D // Generic time out value, 1 microsecond as unit.=0D //=0D -#define SD_MMC_HC_GENERIC_TIMEOUT 1 * 1000 * 1000=0D +#define SD_MMC_HC_GENERIC_TIMEOUT (PcdGet32 (PcdSdMmcGenericTimeoutValue)= )=0D =0D //=0D // SD/MMC async transfer timer interval, set by experience.=0D diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf b/MdeModu= lePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf index 453ecde7fd..e502443ddd 100644 --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf @@ -56,6 +56,7 @@ BaseLib=0D UefiDriverEntryPoint=0D DebugLib=0D + PcdLib=0D =0D [Protocols]=0D gEdkiiSdMmcOverrideProtocolGuid ## SOMETIMES_CONSUMES=0D @@ -68,3 +69,6 @@ =0D [UserExtensions.TianoCore."ExtraFiles"]=0D SdMmcPciHcDxeExtra.uni=0D +=0D +[Pcd]=0D + gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmcGenericTimeoutValue ## CONSUMES= =0D diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 463e889e9a..40601c9583 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -1559,6 +1559,10 @@ # @Prompt Maximum permitted FwVol section nesting depth (exclusive).=0D gEfiMdeModulePkgTokenSpaceGuid.PcdFwVolDxeMaxEncapsulationDepth|0x10|UIN= T32|0x00000030=0D =0D + ## Indicates the default timeout value for SD/MMC Host Controller operat= ions in microseconds.=0D + # @Prompt SD/MMC Host Controller Operations Timeout (us).=0D + gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmcGenericTimeoutValue|1000000|UINT3= 2|0x00000031=0D +=0D [PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]=0D ## This PCD defines the Console output row. The default value is 25 acco= rding to UEFI spec.=0D # This PCD could be set to 0 then console output would be at max column= and max row.=0D diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni index 27889a7280..b070f15ff2 100644 --- a/MdeModulePkg/MdeModulePkg.uni +++ b/MdeModulePkg/MdeModulePkg.uni @@ -1173,6 +1173,10 @@ = " TRUE - Capsule In Ram is supported.
"=0D = " FALSE - Capsule In Ram is not supported."=0D =0D +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSdMmcGenericTimeoutValue_PRO= MPT #language en-US "SD/MMC Host Controller Operations Timeout (us)."=0D +=0D +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSdMmcGenericTimeoutValue_HEL= P #language en-US "Indicates the default timeout value for SD/MMC Host Co= ntroller operations in microseconds."=0D +=0D #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCodRelocationDevPath_PROMPT = #language en-US "Capsule On Disk relocation device path."=0D =0D #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCodRelocationDevPath_HELP #= language en-US "Full device path of platform specific device to store Cap= sule On Disk temp relocation file.
"=0D --=20 2.32.0