* [PATCH 01/79] CryptoPkg/OpensslLib: Fix few typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
@ 2019-12-03 16:14 ` Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 02/79] EmbeddedPkg/FdtLib: Fix a typo Philippe Mathieu-Daudé
` (71 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:14 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Jian J Wang, Xiaoyu Lu, Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix few typos in comments.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
CryptoPkg/Library/OpensslLib/rand_pool.c | 8 ++++----
CryptoPkg/Library/OpensslLib/rand_pool_noise.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/CryptoPkg/Library/OpensslLib/rand_pool.c b/CryptoPkg/Library/OpensslLib/rand_pool.c
index 9d2a4ad13823..9f3983f7c35b 100644
--- a/CryptoPkg/Library/OpensslLib/rand_pool.c
+++ b/CryptoPkg/Library/OpensslLib/rand_pool.c
@@ -129,7 +129,7 @@ RandGetSeed128 (
AES_KEY AESKey;
//
- // Chose an arbitary key and zero the feed_forward_value (FFV)
+ // Chose an arbitrary key and zero the feed_forward_value (FFV)
//
for (Index = 0; Index < 16; Index++) {
Key[Index] = (UINT8) Index;
@@ -287,7 +287,7 @@ int rand_pool_add_additional_data(RAND_POOL *pool)
}
/*
- * Dummy Implememtation for UEFI
+ * Dummy Implementation for UEFI
*
* This is OpenSSL required interface.
*/
@@ -297,7 +297,7 @@ int rand_pool_init(void)
}
/*
- * Dummy Implememtation for UEFI
+ * Dummy Implementation for UEFI
*
* This is OpenSSL required interface.
*/
@@ -306,7 +306,7 @@ void rand_pool_cleanup(void)
}
/*
- * Dummy Implememtation for UEFI
+ * Dummy Implementation for UEFI
*
* This is OpenSSL required interface.
*/
diff --git a/CryptoPkg/Library/OpensslLib/rand_pool_noise.c b/CryptoPkg/Library/OpensslLib/rand_pool_noise.c
index c16ed8b45496..212834e27acc 100644
--- a/CryptoPkg/Library/OpensslLib/rand_pool_noise.c
+++ b/CryptoPkg/Library/OpensslLib/rand_pool_noise.c
@@ -22,7 +22,7 @@ GetRandomNoise64 (
)
{
//
- // Return FALSE will fallback to use PerformaceCounter to
+ // Return FALSE will fallback to use PerformanceCounter to
// generate noise.
//
return FALSE;
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* [PATCH 02/79] EmbeddedPkg/FdtLib: Fix a typo
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 01/79] CryptoPkg/OpensslLib: Fix few typos Philippe Mathieu-Daudé
@ 2019-12-03 16:14 ` Philippe Mathieu-Daudé
2019-12-03 16:58 ` Leif Lindholm
2019-12-03 16:14 ` [PATCH 03/79] EmbeddedPkg/VirtualKeyboard: Fix a typo in EFI_INVALID_PARAMETER Philippe Mathieu-Daudé
` (70 subsequent siblings)
72 siblings, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:14 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Leif Lindholm, Ard Biesheuvel,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix a typo in a comment.
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
EmbeddedPkg/Include/libfdt.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/EmbeddedPkg/Include/libfdt.h b/EmbeddedPkg/Include/libfdt.h
index 141ecb579bde..606c80a0e8ca 100644
--- a/EmbeddedPkg/Include/libfdt.h
+++ b/EmbeddedPkg/Include/libfdt.h
@@ -107,7 +107,7 @@
* nodes, or subnodes preceding properties). */
#define FDT_ERR_BADLAYOUT 12
/* FDT_ERR_BADLAYOUT: For read-write functions, the given
- * device tree has it's sub-blocks in an order that the
+ * device tree has its sub-blocks in an order that the
* function can't handle (memory reserve map, then structure,
* then strings). Use fdt_open_into() to reorganize the tree
* into a form suitable for the read-write operations. */
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [PATCH 02/79] EmbeddedPkg/FdtLib: Fix a typo
2019-12-03 16:14 ` [PATCH 02/79] EmbeddedPkg/FdtLib: Fix a typo Philippe Mathieu-Daudé
@ 2019-12-03 16:58 ` Leif Lindholm
0 siblings, 0 replies; 122+ messages in thread
From: Leif Lindholm @ 2019-12-03 16:58 UTC (permalink / raw)
To: Philippe Mathieu-Daude; +Cc: devel, Antoine Coeur, Ard Biesheuvel
Hi Phil, Antoine,
This file is imported from an external project, and arguably we should
be converting the libfdt import to a submodule instead. So I'd prefer
not pulling this one in.
/
Leif
On Tue, Dec 03, 2019 at 17:14:45 +0100, Philippe Mathieu-Daude wrote:
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix a typo in a comment.
>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> EmbeddedPkg/Include/libfdt.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/EmbeddedPkg/Include/libfdt.h b/EmbeddedPkg/Include/libfdt.h
> index 141ecb579bde..606c80a0e8ca 100644
> --- a/EmbeddedPkg/Include/libfdt.h
> +++ b/EmbeddedPkg/Include/libfdt.h
> @@ -107,7 +107,7 @@
> * nodes, or subnodes preceding properties). */
> #define FDT_ERR_BADLAYOUT 12
> /* FDT_ERR_BADLAYOUT: For read-write functions, the given
> - * device tree has it's sub-blocks in an order that the
> + * device tree has its sub-blocks in an order that the
> * function can't handle (memory reserve map, then structure,
> * then strings). Use fdt_open_into() to reorganize the tree
> * into a form suitable for the read-write operations. */
> --
> 2.21.0
^ permalink raw reply [flat|nested] 122+ messages in thread
* [PATCH 03/79] EmbeddedPkg/VirtualKeyboard: Fix a typo in EFI_INVALID_PARAMETER
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 01/79] CryptoPkg/OpensslLib: Fix few typos Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 02/79] EmbeddedPkg/FdtLib: Fix a typo Philippe Mathieu-Daudé
@ 2019-12-03 16:14 ` Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 04/79] EmbeddedPkg/VirtualKeyboard: Fix few typos Philippe Mathieu-Daudé
` (69 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:14 UTC (permalink / raw)
To: devel
Cc: Philippe Mathieu-Daude, Antoine Cœur, Leif Lindholm,
Ard Biesheuvel
Correctly write 'EFI_INVALID_PARAMETER' in documentation.
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h | 22 ++++++++++----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h
index 8757b678d161..29bc7a06fb16 100644
--- a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h
+++ b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h
@@ -206,9 +206,9 @@ VirtualKeyboardDriverBindingStop (
This and the language specified by Language was
returned in DriverName.
- @retval EFI_INVALID_PAVIRTUALETER Language is NULL.
+ @retval EFI_INVALID_PARAMETER Language is NULL.
- @retval EFI_INVALID_PAVIRTUALETER DriverName is NULL.
+ @retval EFI_INVALID_PARAMETER DriverName is NULL.
@retval EFI_UNSUPPORTED The driver specified by This does not support
the language specified by Language.
@@ -274,14 +274,14 @@ VirtualKeyboardComponentNameGetDriverName (
driver specified by This was returned in
DriverName.
- @retval EFI_INVALID_PAVIRTUALETER ControllerHandle is NULL.
+ @retval EFI_INVALID_PARAMETER ControllerHandle is NULL.
- @retval EFI_INVALID_PAVIRTUALETER ChildHandle is not NULL and it is not a valid
+ @retval EFI_INVALID_PARAMETER ChildHandle is not NULL and it is not a valid
EFI_HANDLE.
- @retval EFI_INVALID_PAVIRTUALETER Language is NULL.
+ @retval EFI_INVALID_PARAMETER Language is NULL.
- @retval EFI_INVALID_PAVIRTUALETER ControllerName is NULL.
+ @retval EFI_INVALID_PARAMETER ControllerName is NULL.
@retval EFI_UNSUPPORTED The driver specified by This is not currently
managing the controller specified by
@@ -351,7 +351,7 @@ VirtualKeyboardResetEx (
@retval EFI_DEVICE_ERROR The device is not functioning correctly and could
not have the setting adjusted.
@retval EFI_UNSUPPORTED The device does not have the ability to set its state.
- @retval EFI_INVALID_PAVIRTUALETER KeyToggleState is NULL.
+ @retval EFI_INVALID_PARAMETER KeyToggleState is NULL.
**/
EFI_STATUS
@@ -374,7 +374,7 @@ VirtualKeyboardSetState (
@retval EFI_SUCCESS The notification function was registered successfully.
@retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necesssary data structures.
- @retval EFI_INVALID_PAVIRTUALETER KeyData or NotifyHandle is NULL.
+ @retval EFI_INVALID_PARAMETER KeyData or NotifyHandle is NULL.
**/
EFI_STATUS
@@ -393,7 +393,7 @@ VirtualKeyboardRegisterKeyNotify (
@param NotificationHandle The handle of the notification function being unregistered.
@retval EFI_SUCCESS The notification function was unregistered successfully.
- @retval EFI_INVALID_PAVIRTUALETER The NotificationHandle is invalid.
+ @retval EFI_INVALID_PARAMETER The NotificationHandle is invalid.
**/
EFI_STATUS
@@ -412,7 +412,7 @@ VirtualKeyboardUnregisterKeyNotify (
@param ListHead The list head
@retval EFI_SUCCESS Free the notify list successfully
- @retval EFI_INVALID_PAVIRTUALETER ListHead is invalid.
+ @retval EFI_INVALID_PARAMETER ListHead is invalid.
**/
EFI_STATUS
@@ -524,7 +524,7 @@ VirtualKeyboardReadKeyStroke (
@retval EFI_NOT_READY There was no keystroke data availiable.
@retval EFI_DEVICE_ERROR The keystroke information was not returned due to
hardware errors.
- @retval EFI_INVALID_PAVIRTUALETER KeyData is NULL.
+ @retval EFI_INVALID_PARAMETER KeyData is NULL.
**/
EFI_STATUS
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* [PATCH 04/79] EmbeddedPkg/VirtualKeyboard: Fix few typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (2 preceding siblings ...)
2019-12-03 16:14 ` [PATCH 03/79] EmbeddedPkg/VirtualKeyboard: Fix a typo in EFI_INVALID_PARAMETER Philippe Mathieu-Daudé
@ 2019-12-03 16:14 ` Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 05/79] EmulatorPkg/Sec: Fix various typos Philippe Mathieu-Daudé
` (68 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:14 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Leif Lindholm, Ard Biesheuvel,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix few typos in the documentation.
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h | 14 +++++++-------
EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c | 16 ++++++++--------
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h
index 29bc7a06fb16..026449046653 100644
--- a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h
+++ b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h
@@ -323,7 +323,7 @@ VirtualKeyboardReset (
);
/**
- Reset the input device and optionaly run diagnostics
+ Reset the input device and optionally run diagnostics
@param This Protocol instance pointer.
@param ExtendedVerification Driver may perform diagnostics on reset.
@@ -373,7 +373,7 @@ VirtualKeyboardSetState (
@retval EFI_SUCCESS The notification function was registered successfully.
- @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necesssary data structures.
+ @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necessary data structures.
@retval EFI_INVALID_PARAMETER KeyData or NotifyHandle is NULL.
**/
@@ -429,7 +429,7 @@ VirtualKeyboardFreeNotifyList (
state data for the key that was pressed.
@retval TRUE Key be pressed matches a registered key.
- @retval FLASE Match failed.
+ @retval FALSE Match failed.
**/
BOOLEAN
@@ -441,7 +441,7 @@ IsKeyRegistered (
/**
Waiting on the keyboard event, if there's any key pressed by the user, signal the event
- @param Event The event that be siganlled when any key has been stroked.
+ @param Event The event that be signalled when any key has been stroked.
@param Context Pointer of the protocol EFI_SIMPLE_TEXT_INPUT_PROTOCOL.
**/
@@ -455,7 +455,7 @@ VirtualKeyboardWaitForKey (
/**
Waiting on the keyboard event, if there's any key pressed by the user, signal the event
- @param Event The event that be siganlled when any key has been stroked.
+ @param Event The event that be signalled when any key has been stroked.
@param Context Pointer of the protocol EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.
**/
@@ -514,14 +514,14 @@ VirtualKeyboardReadKeyStroke (
/**
Reads the next keystroke from the input device. The WaitForKey Event can
- be used to test for existance of a keystroke via WaitForEvent () call.
+ be used to test for existence of a keystroke via WaitForEvent () call.
@param This Protocol instance pointer.
@param KeyData A pointer to a buffer that is filled in with the keystroke
state data for the key that was pressed.
@retval EFI_SUCCESS The keystroke information was returned.
- @retval EFI_NOT_READY There was no keystroke data availiable.
+ @retval EFI_NOT_READY There was no keystroke data available.
@retval EFI_DEVICE_ERROR The keystroke information was not returned due to
hardware errors.
@retval EFI_INVALID_PARAMETER KeyData is NULL.
diff --git a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c
index 750371a06723..e9d0b72ee6c3 100644
--- a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c
+++ b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c
@@ -437,7 +437,7 @@ VirtualKeyboardFreeNotifyList (
pressed.
@retval TRUE Key be pressed matches a registered key.
- @retval FLASE Match failed.
+ @retval FALSE Match failed.
**/
BOOLEAN
@@ -476,7 +476,7 @@ IsKeyRegistered (
Signal the event if there is key available
@param Event the event object
- @param Context waitting context
+ @param Context waiting context
**/
VOID
@@ -580,7 +580,7 @@ VirtualKeyboardReset (
}
/**
- Reset the input device and optionaly run diagnostics
+ Reset the input device and optionally run diagnostics
@param This Protocol instance pointer.
@param ExtendedVerification Driver may perform diagnostics on reset.
@@ -621,7 +621,7 @@ VirtualKeyboardResetEx (
/**
Reads the next keystroke from the input device. The WaitForKey Event can
- be used to test for existance of a keystroke via WaitForEvent () call.
+ be used to test for existence of a keystroke via WaitForEvent () call.
@param VirtualKeyboardPrivate Virtualkeyboard driver private structure.
@param KeyData A pointer to a buffer that is filled in
@@ -629,7 +629,7 @@ VirtualKeyboardResetEx (
that was pressed.
@retval EFI_SUCCESS The keystroke information was returned.
- @retval EFI_NOT_READY There was no keystroke data availiable.
+ @retval EFI_NOT_READY There was no keystroke data available.
@retval EFI_DEVICE_ERROR The keystroke information was not returned
due to hardware errors.
@retval EFI_INVALID_PARAMETER KeyData is NULL.
@@ -731,14 +731,14 @@ VirtualKeyboardReadKeyStroke (
/**
Reads the next keystroke from the input device. The WaitForKey Event can
- be used to test for existance of a keystroke via WaitForEvent () call.
+ be used to test for existence of a keystroke via WaitForEvent () call.
@param This Protocol instance pointer.
@param KeyData A pointer to a buffer that is filled in with the
keystroke state data for the key that was pressed.
@retval EFI_SUCCESS The keystroke information was returned.
- @retval EFI_NOT_READY There was no keystroke data availiable.
+ @retval EFI_NOT_READY There was no keystroke data available.
@retval EFI_DEVICE_ERROR The keystroke information was not returned
due to hardware errors.
@retval EFI_INVALID_PARAMETER KeyData is NULL.
@@ -808,7 +808,7 @@ VirtualKeyboardSetState (
@retval EFI_SUCCESS The notification function was registered
successfully.
- @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necesssary
+ @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necessary
data structures.
@retval EFI_INVALID_PARAMETER KeyData or NotifyHandle is NULL.
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* [PATCH 05/79] EmulatorPkg/Sec: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (3 preceding siblings ...)
2019-12-03 16:14 ` [PATCH 04/79] EmbeddedPkg/VirtualKeyboard: Fix few typos Philippe Mathieu-Daudé
@ 2019-12-03 16:14 ` Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 06/79] EmulatorPkg/Unix: " Philippe Mathieu-Daudé
` (67 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:14 UTC (permalink / raw)
To: devel
Cc: Antoine Coeur, Jordan Justen, Andrew Fish, Ray Ni,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Coeur <coeur@gmx.fr>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
EmulatorPkg/Sec/Sec.h | 4 ++--
EmulatorPkg/Sec/Sec.c | 5 ++---
EmulatorPkg/Sec/Ia32/SwitchRam.S | 18 +++++++++---------
EmulatorPkg/Sec/Ia32/SwitchRam.asm | 20 ++++++++++----------
EmulatorPkg/Sec/X64/SwitchRam.S | 2 +-
EmulatorPkg/Sec/X64/SwitchRam.asm | 2 +-
6 files changed, 25 insertions(+), 26 deletions(-)
diff --git a/EmulatorPkg/Sec/Sec.h b/EmulatorPkg/Sec/Sec.h
index dd301f788868..42554e05b56e 100644
--- a/EmulatorPkg/Sec/Sec.h
+++ b/EmulatorPkg/Sec/Sec.h
@@ -1,5 +1,5 @@
/*++ @file
- Stub SEC that is called from the OS appliation that is the root of the emulator.
+ Stub SEC that is called from the OS application that is the root of the emulator.
The OS application will call the SEC with the PEI Entry Point API.
@@ -23,7 +23,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
//
-// I think this shold be defined in a MdePkg include file?
+// I think this should be defined in a MdePkg include file?
//
VOID
EFIAPI
diff --git a/EmulatorPkg/Sec/Sec.c b/EmulatorPkg/Sec/Sec.c
index b734d2bb8799..1c0f73d66944 100644
--- a/EmulatorPkg/Sec/Sec.c
+++ b/EmulatorPkg/Sec/Sec.c
@@ -1,5 +1,5 @@
/*++ @file
- Stub SEC that is called from the OS appliation that is the root of the emulator.
+ Stub SEC that is called from the OS application that is the root of the emulator.
The OS application will call the SEC with the PEI Entry Point API.
@@ -90,7 +90,7 @@ _ModuleEntryPoint (
SecReseveredMemorySize += sizeof (EFI_PEI_PPI_DESCRIPTOR);
if ((Ppi->Flags & EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST) == EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST) {
- // Since we are appending, need to clear out privious list terminator.
+ // Since we are appending, need to clear out previous list terminator.
Ppi->Flags &= ~EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST;
break;
}
@@ -138,4 +138,3 @@ _ModuleEntryPoint (
}
-
diff --git a/EmulatorPkg/Sec/Ia32/SwitchRam.S b/EmulatorPkg/Sec/Ia32/SwitchRam.S
index f24529cc8e61..d8298223a9b0 100644
--- a/EmulatorPkg/Sec/Ia32/SwitchRam.S
+++ b/EmulatorPkg/Sec/Ia32/SwitchRam.S
@@ -9,7 +9,7 @@
#
# Abstract:
#
-# Switch the stack from temporary memory to permenent memory.
+# Switch the stack from temporary memory to permanent memory.
#
#------------------------------------------------------------------------------
@@ -36,7 +36,7 @@ ASM_PFX(SecSwitchStack):
#
# !!CAUTION!! this function address's is pushed into stack after
-# migration of whole temporary memory, so need save it to permenent
+# migration of whole temporary memory, so need save it to permanent
# memory at first!
#
@@ -44,14 +44,14 @@ ASM_PFX(SecSwitchStack):
movl 24(%esp), %ecx # Save the second parameter
#
-# Save this function's return address into permenent memory at first.
-# Then, Fixup the esp point to permenent memory
+# Save this function's return address into permanent memory at first.
+# Then, Fixup the esp point to permanent memory
#
movl %esp, %eax
subl %ebx, %eax
addl %ecx, %eax
- movl (%esp), %edx # copy pushed register's value to permenent memory
+ movl (%esp), %edx # copy pushed register's value to permanent memory
movl %edx, (%eax)
movl 4(%esp), %edx
movl %edx, 4(%eax)
@@ -61,16 +61,16 @@ ASM_PFX(SecSwitchStack):
movl %edx, 12(%eax)
movl 16(%esp), %edx
movl %edx, 16(%eax)
- movl %eax, %esp # From now, esp is pointed to permenent memory
+ movl %eax, %esp # From now, esp is pointed to permanent memory
#
-# Fixup the ebp point to permenent memory
+# Fixup the ebp point to permanent memory
#
#ifndef __APPLE__
movl %ebp, %eax
subl %ebx, %eax
addl %ecx, %eax
- movl %eax, %ebp # From now, ebp is pointed to permenent memory
+ movl %eax, %ebp # From now, ebp is pointed to permanent memory
#
# Fixup callee's ebp point for PeiDispatch
@@ -78,7 +78,7 @@ ASM_PFX(SecSwitchStack):
movl (%ebp), %eax
subl %ebx, %eax
addl %ecx, %eax
- movl %eax, (%ebp) # From now, Temporary's PPI caller's stack is in permenent memory
+ movl %eax, (%ebp) # From now, Temporary's PPI caller's stack is in permanent memory
#endif
pop %edx
diff --git a/EmulatorPkg/Sec/Ia32/SwitchRam.asm b/EmulatorPkg/Sec/Ia32/SwitchRam.asm
index 9c7908f7a04c..99ef00298069 100644
--- a/EmulatorPkg/Sec/Ia32/SwitchRam.asm
+++ b/EmulatorPkg/Sec/Ia32/SwitchRam.asm
@@ -9,7 +9,7 @@
;
; Abstract:
;
-; Switch the stack from temporary memory to permenent memory.
+; Switch the stack from temporary memory to permanent memory.
;
;------------------------------------------------------------------------------
@@ -36,7 +36,7 @@ SecSwitchStack PROC
;
; !!CAUTION!! this function address's is pushed into stack after
- ; migration of whole temporary memory, so need save it to permenent
+ ; migration of whole temporary memory, so need save it to permanent
; memory at first!
;
@@ -44,13 +44,13 @@ SecSwitchStack PROC
mov ecx, [esp + 24] ; Save the second parameter
;
- ; Save this function's return address into permenent memory at first.
- ; Then, Fixup the esp point to permenent memory
+ ; Save this function's return address into permanent memory at first.
+ ; Then, Fixup the esp point to permanent memory
;
mov eax, esp
sub eax, ebx
add eax, ecx
- mov edx, dword ptr [esp] ; copy pushed register's value to permenent memory
+ mov edx, dword ptr [esp] ; copy pushed register's value to permanent memory
mov dword ptr [eax], edx
mov edx, dword ptr [esp + 4]
mov dword ptr [eax + 4], edx
@@ -58,17 +58,17 @@ SecSwitchStack PROC
mov dword ptr [eax + 8], edx
mov edx, dword ptr [esp + 12]
mov dword ptr [eax + 12], edx
- mov edx, dword ptr [esp + 16] ; Update this function's return address into permenent memory
+ mov edx, dword ptr [esp + 16] ; Update this function's return address into permanent memory
mov dword ptr [eax + 16], edx
- mov esp, eax ; From now, esp is pointed to permenent memory
+ mov esp, eax ; From now, esp is pointed to permanent memory
;
- ; Fixup the ebp point to permenent memory
+ ; Fixup the ebp point to permanent memory
;
mov eax, ebp
sub eax, ebx
add eax, ecx
- mov ebp, eax ; From now, ebp is pointed to permenent memory
+ mov ebp, eax ; From now, ebp is pointed to permanent memory
;
; Fixup callee's ebp point for PeiDispatch
@@ -76,7 +76,7 @@ SecSwitchStack PROC
mov eax, dword ptr [ebp]
sub eax, ebx
add eax, ecx
- mov dword ptr [ebp], eax ; From now, Temporary's PPI caller's stack is in permenent memory
+ mov dword ptr [ebp], eax ; From now, Temporary's PPI caller's stack is in permanent memory
pop edx
pop ecx
diff --git a/EmulatorPkg/Sec/X64/SwitchRam.S b/EmulatorPkg/Sec/X64/SwitchRam.S
index 7ddb6c854b00..59d4e2edef2a 100644
--- a/EmulatorPkg/Sec/X64/SwitchRam.S
+++ b/EmulatorPkg/Sec/X64/SwitchRam.S
@@ -1,7 +1,7 @@
#------------------------------------------------------------------------------
#
# Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR>
-# Portitions copyright (c) 2011, Apple Inc. All rights reserved.
+# Portions copyright (c) 2011, Apple Inc. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
#------------------------------------------------------------------------------
diff --git a/EmulatorPkg/Sec/X64/SwitchRam.asm b/EmulatorPkg/Sec/X64/SwitchRam.asm
index 73530bff39c2..e66bda5bf4e6 100644
--- a/EmulatorPkg/Sec/X64/SwitchRam.asm
+++ b/EmulatorPkg/Sec/X64/SwitchRam.asm
@@ -1,7 +1,7 @@
;------------------------------------------------------------------------------
;
; Copyright (c) 2006 - 2012, Intel Corporation. All rights reserved.<BR>
-; Portitions copyright (c) 2011, Apple Inc. All rights reserved.
+; Portions copyright (c) 2011, Apple Inc. All rights reserved.
; SPDX-License-Identifier: BSD-2-Clause-Patent
;
;------------------------------------------------------------------------------
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* [PATCH 06/79] EmulatorPkg/Unix: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (4 preceding siblings ...)
2019-12-03 16:14 ` [PATCH 05/79] EmulatorPkg/Sec: Fix various typos Philippe Mathieu-Daudé
@ 2019-12-03 16:14 ` Philippe Mathieu-Daudé
2019-12-20 6:38 ` Ni, Ray
2019-12-03 16:14 ` [PATCH 07/79] EmulatorPkg/Win: " Philippe Mathieu-Daudé
` (66 subsequent siblings)
72 siblings, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:14 UTC (permalink / raw)
To: devel
Cc: Antoine Coeur, Jordan Justen, Andrew Fish, Ray Ni,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Coeur <coeur@gmx.fr>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 2 +-
EmulatorPkg/Unix/Host/BlockIo.c | 12 ++++-----
EmulatorPkg/Unix/Host/EmuThunk.c | 2 +-
EmulatorPkg/Unix/Host/Host.c | 26 ++++++++++----------
EmulatorPkg/Unix/Host/LinuxPacketFilter.c | 2 +-
EmulatorPkg/Unix/Host/Pthreads.c | 2 +-
EmulatorPkg/Unix/GdbRun.sh | 4 +--
EmulatorPkg/Unix/Host/X64/Gasket.S | 4 +--
EmulatorPkg/Unix/Host/X64/SwitchStack.S | 2 +-
EmulatorPkg/Unix/lldbefi.py | 14 +++++------
10 files changed, 35 insertions(+), 35 deletions(-)
diff --git a/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c b/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c
index 3013bbc86b27..441f1e8d0afe 100644
--- a/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c
+++ b/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c
@@ -5,7 +5,7 @@
Tested on Mac OS X.
Copyright (c) 2004 - 2019, Intel Corporation. All rights reserved.<BR>
-Portitions copyright (c) 2011, Apple Inc. All rights reserved.
+Portions copyright (c) 2011, Apple Inc. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
diff --git a/EmulatorPkg/Unix/Host/BlockIo.c b/EmulatorPkg/Unix/Host/BlockIo.c
index 07e39347e42b..18368060d59a 100644
--- a/EmulatorPkg/Unix/Host/BlockIo.c
+++ b/EmulatorPkg/Unix/Host/BlockIo.c
@@ -398,7 +398,7 @@ EmuBlockIoReadBlocks (
Done:
if (Token != NULL) {
if (Token->Event != NULL) {
- // Caller is responcible for signaling EFI Event
+ // Caller is responsible for signaling EFI Event
Token->TransactionStatus = Status;
return EFI_SUCCESS;
}
@@ -429,7 +429,7 @@ Done:
the Event is NULL.
@retval EFI_WRITE_PROTECTED The device can not be written to.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_DEVICE_ERROR The device reported an error while performing the write.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The write request contains LBAs that are not valid,
@@ -477,7 +477,7 @@ EmuBlockIoWriteBlocks (
Done:
if (Token != NULL) {
if (Token->Event != NULL) {
- // Caller is responcible for signaling EFI Event
+ // Caller is responsible for signaling EFI Event
Token->TransactionStatus = Status;
return EFI_SUCCESS;
}
@@ -500,7 +500,7 @@ Done:
@retval EFI_SUCCESS The flush request was queued if Event is not NULL.
All outstanding data was written correctly to the
device if the Event is NULL.
- @retval EFI_DEVICE_ERROR The device reported an error while writting back
+ @retval EFI_DEVICE_ERROR The device reported an error while writing back
the data.
@retval EFI_WRITE_PROTECTED The device cannot be written to.
@retval EFI_NO_MEDIA There is no media in the device.
@@ -529,7 +529,7 @@ EmuBlockIoFlushBlocks (
if (Token != NULL) {
if (Token->Event != NULL) {
- // Caller is responcible for signaling EFI Event
+ // Caller is responsible for signaling EFI Event
Token->TransactionStatus = EFI_SUCCESS;
return EFI_SUCCESS;
}
@@ -544,7 +544,7 @@ EmuBlockIoFlushBlocks (
@param[in] This Indicates a pointer to the calling context.
@param[in] ExtendedVerification Indicates that the driver may perform a more
- exhausive verfication operation of the device
+ exhaustive verification operation of the device
during reset.
@retval EFI_SUCCESS The device was reset.
diff --git a/EmulatorPkg/Unix/Host/EmuThunk.c b/EmulatorPkg/Unix/Host/EmuThunk.c
index 1e9dc99187db..b8b0651c6ab0 100644
--- a/EmulatorPkg/Unix/Host/EmuThunk.c
+++ b/EmulatorPkg/Unix/Host/EmuThunk.c
@@ -6,7 +6,7 @@
The mUnixThunkTable exists so that a change to EFI_EMU_THUNK_PROTOCOL
will cause an error in initializing the array if all the member functions
are not added. It looks like adding a element to end and not initializing
- it may cause the table to be initaliized with the members at the end being
+ it may cause the table to be initialized with the members at the end being
set to zero. This is bad as jumping to zero will crash.
Copyright (c) 2004 - 2019, Intel Corporation. All rights reserved.<BR>
diff --git a/EmulatorPkg/Unix/Host/Host.c b/EmulatorPkg/Unix/Host/Host.c
index b431a4c2ed39..b4e5510613c8 100644
--- a/EmulatorPkg/Unix/Host/Host.c
+++ b/EmulatorPkg/Unix/Host/Host.c
@@ -38,7 +38,7 @@ UINTN gFdInfoCount = 0;
EMU_FD_INFO *gFdInfo;
//
-// Array that supports seperate memory rantes.
+// Array that supports separate memory ranges.
// The memory ranges are set in system.cmd via the EFI_MEMORY_SIZE variable.
// The number of array elements is allocated base on parsing
// EFI_MEMORY_SIZE and the memory is never freed.
@@ -379,7 +379,7 @@ Arguments:
Returns:
EFI_SUCCESS - The file was opened and mapped.
EFI_NOT_FOUND - FileName was not found in the current directory
- EFI_DEVICE_ERROR - An error occured attempting to map the opened file
+ EFI_DEVICE_ERROR - An error occurred attempting to map the opened file
**/
EFI_STATUS
@@ -523,7 +523,7 @@ Arguments:
PeiCorePe32File - SEC PE32
Returns:
- Success means control is transfered and thus we should never return
+ Success means control is transferred and thus we should never return
**/
VOID
@@ -611,7 +611,7 @@ Routine Description:
It allows discontinuous memory regions to be supported by the emulator.
It uses gSystemMemory[] and gSystemMemoryCount that were created by
parsing the host environment variable EFI_MEMORY_SIZE.
- The size comes from the varaible and the address comes from the call to
+ The size comes from the variable and the address comes from the call to
UnixOpenFile.
Arguments:
@@ -661,7 +661,7 @@ Routine Description:
This is all of GCD for system memory passed to DXE Core. FV
mapping and other device mapped into system memory are not
- inlcuded in the check.
+ included in the check.
Arguments:
Index - Which memory region to use
@@ -775,7 +775,7 @@ SecPeCoffGetEntryPoint (
Routine Description:
Return the FD Size and base address. Since the FD is loaded from a
- file into host memory only the SEC will know it's address.
+ file into host memory only the SEC will know its address.
Arguments:
Index - Which FD, starts at zero.
@@ -898,7 +898,7 @@ Routine Description:
The ModHandle is needed to unload the image.
Arguments:
- ImageContext - Input data returned from PE Laoder Library. Used to find the
+ ImageContext - Input data returned from PE Loader Library. Used to find the
.PDB file name of the PE Image.
ModHandle - Returned from LoadLibraryEx() and stored for call to
FreeLibrary().
@@ -922,7 +922,7 @@ AddHandle (
for (Index = 0; Index < mImageContextModHandleArraySize; Index++, Array++) {
if (Array->ImageContext == NULL) {
//
- // Make a copy of the stirng and store the ModHandle
+ // Make a copy of the string and store the ModHandle
//
Array->ImageContext = ImageContext;
Array->ModHandle = ModHandle;
@@ -933,7 +933,7 @@ AddHandle (
//
// No free space in mImageContextModHandleArray so grow it by
// IMAGE_CONTEXT_TO_MOD_HANDLE entires. realloc will
- // copy the old values to the new locaiton. But it does
+ // copy the old values to the new location. But it does
// not zero the new memory area.
//
PreviousSize = mImageContextModHandleArraySize * sizeof (IMAGE_CONTEXT_TO_MOD_HANDLE);
@@ -961,11 +961,11 @@ Routine Description:
Return the ModHandle and delete the entry in the array.
Arguments:
- ImageContext - Input data returned from PE Laoder Library. Used to find the
+ ImageContext - Input data returned from PE Loader Library. Used to find the
.PDB file name of the PE Image.
Returns:
- ModHandle - ModHandle assoicated with ImageContext is returned
+ ModHandle - ModHandle associated with ImageContext is returned
NULL - No ModHandle associated with ImageContext
**/
@@ -1129,7 +1129,7 @@ SecGdbScriptBreak (
/**
- Adds the image to a gdb script so it's symbols can be loaded.
+ Adds the image to a gdb script so its symbols can be loaded.
The AddFirmwareSymbolFile helper macro is used.
@param ImageContext The PE/COFF image context
@@ -1202,7 +1202,7 @@ SecPeCoffRelocateImageExtraAction (
/**
- Adds the image to a gdb script so it's symbols can be unloaded.
+ Adds the image to a gdb script so its symbols can be unloaded.
The RemoveFirmwareSymbolFile helper macro is used.
@param ImageContext The PE/COFF image context
diff --git a/EmulatorPkg/Unix/Host/LinuxPacketFilter.c b/EmulatorPkg/Unix/Host/LinuxPacketFilter.c
index a8028d18ff56..2b772ab884c2 100644
--- a/EmulatorPkg/Unix/Host/LinuxPacketFilter.c
+++ b/EmulatorPkg/Unix/Host/LinuxPacketFilter.c
@@ -6,7 +6,7 @@
is just a template that needs to get filled in.
Copyright (c) 2004 - 2009, Intel Corporation. All rights reserved.<BR>
-Portitions copyright (c) 2011, Apple Inc. All rights reserved.
+Portions copyright (c) 2011, Apple Inc. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
diff --git a/EmulatorPkg/Unix/Host/Pthreads.c b/EmulatorPkg/Unix/Host/Pthreads.c
index f07bcfce66f3..025687c356fd 100644
--- a/EmulatorPkg/Unix/Host/Pthreads.c
+++ b/EmulatorPkg/Unix/Host/Pthreads.c
@@ -133,7 +133,7 @@ PthreadCreate (
EnabledOnEntry = FALSE;
}
- // Aquire lock for global, SecFakePthreadStart runs in a different thread.
+ // Acquire lock for global, SecFakePthreadStart runs in a different thread.
pthread_mutex_lock (&mThreadMangle.Mutex);
mThreadMangle.Start = Start;
diff --git a/EmulatorPkg/Unix/GdbRun.sh b/EmulatorPkg/Unix/GdbRun.sh
index 8c761ff2c9b5..b050ad5e2c5c 100644
--- a/EmulatorPkg/Unix/GdbRun.sh
+++ b/EmulatorPkg/Unix/GdbRun.sh
@@ -62,8 +62,8 @@ define RemoveFirmwareSymbolFile
end
if gInXcode == 1
- # in Xcode the program is already runing. Issuing a run command
- # will cause a fatal debugger error. The break point sciprt that
+ # in Xcode the program is already running. Issuing a run command
+ # will cause a fatal debugger error. The break point script that
# is used to source this script sets gInCode to 1.
else
#
diff --git a/EmulatorPkg/Unix/Host/X64/Gasket.S b/EmulatorPkg/Unix/Host/X64/Gasket.S
index a9ca707562f9..030faa8e4c36 100644
--- a/EmulatorPkg/Unix/Host/X64/Gasket.S
+++ b/EmulatorPkg/Unix/Host/X64/Gasket.S
@@ -15,11 +15,11 @@
//
// Gaskets are EFI ABI to UNIX ABI calls
// EFI ABI code will sub 40 (0x28) from %rsp before calling a function
-// This is the 32 (0x20) byte to spill registers and 8 bytes to align stack on 16 byte boundry.
+// This is the 32 (0x20) byte to spill registers and 8 bytes to align stack on 16 byte boundary.
//
.text
-// 32 byte shadow to spill rcx-r9, 8 bytes to align stack on 16 byte boundry
+// 32 byte shadow to spill rcx-r9, 8 bytes to align stack on 16 byte boundary
// Any call with 0 - 4 arguments allocates 40 bytes on the stack.
// For more than 4 args you always have to increase in quanta of 16 so 5 or 6 args is 56,
// 7 or 8 args is 72, and 9 or 10 args is 88
diff --git a/EmulatorPkg/Unix/Host/X64/SwitchStack.S b/EmulatorPkg/Unix/Host/X64/SwitchStack.S
index 4126cc99124a..36838bf29efb 100644
--- a/EmulatorPkg/Unix/Host/X64/SwitchStack.S
+++ b/EmulatorPkg/Unix/Host/X64/SwitchStack.S
@@ -1,7 +1,7 @@
#------------------------------------------------------------------------------
#
# Copyright (c) 2006 - 2008, Intel Corporation. All rights reserved.<BR>
-# Portitions copyright (c) 2011, Apple Inc. All rights reserved.
+# Portions copyright (c) 2011, Apple Inc. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
#------------------------------------------------------------------------------
diff --git a/EmulatorPkg/Unix/lldbefi.py b/EmulatorPkg/Unix/lldbefi.py
index 7f99a7f83fcc..c3fb2675cbc1 100755
--- a/EmulatorPkg/Unix/lldbefi.py
+++ b/EmulatorPkg/Unix/lldbefi.py
@@ -1,7 +1,7 @@
#!/usr/bin/python
#
-# Copyright 2014 Apple Inc. All righes reserved.
+# Copyright 2014 Apple Inc. All rights reserved.
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -278,7 +278,7 @@ def EFI_DEVICE_PATH_PROTOCOL_TypeSummary (valobj,internal_dict):
Address = long ("%d" % valobj.addr)
if (Address == lldb.LLDB_INVALID_ADDRESS):
- # Need to reserach this, it seems to be the nested struct case
+ # Need to research this, it seems to be the nested struct case
ExprStr = ""
elif (Type & 0x7f == 0x7f):
ExprStr = "End Device Path" if SubType == 0xff else "End This Instance"
@@ -304,7 +304,7 @@ def EFI_DEVICE_PATH_PROTOCOL_TypeSummary (valobj,internal_dict):
def TypePrintFormating(debugger):
#
- # Set the default print formating for EFI types in lldb.
+ # Set the default print formatting for EFI types in lldb.
# seems lldb defaults to decimal.
#
category = debugger.GetDefaultCategory()
@@ -390,7 +390,7 @@ def LoadEmulatorEfiSymbols(frame, bp_loc , internal_dict):
FileName = frame.thread.process.ReadCStringFromMemory (FileNamePtr, FileNameLen, Error)
if not Error.Success():
print "!ReadCStringFromMemory() did not find a %d byte C string at %x" % (FileNameLen, FileNamePtr)
- # make breakpoint command contiue
+ # make breakpoint command continue
return False
debugger = frame.thread.process.target.debugger
@@ -410,12 +410,12 @@ def LoadEmulatorEfiSymbols(frame, bp_loc , internal_dict):
if not target.RemoveModule (SBModule):
print "!lldb.target.RemoveModule (%s) FAILED" % SBModule
- # make breakpoint command contiue
+ # make breakpoint command continue
return False
def GuidToCStructStr (guid, Name=False):
#
- # Convert a 16-byte bytesarry (or bytearray compat object) to C guid string
+ # Convert a 16-byte bytesarray (or bytearray compat object) to C guid string
# { 0xB402621F, 0xA940, 0x1E4A, { 0x86, 0x6B, 0x4D, 0xC9, 0x16, 0x2B, 0x34, 0x7C } }
#
# Name=True means lookup name in GuidNameDict and us it if you find it
@@ -522,7 +522,7 @@ def __lldb_init_module (debugger, internal_dict):
if len(data) >= 2:
guid_dict[data[0].upper()] = data[1].strip('\n')
- # init EFI specific type formaters
+ # init EFI specific type formatters
TypePrintFormating (debugger)
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [PATCH 06/79] EmulatorPkg/Unix: Fix various typos
2019-12-03 16:14 ` [PATCH 06/79] EmulatorPkg/Unix: " Philippe Mathieu-Daudé
@ 2019-12-20 6:38 ` Ni, Ray
0 siblings, 0 replies; 122+ messages in thread
From: Ni, Ray @ 2019-12-20 6:38 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Justen, Jordan L, Andrew Fish
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Philippe Mathieu-Daude <philmd@redhat.com>
> Sent: Wednesday, December 4, 2019 12:15 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Andrew Fish <afish@apple.com>; Ni, Ray
> <ray.ni@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
> Subject: [PATCH 06/79] EmulatorPkg/Unix: Fix various typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Coeur <coeur@gmx.fr>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 2 +-
> EmulatorPkg/Unix/Host/BlockIo.c | 12 ++++-----
> EmulatorPkg/Unix/Host/EmuThunk.c | 2 +-
> EmulatorPkg/Unix/Host/Host.c | 26 ++++++++++----------
> EmulatorPkg/Unix/Host/LinuxPacketFilter.c | 2 +-
> EmulatorPkg/Unix/Host/Pthreads.c | 2 +-
> EmulatorPkg/Unix/GdbRun.sh | 4 +--
> EmulatorPkg/Unix/Host/X64/Gasket.S | 4 +--
> EmulatorPkg/Unix/Host/X64/SwitchStack.S | 2 +-
> EmulatorPkg/Unix/lldbefi.py | 14 +++++------
> 10 files changed, 35 insertions(+), 35 deletions(-)
>
> diff --git a/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c
> b/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c
> index 3013bbc86b27..441f1e8d0afe 100644
> --- a/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c
> +++ b/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c
> @@ -5,7 +5,7 @@
> Tested on Mac OS X.
>
> Copyright (c) 2004 - 2019, Intel Corporation. All rights reserved.<BR>
> -Portitions copyright (c) 2011, Apple Inc. All rights reserved.
> +Portions copyright (c) 2011, Apple Inc. All rights reserved.
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> diff --git a/EmulatorPkg/Unix/Host/BlockIo.c
> b/EmulatorPkg/Unix/Host/BlockIo.c
> index 07e39347e42b..18368060d59a 100644
> --- a/EmulatorPkg/Unix/Host/BlockIo.c
> +++ b/EmulatorPkg/Unix/Host/BlockIo.c
> @@ -398,7 +398,7 @@ EmuBlockIoReadBlocks (
> Done:
> if (Token != NULL) {
> if (Token->Event != NULL) {
> - // Caller is responcible for signaling EFI Event
> + // Caller is responsible for signaling EFI Event
> Token->TransactionStatus = Status;
> return EFI_SUCCESS;
> }
> @@ -429,7 +429,7 @@ Done:
> the Event is NULL.
> @retval EFI_WRITE_PROTECTED The device can not be written to.
> @retval EFI_NO_MEDIA There is no media in the device.
> - @retval EFI_MEDIA_CHNAGED The MediaId does not matched the
> current device.
> + @retval EFI_MEDIA_CHANGED The MediaId does not match the current
> device.
> @retval EFI_DEVICE_ERROR The device reported an error while
> performing the write.
> @retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block
> size of the device.
> @retval EFI_INVALID_PARAMETER The write request contains LBAs that are
> not valid,
> @@ -477,7 +477,7 @@ EmuBlockIoWriteBlocks (
> Done:
> if (Token != NULL) {
> if (Token->Event != NULL) {
> - // Caller is responcible for signaling EFI Event
> + // Caller is responsible for signaling EFI Event
> Token->TransactionStatus = Status;
> return EFI_SUCCESS;
> }
> @@ -500,7 +500,7 @@ Done:
> @retval EFI_SUCCESS The flush request was queued if Event is not
> NULL.
> All outstanding data was written correctly to the
> device if the Event is NULL.
> - @retval EFI_DEVICE_ERROR The device reported an error while writting
> back
> + @retval EFI_DEVICE_ERROR The device reported an error while writing
> back
> the data.
> @retval EFI_WRITE_PROTECTED The device cannot be written to.
> @retval EFI_NO_MEDIA There is no media in the device.
> @@ -529,7 +529,7 @@ EmuBlockIoFlushBlocks (
>
> if (Token != NULL) {
> if (Token->Event != NULL) {
> - // Caller is responcible for signaling EFI Event
> + // Caller is responsible for signaling EFI Event
> Token->TransactionStatus = EFI_SUCCESS;
> return EFI_SUCCESS;
> }
> @@ -544,7 +544,7 @@ EmuBlockIoFlushBlocks (
>
> @param[in] This Indicates a pointer to the calling context.
> @param[in] ExtendedVerification Indicates that the driver may perform a
> more
> - exhausive verfication operation of the device
> + exhaustive verification operation of the device
> during reset.
>
> @retval EFI_SUCCESS The device was reset.
> diff --git a/EmulatorPkg/Unix/Host/EmuThunk.c
> b/EmulatorPkg/Unix/Host/EmuThunk.c
> index 1e9dc99187db..b8b0651c6ab0 100644
> --- a/EmulatorPkg/Unix/Host/EmuThunk.c
> +++ b/EmulatorPkg/Unix/Host/EmuThunk.c
> @@ -6,7 +6,7 @@
> The mUnixThunkTable exists so that a change to
> EFI_EMU_THUNK_PROTOCOL
> will cause an error in initializing the array if all the member functions
> are not added. It looks like adding a element to end and not initializing
> - it may cause the table to be initaliized with the members at the end being
> + it may cause the table to be initialized with the members at the end being
> set to zero. This is bad as jumping to zero will crash.
>
> Copyright (c) 2004 - 2019, Intel Corporation. All rights reserved.<BR>
> diff --git a/EmulatorPkg/Unix/Host/Host.c b/EmulatorPkg/Unix/Host/Host.c
> index b431a4c2ed39..b4e5510613c8 100644
> --- a/EmulatorPkg/Unix/Host/Host.c
> +++ b/EmulatorPkg/Unix/Host/Host.c
> @@ -38,7 +38,7 @@ UINTN gFdInfoCount = 0;
> EMU_FD_INFO *gFdInfo;
>
> //
> -// Array that supports seperate memory rantes.
> +// Array that supports separate memory ranges.
> // The memory ranges are set in system.cmd via the EFI_MEMORY_SIZE
> variable.
> // The number of array elements is allocated base on parsing
> // EFI_MEMORY_SIZE and the memory is never freed.
> @@ -379,7 +379,7 @@ Arguments:
> Returns:
> EFI_SUCCESS - The file was opened and mapped.
> EFI_NOT_FOUND - FileName was not found in the current directory
> - EFI_DEVICE_ERROR - An error occured attempting to map the opened file
> + EFI_DEVICE_ERROR - An error occurred attempting to map the opened file
>
> **/
> EFI_STATUS
> @@ -523,7 +523,7 @@ Arguments:
> PeiCorePe32File - SEC PE32
>
> Returns:
> - Success means control is transfered and thus we should never return
> + Success means control is transferred and thus we should never return
>
> **/
> VOID
> @@ -611,7 +611,7 @@ Routine Description:
> It allows discontinuous memory regions to be supported by the emulator.
> It uses gSystemMemory[] and gSystemMemoryCount that were created by
> parsing the host environment variable EFI_MEMORY_SIZE.
> - The size comes from the varaible and the address comes from the call to
> + The size comes from the variable and the address comes from the call to
> UnixOpenFile.
>
> Arguments:
> @@ -661,7 +661,7 @@ Routine Description:
>
> This is all of GCD for system memory passed to DXE Core. FV
> mapping and other device mapped into system memory are not
> - inlcuded in the check.
> + included in the check.
>
> Arguments:
> Index - Which memory region to use
> @@ -775,7 +775,7 @@ SecPeCoffGetEntryPoint (
>
> Routine Description:
> Return the FD Size and base address. Since the FD is loaded from a
> - file into host memory only the SEC will know it's address.
> + file into host memory only the SEC will know its address.
>
> Arguments:
> Index - Which FD, starts at zero.
> @@ -898,7 +898,7 @@ Routine Description:
> The ModHandle is needed to unload the image.
>
> Arguments:
> - ImageContext - Input data returned from PE Laoder Library. Used to find
> the
> + ImageContext - Input data returned from PE Loader Library. Used to find
> the
> .PDB file name of the PE Image.
> ModHandle - Returned from LoadLibraryEx() and stored for call to
> FreeLibrary().
> @@ -922,7 +922,7 @@ AddHandle (
> for (Index = 0; Index < mImageContextModHandleArraySize; Index++,
> Array++) {
> if (Array->ImageContext == NULL) {
> //
> - // Make a copy of the stirng and store the ModHandle
> + // Make a copy of the string and store the ModHandle
> //
> Array->ImageContext = ImageContext;
> Array->ModHandle = ModHandle;
> @@ -933,7 +933,7 @@ AddHandle (
> //
> // No free space in mImageContextModHandleArray so grow it by
> // IMAGE_CONTEXT_TO_MOD_HANDLE entires. realloc will
> - // copy the old values to the new locaiton. But it does
> + // copy the old values to the new location. But it does
> // not zero the new memory area.
> //
> PreviousSize = mImageContextModHandleArraySize * sizeof
> (IMAGE_CONTEXT_TO_MOD_HANDLE);
> @@ -961,11 +961,11 @@ Routine Description:
> Return the ModHandle and delete the entry in the array.
>
> Arguments:
> - ImageContext - Input data returned from PE Laoder Library. Used to find
> the
> + ImageContext - Input data returned from PE Loader Library. Used to find
> the
> .PDB file name of the PE Image.
>
> Returns:
> - ModHandle - ModHandle assoicated with ImageContext is returned
> + ModHandle - ModHandle associated with ImageContext is returned
> NULL - No ModHandle associated with ImageContext
>
> **/
> @@ -1129,7 +1129,7 @@ SecGdbScriptBreak (
>
>
> /**
> - Adds the image to a gdb script so it's symbols can be loaded.
> + Adds the image to a gdb script so its symbols can be loaded.
> The AddFirmwareSymbolFile helper macro is used.
>
> @param ImageContext The PE/COFF image context
> @@ -1202,7 +1202,7 @@ SecPeCoffRelocateImageExtraAction (
>
>
> /**
> - Adds the image to a gdb script so it's symbols can be unloaded.
> + Adds the image to a gdb script so its symbols can be unloaded.
> The RemoveFirmwareSymbolFile helper macro is used.
>
> @param ImageContext The PE/COFF image context
> diff --git a/EmulatorPkg/Unix/Host/LinuxPacketFilter.c
> b/EmulatorPkg/Unix/Host/LinuxPacketFilter.c
> index a8028d18ff56..2b772ab884c2 100644
> --- a/EmulatorPkg/Unix/Host/LinuxPacketFilter.c
> +++ b/EmulatorPkg/Unix/Host/LinuxPacketFilter.c
> @@ -6,7 +6,7 @@
> is just a template that needs to get filled in.
>
> Copyright (c) 2004 - 2009, Intel Corporation. All rights reserved.<BR>
> -Portitions copyright (c) 2011, Apple Inc. All rights reserved.
> +Portions copyright (c) 2011, Apple Inc. All rights reserved.
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> diff --git a/EmulatorPkg/Unix/Host/Pthreads.c
> b/EmulatorPkg/Unix/Host/Pthreads.c
> index f07bcfce66f3..025687c356fd 100644
> --- a/EmulatorPkg/Unix/Host/Pthreads.c
> +++ b/EmulatorPkg/Unix/Host/Pthreads.c
> @@ -133,7 +133,7 @@ PthreadCreate (
> EnabledOnEntry = FALSE;
> }
>
> - // Aquire lock for global, SecFakePthreadStart runs in a different thread.
> + // Acquire lock for global, SecFakePthreadStart runs in a different thread.
> pthread_mutex_lock (&mThreadMangle.Mutex);
> mThreadMangle.Start = Start;
>
> diff --git a/EmulatorPkg/Unix/GdbRun.sh b/EmulatorPkg/Unix/GdbRun.sh
> index 8c761ff2c9b5..b050ad5e2c5c 100644
> --- a/EmulatorPkg/Unix/GdbRun.sh
> +++ b/EmulatorPkg/Unix/GdbRun.sh
> @@ -62,8 +62,8 @@ define RemoveFirmwareSymbolFile
> end
>
> if gInXcode == 1
> - # in Xcode the program is already runing. Issuing a run command
> - # will cause a fatal debugger error. The break point sciprt that
> + # in Xcode the program is already running. Issuing a run command
> + # will cause a fatal debugger error. The break point script that
> # is used to source this script sets gInCode to 1.
> else
> #
> diff --git a/EmulatorPkg/Unix/Host/X64/Gasket.S
> b/EmulatorPkg/Unix/Host/X64/Gasket.S
> index a9ca707562f9..030faa8e4c36 100644
> --- a/EmulatorPkg/Unix/Host/X64/Gasket.S
> +++ b/EmulatorPkg/Unix/Host/X64/Gasket.S
> @@ -15,11 +15,11 @@
> //
> // Gaskets are EFI ABI to UNIX ABI calls
> // EFI ABI code will sub 40 (0x28) from %rsp before calling a function
> -// This is the 32 (0x20) byte to spill registers and 8 bytes to align stack on 16
> byte boundry.
> +// This is the 32 (0x20) byte to spill registers and 8 bytes to align stack on 16
> byte boundary.
> //
> .text
>
> -// 32 byte shadow to spill rcx-r9, 8 bytes to align stack on 16 byte boundry
> +// 32 byte shadow to spill rcx-r9, 8 bytes to align stack on 16 byte boundary
> // Any call with 0 - 4 arguments allocates 40 bytes on the stack.
> // For more than 4 args you always have to increase in quanta of 16 so 5 or 6
> args is 56,
> // 7 or 8 args is 72, and 9 or 10 args is 88
> diff --git a/EmulatorPkg/Unix/Host/X64/SwitchStack.S
> b/EmulatorPkg/Unix/Host/X64/SwitchStack.S
> index 4126cc99124a..36838bf29efb 100644
> --- a/EmulatorPkg/Unix/Host/X64/SwitchStack.S
> +++ b/EmulatorPkg/Unix/Host/X64/SwitchStack.S
> @@ -1,7 +1,7 @@
> #------------------------------------------------------------------------------
> #
> # Copyright (c) 2006 - 2008, Intel Corporation. All rights reserved.<BR>
> -# Portitions copyright (c) 2011, Apple Inc. All rights reserved.
> +# Portions copyright (c) 2011, Apple Inc. All rights reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> #------------------------------------------------------------------------------
> diff --git a/EmulatorPkg/Unix/lldbefi.py b/EmulatorPkg/Unix/lldbefi.py
> index 7f99a7f83fcc..c3fb2675cbc1 100755
> --- a/EmulatorPkg/Unix/lldbefi.py
> +++ b/EmulatorPkg/Unix/lldbefi.py
> @@ -1,7 +1,7 @@
> #!/usr/bin/python
>
> #
> -# Copyright 2014 Apple Inc. All righes reserved.
> +# Copyright 2014 Apple Inc. All rights reserved.
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -278,7 +278,7 @@ def EFI_DEVICE_PATH_PROTOCOL_TypeSummary
> (valobj,internal_dict):
>
> Address = long ("%d" % valobj.addr)
> if (Address == lldb.LLDB_INVALID_ADDRESS):
> - # Need to reserach this, it seems to be the nested struct case
> + # Need to research this, it seems to be the nested struct case
> ExprStr = ""
> elif (Type & 0x7f == 0x7f):
> ExprStr = "End Device Path" if SubType == 0xff else "End This Instance"
> @@ -304,7 +304,7 @@ def EFI_DEVICE_PATH_PROTOCOL_TypeSummary
> (valobj,internal_dict):
>
> def TypePrintFormating(debugger):
> #
> - # Set the default print formating for EFI types in lldb.
> + # Set the default print formatting for EFI types in lldb.
> # seems lldb defaults to decimal.
> #
> category = debugger.GetDefaultCategory()
> @@ -390,7 +390,7 @@ def LoadEmulatorEfiSymbols(frame, bp_loc ,
> internal_dict):
> FileName = frame.thread.process.ReadCStringFromMemory (FileNamePtr,
> FileNameLen, Error)
> if not Error.Success():
> print "!ReadCStringFromMemory() did not find a %d byte C string at %x" %
> (FileNameLen, FileNamePtr)
> - # make breakpoint command contiue
> + # make breakpoint command continue
> return False
>
> debugger = frame.thread.process.target.debugger
> @@ -410,12 +410,12 @@ def LoadEmulatorEfiSymbols(frame, bp_loc ,
> internal_dict):
> if not target.RemoveModule (SBModule):
> print "!lldb.target.RemoveModule (%s) FAILED" % SBModule
>
> - # make breakpoint command contiue
> + # make breakpoint command continue
> return False
>
> def GuidToCStructStr (guid, Name=False):
> #
> - # Convert a 16-byte bytesarry (or bytearray compat object) to C guid string
> + # Convert a 16-byte bytesarray (or bytearray compat object) to C guid
> string
> # { 0xB402621F, 0xA940, 0x1E4A, { 0x86, 0x6B, 0x4D, 0xC9, 0x16, 0x2B, 0x34,
> 0x7C } }
> #
> # Name=True means lookup name in GuidNameDict and us it if you find it
> @@ -522,7 +522,7 @@ def __lldb_init_module (debugger, internal_dict):
> if len(data) >= 2:
> guid_dict[data[0].upper()] = data[1].strip('\n')
>
> - # init EFI specific type formaters
> + # init EFI specific type formatters
> TypePrintFormating (debugger)
>
>
> --
> 2.21.0
^ permalink raw reply [flat|nested] 122+ messages in thread
* [PATCH 07/79] EmulatorPkg/Win: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (5 preceding siblings ...)
2019-12-03 16:14 ` [PATCH 06/79] EmulatorPkg/Unix: " Philippe Mathieu-Daudé
@ 2019-12-03 16:14 ` Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 08/79] FatPkg/EnhancedFatDxe: " Philippe Mathieu-Daudé
` (65 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:14 UTC (permalink / raw)
To: devel
Cc: Antoine Coeur, Jordan Justen, Andrew Fish, Ray Ni,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
EmulatorPkg/Win/Host/WinGop.h | 2 +-
EmulatorPkg/Win/Host/WinHost.h | 2 +-
EmulatorPkg/Win/Host/WinBlockIo.c | 4 ++--
EmulatorPkg/Win/Host/WinFileSystem.c | 2 +-
EmulatorPkg/Win/Host/WinGopInput.c | 4 ++--
EmulatorPkg/Win/Host/WinGopScreen.c | 14 +++++++-------
EmulatorPkg/Win/Host/WinHost.c | 10 +++++-----
7 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/EmulatorPkg/Win/Host/WinGop.h b/EmulatorPkg/Win/Host/WinGop.h
index 5943ca93b22f..7a8f01a37c92 100644
--- a/EmulatorPkg/Win/Host/WinGop.h
+++ b/EmulatorPkg/Win/Host/WinGop.h
@@ -78,7 +78,7 @@ typedef struct {
UINT32 Width;
UINT32 Height;
//
- // This screen is used to redraw the scree when windows events happen. It's
+ // This screen is used to redraw the screen when windows events happen. It's
// updated in the main thread and displayed in the windows thread.
//
BITMAPV4HEADER *VirtualScreenInfo;
diff --git a/EmulatorPkg/Win/Host/WinHost.h b/EmulatorPkg/Win/Host/WinHost.h
index 185d864986ff..0e52c003fc63 100644
--- a/EmulatorPkg/Win/Host/WinHost.h
+++ b/EmulatorPkg/Win/Host/WinHost.h
@@ -82,7 +82,7 @@ Arguments:
SecCorePe32File - SEC Core PE32
Returns:
- Success means control is transfered and thus we should never return
+ Success means control is transferred and thus we should never return
--*/
;
diff --git a/EmulatorPkg/Win/Host/WinBlockIo.c b/EmulatorPkg/Win/Host/WinBlockIo.c
index 5ccd17388ea8..715d0c26cdbc 100644
--- a/EmulatorPkg/Win/Host/WinBlockIo.c
+++ b/EmulatorPkg/Win/Host/WinBlockIo.c
@@ -346,7 +346,7 @@ WinNtBlockIoReadBlocks (
the Event is NULL.
@retval EFI_WRITE_PROTECTED The device can not be written to.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_DEVICE_ERROR The device reported an error while performing the write.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The write request contains LBAs that are not valid,
@@ -411,7 +411,7 @@ WinNtBlockIoWriteBlocks (
@retval EFI_SUCCESS The flush request was queued if Event is not NULL.
All outstanding data was written correctly to the
device if the Event is NULL.
- @retval EFI_DEVICE_ERROR The device reported an error while writting back
+ @retval EFI_DEVICE_ERROR The device reported an error while writing back
the data.
@retval EFI_WRITE_PROTECTED The device cannot be written to.
@retval EFI_NO_MEDIA There is no media in the device.
diff --git a/EmulatorPkg/Win/Host/WinFileSystem.c b/EmulatorPkg/Win/Host/WinFileSystem.c
index aab926889e0a..f6b06b1c9204 100644
--- a/EmulatorPkg/Win/Host/WinFileSystem.c
+++ b/EmulatorPkg/Win/Host/WinFileSystem.c
@@ -391,7 +391,7 @@ GetNextFileNameToken (
If FileName contains only a single L'\', return TRUE.
If FileName contains two adjacent L'\', return FALSE.
If FileName conatins L'/' , return FALSE.
- If FielName contains more than two dots seperated with other FileName characters
+ If FileName contains more than two dots separated with other FileName characters
by L'\', return FALSE. For example, L'.\...\filename.txt' is invalid path name. But L'..TwoDots\filename.txt' is valid path name.
@param FileName The File Name String to check.
diff --git a/EmulatorPkg/Win/Host/WinGopInput.c b/EmulatorPkg/Win/Host/WinGopInput.c
index 312a549847c5..6ae7aa4c371b 100644
--- a/EmulatorPkg/Win/Host/WinGopInput.c
+++ b/EmulatorPkg/Win/Host/WinGopInput.c
@@ -300,7 +300,7 @@ WinNtWndGetKey (
Routine Description:
Reads the next keystroke from the input device. The WaitForKey Event can
- be used to test for existance of a keystroke via WaitForEvent () call.
+ be used to test for existence of a keystroke via WaitForEvent () call.
Arguments:
Private - The private structure of WinNt Gop device.
@@ -309,7 +309,7 @@ WinNtWndGetKey (
Returns:
EFI_SUCCESS - The keystroke information was returned.
- EFI_NOT_READY - There was no keystroke data availiable.
+ EFI_NOT_READY - There was no keystroke data available.
EFI_DEVICE_ERROR - The keystroke information was not returned due to
hardware errors.
EFI_INVALID_PARAMETER - KeyData is NULL.
diff --git a/EmulatorPkg/Win/Host/WinGopScreen.c b/EmulatorPkg/Win/Host/WinGopScreen.c
index fa34596497f8..74011e225e30 100644
--- a/EmulatorPkg/Win/Host/WinGopScreen.c
+++ b/EmulatorPkg/Win/Host/WinGopScreen.c
@@ -297,7 +297,7 @@ WinNtWndSize (
@param X X location on graphics screen.
@param Y Y location on the graphics screen.
@param Width Width of BltBuffer.
- @param Height Hight of BltBuffer
+ @param Height Height of BltBuffer
@param BltOperation Operation to perform on BltBuffer and video memory
@param BltBuffer Buffer containing data to blt into video buffer.
This buffer has a size of
@@ -311,7 +311,7 @@ WinNtWndSize (
@retval EFI_SUCCESS The palette is updated with PaletteArray.
@retval EFI_INVALID_PARAMETER BltOperation is not valid.
- @retval EFI_DEVICE_ERROR A hardware error occured writting to the video
+ @retval EFI_DEVICE_ERROR A hardware error occurred writing to the video
buffer.
**/
@@ -593,11 +593,11 @@ WinNtGopThreadWindowProc (
/**
- This thread simulates the end of WinMain () aplication. Each Winow nededs
- to process it's events. The messages are dispatched to
+ This thread simulates the end of WinMain () application. Each Window needs
+ to process its events. The messages are dispatched to
WinNtGopThreadWindowProc ().
- Be very careful sine WinNtGopThreadWinMain () and WinNtGopThreadWindowProc ()
- are running in a seperate thread. We have to do this to process the events.
+ Be very careful since WinNtGopThreadWinMain () and WinNtGopThreadWindowProc ()
+ are running in a separate thread. We have to do this to process the events.
@param lpParameter Handle of window to manage.
@@ -679,7 +679,7 @@ WinNtGopThreadWinMain (
);
//
- // The reset of this thread is the standard winows program. We need a sperate
+ // The reset of this thread is the standard windows program. We need a separate
// thread since we must process the message loop to make windows act like
// windows.
//
diff --git a/EmulatorPkg/Win/Host/WinHost.c b/EmulatorPkg/Win/Host/WinHost.c
index 62a89f7617af..cfee156b27b4 100644
--- a/EmulatorPkg/Win/Host/WinHost.c
+++ b/EmulatorPkg/Win/Host/WinHost.c
@@ -48,7 +48,7 @@ UINTN gFdInfoCount = 0;
NT_FD_INFO *gFdInfo;
//
-// Array that supports seperate memory rantes.
+// Array that supports separate memory ranges.
// The memory ranges are set by PcdWinNtMemorySizeForSecMain.
// The number of array elements is allocated base on parsing
// PcdWinNtMemorySizeForSecMain value and the memory is never freed.
@@ -105,7 +105,7 @@ WinPeiAutoScan (
Routine Description:
Return the FD Size and base address. Since the FD is loaded from a
- file into host memory only the SEC will know it's address.
+ file into host memory only the SEC will know its address.
Arguments:
Index - Which FD, starts at zero.
@@ -273,7 +273,7 @@ Arguments:
Returns:
EFI_SUCCESS - The file was opened and mapped.
EFI_NOT_FOUND - FileName was not found in the current directory
- EFI_DEVICE_ERROR - An error occured attempting to map the opened file
+ EFI_DEVICE_ERROR - An error occurred attempting to map the opened file
--*/
{
@@ -625,7 +625,7 @@ Arguments:
SecCorePe32File - SEC Core PE32
Returns:
- Success means control is transfered and thus we should never return
+ Success means control is transferred and thus we should never return
--*/
{
@@ -993,7 +993,7 @@ PeCoffLoaderRelocateImageExtraAction (
// the *.dll file as a library using Windows* APIs. This allows
// source level debug. The image is still loaded and relocated
// in the Framework memory space like on a real system (by the code above),
- // but the entry point points into the DLL loaded by the code bellow.
+ // but the entry point points into the DLL loaded by the code below.
//
DllEntryPoint = NULL;
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* [PATCH 08/79] FatPkg/EnhancedFatDxe: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (6 preceding siblings ...)
2019-12-03 16:14 ` [PATCH 07/79] EmulatorPkg/Win: " Philippe Mathieu-Daudé
@ 2019-12-03 16:14 ` Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 09/79] FatPkg/FatPei: Fix few typos Philippe Mathieu-Daudé
` (64 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:14 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Ray Ni, Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in FatPkg/EnhancedFatDxe comments.
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Coeur <coeur@gmx.fr>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
FatPkg/EnhancedFatDxe/Fat.h | 6 +++---
FatPkg/EnhancedFatDxe/Delete.c | 2 +-
FatPkg/EnhancedFatDxe/DirectoryManage.c | 2 +-
FatPkg/EnhancedFatDxe/Fat.c | 2 +-
FatPkg/EnhancedFatDxe/FileName.c | 2 +-
FatPkg/EnhancedFatDxe/FileSpace.c | 6 +++---
FatPkg/EnhancedFatDxe/Flush.c | 4 ++--
7 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/FatPkg/EnhancedFatDxe/Fat.h b/FatPkg/EnhancedFatDxe/Fat.h
index 46c185c3a9e9..fcc25952d495 100644
--- a/FatPkg/EnhancedFatDxe/Fat.h
+++ b/FatPkg/EnhancedFatDxe/Fat.h
@@ -236,7 +236,7 @@ struct _FAT_OFILE {
UINTN Signature;
FAT_VOLUME *Volume;
//
- // A permanant error code to return to all accesses to
+ // A permanent error code to return to all accesses to
// this opened file
//
EFI_STATUS Error;
@@ -246,7 +246,7 @@ struct _FAT_OFILE {
LIST_ENTRY Opens;
//
- // The dynamic infomation
+ // The dynamic information
//
UINTN FileSize;
UINTN FileCluster;
@@ -1863,7 +1863,7 @@ FatCreate8Dot3Name (
@param FatName - The Char8 string needs to be converted.
@param Len - The length of the fat name.
@param LowerCase - Indicate whether to convert the string to lower case.
- @param Str - The result of the convertion.
+ @param Str - The result of the conversion.
**/
VOID
diff --git a/FatPkg/EnhancedFatDxe/Delete.c b/FatPkg/EnhancedFatDxe/Delete.c
index b2a62b35ded8..8a437e3ee201 100644
--- a/FatPkg/EnhancedFatDxe/Delete.c
+++ b/FatPkg/EnhancedFatDxe/Delete.c
@@ -56,7 +56,7 @@ FatDelete (
goto Done;
}
//
- // If the file has a permanant error, skip the delete
+ // If the file has a permanent error, skip the delete
//
Status = OFile->Error;
if (!EFI_ERROR (Status)) {
diff --git a/FatPkg/EnhancedFatDxe/DirectoryManage.c b/FatPkg/EnhancedFatDxe/DirectoryManage.c
index 93772dba09c2..90c01b3baa1c 100644
--- a/FatPkg/EnhancedFatDxe/DirectoryManage.c
+++ b/FatPkg/EnhancedFatDxe/DirectoryManage.c
@@ -13,7 +13,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
Get a directory entry from disk for the Ofile.
@param Parent - The parent of the OFile which need to update.
- @param IoMode - Indicate whether to read directory entry or write directroy entry.
+ @param IoMode - Indicate whether to read directory entry or write directory entry.
@param EntryPos - The position of the directory entry to be accessed.
@param Entry - The directory entry read or written.
diff --git a/FatPkg/EnhancedFatDxe/Fat.c b/FatPkg/EnhancedFatDxe/Fat.c
index 3bec1c94ecd8..77cda1953991 100644
--- a/FatPkg/EnhancedFatDxe/Fat.c
+++ b/FatPkg/EnhancedFatDxe/Fat.c
@@ -417,7 +417,7 @@ FatDriverBindingStart (
Status = FatAllocateVolume (ControllerHandle, DiskIo, DiskIo2, BlockIo);
//
- // When the media changes on a device it will Reinstall the BlockIo interaface.
+ // When the media changes on a device it will Reinstall the BlockIo interface.
// This will cause a call to our Stop(), and a subsequent reentrant call to our
// Start() successfully. We should leave the device open when this happen.
//
diff --git a/FatPkg/EnhancedFatDxe/FileName.c b/FatPkg/EnhancedFatDxe/FileName.c
index 256db309545a..d2d1fb31174c 100644
--- a/FatPkg/EnhancedFatDxe/FileName.c
+++ b/FatPkg/EnhancedFatDxe/FileName.c
@@ -128,7 +128,7 @@ FatTrimAsciiTrailingBlanks (
@param FatName - The Char8 string needs to be converted.
@param Len - The length of the fat name.
@param LowerCase - Indicate whether to convert the string to lower case.
- @param Str - The result of the convertion.
+ @param Str - The result of the conversion.
**/
VOID
diff --git a/FatPkg/EnhancedFatDxe/FileSpace.c b/FatPkg/EnhancedFatDxe/FileSpace.c
index 0dd66e0c53af..f57e44e3680a 100644
--- a/FatPkg/EnhancedFatDxe/FileSpace.c
+++ b/FatPkg/EnhancedFatDxe/FileSpace.c
@@ -223,7 +223,7 @@ FatSetFatEntry (
/**
- Free the cluster clain.
+ Free the cluster chain.
@param Volume - FAT file system volume.
@param Cluster - The first cluster of cluster chain.
@@ -575,8 +575,8 @@ FatOFilePosition (
ASSERT_VOLUME_LOCKED (Volume);
//
- // If this is the fixed root dir, then compute it's position
- // from it's fixed info in the fat bpb
+ // If this is the fixed root dir, then compute its position
+ // from its fixed info in the fat bpb
//
if (OFile->IsFixedRootDir) {
OFile->PosDisk = Volume->RootPos + Position;
diff --git a/FatPkg/EnhancedFatDxe/Flush.c b/FatPkg/EnhancedFatDxe/Flush.c
index e88557d77c8a..d53279107527 100644
--- a/FatPkg/EnhancedFatDxe/Flush.c
+++ b/FatPkg/EnhancedFatDxe/Flush.c
@@ -226,7 +226,7 @@ FatOFileFlush (
//
do {
//
- // If the file has a permanant error, then don't write any
+ // If the file has a permanent error, then don't write any
// of its data to the device (may be from different media)
//
if (EFI_ERROR (OFile->Error)) {
@@ -319,7 +319,7 @@ FatCheckOFileRef (
Check the references of all open files on the volume.
Any open file (that is checked) that is no longer
- referenced, is freed - and it's parent open file
+ referenced, is freed - and its parent open file
is then referenced checked.
@param Volume - The volume to check the pending open file list.
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* [PATCH 09/79] FatPkg/FatPei: Fix few typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (7 preceding siblings ...)
2019-12-03 16:14 ` [PATCH 08/79] FatPkg/EnhancedFatDxe: " Philippe Mathieu-Daudé
@ 2019-12-03 16:14 ` Philippe Mathieu-Daudé
2019-12-20 6:37 ` Ni, Ray
2019-12-03 16:14 ` [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos Philippe Mathieu-Daudé
` (63 subsequent siblings)
72 siblings, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:14 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Ray Ni, Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix few typos in comments.
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Coeur <coeur@gmx.fr>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
FatPkg/FatPei/FatLitePeim.h | 2 +-
FatPkg/FatPei/FatLiteApi.c | 2 +-
FatPkg/FatPei/Mbr.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/FatPkg/FatPei/FatLitePeim.h b/FatPkg/FatPei/FatLitePeim.h
index 9cacf74aceeb..0c3c69853ca6 100644
--- a/FatPkg/FatPei/FatLitePeim.h
+++ b/FatPkg/FatPei/FatLitePeim.h
@@ -185,7 +185,7 @@ typedef struct {
/**
Finds the recovery file on a FAT volume.
- This function finds the the recovery file named FileName on a specified FAT volume and returns
+ This function finds the recovery file named FileName on a specified FAT volume and returns
its FileHandle pointer.
@param PrivateData Global memory map for accessing global
diff --git a/FatPkg/FatPei/FatLiteApi.c b/FatPkg/FatPei/FatLiteApi.c
index 8c7c6e52581f..d07422ba93b7 100644
--- a/FatPkg/FatPei/FatLiteApi.c
+++ b/FatPkg/FatPei/FatLiteApi.c
@@ -591,7 +591,7 @@ LoadRecoveryCapsule (
/**
Finds the recovery file on a FAT volume.
- This function finds the the recovery file named FileName on a specified FAT volume and returns
+ This function finds the recovery file named FileName on a specified FAT volume and returns
its FileHandle pointer.
@param PrivateData Global memory map for accessing global
diff --git a/FatPkg/FatPei/Mbr.c b/FatPkg/FatPei/Mbr.c
index 5b01604c0749..78e73fb811d7 100644
--- a/FatPkg/FatPei/Mbr.c
+++ b/FatPkg/FatPei/Mbr.c
@@ -51,7 +51,7 @@ PartitionValidMbr (
EndingLBA = StartingLBA + UNPACK_UINT32 (Mbr->Partition[Index1].SizeInLBA) - 1;
if (EndingLBA > LastLba) {
//
- // Compatability Errata:
+ // Compatibility Errata:
// Some systems try to hide drive space with their INT 13h driver
// This does not hide space from the OS driver. This means the MBR
// that gets created from DOS is smaller than the MBR created from
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [PATCH 09/79] FatPkg/FatPei: Fix few typos
2019-12-03 16:14 ` [PATCH 09/79] FatPkg/FatPei: Fix few typos Philippe Mathieu-Daudé
@ 2019-12-20 6:37 ` Ni, Ray
0 siblings, 0 replies; 122+ messages in thread
From: Ni, Ray @ 2019-12-20 6:37 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io; +Cc: Antoine Coeur
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Philippe Mathieu-Daude <philmd@redhat.com>
> Sent: Wednesday, December 4, 2019 12:15 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Ni, Ray <ray.ni@intel.com>; Philippe
> Mathieu-Daude <philmd@redhat.com>
> Subject: [PATCH 09/79] FatPkg/FatPei: Fix few typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix few typos in comments.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Coeur <coeur@gmx.fr>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> FatPkg/FatPei/FatLitePeim.h | 2 +-
> FatPkg/FatPei/FatLiteApi.c | 2 +-
> FatPkg/FatPei/Mbr.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/FatPkg/FatPei/FatLitePeim.h b/FatPkg/FatPei/FatLitePeim.h
> index 9cacf74aceeb..0c3c69853ca6 100644
> --- a/FatPkg/FatPei/FatLitePeim.h
> +++ b/FatPkg/FatPei/FatLitePeim.h
> @@ -185,7 +185,7 @@ typedef struct {
>
> /**
> Finds the recovery file on a FAT volume.
> - This function finds the the recovery file named FileName on a specified FAT
> volume and returns
> + This function finds the recovery file named FileName on a specified FAT
> volume and returns
> its FileHandle pointer.
>
> @param PrivateData Global memory map for accessing global
> diff --git a/FatPkg/FatPei/FatLiteApi.c b/FatPkg/FatPei/FatLiteApi.c
> index 8c7c6e52581f..d07422ba93b7 100644
> --- a/FatPkg/FatPei/FatLiteApi.c
> +++ b/FatPkg/FatPei/FatLiteApi.c
> @@ -591,7 +591,7 @@ LoadRecoveryCapsule (
>
> /**
> Finds the recovery file on a FAT volume.
> - This function finds the the recovery file named FileName on a specified FAT
> volume and returns
> + This function finds the recovery file named FileName on a specified FAT
> volume and returns
> its FileHandle pointer.
>
> @param PrivateData Global memory map for accessing global
> diff --git a/FatPkg/FatPei/Mbr.c b/FatPkg/FatPei/Mbr.c
> index 5b01604c0749..78e73fb811d7 100644
> --- a/FatPkg/FatPei/Mbr.c
> +++ b/FatPkg/FatPei/Mbr.c
> @@ -51,7 +51,7 @@ PartitionValidMbr (
> EndingLBA = StartingLBA + UNPACK_UINT32 (Mbr-
> >Partition[Index1].SizeInLBA) - 1;
> if (EndingLBA > LastLba) {
> //
> - // Compatability Errata:
> + // Compatibility Errata:
> // Some systems try to hide drive space with their INT 13h driver
> // This does not hide space from the OS driver. This means the MBR
> // that gets created from DOS is smaller than the MBR created from
> --
> 2.21.0
^ permalink raw reply [flat|nested] 122+ messages in thread
* [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (8 preceding siblings ...)
2019-12-03 16:14 ` [PATCH 09/79] FatPkg/FatPei: Fix few typos Philippe Mathieu-Daudé
@ 2019-12-03 16:14 ` Philippe Mathieu-Daudé
2019-12-04 1:14 ` [edk2-devel] " Nate DeSimone
` (3 more replies)
2019-12-03 16:14 ` [PATCH 11/79] MdeModulePkg/Application: Improve French translation Philippe Mathieu-Daudé
` (62 subsequent siblings)
72 siblings, 4 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:14 UTC (permalink / raw)
To: devel
Cc: Antoine Coeur, Chasel Chiu, Nate DeSimone, Star Zeng,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h | 2 +-
IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h | 4 ++--
IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 2 +-
IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c | 4 ++--
IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c | 4 ++--
IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nasm | 6 +++---
IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/SecEntry.nasm | 2 +-
IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Stack.nasm | 2 +-
8 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
index e39054c30d3b..11a3faaad87a 100644
--- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
+++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
@@ -40,7 +40,7 @@ CallFspNotifyPhase (
/**
Call FSP API - FspMemoryInit.
- @param[in] FspmUpdDataPtr Pointer to the FSPM_UPD data sructure.
+ @param[in] FspmUpdDataPtr Pointer to the FSPM_UPD data structure.
@param[out] HobListPtr Pointer to receive the address of the HOB list.
@return EFI status returned by FspMemoryInit API.
diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
index b90f0eb78302..2aa14c92fd63 100644
--- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
+++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
@@ -12,7 +12,7 @@
/**
This function overrides the default configurations in the FSP-M UPD data region.
- @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data strcture.
+ @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data structure.
**/
VOID
@@ -24,7 +24,7 @@ UpdateFspmUpdData (
/**
This function overrides the default configurations in the FSP-S UPD data region.
- @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data strcture.
+ @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data structure.
**/
VOID
diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
index 0f8cd69a0e6e..b20f0805a021 100644
--- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
+++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
@@ -352,7 +352,7 @@ FspsWrapperInitApiMode (
EFI_BOOT_MODE BootMode;
//
- // Register MemoryDiscovered Nofity to run FspSiliconInit
+ // Register MemoryDiscovered Notify to run FspSiliconInit
//
Status = PeiServicesNotifyPpi (&mPeiMemoryDiscoveredNotifyDesc);
ASSERT_EFI_ERROR (Status);
diff --git a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c
index def04b176659..dddf80b76c26 100644
--- a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c
+++ b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c
@@ -14,7 +14,7 @@
@note At this point, memory is NOT ready, PeiServices are available to use.
- @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data strcture.
+ @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data structure.
**/
VOID
@@ -28,7 +28,7 @@ UpdateFspmUpdData (
/**
This function overrides the default configurations in the FSP-S UPD data region.
- @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data strcture.
+ @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data structure.
**/
VOID
diff --git a/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c b/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c
index 54cebe127c8f..48f4b0295a30 100644
--- a/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c
+++ b/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c
@@ -29,11 +29,11 @@
#define PEI_ADDITIONAL_MEMORY_SIZE (16 * EFI_PAGE_SIZE)
/**
- Get the mem size in memory type infromation table.
+ Get the mem size in memory type information table.
@param[in] PeiServices PEI Services table.
- @return the mem size in memory type infromation table.
+ @return the mem size in memory type information table.
**/
UINT64
GetMemorySizeInMemoryTypeInformation (
diff --git a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nasm b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nasm
index 45c8f21255e3..db8e62ebc5a8 100644
--- a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nasm
+++ b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nasm
@@ -43,7 +43,7 @@ ASM_PFX(AsmExecute32BitCode):
cli
;
- ; save orignal GDTR and CS
+ ; save original GDTR and CS
;
mov rax, ds
push rax
@@ -190,7 +190,7 @@ ReloadCS:
pop rdi
popfq
;
- ; Switch to orignal GDT and CS. here rsp is pointer to the orignal GDT descriptor.
+ ; Switch to original GDT and CS. here rsp is pointer to the original GDT descriptor.
;
lgdt [rsp]
;
@@ -198,7 +198,7 @@ ReloadCS:
;
add rsp, 0x10
;
- ; switch to orignal CS and GDTR
+ ; switch to original CS and GDTR
;
pop r9 ; get CS
shl r9, 32 ; rcx[32..47] <- Cs
diff --git a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/SecEntry.nasm b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/SecEntry.nasm
index d8d0582cb4fa..9f190bb25b0f 100644
--- a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/SecEntry.nasm
+++ b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/SecEntry.nasm
@@ -207,7 +207,7 @@ TempRamInitDone:
cmp eax, 8000000Eh ;Check if EFI_NOT_FOUND returned. Error code for Microcode Update not found.
je CallSecFspInit ;If microcode not found, don't hang, but continue.
- cmp eax, 0 ;Check if EFI_SUCCESS retuned.
+ cmp eax, 0 ;Check if EFI_SUCCESS returned.
jnz FspApiFailed
; ECX: start of range
diff --git a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Stack.nasm b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Stack.nasm
index ba989bd4412b..d7394cf286c6 100644
--- a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Stack.nasm
+++ b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Stack.nasm
@@ -5,7 +5,7 @@
;
; Abstract:
;
-; Switch the stack from temporary memory to permenent memory.
+; Switch the stack from temporary memory to permanent memory.
;
;------------------------------------------------------------------------------
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [edk2-devel] [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos
2019-12-03 16:14 ` [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos Philippe Mathieu-Daudé
@ 2019-12-04 1:14 ` Nate DeSimone
2019-12-04 1:22 ` Chiu, Chasel
` (2 subsequent siblings)
3 siblings, 0 replies; 122+ messages in thread
From: Nate DeSimone @ 2019-12-04 1:14 UTC (permalink / raw)
To: devel@edk2.groups.io, philmd@redhat.com
Cc: Antoine Coeur, Chiu, Chasel, Zeng, Star
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Philippe Mathieu-Daudé
Sent: Tuesday, December 3, 2019 8:15 AM
To: devel@edk2.groups.io
Cc: Antoine Coeur <coeur@gmx.fr>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
Subject: [edk2-devel] [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h | 2 +-
IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h | 4 ++--
IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 2 +-
IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c | 4 ++--
IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c | 4 ++--
IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nasm | 6 +++---
IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/SecEntry.nasm | 2 +-
IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Stack.nasm | 2 +-
8 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
index e39054c30d3b..11a3faaad87a 100644
--- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
+++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
@@ -40,7 +40,7 @@ CallFspNotifyPhase (
/**
Call FSP API - FspMemoryInit.
- @param[in] FspmUpdDataPtr Pointer to the FSPM_UPD data sructure.
+ @param[in] FspmUpdDataPtr Pointer to the FSPM_UPD data structure.
@param[out] HobListPtr Pointer to receive the address of the HOB list.
@return EFI status returned by FspMemoryInit API.
diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
index b90f0eb78302..2aa14c92fd63 100644
--- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
+++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
@@ -12,7 +12,7 @@
/**
This function overrides the default configurations in the FSP-M UPD data region.
- @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data strcture.
+ @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data structure.
**/
VOID
@@ -24,7 +24,7 @@ UpdateFspmUpdData (
/**
This function overrides the default configurations in the FSP-S UPD data region.
- @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data strcture.
+ @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data structure.
**/
VOID
diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
index 0f8cd69a0e6e..b20f0805a021 100644
--- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
+++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
@@ -352,7 +352,7 @@ FspsWrapperInitApiMode (
EFI_BOOT_MODE BootMode;
//
- // Register MemoryDiscovered Nofity to run FspSiliconInit
+ // Register MemoryDiscovered Notify to run FspSiliconInit
//
Status = PeiServicesNotifyPpi (&mPeiMemoryDiscoveredNotifyDesc);
ASSERT_EFI_ERROR (Status);
diff --git a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c
index def04b176659..dddf80b76c26 100644
--- a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c
+++ b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c
@@ -14,7 +14,7 @@
@note At this point, memory is NOT ready, PeiServices are available to use.
- @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data strcture.
+ @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data structure.
**/
VOID
@@ -28,7 +28,7 @@ UpdateFspmUpdData (
/**
This function overrides the default configurations in the FSP-S UPD data region.
- @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data strcture.
+ @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data structure.
**/
VOID
diff --git a/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c b/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c
index 54cebe127c8f..48f4b0295a30 100644
--- a/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c
+++ b/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c
@@ -29,11 +29,11 @@
#define PEI_ADDITIONAL_MEMORY_SIZE (16 * EFI_PAGE_SIZE)
/**
- Get the mem size in memory type infromation table.
+ Get the mem size in memory type information table.
@param[in] PeiServices PEI Services table.
- @return the mem size in memory type infromation table.
+ @return the mem size in memory type information table.
**/
UINT64
GetMemorySizeInMemoryTypeInformation (
diff --git a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nasm b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nasm
index 45c8f21255e3..db8e62ebc5a8 100644
--- a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nasm
+++ b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nasm
@@ -43,7 +43,7 @@ ASM_PFX(AsmExecute32BitCode):
cli
;
- ; save orignal GDTR and CS
+ ; save original GDTR and CS
;
mov rax, ds
push rax
@@ -190,7 +190,7 @@ ReloadCS:
pop rdi
popfq
;
- ; Switch to orignal GDT and CS. here rsp is pointer to the orignal GDT descriptor.
+ ; Switch to original GDT and CS. here rsp is pointer to the original GDT descriptor.
;
lgdt [rsp]
;
@@ -198,7 +198,7 @@ ReloadCS:
;
add rsp, 0x10
;
- ; switch to orignal CS and GDTR
+ ; switch to original CS and GDTR
;
pop r9 ; get CS
shl r9, 32 ; rcx[32..47] <- Cs
diff --git a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/SecEntry.nasm b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/SecEntry.nasm
index d8d0582cb4fa..9f190bb25b0f 100644
--- a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/SecEntry.nasm
+++ b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/SecEntry.nasm
@@ -207,7 +207,7 @@ TempRamInitDone:
cmp eax, 8000000Eh ;Check if EFI_NOT_FOUND returned. Error code for Microcode Update not found.
je CallSecFspInit ;If microcode not found, don't hang, but continue.
- cmp eax, 0 ;Check if EFI_SUCCESS retuned.
+ cmp eax, 0 ;Check if EFI_SUCCESS returned.
jnz FspApiFailed
; ECX: start of range
diff --git a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Stack.nasm b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Stack.nasm
index ba989bd4412b..d7394cf286c6 100644
--- a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Stack.nasm
+++ b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Stack.nasm
@@ -5,7 +5,7 @@
;
; Abstract:
;
-; Switch the stack from temporary memory to permenent memory.
+; Switch the stack from temporary memory to permanent memory.
;
;------------------------------------------------------------------------------
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos
2019-12-03 16:14 ` [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos Philippe Mathieu-Daudé
2019-12-04 1:14 ` [edk2-devel] " Nate DeSimone
@ 2019-12-04 1:22 ` Chiu, Chasel
2019-12-04 1:40 ` [edk2-devel] " Michael D Kinney
2019-12-04 2:30 ` Zeng, Star
2019-12-11 1:53 ` Chiu, Chasel
3 siblings, 1 reply; 122+ messages in thread
From: Chiu, Chasel @ 2019-12-04 1:22 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Desimone, Nathaniel L, Zeng, Star
Philippe, thanks for helping on this.
Just minor feedbacks - many files having old copyright years that I replied below inline, please help to correct them.
With copyright updated, Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Philippe Mathieu-Daude <philmd@redhat.com>
> Sent: Wednesday, December 4, 2019 12:15 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Chiu, Chasel <chasel.chiu@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star
> <star.zeng@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
> Subject: [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
> | 2 +-
> IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
> | 4 ++--
> IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> | 2 +-
>
> IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapp
> erPlatformLibSample.c | 4 ++--
>
> IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrap
> perHobProcessLibSample.c | 4 ++--
>
> IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nas
> m | 6 +++---
>
> IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Sec
> Entry.nasm | 2 +-
>
> IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Sta
> ck.nasm | 2 +-
> 8 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
> b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
> index e39054c30d3b..11a3faaad87a 100644
> --- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
> +++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
Copyright for this file should be "2014 - 2019"
> @@ -40,7 +40,7 @@ CallFspNotifyPhase (
> /**
> Call FSP API - FspMemoryInit.
>
> - @param[in] FspmUpdDataPtr Pointer to the FSPM_UPD data
> sructure.
> + @param[in] FspmUpdDataPtr Pointer to the FSPM_UPD data
> structure.
> @param[out] HobListPtr Pointer to receive the address
> of the HOB list.
>
> @return EFI status returned by FspMemoryInit API.
> diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
> b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
> index b90f0eb78302..2aa14c92fd63 100644
> --- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
> +++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
Copyright for this file should be "2014 - 2019"
> @@ -12,7 +12,7 @@
> /**
> This function overrides the default configurations in the FSP-M UPD data
> region.
>
> - @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data
> strcture.
> + @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data
> structure.
>
> **/
> VOID
> @@ -24,7 +24,7 @@ UpdateFspmUpdData (
> /**
> This function overrides the default configurations in the FSP-S UPD data
> region.
>
> - @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data
> strcture.
> + @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data
> structure.
>
> **/
> VOID
> diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> index 0f8cd69a0e6e..b20f0805a021 100644
> --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> @@ -352,7 +352,7 @@ FspsWrapperInitApiMode (
> EFI_BOOT_MODE BootMode;
>
> //
> - // Register MemoryDiscovered Nofity to run FspSiliconInit
> + // Register MemoryDiscovered Notify to run FspSiliconInit
> //
> Status = PeiServicesNotifyPpi (&mPeiMemoryDiscoveredNotifyDesc);
> ASSERT_EFI_ERROR (Status);
> diff --git
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWra
> pperPlatformLibSample.c
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWra
> pperPlatformLibSample.c
> index def04b176659..dddf80b76c26 100644
> ---
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWra
> pperPlatformLibSample.c
> +++
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWra
> pperPlatformLibSample.c
Copyright for this file should be "2014 - 2019"
> @@ -14,7 +14,7 @@
>
> @note At this point, memory is NOT ready, PeiServices are available to
> use.
>
> - @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data
> strcture.
> + @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data
> structure.
>
> **/
> VOID
> @@ -28,7 +28,7 @@ UpdateFspmUpdData (
> /**
> This function overrides the default configurations in the FSP-S UPD data
> region.
>
> - @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data
> strcture.
> + @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data
> structure.
>
> **/
> VOID
> diff --git
> a/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWr
> apperHobProcessLibSample.c
> b/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWr
> apperHobProcessLibSample.c
> index 54cebe127c8f..48f4b0295a30 100644
> ---
> a/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWr
> apperHobProcessLibSample.c
> +++
> b/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWr
> apperHobProcessLibSample.c
> @@ -29,11 +29,11 @@
> #define PEI_ADDITIONAL_MEMORY_SIZE (16 * EFI_PAGE_SIZE)
>
> /**
> - Get the mem size in memory type infromation table.
> + Get the mem size in memory type information table.
>
> @param[in] PeiServices PEI Services table.
>
> - @return the mem size in memory type infromation table.
> + @return the mem size in memory type information table.
> **/
> UINT64
> GetMemorySizeInMemoryTypeInformation (
> diff --git
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.n
> asm
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.n
> asm
> index 45c8f21255e3..db8e62ebc5a8 100644
> ---
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.n
> asm
> +++
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.n
> asm
Copyright for this file should be "2016 - 2019"
> @@ -43,7 +43,7 @@ ASM_PFX(AsmExecute32BitCode):
> cli
>
> ;
> - ; save orignal GDTR and CS
> + ; save original GDTR and CS
> ;
> mov rax, ds
> push rax
> @@ -190,7 +190,7 @@ ReloadCS:
> pop rdi
> popfq
> ;
> - ; Switch to orignal GDT and CS. here rsp is pointer to the orignal GDT
> descriptor.
> + ; Switch to original GDT and CS. here rsp is pointer to the original GDT
> descriptor.
> ;
> lgdt [rsp]
> ;
> @@ -198,7 +198,7 @@ ReloadCS:
> ;
> add rsp, 0x10
> ;
> - ; switch to orignal CS and GDTR
> + ; switch to original CS and GDTR
> ;
> pop r9 ; get CS
> shl r9, 32 ; rcx[32..47] <- Cs
> diff --git
> a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> ecEntry.nasm
> b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> ecEntry.nasm
> index d8d0582cb4fa..9f190bb25b0f 100644
> ---
> a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> ecEntry.nasm
> +++
> b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> ecEntry.nasm
Copyright for this file should be "2016- 2019"
> @@ -207,7 +207,7 @@ TempRamInitDone:
> cmp eax, 8000000Eh ;Check if EFI_NOT_FOUND returned. Error
> code for Microcode Update not found.
> je CallSecFspInit ;If microcode not found, don't hang, but
> continue.
>
> - cmp eax, 0 ;Check if EFI_SUCCESS retuned.
> + cmp eax, 0 ;Check if EFI_SUCCESS returned.
> jnz FspApiFailed
>
> ; ECX: start of range
> diff --git
> a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> tack.nasm
> b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> tack.nasm
> index ba989bd4412b..d7394cf286c6 100644
> ---
> a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> tack.nasm
> +++
> b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> tack.nasm
Copyright for this file should be "2016 - 2019"
> @@ -5,7 +5,7 @@
> ;
> ; Abstract:
> ;
> -; Switch the stack from temporary memory to permenent memory.
> +; Switch the stack from temporary memory to permanent memory.
> ;
> ;------------------------------------------------------------------------------
>
> --
> 2.21.0
^ permalink raw reply [flat|nested] 122+ messages in thread
* Re: [edk2-devel] [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos
2019-12-04 1:22 ` Chiu, Chasel
@ 2019-12-04 1:40 ` Michael D Kinney
0 siblings, 0 replies; 122+ messages in thread
From: Michael D Kinney @ 2019-12-04 1:40 UTC (permalink / raw)
To: devel@edk2.groups.io, Chiu, Chasel, Philippe Mathieu-Daude,
Kinney, Michael D
Cc: Antoine Coeur, Desimone, Nathaniel L, Zeng, Star
Hi Chasel,
If you had authored the changes, then you could update those
copyright lines.
Since the author of the changes is Antoine Coeur <coeur@gmx.fr>,
Antoine gets to make the choice to add a new copyright line or not.
Thanks,
Mike
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Chiu, Chasel
> Sent: Tuesday, December 3, 2019 5:23 PM
> To: Philippe Mathieu-Daude <philmd@redhat.com>;
> devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star
> <star.zeng@intel.com>
> Subject: Re: [edk2-devel] [PATCH 10/79]
> IntelFsp2WrapperPkg: Fix various typos
>
>
> Philippe, thanks for helping on this.
>
> Just minor feedbacks - many files having old copyright
> years that I replied below inline, please help to
> correct them.
> With copyright updated, Reviewed-by: Chasel Chiu
> <chasel.chiu@intel.com>
>
>
> > -----Original Message-----
> > From: Philippe Mathieu-Daude <philmd@redhat.com>
> > Sent: Wednesday, December 4, 2019 12:15 AM
> > To: devel@edk2.groups.io
> > Cc: Antoine Coeur <coeur@gmx.fr>; Chiu, Chasel
> <chasel.chiu@intel.com>;
> > Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star
> > <star.zeng@intel.com>; Philippe Mathieu-Daude
> <philmd@redhat.com>
> > Subject: [PATCH 10/79] IntelFsp2WrapperPkg: Fix
> various typos
> >
> > From: Antoine Coeur <coeur@gmx.fr>
> >
> > Fix various typos in comments and documentation.
> >
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Star Zeng <star.zeng@intel.com>
> > Reviewed-by: Philippe Mathieu-Daude
> <philmd@redhat.com>
> > Signed-off-by: Philippe Mathieu-Daude
> <philmd@redhat.com>
> > ---
> >
> IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
> > | 2 +-
> >
> IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformL
> ib.h
> > | 4 ++--
> >
> IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> > | 2 +-
> >
> >
> IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSa
> mple/FspWrapp
> > erPlatformLibSample.c | 4 ++--
> >
> >
> IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibS
> ample/FspWrap
> > perHobProcessLibSample.c | 4 ++--
> >
> >
> IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Th
> unk64To32.nas
> > m | 6 +++---
> >
> >
> IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLib
> Sample/Ia32/Sec
> > Entry.nasm | 2 +-
> >
> >
> IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLib
> Sample/Ia32/Sta
> > ck.nasm | 2 +-
> > 8 files changed, 13 insertions(+), 13 deletions(-)
> >
> > diff --git
> a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.
> h
> >
> b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.
> h
> > index e39054c30d3b..11a3faaad87a 100644
> > ---
> a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.
> h
> > +++
> b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.
> h
>
>
> Copyright for this file should be "2014 - 2019"
>
>
> > @@ -40,7 +40,7 @@ CallFspNotifyPhase (
> > /**
> > Call FSP API - FspMemoryInit.
> >
> > - @param[in] FspmUpdDataPtr Pointer to the
> FSPM_UPD data
> > sructure.
> > + @param[in] FspmUpdDataPtr Pointer to the
> FSPM_UPD data
> > structure.
> > @param[out] HobListPtr Pointer to
> receive the address
> > of the HOB list.
> >
> > @return EFI status returned by FspMemoryInit API.
> > diff --git
> a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatfor
> mLib.h
> >
> b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatfor
> mLib.h
> > index b90f0eb78302..2aa14c92fd63 100644
> > ---
> a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatfor
> mLib.h
> > +++
> b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatfor
> mLib.h
>
>
> Copyright for this file should be "2014 - 2019"
>
>
> > @@ -12,7 +12,7 @@
> > /**
> > This function overrides the default configurations
> in the FSP-M UPD data
> > region.
> >
> > - @param[in,out] FspUpdRgnPtr A pointer to the UPD
> data region data
> > strcture.
> > + @param[in,out] FspUpdRgnPtr A pointer to the UPD
> data region data
> > structure.
> >
> > **/
> > VOID
> > @@ -24,7 +24,7 @@ UpdateFspmUpdData (
> > /**
> > This function overrides the default configurations
> in the FSP-S UPD data
> > region.
> >
> > - @param[in,out] FspUpdRgnPtr A pointer to the UPD
> data region data
> > strcture.
> > + @param[in,out] FspUpdRgnPtr A pointer to the UPD
> data region data
> > structure.
> >
> > **/
> > VOID
> > diff --git
> a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> >
> b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> > index 0f8cd69a0e6e..b20f0805a021 100644
> > ---
> a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> > +++
> b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> > @@ -352,7 +352,7 @@ FspsWrapperInitApiMode (
> > EFI_BOOT_MODE BootMode;
> >
> > //
> > - // Register MemoryDiscovered Nofity to run
> FspSiliconInit
> > + // Register MemoryDiscovered Notify to run
> FspSiliconInit
> > //
> > Status = PeiServicesNotifyPpi
> (&mPeiMemoryDiscoveredNotifyDesc);
> > ASSERT_EFI_ERROR (Status);
> > diff --git
> >
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLib
> Sample/FspWra
> > pperPlatformLibSample.c
> >
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLib
> Sample/FspWra
> > pperPlatformLibSample.c
> > index def04b176659..dddf80b76c26 100644
> > ---
> >
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLib
> Sample/FspWra
> > pperPlatformLibSample.c
> > +++
> >
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLib
> Sample/FspWra
> > pperPlatformLibSample.c
>
>
> Copyright for this file should be "2014 - 2019"
>
>
> > @@ -14,7 +14,7 @@
> >
> > @note At this point, memory is NOT ready,
> PeiServices are available to
> > use.
> >
> > - @param[in,out] FspUpdRgnPtr A pointer to the UPD
> data region data
> > strcture.
> > + @param[in,out] FspUpdRgnPtr A pointer to the UPD
> data region data
> > structure.
> >
> > **/
> > VOID
> > @@ -28,7 +28,7 @@ UpdateFspmUpdData (
> > /**
> > This function overrides the default configurations
> in the FSP-S UPD data
> > region.
> >
> > - @param[in,out] FspUpdRgnPtr A pointer to the UPD
> data region data
> > strcture.
> > + @param[in,out] FspUpdRgnPtr A pointer to the UPD
> data region data
> > structure.
> >
> > **/
> > VOID
> > diff --git
> >
> a/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLi
> bSample/FspWr
> > apperHobProcessLibSample.c
> >
> b/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLi
> bSample/FspWr
> > apperHobProcessLibSample.c
> > index 54cebe127c8f..48f4b0295a30 100644
> > ---
> >
> a/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLi
> bSample/FspWr
> > apperHobProcessLibSample.c
> > +++
> >
> b/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLi
> bSample/FspWr
> > apperHobProcessLibSample.c
> > @@ -29,11 +29,11 @@
> > #define PEI_ADDITIONAL_MEMORY_SIZE (16 *
> EFI_PAGE_SIZE)
> >
> > /**
> > - Get the mem size in memory type infromation table.
> > + Get the mem size in memory type information table.
> >
> > @param[in] PeiServices PEI Services table.
> >
> > - @return the mem size in memory type infromation
> table.
> > + @return the mem size in memory type information
> table.
> > **/
> > UINT64
> > GetMemorySizeInMemoryTypeInformation (
> > diff --git
> >
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/
> Thunk64To32.n
> > asm
> >
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/
> Thunk64To32.n
> > asm
> > index 45c8f21255e3..db8e62ebc5a8 100644
> > ---
> >
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/
> Thunk64To32.n
> > asm
> > +++
> >
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/
> Thunk64To32.n
> > asm
>
>
> Copyright for this file should be "2016 - 2019"
>
>
> > @@ -43,7 +43,7 @@ ASM_PFX(AsmExecute32BitCode):
> > cli
> >
> > ;
> > - ; save orignal GDTR and CS
> > + ; save original GDTR and CS
> > ;
> > mov rax, ds
> > push rax
> > @@ -190,7 +190,7 @@ ReloadCS:
> > pop rdi
> > popfq
> > ;
> > - ; Switch to orignal GDT and CS. here rsp is
> pointer to the orignal GDT
> > descriptor.
> > + ; Switch to original GDT and CS. here rsp is
> pointer to the original GDT
> > descriptor.
> > ;
> > lgdt [rsp]
> > ;
> > @@ -198,7 +198,7 @@ ReloadCS:
> > ;
> > add rsp, 0x10
> > ;
> > - ; switch to orignal CS and GDTR
> > + ; switch to original CS and GDTR
> > ;
> > pop r9 ; get CS
> > shl r9, 32 ; rcx[32..47] <- Cs
> > diff --git
> >
> a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecL
> ibSample/Ia32/S
> > ecEntry.nasm
> >
> b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecL
> ibSample/Ia32/S
> > ecEntry.nasm
> > index d8d0582cb4fa..9f190bb25b0f 100644
> > ---
> >
> a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecL
> ibSample/Ia32/S
> > ecEntry.nasm
> > +++
> >
> b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecL
> ibSample/Ia32/S
> > ecEntry.nasm
>
>
> Copyright for this file should be "2016- 2019"
>
>
> > @@ -207,7 +207,7 @@ TempRamInitDone:
> > cmp eax, 8000000Eh ;Check if EFI_NOT_FOUND
> returned. Error
> > code for Microcode Update not found.
> > je CallSecFspInit ;If microcode not found,
> don't hang, but
> > continue.
> >
> > - cmp eax, 0 ;Check if EFI_SUCCESS
> retuned.
> > + cmp eax, 0 ;Check if EFI_SUCCESS
> returned.
> > jnz FspApiFailed
> >
> > ; ECX: start of range
> > diff --git
> >
> a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecL
> ibSample/Ia32/S
> > tack.nasm
> >
> b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecL
> ibSample/Ia32/S
> > tack.nasm
> > index ba989bd4412b..d7394cf286c6 100644
> > ---
> >
> a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecL
> ibSample/Ia32/S
> > tack.nasm
> > +++
> >
> b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecL
> ibSample/Ia32/S
> > tack.nasm
>
>
> Copyright for this file should be "2016 - 2019"
>
>
> > @@ -5,7 +5,7 @@
> > ;
> > ; Abstract:
> > ;
> > -; Switch the stack from temporary memory to
> permenent memory.
> > +; Switch the stack from temporary memory to
> permanent memory.
> > ;
> > ;---------------------------------------------------
> ---------------------------
> >
> > --
> > 2.21.0
>
>
>
^ permalink raw reply [flat|nested] 122+ messages in thread
* Re: [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos
2019-12-03 16:14 ` [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos Philippe Mathieu-Daudé
2019-12-04 1:14 ` [edk2-devel] " Nate DeSimone
2019-12-04 1:22 ` Chiu, Chasel
@ 2019-12-04 2:30 ` Zeng, Star
2019-12-11 1:53 ` Chiu, Chasel
3 siblings, 0 replies; 122+ messages in thread
From: Zeng, Star @ 2019-12-04 2:30 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Chiu, Chasel, Desimone, Nathaniel L, Zeng, Star
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: Philippe Mathieu-Daude [mailto:philmd@redhat.com]
Sent: Wednesday, December 4, 2019 12:15 AM
To: devel@edk2.groups.io
Cc: Antoine Coeur <coeur@gmx.fr>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
Subject: [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h | 2 +-
IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h | 4 ++--
IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 2 +-
IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c | 4 ++--
IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c | 4 ++--
IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nasm | 6 +++---
IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/SecEntry.nasm | 2 +-
IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Stack.nasm | 2 +-
8 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
index e39054c30d3b..11a3faaad87a 100644
--- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
+++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
@@ -40,7 +40,7 @@ CallFspNotifyPhase (
/**
Call FSP API - FspMemoryInit.
- @param[in] FspmUpdDataPtr Pointer to the FSPM_UPD data sructure.
+ @param[in] FspmUpdDataPtr Pointer to the FSPM_UPD data structure.
@param[out] HobListPtr Pointer to receive the address of the HOB list.
@return EFI status returned by FspMemoryInit API.
diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
index b90f0eb78302..2aa14c92fd63 100644
--- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
+++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
@@ -12,7 +12,7 @@
/**
This function overrides the default configurations in the FSP-M UPD data region.
- @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data strcture.
+ @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data structure.
**/
VOID
@@ -24,7 +24,7 @@ UpdateFspmUpdData (
/**
This function overrides the default configurations in the FSP-S UPD data region.
- @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data strcture.
+ @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data structure.
**/
VOID
diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
index 0f8cd69a0e6e..b20f0805a021 100644
--- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
+++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
@@ -352,7 +352,7 @@ FspsWrapperInitApiMode (
EFI_BOOT_MODE BootMode;
//
- // Register MemoryDiscovered Nofity to run FspSiliconInit
+ // Register MemoryDiscovered Notify to run FspSiliconInit
//
Status = PeiServicesNotifyPpi (&mPeiMemoryDiscoveredNotifyDesc);
ASSERT_EFI_ERROR (Status);
diff --git a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c
index def04b176659..dddf80b76c26 100644
--- a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c
+++ b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c
@@ -14,7 +14,7 @@
@note At this point, memory is NOT ready, PeiServices are available to use.
- @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data strcture.
+ @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data structure.
**/
VOID
@@ -28,7 +28,7 @@ UpdateFspmUpdData (
/**
This function overrides the default configurations in the FSP-S UPD data region.
- @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data strcture.
+ @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data structure.
**/
VOID
diff --git a/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c b/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c
index 54cebe127c8f..48f4b0295a30 100644
--- a/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c
+++ b/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c
@@ -29,11 +29,11 @@
#define PEI_ADDITIONAL_MEMORY_SIZE (16 * EFI_PAGE_SIZE)
/**
- Get the mem size in memory type infromation table.
+ Get the mem size in memory type information table.
@param[in] PeiServices PEI Services table.
- @return the mem size in memory type infromation table.
+ @return the mem size in memory type information table.
**/
UINT64
GetMemorySizeInMemoryTypeInformation (
diff --git a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nasm b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nasm
index 45c8f21255e3..db8e62ebc5a8 100644
--- a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nasm
+++ b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nasm
@@ -43,7 +43,7 @@ ASM_PFX(AsmExecute32BitCode):
cli
;
- ; save orignal GDTR and CS
+ ; save original GDTR and CS
;
mov rax, ds
push rax
@@ -190,7 +190,7 @@ ReloadCS:
pop rdi
popfq
;
- ; Switch to orignal GDT and CS. here rsp is pointer to the orignal GDT descriptor.
+ ; Switch to original GDT and CS. here rsp is pointer to the original GDT descriptor.
;
lgdt [rsp]
;
@@ -198,7 +198,7 @@ ReloadCS:
;
add rsp, 0x10
;
- ; switch to orignal CS and GDTR
+ ; switch to original CS and GDTR
;
pop r9 ; get CS
shl r9, 32 ; rcx[32..47] <- Cs
diff --git a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/SecEntry.nasm b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/SecEntry.nasm
index d8d0582cb4fa..9f190bb25b0f 100644
--- a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/SecEntry.nasm
+++ b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/SecEntry.nasm
@@ -207,7 +207,7 @@ TempRamInitDone:
cmp eax, 8000000Eh ;Check if EFI_NOT_FOUND returned. Error code for Microcode Update not found.
je CallSecFspInit ;If microcode not found, don't hang, but continue.
- cmp eax, 0 ;Check if EFI_SUCCESS retuned.
+ cmp eax, 0 ;Check if EFI_SUCCESS returned.
jnz FspApiFailed
; ECX: start of range
diff --git a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Stack.nasm b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Stack.nasm
index ba989bd4412b..d7394cf286c6 100644
--- a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Stack.nasm
+++ b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Stack.nasm
@@ -5,7 +5,7 @@
;
; Abstract:
;
-; Switch the stack from temporary memory to permenent memory.
+; Switch the stack from temporary memory to permanent memory.
;
;------------------------------------------------------------------------------
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos
2019-12-03 16:14 ` [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos Philippe Mathieu-Daudé
` (2 preceding siblings ...)
2019-12-04 2:30 ` Zeng, Star
@ 2019-12-11 1:53 ` Chiu, Chasel
3 siblings, 0 replies; 122+ messages in thread
From: Chiu, Chasel @ 2019-12-11 1:53 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Desimone, Nathaniel L, Zeng, Star
Commit pushed: 97eedf5dfbaffde33210fd88066247cf0b7d3325
> -----Original Message-----
> From: Philippe Mathieu-Daude <philmd@redhat.com>
> Sent: Wednesday, December 4, 2019 12:15 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Chiu, Chasel <chasel.chiu@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star
> <star.zeng@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
> Subject: [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
> | 2 +-
> IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
> | 4 ++--
> IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> | 2 +-
>
> IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapp
> erPlatformLibSample.c | 4 ++--
>
> IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrap
> perHobProcessLibSample.c | 4 ++--
>
> IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nas
> m | 6 +++---
>
> IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Sec
> Entry.nasm | 2 +-
>
> IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Sta
> ck.nasm | 2 +-
> 8 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
> b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
> index e39054c30d3b..11a3faaad87a 100644
> --- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
> +++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
> @@ -40,7 +40,7 @@ CallFspNotifyPhase (
> /**
> Call FSP API - FspMemoryInit.
>
> - @param[in] FspmUpdDataPtr Pointer to the FSPM_UPD data
> sructure.
> + @param[in] FspmUpdDataPtr Pointer to the FSPM_UPD data
> structure.
> @param[out] HobListPtr Pointer to receive the address
> of the HOB list.
>
> @return EFI status returned by FspMemoryInit API.
> diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
> b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
> index b90f0eb78302..2aa14c92fd63 100644
> --- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
> +++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
> @@ -12,7 +12,7 @@
> /**
> This function overrides the default configurations in the FSP-M UPD data
> region.
>
> - @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data
> strcture.
> + @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data
> structure.
>
> **/
> VOID
> @@ -24,7 +24,7 @@ UpdateFspmUpdData (
> /**
> This function overrides the default configurations in the FSP-S UPD data
> region.
>
> - @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data
> strcture.
> + @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data
> structure.
>
> **/
> VOID
> diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> index 0f8cd69a0e6e..b20f0805a021 100644
> --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> @@ -352,7 +352,7 @@ FspsWrapperInitApiMode (
> EFI_BOOT_MODE BootMode;
>
> //
> - // Register MemoryDiscovered Nofity to run FspSiliconInit
> + // Register MemoryDiscovered Notify to run FspSiliconInit
> //
> Status = PeiServicesNotifyPpi (&mPeiMemoryDiscoveredNotifyDesc);
> ASSERT_EFI_ERROR (Status);
> diff --git
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWra
> pperPlatformLibSample.c
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWra
> pperPlatformLibSample.c
> index def04b176659..dddf80b76c26 100644
> ---
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWra
> pperPlatformLibSample.c
> +++
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWra
> pperPlatformLibSample.c
> @@ -14,7 +14,7 @@
>
> @note At this point, memory is NOT ready, PeiServices are available to
> use.
>
> - @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data
> strcture.
> + @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data
> structure.
>
> **/
> VOID
> @@ -28,7 +28,7 @@ UpdateFspmUpdData (
> /**
> This function overrides the default configurations in the FSP-S UPD data
> region.
>
> - @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data
> strcture.
> + @param[in,out] FspUpdRgnPtr A pointer to the UPD data region data
> structure.
>
> **/
> VOID
> diff --git
> a/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWr
> apperHobProcessLibSample.c
> b/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWr
> apperHobProcessLibSample.c
> index 54cebe127c8f..48f4b0295a30 100644
> ---
> a/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWr
> apperHobProcessLibSample.c
> +++
> b/IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWr
> apperHobProcessLibSample.c
> @@ -29,11 +29,11 @@
> #define PEI_ADDITIONAL_MEMORY_SIZE (16 * EFI_PAGE_SIZE)
>
> /**
> - Get the mem size in memory type infromation table.
> + Get the mem size in memory type information table.
>
> @param[in] PeiServices PEI Services table.
>
> - @return the mem size in memory type infromation table.
> + @return the mem size in memory type information table.
> **/
> UINT64
> GetMemorySizeInMemoryTypeInformation (
> diff --git
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.n
> asm
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.n
> asm
> index 45c8f21255e3..db8e62ebc5a8 100644
> ---
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.n
> asm
> +++
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.n
> asm
> @@ -43,7 +43,7 @@ ASM_PFX(AsmExecute32BitCode):
> cli
>
> ;
> - ; save orignal GDTR and CS
> + ; save original GDTR and CS
> ;
> mov rax, ds
> push rax
> @@ -190,7 +190,7 @@ ReloadCS:
> pop rdi
> popfq
> ;
> - ; Switch to orignal GDT and CS. here rsp is pointer to the orignal GDT
> descriptor.
> + ; Switch to original GDT and CS. here rsp is pointer to the original GDT
> descriptor.
> ;
> lgdt [rsp]
> ;
> @@ -198,7 +198,7 @@ ReloadCS:
> ;
> add rsp, 0x10
> ;
> - ; switch to orignal CS and GDTR
> + ; switch to original CS and GDTR
> ;
> pop r9 ; get CS
> shl r9, 32 ; rcx[32..47] <- Cs
> diff --git
> a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> ecEntry.nasm
> b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> ecEntry.nasm
> index d8d0582cb4fa..9f190bb25b0f 100644
> ---
> a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> ecEntry.nasm
> +++
> b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> ecEntry.nasm
> @@ -207,7 +207,7 @@ TempRamInitDone:
> cmp eax, 8000000Eh ;Check if EFI_NOT_FOUND returned. Error
> code for Microcode Update not found.
> je CallSecFspInit ;If microcode not found, don't hang, but
> continue.
>
> - cmp eax, 0 ;Check if EFI_SUCCESS retuned.
> + cmp eax, 0 ;Check if EFI_SUCCESS returned.
> jnz FspApiFailed
>
> ; ECX: start of range
> diff --git
> a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> tack.nasm
> b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> tack.nasm
> index ba989bd4412b..d7394cf286c6 100644
> ---
> a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> tack.nasm
> +++
> b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/S
> tack.nasm
> @@ -5,7 +5,7 @@
> ;
> ; Abstract:
> ;
> -; Switch the stack from temporary memory to permenent memory.
> +; Switch the stack from temporary memory to permanent memory.
> ;
> ;------------------------------------------------------------------------------
>
> --
> 2.21.0
^ permalink raw reply [flat|nested] 122+ messages in thread
* [PATCH 11/79] MdeModulePkg/Application: Improve French translation
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (9 preceding siblings ...)
2019-12-03 16:14 ` [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos Philippe Mathieu-Daudé
@ 2019-12-03 16:14 ` Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 12/79] MdeModulePkg/Application: Fix various typos Philippe Mathieu-Daudé
` (61 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:14 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Jian J Wang, Hao A Wu, Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Use correct French.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Coeur <coeur@gmx.fr>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdeModulePkg/Application/UiApp/FrontPageStrings.uni | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MdeModulePkg/Application/UiApp/FrontPageStrings.uni b/MdeModulePkg/Application/UiApp/FrontPageStrings.uni
index 254a876ec42c..a0ab9abce10a 100644
--- a/MdeModulePkg/Application/UiApp/FrontPageStrings.uni
+++ b/MdeModulePkg/Application/UiApp/FrontPageStrings.uni
@@ -31,7 +31,7 @@
#string STR_FRONT_PAGE_BANNER_0_RIGHT #language en-US "OK"
#language fr-FR "Bon"
#string STR_FRONT_PAGE_BANNER_1_LEFT #language en-US "2 Pentium® X Xeon processors running at 800Thz"
- #language fr-FR "2 Pentium® X les processeurs de Xeon courants à 800Thz"
+ #language fr-FR "2 processeurs Pentium® X Xeon tournants à 800Thz"
#string STR_FRONT_PAGE_BANNER_1_RIGHT #language en-US "24 TB System RAM"
#language fr-FR "24 TB RAM de Système"
#string STR_FRONT_PAGE_BANNER_2_LEFT #language en-US "ACME® EFI BIOS Version 13.5 Release 1039.92"
@@ -41,11 +41,11 @@
#string STR_CONTINUE_PROMPT #language en-US "Continue"
#language fr-FR "Continuer"
#string STR_CONTINUE_HELP #language en-US "This selection will direct the system to continue to booting process"
- #language fr-FR "Cette sélection dirigera le système pour continuer au charger de procédé"
+ #language fr-FR "Cette sélection dirigera le système pour continuer au processus d'amorçage"
#string STR_LANGUAGE_SELECT #language en-US "Select Language"
#language fr-FR "Choisir la Langue"
#string STR_LANGUAGE_SELECT_HELP #language en-US "This is the option one adjusts to change the language for the current system"
- #language fr-FR "Ceci est l'option que celui ajuste changer la langue pour le système actuel"
+ #language fr-FR "Ceci est l'option qu'on ajuste pour changer la langue pour le système actuel"
#string STR_MISSING_STRING #language en-US "Missing String"
#language fr-FR "Missing String"
#string STR_EMPTY_STRING #language en-US ""
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* [PATCH 12/79] MdeModulePkg/Application: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (10 preceding siblings ...)
2019-12-03 16:14 ` [PATCH 11/79] MdeModulePkg/Application: Improve French translation Philippe Mathieu-Daudé
@ 2019-12-03 16:14 ` Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 13/79] MdeModulePkg/Bus/Ata: " Philippe Mathieu-Daudé
` (60 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:14 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Jian J Wang, Hao A Wu, Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in documentation, comments and debug strings.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Coeur <coeur@gmx.fr>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
| 2 +-
MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.h | 2 +-
MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 2 +-
MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 4 ++--
MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c | 2 +-
MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c | 2 +-
6 files changed, 7 insertions(+), 7 deletions(-)
--git a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.h b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.h
index 04c2df5666e6..e38e87824dde 100644
--- a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.h
+++ b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.h
@@ -47,7 +47,7 @@ typedef struct _BOOT_MENU_POPUP_DATA {
EFI_STRING_ID HelpToken[HELP_TOKEN_COUNT]; // All of help string ID
UINTN SelectItem; // Current select item
BOOT_MENU_SCREEN MenuScreen; // Boot menu screen information
- BOOT_MENU_SCROLL_BAR_CONTROL ScrollBarControl; // Boot menu scroll bar inoformation
+ BOOT_MENU_SCROLL_BAR_CONTROL ScrollBarControl; // Boot menu scroll bar information
} BOOT_MENU_POPUP_DATA;
#endif
diff --git a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.h b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.h
index 2f3ae45aaf27..7be45849f965 100644
--- a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.h
+++ b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.h
@@ -85,7 +85,7 @@ BOOLEAN
@param HiiHandle The hii handle for the Uiapp driver.
@param ClassGuid The class guid for the driver which is the target.
- @param SpecialHandlerFn The pointer to the specail handler function, if any.
+ @param SpecialHandlerFn The pointer to the special handler function, if any.
@param StartOpCodeHandle The opcode handle to save the new opcode.
@retval EFI_SUCCESS Search the driver success
diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c
index 3439ce5febe0..40347147734b 100644
--- a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c
+++ b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c
@@ -494,7 +494,7 @@ BuildGatherList (
}
//
- // Record descirptor header
+ // Record descriptor header
//
if (Index == 0) {
BlockDescriptorsHeader = BlockDescriptors1;
diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
index 58a93568d013..3c293bfad84f 100644
--- a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
+++ b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
@@ -38,7 +38,7 @@ DumpUxCapsule (
{
EFI_DISPLAY_CAPSULE *DisplayCapsule;
DisplayCapsule = (EFI_DISPLAY_CAPSULE *)CapsuleHeader;
- Print(L"[UxCapusule]\n");
+ Print(L"[UxCapsule]\n");
Print(L"CapsuleHeader:\n");
Print(L" CapsuleGuid - %g\n", &DisplayCapsule->CapsuleHeader.CapsuleGuid);
Print(L" HeaderSize - 0x%x\n", DisplayCapsule->CapsuleHeader.HeaderSize);
@@ -199,7 +199,7 @@ DumpCapsule (
DumpFmpCapsule(CapsuleHeader);
}
if (IsNestedFmpCapsule(CapsuleHeader)) {
- Print(L"[NestedCapusule]\n");
+ Print(L"[NestedCapsule]\n");
Print(L"CapsuleHeader:\n");
Print(L" CapsuleGuid - %g\n", &CapsuleHeader->CapsuleGuid);
Print(L" HeaderSize - 0x%x\n", CapsuleHeader->HeaderSize);
diff --git a/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c b/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c
index 148607db722b..191c31068545 100644
--- a/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c
+++ b/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c
@@ -627,7 +627,7 @@ DumpMemoryProfileMemoryRange (
@param[in] ProfileSize Memory profile size.
@param[in] Signature Signature.
- @return Pointer to the stucture with the signature.
+ @return Pointer to the structure with the signature.
**/
VOID *
diff --git a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
index c9823e565de8..858fdfc53d78 100644
--- a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
+++ b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
@@ -554,7 +554,7 @@ RequiredDriver (
@param HiiHandle The hii handle for the Uiapp driver.
@param ClassGuid The class guid for the driver which is the target.
- @param SpecialHandlerFn The pointer to the specail handler function, if any.
+ @param SpecialHandlerFn The pointer to the special handler function, if any.
@param StartOpCodeHandle The opcode handle to save the new opcode.
@retval EFI_SUCCESS Search the driver success
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* [PATCH 13/79] MdeModulePkg/Bus/Ata: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (11 preceding siblings ...)
2019-12-03 16:14 ` [PATCH 12/79] MdeModulePkg/Application: Fix various typos Philippe Mathieu-Daudé
@ 2019-12-03 16:14 ` Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 14/79] MdeModulePkg/Bus/I2c: Fix few typos Philippe Mathieu-Daudé
` (59 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:14 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Jian J Wang, Hao A Wu, Ray Ni,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in documentation, comments and debug strings.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf | 2 +-
MdeModulePkg/Bus/Ata/AhciPei/AhciPei.h | 4 ++--
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h | 4 ++--
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.h | 4 ++--
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.h | 2 +-
MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h | 12 ++++++------
MdeModulePkg/Bus/Ata/AhciPei/AhciMode.c | 8 ++++----
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 14 +++++++-------
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c | 8 ++++----
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c | 16 ++++++++--------
MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c | 10 +++++-----
MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c | 4 ++--
MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.uni | 2 +-
13 files changed, 45 insertions(+), 45 deletions(-)
diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
index c3ab5c18f148..086ec5f7c6d3 100644
--- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
+++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
@@ -1,5 +1,5 @@
## @file
-# ATA Bus driver to enumerate and identfy ATA devices.
+# ATA Bus driver to enumerate and identify ATA devices.
#
# This driver follows UEFI driver model and layers on ATA Pass Thru protocol defined
# in UEFI spec 2.2. It installs Block IO and Disk Info protocol for each ATA device
diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPei.h b/MdeModulePkg/Bus/Ata/AhciPei/AhciPei.h
index 9a34dc6e4f15..2be78076bee7 100644
--- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPei.h
+++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPei.h
@@ -161,7 +161,7 @@ typedef struct {
UINT8 AhciD2HRegisterFis[0x14]; // D2H Register Fis: offset 0x40
UINT8 AhciD2HRegisterFisRsvd[0x04];
UINT64 AhciSetDeviceBitsFis; // Set Device Bits Fix: offset 0x58
- UINT8 AhciUnknownFis[0x40]; // Unkonwn Fis: offset 0x60
+ UINT8 AhciUnknownFis[0x40]; // Unknown Fis: offset 0x60
UINT8 AhciUnknownFisRsvd[0x60];
} EFI_AHCI_RECEIVED_FIS;
@@ -239,7 +239,7 @@ typedef struct {
} EFI_AHCI_COMMAND_PRDT;
//
-// Command table Data strucute which is pointed to by the entry in the command list
+// Command table Data structure which is pointed to by the entry in the command list
//
typedef struct {
EFI_AHCI_COMMAND_FIS CommandFis; // A software constructed FIS.
diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h
index 66d5da0b714c..786413930ae9 100644
--- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h
+++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h
@@ -263,7 +263,7 @@ typedef struct {
} EFI_AHCI_COMMAND_PRDT;
//
-// Command table data strucute which is pointed to by the entry in the command list
+// Command table data structure which is pointed to by the entry in the command list
//
typedef struct {
EFI_AHCI_COMMAND_FIS CommandFis; // A software constructed FIS.
@@ -283,7 +283,7 @@ typedef struct {
UINT8 AhciD2HRegisterFis[0x14]; // D2H Register Fis: offset 0x40
UINT8 AhciD2HRegisterFisRsvd[0x04];
UINT64 AhciSetDeviceBitsFis; // Set Device Bits Fix: offset 0x58
- UINT8 AhciUnknownFis[0x40]; // Unkonwn Fis: offset 0x60
+ UINT8 AhciUnknownFis[0x40]; // Unknown Fis: offset 0x60
UINT8 AhciUnknownFisRsvd[0x60];
} EFI_AHCI_RECEIVED_FIS;
diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.h b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.h
index de9e1ee98f19..5f582b9b3e76 100644
--- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.h
+++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.h
@@ -384,7 +384,7 @@ AtaAtapiPassThruSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -521,7 +521,7 @@ EnumerateAttachedDevice (
);
/**
- Call back funtion when the timer event is signaled.
+ Call back function when the timer event is signaled.
@param[in] Event The Event this notify function registered to.
@param[in] Context Pointer to the context data registered to the
diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.h b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.h
index 39273c5b02db..c39ebd06679d 100644
--- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.h
+++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.h
@@ -158,7 +158,7 @@ typedef struct {
@retval EFI_UNSUPPORTED Return this value when the BARs is not IO type
@retval EFI_SUCCESS Get the Base address successfully
- @retval Other Read the pci configureation data error
+ @retval Other Read the pci configuration data error
**/
EFI_STATUS
diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h
index 54c0f3d30fc2..a5a865209942 100644
--- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h
+++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h
@@ -408,7 +408,7 @@ AtaBusDriverBindingSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -614,7 +614,7 @@ AtaBlockIoReset (
@retval EFI_SUCCESS The data was read correctly from the device.
@retval EFI_DEVICE_ERROR The device reported an error while performing the read.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHANGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The read request contains LBAs that are not valid,
or the buffer is not on proper alignment.
@@ -645,7 +645,7 @@ AtaBlockIoReadBlocks (
@retval EFI_WRITE_PROTECTED The device can not be written to.
@retval EFI_DEVICE_ERROR The device reported an error while performing the write.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The write request contains LBAs that are not valid,
or the buffer is not on proper alignment.
@@ -679,7 +679,7 @@ AtaBlockIoFlushBlocks (
);
/**
- Reset the Block Device throught Block I/O2 protocol.
+ Reset the Block Device through Block I/O2 protocol.
@param[in] This Indicates a pointer to the calling context.
@param[in] ExtendedVerification Driver may perform diagnostics on reset.
@@ -749,7 +749,7 @@ AtaBlockIoReadBlocksEx (
@retval EFI_WRITE_PROTECTED The device can not be written to.
@retval EFI_DEVICE_ERROR The device reported an error while performing the write.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The write request contains LBAs that are not valid,
or the buffer is not on proper alignment.
@@ -1061,7 +1061,7 @@ AtaStorageSecuritySendData (
Typically, there are 2 mechanism for resetting eDrive. They are:
1. TPer Reset through IEEE 1667 protocol.
2. TPer Reset through native TCG protocol.
- This routine will detect what protocol the attached eDrive comform to, TCG or
+ This routine will detect what protocol the attached eDrive conform to, TCG or
IEEE 1667 protocol. Then send out TPer Reset command separately.
@param[in] AtaDevice ATA_DEVICE pointer.
diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciMode.c b/MdeModulePkg/Bus/Ata/AhciPei/AhciMode.c
index 8c491bd13865..7636ad27c86c 100644
--- a/MdeModulePkg/Bus/Ata/AhciPei/AhciMode.c
+++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciMode.c
@@ -266,7 +266,7 @@ AhciWaitMemSet (
do {
//
- // Access sytem memory to see if the value is the tested one.
+ // Access system memory to see if the value is the tested one.
//
// The system memory pointed by Address will be updated by the
// SATA Host Controller, "volatile" is introduced to prevent
@@ -520,7 +520,7 @@ AhciBuildCommand (
}
/**
- Buid a command FIS.
+ Build a command FIS.
@param[in,out] CmdFis A pointer to the EFI_AHCI_COMMAND_FIS data
structure.
@@ -801,7 +801,7 @@ AhciPioTransfer (
AhciWriteReg (AhciBar, Offset, Data64.Uint32.Upper32);
//
- // Single task envrionment, we only use one command table for all port
+ // Single task environment, we only use one command table for all port
//
Offset = AHCI_PORT_START + Port * AHCI_PORT_REG_WIDTH + AHCI_PORT_CLB;
OldCmdListLo = AhciReadReg (AhciBar, Offset);
@@ -1843,7 +1843,7 @@ AhciModeInitialization (
if (EFI_ERROR (Status)) {
DEBUG ((
DEBUG_ERROR,
- "%a: Error occured when waiting for the first D2H register FIS - %r\n",
+ "%a: Error occurred when waiting for the first D2H register FIS - %r\n",
__FUNCTION__, Status
));
continue;
diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
index 00aa7e686c34..79d051761d6a 100644
--- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
+++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
@@ -219,7 +219,7 @@ AhciWaitMemSet (
do {
//
- // Access sytem memory to see if the value is the tested one.
+ // Access system memory to see if the value is the tested one.
//
// The system memory pointed by Address will be updated by the
// SATA Host Controller, "volatile" is introduced to prevent
@@ -581,7 +581,7 @@ AhciBuildCommand (
}
/**
- Buid a command FIS.
+ Build a command FIS.
@param CmdFis A pointer to the EFI_AHCI_COMMAND_FIS data structure.
@param AtaCommandBlock A pointer to the AhciBuildCommandFis data structure.
@@ -997,7 +997,7 @@ AhciDmaTransfer (
}
//
- // Wait for command compelte
+ // Wait for command complete
//
FisBaseAddr = (UINTN)AhciRegisters->AhciRFis + Port * sizeof (EFI_AHCI_RECEIVED_FIS);
Offset = FisBaseAddr + EFI_AHCI_D2H_FIS_OFFSET;
@@ -1903,7 +1903,7 @@ AhciCreateTransferDescriptor (
PortImplementBitMap = AhciReadReg(PciIo, EFI_AHCI_PI_OFFSET);
//
- // Get the highest bit of implemented ports which decides how many bytes are allocated for recived FIS.
+ // Get the highest bit of implemented ports which decides how many bytes are allocated for received FIS.
//
MaxPortNumber = (UINT8)(UINTN)(HighBitSet32(PortImplementBitMap) + 1);
if (MaxPortNumber == 0) {
@@ -1958,7 +1958,7 @@ AhciCreateTransferDescriptor (
//
// Allocate memory for command list
- // Note that the implemenation is a single task model which only use a command list for all ports.
+ // Note that the implementation is a single task model which only use a command list for all ports.
//
Buffer = NULL;
MaxCommandListSize = MaxCommandSlotNumber * sizeof (EFI_AHCI_COMMAND_LIST);
@@ -2713,7 +2713,7 @@ AhciModeInitialization (
} else {
continue;
}
- DEBUG ((EFI_D_INFO, "port [%d] port mulitplier [%d] has a [%a]\n",
+ DEBUG ((EFI_D_INFO, "port [%d] port multitplier [%d] has a [%a]\n",
Port, 0, DeviceType == EfiIdeCdrom ? "cdrom" : "harddisk"));
//
@@ -2761,7 +2761,7 @@ AhciModeInitialization (
TransferMode.ModeNumber = (UINT8) (SupportedModes->PioMode.Mode);
//
- // Set supported DMA mode on this IDE device. Note that UDMA & MDMA cann't
+ // Set supported DMA mode on this IDE device. Note that UDMA & MDMA can't
// be set together. Only one DMA mode can be set to a device. If setting
// DMA mode operation fails, we can continue moving on because we only use
// PIO mode at boot time. DMA modes are used by certain kind of OS booting
diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c
index e5b8f40d03b3..86fe9d954fdb 100644
--- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c
+++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c
@@ -1,5 +1,5 @@
/** @file
- This file implements ATA_PASSTHRU_PROCTOCOL and EXT_SCSI_PASSTHRU_PROTOCOL interfaces
+ This file implements ATA_PASSTHRU_PROTOCOL and EXT_SCSI_PASSTHRU_PROTOCOL interfaces
for managed ATA controllers.
Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.<BR>
@@ -404,7 +404,7 @@ AsyncNonBlockingTransferRoutine (
Instance = (ATA_ATAPI_PASS_THRU_INSTANCE *) Context;
EntryHeader = &Instance->NonBlockingTaskList;
//
- // Get the Taks from the Taks List and execute it, until there is
+ // Get the Tasks from the Tasks List and execute it, until there is
// no task in the list or the device is busy with task (EFI_NOT_READY).
//
while (TRUE) {
@@ -538,7 +538,7 @@ AtaAtapiPassThruSupported (
EFI_IDE_CONTROLLER_INIT_PROTOCOL *IdeControllerInit;
//
- // SATA Controller is a device driver, and should ingore the
+ // SATA Controller is a device driver, and should ignore the
// "RemainingDevicePath" according to UEFI spec
//
Status = gBS->OpenProtocol (
@@ -659,7 +659,7 @@ AtaAtapiPassThruSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c
index ac055f00422f..d284cc600b6a 100644
--- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c
+++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c
@@ -46,7 +46,7 @@ IdeReadPortB (
write a 1-byte data to a specific IDE port.
@param PciIo A pointer to EFI_PCI_IO_PROTOCOL data structure
- @param Port The IDE port to be writen
+ @param Port The IDE port to be written
@param Data The data to write to the port
**/
VOID
@@ -76,7 +76,7 @@ IdeWritePortB (
write a 1-word data to a specific IDE port.
@param PciIo A pointer to EFI_PCI_IO_PROTOCOL data structure
- @param Port The IDE port to be writen
+ @param Port The IDE port to be written
@param Data The data to write to the port
**/
VOID
@@ -106,7 +106,7 @@ IdeWritePortW (
write a 2-word data to a specific IDE port.
@param PciIo A pointer to EFI_PCI_IO_PROTOCOL data structure
- @param Port The IDE port to be writen
+ @param Port The IDE port to be written
@param Data The data to write to the port
**/
VOID
@@ -718,12 +718,12 @@ WaitForBSYClear (
Table 2. BARs for Register Mapping
@param[in] PciIo Pointer to the EFI_PCI_IO_PROTOCOL instance
- @param[in, out] IdeRegisters Pointer to EFI_IDE_REGISTERS which is used to
+ @param[in, out] IdeRegisters Pointer to EFI_IDE_REGISTERS which is used to
store the IDE i/o port registers' base addresses
@retval EFI_UNSUPPORTED Return this value when the BARs is not IO type
@retval EFI_SUCCESS Get the Base address successfully
- @retval Other Read the pci configureation data error
+ @retval Other Read the pci configuration data error
**/
EFI_STATUS
@@ -983,7 +983,7 @@ AtaPioDataInOut (
Increment = 256;
//
- // used to record bytes of currently transfered data
+ // used to record bytes of currently transferred data
//
WordCount = 0;
@@ -1688,7 +1688,7 @@ AtaPacketReadWrite (
RequiredWordCount = *ByteCount >> 1;
//
- // No data transfer is premitted.
+ // No data transfer is permitted.
//
if (RequiredWordCount == 0) {
return EFI_SUCCESS;
@@ -2509,7 +2509,7 @@ DetectAndConfigIdeDevice (
}
//
- // Set supported DMA mode on this IDE device. Note that UDMA & MDMA cann't
+ // Set supported DMA mode on this IDE device. Note that UDMA & MDMA can't
// be set together. Only one DMA mode can be set to a device. If setting
// DMA mode operation fails, we can continue moving on because we only use
// PIO mode at boot time. DMA modes are used by certain kind of OS booting
diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c
index f93afab3bba7..28f8638c52fa 100644
--- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c
+++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c
@@ -703,7 +703,7 @@ AtaBusDriverBindingSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -1007,7 +1007,7 @@ AtaBlockIoReset (
@retval EFI_WRITE_PROTECTED The device can not be read/written to.
@retval EFI_DEVICE_ERROR The device reported an error while performing the read/write.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The read/write request contains LBAs that are not valid,
or the buffer is not on proper alignment.
@@ -1101,7 +1101,7 @@ BlockIoReadWrite (
@retval EFI_SUCCESS The data was read correctly from the device.
@retval EFI_DEVICE_ERROR The device reported an error while performing the read.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHANGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The read request contains LBAs that are not valid,
or the buffer is not on proper alignment.
@@ -1135,7 +1135,7 @@ AtaBlockIoReadBlocks (
@retval EFI_WRITE_PROTECTED The device can not be written to.
@retval EFI_DEVICE_ERROR The device reported an error while performing the write.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The write request contains LBAs that are not valid,
or the buffer is not on proper alignment.
@@ -1272,7 +1272,7 @@ AtaBlockIoReadBlocksEx (
@retval EFI_WRITE_PROTECTED The device can not be written to.
@retval EFI_DEVICE_ERROR The device reported an error while performing the write.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The write request contains LBAs that are not valid,
or the buffer is not on proper alignment.
diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c
index fd483cb9a465..79026a4a957d 100644
--- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c
+++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c
@@ -536,7 +536,7 @@ TransferAtaDevice (
//
// As AtaBus is used to manage ATA devices, we have to use the lowest transfer rate to
// calculate the possible maximum timeout value for each read/write operation.
- // The timout value is rounded up to nearest integar and here an additional 30s is added
+ // The timeout value is rounded up to nearest integer and here an additional 30s is added
// to follow ATA spec in which it mentioned that the device may take up to 30s to respond
// commands in the Standby/Idle mode.
//
@@ -634,7 +634,7 @@ AtaTerminateNonBlockingTask (
}
/**
- Call back funtion when the event is signaled.
+ Call back function when the event is signaled.
@param[in] Event The Event this notify function registered to.
@param[in] Context Pointer to the context data registered to the
diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.uni b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.uni
index 00bebce11c2c..ec4aab24d5f6 100644
--- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.uni
+++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.uni
@@ -1,5 +1,5 @@
// /** @file
-// ATA Bus driver to enumerate and identfy ATA devices.
+// ATA Bus driver to enumerate and identify ATA devices.
//
// This driver follows UEFI driver model and layers on ATA Pass Thru protocol defined
// in UEFI spec 2.2. It installs Block IO and Disk Info protocol for each ATA device
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* [PATCH 14/79] MdeModulePkg/Bus/I2c: Fix few typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (12 preceding siblings ...)
2019-12-03 16:14 ` [PATCH 13/79] MdeModulePkg/Bus/Ata: " Philippe Mathieu-Daudé
@ 2019-12-03 16:14 ` Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 15/79] MdeModulePkg/Bus/Isa: Fix various typos Philippe Mathieu-Daudé
` (58 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:14 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Jian J Wang, Hao A Wu, Ray Ni,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix few typos in comments and documentation.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdeModulePkg/Bus/I2c/I2cDxe/I2cDxe.h | 4 ++--
MdeModulePkg/Bus/I2c/I2cDxe/I2cBus.c | 4 ++--
MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/MdeModulePkg/Bus/I2c/I2cDxe/I2cDxe.h b/MdeModulePkg/Bus/I2c/I2cDxe/I2cDxe.h
index 3c906e720359..49f1e9b17bec 100644
--- a/MdeModulePkg/Bus/I2c/I2cDxe/I2cDxe.h
+++ b/MdeModulePkg/Bus/I2c/I2cDxe/I2cDxe.h
@@ -426,7 +426,7 @@ I2cBusDriverSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -773,7 +773,7 @@ I2cHostDriverSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
diff --git a/MdeModulePkg/Bus/I2c/I2cDxe/I2cBus.c b/MdeModulePkg/Bus/I2c/I2cDxe/I2cBus.c
index ed33a51da252..1833c0afb81d 100644
--- a/MdeModulePkg/Bus/I2c/I2cDxe/I2cBus.c
+++ b/MdeModulePkg/Bus/I2c/I2cDxe/I2cBus.c
@@ -538,7 +538,7 @@ I2cBusDriverSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -623,7 +623,7 @@ I2cBusDriverStart (
if ((RemainingDevicePath != NULL) && IsDevicePathEnd (RemainingDevicePath)) {
//
// If RemainingDevicePath is the End of Device Path Node,
- // don't create any child device and return EFI_SUCESS
+ // don't create any child device and return EFI_SUCCESS
//
return EFI_SUCCESS;
}
diff --git a/MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c b/MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c
index 79c091694677..95294c9c9891 100644
--- a/MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c
+++ b/MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c
@@ -311,7 +311,7 @@ I2cHostDriverSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* [PATCH 15/79] MdeModulePkg/Bus/Isa: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (13 preceding siblings ...)
2019-12-03 16:14 ` [PATCH 14/79] MdeModulePkg/Bus/I2c: Fix few typos Philippe Mathieu-Daudé
@ 2019-12-03 16:14 ` Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 16/79] MdeModulePkg/Bus/Scsi: " Philippe Mathieu-Daudé
` (57 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:14 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Jian J Wang, Hao A Wu, Ray Ni,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in documentation, comments and debug strings.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf | 2 +-
MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 14 +++++++-------
MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.h | 2 +-
MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.h | 2 +-
MdeModulePkg/Bus/Isa/IsaBusDxe/IsaBusDxe.c | 6 +++---
MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 16 ++++++++--------
MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c | 20 ++++++++++----------
MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c | 4 ++--
MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.c | 2 +-
MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.c | 4 ++--
MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.uni | 2 +-
11 files changed, 37 insertions(+), 37 deletions(-)
diff --git a/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf b/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf
index cf2699c1d996..7e801ecd1f20 100644
--- a/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf
+++ b/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf
@@ -1,7 +1,7 @@
## @file
# PS2 Mouse Driver.
#
-# This dirver provides support for PS2 based mice.
+# This driver provides support for PS2 based mice.
#
# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
#
diff --git a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
index 3666ebc85e7a..c2762db03878 100644
--- a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
+++ b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
@@ -352,7 +352,7 @@ KeyboardReadKeyStroke (
Signal the event if there is key available
@param Event the event object
- @param Context waitting context
+ @param Context waiting context
**/
VOID
@@ -411,7 +411,7 @@ KeyboardWaitForKeyEx (
//
/**
- Reset the input device and optionaly run diagnostics
+ Reset the input device and optionally run diagnostics
@param This - Protocol instance pointer.
@param ExtendedVerification - Driver may perform diagnostics on reset.
@@ -430,7 +430,7 @@ KeyboardEfiResetEx (
/**
Reads the next keystroke from the input device. The WaitForKey Event can
- be used to test for existance of a keystroke via WaitForEvent () call.
+ be used to test for existence of a keystroke via WaitForEvent () call.
@param This - Protocol instance pointer.
@@ -438,7 +438,7 @@ KeyboardEfiResetEx (
state data for the key that was pressed.
@retval EFI_SUCCESS - The keystroke information was returned.
- @retval EFI_NOT_READY - There was no keystroke data availiable.
+ @retval EFI_NOT_READY - There was no keystroke data available.
@retval EFI_DEVICE_ERROR - The keystroke information was not returned due to
hardware errors.
@retval EFI_INVALID_PARAMETER - KeyData is NULL.
@@ -486,7 +486,7 @@ KeyboardSetState (
@param NotifyHandle - Points to the unique handle assigned to the registered notification.
@retval EFI_SUCCESS - The notification function was registered successfully.
- @retval EFI_OUT_OF_RESOURCES - Unable to allocate resources for necesssary data structures.
+ @retval EFI_OUT_OF_RESOURCES - Unable to allocate resources for necessary data structures.
@retval EFI_INVALID_PARAMETER - KeyData or NotifyHandle is NULL.
**/
@@ -531,7 +531,7 @@ PushEfikeyBufTail (
);
/**
- Judge whether is a registed key
+ Judge whether is a registered key
@param RegsiteredData A pointer to a buffer that is filled in with the keystroke
state data for the key that was registered.
@@ -539,7 +539,7 @@ PushEfikeyBufTail (
state data for the key that was pressed.
@retval TRUE Key be pressed matches a registered key.
- @retval FLASE Match failed.
+ @retval FALSE Match failed.
**/
BOOLEAN
diff --git a/MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.h b/MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.h
index 61380a4d1fc6..60da42121173 100644
--- a/MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.h
+++ b/MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.h
@@ -362,7 +362,7 @@ CheckForInput (
/**
I/O work flow to wait input buffer empty in given time.
- @param Timeout Wating time.
+ @param Timeout Waiting time.
@retval EFI_TIMEOUT if input is still not empty in given time.
@retval EFI_SUCCESS input is empty.
diff --git a/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.h b/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.h
index df2e283f6da3..1f7c310ad1f4 100644
--- a/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.h
+++ b/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.h
@@ -124,7 +124,7 @@ PS2MouseDriverSupported (
/**
Start this driver on ControllerHandle by opening a IsaIo
protocol, creating PS2_MOUSE_ABSOLUTE_POINTER_DEV device and install gEfiAbsolutePointerProtocolGuid
- finnally.
+ finally.
@param This Protocol instance pointer.
@param ControllerHandle Handle of device to bind driver to
diff --git a/MdeModulePkg/Bus/Isa/IsaBusDxe/IsaBusDxe.c b/MdeModulePkg/Bus/Isa/IsaBusDxe/IsaBusDxe.c
index af4041081d6a..ccda7c3f706e 100644
--- a/MdeModulePkg/Bus/Isa/IsaBusDxe/IsaBusDxe.c
+++ b/MdeModulePkg/Bus/Isa/IsaBusDxe/IsaBusDxe.c
@@ -109,7 +109,7 @@ ISA_BUS_CHILD_PRIVATE_DATA mIsaBusChildPrivateTemplate = {
then a new handle is created. If it is a pointer to an existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child
@@ -166,7 +166,7 @@ IsaBusCreateChild (
@param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param ChildHandle Handle of the child to destroy
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
@@ -272,7 +272,7 @@ ISA_BUS_PRIVATE_DATA mIsaBusPrivateTemplate = {
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
diff --git a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
index 87f6efd8dd64..d8d050b0a92a 100644
--- a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
+++ b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
@@ -799,7 +799,7 @@ KeyboardTimerHandler (
//
// To let KB driver support Hot plug, here should skip the 'resend' command for the case that
// KB is not connected to system. If KB is not connected to system, driver will find there's something
- // error in the following code and wait for the input buffer empty, this waiting time shoulb be short enough since
+ // error in the following code and wait for the input buffer empty, this waiting time should be short enough since
// this is a NOTIFY TPL period function, or the system performance will degrade hardly when KB is not connected.
// Just skip the 'resend' process simply.
//
@@ -827,7 +827,7 @@ KeyboardTimerHandler (
@param ConsoleIn - Pointer to instance of KEYBOARD_CONSOLE_IN_DEV
@param Data - Pointer to outof buffer for keeping key value
- @retval EFI_TIMEOUT Status resigter time out
+ @retval EFI_TIMEOUT Status register time out
@retval EFI_SUCCESS Success to read keyboard
**/
@@ -871,7 +871,7 @@ KeyboardRead (
@param Data value wanted to be written
@retval EFI_TIMEOUT The input buffer register is full for putting new value util timeout
- @retval EFI_SUCCESS The new value is sucess put into input buffer register.
+ @retval EFI_SUCCESS The new value is success put into input buffer register.
**/
EFI_STATUS
@@ -1688,7 +1688,7 @@ InitKeyboard (
if (EFI_ERROR (Status)) {
KeyboardError (
ConsoleIn,
- L"Some specific value not aquired from 8042 controller!\n\r"
+ L"Some specific value not acquired from 8042 controller!\n\r"
);
goto Done;
}
@@ -1703,7 +1703,7 @@ InitKeyboard (
Status = KeyboardWaitForValue (ConsoleIn, KEYBOARD_8048_RETURN_8042_ACK);
if (EFI_ERROR (Status)) {
- KeyboardError (ConsoleIn, L"Some specific value not aquired from 8042 controller!\n\r");
+ KeyboardError (ConsoleIn, L"Some specific value not acquired from 8042 controller!\n\r");
goto Done;
}
//
@@ -1730,7 +1730,7 @@ InitKeyboard (
Status = KeyboardWaitForValue (ConsoleIn, KEYBOARD_8048_RETURN_8042_ACK);
if (EFI_ERROR (Status)) {
- KeyboardError (ConsoleIn, L"Some specific value not aquired from 8042 controller!\n\r");
+ KeyboardError (ConsoleIn, L"Some specific value not acquired from 8042 controller!\n\r");
goto Done;
}
@@ -1742,7 +1742,7 @@ InitKeyboard (
Status = KeyboardWaitForValue (ConsoleIn, KEYBOARD_8048_RETURN_8042_ACK);
if (EFI_ERROR (Status)) {
- KeyboardError (ConsoleIn, L"Some specific value not aquired from 8042 controller!\n\r");
+ KeyboardError (ConsoleIn, L"Some specific value not acquired from 8042 controller!\n\r");
goto Done;
}
@@ -1757,7 +1757,7 @@ InitKeyboard (
Status = KeyboardWaitForValue (ConsoleIn, KEYBOARD_8048_RETURN_8042_ACK);
if (EFI_ERROR (Status)) {
- KeyboardError (ConsoleIn, L"Some specific value not aquired from 8042 controller!\n\r");
+ KeyboardError (ConsoleIn, L"Some specific value not acquired from 8042 controller!\n\r");
goto Done;
}
//
diff --git a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c
index 458519cb71e6..835f33cfa800 100644
--- a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c
+++ b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c
@@ -77,7 +77,7 @@ PushEfikeyBufTail (
}
/**
- Judge whether is a registed key
+ Judge whether is a registered key
@param RegsiteredData A pointer to a buffer that is filled in with the keystroke
state data for the key that was registered.
@@ -85,7 +85,7 @@ PushEfikeyBufTail (
state data for the key that was pressed.
@retval TRUE Key be pressed matches a registered key.
- @retval FLASE Match failed.
+ @retval FALSE Match failed.
**/
BOOLEAN
@@ -120,7 +120,7 @@ IsKeyRegistered (
/**
Reads the next keystroke from the input device. The WaitForKey Event can
- be used to test for existance of a keystroke via WaitForEvent () call.
+ be used to test for existence of a keystroke via WaitForEvent () call.
@param ConsoleInDev Ps2 Keyboard private structure
@param KeyData A pointer to a buffer that is filled in with the keystroke
@@ -128,7 +128,7 @@ IsKeyRegistered (
@retval EFI_SUCCESS The keystroke information was returned.
- @retval EFI_NOT_READY There was no keystroke data availiable.
+ @retval EFI_NOT_READY There was no keystroke data available.
@retval EFI_DEVICE_ERROR The keystroke information was not returned due to
hardware errors.
@retval EFI_INVALID_PARAMETER KeyData is NULL.
@@ -308,7 +308,7 @@ KeyboardReadKeyStroke (
Signal the event if there is key available
@param Event the event object
- @param Context waitting context
+ @param Context waiting context
**/
VOID
@@ -333,7 +333,7 @@ KeyboardWaitForKey (
if (!ConsoleIn->KeyboardErr) {
//
- // WaitforKey doesn't suppor the partial key.
+ // WaitforKey doesn't support the partial key.
// Considering if the partial keystroke is enabled, there maybe a partial
// keystroke in the queue, so here skip the partial keystroke and get the
// next key from the queue
@@ -381,7 +381,7 @@ KeyboardWaitForKeyEx (
}
/**
- Reset the input device and optionaly run diagnostics
+ Reset the input device and optionally run diagnostics
@param This Protocol instance pointer.
@param ExtendedVerification Driver may perform diagnostics on reset.
@@ -411,7 +411,7 @@ KeyboardEfiResetEx (
/**
Reads the next keystroke from the input device. The WaitForKey Event can
- be used to test for existance of a keystroke via WaitForEvent () call.
+ be used to test for existence of a keystroke via WaitForEvent () call.
@param This Protocol instance pointer.
@@ -419,7 +419,7 @@ KeyboardEfiResetEx (
state data for the key that was pressed.
@retval EFI_SUCCESS The keystroke information was returned.
- @retval EFI_NOT_READY There was no keystroke data availiable.
+ @retval EFI_NOT_READY There was no keystroke data available.
@retval EFI_DEVICE_ERROR The keystroke information was not returned due to
hardware errors.
@retval EFI_INVALID_PARAMETER KeyData is NULL.
@@ -540,7 +540,7 @@ Exit:
@param NotifyHandle Points to the unique handle assigned to the registered notification.
@retval EFI_SUCCESS The notification function was registered successfully.
- @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necesssary data structures.
+ @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necessary data structures.
@retval EFI_INVALID_PARAMETER KeyData or NotifyHandle or KeyNotificationFunction is NULL.
**/
diff --git a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c
index 2ee3a52ee58a..855fda742efc 100644
--- a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c
+++ b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c
@@ -77,7 +77,7 @@ KbdControllerDriverStop (
@param ListHead Pointer to list head
@retval EFI_INVALID_PARAMETER ListHead is NULL
- @retval EFI_SUCCESS Sucess to free NotifyList
+ @retval EFI_SUCCESS Success to free NotifyList
**/
EFI_STATUS
KbdFreeNotifyList (
@@ -597,7 +597,7 @@ KbdControllerDriverStop (
@param ListHead Pointer to list head
@retval EFI_INVALID_PARAMETER ListHead is NULL
- @retval EFI_SUCCESS Sucess to free NotifyList
+ @retval EFI_SUCCESS Success to free NotifyList
**/
EFI_STATUS
KbdFreeNotifyList (
diff --git a/MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.c b/MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.c
index 4eb30276cd6f..d8fed87c1653 100644
--- a/MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.c
+++ b/MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.c
@@ -775,7 +775,7 @@ CheckForInput (
/**
I/O work flow to wait input buffer empty in given time.
- @param Timeout Wating time.
+ @param Timeout Waiting time.
@retval EFI_TIMEOUT if input is still not empty in given time.
@retval EFI_SUCCESS input is empty.
diff --git a/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.c b/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.c
index fd34e3eaf89f..ebcb2a43dc3c 100644
--- a/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.c
+++ b/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.c
@@ -587,8 +587,8 @@ MouseReset (
Status = EFI_SUCCESS;
//
- // The PS2 mouse driver reset behavior is always successfully return no matter wheater or not there is mouse connected to system.
- // This behavior is needed by performance speed. The following mouse command only succeessfully finish when mouse device is
+ // The PS2 mouse driver reset behavior is always successfully return no matter whether or not there is mouse connected to system.
+ // This behavior is needed by performance speed. The following mouse command only successfully finish when mouse device is
// connected to system, so if PS2 mouse device not connect to system or user not ask for, we skip the mouse configuration and enabling
//
if (ExtendedVerification && CheckMouseConnect (MouseDev)) {
diff --git a/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.uni b/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.uni
index 9e153e76db46..e41869a01359 100644
--- a/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.uni
+++ b/MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.uni
@@ -1,7 +1,7 @@
// /** @file
// PS2 Mouse Driver.
//
-// This dirver provides support for PS2 based mice.
+// This driver provides support for PS2 based mice.
//
// Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
//
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* [PATCH 16/79] MdeModulePkg/Bus/Scsi: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (14 preceding siblings ...)
2019-12-03 16:14 ` [PATCH 15/79] MdeModulePkg/Bus/Isa: Fix various typos Philippe Mathieu-Daudé
@ 2019-12-03 16:14 ` Philippe Mathieu-Daudé
2019-12-03 16:15 ` [PATCH 17/79] MdeModulePkg/Bus/Sd: " Philippe Mathieu-Daudé
` (56 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:14 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Jian J Wang, Hao A Wu, Ray Ni,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.h | 4 +--
MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 10 +++---
MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 6 ++--
MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 32 ++++++++++----------
4 files changed, 26 insertions(+), 26 deletions(-)
diff --git a/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.h b/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.h
index 917e937520a8..97581866b6f7 100644
--- a/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.h
+++ b/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.h
@@ -50,7 +50,7 @@ typedef struct {
} SCSI_EVENT_DATA;
//
-// SCSI Bus Controller device strcuture
+// SCSI Bus Controller device structure
//
#define SCSI_BUS_DEVICE_SIGNATURE SIGNATURE_32 ('s', 'c', 's', 'i')
@@ -450,7 +450,7 @@ ScsiExecuteSCSICommand (
@param This Protocol instance pointer
@param Controller Controller handle
- @param TargetId Tartget to be scanned
+ @param TargetId Target to be scanned
@param Lun The Lun of the SCSI device on the SCSI channel.
@param ScsiBusDev The pointer of SCSI_BUS_DEVICE
diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h
index 2d8679ec6fd0..ed9bbd6f8ba8 100644
--- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h
+++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h
@@ -185,7 +185,7 @@ extern EFI_COMPONENT_NAME2_PROTOCOL gScsiDiskComponentName2;
//
// SCSI Disk Timeout Experience Value
//
-// As ScsiDisk and ScsiBus driver are used to manage SCSI or ATAPI devices, the timout
+// As ScsiDisk and ScsiBus driver are used to manage SCSI or ATAPI devices, the timeout
// value is updated to 30s to follow ATA/ATAPI spec in which the device may take up to 30s
// to respond command.
//
@@ -412,7 +412,7 @@ ScsiDiskComponentNameGetControllerName (
@retval EFI_SUCCESS The device was reset.
@retval EFI_DEVICE_ERROR The device is not functioning properly and could
not be reset.
- @return EFI_STATUS is retured from EFI_SCSI_IO_PROTOCOL.ResetDevice().
+ @return EFI_STATUS is returned from EFI_SCSI_IO_PROTOCOL.ResetDevice().
**/
EFI_STATUS
@@ -464,7 +464,7 @@ ScsiDiskReadBlocks (
@retval EFI_WRITE_PROTECTED The device can not be written to.
@retval EFI_DEVICE_ERROR Fail to detect media.
@retval EFI_NO_MEDIA Media is not present.
- @retval EFI_MEDIA_CHNAGED Media has changed.
+ @retval EFI_MEDIA_CHANGED Media has changed.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER Invalid parameter passed in.
@@ -1010,7 +1010,7 @@ CheckTargetStatus (
When encountering error during the process, if retrieve sense keys before
error encountered, it returns the sense keys with return status set to EFI_SUCCESS,
- and NeedRetry set to FALSE; otherwize, return the proper return status.
+ and NeedRetry set to FALSE; otherwise, return the proper return status.
@param ScsiDiskDevice The pointer of SCSI_DISK_DEV
@param NeedRetry The pointer of flag indicates if need a retry
@@ -1444,7 +1444,7 @@ ScsiDiskIsHardwareError (
@param SenseCounts The number of sense key
@retval TRUE Media is changed.
- @retval FALSE Medit is NOT changed.
+ @retval FALSE Media is NOT changed.
**/
BOOLEAN
ScsiDiskIsMediaChange (
diff --git a/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c b/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c
index 1caffd38cdcb..27b554ad3e1d 100644
--- a/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c
+++ b/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c
@@ -487,7 +487,7 @@ SCSIBusDriverBindingStart (
} else {
//
// If RemainingDevicePath is the End of Device Path Node,
- // skip enumerate any device and return EFI_SUCESSS
+ // skip enumerate any device and return EFI_SUCCESS
//
ScanOtherPuns = FALSE;
}
@@ -644,7 +644,7 @@ SCSIBusDriverBindingStop (
);
//
// When Start() succeeds to open ExtPassThru, it always tries to open PassThru BY_DRIVER.
- // Its intent is to prevent another SCSI Bus Driver from woking on the same host handle.
+ // Its intent is to prevent another SCSI Bus Driver from working on the same host handle.
// So Stop() needs to try to close PassThru if present here.
//
gBS->CloseProtocol (
@@ -1099,7 +1099,7 @@ ScsiExecuteSCSICommand (
@param This Protocol instance pointer
@param Controller Controller handle
- @param TargetId Tartget to be scanned
+ @param TargetId Target to be scanned
@param Lun The Lun of the SCSI device on the SCSI channel.
@param ScsiBusDev The pointer of SCSI_BUS_DEVICE
diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
index 6bfcf03a4b41..c80e78fa8a6b 100644
--- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
+++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
@@ -704,7 +704,7 @@ Done:
@retval EFI_WRITE_PROTECTED The device can not be written to.
@retval EFI_DEVICE_ERROR Fail to detect media.
@retval EFI_NO_MEDIA Media is not present.
- @retval EFI_MEDIA_CHNAGED Media has changed.
+ @retval EFI_MEDIA_CHANGED Media has changed.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER Invalid parameter passed in.
@@ -3166,7 +3166,7 @@ CheckTargetStatus (
When encountering error during the process, if retrieve sense keys before
error encountered, it returns the sense keys with return status set to EFI_SUCCESS,
- and NeedRetry set to FALSE; otherwize, return the proper return status.
+ and NeedRetry set to FALSE; otherwise, return the proper return status.
@param ScsiDiskDevice The pointer of SCSI_DISK_DEV
@param NeedRetry The pointer of flag indicates if need a retry
@@ -3438,7 +3438,7 @@ ScsiDiskReadSectors (
// As ScsiDisk and ScsiBus driver are used to manage SCSI or ATAPI devices, we have to use
// the lowest transfer rate to calculate the possible maximum timeout value for each operation.
// From the above table, we could know 2.1Mbytes per second is lowest one.
- // The timout value is rounded up to nearest integar and here an additional 30s is added
+ // The timeout value is rounded up to nearest integer and here an additional 30s is added
// to follow ATA spec in which it mentioned that the device may take up to 30s to respond
// commands in the Standby/Idle mode.
//
@@ -3482,7 +3482,7 @@ ScsiDiskReadSectors (
// it is invalid to request more sectors in the CDB than the entire
// transfer (ie. ByteCount) can carry.
//
- // In addition, ByteCount is only expected to go down, or stay unchaged.
+ // In addition, ByteCount is only expected to go down, or stay unchanged.
// Therefore we don't need to update Timeout: the original timeout should
// accommodate shorter transfers too.
//
@@ -3603,7 +3603,7 @@ ScsiDiskWriteSectors (
// As ScsiDisk and ScsiBus driver are used to manage SCSI or ATAPI devices, we have to use
// the lowest transfer rate to calculate the possible maximum timeout value for each operation.
// From the above table, we could know 2.1Mbytes per second is lowest one.
- // The timout value is rounded up to nearest integar and here an additional 30s is added
+ // The timeout value is rounded up to nearest integer and here an additional 30s is added
// to follow ATA spec in which it mentioned that the device may take up to 30s to respond
// commands in the Standby/Idle mode.
//
@@ -3646,7 +3646,7 @@ ScsiDiskWriteSectors (
// it is invalid to request more sectors in the CDB than the entire
// transfer (ie. ByteCount) can carry.
//
- // In addition, ByteCount is only expected to go down, or stay unchaged.
+ // In addition, ByteCount is only expected to go down, or stay unchanged.
// Therefore we don't need to update Timeout: the original timeout should
// accommodate shorter transfers too.
//
@@ -3787,7 +3787,7 @@ ScsiDiskAsyncReadSectors (
// we have to use the lowest transfer rate to calculate the possible
// maximum timeout value for each operation.
// From the above table, we could know 2.1Mbytes per second is lowest one.
- // The timout value is rounded up to nearest integar and here an additional
+ // The timeout value is rounded up to nearest integer and here an additional
// 30s is added to follow ATA spec in which it mentioned that the device
// may take up to 30s to respond commands in the Standby/Idle mode.
//
@@ -4004,7 +4004,7 @@ ScsiDiskAsyncWriteSectors (
// we have to use the lowest transfer rate to calculate the possible
// maximum timeout value for each operation.
// From the above table, we could know 2.1Mbytes per second is lowest one.
- // The timout value is rounded up to nearest integar and here an additional
+ // The timeout value is rounded up to nearest integer and here an additional
// 30s is added to follow ATA spec in which it mentioned that the device
// may take up to 30s to respond commands in the Standby/Idle mode.
//
@@ -4143,10 +4143,10 @@ ScsiDiskRead10 (
UINTN Action;
//
- // Implement a backoff algorithem to resolve some compatibility issues that
+ // Implement a backoff algorithm to resolve some compatibility issues that
// some SCSI targets or ATAPI devices couldn't correctly response reading/writing
// big data in a single operation.
- // This algorithem will at first try to execute original request. If the request fails
+ // This algorithm will at first try to execute original request. If the request fails
// with media error sense data or else, it will reduce the transfer length to half and
// try again till the operation succeeds or fails with one sector transfer length.
//
@@ -4268,10 +4268,10 @@ ScsiDiskWrite10 (
UINTN Action;
//
- // Implement a backoff algorithem to resolve some compatibility issues that
+ // Implement a backoff algorithm to resolve some compatibility issues that
// some SCSI targets or ATAPI devices couldn't correctly response reading/writing
// big data in a single operation.
- // This algorithem will at first try to execute original request. If the request fails
+ // This algorithm will at first try to execute original request. If the request fails
// with media error sense data or else, it will reduce the transfer length to half and
// try again till the operation succeeds or fails with one sector transfer length.
//
@@ -4391,10 +4391,10 @@ ScsiDiskRead16 (
UINTN Action;
//
- // Implement a backoff algorithem to resolve some compatibility issues that
+ // Implement a backoff algorithm to resolve some compatibility issues that
// some SCSI targets or ATAPI devices couldn't correctly response reading/writing
// big data in a single operation.
- // This algorithem will at first try to execute original request. If the request fails
+ // This algorithm will at first try to execute original request. If the request fails
// with media error sense data or else, it will reduce the transfer length to half and
// try again till the operation succeeds or fails with one sector transfer length.
//
@@ -4515,10 +4515,10 @@ ScsiDiskWrite16 (
UINTN Action;
//
- // Implement a backoff algorithem to resolve some compatibility issues that
+ // Implement a backoff algorithm to resolve some compatibility issues that
// some SCSI targets or ATAPI devices couldn't correctly response reading/writing
// big data in a single operation.
- // This algorithem will at first try to execute original request. If the request fails
+ // This algorithm will at first try to execute original request. If the request fails
// with media error sense data or else, it will reduce the transfer length to half and
// try again till the operation succeeds or fails with one sector transfer length.
//
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* [PATCH 17/79] MdeModulePkg/Bus/Sd: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (15 preceding siblings ...)
2019-12-03 16:14 ` [PATCH 16/79] MdeModulePkg/Bus/Scsi: " Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-03 16:15 ` [PATCH 18/79] MdeModulePkg/Core/Pei: " Philippe Mathieu-Daudé
` (55 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Jian J Wang, Hao A Wu, Ray Ni,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.h | 2 +-
MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h | 6 +++---
MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.h | 2 +-
MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.h | 6 +++---
MdeModulePkg/Bus/Sd/SdDxe/SdDxe.h | 2 +-
MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c | 2 +-
MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c | 12 ++++++------
MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c | 12 ++++++------
MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.c | 2 +-
MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c | 2 +-
MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHci.c | 6 +++---
MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 10 +++++-----
MdeModulePkg/Bus/Sd/SdDxe/SdDxe.c | 2 +-
13 files changed, 33 insertions(+), 33 deletions(-)
diff --git a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.h b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.h
index c0e461335f43..4e3e51d14403 100644
--- a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.h
+++ b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.h
@@ -244,7 +244,7 @@ EmmcPeimHcInitHost (
Refer to EMMC Electrical Standard Spec 5.1 Section 6.10.4 for details.
@param[in] Slot The slot number of the Emmc card to send the command to.
- @param[in] Access The access mode of SWTICH command.
+ @param[in] Access The access mode of SWITCH command.
@param[in] Index The offset of the field to be access.
@param[in] Value The value to be set to the specified field of EXT_CSD register.
@param[in] CmdSet The value of CmdSet field of EXT_CSD register.
diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h
index 86957a42daea..62e70ae912b0 100644
--- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h
+++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h
@@ -43,7 +43,7 @@ EmmcReset (
@retval EFI_SUCCESS The data was read correctly from the device.
@retval EFI_DEVICE_ERROR The device reported an error while performing the read.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHANGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The read request contains LBAs that are not valid,
or the buffer is not on proper alignment.
@@ -73,7 +73,7 @@ EmmcReadBlocks (
@retval EFI_WRITE_PROTECTED The device can not be written to.
@retval EFI_DEVICE_ERROR The device reported an error while performing the write.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The write request contains LBAs that are not valid,
or the buffer is not on proper alignment.
@@ -176,7 +176,7 @@ EmmcReadBlocksEx (
@retval EFI_WRITE_PROTECTED The device can not be written to.
@retval EFI_DEVICE_ERROR The device reported an error while performing the write.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The write request contains LBAs that are not valid,
or the buffer is not on proper alignment.
diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.h b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.h
index d286d97f4213..5ecce41dee11 100644
--- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.h
+++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.h
@@ -235,7 +235,7 @@ EmmcDxeDriverBindingSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
diff --git a/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.h b/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.h
index 769b47106400..b6b4c45f1f3d 100644
--- a/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.h
+++ b/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.h
@@ -43,7 +43,7 @@ SdReset (
@retval EFI_SUCCESS The data was read correctly from the device.
@retval EFI_DEVICE_ERROR The device reported an error while performing the read.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHANGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The read request contains LBAs that are not valid,
or the buffer is not on proper alignment.
@@ -73,7 +73,7 @@ SdReadBlocks (
@retval EFI_WRITE_PROTECTED The device can not be written to.
@retval EFI_DEVICE_ERROR The device reported an error while performing the write.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The write request contains LBAs that are not valid,
or the buffer is not on proper alignment.
@@ -176,7 +176,7 @@ SdReadBlocksEx (
@retval EFI_WRITE_PROTECTED The device can not be written to.
@retval EFI_DEVICE_ERROR The device reported an error while performing the write.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The write request contains LBAs that are not valid,
or the buffer is not on proper alignment.
diff --git a/MdeModulePkg/Bus/Sd/SdDxe/SdDxe.h b/MdeModulePkg/Bus/Sd/SdDxe/SdDxe.h
index d23f5a07a511..ff740a52183b 100644
--- a/MdeModulePkg/Bus/Sd/SdDxe/SdDxe.h
+++ b/MdeModulePkg/Bus/Sd/SdDxe/SdDxe.h
@@ -210,7 +210,7 @@ SdDxeDriverBindingSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
diff --git a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c
index c60ac30421e6..19a0afcb6d2c 100644
--- a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c
+++ b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c
@@ -128,7 +128,7 @@ EmmcPeimAllocMemFromBlock (
//
// If current bit is zero, the corresponding memory unit is
// available, otherwise we need to restart our searching.
- // Available counts the consective number of zero bit.
+ // Available counts the consecutive number of zero bit.
//
if (!EMMC_PEIM_MEM_BIT_IS_SET (Block->Bits[Byte], Bit)) {
Available++;
diff --git a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
index 679646eeb277..287a10266a6a 100644
--- a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
+++ b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
@@ -1290,7 +1290,7 @@ EmmcPeimExecTrb (
BlkCount = 0;
if (Trb->Mode != EmmcNoData) {
//
- // Calcuate Block Count.
+ // Calculate Block Count.
//
BlkCount = (UINT16)(Trb->DataLen / Trb->BlockSize);
}
@@ -2017,7 +2017,7 @@ EmmcPeimGetExtCsd (
Refer to EMMC Electrical Standard Spec 5.1 Section 6.10.4 for details.
@param[in] Slot The slot number of the Emmc card to send the command to.
- @param[in] Access The access mode of SWTICH command.
+ @param[in] Access The access mode of SWITCH command.
@param[in] Index The offset of the field to be access.
@param[in] Value The value to be set to the specified field of EXT_CSD register.
@param[in] CmdSet The value of CmdSet field of EXT_CSD register.
@@ -2273,7 +2273,7 @@ EmmcPeimSendTuningBlk (
}
/**
- Tunning the clock to get HS200 optimal sampling point.
+ Tuning the clock to get HS200 optimal sampling point.
Command SEND_TUNING_BLOCK may be sent up to 40 times until the host finishes the
tuning procedure.
@@ -2509,7 +2509,7 @@ EmmcPeimSwitchToHighSpeed (
return Status;
}
//
- // Set to Hight Speed timing
+ // Set to High Speed timing
//
HostCtrl1 = BIT2;
Status = EmmcPeimHcOrMmio (Slot->EmmcHcBase + EMMC_HC_HOST_CTRL1, sizeof (HostCtrl1), &HostCtrl1);
@@ -2658,7 +2658,7 @@ EmmcPeimSwitchToHS400 (
return Status;
}
//
- // Set to Hight Speed timing and set the clock frequency to a value less than 52MHz.
+ // Set to High Speed timing and set the clock frequency to a value less than 52MHz.
//
HsTiming = 1;
Status = EmmcPeimSwitchClockFreq (Slot, Rca, HsTiming, 52);
@@ -2752,7 +2752,7 @@ EmmcPeimSetBusMode (
BusWidth = 4;
}
//
- // Get Deivce_Type from EXT_CSD register.
+ // Get Device_Type from EXT_CSD register.
//
Status = EmmcPeimGetExtCsd (Slot, &Slot->ExtCsd);
if (EFI_ERROR (Status)) {
diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c
index 1b247af57622..afdc0a57efc9 100644
--- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c
+++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c
@@ -9,7 +9,7 @@
#include "EmmcDxe.h"
/**
- Nonblocking I/O callback funtion when the event is signaled.
+ Nonblocking I/O callback function when the event is signaled.
@param[in] Event The Event this notify function registered to.
@param[in] Context Pointer to the context data registered to the
@@ -785,7 +785,7 @@ Error:
@retval EFI_WRITE_PROTECTED The device can not be read/written to.
@retval EFI_DEVICE_ERROR The device reported an error while performing the read/write.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The read/write request contains LBAs that are not valid,
or the buffer is not on proper alignment.
@@ -954,7 +954,7 @@ EmmcReset (
@retval EFI_SUCCESS The data was read correctly from the device.
@retval EFI_DEVICE_ERROR The device reported an error while performing the read.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHANGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The read request contains LBAs that are not valid,
or the buffer is not on proper alignment.
@@ -993,7 +993,7 @@ EmmcReadBlocks (
@retval EFI_WRITE_PROTECTED The device can not be written to.
@retval EFI_DEVICE_ERROR The device reported an error while performing the write.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The write request contains LBAs that are not valid,
or the buffer is not on proper alignment.
@@ -1151,7 +1151,7 @@ EmmcReadBlocksEx (
@retval EFI_WRITE_PROTECTED The device can not be written to.
@retval EFI_DEVICE_ERROR The device reported an error while performing the write.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The write request contains LBAs that are not valid,
or the buffer is not on proper alignment.
@@ -2058,7 +2058,7 @@ EmmcEraseBlocks (
//
// If the size to erase is smaller than the erase group size, the whole
- // erase operation is performed by writting zeros.
+ // erase operation is performed by writing zeros.
//
if (BlockNum < EraseGroupSize) {
Status = EmmcWriteZeros (Partition, FirstLba, Size);
diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.c b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.c
index e2ae56c5058a..e9095b904c56 100644
--- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.c
+++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.c
@@ -812,7 +812,7 @@ EmmcDxeDriverBindingSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
diff --git a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
index 63a35cc2535c..fb043c19fffd 100644
--- a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
+++ b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
@@ -128,7 +128,7 @@ SdPeimAllocMemFromBlock (
//
// If current bit is zero, the corresponding memory unit is
// available, otherwise we need to restart our searching.
- // Available counts the consective number of zero bit.
+ // Available counts the consecutive number of zero bit.
//
if (!SD_PEIM_MEM_BIT_IS_SET (Block->Bits[Byte], Bit)) {
Available++;
diff --git a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHci.c b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHci.c
index 5efc06af5f8d..756c3063bbff 100644
--- a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHci.c
+++ b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHci.c
@@ -1290,7 +1290,7 @@ SdPeimExecTrb (
BlkCount = 0;
if (Trb->Mode != SdNoData) {
//
- // Calcuate Block Count.
+ // Calculate Block Count.
//
BlkCount = (UINT16)(Trb->DataLen / Trb->BlockSize);
}
@@ -2494,7 +2494,7 @@ SdPeimSendTuningBlk (
}
/**
- Tunning the sampling point of SDR104 or SDR50 bus speed mode.
+ Tuning the sampling point of SDR104 or SDR50 bus speed mode.
Command SD_SEND_TUNING_BLOCK may be sent up to 40 times until the host finishes the
tuning procedure.
@@ -2702,7 +2702,7 @@ SdPeimSetBusMode (
return EFI_DEVICE_ERROR;
}
//
- // Set to Hight Speed timing
+ // Set to High Speed timing
//
if (AccessMode == 1) {
HostCtrl1 = BIT2;
diff --git a/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c b/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c
index 876efe31e5d3..9f42abe7e2ad 100644
--- a/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c
+++ b/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c
@@ -9,7 +9,7 @@
#include "SdDxe.h"
/**
- Nonblocking I/O callback funtion when the event is signaled.
+ Nonblocking I/O callback function when the event is signaled.
@param[in] Event The Event this notify function registered to.
@param[in] Context Pointer to the context data registered to the
@@ -569,7 +569,7 @@ Error:
@retval EFI_WRITE_PROTECTED The device can not be read/written to.
@retval EFI_DEVICE_ERROR The device reported an error while performing the read/write.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The read/write request contains LBAs that are not valid,
or the buffer is not on proper alignment.
@@ -721,7 +721,7 @@ SdReset (
@retval EFI_SUCCESS The data was read correctly from the device.
@retval EFI_DEVICE_ERROR The device reported an error while performing the read.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHANGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The read request contains LBAs that are not valid,
or the buffer is not on proper alignment.
@@ -760,7 +760,7 @@ SdReadBlocks (
@retval EFI_WRITE_PROTECTED The device can not be written to.
@retval EFI_DEVICE_ERROR The device reported an error while performing the write.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The write request contains LBAs that are not valid,
or the buffer is not on proper alignment.
@@ -918,7 +918,7 @@ SdReadBlocksEx (
@retval EFI_WRITE_PROTECTED The device can not be written to.
@retval EFI_DEVICE_ERROR The device reported an error while performing the write.
@retval EFI_NO_MEDIA There is no media in the device.
- @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device.
+ @retval EFI_MEDIA_CHANGED The MediaId does not match the current device.
@retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device.
@retval EFI_INVALID_PARAMETER The write request contains LBAs that are not valid,
or the buffer is not on proper alignment.
diff --git a/MdeModulePkg/Bus/Sd/SdDxe/SdDxe.c b/MdeModulePkg/Bus/Sd/SdDxe/SdDxe.c
index e341b4cc1c8d..73bcc181c13f 100644
--- a/MdeModulePkg/Bus/Sd/SdDxe/SdDxe.c
+++ b/MdeModulePkg/Bus/Sd/SdDxe/SdDxe.c
@@ -563,7 +563,7 @@ SdDxeDriverBindingSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* [PATCH 18/79] MdeModulePkg/Core/Pei: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (16 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 17/79] MdeModulePkg/Bus/Sd: " Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-03 16:15 ` [PATCH 19/79] MdeModulePkg/Core/PiSmmCore: " Philippe Mathieu-Daudé
` (54 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Jian J Wang, Hao A Wu, Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdeModulePkg/Core/Pei/PeiMain.h | 20 +++++++-------
MdeModulePkg/Core/Pei/Dependency/Dependency.c | 4 +--
MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 28 ++++++++++----------
MdeModulePkg/Core/Pei/FwVol/FwVol.c | 8 +++---
MdeModulePkg/Core/Pei/Hob/Hob.c | 2 +-
MdeModulePkg/Core/Pei/Image/Image.c | 8 +++---
MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 10 +++----
MdeModulePkg/Core/Pei/PeiMain/PeiMain.c | 4 +--
MdeModulePkg/Core/Pei/Ppi/Ppi.c | 2 +-
MdeModulePkg/Core/Pei/Security/Security.c | 2 +-
10 files changed, 44 insertions(+), 44 deletions(-)
diff --git a/MdeModulePkg/Core/Pei/PeiMain.h b/MdeModulePkg/Core/Pei/PeiMain.h
index f2aa97c6640c..f799f5e2776c 100644
--- a/MdeModulePkg/Core/Pei/PeiMain.h
+++ b/MdeModulePkg/Core/Pei/PeiMain.h
@@ -136,11 +136,11 @@ typedef struct {
EFI_PEI_FV_HANDLE FvHandle;
UINTN PeimCount;
//
- // Ponter to the buffer with the PeimCount number of Entries.
+ // Pointer to the buffer with the PeimCount number of Entries.
//
UINT8 *PeimState;
//
- // Ponter to the buffer with the PeimCount number of Entries.
+ // Pointer to the buffer with the PeimCount number of Entries.
//
EFI_PEI_FILE_HANDLE *FvFileHandles;
BOOLEAN ScanFv;
@@ -282,7 +282,7 @@ struct _PEI_CORE_INSTANCE {
EFI_PHYSICAL_ADDRESS LoadModuleAtFixAddressTopAddress;
//
// The field is define for Loading modules at fixed address feature to tracker the PEI code
- // memory range usage. It is a bit mapped array in which every bit indicates the correspoding memory page
+ // memory range usage. It is a bit mapped array in which every bit indicates the corresponding memory page
// available or not.
//
UINT64 *PeiCodeMemoryRangeUsageBitMap;
@@ -372,7 +372,7 @@ PeiCore (
This is the POSTFIX version of the dependency evaluator. When a
PUSH [PPI GUID] is encountered, a pointer to the GUID is stored on
- the evaluation stack. When that entry is poped from the evaluation
+ the evaluation stack. When that entry is popped from the evaluation
stack, the PPI is checked if it is installed. This method allows
some time savings as not all PPIs must be checked for certain
operation types (AND, OR).
@@ -412,7 +412,7 @@ PeiDispatcher (
@param PrivateData PeiCore's private data structure
@param OldCoreData Old data from SecCore
- NULL if being run in non-permament memory mode.
+ NULL if being run in non-permanent memory mode.
@param SecCoreData Points to a data structure containing SEC to PEI handoff data, such as the size
and location of temporary RAM, the stack location and the BFV location.
@@ -453,7 +453,7 @@ DepexSatisfied (
@param PrivateData Pointer to the PEI Core data.
@param OldCoreData Pointer to old PEI Core data.
- NULL if being run in non-permament memory mode.
+ NULL if being run in non-permanent memory mode.
**/
VOID
@@ -555,7 +555,7 @@ PeiLocatePpi (
@retval EFI_SUCCESS if successful
@retval EFI_OUT_OF_RESOURCES if no space in the database
- @retval EFI_INVALID_PARAMETER if not a good decriptor
+ @retval EFI_INVALID_PARAMETER if not a good descriptor
**/
EFI_STATUS
@@ -659,7 +659,7 @@ PeiSetBootMode (
@param PeiServices An indirect pointer to the EFI_PEI_SERVICES table published by the PEI Foundation.
@param OldCoreData Pointer to the old core data.
- NULL if being run in non-permament memory mode.
+ NULL if being run in non-permanent memory mode.
**/
VOID
@@ -887,7 +887,7 @@ PeiFfsFindNextVolume (
@param SecCoreData Points to a data structure containing SEC to PEI handoff data, such as the size
and location of temporary RAM, the stack location and the BFV location.
@param OldCoreData Pointer to the PEI Core data.
- NULL if being run in non-permament memory mode.
+ NULL if being run in non-permanent memory mode.
**/
VOID
@@ -1125,7 +1125,7 @@ PeiInitializeFv (
);
/**
- Process Firmware Volum Information once FvInfoPPI install.
+ Process Firmware Volume Information once FvInfoPPI install.
@param PeiServices An indirect pointer to the EFI_PEI_SERVICES table published by the PEI Foundation.
@param NotifyDescriptor Address of the notification descriptor data structure.
diff --git a/MdeModulePkg/Core/Pei/Dependency/Dependency.c b/MdeModulePkg/Core/Pei/Dependency/Dependency.c
index 6ce610a02833..5fedeb80b10d 100644
--- a/MdeModulePkg/Core/Pei/Dependency/Dependency.c
+++ b/MdeModulePkg/Core/Pei/Dependency/Dependency.c
@@ -72,7 +72,7 @@ IsPpiInstalled (
This is the POSTFIX version of the dependency evaluator. When a
PUSH [PPI GUID] is encountered, a pointer to the GUID is stored on
- the evaluation stack. When that entry is poped from the evaluation
+ the evaluation stack. When that entry is popped from the evaluation
stack, the PPI is checked if it is installed. This method allows
some time savings as not all PPIs must be checked for certain
operation types (AND, OR).
@@ -123,7 +123,7 @@ PeimDispatchReadiness (
//
// Push the pointer to the PUSH opcode operator (pointer to PPI GUID)
- // We will evaluate if the PPI is insalled on the POP operation.
+ // We will evaluate if the PPI is installed on the POP operation.
//
StackPtr->Operator = (VOID *) Iterator;
Iterator = Iterator + sizeof (EFI_GUID);
diff --git a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
index ba2fd0cae14f..182685b5c014 100644
--- a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
+++ b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
@@ -257,7 +257,7 @@ PeiLoadFixAddressIsMemoryRangeAvailable (
This function should only be invoked when Loading Module at Fixed Address(LMFA) feature is enabled. When feature is
configured as Load Modules at Fix Absolute Address, this function is to validate the top address assigned by user. When
- feature is configured as Load Modules at Fixed Offset, the functino is to find the top address which is TOLM-TSEG in general.
+ feature is configured as Load Modules at Fixed Offset, the function is to find the top address which is TOLM-TSEG in general.
And also the function will re-install PEI memory.
@param PrivateData Pointer to the private data passed in from caller
@@ -393,12 +393,12 @@ PeiLoadFixAddressHook(
continue;
}
//
- // If the range describe in memory allocation HOB belongs to the memroy range described by the resource hob
+ // If the range describe in memory allocation HOB belongs to the memory range described by the resource hob
//
if (MemoryHob->AllocDescriptor.MemoryBaseAddress >= NextResourceHob->PhysicalStart &&
MemoryHob->AllocDescriptor.MemoryBaseAddress + MemoryHob->AllocDescriptor.MemoryLength <= NextResourceHob->PhysicalStart + NextResourceHob->ResourceLength) {
//
- // Build seperate resource hob for this allocated range
+ // Build separate resource hob for this allocated range
//
if (MemoryHob->AllocDescriptor.MemoryBaseAddress > NextResourceHob->PhysicalStart) {
BuildResourceDescriptorHob (
@@ -452,7 +452,7 @@ PeiLoadFixAddressHook(
ResourceHob = Hob.ResourceDescriptor;
//
- // See if this resource descrior HOB describes tested system memory below MAX_ADDRESS
+ // See if this resource descriptor HOB describes tested system memory below MAX_ADDRESS
//
if (ResourceHob->ResourceType == EFI_RESOURCE_SYSTEM_MEMORY &&
ResourceHob->PhysicalStart + ResourceHob->ResourceLength <= MAX_ADDRESS) {
@@ -476,7 +476,7 @@ PeiLoadFixAddressHook(
DEBUG ((EFI_D_INFO, "LOADING MODULE FIXED ERROR:Top Address 0x%lx is invalid \n", TopLoadingAddress));
DEBUG ((EFI_D_INFO, "LOADING MODULE FIXED ERROR:The recommended Top Address for the platform is: \n"));
//
- // Print the recomended Top address range.
+ // Print the recommended Top address range.
//
for (Hob.Raw = PrivateData->HobList.Raw; !END_OF_HOB_LIST(Hob); Hob.Raw = GET_NEXT_HOB(Hob)) {
//
@@ -486,7 +486,7 @@ PeiLoadFixAddressHook(
ResourceHob = Hob.ResourceDescriptor;
//
- // See if this resource descrior HOB describes tested system memory below MAX_ADDRESS
+ // See if this resource descriptor HOB describes tested system memory below MAX_ADDRESS
//
if (ResourceHob->ResourceType == EFI_RESOURCE_SYSTEM_MEMORY &&
ResourceHob->PhysicalStart + ResourceHob->ResourceLength <= MAX_ADDRESS) {
@@ -524,7 +524,7 @@ PeiLoadFixAddressHook(
ResourceHob = Hob.ResourceDescriptor;
//
- // See if this resource descrior HOB describes tested system memory below MAX_ADDRESS
+ // See if this resource descriptor HOB describes tested system memory below MAX_ADDRESS
//
if (ResourceHob->ResourceType == EFI_RESOURCE_SYSTEM_MEMORY &&
ResourceHob->PhysicalStart + ResourceHob->ResourceLength <= MAX_ADDRESS &&
@@ -554,7 +554,7 @@ PeiLoadFixAddressHook(
if (CurrentResourceHob != NULL) {
//
- // rebuild resource HOB for PEI memmory and reserved memory
+ // rebuild resource HOB for PEI memory and reserved memory
//
BuildResourceDescriptorHob (
EFI_RESOURCE_SYSTEM_MEMORY,
@@ -604,7 +604,7 @@ PeiLoadFixAddressHook(
);
}
//
- // Delete CurrentHob by marking it as unused since the the memory range described by is rebuilt.
+ // Delete CurrentHob by marking it as unused since the memory range described by is rebuilt.
//
GET_HOB_TYPE (CurrentHob) = EFI_HOB_TYPE_UNUSED;
}
@@ -750,8 +750,8 @@ PeiCheckAndSwitchStack (
ASSERT (NewStackSize >= SecCoreData->StackSize);
//
- // Calculate stack offset and heap offset between temporary memory and new permement
- // memory seperately.
+ // Calculate stack offset and heap offset between temporary memory and new permanent
+ // memory separately.
//
TopOfOldStack = (UINTN)SecCoreData->StackBase + SecCoreData->StackSize;
TopOfNewStack = Private->PhysicalMemoryBegin + NewStackSize;
@@ -1045,7 +1045,7 @@ PeiDispatcher (
// pass of the dispatcher, it will start over from the Bfv again to see
// if any new PEIMs dependencies got satisfied. With a well ordered
// FV where PEIMs are found in the order their dependencies are also
- // satisfied, this dipatcher should run only once.
+ // satisfied, this dispatcher should run only once.
//
do {
//
@@ -1229,7 +1229,7 @@ PeiDispatcher (
//
// Before walking through the next FV, we should set them to NULL/0 to
- // start at the begining of the next FV.
+ // start at the beginning of the next FV.
//
Private->CurrentFileHandle = NULL;
Private->CurrentPeimCount = 0;
@@ -1259,7 +1259,7 @@ PeiDispatcher (
@param PrivateData PeiCore's private data structure
@param OldCoreData Old data from SecCore
- NULL if being run in non-permament memory mode.
+ NULL if being run in non-permanent memory mode.
@param SecCoreData Points to a data structure containing information about the PEI core's operating
environment, such as the size and location of temporary RAM, the stack location and
the BFV location.
diff --git a/MdeModulePkg/Core/Pei/FwVol/FwVol.c b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
index f4642c47c13a..c105a14a1fb0 100644
--- a/MdeModulePkg/Core/Pei/FwVol/FwVol.c
+++ b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
@@ -178,7 +178,7 @@ CalculateHeaderChecksum (
if (IS_FFS_FILE2 (FileHeader)) {
CopyMem (&TestFileHeader, FileHeader, sizeof (EFI_FFS_FILE_HEADER2));
//
- // Ingore State and File field in FFS header.
+ // Ignore State and File field in FFS header.
//
TestFileHeader.State = 0;
TestFileHeader.IntegrityCheck.Checksum.File = 0;
@@ -187,7 +187,7 @@ CalculateHeaderChecksum (
} else {
CopyMem (&TestFileHeader, FileHeader, sizeof (EFI_FFS_FILE_HEADER));
//
- // Ingore State and File field in FFS header.
+ // Ignore State and File field in FFS header.
//
TestFileHeader.State = 0;
TestFileHeader.IntegrityCheck.Checksum.File = 0;
@@ -528,7 +528,7 @@ PeiInitializeFv (
}
/**
- Process Firmware Volum Information once FvInfoPPI or FvInfo2PPI install.
+ Process Firmware Volume Information once FvInfoPPI or FvInfo2PPI install.
The FV Info will be registered into PeiCore private data structure.
And search the inside FV image, if found, the new FV INFO(2) PPI will be installed.
@@ -537,7 +537,7 @@ PeiInitializeFv (
@param Ppi Address of the PPI that was installed.
@retval EFI_SUCCESS The FV Info is registered into PeiCore private data structure.
- @return if not EFI_SUCESS, fail to verify FV.
+ @return if not EFI_SUCCESS, fail to verify FV.
**/
EFI_STATUS
diff --git a/MdeModulePkg/Core/Pei/Hob/Hob.c b/MdeModulePkg/Core/Pei/Hob/Hob.c
index 5900f6042b60..20e022796e5f 100644
--- a/MdeModulePkg/Core/Pei/Hob/Hob.c
+++ b/MdeModulePkg/Core/Pei/Hob/Hob.c
@@ -1,5 +1,5 @@
/** @file
- This module provide Hand-Off Block manupulation.
+ This module provide Hand-Off Block manipulation.
Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
diff --git a/MdeModulePkg/Core/Pei/Image/Image.c b/MdeModulePkg/Core/Pei/Image/Image.c
index d553d9128fdd..0db15acf7171 100644
--- a/MdeModulePkg/Core/Pei/Image/Image.c
+++ b/MdeModulePkg/Core/Pei/Image/Image.c
@@ -99,7 +99,7 @@ CheckAndMarkFixLoadingMemoryUsageBitMap (
}
//
- // Test if the memory is avalaible or not.
+ // Test if the memory is available or not.
//
MemoryUsageBitMap = Private->PeiCodeMemoryRangeUsageBitMap;
BaseOffsetPageNumber = EFI_SIZE_TO_PAGES((UINT32)(ImageBase - PeiCodeBase));
@@ -290,7 +290,7 @@ LoadAndRelocatePeCoffImage (
}
//
- // Initilize local IsS3Boot and IsRegisterForShadow variable
+ // Initialize local IsS3Boot and IsRegisterForShadow variable
//
IsS3Boot = FALSE;
if (Private->HobList.HandoffInformationTable->BootMode == BOOT_ON_S3_RESUME) {
@@ -363,7 +363,7 @@ LoadAndRelocatePeCoffImage (
if (EFI_ERROR (Status)){
DEBUG ((EFI_D_INFO|EFI_D_LOAD, "LOADING MODULE FIXED ERROR: Failed to load module at fixed address. \n"));
//
- // The PEIM is not assiged valid address, try to allocate page to load it.
+ // The PEIM is not assigned valid address, try to allocate page to load it.
//
Status = PeiServicesAllocatePages (EfiBootServicesCode,
EFI_SIZE_TO_PAGES ((UINT32) AlignImageSize),
@@ -602,7 +602,7 @@ PeiLoadImageLoadImage (
//
// Copy the PDB file name to our temporary string, and replace .pdb with .efi
// The PDB file name is limited in the range of 0~511.
- // If the length is bigger than 511, trim the redudant characters to avoid overflow in array boundary.
+ // If the length is bigger than 511, trim the redundant characters to avoid overflow in array boundary.
//
for (Index = 0; Index < sizeof (EfiFileName) - 4; Index++) {
EfiFileName[Index] = AsciiString[Index + StartIndex];
diff --git a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
index 706837890fde..549047fc9466 100644
--- a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
+++ b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
@@ -17,7 +17,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
environment, such as the size and location of temporary RAM, the stack location and
the BFV location.
@param OldCoreData Pointer to the PEI Core data.
- NULL if being run in non-permament memory mode.
+ NULL if being run in non-permanent memory mode.
**/
VOID
@@ -61,7 +61,7 @@ InitializeMemoryServices (
The usage model is that the PEIM that discovers the permanent memory shall invoke this service.
This routine will hold discoveried memory information into PeiCore's private data,
and set SwitchStackSignal flag. After PEIM who discovery memory is dispatched,
- PeiDispatcher will migrate temporary memory to permenement memory.
+ PeiDispatcher will migrate temporary memory to permanent memory.
@param PeiServices An indirect pointer to the EFI_PEI_SERVICES table published by the PEI Foundation.
@param MemoryBegin Start of memory address.
@@ -86,7 +86,7 @@ PeiInstallPeiMemory (
//
// PEI_SERVICE.InstallPeiMemory should only be called one time during whole PEI phase.
// If it is invoked more than one time, ASSERT information is given for developer debugging in debug tip and
- // simply return EFI_SUCESS in release tip to ignore it.
+ // simply return EFI_SUCCESS in release tip to ignore it.
//
if (PrivateData->PeiMemoryInstalled) {
DEBUG ((EFI_D_ERROR, "ERROR: PeiInstallPeiMemory is called more than once!\n"));
@@ -759,7 +759,7 @@ PeiFreePages (
/**
Pool allocation service. Before permanent memory is discoveried, the pool will
- be allocated the heap in the temporary memory. Genenrally, the size of heap in temporary
+ be allocated the heap in the temporary memory. Generally, the size of heap in temporary
memory does not exceed to 64K, so the biggest pool size could be allocated is
64K.
@@ -790,7 +790,7 @@ PeiAllocatePool (
//
// Generally, the size of heap in temporary memory does not exceed to 64K,
- // HobLength is multiples of 8 bytes, so the maxmium size of pool is 0xFFF8 - sizeof (EFI_HOB_MEMORY_POOL)
+ // HobLength is multiples of 8 bytes, so the maximum size of pool is 0xFFF8 - sizeof (EFI_HOB_MEMORY_POOL)
//
if (Size > (0xFFF8 - sizeof (EFI_HOB_MEMORY_POOL))) {
return EFI_OUT_OF_RESOURCES;
diff --git a/MdeModulePkg/Core/Pei/PeiMain/PeiMain.c b/MdeModulePkg/Core/Pei/PeiMain/PeiMain.c
index 33f056ea8f5d..cca57c4c0686 100644
--- a/MdeModulePkg/Core/Pei/PeiMain/PeiMain.c
+++ b/MdeModulePkg/Core/Pei/PeiMain/PeiMain.c
@@ -132,7 +132,7 @@ ShadowPeiCore (
ASSERT_EFI_ERROR (Status);
//
- // Compute the PeiCore's function address after shaowed PeiCore.
+ // Compute the PeiCore's function address after shadowed PeiCore.
// _ModuleEntryPoint is PeiCore main function entry
//
return (PEICORE_FUNCTION_POINTER)((UINTN) EntryPoint + (UINTN) PeiCore - (UINTN) _ModuleEntryPoint);
@@ -315,7 +315,7 @@ PeiCore (
}
//
- // Shadow PEI Core. When permanent memory is avaiable, shadow
+ // Shadow PEI Core. When permanent memory is available, shadow
// PEI Core and PEIMs to get high performance.
//
OldCoreData->ShadowedPeiCore = (PEICORE_FUNCTION_POINTER) (UINTN) PeiCore;
diff --git a/MdeModulePkg/Core/Pei/Ppi/Ppi.c b/MdeModulePkg/Core/Pei/Ppi/Ppi.c
index 964aee690e27..e3220266f0b2 100644
--- a/MdeModulePkg/Core/Pei/Ppi/Ppi.c
+++ b/MdeModulePkg/Core/Pei/Ppi/Ppi.c
@@ -663,7 +663,7 @@ ProcessDispatchNotifyList (
//
// Check if the PEIM that was just dispatched resulted in any
// Notifies getting installed. If so, go process any dispatch
- // level Notifies that match the previouly installed PPIs.
+ // level Notifies that match the previously installed PPIs.
// Use "while" instead of "if" since ProcessNotify can modify
// DispatchNotifyList.CurrentCount (with NotifyPpi) so we have
// to iterate until the same.
diff --git a/MdeModulePkg/Core/Pei/Security/Security.c b/MdeModulePkg/Core/Pei/Security/Security.c
index 99da505538fa..32bc292b15c4 100644
--- a/MdeModulePkg/Core/Pei/Security/Security.c
+++ b/MdeModulePkg/Core/Pei/Security/Security.c
@@ -20,7 +20,7 @@ EFI_PEI_NOTIFY_DESCRIPTOR mNotifyList = {
@param PeiServices An indirect pointer to the EFI_PEI_SERVICES table published by the PEI Foundation.
@param OldCoreData Pointer to the old core data.
- NULL if being run in non-permament memory mode.
+ NULL if being run in non-permanent memory mode.
**/
VOID
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* [PATCH 19/79] MdeModulePkg/Core/PiSmmCore: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (17 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 18/79] MdeModulePkg/Core/Pei: " Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-03 16:15 ` [PATCH 20/79] MdeModulePkg/UsbBusDxe: Fix a typo Philippe Mathieu-Daudé
` (53 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Jian J Wang, Hao A Wu, Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf | 10 ++++----
MdeModulePkg/Core/PiSmmCore/HeapGuard.h | 2 +-
MdeModulePkg/Core/PiSmmCore/PiSmmCore.h | 12 +++++-----
MdeModulePkg/Core/PiSmmCore/PiSmmCorePrivateData.h | 6 ++---
MdeModulePkg/Core/PiSmmCore/Dependency.c | 4 ++--
MdeModulePkg/Core/PiSmmCore/Dispatcher.c | 24 ++++++++++----------
MdeModulePkg/Core/PiSmmCore/HeapGuard.c | 4 ++--
MdeModulePkg/Core/PiSmmCore/Locate.c | 8 +++----
MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c | 8 +++----
MdeModulePkg/Core/PiSmmCore/Page.c | 4 ++--
MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 10 ++++----
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 8 +++----
MdeModulePkg/Core/PiSmmCore/Smi.c | 2 +-
MdeModulePkg/Core/PiSmmCore/SmramProfileRecord.c | 4 ++--
14 files changed, 53 insertions(+), 53 deletions(-)
diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf
index b6b1bbcdac51..619603d6c2a0 100644
--- a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf
+++ b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf
@@ -57,23 +57,23 @@ [Protocols]
gEfiSmmControl2ProtocolGuid ## CONSUMES
## NOTIFY
## SOMETIMES_CONSUMES
- ## UNDEFINED # Used to do smm communcation
+ ## UNDEFINED # Used to do smm communication
gEfiDxeSmmReadyToLockProtocolGuid
gEfiCpuArchProtocolGuid ## SOMETIMES_CONSUMES
[Guids]
## CONSUMES ## Event
- ## PRODUCES ## UNDEFINED # Used to do smm communcation
+ ## PRODUCES ## UNDEFINED # Used to do smm communication
gEfiEventDxeDispatchGuid
gEfiEventReadyToBootGuid ## CONSUMES ## Event
## SOMETIMES_CONSUMES ## Event
- ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm communcation
+ ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm communication
gEfiEventLegacyBootGuid
## SOMETIMES_CONSUMES ## Event
- ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm communcation
+ ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm communication
gEfiEventExitBootServicesGuid
## SOMETIMES_CONSUMES ## Event
- ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm communcation
+ ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm communication
gEfiEventReadyToBootGuid
gEfiEventVirtualAddressChangeGuid ## CONSUMES ## Event
gEfiEndOfDxeEventGroupGuid ## CONSUMES ## Event
diff --git a/MdeModulePkg/Core/PiSmmCore/HeapGuard.h b/MdeModulePkg/Core/PiSmmCore/HeapGuard.h
index 9077db1a8496..1b5c0f2a4f57 100644
--- a/MdeModulePkg/Core/PiSmmCore/HeapGuard.h
+++ b/MdeModulePkg/Core/PiSmmCore/HeapGuard.h
@@ -39,7 +39,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
//
// For a normal configuration of system with 4G memory, two levels of tables
// can track the whole memory, because two levels (L3+L4) of map tables have
-// already coverred 37-bit of memory address. And for a normal UEFI BIOS,
+// already covered 37-bit of memory address. And for a normal UEFI BIOS,
// less than 128M memory would be consumed during boot. That means we just
// need
//
diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h
index 0908e7f4e9e7..50a7fc0000cb 100644
--- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h
+++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h
@@ -171,7 +171,7 @@ typedef struct {
EFI_GUID ProtocolID;
/// All protocol interfaces
LIST_ENTRY Protocols;
- /// Registerd notification handlers
+ /// Registered notification handlers
LIST_ENTRY Notify;
} PROTOCOL_ENTRY;
@@ -562,7 +562,7 @@ SmmLocateHandle (
/**
Return the first Protocol Interface that matches the Protocol GUID. If
Registration is pasased in return a Protocol Instance that was just add
- to the system. If Retistration is NULL return the first Protocol Interface
+ to the system. If Registration is NULL return the first Protocol Interface
you find.
@param Protocol The protocol to search for
@@ -602,7 +602,7 @@ SmmLocateProtocol (
@retval EFI_NOT_FOUND No handles match the search.
@retval EFI_OUT_OF_RESOURCES There is not enough pool memory to store the
matching results.
- @retval EFI_INVALID_PARAMETER One or more paramters are not valid.
+ @retval EFI_INVALID_PARAMETER One or more parameters are not valid.
**/
EFI_STATUS
@@ -641,7 +641,7 @@ SmiManage (
/**
Registers a handler to execute within SMM.
- @param Handler Handler service funtion pointer.
+ @param Handler Handler service function pointer.
@param HandlerType Points to the handler type or NULL for root SMI handlers.
@param DispatchHandle On return, contains a unique handle which can be used to later unregister the handler function.
@@ -873,12 +873,12 @@ SmmEfiNotAvailableYetArg5 (
);
//
-//Functions used during debug buils
+//Functions used during debug builds
//
/**
Traverse the discovered list for any drivers that were discovered but not loaded
- because the dependency experessions evaluated to false.
+ because the dependency expressions evaluated to false.
**/
VOID
diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCorePrivateData.h b/MdeModulePkg/Core/PiSmmCore/PiSmmCorePrivateData.h
index 1d8af6f12767..28f95d9b024b 100644
--- a/MdeModulePkg/Core/PiSmmCore/PiSmmCorePrivateData.h
+++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCorePrivateData.h
@@ -65,7 +65,7 @@ typedef struct {
///
/// The SMM Foundation Entry Point. The SMM Core fills in this field when the
- /// SMM Core is initialized. The SMM IPL is responsbile for registering this entry
+ /// SMM Core is initialized. The SMM IPL is responsible for registering this entry
/// point with the SMM Configuration Protocol. The SMM Configuration Protocol may
/// not be available at the time the SMM IPL and SMM Core are started, so the SMM IPL
/// sets up a protocol notification on the SMM Configuration Protocol and registers
@@ -92,14 +92,14 @@ typedef struct {
EFI_SMM_SYSTEM_TABLE2 *Smst;
///
- /// This field is used by the SMM Communicatioon Protocol to pass a buffer into
+ /// This field is used by the SMM Communication Protocol to pass a buffer into
/// a software SMI handler and for the software SMI handler to pass a buffer back to
/// the caller of the SMM Communication Protocol.
///
VOID *CommunicationBuffer;
///
- /// This field is used by the SMM Communicatioon Protocol to pass the size of a buffer,
+ /// This field is used by the SMM Communication Protocol to pass the size of a buffer,
/// in bytes, into a software SMI handler and for the software SMI handler to pass the
/// size, in bytes, of a buffer back to the caller of the SMM Communication Protocol.
///
diff --git a/MdeModulePkg/Core/PiSmmCore/Dependency.c b/MdeModulePkg/Core/PiSmmCore/Dependency.c
index dfd4537f846a..1167807b151b 100644
--- a/MdeModulePkg/Core/PiSmmCore/Dependency.c
+++ b/MdeModulePkg/Core/PiSmmCore/Dependency.c
@@ -192,7 +192,7 @@ SmmIsSchedulable (
if (DriverEntry->Depex == NULL) {
//
// A NULL Depex means that the SMM driver is not built correctly.
- // All SMM drivers must have a valid depex expressiion.
+ // All SMM drivers must have a valid depex expression.
//
DEBUG ((DEBUG_DISPATCH, " RESULT = FALSE (Depex is empty)\n"));
ASSERT (FALSE);
@@ -371,7 +371,7 @@ SmmIsSchedulable (
// The math is done out of order, but it should not matter. That is
// we may add in the sizeof (EFI_GUID) before we account for the OP Code.
// This is not an issue, since we just need the correct end result. You
- // need to be careful using Iterator in the loop as it's intermediate value
+ // need to be careful using Iterator in the loop as its intermediate value
// may be strange.
//
Iterator++;
diff --git a/MdeModulePkg/Core/PiSmmCore/Dispatcher.c b/MdeModulePkg/Core/PiSmmCore/Dispatcher.c
index e5a160ed0b92..9bec731e5312 100644
--- a/MdeModulePkg/Core/PiSmmCore/Dispatcher.c
+++ b/MdeModulePkg/Core/PiSmmCore/Dispatcher.c
@@ -17,7 +17,7 @@
and After dependencies. This is done recursively as the call to add
to the mScheduledQueue checks for Before and recursively adds
all Befores. It then addes the item that was passed in and then
- processess the After dependecies by recursively calling the routine.
+ processes the After dependencies by recursively calling the routine.
Dispatcher Rules:
The rules for the dispatcher are similar to the DXE dispatcher.
@@ -25,7 +25,7 @@
The rules for DXE dispatcher are in chapter 10 of the DXE CIS. Figure 10-3
is the state diagram for the DXE dispatcher
- Depex - Dependency Expresion.
+ Depex - Dependency Expression.
Copyright (c) 2014, Hewlett-Packard Development Company, L.P.
Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
@@ -83,12 +83,12 @@ LIST_ENTRY mScheduledQueue = INITIALIZE_LIST_HEAD_VARIABLE (mScheduledQueue);
LIST_ENTRY mFvHandleList = INITIALIZE_LIST_HEAD_VARIABLE (mFvHandleList);
//
-// Flag for the SMM Dispacher. TRUE if dispatcher is execuing.
+// Flag for the SMM Dispatcher. TRUE if dispatcher is executing.
//
BOOLEAN gDispatcherRunning = FALSE;
//
-// Flag for the SMM Dispacher. TRUE if there is one or more SMM drivers ready to be dispatched
+// Flag for the SMM Dispatcher. TRUE if there is one or more SMM drivers ready to be dispatched
//
BOOLEAN gRequestDispatch = FALSE;
@@ -175,7 +175,7 @@ CheckAndMarkFixLoadingMemoryUsageBitMap (
return EFI_NOT_FOUND;
}
//
- // Test if the memory is avalaible or not.
+ // Test if the memory is available or not.
//
BaseOffsetPageNumber = EFI_SIZE_TO_PAGES((UINT32)(ImageBase - SmmCodeBase));
TopOffsetPageNumber = EFI_SIZE_TO_PAGES((UINT32)(ImageBase + ImageSize - SmmCodeBase));
@@ -458,7 +458,7 @@ SmmLoadImage (
Status = GetPeCoffImageFixLoadingAssignedAddress (&ImageContext);
if (!EFI_ERROR (Status)) {
//
- // Since the memory range to load Smm core alreay been cut out, so no need to allocate and free this range
+ // Since the memory range to load Smm core already been cut out, so no need to allocate and free this range
// following statements is to bypass SmmFreePages
//
PageCount = 0;
@@ -664,7 +664,7 @@ SmmLoadImage (
//
// Copy the PDB file name to our temporary string, and replace .pdb with .efi
// The PDB file name is limited in the range of 0~255.
- // If the length is bigger than 255, trim the redudant characters to avoid overflow in array boundary.
+ // If the length is bigger than 255, trim the redundant characters to avoid overflow in array boundary.
//
for (Index = 0; Index < sizeof (EfiFileName) - 4; Index++) {
EfiFileName[Index] = ImageContext.PdbPointer[Index + StartIndex];
@@ -741,7 +741,7 @@ SmmPreProcessDepex (
@param DriverEntry Driver to work on.
- @retval EFI_SUCCESS Depex read and preprossesed
+ @retval EFI_SUCCESS Depex read and preprocessed
@retval EFI_PROTOCOL_ERROR The section extraction protocol returned an error
and Depex reading needs to be retried.
@retval Error DEPEX not found.
@@ -1093,8 +1093,8 @@ FvHasBeenProcessed (
}
/**
- Remember that Fv protocol on FvHandle has had it's drivers placed on the
- mDiscoveredList. This fucntion adds entries on the mFvHandleList. Items are
+ Remember that Fv protocol on FvHandle has had its drivers placed on the
+ mDiscoveredList. This function adds entries on the mFvHandleList. Items are
never removed/freed from the mFvHandleList.
@param FvHandle The handle of a FV that has been processed
@@ -1165,7 +1165,7 @@ SmmFvToDevicePath (
/**
Add an entry to the mDiscoveredList. Allocate memory to store the DriverEntry,
- and initilize any state variables. Read the Depex from the FV and store it
+ and initialize any state variables. Read the Depex from the FV and store it
in DriverEntry. Pre-process the Depex to set the Before and After state.
The Discovered list is never free'ed and contains booleans that represent the
other possible SMM driver states.
@@ -1473,7 +1473,7 @@ SmmDriverDispatchHandler (
/**
Traverse the discovered list for any drivers that were discovered but not loaded
- because the dependency experessions evaluated to false.
+ because the dependency expressions evaluated to false.
**/
VOID
diff --git a/MdeModulePkg/Core/PiSmmCore/HeapGuard.c b/MdeModulePkg/Core/PiSmmCore/HeapGuard.c
index 29cd00f3897d..b0d0f72044a3 100644
--- a/MdeModulePkg/Core/PiSmmCore/HeapGuard.c
+++ b/MdeModulePkg/Core/PiSmmCore/HeapGuard.c
@@ -497,7 +497,7 @@ IsMemoryGuarded (
/**
Set the page at the given address to be a Guard page.
- This is done by changing the page table attribute to be NOT PRSENT.
+ This is done by changing the page table attribute to be NOT PRESENT.
@param[in] BaseAddress Page address to Guard at.
@@ -527,7 +527,7 @@ SetGuardPage (
/**
Unset the Guard page at the given address to the normal memory.
- This is done by changing the page table attribute to be PRSENT.
+ This is done by changing the page table attribute to be PRESENT.
@param[in] BaseAddress Page address to Guard at.
diff --git a/MdeModulePkg/Core/PiSmmCore/Locate.c b/MdeModulePkg/Core/PiSmmCore/Locate.c
index 85c6873fafe2..8458199ec86c 100644
--- a/MdeModulePkg/Core/PiSmmCore/Locate.c
+++ b/MdeModulePkg/Core/PiSmmCore/Locate.c
@@ -34,7 +34,7 @@ IHANDLE *
/**
Routine to get the next Handle, when you are searching for all handles.
- @param Position Information about which Handle to seach for.
+ @param Position Information about which Handle to search for.
@param Interface Return the interface structure for the matching
protocol.
@@ -70,7 +70,7 @@ SmmGetNextLocateAllHandles (
Routine to get the next Handle, when you are searching for register protocol
notifies.
- @param Position Information about which Handle to seach for.
+ @param Position Information about which Handle to search for.
@param Interface Return the interface structure for the matching
protocol.
@@ -116,7 +116,7 @@ SmmGetNextLocateByRegisterNotify (
/**
Routine to get the next Handle, when you are searching for a given protocol.
- @param Position Information about which Handle to seach for.
+ @param Position Information about which Handle to search for.
@param Interface Return the interface structure for the matching
protocol.
@@ -173,7 +173,7 @@ SmmGetNextLocateByProtocol (
/**
Return the first Protocol Interface that matches the Protocol GUID. If
Registration is pasased in return a Protocol Instance that was just add
- to the system. If Retistration is NULL return the first Protocol Interface
+ to the system. If Registration is NULL return the first Protocol Interface
you find.
@param Protocol The protocol to search for
diff --git a/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c b/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
index d6123da3ad1a..de8262ecb9f9 100644
--- a/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
+++ b/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
@@ -152,7 +152,7 @@ SortMemoryMap (
}
/**
- Merge continous memory map entries whose have same attributes.
+ Merge continuous memory map entries whose have same attributes.
@param[in, out] MemoryMap A pointer to the buffer in which firmware places
the current memory map.
@@ -300,7 +300,7 @@ GetImageRecordByAddress (
@param[in] ImageRecord An image record whose [ImageBase, ImageSize] covered
by old memory map entry.
@param[in, out] NewRecord A pointer to several new memory map entries.
- The caller gurantee the buffer size be 1 +
+ The caller guarantee the buffer size be 1 +
(SplitRecordCount * DescriptorSize) calculated
below.
@param[in] OldRecord A pointer to one old memory map entry.
@@ -450,7 +450,7 @@ GetMaxSplitRecordCount (
@param[in] OldRecord A pointer to one old memory map entry.
@param[in, out] NewRecord A pointer to several new memory map entries.
- The caller gurantee the buffer size be 1 +
+ The caller guarantee the buffer size be 1 +
(SplitRecordCount * DescriptorSize) calculated
below.
@param[in] MaxSplitRecordCount The max number of splitted entries
@@ -667,7 +667,7 @@ SplitTable (
This function for GetMemoryMap() with memory attributes table.
It calls original GetMemoryMap() to get the original memory map information. Then
- plus the additional memory map entries for PE Code/Data seperation.
+ plus the additional memory map entries for PE Code/Data separation.
@param[in, out] MemoryMapSize A pointer to the size, in bytes, of the
MemoryMap buffer. On input, this is the size of
diff --git a/MdeModulePkg/Core/PiSmmCore/Page.c b/MdeModulePkg/Core/PiSmmCore/Page.c
index 1f05bddcc0b8..d886187d9a4a 100644
--- a/MdeModulePkg/Core/PiSmmCore/Page.c
+++ b/MdeModulePkg/Core/PiSmmCore/Page.c
@@ -83,7 +83,7 @@ SmmInternalAllocatePagesEx (
Please Note this algorithm to allocate the memory map descriptor has a property
that the memory allocated for memory entries always grows, and will never really be freed.
- @return The Memory map descriptor dequed from the mFreeMemoryMapEntryList
+ @return The Memory map descriptor dequeued from the mFreeMemoryMapEntryList
**/
MEMORY_MAP *
@@ -117,7 +117,7 @@ AllocateMemoryMapEntry (
FreeDescriptorEntries = (MEMORY_MAP *)(UINTN)Mem;
//DEBUG((DEBUG_INFO, "New FreeDescriptorEntries - 0x%x\n", FreeDescriptorEntries));
//
- // Enque the free memmory map entries into the list
+ // Enqueue the free memory map entries into the list
//
for (Index = 0; Index< RUNTIME_PAGE_ALLOCATION_GRANULARITY / sizeof(MEMORY_MAP); Index++) {
FreeDescriptorEntries[Index].Signature = MEMORY_MAP_SIGNATURE;
diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
index b5676f21bf26..cfa9922cbdb5 100644
--- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
+++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
@@ -373,7 +373,7 @@ SmmReadyToLockHandler (
);
//
- // Make sure SMM CPU I/O 2 Procol has been installed into the handle database
+ // Make sure SMM CPU I/O 2 Protocol has been installed into the handle database
//
Status = SmmLocateProtocol (&gEfiSmmCpuIo2ProtocolGuid, NULL, &Interface);
@@ -586,7 +586,7 @@ SmmEndOfS3ResumeHandler (
ASSERT_EFI_ERROR (Status);
//
- // Uninstall the protocol here because the comsumer just hook the
+ // Uninstall the protocol here because the consumer just hook the
// installation event.
//
Status = SmmUninstallProtocolInterface (
@@ -673,7 +673,7 @@ SmmEntryPoint (
SmmEntryPointMemoryManagementHook ();
//
- // If a legacy boot has occured, then make sure gSmmCorePrivate is not accessed
+ // If a legacy boot has occurred, then make sure gSmmCorePrivate is not accessed
//
InLegacyBoot = mInLegacyBoot;
if (!InLegacyBoot) {
@@ -737,7 +737,7 @@ SmmEntryPoint (
PlatformHookAfterSmmDispatch ();
//
- // If a legacy boot has occured, then make sure gSmmCorePrivate is not accessed
+ // If a legacy boot has occurred, then make sure gSmmCorePrivate is not accessed
//
if (!InLegacyBoot) {
//
@@ -867,7 +867,7 @@ SmmMain (
//
// No need to initialize memory service.
// It is done in constructor of PiSmmCoreMemoryAllocationLib(),
- // so that the library linked with PiSmmCore can use AllocatePool() in constuctor.
+ // so that the library linked with PiSmmCore can use AllocatePool() in constructor.
//
SmramProfileInit ();
diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
index 1cf8c93227a3..20b84eaee277 100644
--- a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
+++ b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
@@ -707,7 +707,7 @@ SmmIplSmmConfigurationEventNotify (
}
//
- // Register the SMM Entry Point provided by the SMM Core with the SMM COnfiguration protocol
+ // Register the SMM Entry Point provided by the SMM Core with the SMM Configuration protocol
//
Status = SmmConfiguration->RegisterSmmEntry (SmmConfiguration, gSmmCorePrivate->SmmEntryPoint);
ASSERT_EFI_ERROR (Status);
@@ -964,7 +964,7 @@ ExecuteSmmCoreFromSmram (
}
//
- // Initilize ImageContext
+ // Initialize ImageContext
//
ImageContext.Handle = SourceBuffer;
ImageContext.ImageRead = PeCoffLoaderImageReadFromMemory;
@@ -1082,7 +1082,7 @@ ExecuteSmmCoreFromSmram (
}
//
- // Always free memory allocted by GetFileBufferByFilePath ()
+ // Always free memory allocated by GetFileBufferByFilePath ()
//
FreePool (SourceBuffer);
@@ -1763,7 +1763,7 @@ SmmIplEntry (
ASSERT_EFI_ERROR (Status);
//
- // Create the set of protocol and event notififcations that the SMM IPL requires
+ // Create the set of protocol and event notifications that the SMM IPL requires
//
for (Index = 0; mSmmIplEvents[Index].NotifyFunction != NULL; Index++) {
if (mSmmIplEvents[Index].Protocol) {
diff --git a/MdeModulePkg/Core/PiSmmCore/Smi.c b/MdeModulePkg/Core/PiSmmCore/Smi.c
index 488af6754faf..aeefb392f7af 100644
--- a/MdeModulePkg/Core/PiSmmCore/Smi.c
+++ b/MdeModulePkg/Core/PiSmmCore/Smi.c
@@ -196,7 +196,7 @@ SmiManage (
/**
Registers a handler to execute within SMM.
- @param Handler Handler service funtion pointer.
+ @param Handler Handler service function pointer.
@param HandlerType Points to the handler type or NULL for root SMI handlers.
@param DispatchHandle On return, contains a unique handle which can be used to later unregister the handler function.
diff --git a/MdeModulePkg/Core/PiSmmCore/SmramProfileRecord.c b/MdeModulePkg/Core/PiSmmCore/SmramProfileRecord.c
index 49c4a3758fdd..1b302c810cc9 100644
--- a/MdeModulePkg/Core/PiSmmCore/SmramProfileRecord.c
+++ b/MdeModulePkg/Core/PiSmmCore/SmramProfileRecord.c
@@ -78,7 +78,7 @@ GLOBAL_REMOVE_IF_UNREFERENCED EFI_DEVICE_PATH_PROTOCOL *mSmramProfileDriverPath;
GLOBAL_REMOVE_IF_UNREFERENCED UINTN mSmramProfileDriverPathSize;
/**
- Dump SMRAM infromation.
+ Dump SMRAM information.
**/
VOID
@@ -2797,7 +2797,7 @@ DumpSmramProfile (
}
/**
- Dump SMRAM infromation.
+ Dump SMRAM information.
**/
VOID
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* [PATCH 20/79] MdeModulePkg/UsbBusDxe: Fix a typo
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (18 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 19/79] MdeModulePkg/Core/PiSmmCore: " Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-03 16:15 ` [PATCH 21/79] MdeModulePkg/UsbMass: Fix various typos Philippe Mathieu-Daudé
` (52 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel
Cc: Philippe Mathieu-Daude, Antoine Cœur, Jian J Wang, Hao A Wu,
Ray Ni
Correctly write 'malformatted'.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c
index a64f33fde67a..008a592859aa 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c
+++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c
@@ -398,7 +398,7 @@ UsbParseConfigDesc (
break;
} else if (Setting->Desc.InterfaceNumber >= NumIf) {
- DEBUG (( EFI_D_ERROR, "UsbParseConfigDesc: mal-formated interface descriptor\n"));
+ DEBUG (( EFI_D_ERROR, "UsbParseConfigDesc: malformatted interface descriptor\n"));
UsbFreeInterfaceDesc (Setting);
goto ON_ERROR;
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* [PATCH 21/79] MdeModulePkg/UsbMass: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (19 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 20/79] MdeModulePkg/UsbBusDxe: Fix a typo Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-03 16:15 ` [PATCH 22/79] MdeModulePkg/UsbMouse: Fix few typos Philippe Mathieu-Daudé
` (51 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Jian J Wang, Hao A Wu, Ray Ni,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h | 4 ++--
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.h | 4 ++--
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.h | 2 +-
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.h | 2 +-
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c | 4 ++--
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.c | 4 ++--
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.c | 4 ++--
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c | 4 ++--
8 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h
index 2b89c92724a8..f34a41284e4c 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h
@@ -77,7 +77,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
// Mass command timeout, refers to specification[USB20-9.2.6.1]
//
// USB2.0 Spec define the up-limit timeout 5s for all command. USB floppy,
-// USB CD-Rom and iPod devices are much slower than USB key when reponse
+// USB CD-Rom and iPod devices are much slower than USB key when response
// most of commands, So we set 5s as timeout here.
//
#define USB_BOOT_GENERAL_CMD_TIMEOUT (5 * USB_MASS_1_SECOND)
@@ -213,7 +213,7 @@ typedef struct {
This function get the parameters for the USB mass storage media,
It is used both to initialize the media during the Start() phase
of Driver Binding Protocol and to re-initialize it when the media is
- changed. Althought the RemoveableMedia is unlikely to change,
+ changed. Although the RemoveableMedia is unlikely to change,
it is also included here.
@param UsbMass The device to retrieve disk gemotric.
diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.h b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.h
index ea03cf7e2fd4..3ef8f240a2c1 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.h
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.h
@@ -14,14 +14,14 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
extern USB_MASS_TRANSPORT mUsbBotTransport;
//
-// Usb Bulk-Only class specfic request
+// Usb Bulk-Only class specific request
//
#define USB_BOT_RESET_REQUEST 0xFF ///< Bulk-Only Mass Storage Reset
#define USB_BOT_GETLUN_REQUEST 0xFE ///< Get Max Lun
#define USB_BOT_CBW_SIGNATURE 0x43425355 ///< dCBWSignature, tag the packet as CBW
#define USB_BOT_CSW_SIGNATURE 0x53425355 ///< dCSWSignature, tag the packet as CSW
#define USB_BOT_MAX_LUN 0x0F ///< Lun number is from 0 to 15
-#define USB_BOT_MAX_CMDLEN 16 ///< Maxium number of command from command set
+#define USB_BOT_MAX_CMDLEN 16 ///< Maximum number of command from command set
//
// Usb BOT command block status values
diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.h b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.h
index 287c0330f61e..b79b9c243630 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.h
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.h
@@ -1,5 +1,5 @@
/** @file
- Defination for the USB mass storage Control/Bulk/Interrupt (CBI) transport,
+ Definition for the USB mass storage Control/Bulk/Interrupt (CBI) transport,
according to USB Mass Storage Class Control/Bulk/Interrupt (CBI) Transport, Revision 1.1.
Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.h b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.h
index 9f63deeae3db..283bed7055a0 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.h
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.h
@@ -48,7 +48,7 @@ USBMassDriverBindingSupported (
/**
Starts the USB mass storage device with this driver.
- This function consumes USB I/O Portocol, intializes USB mass storage device,
+ This function consumes USB I/O Protocol, initializes USB mass storage device,
installs Block I/O Protocol, and submits Asynchronous Interrupt
Transfer to manage the USB mass storage device.
diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c
index 600896b6a214..aab4061e183c 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c
@@ -197,7 +197,7 @@ UsbBootExecCmd (
//
// If ExecCommand() returns no error and CmdResult is success,
- // then the commnad transfer is successful.
+ // then the command transfer is successful.
//
if ((CmdResult == USB_MASS_CMD_SUCCESS) && !EFI_ERROR (Status)) {
return EFI_SUCCESS;
@@ -610,7 +610,7 @@ UsbScsiModeSense (
This function get the parameters for the USB mass storage media,
It is used both to initialize the media during the Start() phase
of Driver Binding Protocol and to re-initialize it when the media is
- changed. Althought the RemoveableMedia is unlikely to change,
+ changed. Although the RemoveableMedia is unlikely to change,
it is also included here.
@param UsbMass The device to retrieve disk gemotric.
diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.c b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.c
index 98d2ba99688b..1e878a1bdd1d 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.c
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.c
@@ -326,7 +326,7 @@ UsbBotGetStatus (
for (Index = 0; Index < USB_BOT_RECV_CSW_RETRY; Index++) {
//
- // Attemp to the read Command Status Wrapper from bulk in endpoint
+ // Attempt to the read Command Status Wrapper from bulk in endpoint
//
ZeroMem (&Csw, sizeof (USB_BOT_CSW));
Result = 0;
@@ -553,7 +553,7 @@ UsbBotGetMaxLun (
UsbBot = (USB_BOT_PROTOCOL *) Context;
//
- // Issue a class specific Bulk-Only Mass Storage get max lun reqest.
+ // Issue a class specific Bulk-Only Mass Storage get max lun request.
// according to section 3.2 of USB Mass Storage Class Bulk-Only Transport Spec, v1.0.
//
Request.RequestType = 0xA1;
diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.c b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.c
index 1e5508c75674..477f0536d673 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.c
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.c
@@ -305,7 +305,7 @@ UsbCbiDataTransfer (
if (TransStatus == EFI_USB_ERR_NAK) {
//
// The device can NAK the host if either the data/buffer isn't
- // aviable or the command is in-progress.
+ // available or the command is in-progress.
// If data are partially transferred, we just ignore NAK and continue.
// If all data have been transferred and status is NAK, then we retry for several times.
// If retry exceeds the USB_CBI_MAX_RETRY, then return error status.
@@ -378,7 +378,7 @@ UsbCbiGetStatus (
Timeout = Timeout / USB_MASS_1_MILLISECOND;
//
- // Attemp to the read the result from interrupt endpoint
+ // Attempt to the read the result from interrupt endpoint
//
for (Retry = 0; Retry < USB_CBI_MAX_RETRY; Retry++) {
TransStatus = 0;
diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c
index 0dcbc5da2cb8..bbd19e044748 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c
@@ -367,7 +367,7 @@ UsbMassInitMedia (
}
/**
- Initilize the USB Mass Storage transport.
+ Initialize the USB Mass Storage transport.
This function tries to find the matching USB Mass Storage transport
protocol for USB device. If found, initializes the matching transport.
@@ -770,7 +770,7 @@ ON_EXIT:
/**
Starts the USB mass storage device with this driver.
- This function consumes USB I/O Portocol, intializes USB mass storage device,
+ This function consumes USB I/O Protocol, initializes USB mass storage device,
installs Block I/O Protocol, and submits Asynchronous Interrupt
Transfer to manage the USB mass storage device.
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* [PATCH 22/79] MdeModulePkg/UsbMouse: Fix few typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (20 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 21/79] MdeModulePkg/UsbMass: Fix various typos Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-03 16:15 ` [PATCH 23/79] MdeModulePkg/UsbBus: Fix various typos Philippe Mathieu-Daudé
` (50 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Jian J Wang, Hao A Wu, Ray Ni,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix few typos in comments and documentation.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.h | 2 +-
MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.h | 2 +-
MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/MouseHid.c | 2 +-
MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c | 2 +-
MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c | 2 +-
MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.h b/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.h
index f7fe480d0762..c9edc45e38a4 100644
--- a/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.h
+++ b/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.h
@@ -138,7 +138,7 @@ USBMouseAbsolutePointerDriverBindingSupported (
/**
Starts the mouse device with this driver.
- This function consumes USB I/O Portocol, intializes USB mouse device,
+ This function consumes USB I/O Protocol, initializes USB mouse device,
installs Absolute Pointer Protocol, and submits Asynchronous Interrupt
Transfer to manage the USB mouse device.
diff --git a/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.h b/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.h
index b71ef829870a..f46069602f28 100644
--- a/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.h
+++ b/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.h
@@ -138,7 +138,7 @@ USBMouseDriverBindingSupported (
/**
Starts the mouse device with this driver.
- This function consumes USB I/O Portocol, intializes USB mouse device,
+ This function consumes USB I/O Protocol, initializes USB mouse device,
installs Simple Pointer Protocol, and submits Asynchronous Interrupt
Transfer to manage the USB mouse device.
diff --git a/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/MouseHid.c b/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/MouseHid.c
index d7805ad3de90..10e18e58ab45 100644
--- a/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/MouseHid.c
+++ b/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/MouseHid.c
@@ -22,7 +22,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
Only short item is supported here.
@param StartPos Start position of the HID item to get.
- @param EndPos End position of the range to get the the next HID item.
+ @param EndPos End position of the range to get the next HID item.
@param HidItem Buffer for the HID Item to return.
@return Pointer to end of the HID item returned.
diff --git a/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c b/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c
index 8953e7031cfc..83197bfd996f 100644
--- a/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c
+++ b/MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c
@@ -109,7 +109,7 @@ USBMouseAbsolutePointerDriverBindingSupported (
/**
Starts the mouse device with this driver.
- This function consumes USB I/O Portocol, intializes USB mouse device,
+ This function consumes USB I/O Protocol, initializes USB mouse device,
installs Absolute Pointer Protocol, and submits Asynchronous Interrupt
Transfer to manage the USB mouse device.
diff --git a/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c b/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c
index de44aec516e4..2b6d86030b26 100644
--- a/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c
+++ b/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c
@@ -22,7 +22,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
Only short item is supported here.
@param StartPos Start position of the HID item to get.
- @param EndPos End position of the range to get the the next HID item.
+ @param EndPos End position of the range to get the next HID item.
@param HidItem Buffer for the HID Item to return.
@return Pointer to end of the HID item returned.
diff --git a/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c b/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c
index 677815a8ade3..8284e9ec80b9 100644
--- a/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c
+++ b/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c
@@ -109,7 +109,7 @@ USBMouseDriverBindingSupported (
/**
Starts the mouse device with this driver.
- This function consumes USB I/O Portocol, intializes USB mouse device,
+ This function consumes USB I/O Protocol, initializes USB mouse device,
installs Simple Pointer Protocol, and submits Asynchronous Interrupt
Transfer to manage the USB mouse device.
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* [PATCH 23/79] MdeModulePkg/UsbBus: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (21 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 22/79] MdeModulePkg/UsbMouse: Fix few typos Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-03 16:15 ` [PATCH 24/79] MdeModulePkg/Usb: " Philippe Mathieu-Daudé
` (49 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Jian J Wang, Hao A Wu, Ray Ni,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.h | 14 +++++++-------
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.h | 2 +-
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h | 2 +-
MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h | 2 +-
MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h | 2 +-
MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.h | 2 +-
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c | 12 ++++++------
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c | 2 +-
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c | 4 ++--
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c | 8 ++++----
MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c | 2 +-
MdeModulePkg/Bus/Usb/UsbBusPei/UsbIoPeim.c | 2 +-
12 files changed, 27 insertions(+), 27 deletions(-)
diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.h b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.h
index 3fdbc94d95eb..c84a24df2413 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.h
+++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.h
@@ -159,7 +159,7 @@ typedef struct _EFI_USB_BUS_PROTOCOL {
//
// Stands for the real USB device. Each device may
-// has several seperately working interfaces.
+// has several separately working interfaces.
//
struct _USB_DEVICE {
USB_BUS *Bus;
@@ -265,8 +265,8 @@ struct _USB_BUS {
// USB Bus driver need to control the recursive connect policy of the bus, only those wanted
// usb child device will be recursively connected.
//
- // WantedUsbIoDPList tracks the Usb child devices which user want to recursivly fully connecte,
- // every wanted child device is stored in a item of the WantedUsbIoDPList, whose structrure is
+ // WantedUsbIoDPList tracks the Usb child devices which user want to recursively fully connecte,
+ // every wanted child device is stored in a item of the WantedUsbIoDPList, whose structure is
// DEVICE_PATH_LIST_ITEM
//
LIST_ENTRY WantedUsbIoDPList;
@@ -337,7 +337,7 @@ UsbBusAddWantedUsbIoDP (
Check whether a usb child device is the wanted device in a bus.
@param Bus The Usb bus's private data pointer.
- @param UsbIf The usb child device inferface.
+ @param UsbIf The usb child device interface.
@retval True If a usb child device is the wanted device in a bus.
@retval False If a usb child device is *NOT* the wanted device in a bus.
@@ -351,7 +351,7 @@ UsbBusIsWantedUsbIO (
);
/**
- Recursively connnect every wanted usb child device to ensure they all fully connected.
+ Recursively connect every wanted usb child device to ensure they all fully connected.
Check all the child Usb IO handles in this bus, recursively connecte if it is wanted usb child device.
@param UsbBusId Point to EFI_USB_BUS_PROTOCOL interface.
@@ -461,7 +461,7 @@ UsbIoSyncInterruptTransfer (
the request.
@param PollInterval The interval to poll the transfer result, (in ms).
@param DataLength The length of perodic data transfer.
- @param Callback The function to call periodicaly when transfer is
+ @param Callback The function to call periodically when transfer is
ready.
@param Context The context to the callback.
@@ -512,7 +512,7 @@ UsbIoIsochronousTransfer (
@param DeviceEndpoint The device endpoint.
@param Data The data to transfer.
@param DataLength The length of perodic data transfer.
- @param IsochronousCallBack The function to call periodicaly when transfer is
+ @param IsochronousCallBack The function to call periodically when transfer is
ready.
@param Context The context to the callback.
diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.h b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.h
index 0f4db2f34dc9..6043b5b2cd48 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.h
+++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.h
@@ -97,7 +97,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#pragma pack(1)
//
-// Hub descriptor, the last two fields are of variable lenght.
+// Hub descriptor, the last two fields are of variable length.
//
typedef struct {
UINT8 Length;
diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h
index 9c52520c87f7..1d2b8a6174c7 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h
+++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h
@@ -101,7 +101,7 @@ UsbHcClearRootHubPortFeature (
@param UsbResult The result of transfer.
@retval EFI_SUCCESS The control transfer finished without error.
- @retval Others The control transfer failed, reason returned in UsbReslt.
+ @retval Others The control transfer failed, reason returned in UsbResult.
**/
EFI_STATUS
diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h b/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h
index a78a1652ff4a..2a6d911a067e 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h
+++ b/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h
@@ -78,7 +78,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#define MAXBYTES 8
#pragma pack(1)
//
-// Hub descriptor, the last two fields are of variable lenght.
+// Hub descriptor, the last two fields are of variable length.
//
typedef struct {
UINT8 Length;
diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h b/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h
index cf9400987a38..48b8e594b283 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h
+++ b/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h
@@ -1,5 +1,5 @@
/** @file
-Common Libarary for PEI USB
+Common Library for PEI USB
Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved. <BR>
diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.h b/MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.h
index caba53266dac..b55b97d8707f 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.h
+++ b/MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.h
@@ -154,7 +154,7 @@ PeiUsbControlTransfer (
@param DeviceEndpoint Endpoint number and its direction in bit 7.
@param Data A pointer to the buffer of data to transmit
from or receive into.
- @param DataLength The lenght of the data buffer.
+ @param DataLength The length of the data buffer.
@param Timeout Indicates the maximum time, in millisecond, which the
transfer is allowed to complete. If Timeout is 0, then
the caller must wait for the function to be completed
diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c
index d4002c48d74e..4b4915c019ad 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c
+++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c
@@ -96,10 +96,10 @@ UsbIoControlTransfer (
UsbStatus
);
//
- // If the request completed sucessfully and the Direction of the request is
+ // If the request completed successfully and the Direction of the request is
// EfiUsbDataIn or EfiUsbDataOut, then make sure the actual number of bytes
- // transfered is the same as the number of bytes requested. If a different
- // number of bytes were transfered, then return EFI_DEVICE_ERROR.
+ // transferred is the same as the number of bytes requested. If a different
+ // number of bytes were transferred, then return EFI_DEVICE_ERROR.
//
if (!EFI_ERROR (Status)) {
if (Direction != EfiUsbNoData && DataLength != RequestedDataLength) {
@@ -389,7 +389,7 @@ ON_EXIT:
the request.
@param PollInterval The interval to poll the transfer result, (in ms).
@param DataLength The length of perodic data transfer.
- @param Callback The function to call periodicaly when transfer is
+ @param Callback The function to call periodically when transfer is
ready.
@param Context The context to the callback.
@@ -490,7 +490,7 @@ UsbIoIsochronousTransfer (
@param DeviceEndpoint The device endpoint.
@param Data The data to transfer.
@param DataLength The length of perodic data transfer.
- @param IsochronousCallBack The function to call periodicaly when transfer is
+ @param IsochronousCallBack The function to call periodically when transfer is
ready.
@param Context The context to the callback.
@@ -1355,7 +1355,7 @@ UsbBusControllerDriverStart (
if (IsDevicePathEnd (RemainingDevicePath)) {
//
// If RemainingDevicePath is the End of Device Path Node,
- // skip enumerate any device and return EFI_SUCESSS
+ // skip enumerate any device and return EFI_SUCCESS
//
return EFI_SUCCESS;
}
diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c
index cc0de52de411..d3e0cfa626c3 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c
+++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c
@@ -757,7 +757,7 @@ UsbEnumerateNewDev (
//
// After port is reset, hub establishes a signal path between
- // the device and host (DEFALUT state). Device's registers are
+ // the device and host (DEFAULT state). Device's registers are
// reset, use default address 0 (host enumerates one device at
// a time) , and ready to respond to control transfer at EP 0.
//
diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c
index c7c27a54819f..c5bd112511a4 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c
+++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c
@@ -545,7 +545,7 @@ UsbOnHubInterrupt (
// OK, actually something is changed, save the change map
// then signal the HUB to do enumeration. This is a good
// practise since UsbOnHubInterrupt is called in the context
- // of host contrller's AsyncInterrupt monitor.
+ // of host controller's AsyncInterrupt monitor.
//
HubIf->ChangeMap = AllocateZeroPool (DataLength);
@@ -630,7 +630,7 @@ UsbHubInit (
//
// OK, set IsHub to TRUE. Now usb bus can handle this device
- // as a working HUB. If failed eariler, bus driver will not
+ // as a working HUB. If failed earlier, bus driver will not
// recognize it as a hub. Other parts of the bus should be able
// to work.
//
diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c
index 8559992d2743..7529e03e853c 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c
+++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c
@@ -784,7 +784,7 @@ MatchUsbClass (
// If connect class policy, determine whether to create device handle by the five fields
// in class device path node.
//
- // In addtion, hub interface is always matched for this policy.
+ // In addition, hub interface is always matched for this policy.
//
if ((ActIfDesc->InterfaceClass == USB_HUB_CLASS_CODE) &&
(ActIfDesc->InterfaceSubClass == USB_HUB_SUBCLASS_CODE)) {
@@ -1018,7 +1018,7 @@ UsbBusAddWantedUsbIoDP (
} else {
//
// If RemainingDevicePath is the End of Device Path Node,
- // skip enumerate any device and return EFI_SUCESSS
+ // skip enumerate any device and return EFI_SUCCESS
//
return EFI_SUCCESS;
}
@@ -1034,7 +1034,7 @@ UsbBusAddWantedUsbIoDP (
Check whether a usb child device is the wanted device in a bus.
@param Bus The Usb bus's private data pointer.
- @param UsbIf The usb child device inferface.
+ @param UsbIf The usb child device interface.
@retval True If a usb child device is the wanted device in a bus.
@retval False If a usb child device is *NOT* the wanted device in a bus.
@@ -1136,7 +1136,7 @@ UsbBusIsWantedUsbIO (
}
/**
- Recursively connnect every wanted usb child device to ensure they all fully connected.
+ Recursively connect every wanted usb child device to ensure they all fully connected.
Check all the child Usb IO handles in this bus, recursively connecte if it is wanted usb child device.
@param UsbBusId Point to EFI_USB_BUS_PROTOCOL interface.
diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c b/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c
index 2cc1fc6aa77e..1385b0ab59af 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c
+++ b/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c
@@ -1,5 +1,5 @@
/** @file
-Common Libarary for PEI USB
+Common Library for PEI USB
Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved. <BR>
diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/UsbIoPeim.c b/MdeModulePkg/Bus/Usb/UsbBusPei/UsbIoPeim.c
index 653bbf52f005..fc04f834a549 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusPei/UsbIoPeim.c
+++ b/MdeModulePkg/Bus/Usb/UsbBusPei/UsbIoPeim.c
@@ -131,7 +131,7 @@ PeiUsbControlTransfer (
@param DeviceEndpoint Endpoint number and its direction in bit 7.
@param Data A pointer to the buffer of data to transmit
from or receive into.
- @param DataLength The lenght of the data buffer.
+ @param DataLength The length of the data buffer.
@param Timeout Indicates the maximum time, in millisecond, which the
transfer is allowed to complete. If Timeout is 0, then
the caller must wait for the function to be completed
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* [PATCH 24/79] MdeModulePkg/Usb: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (22 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 23/79] MdeModulePkg/UsbBus: Fix various typos Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-03 16:15 ` [PATCH 25/79] MdePkg/IndustryStandard: " Philippe Mathieu-Daudé
` (48 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Jian J Wang, Hao A Wu, Ray Ni,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h | 2 +-
MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h | 10 +++++-----
MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.h | 2 +-
MdeModulePkg/Bus/Usb/UsbBotPei/BotPeim.c | 2 +-
MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c | 2 +-
MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c | 2 +-
MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c | 8 ++++----
MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c | 6 +++---
8 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h
index 266581b80995..e06e2533a776 100644
--- a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h
+++ b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h
@@ -1,5 +1,5 @@
/** @file
-Common Libarary for PEI USB.
+Common Library for PEI USB.
Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.<BR>
diff --git a/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h b/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h
index 65819e43e6bd..852e43390d81 100644
--- a/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h
+++ b/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h
@@ -377,7 +377,7 @@ UsbKeyboardComponentNameGetControllerName (
// Functions of Simple Text Input Protocol
//
/**
- Reset the input device and optionaly run diagnostics
+ Reset the input device and optionally run diagnostics
There are 2 types of reset for USB keyboard.
For non-exhaustive reset, only keyboard buffer is cleared.
@@ -406,8 +406,8 @@ USBKeyboardReset (
information for the key that was pressed.
@retval EFI_SUCCESS The keystroke information was returned.
- @retval EFI_NOT_READY There was no keystroke data availiable.
- @retval EFI_DEVICE_ERROR The keydtroke information was not returned due to
+ @retval EFI_NOT_READY There was no keystroke data available.
+ @retval EFI_DEVICE_ERROR The keystroke information was not returned due to
hardware errors.
**/
@@ -507,7 +507,7 @@ USBKeyboardSetState (
@param NotifyHandle Points to the unique handle assigned to the registered notification.
@retval EFI_SUCCESS The notification function was registered successfully.
- @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necesssary data structures.
+ @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necessary data structures.
@retval EFI_INVALID_PARAMETER KeyData or NotifyHandle or KeyNotificationFunction is NULL.
**/
@@ -574,7 +574,7 @@ KbdFreeNotifyList (
@param InputData A pointer to keystroke data for the key that was pressed.
@retval TRUE Key pressed matches a registered key.
- @retval FLASE Key pressed does not matche a registered key.
+ @retval FALSE Key pressed does not match a registered key.
**/
BOOLEAN
diff --git a/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.h b/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.h
index 601fdd0c92e2..811f136b65b2 100644
--- a/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.h
+++ b/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.h
@@ -108,7 +108,7 @@ ReleaseKeyboardLayoutResources (
This function is the handler function for USB keyboard's asynchronous interrupt transfer
to manage the keyboard. It parses the USB keyboard input report, and inserts data to
- keyboard buffer according to state of modifer keys and normal keys. Timer for repeat key
+ keyboard buffer according to state of modifier keys and normal keys. Timer for repeat key
is also set accordingly.
@param Data A pointer to a buffer that is filled with key data which is
diff --git a/MdeModulePkg/Bus/Usb/UsbBotPei/BotPeim.c b/MdeModulePkg/Bus/Usb/UsbBotPei/BotPeim.c
index 5c071c661a45..2b1ca20a6314 100644
--- a/MdeModulePkg/Bus/Usb/UsbBotPei/BotPeim.c
+++ b/MdeModulePkg/Bus/Usb/UsbBotPei/BotPeim.c
@@ -192,7 +192,7 @@ BotDataPhase (
TransferredSize = 0;
//
- // retrieve the the max packet length of the given endpoint
+ // retrieve the max packet length of the given endpoint
//
if (Direction == EfiUsbDataIn) {
MaxPacketLen = (PeiBotDev->BulkInEndpoint)->MaxPacketSize;
diff --git a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c
index 9e6e748845d4..41f782a78bf9 100644
--- a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c
+++ b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c
@@ -1,5 +1,5 @@
/** @file
-Pei USB ATATPI command implementations.
+Pei USB ATAPI command implementations.
Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.<BR>
diff --git a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c
index fe9e6203010e..292682a2e447 100644
--- a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c
+++ b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c
@@ -1,5 +1,5 @@
/** @file
-Common Libarary for PEI USB.
+Common Library for PEI USB.
Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
diff --git a/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c b/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c
index 27685995c238..8792a36e4722 100644
--- a/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c
+++ b/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c
@@ -583,7 +583,7 @@ USBKeyboardDriverBindingStop (
data for the key that was pressed.
@retval EFI_SUCCESS The keystroke information was returned.
- @retval EFI_NOT_READY There was no keystroke data availiable.
+ @retval EFI_NOT_READY There was no keystroke data available.
@retval EFI_DEVICE_ERROR The keystroke information was not returned due to
hardware errors.
@retval EFI_INVALID_PARAMETER KeyData is NULL.
@@ -684,7 +684,7 @@ USBKeyboardReset (
information for the key that was pressed.
@retval EFI_SUCCESS The keystroke information was returned.
- @retval EFI_NOT_READY There was no keystroke data availiable.
+ @retval EFI_NOT_READY There was no keystroke data available.
@retval EFI_DEVICE_ERROR The keystroke information was not returned due to
hardware errors.
@@ -763,7 +763,7 @@ USBKeyboardWaitForKey (
OldTpl = gBS->RaiseTPL (TPL_NOTIFY);
//
- // WaitforKey doesn't suppor the partial key.
+ // WaitforKey doesn't support the partial key.
// Considering if the partial keystroke is enabled, there maybe a partial
// keystroke in the queue, so here skip the partial keystroke and get the
// next key from the queue
@@ -870,7 +870,7 @@ KbdFreeNotifyList (
@param InputData A pointer to keystroke data for the key that was pressed.
@retval TRUE Key pressed matches a registered key.
- @retval FLASE Key pressed does not matches a registered key.
+ @retval FALSE Key pressed does not matches a registered key.
**/
BOOLEAN
diff --git a/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c b/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c
index 7eb65b8815c1..5faf82ea579c 100644
--- a/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c
+++ b/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c
@@ -253,7 +253,7 @@ UINT8 EfiKeyToUsbKeyCodeConvertionTable[] = {
};
//
-// Keyboard modifier value to EFI Scan Code convertion table
+// Keyboard modifier value to EFI Scan Code conversion table
// EFI Scan Code and the modifier values are defined in UEFI spec.
//
UINT8 ModifierValueToEfiScanCodeConvertionTable[] = {
@@ -569,7 +569,7 @@ FindPhysicalKey (
This function is registered to event of EFI_HII_SET_KEYBOARD_LAYOUT_EVENT_GUID
group type, which will be triggered by EFI_HII_DATABASE_PROTOCOL.SetKeyboardLayout().
- It tries to get curent keyboard layout from HII database.
+ It tries to get current keyboard layout from HII database.
@param Event Event being signaled.
@param Context Points to USB_KB_DEV instance.
@@ -1084,7 +1084,7 @@ KeyboardHandler (
//
// Handle modifier key's pressing or releasing situation.
- // According to USB HID Firmware spec, Byte 0 uses folloing map of Modifier keys:
+ // According to USB HID Firmware spec, Byte 0 uses following map of Modifier keys:
// Bit0: Left Control, Keycode: 0xe0
// Bit1: Left Shift, Keycode: 0xe1
// Bit2: Left Alt, Keycode: 0xe2
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* [PATCH 25/79] MdePkg/IndustryStandard: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (23 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 24/79] MdeModulePkg/Usb: " Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-04 1:35 ` Michael D Kinney
2019-12-03 16:15 ` [PATCH 26/79] MdePkg/Library/Dxe: " Philippe Mathieu-Daudé
` (47 subsequent siblings)
72 siblings, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Michael D Kinney, Liming Gao,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdePkg/Include/IndustryStandard/Acpi10.h | 4 +-
MdePkg/Include/IndustryStandard/Acpi20.h | 4 +-
MdePkg/Include/IndustryStandard/Acpi30.h | 4 +-
MdePkg/Include/IndustryStandard/Acpi40.h | 2 +-
MdePkg/Include/IndustryStandard/Acpi50.h | 6 +--
MdePkg/Include/IndustryStandard/Acpi51.h | 4 +-
MdePkg/Include/IndustryStandard/Acpi60.h | 4 +-
MdePkg/Include/IndustryStandard/Acpi61.h | 4 +-
MdePkg/Include/IndustryStandard/Acpi62.h | 8 ++--
MdePkg/Include/IndustryStandard/Atapi.h | 40 ++++++++++----------
MdePkg/Include/IndustryStandard/ElTorito.h | 4 +-
MdePkg/Include/IndustryStandard/Emmc.h | 2 +-
MdePkg/Include/IndustryStandard/IpmiNetFnBridge.h | 4 +-
MdePkg/Include/IndustryStandard/Nvme.h | 10 ++---
MdePkg/Include/IndustryStandard/Pci22.h | 20 +++++-----
MdePkg/Include/IndustryStandard/PeImage.h | 2 +-
MdePkg/Include/IndustryStandard/Scsi.h | 2 +-
MdePkg/Include/IndustryStandard/SmBus.h | 2 +-
MdePkg/Include/IndustryStandard/Tpm12.h | 2 +-
19 files changed, 64 insertions(+), 64 deletions(-)
diff --git a/MdePkg/Include/IndustryStandard/Acpi10.h b/MdePkg/Include/IndustryStandard/Acpi10.h
index a38d2be61cc3..fa06eefbb6e6 100644
--- a/MdePkg/Include/IndustryStandard/Acpi10.h
+++ b/MdePkg/Include/IndustryStandard/Acpi10.h
@@ -37,7 +37,7 @@ typedef struct {
#pragma pack()
//
-// Define for Desriptor
+// Define for Descriptor
//
#define ACPI_SMALL_ITEM_FLAG 0x00
#define ACPI_LARGE_ITEM_FLAG 0x01
@@ -109,7 +109,7 @@ typedef struct {
#pragma pack(1)
///
-/// The commond definition of QWORD, DWORD, and WORD
+/// The common definition of QWORD, DWORD, and WORD
/// Address Space Descriptors.
///
typedef PACKED struct {
diff --git a/MdePkg/Include/IndustryStandard/Acpi20.h b/MdePkg/Include/IndustryStandard/Acpi20.h
index 8a0adbbb6a97..b63d494705a2 100644
--- a/MdePkg/Include/IndustryStandard/Acpi20.h
+++ b/MdePkg/Include/IndustryStandard/Acpi20.h
@@ -11,7 +11,7 @@
#include <IndustryStandard/Acpi10.h>
//
-// Define for Desriptor
+// Define for Descriptor
//
#define ACPI_LARGE_GENERIC_REGISTER_DESCRIPTOR_NAME 0x02
@@ -505,7 +505,7 @@ typedef struct {
#define EFI_ACPI_2_0_SYSTEM_LOCALITY_INFORMATION_TABLE_SIGNATURE SIGNATURE_32('S', 'L', 'I', 'T')
///
-/// "SPCR" Serial Port Concole Redirection Table
+/// "SPCR" Serial Port Console Redirection Table
///
#define EFI_ACPI_2_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGNATURE SIGNATURE_32('S', 'P', 'C', 'R')
diff --git a/MdePkg/Include/IndustryStandard/Acpi30.h b/MdePkg/Include/IndustryStandard/Acpi30.h
index 0fc947e745f4..6a7fc39c256e 100644
--- a/MdePkg/Include/IndustryStandard/Acpi30.h
+++ b/MdePkg/Include/IndustryStandard/Acpi30.h
@@ -11,7 +11,7 @@
#include <IndustryStandard/Acpi20.h>
//
-// Define for Desriptor
+// Define for Descriptor
//
#define ACPI_LARGE_EXTENDED_ADDRESS_SPACE_DESCRIPTOR_NAME 0x0B
@@ -684,7 +684,7 @@ typedef struct {
#define EFI_ACPI_3_0_PCI_EXPRESS_MEMORY_MAPPED_CONFIGURATION_SPACE_BASE_ADDRESS_DESCRIPTION_TABLE_SIGNATURE SIGNATURE_32('M', 'C', 'F', 'G')
///
-/// "SPCR" Serial Port Concole Redirection Table
+/// "SPCR" Serial Port Console Redirection Table
///
#define EFI_ACPI_3_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGNATURE SIGNATURE_32('S', 'P', 'C', 'R')
diff --git a/MdePkg/Include/IndustryStandard/Acpi40.h b/MdePkg/Include/IndustryStandard/Acpi40.h
index 53ec90c04243..c03ba7a6290b 100644
--- a/MdePkg/Include/IndustryStandard/Acpi40.h
+++ b/MdePkg/Include/IndustryStandard/Acpi40.h
@@ -1264,7 +1264,7 @@ typedef struct {
#define EFI_ACPI_4_0_MANAGEMENT_CONTROLLER_HOST_INTERFACE_TABLE_SIGNATURE SIGNATURE_32('M', 'C', 'H', 'I')
///
-/// "SPCR" Serial Port Concole Redirection Table
+/// "SPCR" Serial Port Console Redirection Table
///
#define EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGNATURE SIGNATURE_32('S', 'P', 'C', 'R')
diff --git a/MdePkg/Include/IndustryStandard/Acpi50.h b/MdePkg/Include/IndustryStandard/Acpi50.h
index 067ab68c3428..46dcdb950741 100644
--- a/MdePkg/Include/IndustryStandard/Acpi50.h
+++ b/MdePkg/Include/IndustryStandard/Acpi50.h
@@ -12,7 +12,7 @@
#include <IndustryStandard/Acpi40.h>
//
-// Define for Desriptor
+// Define for Descriptor
//
#define ACPI_SMALL_FIXED_DMA_DESCRIPTOR_NAME 0x0A
#define ACPI_LARGE_GPIO_CONNECTION_DESCRIPTOR_NAME 0x0C
@@ -1201,7 +1201,7 @@ typedef struct {
///
UINT64 ExitBootServicesEntry;
///
- /// Timer value logged at the point just prior towhen the OS loader gaining
+ /// Timer value logged at the point just prior to when the OS loader gaining
/// control back from calls the ExitBootServices function for UEFI compatible firmware.
/// For non-UEFI compatible boots, this field must be zero.
///
@@ -2063,7 +2063,7 @@ typedef struct {
#define EFI_ACPI_5_0_SOFTWARE_LICENSING_TABLE_SIGNATURE SIGNATURE_32('S', 'L', 'I', 'C')
///
-/// "SPCR" Serial Port Concole Redirection Table
+/// "SPCR" Serial Port Console Redirection Table
///
#define EFI_ACPI_5_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGNATURE SIGNATURE_32('S', 'P', 'C', 'R')
diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h b/MdePkg/Include/IndustryStandard/Acpi51.h
index e80b93f49a6a..0132f25de8ce 100644
--- a/MdePkg/Include/IndustryStandard/Acpi51.h
+++ b/MdePkg/Include/IndustryStandard/Acpi51.h
@@ -1154,7 +1154,7 @@ typedef struct {
///
UINT64 ExitBootServicesEntry;
///
- /// Timer value logged at the point just prior towhen the OS loader gaining
+ /// Timer value logged at the point just prior to when the OS loader gaining
/// control back from calls the ExitBootServices function for UEFI compatible firmware.
/// For non-UEFI compatible boots, this field must be zero.
///
@@ -2084,7 +2084,7 @@ typedef struct {
#define EFI_ACPI_5_1_SOFTWARE_LICENSING_TABLE_SIGNATURE SIGNATURE_32('S', 'L', 'I', 'C')
///
-/// "SPCR" Serial Port Concole Redirection Table
+/// "SPCR" Serial Port Console Redirection Table
///
#define EFI_ACPI_5_1_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGNATURE SIGNATURE_32('S', 'P', 'C', 'R')
diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h b/MdePkg/Include/IndustryStandard/Acpi60.h
index 521d8a5b2ebd..94a30a81b369 100644
--- a/MdePkg/Include/IndustryStandard/Acpi60.h
+++ b/MdePkg/Include/IndustryStandard/Acpi60.h
@@ -1169,7 +1169,7 @@ typedef struct {
///
UINT64 ExitBootServicesEntry;
///
- /// Timer value logged at the point just prior towhen the OS loader gaining
+ /// Timer value logged at the point just prior to when the OS loader gaining
/// control back from calls the ExitBootServices function for UEFI compatible firmware.
/// For non-UEFI compatible boots, this field must be zero.
///
@@ -2327,7 +2327,7 @@ typedef struct {
#define EFI_ACPI_6_0_SOFTWARE_LICENSING_TABLE_SIGNATURE SIGNATURE_32('S', 'L', 'I', 'C')
///
-/// "SPCR" Serial Port Concole Redirection Table
+/// "SPCR" Serial Port Console Redirection Table
///
#define EFI_ACPI_6_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGNATURE SIGNATURE_32('S', 'P', 'C', 'R')
diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h b/MdePkg/Include/IndustryStandard/Acpi61.h
index 6fac6506ccfb..985c8273ce61 100644
--- a/MdePkg/Include/IndustryStandard/Acpi61.h
+++ b/MdePkg/Include/IndustryStandard/Acpi61.h
@@ -1169,7 +1169,7 @@ typedef struct {
///
UINT64 ExitBootServicesEntry;
///
- /// Timer value logged at the point just prior towhen the OS loader gaining
+ /// Timer value logged at the point just prior to when the OS loader gaining
/// control back from calls the ExitBootServices function for UEFI compatible firmware.
/// For non-UEFI compatible boots, this field must be zero.
///
@@ -2359,7 +2359,7 @@ typedef struct {
#define EFI_ACPI_6_1_SOFTWARE_LICENSING_TABLE_SIGNATURE SIGNATURE_32('S', 'L', 'I', 'C')
///
-/// "SPCR" Serial Port Concole Redirection Table
+/// "SPCR" Serial Port Console Redirection Table
///
#define EFI_ACPI_6_1_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGNATURE SIGNATURE_32('S', 'P', 'C', 'R')
diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h
index e60d1dfce6ce..5a5e9b811247 100644
--- a/MdePkg/Include/IndustryStandard/Acpi62.h
+++ b/MdePkg/Include/IndustryStandard/Acpi62.h
@@ -1281,7 +1281,7 @@ typedef struct {
///
UINT64 ExitBootServicesEntry;
///
- /// Timer value logged at the point just prior towhen the OS loader gaining
+ /// Timer value logged at the point just prior to when the OS loader gaining
/// control back from calls the ExitBootServices function for UEFI compatible firmware.
/// For non-UEFI compatible boots, this field must be zero.
///
@@ -1650,13 +1650,13 @@ typedef struct {
#define EFI_ACPI_6_2_SECURE_DEVICES_TABLE_REVISION 0x01
///
-/// Secure Devcice types
+/// Secure Device types
///
#define EFI_ACPI_6_2_SDEV_TYPE_PCIE_ENDPOINT_DEVICE 0x01
#define EFI_ACPI_6_2_SDEV_TYPE_ACPI_NAMESPACE_DEVICE 0x00
///
-/// Secure Devcice flags
+/// Secure Device flags
///
#define EFI_ACPI_6_2_SDEV_FLAG_ALLOW_HANDOFF BIT0
@@ -2890,7 +2890,7 @@ typedef struct {
#define EFI_ACPI_6_2_SOFTWARE_LICENSING_TABLE_SIGNATURE SIGNATURE_32('S', 'L', 'I', 'C')
///
-/// "SPCR" Serial Port Concole Redirection Table
+/// "SPCR" Serial Port Console Redirection Table
///
#define EFI_ACPI_6_2_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGNATURE SIGNATURE_32('S', 'P', 'C', 'R')
diff --git a/MdePkg/Include/IndustryStandard/Atapi.h b/MdePkg/Include/IndustryStandard/Atapi.h
index 43d0b58ae6ec..d9abe7f28fad 100644
--- a/MdePkg/Include/IndustryStandard/Atapi.h
+++ b/MdePkg/Include/IndustryStandard/Atapi.h
@@ -484,33 +484,33 @@ typedef union {
//
// ATA Packet Command Code
//
-#define ATA_CMD_FORMAT_UNIT 0x04 ///< defined in ATAPI Removable Rewritable Media Devcies
+#define ATA_CMD_FORMAT_UNIT 0x04 ///< defined in ATAPI Removable Rewritable Media Devices
#define ATA_CMD_SOFT_RESET 0x08 ///< defined from ATA-3
#define ATA_CMD_PACKET 0xA0 ///< defined from ATA-3
#define ATA_CMD_IDENTIFY_DEVICE 0xA1 ///< defined from ATA-3
#define ATA_CMD_SERVICE 0xA2 ///< defined from ATA-3
#define ATA_CMD_TEST_UNIT_READY 0x00 ///< defined from ATA-1
#define ATA_CMD_REQUEST_SENSE 0x03 ///< defined from ATA-4
-#define ATA_CMD_INQUIRY 0x12 ///< defined in ATAPI Removable Rewritable Media Devcies
-#define ATA_CMD_READ_FORMAT_CAPACITY 0x23 ///< defined in ATAPI Removable Rewritable Media Devcies
-#define ATA_CMD_READ_CAPACITY 0x25 ///< defined in ATAPI Removable Rewritable Media Devcies
-#define ATA_CMD_READ_10 0x28 ///< defined in ATAPI Removable Rewritable Media Devcies
-#define ATA_CMD_WRITE_10 0x2A ///< defined in ATAPI Removable Rewritable Media Devcies
-#define ATA_CMD_ATAPI_SEEK 0x2B ///< defined in ATAPI Removable Rewritable Media Devcies
-#define ATA_CMD_WRITE_AND_VERIFY 0x2E ///< defined in ATAPI Removable Rewritable Media Devcies
-#define ATA_CMD_VERIFY 0x2F ///< defined in ATAPI Removable Rewritable Media Devcies
-#define ATA_CMD_READ_12 0xA8 ///< defined in ATAPI Removable Rewritable Media Devcies
-#define ATA_CMD_WRITE_12 0xAA ///< defined in ATAPI Removable Rewritable Media Devcies
-#define ATA_CMD_START_STOP_UNIT 0x1B ///< defined in ATAPI Removable Rewritable Media Devcies
-#define ATA_CMD_PREVENT_ALLOW_MEDIA_REMOVAL 0x1E ///< defined in ATAPI Removable Rewritable Media Devcies
-#define ATA_CMD_MODE_SELECT 0x55 ///< defined in ATAPI Removable Rewritable Media Devcies
+#define ATA_CMD_INQUIRY 0x12 ///< defined in ATAPI Removable Rewritable Media Devices
+#define ATA_CMD_READ_FORMAT_CAPACITY 0x23 ///< defined in ATAPI Removable Rewritable Media Devices
+#define ATA_CMD_READ_CAPACITY 0x25 ///< defined in ATAPI Removable Rewritable Media Devices
+#define ATA_CMD_READ_10 0x28 ///< defined in ATAPI Removable Rewritable Media Devices
+#define ATA_CMD_WRITE_10 0x2A ///< defined in ATAPI Removable Rewritable Media Devices
+#define ATA_CMD_ATAPI_SEEK 0x2B ///< defined in ATAPI Removable Rewritable Media Devices
+#define ATA_CMD_WRITE_AND_VERIFY 0x2E ///< defined in ATAPI Removable Rewritable Media Devices
+#define ATA_CMD_VERIFY 0x2F ///< defined in ATAPI Removable Rewritable Media Devices
+#define ATA_CMD_READ_12 0xA8 ///< defined in ATAPI Removable Rewritable Media Devices
+#define ATA_CMD_WRITE_12 0xAA ///< defined in ATAPI Removable Rewritable Media Devices
+#define ATA_CMD_START_STOP_UNIT 0x1B ///< defined in ATAPI Removable Rewritable Media Devices
+#define ATA_CMD_PREVENT_ALLOW_MEDIA_REMOVAL 0x1E ///< defined in ATAPI Removable Rewritable Media Devices
+#define ATA_CMD_MODE_SELECT 0x55 ///< defined in ATAPI Removable Rewritable Media Devices
-#define ATA_CMD_MODE_SENSE 0x5A ///< defined in ATAPI Removable Rewritable Media Devcies
- #define ATA_PAGE_CODE_READ_WRITE_ERROR 0x01 ///< defined in ATAPI Removable Rewritable Media Devcies
- #define ATA_PAGE_CODE_CACHING_PAGE 0x08 ///< defined in ATAPI Removable Rewritable Media Devcies
- #define ATA_PAGE_CODE_REMOVABLE_BLOCK_CAPABILITIES 0x1B ///< defined in ATAPI Removable Rewritable Media Devcies
- #define ATA_PAGE_CODE_TIMER_PROTECT_PAGE 0x1C ///< defined in ATAPI Removable Rewritable Media Devcies
- #define ATA_PAGE_CODE_RETURN_ALL_PAGES 0x3F ///< defined in ATAPI Removable Rewritable Media Devcies
+#define ATA_CMD_MODE_SENSE 0x5A ///< defined in ATAPI Removable Rewritable Media Devices
+ #define ATA_PAGE_CODE_READ_WRITE_ERROR 0x01 ///< defined in ATAPI Removable Rewritable Media Devices
+ #define ATA_PAGE_CODE_CACHING_PAGE 0x08 ///< defined in ATAPI Removable Rewritable Media Devices
+ #define ATA_PAGE_CODE_REMOVABLE_BLOCK_CAPABILITIES 0x1B ///< defined in ATAPI Removable Rewritable Media Devices
+ #define ATA_PAGE_CODE_TIMER_PROTECT_PAGE 0x1C ///< defined in ATAPI Removable Rewritable Media Devices
+ #define ATA_PAGE_CODE_RETURN_ALL_PAGES 0x3F ///< defined in ATAPI Removable Rewritable Media Devices
#define ATA_CMD_GET_CONFIGURATION 0x46 ///< defined in ATAPI Multimedia Devices
#define ATA_GCCD_RT_FIELD_VALUE_ALL 0x00 ///< defined in ATAPI Multimedia Devices
diff --git a/MdePkg/Include/IndustryStandard/ElTorito.h b/MdePkg/Include/IndustryStandard/ElTorito.h
index 31d02bcf1339..94b55d842f3c 100644
--- a/MdePkg/Include/IndustryStandard/ElTorito.h
+++ b/MdePkg/Include/IndustryStandard/ElTorito.h
@@ -1,6 +1,6 @@
/** @file
ElTorito Partitions Format Definition.
- This file includes some defintions from
+ This file includes some definitions from
1. "El Torito" Bootable CD-ROM Format Specification, Version 1.0.
2. Volume and File Structure of CDROM for Information Interchange,
Standard ECMA-119. (IS0 9660)
@@ -75,7 +75,7 @@ typedef union {
} BootRecordVolume;
///
- /// Primary Volumn Descriptor, defined in ISO 9660.
+ /// Primary Volume Descriptor, defined in ISO 9660.
///
struct {
UINT8 Type;
diff --git a/MdePkg/Include/IndustryStandard/Emmc.h b/MdePkg/Include/IndustryStandard/Emmc.h
index 2055c4ca18d8..5cfc95800813 100644
--- a/MdePkg/Include/IndustryStandard/Emmc.h
+++ b/MdePkg/Include/IndustryStandard/Emmc.h
@@ -224,7 +224,7 @@ typedef struct {
UINT8 MinPerfW8B52M; // Minimum Write Performance for 8bit at 52MHz [210]
UINT8 Reserved17; // Reserved [211]
UINT8 SecCount[4]; // Sector Count [215:212]
- UINT8 SleepNotificationTime; // Sleep Notification Timout [216]
+ UINT8 SleepNotificationTime; // Sleep Notification Timeout [216]
UINT8 SATimeout; // Sleep/awake timeout [217]
UINT8 ProductionStateAwarenessTimeout; // Production state awareness timeout [218]
UINT8 SCVccq; // Sleep current (VCCQ) [219]
diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnBridge.h b/MdePkg/Include/IndustryStandard/IpmiNetFnBridge.h
index 79af969a20c6..3c2084048481 100644
--- a/MdePkg/Include/IndustryStandard/IpmiNetFnBridge.h
+++ b/MdePkg/Include/IndustryStandard/IpmiNetFnBridge.h
@@ -127,12 +127,12 @@
//
//
-// Definitions for Prepare for Discoveery command
+// Definitions for Prepare for Discovery command
//
#define IPMI_BRIDGE_PREPARE_FOR_DISCOVERY 0x10
//
-// Constants and Structure definitions for "Prepare for Discoveery" command to follow here
+// Constants and Structure definitions for "Prepare for Discovery" command to follow here
//
//
diff --git a/MdePkg/Include/IndustryStandard/Nvme.h b/MdePkg/Include/IndustryStandard/Nvme.h
index 9468a73d7066..9b19a2074b0d 100644
--- a/MdePkg/Include/IndustryStandard/Nvme.h
+++ b/MdePkg/Include/IndustryStandard/Nvme.h
@@ -309,11 +309,11 @@ typedef struct {
UINT32 Exlat; /* Exit Latency */
UINT8 Rrt:5; /* Relative Read Throughput */
UINT8 Rsvd3:3; /* Reserved as of Nvm Express 1.1 Spec */
- UINT8 Rrl:5; /* Relative Read Leatency */
+ UINT8 Rrl:5; /* Relative Read Latency */
UINT8 Rsvd4:3; /* Reserved as of Nvm Express 1.1 Spec */
UINT8 Rwt:5; /* Relative Write Throughput */
UINT8 Rsvd5:3; /* Reserved as of Nvm Express 1.1 Spec */
- UINT8 Rwl:5; /* Relative Write Leatency */
+ UINT8 Rwl:5; /* Relative Write Latency */
UINT8 Rsvd6:3; /* Reserved as of Nvm Express 1.1 Spec */
UINT8 Rsvd7[16]; /* Reserved as of Nvm Express 1.1 Spec */
} NVME_PSDESCRIPTOR;
@@ -329,7 +329,7 @@ typedef struct {
UINT16 Ssvid; /* PCI sub-system vendor ID */
UINT8 Sn[20]; /* Product serial number */
- UINT8 Mn[40]; /* Proeduct model number */
+ UINT8 Mn[40]; /* Product model number */
UINT8 Fr[8]; /* Firmware Revision */
UINT8 Rab; /* Recommended Arbitration Burst */
UINT8 Ieee_oui[3]; /* Organization Unique Identifier */
@@ -657,7 +657,7 @@ typedef union {
//
typedef struct {
//
- // CDW 0, Common to all comnmands
+ // CDW 0, Common to all commands
//
UINT8 Opc; // Opcode
UINT8 Fuse:2; // Fused Operation
@@ -869,7 +869,7 @@ typedef struct {
//
UINT8 AvailableSpareThreshold;
//
- // Contains a vendor specific estimate of the percentage of NVM subsystem life used based on the actual usage and the manufacturer?s prediction of NVM life. A value of 100 indicates that the estimated endurance of the NVM in the NVM subsystem has been consumed, but may not indicate an NVM subsystem failure. The value is allowed to exceed 100. Percentages greater than 254 shall be represented as 255. This value shall be updated once per power-on hour (when the controller is not in a sleep state).
+ // Contains a vendor specific estimate of the percentage of NVM subsystem life used based on the actual usage and the manufacturer's prediction of NVM life. A value of 100 indicates that the estimated endurance of the NVM in the NVM subsystem has been consumed, but may not indicate an NVM subsystem failure. The value is allowed to exceed 100. Percentages greater than 254 shall be represented as 255. This value shall be updated once per power-on hour (when the controller is not in a sleep state).
//
UINT8 PercentageUsed;
UINT8 Reserved1[26];
diff --git a/MdePkg/Include/IndustryStandard/Pci22.h b/MdePkg/Include/IndustryStandard/Pci22.h
index 5fd054c4cfbe..81a854f69577 100644
--- a/MdePkg/Include/IndustryStandard/Pci22.h
+++ b/MdePkg/Include/IndustryStandard/Pci22.h
@@ -5,7 +5,7 @@
PCI Local Bus Specification, 2.2
PCI-to-PCI Bridge Architecture Specification, Revision 1.2
PC Card Standard, 8.0
- PCI Power Management Interface Specifiction, Revision 1.2
+ PCI Power Management Interface Specification, Revision 1.2
Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
Copyright (c) 2014 - 2015, Hewlett-Packard Development Company, L.P.<BR>
@@ -111,11 +111,11 @@ typedef union {
} PCI_TYPE_GENERIC;
///
-/// CardBus Conroller Configuration Space,
+/// CardBus Controller Configuration Space,
/// Section 4.5.1, PC Card Standard. 8.0
///
typedef struct {
- UINT32 CardBusSocketReg; ///< Cardus Socket/ExCA Base
+ UINT32 CardBusSocketReg; ///< Cardbus Socket/ExCA Base
UINT8 Cap_Ptr;
UINT8 Reserved;
UINT16 SecondaryStatus; ///< Secondary Status
@@ -222,7 +222,7 @@ typedef struct {
#define PCI_IF_8259_PIC 0x00
#define PCI_IF_ISA_PIC 0x01
#define PCI_IF_EISA_PIC 0x02
-#define PCI_IF_APIC_CONTROLLER 0x10 ///< I/O APIC interrupt controller , 32 bye none-prefectable memory.
+#define PCI_IF_APIC_CONTROLLER 0x10 ///< I/O APIC interrupt controller , 32 byte none-prefetchable memory.
#define PCI_IF_APIC_CONTROLLER2 0x20
#define PCI_SUBCLASS_DMA 0x01
#define PCI_IF_8237_DMA 0x00
@@ -509,7 +509,7 @@ typedef struct {
#define IS_PCI_MULTI_FUNC(_p) ((_p)->Hdr.HeaderType & HEADER_TYPE_MULTI_FUNCTION)
///
-/// Rom Base Address in Bridge, defined in PCI-to-PCI Bridge Architecure Specification,
+/// Rom Base Address in Bridge, defined in PCI-to-PCI Bridge Architecture Specification,
///
#define PCI_BRIDGE_ROMBAR 0x38
@@ -642,7 +642,7 @@ typedef struct {
///
/// PMC - Power Management Capabilities
-/// Section 3.2.3, PCI Power Management Interface Specifiction, Revision 1.2
+/// Section 3.2.3, PCI Power Management Interface Specification, Revision 1.2
///
typedef union {
struct {
@@ -662,7 +662,7 @@ typedef union {
///
/// PMCSR - Power Management Control/Status
-/// Section 3.2.4, PCI Power Management Interface Specifiction, Revision 1.2
+/// Section 3.2.4, PCI Power Management Interface Specification, Revision 1.2
///
typedef union {
struct {
@@ -685,7 +685,7 @@ typedef union {
///
/// PMCSR_BSE - PMCSR PCI-to-PCI Bridge Support Extensions
-/// Section 3.2.5, PCI Power Management Interface Specifiction, Revision 1.2
+/// Section 3.2.5, PCI Power Management Interface Specification, Revision 1.2
///
typedef union {
struct {
@@ -698,7 +698,7 @@ typedef union {
///
/// Power Management Register Block Definition
-/// Section 3.2, PCI Power Management Interface Specifiction, Revision 1.2
+/// Section 3.2, PCI Power Management Interface Specification, Revision 1.2
///
typedef struct {
EFI_PCI_CAPABILITY_HDR Hdr;
@@ -732,7 +732,7 @@ typedef struct {
///
/// Slot Numbering Capabilities Register
-/// Section 3.2.6, PCI-to-PCI Bridge Architeture Specification, Revision 1.2
+/// Section 3.2.6, PCI-to-PCI Bridge Architecture Specification, Revision 1.2
///
typedef struct {
EFI_PCI_CAPABILITY_HDR Hdr;
diff --git a/MdePkg/Include/IndustryStandard/PeImage.h b/MdePkg/Include/IndustryStandard/PeImage.h
index 720bb084ac42..a3d9bbed757b 100644
--- a/MdePkg/Include/IndustryStandard/PeImage.h
+++ b/MdePkg/Include/IndustryStandard/PeImage.h
@@ -92,7 +92,7 @@ typedef struct {
//
#define EFI_IMAGE_FILE_RELOCS_STRIPPED BIT0 ///< 0x0001 Relocation info stripped from file.
#define EFI_IMAGE_FILE_EXECUTABLE_IMAGE BIT1 ///< 0x0002 File is executable (i.e. no unresolved externel references).
-#define EFI_IMAGE_FILE_LINE_NUMS_STRIPPED BIT2 ///< 0x0004 Line nunbers stripped from file.
+#define EFI_IMAGE_FILE_LINE_NUMS_STRIPPED BIT2 ///< 0x0004 Line numbers stripped from file.
#define EFI_IMAGE_FILE_LOCAL_SYMS_STRIPPED BIT3 ///< 0x0008 Local symbols stripped from file.
#define EFI_IMAGE_FILE_BYTES_REVERSED_LO BIT7 ///< 0x0080 Bytes of machine word are reversed.
#define EFI_IMAGE_FILE_32BIT_MACHINE BIT8 ///< 0x0100 32 bit word machine.
diff --git a/MdePkg/Include/IndustryStandard/Scsi.h b/MdePkg/Include/IndustryStandard/Scsi.h
index d03886417f86..3e966520a185 100644
--- a/MdePkg/Include/IndustryStandard/Scsi.h
+++ b/MdePkg/Include/IndustryStandard/Scsi.h
@@ -154,7 +154,7 @@
#define EFI_SCSI_OP_SEND_VOL_TAG 0xb6
//
-// Additional commands for Communition Devices
+// Additional commands for Communication Devices
//
#define EFI_SCSI_OP_GET_MESSAGE6 0x08
#define EFI_SCSI_OP_GET_MESSAGE10 0x28
diff --git a/MdePkg/Include/IndustryStandard/SmBus.h b/MdePkg/Include/IndustryStandard/SmBus.h
index f5d6e5ef9b7d..024a7ba67a06 100644
--- a/MdePkg/Include/IndustryStandard/SmBus.h
+++ b/MdePkg/Include/IndustryStandard/SmBus.h
@@ -1,5 +1,5 @@
/** @file
- This file declares the SMBus definitions defined in SmBus Specifciation V2.0
+ This file declares the SMBus definitions defined in SmBus Specification V2.0
and defined in PI1.0 specification volume 5.
Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
diff --git a/MdePkg/Include/IndustryStandard/Tpm12.h b/MdePkg/Include/IndustryStandard/Tpm12.h
index 2537c192b3f8..e85a567e83be 100644
--- a/MdePkg/Include/IndustryStandard/Tpm12.h
+++ b/MdePkg/Include/IndustryStandard/Tpm12.h
@@ -597,7 +597,7 @@ typedef struct tdTPM_CHANGEAUTH_VALIDATE {
///
/// Part 2, section 5.12: TPM_MIGRATIONKEYAUTH
-/// decalared after section 10 to catch declaration of TPM_PUBKEY
+/// declared after section 10 to catch declaration of TPM_PUBKEY
///
/// Part 2 section 10.1: TPM_KEY_PARMS
/// [size_is(parmSize)] BYTE* parms;
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [PATCH 25/79] MdePkg/IndustryStandard: Fix various typos
2019-12-03 16:15 ` [PATCH 25/79] MdePkg/IndustryStandard: " Philippe Mathieu-Daudé
@ 2019-12-04 1:35 ` Michael D Kinney
0 siblings, 0 replies; 122+ messages in thread
From: Michael D Kinney @ 2019-12-04 1:35 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io, Kinney, Michael D
Cc: Antoine Coeur, Gao, Liming
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: Philippe Mathieu-Daude <philmd@redhat.com>
> Sent: Tuesday, December 3, 2019 8:15 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Philippe Mathieu-Daude
> <philmd@redhat.com>
> Subject: [PATCH 25/79] MdePkg/IndustryStandard: Fix
> various typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude
> <philmd@redhat.com>
> ---
> MdePkg/Include/IndustryStandard/Acpi10.h | 4
> +-
> MdePkg/Include/IndustryStandard/Acpi20.h | 4
> +-
> MdePkg/Include/IndustryStandard/Acpi30.h | 4
> +-
> MdePkg/Include/IndustryStandard/Acpi40.h | 2
> +-
> MdePkg/Include/IndustryStandard/Acpi50.h | 6
> +--
> MdePkg/Include/IndustryStandard/Acpi51.h | 4
> +-
> MdePkg/Include/IndustryStandard/Acpi60.h | 4
> +-
> MdePkg/Include/IndustryStandard/Acpi61.h | 4
> +-
> MdePkg/Include/IndustryStandard/Acpi62.h | 8
> ++--
> MdePkg/Include/IndustryStandard/Atapi.h | 40
> ++++++++++----------
> MdePkg/Include/IndustryStandard/ElTorito.h | 4
> +-
> MdePkg/Include/IndustryStandard/Emmc.h | 2
> +-
> MdePkg/Include/IndustryStandard/IpmiNetFnBridge.h | 4
> +-
> MdePkg/Include/IndustryStandard/Nvme.h | 10
> ++---
> MdePkg/Include/IndustryStandard/Pci22.h | 20
> +++++-----
> MdePkg/Include/IndustryStandard/PeImage.h | 2
> +-
> MdePkg/Include/IndustryStandard/Scsi.h | 2
> +-
> MdePkg/Include/IndustryStandard/SmBus.h | 2
> +-
> MdePkg/Include/IndustryStandard/Tpm12.h | 2
> +-
> 19 files changed, 64 insertions(+), 64 deletions(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi10.h
> b/MdePkg/Include/IndustryStandard/Acpi10.h
> index a38d2be61cc3..fa06eefbb6e6 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi10.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi10.h
> @@ -37,7 +37,7 @@ typedef struct {
> #pragma pack()
>
> //
> -// Define for Desriptor
> +// Define for Descriptor
> //
> #define ACPI_SMALL_ITEM_FLAG 0x00
> #define ACPI_LARGE_ITEM_FLAG 0x01
> @@ -109,7 +109,7 @@ typedef struct {
> #pragma pack(1)
>
> ///
> -/// The commond definition of QWORD, DWORD, and WORD
> +/// The common definition of QWORD, DWORD, and WORD
> /// Address Space Descriptors.
> ///
> typedef PACKED struct {
> diff --git a/MdePkg/Include/IndustryStandard/Acpi20.h
> b/MdePkg/Include/IndustryStandard/Acpi20.h
> index 8a0adbbb6a97..b63d494705a2 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi20.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi20.h
> @@ -11,7 +11,7 @@
> #include <IndustryStandard/Acpi10.h>
>
> //
> -// Define for Desriptor
> +// Define for Descriptor
> //
> #define ACPI_LARGE_GENERIC_REGISTER_DESCRIPTOR_NAME
> 0x02
>
> @@ -505,7 +505,7 @@ typedef struct {
> #define
> EFI_ACPI_2_0_SYSTEM_LOCALITY_INFORMATION_TABLE_SIGNATUR
> E SIGNATURE_32('S', 'L', 'I', 'T')
>
> ///
> -/// "SPCR" Serial Port Concole Redirection Table
> +/// "SPCR" Serial Port Console Redirection Table
> ///
> #define
> EFI_ACPI_2_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGN
> ATURE SIGNATURE_32('S', 'P', 'C', 'R')
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi30.h
> b/MdePkg/Include/IndustryStandard/Acpi30.h
> index 0fc947e745f4..6a7fc39c256e 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi30.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi30.h
> @@ -11,7 +11,7 @@
> #include <IndustryStandard/Acpi20.h>
>
> //
> -// Define for Desriptor
> +// Define for Descriptor
> //
> #define
> ACPI_LARGE_EXTENDED_ADDRESS_SPACE_DESCRIPTOR_NAME
> 0x0B
>
> @@ -684,7 +684,7 @@ typedef struct {
> #define
> EFI_ACPI_3_0_PCI_EXPRESS_MEMORY_MAPPED_CONFIGURATION_SP
> ACE_BASE_ADDRESS_DESCRIPTION_TABLE_SIGNATURE
> SIGNATURE_32('M', 'C', 'F', 'G')
>
> ///
> -/// "SPCR" Serial Port Concole Redirection Table
> +/// "SPCR" Serial Port Console Redirection Table
> ///
> #define
> EFI_ACPI_3_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGN
> ATURE SIGNATURE_32('S', 'P', 'C', 'R')
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi40.h
> b/MdePkg/Include/IndustryStandard/Acpi40.h
> index 53ec90c04243..c03ba7a6290b 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi40.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi40.h
> @@ -1264,7 +1264,7 @@ typedef struct {
> #define
> EFI_ACPI_4_0_MANAGEMENT_CONTROLLER_HOST_INTERFACE_TABLE
> _SIGNATURE SIGNATURE_32('M', 'C', 'H', 'I')
>
> ///
> -/// "SPCR" Serial Port Concole Redirection Table
> +/// "SPCR" Serial Port Console Redirection Table
> ///
> #define
> EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGN
> ATURE SIGNATURE_32('S', 'P', 'C', 'R')
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi50.h
> b/MdePkg/Include/IndustryStandard/Acpi50.h
> index 067ab68c3428..46dcdb950741 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi50.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi50.h
> @@ -12,7 +12,7 @@
> #include <IndustryStandard/Acpi40.h>
>
> //
> -// Define for Desriptor
> +// Define for Descriptor
> //
> #define ACPI_SMALL_FIXED_DMA_DESCRIPTOR_NAME
> 0x0A
> #define ACPI_LARGE_GPIO_CONNECTION_DESCRIPTOR_NAME
> 0x0C
> @@ -1201,7 +1201,7 @@ typedef struct {
> ///
> UINT64
> ExitBootServicesEntry;
> ///
> - /// Timer value logged at the point just prior
> towhen the OS loader gaining
> + /// Timer value logged at the point just prior to
> when the OS loader gaining
> /// control back from calls the ExitBootServices
> function for UEFI compatible firmware.
> /// For non-UEFI compatible boots, this field must
> be zero.
> ///
> @@ -2063,7 +2063,7 @@ typedef struct {
> #define
> EFI_ACPI_5_0_SOFTWARE_LICENSING_TABLE_SIGNATURE
> SIGNATURE_32('S', 'L', 'I', 'C')
>
> ///
> -/// "SPCR" Serial Port Concole Redirection Table
> +/// "SPCR" Serial Port Console Redirection Table
> ///
> #define
> EFI_ACPI_5_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGN
> ATURE SIGNATURE_32('S', 'P', 'C', 'R')
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h
> b/MdePkg/Include/IndustryStandard/Acpi51.h
> index e80b93f49a6a..0132f25de8ce 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi51.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi51.h
> @@ -1154,7 +1154,7 @@ typedef struct {
> ///
> UINT64
> ExitBootServicesEntry;
> ///
> - /// Timer value logged at the point just prior
> towhen the OS loader gaining
> + /// Timer value logged at the point just prior to
> when the OS loader gaining
> /// control back from calls the ExitBootServices
> function for UEFI compatible firmware.
> /// For non-UEFI compatible boots, this field must
> be zero.
> ///
> @@ -2084,7 +2084,7 @@ typedef struct {
> #define
> EFI_ACPI_5_1_SOFTWARE_LICENSING_TABLE_SIGNATURE
> SIGNATURE_32('S', 'L', 'I', 'C')
>
> ///
> -/// "SPCR" Serial Port Concole Redirection Table
> +/// "SPCR" Serial Port Console Redirection Table
> ///
> #define
> EFI_ACPI_5_1_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGN
> ATURE SIGNATURE_32('S', 'P', 'C', 'R')
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h
> b/MdePkg/Include/IndustryStandard/Acpi60.h
> index 521d8a5b2ebd..94a30a81b369 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi60.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi60.h
> @@ -1169,7 +1169,7 @@ typedef struct {
> ///
> UINT64
> ExitBootServicesEntry;
> ///
> - /// Timer value logged at the point just prior
> towhen the OS loader gaining
> + /// Timer value logged at the point just prior to
> when the OS loader gaining
> /// control back from calls the ExitBootServices
> function for UEFI compatible firmware.
> /// For non-UEFI compatible boots, this field must
> be zero.
> ///
> @@ -2327,7 +2327,7 @@ typedef struct {
> #define
> EFI_ACPI_6_0_SOFTWARE_LICENSING_TABLE_SIGNATURE
> SIGNATURE_32('S', 'L', 'I', 'C')
>
> ///
> -/// "SPCR" Serial Port Concole Redirection Table
> +/// "SPCR" Serial Port Console Redirection Table
> ///
> #define
> EFI_ACPI_6_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGN
> ATURE SIGNATURE_32('S', 'P', 'C', 'R')
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h
> b/MdePkg/Include/IndustryStandard/Acpi61.h
> index 6fac6506ccfb..985c8273ce61 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi61.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi61.h
> @@ -1169,7 +1169,7 @@ typedef struct {
> ///
> UINT64
> ExitBootServicesEntry;
> ///
> - /// Timer value logged at the point just prior
> towhen the OS loader gaining
> + /// Timer value logged at the point just prior to
> when the OS loader gaining
> /// control back from calls the ExitBootServices
> function for UEFI compatible firmware.
> /// For non-UEFI compatible boots, this field must
> be zero.
> ///
> @@ -2359,7 +2359,7 @@ typedef struct {
> #define
> EFI_ACPI_6_1_SOFTWARE_LICENSING_TABLE_SIGNATURE
> SIGNATURE_32('S', 'L', 'I', 'C')
>
> ///
> -/// "SPCR" Serial Port Concole Redirection Table
> +/// "SPCR" Serial Port Console Redirection Table
> ///
> #define
> EFI_ACPI_6_1_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGN
> ATURE SIGNATURE_32('S', 'P', 'C', 'R')
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h
> b/MdePkg/Include/IndustryStandard/Acpi62.h
> index e60d1dfce6ce..5a5e9b811247 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi62.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi62.h
> @@ -1281,7 +1281,7 @@ typedef struct {
> ///
> UINT64
> ExitBootServicesEntry;
> ///
> - /// Timer value logged at the point just prior
> towhen the OS loader gaining
> + /// Timer value logged at the point just prior to
> when the OS loader gaining
> /// control back from calls the ExitBootServices
> function for UEFI compatible firmware.
> /// For non-UEFI compatible boots, this field must
> be zero.
> ///
> @@ -1650,13 +1650,13 @@ typedef struct {
> #define EFI_ACPI_6_2_SECURE_DEVICES_TABLE_REVISION
> 0x01
>
> ///
> -/// Secure Devcice types
> +/// Secure Device types
> ///
> #define EFI_ACPI_6_2_SDEV_TYPE_PCIE_ENDPOINT_DEVICE
> 0x01
> #define EFI_ACPI_6_2_SDEV_TYPE_ACPI_NAMESPACE_DEVICE
> 0x00
>
> ///
> -/// Secure Devcice flags
> +/// Secure Device flags
> ///
> #define EFI_ACPI_6_2_SDEV_FLAG_ALLOW_HANDOFF
> BIT0
>
> @@ -2890,7 +2890,7 @@ typedef struct {
> #define
> EFI_ACPI_6_2_SOFTWARE_LICENSING_TABLE_SIGNATURE
> SIGNATURE_32('S', 'L', 'I', 'C')
>
> ///
> -/// "SPCR" Serial Port Concole Redirection Table
> +/// "SPCR" Serial Port Console Redirection Table
> ///
> #define
> EFI_ACPI_6_2_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGN
> ATURE SIGNATURE_32('S', 'P', 'C', 'R')
>
> diff --git a/MdePkg/Include/IndustryStandard/Atapi.h
> b/MdePkg/Include/IndustryStandard/Atapi.h
> index 43d0b58ae6ec..d9abe7f28fad 100644
> --- a/MdePkg/Include/IndustryStandard/Atapi.h
> +++ b/MdePkg/Include/IndustryStandard/Atapi.h
> @@ -484,33 +484,33 @@ typedef union {
> //
> // ATA Packet Command Code
> //
> -#define ATA_CMD_FORMAT_UNIT
> 0x04 ///< defined in ATAPI Removable Rewritable Media
> Devcies
> +#define ATA_CMD_FORMAT_UNIT
> 0x04 ///< defined in ATAPI Removable Rewritable Media
> Devices
> #define ATA_CMD_SOFT_RESET
> 0x08 ///< defined from ATA-3
> #define ATA_CMD_PACKET
> 0xA0 ///< defined from ATA-3
> #define ATA_CMD_IDENTIFY_DEVICE
> 0xA1 ///< defined from ATA-3
> #define ATA_CMD_SERVICE
> 0xA2 ///< defined from ATA-3
> #define ATA_CMD_TEST_UNIT_READY
> 0x00 ///< defined from ATA-1
> #define ATA_CMD_REQUEST_SENSE
> 0x03 ///< defined from ATA-4
> -#define ATA_CMD_INQUIRY
> 0x12 ///< defined in ATAPI Removable Rewritable Media
> Devcies
> -#define ATA_CMD_READ_FORMAT_CAPACITY
> 0x23 ///< defined in ATAPI Removable Rewritable Media
> Devcies
> -#define ATA_CMD_READ_CAPACITY
> 0x25 ///< defined in ATAPI Removable Rewritable Media
> Devcies
> -#define ATA_CMD_READ_10
> 0x28 ///< defined in ATAPI Removable Rewritable Media
> Devcies
> -#define ATA_CMD_WRITE_10
> 0x2A ///< defined in ATAPI Removable Rewritable Media
> Devcies
> -#define ATA_CMD_ATAPI_SEEK
> 0x2B ///< defined in ATAPI Removable Rewritable Media
> Devcies
> -#define ATA_CMD_WRITE_AND_VERIFY
> 0x2E ///< defined in ATAPI Removable Rewritable Media
> Devcies
> -#define ATA_CMD_VERIFY
> 0x2F ///< defined in ATAPI Removable Rewritable Media
> Devcies
> -#define ATA_CMD_READ_12
> 0xA8 ///< defined in ATAPI Removable Rewritable Media
> Devcies
> -#define ATA_CMD_WRITE_12
> 0xAA ///< defined in ATAPI Removable Rewritable Media
> Devcies
> -#define ATA_CMD_START_STOP_UNIT
> 0x1B ///< defined in ATAPI Removable Rewritable Media
> Devcies
> -#define ATA_CMD_PREVENT_ALLOW_MEDIA_REMOVAL
> 0x1E ///< defined in ATAPI Removable Rewritable Media
> Devcies
> -#define ATA_CMD_MODE_SELECT
> 0x55 ///< defined in ATAPI Removable Rewritable Media
> Devcies
> +#define ATA_CMD_INQUIRY
> 0x12 ///< defined in ATAPI Removable Rewritable Media
> Devices
> +#define ATA_CMD_READ_FORMAT_CAPACITY
> 0x23 ///< defined in ATAPI Removable Rewritable Media
> Devices
> +#define ATA_CMD_READ_CAPACITY
> 0x25 ///< defined in ATAPI Removable Rewritable Media
> Devices
> +#define ATA_CMD_READ_10
> 0x28 ///< defined in ATAPI Removable Rewritable Media
> Devices
> +#define ATA_CMD_WRITE_10
> 0x2A ///< defined in ATAPI Removable Rewritable Media
> Devices
> +#define ATA_CMD_ATAPI_SEEK
> 0x2B ///< defined in ATAPI Removable Rewritable Media
> Devices
> +#define ATA_CMD_WRITE_AND_VERIFY
> 0x2E ///< defined in ATAPI Removable Rewritable Media
> Devices
> +#define ATA_CMD_VERIFY
> 0x2F ///< defined in ATAPI Removable Rewritable Media
> Devices
> +#define ATA_CMD_READ_12
> 0xA8 ///< defined in ATAPI Removable Rewritable Media
> Devices
> +#define ATA_CMD_WRITE_12
> 0xAA ///< defined in ATAPI Removable Rewritable Media
> Devices
> +#define ATA_CMD_START_STOP_UNIT
> 0x1B ///< defined in ATAPI Removable Rewritable Media
> Devices
> +#define ATA_CMD_PREVENT_ALLOW_MEDIA_REMOVAL
> 0x1E ///< defined in ATAPI Removable Rewritable Media
> Devices
> +#define ATA_CMD_MODE_SELECT
> 0x55 ///< defined in ATAPI Removable Rewritable Media
> Devices
>
> -#define ATA_CMD_MODE_SENSE
> 0x5A ///< defined in ATAPI Removable Rewritable Media
> Devcies
> - #define ATA_PAGE_CODE_READ_WRITE_ERROR
> 0x01 ///< defined in ATAPI Removable Rewritable Media
> Devcies
> - #define ATA_PAGE_CODE_CACHING_PAGE
> 0x08 ///< defined in ATAPI Removable Rewritable Media
> Devcies
> - #define ATA_PAGE_CODE_REMOVABLE_BLOCK_CAPABILITIES
> 0x1B ///< defined in ATAPI Removable Rewritable Media
> Devcies
> - #define ATA_PAGE_CODE_TIMER_PROTECT_PAGE
> 0x1C ///< defined in ATAPI Removable Rewritable Media
> Devcies
> - #define ATA_PAGE_CODE_RETURN_ALL_PAGES
> 0x3F ///< defined in ATAPI Removable Rewritable Media
> Devcies
> +#define ATA_CMD_MODE_SENSE
> 0x5A ///< defined in ATAPI Removable Rewritable Media
> Devices
> + #define ATA_PAGE_CODE_READ_WRITE_ERROR
> 0x01 ///< defined in ATAPI Removable Rewritable Media
> Devices
> + #define ATA_PAGE_CODE_CACHING_PAGE
> 0x08 ///< defined in ATAPI Removable Rewritable Media
> Devices
> + #define ATA_PAGE_CODE_REMOVABLE_BLOCK_CAPABILITIES
> 0x1B ///< defined in ATAPI Removable Rewritable Media
> Devices
> + #define ATA_PAGE_CODE_TIMER_PROTECT_PAGE
> 0x1C ///< defined in ATAPI Removable Rewritable Media
> Devices
> + #define ATA_PAGE_CODE_RETURN_ALL_PAGES
> 0x3F ///< defined in ATAPI Removable Rewritable Media
> Devices
>
> #define ATA_CMD_GET_CONFIGURATION
> 0x46 ///< defined in ATAPI Multimedia Devices
> #define ATA_GCCD_RT_FIELD_VALUE_ALL
> 0x00 ///< defined in ATAPI Multimedia Devices
> diff --git a/MdePkg/Include/IndustryStandard/ElTorito.h
> b/MdePkg/Include/IndustryStandard/ElTorito.h
> index 31d02bcf1339..94b55d842f3c 100644
> --- a/MdePkg/Include/IndustryStandard/ElTorito.h
> +++ b/MdePkg/Include/IndustryStandard/ElTorito.h
> @@ -1,6 +1,6 @@
> /** @file
> ElTorito Partitions Format Definition.
> - This file includes some defintions from
> + This file includes some definitions from
> 1. "El Torito" Bootable CD-ROM Format Specification,
> Version 1.0.
> 2. Volume and File Structure of CDROM for
> Information Interchange,
> Standard ECMA-119. (IS0 9660)
> @@ -75,7 +75,7 @@ typedef union {
> } BootRecordVolume;
>
> ///
> - /// Primary Volumn Descriptor, defined in ISO 9660.
> + /// Primary Volume Descriptor, defined in ISO 9660.
> ///
> struct {
> UINT8 Type;
> diff --git a/MdePkg/Include/IndustryStandard/Emmc.h
> b/MdePkg/Include/IndustryStandard/Emmc.h
> index 2055c4ca18d8..5cfc95800813 100644
> --- a/MdePkg/Include/IndustryStandard/Emmc.h
> +++ b/MdePkg/Include/IndustryStandard/Emmc.h
> @@ -224,7 +224,7 @@ typedef struct {
> UINT8 MinPerfW8B52M; //
> Minimum Write Performance for 8bit at 52MHz [210]
> UINT8 Reserved17; //
> Reserved [211]
> UINT8 SecCount[4]; //
> Sector Count [215:212]
> - UINT8 SleepNotificationTime; //
> Sleep Notification Timout [216]
> + UINT8 SleepNotificationTime; //
> Sleep Notification Timeout [216]
> UINT8 SATimeout; //
> Sleep/awake timeout [217]
> UINT8 ProductionStateAwarenessTimeout; //
> Production state awareness timeout [218]
> UINT8 SCVccq; //
> Sleep current (VCCQ) [219]
> diff --git
> a/MdePkg/Include/IndustryStandard/IpmiNetFnBridge.h
> b/MdePkg/Include/IndustryStandard/IpmiNetFnBridge.h
> index 79af969a20c6..3c2084048481 100644
> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnBridge.h
> +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnBridge.h
> @@ -127,12 +127,12 @@
> //
>
> //
> -// Definitions for Prepare for Discoveery command
> +// Definitions for Prepare for Discovery command
> //
> #define IPMI_BRIDGE_PREPARE_FOR_DISCOVERY 0x10
>
> //
> -// Constants and Structure definitions for "Prepare
> for Discoveery" command to follow here
> +// Constants and Structure definitions for "Prepare
> for Discovery" command to follow here
> //
>
> //
> diff --git a/MdePkg/Include/IndustryStandard/Nvme.h
> b/MdePkg/Include/IndustryStandard/Nvme.h
> index 9468a73d7066..9b19a2074b0d 100644
> --- a/MdePkg/Include/IndustryStandard/Nvme.h
> +++ b/MdePkg/Include/IndustryStandard/Nvme.h
> @@ -309,11 +309,11 @@ typedef struct {
> UINT32 Exlat; /* Exit Latency */
> UINT8 Rrt:5; /* Relative Read
> Throughput */
> UINT8 Rsvd3:3; /* Reserved as of Nvm
> Express 1.1 Spec */
> - UINT8 Rrl:5; /* Relative Read Leatency
> */
> + UINT8 Rrl:5; /* Relative Read Latency
> */
> UINT8 Rsvd4:3; /* Reserved as of Nvm
> Express 1.1 Spec */
> UINT8 Rwt:5; /* Relative Write
> Throughput */
> UINT8 Rsvd5:3; /* Reserved as of Nvm
> Express 1.1 Spec */
> - UINT8 Rwl:5; /* Relative Write Leatency
> */
> + UINT8 Rwl:5; /* Relative Write Latency
> */
> UINT8 Rsvd6:3; /* Reserved as of Nvm
> Express 1.1 Spec */
> UINT8 Rsvd7[16]; /* Reserved as of Nvm
> Express 1.1 Spec */
> } NVME_PSDESCRIPTOR;
> @@ -329,7 +329,7 @@ typedef struct {
> UINT16 Ssvid; /* PCI sub-system vendor
> ID */
> UINT8 Sn[20]; /* Product serial number
> */
>
> - UINT8 Mn[40]; /* Proeduct model number
> */
> + UINT8 Mn[40]; /* Product model number
> */
> UINT8 Fr[8]; /* Firmware Revision */
> UINT8 Rab; /* Recommended
> Arbitration Burst */
> UINT8 Ieee_oui[3]; /* Organization Unique
> Identifier */
> @@ -657,7 +657,7 @@ typedef union {
> //
> typedef struct {
> //
> - // CDW 0, Common to all comnmands
> + // CDW 0, Common to all commands
> //
> UINT8 Opc; // Opcode
> UINT8 Fuse:2; // Fused Operation
> @@ -869,7 +869,7 @@ typedef struct {
> //
> UINT8 AvailableSpareThreshold;
> //
> - // Contains a vendor specific estimate of the
> percentage of NVM subsystem life used based on the
> actual usage and the manufacturer?s prediction of NVM
> life. A value of 100 indicates that the estimated
> endurance of the NVM in the NVM subsystem has been
> consumed, but may not indicate an NVM subsystem
> failure. The value is allowed to exceed 100.
> Percentages greater than 254 shall be represented as
> 255. This value shall be updated once per power-on hour
> (when the controller is not in a sleep state).
> + // Contains a vendor specific estimate of the
> percentage of NVM subsystem life used based on the
> actual usage and the manufacturer's prediction of NVM
> life. A value of 100 indicates that the estimated
> endurance of the NVM in the NVM subsystem has been
> consumed, but may not indicate an NVM subsystem
> failure. The value is allowed to exceed 100.
> Percentages greater than 254 shall be represented as
> 255. This value shall be updated once per power-on hour
> (when the controller is not in a sleep state).
> //
> UINT8 PercentageUsed;
> UINT8 Reserved1[26];
> diff --git a/MdePkg/Include/IndustryStandard/Pci22.h
> b/MdePkg/Include/IndustryStandard/Pci22.h
> index 5fd054c4cfbe..81a854f69577 100644
> --- a/MdePkg/Include/IndustryStandard/Pci22.h
> +++ b/MdePkg/Include/IndustryStandard/Pci22.h
> @@ -5,7 +5,7 @@
> PCI Local Bus Specification, 2.2
> PCI-to-PCI Bridge Architecture Specification,
> Revision 1.2
> PC Card Standard, 8.0
> - PCI Power Management Interface Specifiction,
> Revision 1.2
> + PCI Power Management Interface Specification,
> Revision 1.2
>
> Copyright (c) 2006 - 2018, Intel Corporation. All
> rights reserved.<BR>
> Copyright (c) 2014 - 2015, Hewlett-Packard
> Development Company, L.P.<BR>
> @@ -111,11 +111,11 @@ typedef union {
> } PCI_TYPE_GENERIC;
>
> ///
> -/// CardBus Conroller Configuration Space,
> +/// CardBus Controller Configuration Space,
> /// Section 4.5.1, PC Card Standard. 8.0
> ///
> typedef struct {
> - UINT32 CardBusSocketReg; ///< Cardus
> Socket/ExCA Base
> + UINT32 CardBusSocketReg; ///< Cardbus
> Socket/ExCA Base
> UINT8 Cap_Ptr;
> UINT8 Reserved;
> UINT16 SecondaryStatus; ///< Secondary Status
> @@ -222,7 +222,7 @@ typedef struct {
> #define PCI_IF_8259_PIC 0x00
> #define PCI_IF_ISA_PIC 0x01
> #define PCI_IF_EISA_PIC 0x02
> -#define PCI_IF_APIC_CONTROLLER 0x10 ///<
> I/O APIC interrupt controller , 32 bye none-prefectable
> memory.
> +#define PCI_IF_APIC_CONTROLLER 0x10 ///<
> I/O APIC interrupt controller , 32 byte none-
> prefetchable memory.
> #define PCI_IF_APIC_CONTROLLER2 0x20
> #define PCI_SUBCLASS_DMA 0x01
> #define PCI_IF_8237_DMA 0x00
> @@ -509,7 +509,7 @@ typedef struct {
> #define IS_PCI_MULTI_FUNC(_p) ((_p)-
> >Hdr.HeaderType & HEADER_TYPE_MULTI_FUNCTION)
>
> ///
> -/// Rom Base Address in Bridge, defined in PCI-to-PCI
> Bridge Architecure Specification,
> +/// Rom Base Address in Bridge, defined in PCI-to-PCI
> Bridge Architecture Specification,
> ///
> #define PCI_BRIDGE_ROMBAR 0x38
>
> @@ -642,7 +642,7 @@ typedef struct {
>
> ///
> /// PMC - Power Management Capabilities
> -/// Section 3.2.3, PCI Power Management Interface
> Specifiction, Revision 1.2
> +/// Section 3.2.3, PCI Power Management Interface
> Specification, Revision 1.2
> ///
> typedef union {
> struct {
> @@ -662,7 +662,7 @@ typedef union {
>
> ///
> /// PMCSR - Power Management Control/Status
> -/// Section 3.2.4, PCI Power Management Interface
> Specifiction, Revision 1.2
> +/// Section 3.2.4, PCI Power Management Interface
> Specification, Revision 1.2
> ///
> typedef union {
> struct {
> @@ -685,7 +685,7 @@ typedef union {
>
> ///
> /// PMCSR_BSE - PMCSR PCI-to-PCI Bridge Support
> Extensions
> -/// Section 3.2.5, PCI Power Management Interface
> Specifiction, Revision 1.2
> +/// Section 3.2.5, PCI Power Management Interface
> Specification, Revision 1.2
> ///
> typedef union {
> struct {
> @@ -698,7 +698,7 @@ typedef union {
>
> ///
> /// Power Management Register Block Definition
> -/// Section 3.2, PCI Power Management Interface
> Specifiction, Revision 1.2
> +/// Section 3.2, PCI Power Management Interface
> Specification, Revision 1.2
> ///
> typedef struct {
> EFI_PCI_CAPABILITY_HDR Hdr;
> @@ -732,7 +732,7 @@ typedef struct {
>
> ///
> /// Slot Numbering Capabilities Register
> -/// Section 3.2.6, PCI-to-PCI Bridge Architeture
> Specification, Revision 1.2
> +/// Section 3.2.6, PCI-to-PCI Bridge Architecture
> Specification, Revision 1.2
> ///
> typedef struct {
> EFI_PCI_CAPABILITY_HDR Hdr;
> diff --git a/MdePkg/Include/IndustryStandard/PeImage.h
> b/MdePkg/Include/IndustryStandard/PeImage.h
> index 720bb084ac42..a3d9bbed757b 100644
> --- a/MdePkg/Include/IndustryStandard/PeImage.h
> +++ b/MdePkg/Include/IndustryStandard/PeImage.h
> @@ -92,7 +92,7 @@ typedef struct {
> //
> #define EFI_IMAGE_FILE_RELOCS_STRIPPED BIT0
> ///< 0x0001 Relocation info stripped from file.
> #define EFI_IMAGE_FILE_EXECUTABLE_IMAGE BIT1
> ///< 0x0002 File is executable (i.e. no unresolved
> externel references).
> -#define EFI_IMAGE_FILE_LINE_NUMS_STRIPPED BIT2
> ///< 0x0004 Line nunbers stripped from file.
> +#define EFI_IMAGE_FILE_LINE_NUMS_STRIPPED BIT2
> ///< 0x0004 Line numbers stripped from file.
> #define EFI_IMAGE_FILE_LOCAL_SYMS_STRIPPED BIT3
> ///< 0x0008 Local symbols stripped from file.
> #define EFI_IMAGE_FILE_BYTES_REVERSED_LO BIT7
> ///< 0x0080 Bytes of machine word are reversed.
> #define EFI_IMAGE_FILE_32BIT_MACHINE BIT8
> ///< 0x0100 32 bit word machine.
> diff --git a/MdePkg/Include/IndustryStandard/Scsi.h
> b/MdePkg/Include/IndustryStandard/Scsi.h
> index d03886417f86..3e966520a185 100644
> --- a/MdePkg/Include/IndustryStandard/Scsi.h
> +++ b/MdePkg/Include/IndustryStandard/Scsi.h
> @@ -154,7 +154,7 @@
> #define EFI_SCSI_OP_SEND_VOL_TAG 0xb6
>
> //
> -// Additional commands for Communition Devices
> +// Additional commands for Communication Devices
> //
> #define EFI_SCSI_OP_GET_MESSAGE6 0x08
> #define EFI_SCSI_OP_GET_MESSAGE10 0x28
> diff --git a/MdePkg/Include/IndustryStandard/SmBus.h
> b/MdePkg/Include/IndustryStandard/SmBus.h
> index f5d6e5ef9b7d..024a7ba67a06 100644
> --- a/MdePkg/Include/IndustryStandard/SmBus.h
> +++ b/MdePkg/Include/IndustryStandard/SmBus.h
> @@ -1,5 +1,5 @@
> /** @file
> - This file declares the SMBus definitions defined in
> SmBus Specifciation V2.0
> + This file declares the SMBus definitions defined in
> SmBus Specification V2.0
> and defined in PI1.0 specification volume 5.
>
> Copyright (c) 2007 - 2018, Intel Corporation. All
> rights reserved.<BR>
> diff --git a/MdePkg/Include/IndustryStandard/Tpm12.h
> b/MdePkg/Include/IndustryStandard/Tpm12.h
> index 2537c192b3f8..e85a567e83be 100644
> --- a/MdePkg/Include/IndustryStandard/Tpm12.h
> +++ b/MdePkg/Include/IndustryStandard/Tpm12.h
> @@ -597,7 +597,7 @@ typedef struct
> tdTPM_CHANGEAUTH_VALIDATE {
>
> ///
> /// Part 2, section 5.12: TPM_MIGRATIONKEYAUTH
> -/// decalared after section 10 to catch declaration
> of TPM_PUBKEY
> +/// declared after section 10 to catch declaration
> of TPM_PUBKEY
> ///
> /// Part 2 section 10.1: TPM_KEY_PARMS
> /// [size_is(parmSize)] BYTE* parms;
> --
> 2.21.0
^ permalink raw reply [flat|nested] 122+ messages in thread
* [PATCH 26/79] MdePkg/Library/Dxe: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (24 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 25/79] MdePkg/IndustryStandard: " Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-04 1:24 ` [edk2-devel] " Michael D Kinney
2019-12-03 16:15 ` [PATCH 27/79] MdePkg/Library/Pci: " Philippe Mathieu-Daudé
` (46 subsequent siblings)
72 siblings, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Michael D Kinney, Liming Gao,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in documentation, comments and strings,
and remove the duplicated 'the'.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdePkg/Library/DxePcdLib/DxePcdLib.inf | 2 +-
MdePkg/Include/Library/DxeServicesLib.h | 2 +-
| 10 +++++-----
MdePkg/Library/DxeHobLib/HobLib.c | 2 +-
MdePkg/Library/DxeIoLibCpuIo2/IoLib.c | 2 +-
MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.c | 6 +++---
MdePkg/Library/DxeServicesLib/DxeServicesLib.c | 12 ++++++------
MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.c | 2 +-
MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c | 2 +-
MdePkg/Library/DxePcdLib/DxePcdLib.uni | 2 +-
10 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/MdePkg/Library/DxePcdLib/DxePcdLib.inf b/MdePkg/Library/DxePcdLib/DxePcdLib.inf
index c3f67543a4b7..3d4d21b442b4 100644
--- a/MdePkg/Library/DxePcdLib/DxePcdLib.inf
+++ b/MdePkg/Library/DxePcdLib/DxePcdLib.inf
@@ -16,7 +16,7 @@
# Note: A driver of type DXE_RUNTIME_DRIVER and DXE_SMM_DRIVER can only use this DxePcdLib
# in their initialization without any issues to access Dynamic and DynamicEx PCD. They can't
# access Dynamic and DynamicEx PCD in the implementation of runtime services and SMI handlers.
-# Because EFI_PCD_PROTOCOL is DXE protocol that is not aviable in OS runtime phase.
+# Because EFI_PCD_PROTOCOL is DXE protocol that is not available in OS runtime phase.
#
# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
#
diff --git a/MdePkg/Include/Library/DxeServicesLib.h b/MdePkg/Include/Library/DxeServicesLib.h
index 838abf356fdd..689f47a54fa1 100644
--- a/MdePkg/Include/Library/DxeServicesLib.h
+++ b/MdePkg/Include/Library/DxeServicesLib.h
@@ -171,7 +171,7 @@ GetSectionFromFv (
/**
- Searches the FFS file the the currently executing module was loaded from and returns the first matching FFS section.
+ Searches the FFS file the currently executing module was loaded from and returns the first matching FFS section.
This function searches the FFS file that the currently executing module was loaded from for a FFS sections of type SectionType.
If the FFS file contains at least SectionInstance instances of the FFS section specified by SectionType,
--git a/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.c b/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.c
index 4dfe450be9bc..ef730ec55159 100644
--- a/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.c
+++ b/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.c
@@ -150,7 +150,7 @@ ExtractGuidedSectionGetGuidList (
If GetInfoHandler is NULL, then ASSERT().
If DecodeHandler is NULL, then ASSERT().
- @param[in] SectionGuid A pointer to the GUID associated with the the handlers
+ @param[in] SectionGuid A pointer to the GUID associated with the handlers
of the GUIDed section type being registered.
@param[in] GetInfoHandler The pointer to a function that examines a GUIDed section and returns the
size of the decoded buffer and the size of an optional scratch buffer
@@ -231,9 +231,9 @@ ExtractGuidedSectionRegisterHandlers (
Examines a GUIDed section specified by InputSection.
If GUID for InputSection does not match any of the GUIDs registered through ExtractGuidedSectionRegisterHandlers(),
then RETURN_UNSUPPORTED is returned.
- If the GUID of InputSection does match the GUID that this handler supports, then the the associated handler
+ If the GUID of InputSection does match the GUID that this handler supports, then the associated handler
of type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER that was registered with ExtractGuidedSectionRegisterHandlers()
- is used to retrieve the OututBufferSize, ScratchSize, and Attributes values. The return status from the handler of
+ is used to retrieve the OutputBufferSize, ScratchSize, and Attributes values. The return status from the handler of
type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER is returned.
If InputSection is NULL, then ASSERT().
@@ -311,7 +311,7 @@ ExtractGuidedSectionGetInfo (
Decodes the GUIDed section specified by InputSection.
If GUID for InputSection does not match any of the GUIDs registered through ExtractGuidedSectionRegisterHandlers(),
then RETURN_UNSUPPORTED is returned.
- If the GUID of InputSection does match the GUID that this handler supports, then the the associated handler
+ If the GUID of InputSection does match the GUID that this handler supports, then the associated handler
of type EXTRACT_GUIDED_SECTION_DECODE_HANDLER that was registered with ExtractGuidedSectionRegisterHandlers()
is used to decode InputSection into the buffer specified by OutputBuffer and the authentication status of this
decode operation is returned in AuthenticationStatus. If the decoded buffer is identical to the data in InputSection,
@@ -397,7 +397,7 @@ ExtractGuidedSectionDecode (
If SectionGuid is NULL, then ASSERT().
- @param[in] SectionGuid A pointer to the GUID associated with the handlersof the GUIDed
+ @param[in] SectionGuid A pointer to the GUID associated with the handlers of the GUIDed
section type being retrieved.
@param[out] GetInfoHandler Pointer to a function that examines a GUIDed section and returns
the size of the decoded buffer and the size of an optional scratch
diff --git a/MdePkg/Library/DxeHobLib/HobLib.c b/MdePkg/Library/DxeHobLib/HobLib.c
index bf2470f6e278..ffac638d1806 100644
--- a/MdePkg/Library/DxeHobLib/HobLib.c
+++ b/MdePkg/Library/DxeHobLib/HobLib.c
@@ -1,5 +1,5 @@
/** @file
- HOB Library implemenation for Dxe Phase.
+ HOB Library implementation for Dxe Phase.
Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
diff --git a/MdePkg/Library/DxeIoLibCpuIo2/IoLib.c b/MdePkg/Library/DxeIoLibCpuIo2/IoLib.c
index b37e7a299e8a..21f88d98527c 100644
--- a/MdePkg/Library/DxeIoLibCpuIo2/IoLib.c
+++ b/MdePkg/Library/DxeIoLibCpuIo2/IoLib.c
@@ -11,7 +11,7 @@
#include "DxeCpuIo2LibInternal.h"
//
-// Globle varible to cache pointer to CpuIo2 protocol.
+// Global variable to cache pointer to CpuIo2 protocol.
//
EFI_CPU_IO2_PROTOCOL *mCpuIo = NULL;
diff --git a/MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.c b/MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.c
index 6e784763be73..b456b676bddc 100644
--- a/MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.c
+++ b/MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.c
@@ -299,7 +299,7 @@ PciExpressRegisterForRuntimeAccess (
Address = GetPciExpressAddress (Address & 0x0ffff000);
//
- // See if Address has already been registerd for runtime access
+ // See if Address has already been registered for runtime access
//
for (Index = 0; Index < mDxeRuntimePciExpressLibNumberOfRuntimeRanges; Index++) {
if (mDxeRuntimePciExpressLibRegistrationTable[Index].PhysicalAddress == Address) {
@@ -1457,7 +1457,7 @@ PciExpressBitFieldAndThenOr32 (
Size into the buffer specified by Buffer. This function only allows the PCI
configuration registers from a single PCI function to be read. Size is
returned. When possible 32-bit PCI configuration read cycles are used to read
- from StartAdress to StartAddress + Size. Due to alignment restrictions, 8-bit
+ from StartAddress to StartAddress + Size. Due to alignment restrictions, 8-bit
and 16-bit PCI configuration read cycles may be used at the beginning and the
end of the range.
@@ -1560,7 +1560,7 @@ PciExpressReadBuffer (
Size from the buffer specified by Buffer. This function only allows the PCI
configuration registers from a single PCI function to be written. Size is
returned. When possible 32-bit PCI configuration write cycles are used to
- write from StartAdress to StartAddress + Size. Due to alignment restrictions,
+ write from StartAddress to StartAddress + Size. Due to alignment restrictions,
8-bit and 16-bit PCI configuration write cycles may be used at the beginning
and the end of the range.
diff --git a/MdePkg/Library/DxeServicesLib/DxeServicesLib.c b/MdePkg/Library/DxeServicesLib/DxeServicesLib.c
index 0735b2f80400..3e3bbf605533 100644
--- a/MdePkg/Library/DxeServicesLib/DxeServicesLib.c
+++ b/MdePkg/Library/DxeServicesLib/DxeServicesLib.c
@@ -25,7 +25,7 @@
/**
Identify the device handle from which the Image is loaded from. As this device handle is passed to
GetSectionFromFv as the identifier for a Firmware Volume, an EFI_FIRMWARE_VOLUME2_PROTOCOL
- protocol instance should be located succesfully by calling gBS->HandleProtocol ().
+ protocol instance should be located successfully by calling gBS->HandleProtocol ().
This function locates the EFI_LOADED_IMAGE_PROTOCOL instance installed
on ImageHandle. It then returns EFI_LOADED_IMAGE_PROTOCOL.DeviceHandle.
@@ -71,7 +71,7 @@ InternalImageHandleToFvHandle (
Section type and instance number from the specified Firmware Volume.
This functions first locate the EFI_FIRMWARE_VOLUME2_PROTOCOL protocol instance on FvHandle in order to
- carry out the Firmware Volume read operation. The function then reads the Firmware Section found sepcifed
+ carry out the Firmware Volume read operation. The function then reads the Firmware Section found specified
by NameGuid, SectionType and SectionInstance.
The details of this search order is defined in description of EFI_FIRMWARE_VOLUME2_PROTOCOL.ReadSection ()
@@ -94,7 +94,7 @@ InternalImageHandleToFvHandle (
@param SectionType The Firmware Section type.
@param SectionInstance The instance number of Firmware Section to
read from starting from 0.
- @param Buffer On output, Buffer contains the the data read
+ @param Buffer On output, Buffer contains the data read
from the section in the Firmware File found.
@param Size On output, the size of Buffer.
@@ -517,7 +517,7 @@ GetSectionFromFv (
/**
- Searches the FFS file the the currently executing module was loaded from and returns the first matching FFS section.
+ Searches the FFS file the currently executing module was loaded from and returns the first matching FFS section.
This function searches the FFS file that the currently executing module was loaded from for a FFS sections of type SectionType.
If the FFS file contains at least SectionInstance instances of the FFS section specified by SectionType,
@@ -597,7 +597,7 @@ GetSectionFromFfs (
selection. If FALSE, then FilePath must
match an exact file to be loaded.
@param[in] FilePath The pointer to the device path of the file
- that is absracted to the file buffer.
+ that is abstracted to the file buffer.
@param[out] FileSize The pointer to the size of the abstracted
file buffer.
@param[out] AuthenticationStatus Pointer to the authentication status.
@@ -745,7 +745,7 @@ GetFileBufferByFilePath (
}
//
// Parse each MEDIA_FILEPATH_DP node. There may be more than one, since the
- // directory information and filename can be seperate. The goal is to inch
+ // directory information and filename can be separate. The goal is to inch
// our way down each device path node and close the previous node
//
DevicePathNode = TempDevicePathNode;
diff --git a/MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.c b/MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.c
index 6783e4d75489..9acb1b79b391 100644
--- a/MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.c
+++ b/MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.c
@@ -9,7 +9,7 @@
Please attention this library instance can not be used util EFI_SYSTEM_TABLE was
initialized.
- This library contains contruct function to retrieve EFI_DXE_SERIVCE, this construct
+ This library contains construct function to retrieve EFI_DXE_SERVICE, this construct
function will be invoked in DXE driver's autogen file.
Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
diff --git a/MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c b/MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c
index f6e3d4508f47..d9cca7eb5fa8 100644
--- a/MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c
+++ b/MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c
@@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
//
-// Globle varible to cache pointer to Smbus protocol.
+// Global variable to cache pointer to Smbus protocol.
//
EFI_SMBUS_HC_PROTOCOL *mSmbus = NULL;
diff --git a/MdePkg/Library/DxePcdLib/DxePcdLib.uni b/MdePkg/Library/DxePcdLib/DxePcdLib.uni
index 889f427e5ffd..c48aea35db95 100644
--- a/MdePkg/Library/DxePcdLib/DxePcdLib.uni
+++ b/MdePkg/Library/DxePcdLib/DxePcdLib.uni
@@ -22,5 +22,5 @@
#string STR_MODULE_ABSTRACT #language en-US "PCD Library using PCD Protocol"
-#string STR_MODULE_DESCRIPTION #language en-US "There are two PCD protocols: 1) PCD_PROTOCOL It is an EDKII implementation that supporst Dynamic/DynamicEx PCDs. 2) EFI_PCD_PROTOCOL It is defined by PI Specification 1.2, Vol 3, which only support dynamicEx type PCD. For dynamicEx type PCDs, it is compatible between PCD_PROTOCOL and EFI_PCD_PROTOCOL. This library instance uses the PCD_PROTOCOL to handle dynamic PCD requests and uses EFI_PCD_PROTOCOL to handle DynamicEx type PCDs."
+#string STR_MODULE_DESCRIPTION #language en-US "There are two PCD protocols: 1) PCD_PROTOCOL It is an EDKII implementation that supports Dynamic/DynamicEx PCDs. 2) EFI_PCD_PROTOCOL It is defined by PI Specification 1.2, Vol 3, which only support dynamicEx type PCD. For dynamicEx type PCDs, it is compatible between PCD_PROTOCOL and EFI_PCD_PROTOCOL. This library instance uses the PCD_PROTOCOL to handle dynamic PCD requests and uses EFI_PCD_PROTOCOL to handle DynamicEx type PCDs."
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [edk2-devel] [PATCH 26/79] MdePkg/Library/Dxe: Fix various typos
2019-12-03 16:15 ` [PATCH 26/79] MdePkg/Library/Dxe: " Philippe Mathieu-Daudé
@ 2019-12-04 1:24 ` Michael D Kinney
0 siblings, 0 replies; 122+ messages in thread
From: Michael D Kinney @ 2019-12-04 1:24 UTC (permalink / raw)
To: devel@edk2.groups.io, philmd@redhat.com, Kinney, Michael D
Cc: Antoine Coeur, Gao, Liming
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Philippe Mathieu-Daudé
> Sent: Tuesday, December 3, 2019 8:15 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Philippe Mathieu-Daude
> <philmd@redhat.com>
> Subject: [edk2-devel] [PATCH 26/79] MdePkg/Library/Dxe:
> Fix various typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in documentation, comments and
> strings,
> and remove the duplicated 'the'.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude
> <philmd@redhat.com>
> ---
> MdePkg/Library/DxePcdLib/DxePcdLib.inf
> | 2 +-
> MdePkg/Include/Library/DxeServicesLib.h
> | 2 +-
>
> MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGui
> dedSectionLib.c | 10 +++++-----
> MdePkg/Library/DxeHobLib/HobLib.c
> | 2 +-
> MdePkg/Library/DxeIoLibCpuIo2/IoLib.c
> | 2 +-
> MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.c
> | 6 +++---
> MdePkg/Library/DxeServicesLib/DxeServicesLib.c
> | 12 ++++++------
>
> MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.
> c | 2 +-
> MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c
> | 2 +-
> MdePkg/Library/DxePcdLib/DxePcdLib.uni
> | 2 +-
> 10 files changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/MdePkg/Library/DxePcdLib/DxePcdLib.inf
> b/MdePkg/Library/DxePcdLib/DxePcdLib.inf
> index c3f67543a4b7..3d4d21b442b4 100644
> --- a/MdePkg/Library/DxePcdLib/DxePcdLib.inf
> +++ b/MdePkg/Library/DxePcdLib/DxePcdLib.inf
> @@ -16,7 +16,7 @@
> # Note: A driver of type DXE_RUNTIME_DRIVER and
> DXE_SMM_DRIVER can only use this DxePcdLib
> # in their initialization without any issues to
> access Dynamic and DynamicEx PCD. They can't
> # access Dynamic and DynamicEx PCD in the
> implementation of runtime services and SMI handlers.
> -# Because EFI_PCD_PROTOCOL is DXE protocol that is
> not aviable in OS runtime phase.
> +# Because EFI_PCD_PROTOCOL is DXE protocol that is
> not available in OS runtime phase.
> #
> # Copyright (c) 2007 - 2018, Intel Corporation. All
> rights reserved.<BR>
> #
> diff --git a/MdePkg/Include/Library/DxeServicesLib.h
> b/MdePkg/Include/Library/DxeServicesLib.h
> index 838abf356fdd..689f47a54fa1 100644
> --- a/MdePkg/Include/Library/DxeServicesLib.h
> +++ b/MdePkg/Include/Library/DxeServicesLib.h
> @@ -171,7 +171,7 @@ GetSectionFromFv (
>
>
> /**
> - Searches the FFS file the the currently executing
> module was loaded from and returns the first matching
> FFS section.
> + Searches the FFS file the currently executing module
> was loaded from and returns the first matching FFS
> section.
>
> This function searches the FFS file that the
> currently executing module was loaded from for a FFS
> sections of type SectionType.
> If the FFS file contains at least SectionInstance
> instances of the FFS section specified by SectionType,
> diff --git
> a/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractG
> uidedSectionLib.c
> b/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractG
> uidedSectionLib.c
> index 4dfe450be9bc..ef730ec55159 100644
> ---
> a/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractG
> uidedSectionLib.c
> +++
> b/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractG
> uidedSectionLib.c
> @@ -150,7 +150,7 @@ ExtractGuidedSectionGetGuidList (
> If GetInfoHandler is NULL, then ASSERT().
> If DecodeHandler is NULL, then ASSERT().
>
> - @param[in] SectionGuid A pointer to the GUID
> associated with the the handlers
> + @param[in] SectionGuid A pointer to the GUID
> associated with the handlers
> of the GUIDed section
> type being registered.
> @param[in] GetInfoHandler The pointer to a function
> that examines a GUIDed section and returns the
> size of the decoded
> buffer and the size of an optional scratch buffer
> @@ -231,9 +231,9 @@
> ExtractGuidedSectionRegisterHandlers (
> Examines a GUIDed section specified by InputSection.
> If GUID for InputSection does not match any of the
> GUIDs registered through
> ExtractGuidedSectionRegisterHandlers(),
> then RETURN_UNSUPPORTED is returned.
> - If the GUID of InputSection does match the GUID that
> this handler supports, then the the associated handler
> + If the GUID of InputSection does match the GUID that
> this handler supports, then the associated handler
> of type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER that
> was registered with
> ExtractGuidedSectionRegisterHandlers()
> - is used to retrieve the OututBufferSize,
> ScratchSize, and Attributes values. The return status
> from the handler of
> + is used to retrieve the OutputBufferSize,
> ScratchSize, and Attributes values. The return status
> from the handler of
> type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER is
> returned.
>
> If InputSection is NULL, then ASSERT().
> @@ -311,7 +311,7 @@ ExtractGuidedSectionGetInfo (
> Decodes the GUIDed section specified by
> InputSection.
> If GUID for InputSection does not match any of the
> GUIDs registered through
> ExtractGuidedSectionRegisterHandlers(),
> then RETURN_UNSUPPORTED is returned.
> - If the GUID of InputSection does match the GUID that
> this handler supports, then the the associated handler
> + If the GUID of InputSection does match the GUID that
> this handler supports, then the associated handler
> of type EXTRACT_GUIDED_SECTION_DECODE_HANDLER that
> was registered with
> ExtractGuidedSectionRegisterHandlers()
> is used to decode InputSection into the buffer
> specified by OutputBuffer and the authentication status
> of this
> decode operation is returned in
> AuthenticationStatus. If the decoded buffer is
> identical to the data in InputSection,
> @@ -397,7 +397,7 @@ ExtractGuidedSectionDecode (
>
> If SectionGuid is NULL, then ASSERT().
>
> - @param[in] SectionGuid A pointer to the GUID
> associated with the handlersof the GUIDed
> + @param[in] SectionGuid A pointer to the GUID
> associated with the handlers of the GUIDed
> section type being
> retrieved.
> @param[out] GetInfoHandler Pointer to a function
> that examines a GUIDed section and returns
> the size of the decoded
> buffer and the size of an optional scratch
> diff --git a/MdePkg/Library/DxeHobLib/HobLib.c
> b/MdePkg/Library/DxeHobLib/HobLib.c
> index bf2470f6e278..ffac638d1806 100644
> --- a/MdePkg/Library/DxeHobLib/HobLib.c
> +++ b/MdePkg/Library/DxeHobLib/HobLib.c
> @@ -1,5 +1,5 @@
> /** @file
> - HOB Library implemenation for Dxe Phase.
> + HOB Library implementation for Dxe Phase.
>
> Copyright (c) 2006 - 2018, Intel Corporation. All
> rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> diff --git a/MdePkg/Library/DxeIoLibCpuIo2/IoLib.c
> b/MdePkg/Library/DxeIoLibCpuIo2/IoLib.c
> index b37e7a299e8a..21f88d98527c 100644
> --- a/MdePkg/Library/DxeIoLibCpuIo2/IoLib.c
> +++ b/MdePkg/Library/DxeIoLibCpuIo2/IoLib.c
> @@ -11,7 +11,7 @@
> #include "DxeCpuIo2LibInternal.h"
>
> //
> -// Globle varible to cache pointer to CpuIo2 protocol.
> +// Global variable to cache pointer to CpuIo2
> protocol.
> //
> EFI_CPU_IO2_PROTOCOL *mCpuIo = NULL;
>
> diff --git
> a/MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.
> c
> b/MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.
> c
> index 6e784763be73..b456b676bddc 100644
> ---
> a/MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.
> c
> +++
> b/MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.
> c
> @@ -299,7 +299,7 @@ PciExpressRegisterForRuntimeAccess
> (
> Address = GetPciExpressAddress (Address &
> 0x0ffff000);
>
> //
> - // See if Address has already been registerd for
> runtime access
> + // See if Address has already been registered for
> runtime access
> //
> for (Index = 0; Index <
> mDxeRuntimePciExpressLibNumberOfRuntimeRanges; Index++)
> {
> if
> (mDxeRuntimePciExpressLibRegistrationTable[Index].Physi
> calAddress == Address) {
> @@ -1457,7 +1457,7 @@ PciExpressBitFieldAndThenOr32 (
> Size into the buffer specified by Buffer. This
> function only allows the PCI
> configuration registers from a single PCI function
> to be read. Size is
> returned. When possible 32-bit PCI configuration
> read cycles are used to read
> - from StartAdress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
> + from StartAddress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
> and 16-bit PCI configuration read cycles may be used
> at the beginning and the
> end of the range.
>
> @@ -1560,7 +1560,7 @@ PciExpressReadBuffer (
> Size from the buffer specified by Buffer. This
> function only allows the PCI
> configuration registers from a single PCI function
> to be written. Size is
> returned. When possible 32-bit PCI configuration
> write cycles are used to
> - write from StartAdress to StartAddress + Size. Due
> to alignment restrictions,
> + write from StartAddress to StartAddress + Size. Due
> to alignment restrictions,
> 8-bit and 16-bit PCI configuration write cycles may
> be used at the beginning
> and the end of the range.
>
> diff --git
> a/MdePkg/Library/DxeServicesLib/DxeServicesLib.c
> b/MdePkg/Library/DxeServicesLib/DxeServicesLib.c
> index 0735b2f80400..3e3bbf605533 100644
> --- a/MdePkg/Library/DxeServicesLib/DxeServicesLib.c
> +++ b/MdePkg/Library/DxeServicesLib/DxeServicesLib.c
> @@ -25,7 +25,7 @@
> /**
> Identify the device handle from which the Image is
> loaded from. As this device handle is passed to
> GetSectionFromFv as the identifier for a Firmware
> Volume, an EFI_FIRMWARE_VOLUME2_PROTOCOL
> - protocol instance should be located succesfully by
> calling gBS->HandleProtocol ().
> + protocol instance should be located successfully by
> calling gBS->HandleProtocol ().
>
> This function locates the EFI_LOADED_IMAGE_PROTOCOL
> instance installed
> on ImageHandle. It then returns
> EFI_LOADED_IMAGE_PROTOCOL.DeviceHandle.
> @@ -71,7 +71,7 @@ InternalImageHandleToFvHandle (
> Section type and instance number from the specified
> Firmware Volume.
>
> This functions first locate the
> EFI_FIRMWARE_VOLUME2_PROTOCOL protocol instance on
> FvHandle in order to
> - carry out the Firmware Volume read operation. The
> function then reads the Firmware Section found sepcifed
> + carry out the Firmware Volume read operation. The
> function then reads the Firmware Section found
> specified
> by NameGuid, SectionType and SectionInstance.
>
> The details of this search order is defined in
> description of
> EFI_FIRMWARE_VOLUME2_PROTOCOL.ReadSection ()
> @@ -94,7 +94,7 @@ InternalImageHandleToFvHandle (
> @param SectionType The Firmware Section
> type.
> @param SectionInstance The instance number
> of Firmware Section to
> read from starting
> from 0.
> - @param Buffer On output, Buffer
> contains the the data read
> + @param Buffer On output, Buffer
> contains the data read
> from the section in
> the Firmware File found.
> @param Size On output, the size
> of Buffer.
>
> @@ -517,7 +517,7 @@ GetSectionFromFv (
>
>
> /**
> - Searches the FFS file the the currently executing
> module was loaded from and returns the first matching
> FFS section.
> + Searches the FFS file the currently executing module
> was loaded from and returns the first matching FFS
> section.
>
> This function searches the FFS file that the
> currently executing module was loaded from for a FFS
> sections of type SectionType.
> If the FFS file contains at least SectionInstance
> instances of the FFS section specified by SectionType,
> @@ -597,7 +597,7 @@ GetSectionFromFfs (
> selection. If
> FALSE, then FilePath must
> match an exact
> file to be loaded.
> @param[in] FilePath The pointer to
> the device path of the file
> - that is
> absracted to the file buffer.
> + that is
> abstracted to the file buffer.
> @param[out] FileSize The pointer to
> the size of the abstracted
> file buffer.
> @param[out] AuthenticationStatus Pointer to the
> authentication status.
> @@ -745,7 +745,7 @@ GetFileBufferByFilePath (
> }
> //
> // Parse each MEDIA_FILEPATH_DP node. There
> may be more than one, since the
> - // directory information and filename can be
> seperate. The goal is to inch
> + // directory information and filename can be
> separate. The goal is to inch
> // our way down each device path node and
> close the previous node
> //
> DevicePathNode = TempDevicePathNode;
> diff --git
> a/MdePkg/Library/DxeServicesTableLib/DxeServicesTableLi
> b.c
> b/MdePkg/Library/DxeServicesTableLib/DxeServicesTableLi
> b.c
> index 6783e4d75489..9acb1b79b391 100644
> ---
> a/MdePkg/Library/DxeServicesTableLib/DxeServicesTableLi
> b.c
> +++
> b/MdePkg/Library/DxeServicesTableLib/DxeServicesTableLi
> b.c
> @@ -9,7 +9,7 @@
> Please attention this library instance can not be
> used util EFI_SYSTEM_TABLE was
> initialized.
>
> - This library contains contruct function to retrieve
> EFI_DXE_SERIVCE, this construct
> + This library contains construct function to retrieve
> EFI_DXE_SERVICE, this construct
> function will be invoked in DXE driver's autogen
> file.
>
> Copyright (c) 2006 - 2018, Intel Corporation. All
> rights reserved.<BR>
> diff --git a/MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c
> b/MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c
> index f6e3d4508f47..d9cca7eb5fa8 100644
> --- a/MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c
> +++ b/MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c
> @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-
> Clause-Patent
>
>
> //
> -// Globle varible to cache pointer to Smbus protocol.
> +// Global variable to cache pointer to Smbus protocol.
> //
> EFI_SMBUS_HC_PROTOCOL *mSmbus = NULL;
>
> diff --git a/MdePkg/Library/DxePcdLib/DxePcdLib.uni
> b/MdePkg/Library/DxePcdLib/DxePcdLib.uni
> index 889f427e5ffd..c48aea35db95 100644
> --- a/MdePkg/Library/DxePcdLib/DxePcdLib.uni
> +++ b/MdePkg/Library/DxePcdLib/DxePcdLib.uni
> @@ -22,5 +22,5 @@
>
> #string STR_MODULE_ABSTRACT #language en-
> US "PCD Library using PCD Protocol"
>
> -#string STR_MODULE_DESCRIPTION #language en-
> US "There are two PCD protocols: 1) PCD_PROTOCOL It is
> an EDKII implementation that supporst Dynamic/DynamicEx
> PCDs. 2) EFI_PCD_PROTOCOL It is defined by PI
> Specification 1.2, Vol 3, which only support dynamicEx
> type PCD. For dynamicEx type PCDs, it is compatible
> between PCD_PROTOCOL and EFI_PCD_PROTOCOL. This
> library instance uses the PCD_PROTOCOL to handle
> dynamic PCD requests and uses EFI_PCD_PROTOCOL to
> handle DynamicEx type PCDs."
> +#string STR_MODULE_DESCRIPTION #language en-
> US "There are two PCD protocols: 1) PCD_PROTOCOL It is
> an EDKII implementation that supports Dynamic/DynamicEx
> PCDs. 2) EFI_PCD_PROTOCOL It is defined by PI
> Specification 1.2, Vol 3, which only support dynamicEx
> type PCD. For dynamicEx type PCDs, it is compatible
> between PCD_PROTOCOL and EFI_PCD_PROTOCOL. This
> library instance uses the PCD_PROTOCOL to handle
> dynamic PCD requests and uses EFI_PCD_PROTOCOL to
> handle DynamicEx type PCDs."
>
> --
> 2.21.0
>
>
>
^ permalink raw reply [flat|nested] 122+ messages in thread
* [PATCH 27/79] MdePkg/Library/Pci: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (25 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 26/79] MdePkg/Library/Dxe: " Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-04 1:25 ` [edk2-devel] " Michael D Kinney
2019-12-03 16:15 ` [PATCH 28/79] MdePkg/Library/Smm: " Philippe Mathieu-Daudé
` (45 subsequent siblings)
72 siblings, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Michael D Kinney, Liming Gao,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdePkg/Include/Library/PciCf8Lib.h | 4 ++--
MdePkg/Include/Library/PciExpressLib.h | 4 ++--
MdePkg/Include/Library/PciLib.h | 4 ++--
MdePkg/Include/Library/PciSegmentLib.h | 4 ++--
MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePciSegmentLib.c | 2 +-
MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c | 4 ++--
6 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/MdePkg/Include/Library/PciCf8Lib.h b/MdePkg/Include/Library/PciCf8Lib.h
index 41558dabddc2..7e22a527a80e 100644
--- a/MdePkg/Include/Library/PciCf8Lib.h
+++ b/MdePkg/Include/Library/PciCf8Lib.h
@@ -1027,7 +1027,7 @@ PciCf8BitFieldAndThenOr32 (
Size into the buffer specified by Buffer. This function only allows the PCI
configuration registers from a single PCI function to be read. Size is
returned. When possible 32-bit PCI configuration read cycles are used to read
- from StartAdress to StartAddress + Size. Due to alignment restrictions, 8-bit
+ from StartAddress to StartAddress + Size. Due to alignment restrictions, 8-bit
and 16-bit PCI configuration read cycles may be used at the beginning and the
end of the range.
@@ -1060,7 +1060,7 @@ PciCf8ReadBuffer (
Size from the buffer specified by Buffer. This function only allows the PCI
configuration registers from a single PCI function to be written. Size is
returned. When possible 32-bit PCI configuration write cycles are used to
- write from StartAdress to StartAddress + Size. Due to alignment restrictions,
+ write from StartAddress to StartAddress + Size. Due to alignment restrictions,
8-bit and 16-bit PCI configuration write cycles may be used at the beginning
and the end of the range.
diff --git a/MdePkg/Include/Library/PciExpressLib.h b/MdePkg/Include/Library/PciExpressLib.h
index aec2b5f3777d..826fdcf7db6c 100644
--- a/MdePkg/Include/Library/PciExpressLib.h
+++ b/MdePkg/Include/Library/PciExpressLib.h
@@ -997,7 +997,7 @@ PciExpressBitFieldAndThenOr32 (
Size into the buffer specified by Buffer. This function only allows the PCI
configuration registers from a single PCI function to be read. Size is
returned. When possible 32-bit PCI configuration read cycles are used to read
- from StartAdress to StartAddress + Size. Due to alignment restrictions, 8-bit
+ from StartAddress to StartAddress + Size. Due to alignment restrictions, 8-bit
and 16-bit PCI configuration read cycles may be used at the beginning and the
end of the range.
@@ -1029,7 +1029,7 @@ PciExpressReadBuffer (
Size from the buffer specified by Buffer. This function only allows the PCI
configuration registers from a single PCI function to be written. Size is
returned. When possible 32-bit PCI configuration write cycles are used to
- write from StartAdress to StartAddress + Size. Due to alignment restrictions,
+ write from StartAddress to StartAddress + Size. Due to alignment restrictions,
8-bit and 16-bit PCI configuration write cycles may be used at the beginning
and the end of the range.
diff --git a/MdePkg/Include/Library/PciLib.h b/MdePkg/Include/Library/PciLib.h
index 7a7d42050f0a..836494b6c1d7 100644
--- a/MdePkg/Include/Library/PciLib.h
+++ b/MdePkg/Include/Library/PciLib.h
@@ -997,7 +997,7 @@ PciBitFieldAndThenOr32 (
Size into the buffer specified by Buffer. This function only allows the PCI
configuration registers from a single PCI function to be read. Size is
returned. When possible 32-bit PCI configuration read cycles are used to read
- from StartAdress to StartAddress + Size. Due to alignment restrictions, 8-bit
+ from StartAddress to StartAddress + Size. Due to alignment restrictions, 8-bit
and 16-bit PCI configuration read cycles may be used at the beginning and the
end of the range.
@@ -1029,7 +1029,7 @@ PciReadBuffer (
Size from the buffer specified by Buffer. This function only allows the PCI
configuration registers from a single PCI function to be written. Size is
returned. When possible 32-bit PCI configuration write cycles are used to
- write from StartAdress to StartAddress + Size. Due to alignment restrictions,
+ write from StartAddress to StartAddress + Size. Due to alignment restrictions,
8-bit and 16-bit PCI configuration write cycles may be used at the beginning
and the end of the range.
diff --git a/MdePkg/Include/Library/PciSegmentLib.h b/MdePkg/Include/Library/PciSegmentLib.h
index bd31f05a23fe..fcd98dbfd8df 100644
--- a/MdePkg/Include/Library/PciSegmentLib.h
+++ b/MdePkg/Include/Library/PciSegmentLib.h
@@ -984,7 +984,7 @@ PciSegmentBitFieldAndThenOr32 (
Size into the buffer specified by Buffer. This function only allows the PCI
configuration registers from a single PCI function to be read. Size is
returned. When possible 32-bit PCI configuration read cycles are used to read
- from StartAdress to StartAddress + Size. Due to alignment restrictions, 8-bit
+ from StartAddress to StartAddress + Size. Due to alignment restrictions, 8-bit
and 16-bit PCI configuration read cycles may be used at the beginning and the
end of the range.
@@ -1016,7 +1016,7 @@ PciSegmentReadBuffer (
Size from the buffer specified by Buffer. This function only allows the PCI
configuration registers from a single PCI function to be written. Size is
returned. When possible 32-bit PCI configuration write cycles are used to
- write from StartAdress to StartAddress + Size. Due to alignment restrictions,
+ write from StartAddress to StartAddress + Size. Due to alignment restrictions,
8-bit and 16-bit PCI configuration write cycles may be used at the beginning
and the end of the range.
diff --git a/MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePciSegmentLib.c b/MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePciSegmentLib.c
index 2f503ecffe05..36b0b632c124 100644
--- a/MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePciSegmentLib.c
+++ b/MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePciSegmentLib.c
@@ -211,7 +211,7 @@ PciSegmentRegisterForRuntimeAccess (
Address = (UINTN)EcamAddress;
//
- // See if Address has already been registerd for runtime access
+ // See if Address has already been registered for runtime access
//
for (Index = 0; Index < mDxeRuntimePciSegmentLibNumberOfRuntimeRanges; Index++) {
if (mDxeRuntimePciSegmentLibRegistrationTable[Index].PhysicalAddress == Address) {
diff --git a/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c b/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c
index 1b42481123c9..a76e9d9adf07 100644
--- a/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c
+++ b/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c
@@ -1169,7 +1169,7 @@ PciSegmentBitFieldAndThenOr32 (
Size into the buffer specified by Buffer. This function only allows the PCI
configuration registers from a single PCI function to be read. Size is
returned. When possible 32-bit PCI configuration read cycles are used to read
- from StartAdress to StartAddress + Size. Due to alignment restrictions, 8-bit
+ from StartAddress to StartAddress + Size. Due to alignment restrictions, 8-bit
and 16-bit PCI configuration read cycles may be used at the beginning and the
end of the range.
@@ -1272,7 +1272,7 @@ PciSegmentReadBuffer (
Size from the buffer specified by Buffer. This function only allows the PCI
configuration registers from a single PCI function to be written. Size is
returned. When possible 32-bit PCI configuration write cycles are used to
- write from StartAdress to StartAddress + Size. Due to alignment restrictions,
+ write from StartAddress to StartAddress + Size. Due to alignment restrictions,
8-bit and 16-bit PCI configuration write cycles may be used at the beginning
and the end of the range.
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [edk2-devel] [PATCH 27/79] MdePkg/Library/Pci: Fix various typos
2019-12-03 16:15 ` [PATCH 27/79] MdePkg/Library/Pci: " Philippe Mathieu-Daudé
@ 2019-12-04 1:25 ` Michael D Kinney
0 siblings, 0 replies; 122+ messages in thread
From: Michael D Kinney @ 2019-12-04 1:25 UTC (permalink / raw)
To: devel@edk2.groups.io, philmd@redhat.com, Kinney, Michael D
Cc: Antoine Coeur, Gao, Liming
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Philippe Mathieu-Daudé
> Sent: Tuesday, December 3, 2019 8:15 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Philippe Mathieu-Daude
> <philmd@redhat.com>
> Subject: [edk2-devel] [PATCH 27/79] MdePkg/Library/Pci:
> Fix various typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude
> <philmd@redhat.com>
> ---
> MdePkg/Include/Library/PciCf8Lib.h
> | 4 ++--
> MdePkg/Include/Library/PciExpressLib.h
> | 4 ++--
> MdePkg/Include/Library/PciLib.h
> | 4 ++--
> MdePkg/Include/Library/PciSegmentLib.h
> | 4 ++--
>
> MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePciSe
> gmentLib.c | 2 +-
>
> MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCo
> mmon.c | 4 ++--
> 6 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/MdePkg/Include/Library/PciCf8Lib.h
> b/MdePkg/Include/Library/PciCf8Lib.h
> index 41558dabddc2..7e22a527a80e 100644
> --- a/MdePkg/Include/Library/PciCf8Lib.h
> +++ b/MdePkg/Include/Library/PciCf8Lib.h
> @@ -1027,7 +1027,7 @@ PciCf8BitFieldAndThenOr32 (
> Size into the buffer specified by Buffer. This
> function only allows the PCI
> configuration registers from a single PCI function
> to be read. Size is
> returned. When possible 32-bit PCI configuration
> read cycles are used to read
> - from StartAdress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
> + from StartAddress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
> and 16-bit PCI configuration read cycles may be used
> at the beginning and the
> end of the range.
>
> @@ -1060,7 +1060,7 @@ PciCf8ReadBuffer (
> Size from the buffer specified by Buffer. This
> function only allows the PCI
> configuration registers from a single PCI function
> to be written. Size is
> returned. When possible 32-bit PCI configuration
> write cycles are used to
> - write from StartAdress to StartAddress + Size. Due
> to alignment restrictions,
> + write from StartAddress to StartAddress + Size. Due
> to alignment restrictions,
> 8-bit and 16-bit PCI configuration write cycles may
> be used at the beginning
> and the end of the range.
>
> diff --git a/MdePkg/Include/Library/PciExpressLib.h
> b/MdePkg/Include/Library/PciExpressLib.h
> index aec2b5f3777d..826fdcf7db6c 100644
> --- a/MdePkg/Include/Library/PciExpressLib.h
> +++ b/MdePkg/Include/Library/PciExpressLib.h
> @@ -997,7 +997,7 @@ PciExpressBitFieldAndThenOr32 (
> Size into the buffer specified by Buffer. This
> function only allows the PCI
> configuration registers from a single PCI function
> to be read. Size is
> returned. When possible 32-bit PCI configuration
> read cycles are used to read
> - from StartAdress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
> + from StartAddress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
> and 16-bit PCI configuration read cycles may be used
> at the beginning and the
> end of the range.
>
> @@ -1029,7 +1029,7 @@ PciExpressReadBuffer (
> Size from the buffer specified by Buffer. This
> function only allows the PCI
> configuration registers from a single PCI function
> to be written. Size is
> returned. When possible 32-bit PCI configuration
> write cycles are used to
> - write from StartAdress to StartAddress + Size. Due
> to alignment restrictions,
> + write from StartAddress to StartAddress + Size. Due
> to alignment restrictions,
> 8-bit and 16-bit PCI configuration write cycles may
> be used at the beginning
> and the end of the range.
>
> diff --git a/MdePkg/Include/Library/PciLib.h
> b/MdePkg/Include/Library/PciLib.h
> index 7a7d42050f0a..836494b6c1d7 100644
> --- a/MdePkg/Include/Library/PciLib.h
> +++ b/MdePkg/Include/Library/PciLib.h
> @@ -997,7 +997,7 @@ PciBitFieldAndThenOr32 (
> Size into the buffer specified by Buffer. This
> function only allows the PCI
> configuration registers from a single PCI function
> to be read. Size is
> returned. When possible 32-bit PCI configuration
> read cycles are used to read
> - from StartAdress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
> + from StartAddress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
> and 16-bit PCI configuration read cycles may be used
> at the beginning and the
> end of the range.
>
> @@ -1029,7 +1029,7 @@ PciReadBuffer (
> Size from the buffer specified by Buffer. This
> function only allows the PCI
> configuration registers from a single PCI function
> to be written. Size is
> returned. When possible 32-bit PCI configuration
> write cycles are used to
> - write from StartAdress to StartAddress + Size. Due
> to alignment restrictions,
> + write from StartAddress to StartAddress + Size. Due
> to alignment restrictions,
> 8-bit and 16-bit PCI configuration write cycles may
> be used at the beginning
> and the end of the range.
>
> diff --git a/MdePkg/Include/Library/PciSegmentLib.h
> b/MdePkg/Include/Library/PciSegmentLib.h
> index bd31f05a23fe..fcd98dbfd8df 100644
> --- a/MdePkg/Include/Library/PciSegmentLib.h
> +++ b/MdePkg/Include/Library/PciSegmentLib.h
> @@ -984,7 +984,7 @@ PciSegmentBitFieldAndThenOr32 (
> Size into the buffer specified by Buffer. This
> function only allows the PCI
> configuration registers from a single PCI function
> to be read. Size is
> returned. When possible 32-bit PCI configuration
> read cycles are used to read
> - from StartAdress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
> + from StartAddress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
> and 16-bit PCI configuration read cycles may be used
> at the beginning and the
> end of the range.
>
> @@ -1016,7 +1016,7 @@ PciSegmentReadBuffer (
> Size from the buffer specified by Buffer. This
> function only allows the PCI
> configuration registers from a single PCI function
> to be written. Size is
> returned. When possible 32-bit PCI configuration
> write cycles are used to
> - write from StartAdress to StartAddress + Size. Due
> to alignment restrictions,
> + write from StartAddress to StartAddress + Size. Due
> to alignment restrictions,
> 8-bit and 16-bit PCI configuration write cycles may
> be used at the beginning
> and the end of the range.
>
> diff --git
> a/MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePci
> SegmentLib.c
> b/MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePci
> SegmentLib.c
> index 2f503ecffe05..36b0b632c124 100644
> ---
> a/MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePci
> SegmentLib.c
> +++
> b/MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePci
> SegmentLib.c
> @@ -211,7 +211,7 @@ PciSegmentRegisterForRuntimeAccess
> (
> Address = (UINTN)EcamAddress;
>
> //
> - // See if Address has already been registerd for
> runtime access
> + // See if Address has already been registered for
> runtime access
> //
> for (Index = 0; Index <
> mDxeRuntimePciSegmentLibNumberOfRuntimeRanges; Index++)
> {
> if
> (mDxeRuntimePciSegmentLibRegistrationTable[Index].Physi
> calAddress == Address) {
> diff --git
> a/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLib
> Common.c
> b/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLib
> Common.c
> index 1b42481123c9..a76e9d9adf07 100644
> ---
> a/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLib
> Common.c
> +++
> b/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLib
> Common.c
> @@ -1169,7 +1169,7 @@ PciSegmentBitFieldAndThenOr32 (
> Size into the buffer specified by Buffer. This
> function only allows the PCI
> configuration registers from a single PCI function
> to be read. Size is
> returned. When possible 32-bit PCI configuration
> read cycles are used to read
> - from StartAdress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
> + from StartAddress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
> and 16-bit PCI configuration read cycles may be used
> at the beginning and the
> end of the range.
>
> @@ -1272,7 +1272,7 @@ PciSegmentReadBuffer (
> Size from the buffer specified by Buffer. This
> function only allows the PCI
> configuration registers from a single PCI function
> to be written. Size is
> returned. When possible 32-bit PCI configuration
> write cycles are used to
> - write from StartAdress to StartAddress + Size. Due
> to alignment restrictions,
> + write from StartAddress to StartAddress + Size. Due
> to alignment restrictions,
> 8-bit and 16-bit PCI configuration write cycles may
> be used at the beginning
> and the end of the range.
>
> --
> 2.21.0
>
>
>
^ permalink raw reply [flat|nested] 122+ messages in thread
* [PATCH 28/79] MdePkg/Library/Smm: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (26 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 27/79] MdePkg/Library/Pci: " Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-04 1:28 ` Michael D Kinney
2019-12-03 16:15 ` [PATCH 29/79] MdePkg/Ppi: " Philippe Mathieu-Daudé
` (44 subsequent siblings)
72 siblings, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Michael D Kinney, Liming Gao,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdePkg/Include/Library/SmmLib.h | 4 +-
MdePkg/Include/Library/SmmMemLib.h | 4 +-
MdePkg/Include/Library/SmmPeriodicSmiLib.h | 6 +--
MdePkg/Library/SmmMemLib/SmmMemLib.c | 4 +-
MdePkg/Library/SmmPciExpressLib/PciExpressLib.c | 4 +-
MdePkg/Library/SmmPciLibPciRootBridgeIo/PciLib.c | 6 +--
MdePkg/Library/SmmPeriodicSmiLib/SmmPeriodicSmiLib.c | 42 ++++++++++----------
MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.c | 2 +-
8 files changed, 36 insertions(+), 36 deletions(-)
diff --git a/MdePkg/Include/Library/SmmLib.h b/MdePkg/Include/Library/SmmLib.h
index 8d83df7fd737..bcb7045c1b65 100644
--- a/MdePkg/Include/Library/SmmLib.h
+++ b/MdePkg/Include/Library/SmmLib.h
@@ -45,7 +45,7 @@ TriggerRuntimeSoftwareSmi (
it was triggered at boot time, it returns TRUE. Otherwise, it returns FALSE.
@retval TRUE A software SMI triggered at boot time happened.
- @retval FLASE No software SMI happened, or the software SMI was triggered at run time.
+ @retval FALSE No software SMI happened, or the software SMI was triggered at run time.
**/
BOOLEAN
@@ -62,7 +62,7 @@ IsBootServiceSoftwareSmi (
it was triggered at run time, it returns TRUE. Otherwise, it returns FALSE.
@retval TRUE A software SMI triggered at run time happened.
- @retval FLASE No software SMI happened or the software SMI was triggered at boot time.
+ @retval FALSE No software SMI happened or the software SMI was triggered at boot time.
**/
BOOLEAN
diff --git a/MdePkg/Include/Library/SmmMemLib.h b/MdePkg/Include/Library/SmmMemLib.h
index 72edc9adcde7..d92cbd9aabd2 100644
--- a/MdePkg/Include/Library/SmmMemLib.h
+++ b/MdePkg/Include/Library/SmmMemLib.h
@@ -67,7 +67,7 @@ SmmCopyMemToSmram (
@param SourceBuffer The pointer to the source buffer of the memory copy.
@param Length The number of bytes to copy from SourceBuffer to DestinationBuffer.
- @retval EFI_SECURITY_VIOLATION The DesinationBuffer is invalid per processor architecture or overlap with SMRAM.
+ @retval EFI_SECURITY_VIOLATION The DestinationBuffer is invalid per processor architecture or overlap with SMRAM.
@retval EFI_SUCCESS Memory is copied.
**/
@@ -92,7 +92,7 @@ SmmCopyMemFromSmram (
@param SourceBuffer The pointer to the source buffer of the memory copy.
@param Length The number of bytes to copy from SourceBuffer to DestinationBuffer.
- @retval EFI_SECURITY_VIOLATION The DesinationBuffer is invalid per processor architecture or overlap with SMRAM.
+ @retval EFI_SECURITY_VIOLATION The DestinationBuffer is invalid per processor architecture or overlap with SMRAM.
@retval EFI_SECURITY_VIOLATION The SourceBuffer is invalid per processor architecture or overlap with SMRAM.
@retval EFI_SUCCESS Memory is copied.
diff --git a/MdePkg/Include/Library/SmmPeriodicSmiLib.h b/MdePkg/Include/Library/SmmPeriodicSmiLib.h
index 6215aa2232ac..a3e086d02501 100644
--- a/MdePkg/Include/Library/SmmPeriodicSmiLib.h
+++ b/MdePkg/Include/Library/SmmPeriodicSmiLib.h
@@ -64,7 +64,7 @@ PeriodicSmiExit (
This function yields control back to the SMM Foundation. When the next
periodic SMI for the currently executing handler is triggered, the periodic
SMI handler will be resumed and this function will return. Use of this
- function requires a seperate stack for the periodic SMI handler. A non zero
+ function requires a separate stack for the periodic SMI handler. A non zero
stack size must be specified in PeriodicSmiEnable() for this function to be
used.
@@ -113,7 +113,7 @@ VOID
@param[in] DispatchFunction A pointer to a periodic SMI handler function.
@param[in] Context Optional content to pass into DispatchFunction.
@param[in] TickPeriod The requested tick period in 100ns units that
- control should be givien to the periodic SMI
+ control should be given to the periodic SMI
handler. Must be one of the supported values
returned by PeriodicSmiSupportedPickPeriod().
@param[in] Cpu Specifies the CPU that is required to execute
@@ -137,7 +137,7 @@ VOID
@retval EFI_OUT_OF_RESOURCES There are not enough resources to enable the
periodic SMI handler.
@retval EFI_OUT_OF_RESOURCES There are not enough resources to allocate the
- stack speficied by StackSize.
+ stack specified by StackSize.
@retval EFI_SUCCESS The periodic SMI handler was enabled.
**/
diff --git a/MdePkg/Library/SmmMemLib/SmmMemLib.c b/MdePkg/Library/SmmMemLib/SmmMemLib.c
index 7169bbdd10d8..63a4ff7a97f1 100644
--- a/MdePkg/Library/SmmMemLib/SmmMemLib.c
+++ b/MdePkg/Library/SmmMemLib/SmmMemLib.c
@@ -275,7 +275,7 @@ SmmCopyMemToSmram (
@param SourceBuffer The pointer to the source buffer of the memory copy.
@param Length The number of bytes to copy from SourceBuffer to DestinationBuffer.
- @retval EFI_SECURITY_VIOLATION The DesinationBuffer is invalid per processor architecture or overlap with SMRAM.
+ @retval EFI_SECURITY_VIOLATION The DestinationBuffer is invalid per processor architecture or overlap with SMRAM.
@retval EFI_SUCCESS Memory is copied.
**/
@@ -308,7 +308,7 @@ SmmCopyMemFromSmram (
@param SourceBuffer The pointer to the source buffer of the memory copy.
@param Length The number of bytes to copy from SourceBuffer to DestinationBuffer.
- @retval EFI_SECURITY_VIOLATION The DesinationBuffer is invalid per processor architecture or overlap with SMRAM.
+ @retval EFI_SECURITY_VIOLATION The DestinationBuffer is invalid per processor architecture or overlap with SMRAM.
@retval EFI_SECURITY_VIOLATION The SourceBuffer is invalid per processor architecture or overlap with SMRAM.
@retval EFI_SUCCESS Memory is copied.
diff --git a/MdePkg/Library/SmmPciExpressLib/PciExpressLib.c b/MdePkg/Library/SmmPciExpressLib/PciExpressLib.c
index 80c0154f5fad..35b9f775a80b 100644
--- a/MdePkg/Library/SmmPciExpressLib/PciExpressLib.c
+++ b/MdePkg/Library/SmmPciExpressLib/PciExpressLib.c
@@ -1226,7 +1226,7 @@ PciExpressBitFieldAndThenOr32 (
Size into the buffer specified by Buffer. This function only allows the PCI
configuration registers from a single PCI function to be read. Size is
returned. When possible 32-bit PCI configuration read cycles are used to read
- from StartAdress to StartAddress + Size. Due to alignment restrictions, 8-bit
+ from StartAddress to StartAddress + Size. Due to alignment restrictions, 8-bit
and 16-bit PCI configuration read cycles may be used at the beginning and the
end of the range.
@@ -1329,7 +1329,7 @@ PciExpressReadBuffer (
Size from the buffer specified by Buffer. This function only allows the PCI
configuration registers from a single PCI function to be written. Size is
returned. When possible 32-bit PCI configuration write cycles are used to
- write from StartAdress to StartAddress + Size. Due to alignment restrictions,
+ write from StartAddress to StartAddress + Size. Due to alignment restrictions,
8-bit and 16-bit PCI configuration write cycles may be used at the beginning
and the end of the range.
diff --git a/MdePkg/Library/SmmPciLibPciRootBridgeIo/PciLib.c b/MdePkg/Library/SmmPciLibPciRootBridgeIo/PciLib.c
index c9660f48d700..49ea99ce1f05 100644
--- a/MdePkg/Library/SmmPciLibPciRootBridgeIo/PciLib.c
+++ b/MdePkg/Library/SmmPciLibPciRootBridgeIo/PciLib.c
@@ -35,7 +35,7 @@
((((A) << 4) & 0xff000000) | (((A) >> 4) & 0x00000700) | (((A) << 1) & 0x001f0000) | (LShiftU64((A) & 0xfff, 32)))
//
-// Global varible to cache pointer to PCI Root Bridge I/O protocol.
+// Global variable to cache pointer to PCI Root Bridge I/O protocol.
//
EFI_SMM_PCI_ROOT_BRIDGE_IO_PROTOCOL *mSmmPciRootBridgeIo = NULL;
@@ -1238,7 +1238,7 @@ PciBitFieldAndThenOr32 (
Size into the buffer specified by Buffer. This function only allows the PCI
configuration registers from a single PCI function to be read. Size is
returned. When possible 32-bit PCI configuration read cycles are used to read
- from StartAdress to StartAddress + Size. Due to alignment restrictions, 8-bit
+ from StartAddress to StartAddress + Size. Due to alignment restrictions, 8-bit
and 16-bit PCI configuration read cycles may be used at the beginning and the
end of the range.
@@ -1336,7 +1336,7 @@ PciReadBuffer (
Size from the buffer specified by Buffer. This function only allows the PCI
configuration registers from a single PCI function to be written. Size is
returned. When possible 32-bit PCI configuration write cycles are used to
- write from StartAdress to StartAddress + Size. Due to alignment restrictions,
+ write from StartAddress to StartAddress + Size. Due to alignment restrictions,
8-bit and 16-bit PCI configuration write cycles may be used at the beginning
and the end of the range.
diff --git a/MdePkg/Library/SmmPeriodicSmiLib/SmmPeriodicSmiLib.c b/MdePkg/Library/SmmPeriodicSmiLib/SmmPeriodicSmiLib.c
index ba01910b696b..8b1e780b76db 100644
--- a/MdePkg/Library/SmmPeriodicSmiLib/SmmPeriodicSmiLib.c
+++ b/MdePkg/Library/SmmPeriodicSmiLib/SmmPeriodicSmiLib.c
@@ -107,8 +107,8 @@ typedef struct {
UINT64 DispatchTotalTime;
///
/// The performance counter value that was captured the last time that the
- /// periodic SMI handler called PeriodcSmiExecutionTime(). This allows the
- /// time value returned by PeriodcSmiExecutionTime() to be accurate even when
+ /// periodic SMI handler called PeriodicSmiExecutionTime(). This allows the
+ /// time value returned by PeriodicSmiExecutionTime() to be accurate even when
/// the performance counter rolls over.
///
UINT64 DispatchCheckPointTime;
@@ -127,7 +127,7 @@ typedef struct {
///
/// Buffer used to save the context when a periodic SMI handler requests to
/// yield using PeriodicSmiYield(). This context is used to resume the
- /// execution of a periodic SMI handler the next time control is transferd
+ /// execution of a periodic SMI handler the next time control is transferred
/// to the periodic SMI handler that yielded.
///
BASE_LIBRARY_JUMP_BUFFER YieldJumpBuffer;
@@ -152,7 +152,7 @@ typedef struct {
)
///
-/// Pointer to the SMM Periodic Timer Disatch Protocol that was located in the constuctor.
+/// Pointer to the SMM Periodic Timer Dispatch Protocol that was located in the constructor.
///
EFI_SMM_PERIODIC_TIMER_DISPATCH2_PROTOCOL *gSmmPeriodicTimerDispatch2 = NULL;
@@ -522,7 +522,7 @@ PeriodicSmiExit (
This function yields control back to the SMM Foundation. When the next
periodic SMI for the currently executing handler is triggered, the periodic
SMI handler will be resumed and this function will return. Use of this
- function requires a seperate stack for the periodic SMI handler. A non zero
+ function requires a separate stack for the periodic SMI handler. A non zero
stack size must be specified in PeriodicSmiEnable() for this function to be
used.
@@ -572,7 +572,7 @@ PeriodicSmiYield (
SetJumpFlag = SetJump (&PeriodicSmiLibraryHandler->YieldJumpBuffer);
if (SetJumpFlag == 0) {
//
- // The intial call to SetJump() always returns 0.
+ // The initial call to SetJump() always returns 0.
// If this is the initial call, then exit the current periodic SMI handler
//
PeriodicSmiExit ();
@@ -588,7 +588,7 @@ PeriodicSmiYield (
PeriodicSmiLibraryHandler->YieldFlag = FALSE;
//
- // Return the amount elapsed time that occured while yielded
+ // Return the amount elapsed time that occurred while yielded
//
return PeriodicSmiLibraryHandler->ElapsedTime;
}
@@ -620,7 +620,7 @@ PeriodicSmiDispatchFunctionSwitchStack (
//
// Dispatch the registered handler passing in the context that was registered
// and the amount of time that has elapsed since the previous time this
- // periodic SMI handler was dispacthed.
+ // periodic SMI handler was dispatched.
//
PeriodicSmiLibraryHandler->DispatchFunction (
PeriodicSmiLibraryHandler->Context,
@@ -628,16 +628,16 @@ PeriodicSmiDispatchFunctionSwitchStack (
);
//
- // If this DispatchFunction() returns, then unconditially call PeriodicSmiExit()
+ // If this DispatchFunction() returns, then unconditionally call PeriodicSmiExit()
// to perform a LongJump() back to PeriodicSmiDispatchFunctionOnCpu(). The
- // LongJump() will resume exection on the original stack.
+ // LongJump() will resume execution on the original stack.
//
PeriodicSmiExit ();
}
/**
Internal worker function that transfers control to an enabled periodic SMI
- handler on the specified logial CPU. This function determines if the periodic
+ handler on the specified logical CPU. This function determines if the periodic
SMI handler yielded and needs to be resumed. It also and switches to an
allocated stack if one was allocated in PeriodicSmiEnable().
@@ -652,9 +652,9 @@ PeriodicSmiDispatchFunctionOnCpu (
)
{
//
- // Save context in DispatchJumpBuffer. The intial call to SetJump() always
+ // Save context in DispatchJumpBuffer. The initial call to SetJump() always
// returns 0. If this is the initial call, then either resume from a prior
- // call to PeriodicSmiYield() or call the DispatchFunction registerd in
+ // call to PeriodicSmiYield() or call the DispatchFunction registered in
// PeriodicSmiEnable() using an allocated stack if one was specified.
//
if (SetJump (&PeriodicSmiLibraryHandler->DispatchJumpBuffer) != 0) {
@@ -679,7 +679,7 @@ PeriodicSmiDispatchFunctionOnCpu (
//
// If Stack is NULL then call DispatchFunction using current stack passing
// in the context that was registered and the amount of time that has
- // elapsed since the previous time this periodic SMI handler was dispacthed.
+ // elapsed since the previous time this periodic SMI handler was dispatched.
//
PeriodicSmiLibraryHandler->DispatchFunction (
PeriodicSmiLibraryHandler->Context,
@@ -687,7 +687,7 @@ PeriodicSmiDispatchFunctionOnCpu (
);
//
- // If this DispatchFunction() returns, then unconditially call PeriodicSmiExit()
+ // If this DispatchFunction() returns, then unconditionally call PeriodicSmiExit()
// to perform a LongJump() back to this function.
//
PeriodicSmiExit ();
@@ -712,7 +712,7 @@ PeriodicSmiDispatchFunctionOnCpu (
/**
Internal worker function that transfers control to an enabled periodic SMI
- handler on the specified logial CPU. This worker function is only called
+ handler on the specified logical CPU. This worker function is only called
using the SMM Services Table function SmmStartupThisAp() to execute the
periodic SMI handler on a logical CPU that is different than the one that is
running the SMM Foundation. When the periodic SMI handler returns, a lock is
@@ -736,7 +736,7 @@ PeriodicSmiDispatchFunctionWithLock (
PeriodicSmiLibraryHandler = (PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT *)Buffer;
//
- // Execute dispatch function on the currently excuting logical CPU
+ // Execute dispatch function on the currently executing logical CPU
//
PeriodicSmiDispatchFunctionOnCpu (PeriodicSmiLibraryHandler);
@@ -805,7 +805,7 @@ PeriodicSmiDispatchFunction (
(PeriodicSmiLibraryHandler->Cpu == gSmst->CurrentlyExecutingCpu) ) {
//
// Dispatch on the currently execution CPU if the CPU specified in PeriodicSmiEnable()
- // was PERIODIC_SMI_LIBARRY_ANY_CPU or the currently executing CPU matches the CPU
+ // was PERIODIC_SMI_LIBRARY_ANY_CPU or the currently executing CPU matches the CPU
// that was specified in PeriodicSmiEnable().
//
PeriodicSmiDispatchFunctionOnCpu (PeriodicSmiLibraryHandler);
@@ -867,7 +867,7 @@ PeriodicSmiDispatchFunction (
@param[in] DispatchFunction A pointer to a periodic SMI handler function.
@param[in] Context Optional content to pass into DispatchFunction.
@param[in] TickPeriod The requested tick period in 100ns units that
- control should be givien to the periodic SMI
+ control should be given to the periodic SMI
handler. Must be one of the supported values
returned by PeriodicSmiSupportedPickPeriod().
@param[in] Cpu Specifies the CPU that is required to execute
@@ -891,7 +891,7 @@ PeriodicSmiDispatchFunction (
@retval EFI_OUT_OF_RESOURCES There are not enough resources to enable the
periodic SMI handler.
@retval EFI_OUT_OF_RESOURCES There are not enough resources to allocate the
- stack speficied by StackSize.
+ stack specified by StackSize.
@retval EFI_SUCCESS The periodic SMI handler was enabled.
**/
@@ -1077,7 +1077,7 @@ SmmPeriodicSmiLibConstructor (
//
// Count the number of periodic SMI tick intervals that the SMM Periodic Timer
- // Dipatch 2 Protocol supports.
+ // Dispatch 2 Protocol supports.
//
SmiTickInterval = NULL;
Count = 0;
diff --git a/MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.c b/MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.c
index d95e9d473790..0f611cd25df7 100644
--- a/MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.c
+++ b/MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.c
@@ -36,7 +36,7 @@ SmmServicesTableLibConstructor (
//
// Retrieve SMM Base2 Protocol, Do not use gBS from UefiBootServicesTableLib on purpose
// to prevent inclusion of gBS, gST, and gImageHandle from SMM Drivers unless the
- // SMM driver explicity declares that dependency.
+ // SMM driver explicitly declares that dependency.
//
Status = SystemTable->BootServices->LocateProtocol (
&gEfiSmmBase2ProtocolGuid,
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [PATCH 28/79] MdePkg/Library/Smm: Fix various typos
2019-12-03 16:15 ` [PATCH 28/79] MdePkg/Library/Smm: " Philippe Mathieu-Daudé
@ 2019-12-04 1:28 ` Michael D Kinney
0 siblings, 0 replies; 122+ messages in thread
From: Michael D Kinney @ 2019-12-04 1:28 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io, Kinney, Michael D
Cc: Antoine Coeur, Gao, Liming
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: Philippe Mathieu-Daude <philmd@redhat.com>
> Sent: Tuesday, December 3, 2019 8:15 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Philippe Mathieu-Daude
> <philmd@redhat.com>
> Subject: [PATCH 28/79] MdePkg/Library/Smm: Fix various
> typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude
> <philmd@redhat.com>
> ---
> MdePkg/Include/Library/SmmLib.h
> | 4 +-
> MdePkg/Include/Library/SmmMemLib.h
> | 4 +-
> MdePkg/Include/Library/SmmPeriodicSmiLib.h
> | 6 +--
> MdePkg/Library/SmmMemLib/SmmMemLib.c
> | 4 +-
> MdePkg/Library/SmmPciExpressLib/PciExpressLib.c
> | 4 +-
> MdePkg/Library/SmmPciLibPciRootBridgeIo/PciLib.c
> | 6 +--
> MdePkg/Library/SmmPeriodicSmiLib/SmmPeriodicSmiLib.c
> | 42 ++++++++++----------
>
> MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.
> c | 2 +-
> 8 files changed, 36 insertions(+), 36 deletions(-)
>
> diff --git a/MdePkg/Include/Library/SmmLib.h
> b/MdePkg/Include/Library/SmmLib.h
> index 8d83df7fd737..bcb7045c1b65 100644
> --- a/MdePkg/Include/Library/SmmLib.h
> +++ b/MdePkg/Include/Library/SmmLib.h
> @@ -45,7 +45,7 @@ TriggerRuntimeSoftwareSmi (
> it was triggered at boot time, it returns TRUE.
> Otherwise, it returns FALSE.
>
> @retval TRUE A software SMI triggered at boot time
> happened.
> - @retval FLASE No software SMI happened, or the
> software SMI was triggered at run time.
> + @retval FALSE No software SMI happened, or the
> software SMI was triggered at run time.
>
> **/
> BOOLEAN
> @@ -62,7 +62,7 @@ IsBootServiceSoftwareSmi (
> it was triggered at run time, it returns TRUE.
> Otherwise, it returns FALSE.
>
> @retval TRUE A software SMI triggered at run time
> happened.
> - @retval FLASE No software SMI happened or the
> software SMI was triggered at boot time.
> + @retval FALSE No software SMI happened or the
> software SMI was triggered at boot time.
>
> **/
> BOOLEAN
> diff --git a/MdePkg/Include/Library/SmmMemLib.h
> b/MdePkg/Include/Library/SmmMemLib.h
> index 72edc9adcde7..d92cbd9aabd2 100644
> --- a/MdePkg/Include/Library/SmmMemLib.h
> +++ b/MdePkg/Include/Library/SmmMemLib.h
> @@ -67,7 +67,7 @@ SmmCopyMemToSmram (
> @param SourceBuffer The pointer to the
> source buffer of the memory copy.
> @param Length The number of bytes to
> copy from SourceBuffer to DestinationBuffer.
>
> - @retval EFI_SECURITY_VIOLATION The DesinationBuffer
> is invalid per processor architecture or overlap with
> SMRAM.
> + @retval EFI_SECURITY_VIOLATION The DestinationBuffer
> is invalid per processor architecture or overlap with
> SMRAM.
> @retval EFI_SUCCESS Memory is copied.
>
> **/
> @@ -92,7 +92,7 @@ SmmCopyMemFromSmram (
> @param SourceBuffer The pointer to the
> source buffer of the memory copy.
> @param Length The number of bytes to
> copy from SourceBuffer to DestinationBuffer.
>
> - @retval EFI_SECURITY_VIOLATION The DesinationBuffer
> is invalid per processor architecture or overlap with
> SMRAM.
> + @retval EFI_SECURITY_VIOLATION The DestinationBuffer
> is invalid per processor architecture or overlap with
> SMRAM.
> @retval EFI_SECURITY_VIOLATION The SourceBuffer is
> invalid per processor architecture or overlap with
> SMRAM.
> @retval EFI_SUCCESS Memory is copied.
>
> diff --git a/MdePkg/Include/Library/SmmPeriodicSmiLib.h
> b/MdePkg/Include/Library/SmmPeriodicSmiLib.h
> index 6215aa2232ac..a3e086d02501 100644
> --- a/MdePkg/Include/Library/SmmPeriodicSmiLib.h
> +++ b/MdePkg/Include/Library/SmmPeriodicSmiLib.h
> @@ -64,7 +64,7 @@ PeriodicSmiExit (
> This function yields control back to the SMM
> Foundation. When the next
> periodic SMI for the currently executing handler is
> triggered, the periodic
> SMI handler will be resumed and this function will
> return. Use of this
> - function requires a seperate stack for the periodic
> SMI handler. A non zero
> + function requires a separate stack for the periodic
> SMI handler. A non zero
> stack size must be specified in PeriodicSmiEnable()
> for this function to be
> used.
>
> @@ -113,7 +113,7 @@ VOID
> @param[in] DispatchFunction A pointer to a
> periodic SMI handler function.
> @param[in] Context Optional content to
> pass into DispatchFunction.
> @param[in] TickPeriod The requested tick
> period in 100ns units that
> - control should be
> givien to the periodic SMI
> + control should be
> given to the periodic SMI
> handler. Must be
> one of the supported values
> returned by
> PeriodicSmiSupportedPickPeriod().
> @param[in] Cpu Specifies the CPU
> that is required to execute
> @@ -137,7 +137,7 @@ VOID
> @retval EFI_OUT_OF_RESOURCES There are not enough
> resources to enable the
> periodic SMI handler.
> @retval EFI_OUT_OF_RESOURCES There are not enough
> resources to allocate the
> - stack speficied by
> StackSize.
> + stack specified by
> StackSize.
> @retval EFI_SUCCESS The periodic SMI
> handler was enabled.
>
> **/
> diff --git a/MdePkg/Library/SmmMemLib/SmmMemLib.c
> b/MdePkg/Library/SmmMemLib/SmmMemLib.c
> index 7169bbdd10d8..63a4ff7a97f1 100644
> --- a/MdePkg/Library/SmmMemLib/SmmMemLib.c
> +++ b/MdePkg/Library/SmmMemLib/SmmMemLib.c
> @@ -275,7 +275,7 @@ SmmCopyMemToSmram (
> @param SourceBuffer The pointer to the
> source buffer of the memory copy.
> @param Length The number of bytes to
> copy from SourceBuffer to DestinationBuffer.
>
> - @retval EFI_SECURITY_VIOLATION The DesinationBuffer
> is invalid per processor architecture or overlap with
> SMRAM.
> + @retval EFI_SECURITY_VIOLATION The DestinationBuffer
> is invalid per processor architecture or overlap with
> SMRAM.
> @retval EFI_SUCCESS Memory is copied.
>
> **/
> @@ -308,7 +308,7 @@ SmmCopyMemFromSmram (
> @param SourceBuffer The pointer to the
> source buffer of the memory copy.
> @param Length The number of bytes to
> copy from SourceBuffer to DestinationBuffer.
>
> - @retval EFI_SECURITY_VIOLATION The DesinationBuffer
> is invalid per processor architecture or overlap with
> SMRAM.
> + @retval EFI_SECURITY_VIOLATION The DestinationBuffer
> is invalid per processor architecture or overlap with
> SMRAM.
> @retval EFI_SECURITY_VIOLATION The SourceBuffer is
> invalid per processor architecture or overlap with
> SMRAM.
> @retval EFI_SUCCESS Memory is copied.
>
> diff --git
> a/MdePkg/Library/SmmPciExpressLib/PciExpressLib.c
> b/MdePkg/Library/SmmPciExpressLib/PciExpressLib.c
> index 80c0154f5fad..35b9f775a80b 100644
> --- a/MdePkg/Library/SmmPciExpressLib/PciExpressLib.c
> +++ b/MdePkg/Library/SmmPciExpressLib/PciExpressLib.c
> @@ -1226,7 +1226,7 @@ PciExpressBitFieldAndThenOr32 (
> Size into the buffer specified by Buffer. This
> function only allows the PCI
> configuration registers from a single PCI function to
> be read. Size is
> returned. When possible 32-bit PCI configuration read
> cycles are used to read
> - from StartAdress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
> + from StartAddress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
> and 16-bit PCI configuration read cycles may be used
> at the beginning and the
> end of the range.
>
> @@ -1329,7 +1329,7 @@ PciExpressReadBuffer (
> Size from the buffer specified by Buffer. This
> function only allows the PCI
> configuration registers from a single PCI function to
> be written. Size is
> returned. When possible 32-bit PCI configuration
> write cycles are used to
> - write from StartAdress to StartAddress + Size. Due to
> alignment restrictions,
> + write from StartAddress to StartAddress + Size. Due
> to alignment restrictions,
> 8-bit and 16-bit PCI configuration write cycles may
> be used at the beginning
> and the end of the range.
>
> diff --git
> a/MdePkg/Library/SmmPciLibPciRootBridgeIo/PciLib.c
> b/MdePkg/Library/SmmPciLibPciRootBridgeIo/PciLib.c
> index c9660f48d700..49ea99ce1f05 100644
> --- a/MdePkg/Library/SmmPciLibPciRootBridgeIo/PciLib.c
> +++ b/MdePkg/Library/SmmPciLibPciRootBridgeIo/PciLib.c
> @@ -35,7 +35,7 @@
> ((((A) << 4) & 0xff000000) | (((A) >> 4) &
> 0x00000700) | (((A) << 1) & 0x001f0000) |
> (LShiftU64((A) & 0xfff, 32)))
>
> //
> -// Global varible to cache pointer to PCI Root Bridge
> I/O protocol.
> +// Global variable to cache pointer to PCI Root Bridge
> I/O protocol.
> //
> EFI_SMM_PCI_ROOT_BRIDGE_IO_PROTOCOL
> *mSmmPciRootBridgeIo = NULL;
>
> @@ -1238,7 +1238,7 @@ PciBitFieldAndThenOr32 (
> Size into the buffer specified by Buffer. This
> function only allows the PCI
> configuration registers from a single PCI function
> to be read. Size is
> returned. When possible 32-bit PCI configuration
> read cycles are used to read
> - from StartAdress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
> + from StartAddress to StartAddress + Size. Due to
> alignment restrictions, 8-bit
> and 16-bit PCI configuration read cycles may be used
> at the beginning and the
> end of the range.
>
> @@ -1336,7 +1336,7 @@ PciReadBuffer (
> Size from the buffer specified by Buffer. This
> function only allows the PCI
> configuration registers from a single PCI function
> to be written. Size is
> returned. When possible 32-bit PCI configuration
> write cycles are used to
> - write from StartAdress to StartAddress + Size. Due
> to alignment restrictions,
> + write from StartAddress to StartAddress + Size. Due
> to alignment restrictions,
> 8-bit and 16-bit PCI configuration write cycles may
> be used at the beginning
> and the end of the range.
>
> diff --git
> a/MdePkg/Library/SmmPeriodicSmiLib/SmmPeriodicSmiLib.c
> b/MdePkg/Library/SmmPeriodicSmiLib/SmmPeriodicSmiLib.c
> index ba01910b696b..8b1e780b76db 100644
> ---
> a/MdePkg/Library/SmmPeriodicSmiLib/SmmPeriodicSmiLib.c
> +++
> b/MdePkg/Library/SmmPeriodicSmiLib/SmmPeriodicSmiLib.c
> @@ -107,8 +107,8 @@ typedef struct {
> UINT64
> DispatchTotalTime;
> ///
> /// The performance counter value that was captured
> the last time that the
> - /// periodic SMI handler called
> PeriodcSmiExecutionTime(). This allows the
> - /// time value returned by PeriodcSmiExecutionTime()
> to be accurate even when
> + /// periodic SMI handler called
> PeriodicSmiExecutionTime(). This allows the
> + /// time value returned by
> PeriodicSmiExecutionTime() to be accurate even when
> /// the performance counter rolls over.
> ///
> UINT64
> DispatchCheckPointTime;
> @@ -127,7 +127,7 @@ typedef struct {
> ///
> /// Buffer used to save the context when a periodic
> SMI handler requests to
> /// yield using PeriodicSmiYield(). This context is
> used to resume the
> - /// execution of a periodic SMI handler the next
> time control is transferd
> + /// execution of a periodic SMI handler the next
> time control is transferred
> /// to the periodic SMI handler that yielded.
> ///
> BASE_LIBRARY_JUMP_BUFFER
> YieldJumpBuffer;
> @@ -152,7 +152,7 @@ typedef struct {
> )
>
> ///
> -/// Pointer to the SMM Periodic Timer Disatch Protocol
> that was located in the constuctor.
> +/// Pointer to the SMM Periodic Timer Dispatch
> Protocol that was located in the constructor.
> ///
> EFI_SMM_PERIODIC_TIMER_DISPATCH2_PROTOCOL
> *gSmmPeriodicTimerDispatch2 = NULL;
>
> @@ -522,7 +522,7 @@ PeriodicSmiExit (
> This function yields control back to the SMM
> Foundation. When the next
> periodic SMI for the currently executing handler is
> triggered, the periodic
> SMI handler will be resumed and this function will
> return. Use of this
> - function requires a seperate stack for the periodic
> SMI handler. A non zero
> + function requires a separate stack for the periodic
> SMI handler. A non zero
> stack size must be specified in PeriodicSmiEnable()
> for this function to be
> used.
>
> @@ -572,7 +572,7 @@ PeriodicSmiYield (
> SetJumpFlag = SetJump (&PeriodicSmiLibraryHandler-
> >YieldJumpBuffer);
> if (SetJumpFlag == 0) {
> //
> - // The intial call to SetJump() always returns 0.
> + // The initial call to SetJump() always returns 0.
> // If this is the initial call, then exit the
> current periodic SMI handler
> //
> PeriodicSmiExit ();
> @@ -588,7 +588,7 @@ PeriodicSmiYield (
> PeriodicSmiLibraryHandler->YieldFlag = FALSE;
>
> //
> - // Return the amount elapsed time that occured while
> yielded
> + // Return the amount elapsed time that occurred
> while yielded
> //
> return PeriodicSmiLibraryHandler->ElapsedTime;
> }
> @@ -620,7 +620,7 @@
> PeriodicSmiDispatchFunctionSwitchStack (
> //
> // Dispatch the registered handler passing in the
> context that was registered
> // and the amount of time that has elapsed since the
> previous time this
> - // periodic SMI handler was dispacthed.
> + // periodic SMI handler was dispatched.
> //
> PeriodicSmiLibraryHandler->DispatchFunction (
> PeriodicSmiLibraryHandler->Context,
> @@ -628,16 +628,16 @@
> PeriodicSmiDispatchFunctionSwitchStack (
> );
>
> //
> - // If this DispatchFunction() returns, then
> unconditially call PeriodicSmiExit()
> + // If this DispatchFunction() returns, then
> unconditionally call PeriodicSmiExit()
> // to perform a LongJump() back to
> PeriodicSmiDispatchFunctionOnCpu(). The
> - // LongJump() will resume exection on the original
> stack.
> + // LongJump() will resume execution on the original
> stack.
> //
> PeriodicSmiExit ();
> }
>
> /**
> Internal worker function that transfers control to
> an enabled periodic SMI
> - handler on the specified logial CPU. This function
> determines if the periodic
> + handler on the specified logical CPU. This function
> determines if the periodic
> SMI handler yielded and needs to be resumed. It
> also and switches to an
> allocated stack if one was allocated in
> PeriodicSmiEnable().
>
> @@ -652,9 +652,9 @@ PeriodicSmiDispatchFunctionOnCpu (
> )
> {
> //
> - // Save context in DispatchJumpBuffer. The intial
> call to SetJump() always
> + // Save context in DispatchJumpBuffer. The initial
> call to SetJump() always
> // returns 0. If this is the initial call, then
> either resume from a prior
> - // call to PeriodicSmiYield() or call the
> DispatchFunction registerd in
> + // call to PeriodicSmiYield() or call the
> DispatchFunction registered in
> // PeriodicSmiEnable() using an allocated stack if
> one was specified.
> //
> if (SetJump (&PeriodicSmiLibraryHandler-
> >DispatchJumpBuffer) != 0) {
> @@ -679,7 +679,7 @@ PeriodicSmiDispatchFunctionOnCpu (
> //
> // If Stack is NULL then call DispatchFunction
> using current stack passing
> // in the context that was registered and the
> amount of time that has
> - // elapsed since the previous time this periodic
> SMI handler was dispacthed.
> + // elapsed since the previous time this periodic
> SMI handler was dispatched.
> //
> PeriodicSmiLibraryHandler->DispatchFunction (
> PeriodicSmiLibraryHandler->Context,
> @@ -687,7 +687,7 @@ PeriodicSmiDispatchFunctionOnCpu (
> );
>
> //
> - // If this DispatchFunction() returns, then
> unconditially call PeriodicSmiExit()
> + // If this DispatchFunction() returns, then
> unconditionally call PeriodicSmiExit()
> // to perform a LongJump() back to this function.
> //
> PeriodicSmiExit ();
> @@ -712,7 +712,7 @@ PeriodicSmiDispatchFunctionOnCpu (
>
> /**
> Internal worker function that transfers control to
> an enabled periodic SMI
> - handler on the specified logial CPU. This worker
> function is only called
> + handler on the specified logical CPU. This worker
> function is only called
> using the SMM Services Table function
> SmmStartupThisAp() to execute the
> periodic SMI handler on a logical CPU that is
> different than the one that is
> running the SMM Foundation. When the periodic SMI
> handler returns, a lock is
> @@ -736,7 +736,7 @@ PeriodicSmiDispatchFunctionWithLock
> (
> PeriodicSmiLibraryHandler =
> (PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT *)Buffer;
>
> //
> - // Execute dispatch function on the currently
> excuting logical CPU
> + // Execute dispatch function on the currently
> executing logical CPU
> //
> PeriodicSmiDispatchFunctionOnCpu
> (PeriodicSmiLibraryHandler);
>
> @@ -805,7 +805,7 @@ PeriodicSmiDispatchFunction (
> (PeriodicSmiLibraryHandler->Cpu == gSmst-
> >CurrentlyExecutingCpu) ) {
> //
> // Dispatch on the currently execution CPU if the
> CPU specified in PeriodicSmiEnable()
> - // was PERIODIC_SMI_LIBARRY_ANY_CPU or the
> currently executing CPU matches the CPU
> + // was PERIODIC_SMI_LIBRARY_ANY_CPU or the
> currently executing CPU matches the CPU
> // that was specified in PeriodicSmiEnable().
> //
> PeriodicSmiDispatchFunctionOnCpu
> (PeriodicSmiLibraryHandler);
> @@ -867,7 +867,7 @@ PeriodicSmiDispatchFunction (
> @param[in] DispatchFunction A pointer to a
> periodic SMI handler function.
> @param[in] Context Optional content to
> pass into DispatchFunction.
> @param[in] TickPeriod The requested tick
> period in 100ns units that
> - control should be
> givien to the periodic SMI
> + control should be
> given to the periodic SMI
> handler. Must be
> one of the supported values
> returned by
> PeriodicSmiSupportedPickPeriod().
> @param[in] Cpu Specifies the CPU
> that is required to execute
> @@ -891,7 +891,7 @@ PeriodicSmiDispatchFunction (
> @retval EFI_OUT_OF_RESOURCES There are not enough
> resources to enable the
> periodic SMI handler.
> @retval EFI_OUT_OF_RESOURCES There are not enough
> resources to allocate the
> - stack speficied by
> StackSize.
> + stack specified by
> StackSize.
> @retval EFI_SUCCESS The periodic SMI
> handler was enabled.
>
> **/
> @@ -1077,7 +1077,7 @@ SmmPeriodicSmiLibConstructor (
>
> //
> // Count the number of periodic SMI tick intervals
> that the SMM Periodic Timer
> - // Dipatch 2 Protocol supports.
> + // Dispatch 2 Protocol supports.
> //
> SmiTickInterval = NULL;
> Count = 0;
> diff --git
> a/MdePkg/Library/SmmServicesTableLib/SmmServicesTableLi
> b.c
> b/MdePkg/Library/SmmServicesTableLib/SmmServicesTableLi
> b.c
> index d95e9d473790..0f611cd25df7 100644
> ---
> a/MdePkg/Library/SmmServicesTableLib/SmmServicesTableLi
> b.c
> +++
> b/MdePkg/Library/SmmServicesTableLib/SmmServicesTableLi
> b.c
> @@ -36,7 +36,7 @@ SmmServicesTableLibConstructor (
> //
> // Retrieve SMM Base2 Protocol, Do not use gBS from
> UefiBootServicesTableLib on purpose
> // to prevent inclusion of gBS, gST, and
> gImageHandle from SMM Drivers unless the
> - // SMM driver explicity declares that dependency.
> + // SMM driver explicitly declares that dependency.
> //
> Status = SystemTable->BootServices->LocateProtocol (
>
> &gEfiSmmBase2ProtocolGuid,
> --
> 2.21.0
^ permalink raw reply [flat|nested] 122+ messages in thread
* [PATCH 29/79] MdePkg/Ppi: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (27 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 28/79] MdePkg/Library/Smm: " Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-04 1:29 ` [edk2-devel] " Michael D Kinney
2019-12-03 16:15 ` [PATCH 30/79] MdePkg/Register: " Philippe Mathieu-Daudé
` (43 subsequent siblings)
72 siblings, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Michael D Kinney, Liming Gao,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdePkg/Include/Ppi/BlockIo.h | 4 ++--
MdePkg/Include/Ppi/BlockIo2.h | 2 +-
MdePkg/Include/Ppi/Capsule.h | 2 +-
MdePkg/Include/Ppi/Decompress.h | 2 +-
MdePkg/Include/Ppi/DeviceRecoveryModule.h | 2 +-
MdePkg/Include/Ppi/IsaHc.h | 2 +-
MdePkg/Include/Ppi/MpServices.h | 2 +-
MdePkg/Include/Ppi/Pcd.h | 4 ++--
MdePkg/Include/Ppi/RecoveryModule.h | 2 +-
MdePkg/Include/Ppi/TemporaryRamDone.h | 2 +-
MdePkg/Include/Ppi/VectorHandoffInfo.h | 2 +-
11 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/MdePkg/Include/Ppi/BlockIo.h b/MdePkg/Include/Ppi/BlockIo.h
index 524f026fe589..3a4955be6b59 100644
--- a/MdePkg/Include/Ppi/BlockIo.h
+++ b/MdePkg/Include/Ppi/BlockIo.h
@@ -15,7 +15,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
@par Revision Reference:
This PPI is defined in UEFI Platform Initialization Specification 1.2 Volume 1:
- Pre-EFI Initalization Core Interface.
+ Pre-EFI Initialization Core Interface.
**/
@@ -58,7 +58,7 @@ typedef enum {
/// Specification inconsistency here:
/// PEI_BLOCK_IO_MEDIA has been changed to EFI_PEI_BLOCK_IO_MEDIA.
/// Inconsistency exists in UEFI Platform Initialization Specification 1.2
-/// Volume 1: Pre-EFI Initalization Core Interface, where all referrences to
+/// Volume 1: Pre-EFI Initialization Core Interface, where all references to
/// this structure name are with the "EFI_" prefix, except for the definition
/// which is without "EFI_". So the name of PEI_BLOCK_IO_MEDIA is taken as the
/// exception, and EFI_PEI_BLOCK_IO_MEDIA is used to comply with most of
diff --git a/MdePkg/Include/Ppi/BlockIo2.h b/MdePkg/Include/Ppi/BlockIo2.h
index e1af6a4293ed..0dba6485d941 100644
--- a/MdePkg/Include/Ppi/BlockIo2.h
+++ b/MdePkg/Include/Ppi/BlockIo2.h
@@ -7,7 +7,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
@par Revision Reference:
This PPI is defined in UEFI Platform Initialization Specification 1.4 Volume 1:
- Pre-EFI Initalization Core Interface.
+ Pre-EFI Initialization Core Interface.
**/
diff --git a/MdePkg/Include/Ppi/Capsule.h b/MdePkg/Include/Ppi/Capsule.h
index cb7b0e2ae76a..331d9b81cad2 100644
--- a/MdePkg/Include/Ppi/Capsule.h
+++ b/MdePkg/Include/Ppi/Capsule.h
@@ -45,7 +45,7 @@ typedef struct _EFI_PEI_CAPSULE_PPI PEI_CAPSULE_PPI;
On output, this variable will contain the size of the
coalesced capsule.
- @retval EFI_NOT_FOUND If: boot modecould not be determined, or the
+ @retval EFI_NOT_FOUND If: boot mode could not be determined, or the
boot mode is not flash-update, or the capsule descriptors were not found.
@retval EFI_BUFFER_TOO_SMALL The capsule could not be coalesced in the provided memory region.
@retval EFI_SUCCESS There was no capsule, or the capsule was processed successfully.
diff --git a/MdePkg/Include/Ppi/Decompress.h b/MdePkg/Include/Ppi/Decompress.h
index 7ba26e419c59..b9ca63746ab2 100644
--- a/MdePkg/Include/Ppi/Decompress.h
+++ b/MdePkg/Include/Ppi/Decompress.h
@@ -1,5 +1,5 @@
/** @file
- Provides decompression services to the PEI Foundatoin.
+ Provides decompression services to the PEI Foundation.
Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
diff --git a/MdePkg/Include/Ppi/DeviceRecoveryModule.h b/MdePkg/Include/Ppi/DeviceRecoveryModule.h
index a4587255a3c8..64dabec1139c 100644
--- a/MdePkg/Include/Ppi/DeviceRecoveryModule.h
+++ b/MdePkg/Include/Ppi/DeviceRecoveryModule.h
@@ -15,7 +15,7 @@
@par Revision Reference:
This PPI is defined in UEFI Platform Initialization Specification 1.2 Volume 1:
- Pre-EFI Initalization Core Interface
+ Pre-EFI Initialization Core Interface
**/
diff --git a/MdePkg/Include/Ppi/IsaHc.h b/MdePkg/Include/Ppi/IsaHc.h
index 5468c2e94b72..d7dfd9b47e8c 100644
--- a/MdePkg/Include/Ppi/IsaHc.h
+++ b/MdePkg/Include/Ppi/IsaHc.h
@@ -28,7 +28,7 @@ typedef struct _EFI_ISA_HC_PPI *PEFI_ISA_HC_PPI;
that more than one caller may be assigned to the same aperture.
It may be possible that a single hardware aperture may be used for more than
one device. This function tracks the number of times that each aperture is
- referenced, and doesa not close the hardware aperture (via CloseIoAperture())
+ referenced, and does not close the hardware aperture (via CloseIoAperture())
until there are no more references to it.
@param This A pointer to this instance of the EFI_ISA_HC_PPI.
diff --git a/MdePkg/Include/Ppi/MpServices.h b/MdePkg/Include/Ppi/MpServices.h
index afcd8819e9cc..5ea3373909e1 100644
--- a/MdePkg/Include/Ppi/MpServices.h
+++ b/MdePkg/Include/Ppi/MpServices.h
@@ -75,7 +75,7 @@ EFI_STATUS
);
/**
- Activate all of the application proessors.
+ Activate all of the application processors.
@param[in] PeiServices An indirect pointer to the PEI Services Table
published by the PEI Foundation.
diff --git a/MdePkg/Include/Ppi/Pcd.h b/MdePkg/Include/Ppi/Pcd.h
index 55fb0e7aea78..9341821af47a 100644
--- a/MdePkg/Include/Ppi/Pcd.h
+++ b/MdePkg/Include/Ppi/Pcd.h
@@ -137,7 +137,7 @@ UINT64
@param[in] TokenNumber The PCD token number.
- @return The pointer to the buffer to be retrived.
+ @return The pointer to the buffer to be retrieved.
**/
typedef
@@ -291,7 +291,7 @@ UINT64
@param[in] Guid The token space for the token number.
@param[in] TokenNumber The PCD token number.
- @return The pointer to the buffer to be retrived.
+ @return The pointer to the buffer to be retrieved.
**/
typedef
diff --git a/MdePkg/Include/Ppi/RecoveryModule.h b/MdePkg/Include/Ppi/RecoveryModule.h
index bb6b49160df6..6de937830464 100644
--- a/MdePkg/Include/Ppi/RecoveryModule.h
+++ b/MdePkg/Include/Ppi/RecoveryModule.h
@@ -36,7 +36,7 @@
@par Revision Reference:
This PPI is defined in UEFI Platform Initialization Specification 1.2 Errata B Volume 1:
- Pre-EFI Initalization Core Interface
+ Pre-EFI Initialization Core Interface
**/
diff --git a/MdePkg/Include/Ppi/TemporaryRamDone.h b/MdePkg/Include/Ppi/TemporaryRamDone.h
index ad149338a6ac..21c232ac9352 100644
--- a/MdePkg/Include/Ppi/TemporaryRamDone.h
+++ b/MdePkg/Include/Ppi/TemporaryRamDone.h
@@ -18,7 +18,7 @@
/**
TemporaryRamDone() disables the use of Temporary RAM. If present, this service is invoked
- by the PEI Foundation after the EFI_PEI_PERMANANT_MEMORY_INSTALLED_PPI is installed.
+ by the PEI Foundation after the EFI_PEI_PERMANENT_MEMORY_INSTALLED_PPI is installed.
@retval EFI_SUCCESS Use of Temporary RAM was disabled.
@retval EFI_INVALID_PARAMETER Temporary RAM could not be disabled.
diff --git a/MdePkg/Include/Ppi/VectorHandoffInfo.h b/MdePkg/Include/Ppi/VectorHandoffInfo.h
index ecfa3f5966c8..17f52ffd3d85 100644
--- a/MdePkg/Include/Ppi/VectorHandoffInfo.h
+++ b/MdePkg/Include/Ppi/VectorHandoffInfo.h
@@ -43,7 +43,7 @@ typedef struct {
//
UINT32 VectorNumber;
//
- // A bitmask that describes the attributes ofthe interrupt or exception vector.
+ // A bitmask that describes the attributes of the interrupt or exception vector.
//
UINT32 Attribute;
//
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [edk2-devel] [PATCH 29/79] MdePkg/Ppi: Fix various typos
2019-12-03 16:15 ` [PATCH 29/79] MdePkg/Ppi: " Philippe Mathieu-Daudé
@ 2019-12-04 1:29 ` Michael D Kinney
0 siblings, 0 replies; 122+ messages in thread
From: Michael D Kinney @ 2019-12-04 1:29 UTC (permalink / raw)
To: devel@edk2.groups.io, philmd@redhat.com, Kinney, Michael D
Cc: Antoine Coeur, Gao, Liming
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Philippe Mathieu-Daudé
> Sent: Tuesday, December 3, 2019 8:15 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Philippe Mathieu-Daude
> <philmd@redhat.com>
> Subject: [edk2-devel] [PATCH 29/79] MdePkg/Ppi: Fix
> various typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude
> <philmd@redhat.com>
> ---
> MdePkg/Include/Ppi/BlockIo.h | 4 ++--
> MdePkg/Include/Ppi/BlockIo2.h | 2 +-
> MdePkg/Include/Ppi/Capsule.h | 2 +-
> MdePkg/Include/Ppi/Decompress.h | 2 +-
> MdePkg/Include/Ppi/DeviceRecoveryModule.h | 2 +-
> MdePkg/Include/Ppi/IsaHc.h | 2 +-
> MdePkg/Include/Ppi/MpServices.h | 2 +-
> MdePkg/Include/Ppi/Pcd.h | 4 ++--
> MdePkg/Include/Ppi/RecoveryModule.h | 2 +-
> MdePkg/Include/Ppi/TemporaryRamDone.h | 2 +-
> MdePkg/Include/Ppi/VectorHandoffInfo.h | 2 +-
> 11 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/MdePkg/Include/Ppi/BlockIo.h
> b/MdePkg/Include/Ppi/BlockIo.h
> index 524f026fe589..3a4955be6b59 100644
> --- a/MdePkg/Include/Ppi/BlockIo.h
> +++ b/MdePkg/Include/Ppi/BlockIo.h
> @@ -15,7 +15,7 @@ SPDX-License-Identifier: BSD-2-
> Clause-Patent
>
> @par Revision Reference:
> This PPI is defined in UEFI Platform Initialization
> Specification 1.2 Volume 1:
> - Pre-EFI Initalization Core Interface.
> + Pre-EFI Initialization Core Interface.
>
> **/
>
> @@ -58,7 +58,7 @@ typedef enum {
> /// Specification inconsistency here:
> /// PEI_BLOCK_IO_MEDIA has been changed to
> EFI_PEI_BLOCK_IO_MEDIA.
> /// Inconsistency exists in UEFI Platform
> Initialization Specification 1.2
> -/// Volume 1: Pre-EFI Initalization Core Interface,
> where all referrences to
> +/// Volume 1: Pre-EFI Initialization Core Interface,
> where all references to
> /// this structure name are with the "EFI_" prefix,
> except for the definition
> /// which is without "EFI_". So the name of
> PEI_BLOCK_IO_MEDIA is taken as the
> /// exception, and EFI_PEI_BLOCK_IO_MEDIA is used to
> comply with most of
> diff --git a/MdePkg/Include/Ppi/BlockIo2.h
> b/MdePkg/Include/Ppi/BlockIo2.h
> index e1af6a4293ed..0dba6485d941 100644
> --- a/MdePkg/Include/Ppi/BlockIo2.h
> +++ b/MdePkg/Include/Ppi/BlockIo2.h
> @@ -7,7 +7,7 @@ SPDX-License-Identifier: BSD-2-Clause-
> Patent
>
> @par Revision Reference:
> This PPI is defined in UEFI Platform Initialization
> Specification 1.4 Volume 1:
> - Pre-EFI Initalization Core Interface.
> + Pre-EFI Initialization Core Interface.
>
> **/
>
> diff --git a/MdePkg/Include/Ppi/Capsule.h
> b/MdePkg/Include/Ppi/Capsule.h
> index cb7b0e2ae76a..331d9b81cad2 100644
> --- a/MdePkg/Include/Ppi/Capsule.h
> +++ b/MdePkg/Include/Ppi/Capsule.h
> @@ -45,7 +45,7 @@ typedef struct _EFI_PEI_CAPSULE_PPI
> PEI_CAPSULE_PPI;
> On output, this variable
> will contain the size of the
> coalesced capsule.
>
> - @retval EFI_NOT_FOUND If: boot modecould
> not be determined, or the
> + @retval EFI_NOT_FOUND If: boot mode could
> not be determined, or the
> boot mode is not
> flash-update, or the capsule descriptors were not
> found.
> @retval EFI_BUFFER_TOO_SMALL The capsule could not
> be coalesced in the provided memory region.
> @retval EFI_SUCCESS There was no capsule,
> or the capsule was processed successfully.
> diff --git a/MdePkg/Include/Ppi/Decompress.h
> b/MdePkg/Include/Ppi/Decompress.h
> index 7ba26e419c59..b9ca63746ab2 100644
> --- a/MdePkg/Include/Ppi/Decompress.h
> +++ b/MdePkg/Include/Ppi/Decompress.h
> @@ -1,5 +1,5 @@
> /** @file
> - Provides decompression services to the PEI
> Foundatoin.
> + Provides decompression services to the PEI
> Foundation.
>
> Copyright (c) 2006 - 2018, Intel Corporation. All
> rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> diff --git a/MdePkg/Include/Ppi/DeviceRecoveryModule.h
> b/MdePkg/Include/Ppi/DeviceRecoveryModule.h
> index a4587255a3c8..64dabec1139c 100644
> --- a/MdePkg/Include/Ppi/DeviceRecoveryModule.h
> +++ b/MdePkg/Include/Ppi/DeviceRecoveryModule.h
> @@ -15,7 +15,7 @@
>
> @par Revision Reference:
> This PPI is defined in UEFI Platform Initialization
> Specification 1.2 Volume 1:
> - Pre-EFI Initalization Core Interface
> + Pre-EFI Initialization Core Interface
>
> **/
>
> diff --git a/MdePkg/Include/Ppi/IsaHc.h
> b/MdePkg/Include/Ppi/IsaHc.h
> index 5468c2e94b72..d7dfd9b47e8c 100644
> --- a/MdePkg/Include/Ppi/IsaHc.h
> +++ b/MdePkg/Include/Ppi/IsaHc.h
> @@ -28,7 +28,7 @@ typedef struct _EFI_ISA_HC_PPI
> *PEFI_ISA_HC_PPI;
> that more than one caller may be assigned to the
> same aperture.
> It may be possible that a single hardware aperture
> may be used for more than
> one device. This function tracks the number of times
> that each aperture is
> - referenced, and doesa not close the hardware
> aperture (via CloseIoAperture())
> + referenced, and does not close the hardware aperture
> (via CloseIoAperture())
> until there are no more references to it.
>
> @param This A pointer to this instance
> of the EFI_ISA_HC_PPI.
> diff --git a/MdePkg/Include/Ppi/MpServices.h
> b/MdePkg/Include/Ppi/MpServices.h
> index afcd8819e9cc..5ea3373909e1 100644
> --- a/MdePkg/Include/Ppi/MpServices.h
> +++ b/MdePkg/Include/Ppi/MpServices.h
> @@ -75,7 +75,7 @@ EFI_STATUS
> );
>
> /**
> - Activate all of the application proessors.
> + Activate all of the application processors.
>
> @param[in] PeiServices An indirect pointer
> to the PEI Services Table
> published by the PEI
> Foundation.
> diff --git a/MdePkg/Include/Ppi/Pcd.h
> b/MdePkg/Include/Ppi/Pcd.h
> index 55fb0e7aea78..9341821af47a 100644
> --- a/MdePkg/Include/Ppi/Pcd.h
> +++ b/MdePkg/Include/Ppi/Pcd.h
> @@ -137,7 +137,7 @@ UINT64
>
> @param[in] TokenNumber The PCD token number.
>
> - @return The pointer to the buffer to be retrived.
> + @return The pointer to the buffer to be retrieved.
>
> **/
> typedef
> @@ -291,7 +291,7 @@ UINT64
> @param[in] Guid The token space for the
> token number.
> @param[in] TokenNumber The PCD token number.
>
> - @return The pointer to the buffer to be retrived.
> + @return The pointer to the buffer to be retrieved.
>
> **/
> typedef
> diff --git a/MdePkg/Include/Ppi/RecoveryModule.h
> b/MdePkg/Include/Ppi/RecoveryModule.h
> index bb6b49160df6..6de937830464 100644
> --- a/MdePkg/Include/Ppi/RecoveryModule.h
> +++ b/MdePkg/Include/Ppi/RecoveryModule.h
> @@ -36,7 +36,7 @@
>
> @par Revision Reference:
> This PPI is defined in UEFI Platform Initialization
> Specification 1.2 Errata B Volume 1:
> - Pre-EFI Initalization Core Interface
> + Pre-EFI Initialization Core Interface
>
> **/
>
> diff --git a/MdePkg/Include/Ppi/TemporaryRamDone.h
> b/MdePkg/Include/Ppi/TemporaryRamDone.h
> index ad149338a6ac..21c232ac9352 100644
> --- a/MdePkg/Include/Ppi/TemporaryRamDone.h
> +++ b/MdePkg/Include/Ppi/TemporaryRamDone.h
> @@ -18,7 +18,7 @@
>
> /**
> TemporaryRamDone() disables the use of Temporary
> RAM. If present, this service is invoked
> - by the PEI Foundation after the
> EFI_PEI_PERMANANT_MEMORY_INSTALLED_PPI is installed.
> + by the PEI Foundation after the
> EFI_PEI_PERMANENT_MEMORY_INSTALLED_PPI is installed.
>
> @retval EFI_SUCCESS Use of Temporary RAM
> was disabled.
> @retval EFI_INVALID_PARAMETER Temporary RAM could
> not be disabled.
> diff --git a/MdePkg/Include/Ppi/VectorHandoffInfo.h
> b/MdePkg/Include/Ppi/VectorHandoffInfo.h
> index ecfa3f5966c8..17f52ffd3d85 100644
> --- a/MdePkg/Include/Ppi/VectorHandoffInfo.h
> +++ b/MdePkg/Include/Ppi/VectorHandoffInfo.h
> @@ -43,7 +43,7 @@ typedef struct {
> //
> UINT32 VectorNumber;
> //
> - // A bitmask that describes the attributes ofthe
> interrupt or exception vector.
> + // A bitmask that describes the attributes of the
> interrupt or exception vector.
> //
> UINT32 Attribute;
> //
> --
> 2.21.0
>
>
>
^ permalink raw reply [flat|nested] 122+ messages in thread
* [PATCH 30/79] MdePkg/Register: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (28 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 29/79] MdePkg/Ppi: " Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-04 1:30 ` [edk2-devel] " Michael D Kinney
2019-12-03 16:15 ` [PATCH 31/79] NetworkPkg: Fix a typo Philippe Mathieu-Daudé
` (42 subsequent siblings)
72 siblings, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel; +Cc: Antoine Coeur, Michael D Kinney, Liming Gao,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdePkg/Include/Register/Amd/Cpuid.h | 8 ++++----
MdePkg/Include/Register/Amd/Fam17Msr.h | 2 +-
MdePkg/Include/Register/Amd/Msr.h | 2 +-
MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h | 2 +-
MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h | 2 +-
MdePkg/Include/Register/Intel/StmResourceDescriptor.h | 2 +-
6 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/MdePkg/Include/Register/Amd/Cpuid.h b/MdePkg/Include/Register/Amd/Cpuid.h
index ad1ba4d016e0..8e91e84b767f 100644
--- a/MdePkg/Include/Register/Amd/Cpuid.h
+++ b/MdePkg/Include/Register/Amd/Cpuid.h
@@ -11,7 +11,7 @@
SPDX-License-Identifier: BSD-2-Clause-Patent
@par Specification Reference:
- AMD64 Architecture Programming Manaul volume 2, March 2017, Sections 15.34
+ AMD64 Architecture Programming Manual volume 2, March 2017, Sections 15.34
**/
@@ -364,7 +364,7 @@ typedef union {
///
UINT32 Page1GB:1;
///
- /// [Bit 27] RDTSCP intructions.
+ /// [Bit 27] RDTSCP instructions.
///
UINT32 RDTSCP:1;
///
@@ -513,9 +513,9 @@ typedef union {
@retval EAX Extended APIC ID described by the type
CPUID_AMD_PROCESSOR_TOPOLOGY_EAX.
- @retval EBX Core Indentifiers described by the type
+ @retval EBX Core Identifiers described by the type
CPUID_AMD_PROCESSOR_TOPOLOGY_EBX.
- @retval ECX Node Indentifiers described by the type
+ @retval ECX Node Identifiers described by the type
CPUID_AMD_PROCESSOR_TOPOLOGY_ECX.
@retval EDX Reserved.
**/
diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h b/MdePkg/Include/Register/Amd/Fam17Msr.h
index 37b935dcdb30..6ef45a9b21d3 100644
--- a/MdePkg/Include/Register/Amd/Fam17Msr.h
+++ b/MdePkg/Include/Register/Amd/Fam17Msr.h
@@ -10,7 +10,7 @@
SPDX-License-Identifier: BSD-2-Clause-Patent
@par Specification Reference:
- AMD64 Architecture Programming Manaul volume 2, March 2017, Sections 15.34
+ AMD64 Architecture Programming Manual volume 2, March 2017, Sections 15.34
**/
diff --git a/MdePkg/Include/Register/Amd/Msr.h b/MdePkg/Include/Register/Amd/Msr.h
index e74de7a1df48..084eb892cdd9 100644
--- a/MdePkg/Include/Register/Amd/Msr.h
+++ b/MdePkg/Include/Register/Amd/Msr.h
@@ -10,7 +10,7 @@
SPDX-License-Identifier: BSD-2-Clause-Patent
@par Specification Reference:
- AMD64 Architecture Programming Manaul volume 2, March 2017, Sections 15.34
+ AMD64 Architecture Programming Manual volume 2, March 2017, Sections 15.34
**/
diff --git a/MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h b/MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
index 2edc1363b7c4..c56d20df66a4 100644
--- a/MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
+++ b/MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
@@ -1,5 +1,5 @@
/** @file
- MSR Defintions for Intel Atom processors based on the Goldmont Plus microarchitecture.
+ MSR Definitions for Intel Atom processors based on the Goldmont Plus microarchitecture.
Provides defines for Machine Specific Registers(MSR) indexes. Data structures
are provided for MSRs that contain one or more bit fields. If the MSR value
diff --git a/MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h b/MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h
index 30f96f0e82fa..03cac77c19a6 100644
--- a/MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h
+++ b/MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h
@@ -1,5 +1,5 @@
/** @file
- MSR Defintions for Intel processors based on the Skylake/Kabylake/Coffeelake/Cannonlake microarchitecture.
+ MSR Definitions for Intel processors based on the Skylake/Kabylake/Coffeelake/Cannonlake microarchitecture.
Provides defines for Machine Specific Registers(MSR) indexes. Data structures
are provided for MSRs that contain one or more bit fields. If the MSR value
diff --git a/MdePkg/Include/Register/Intel/StmResourceDescriptor.h b/MdePkg/Include/Register/Intel/StmResourceDescriptor.h
index da4c91d0f4b8..3e426701e83c 100644
--- a/MdePkg/Include/Register/Intel/StmResourceDescriptor.h
+++ b/MdePkg/Include/Register/Intel/StmResourceDescriptor.h
@@ -179,7 +179,7 @@ typedef struct {
} STM_RSC_ALL_RESOURCES_DESC;
/**
- STM Register Volation Descriptor
+ STM Register Violation Descriptor
**/
typedef struct {
STM_RSC_DESC_HEADER Hdr;
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [edk2-devel] [PATCH 30/79] MdePkg/Register: Fix various typos
2019-12-03 16:15 ` [PATCH 30/79] MdePkg/Register: " Philippe Mathieu-Daudé
@ 2019-12-04 1:30 ` Michael D Kinney
0 siblings, 0 replies; 122+ messages in thread
From: Michael D Kinney @ 2019-12-04 1:30 UTC (permalink / raw)
To: devel@edk2.groups.io, philmd@redhat.com, Kinney, Michael D
Cc: Antoine Coeur, Gao, Liming
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Philippe Mathieu-Daudé
> Sent: Tuesday, December 3, 2019 8:15 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Philippe Mathieu-Daude
> <philmd@redhat.com>
> Subject: [edk2-devel] [PATCH 30/79] MdePkg/Register:
> Fix various typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude
> <philmd@redhat.com>
> ---
> MdePkg/Include/Register/Amd/Cpuid.h
> | 8 ++++----
> MdePkg/Include/Register/Amd/Fam17Msr.h
> | 2 +-
> MdePkg/Include/Register/Amd/Msr.h
> | 2 +-
> MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
> | 2 +-
> MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h
> | 2 +-
> MdePkg/Include/Register/Intel/StmResourceDescriptor.h
> | 2 +-
> 6 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/MdePkg/Include/Register/Amd/Cpuid.h
> b/MdePkg/Include/Register/Amd/Cpuid.h
> index ad1ba4d016e0..8e91e84b767f 100644
> --- a/MdePkg/Include/Register/Amd/Cpuid.h
> +++ b/MdePkg/Include/Register/Amd/Cpuid.h
> @@ -11,7 +11,7 @@
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @par Specification Reference:
> - AMD64 Architecture Programming Manaul volume 2,
> March 2017, Sections 15.34
> + AMD64 Architecture Programming Manual volume 2,
> March 2017, Sections 15.34
>
> **/
>
> @@ -364,7 +364,7 @@ typedef union {
> ///
> UINT32 Page1GB:1;
> ///
> - /// [Bit 27] RDTSCP intructions.
> + /// [Bit 27] RDTSCP instructions.
> ///
> UINT32 RDTSCP:1;
> ///
> @@ -513,9 +513,9 @@ typedef union {
>
> @retval EAX Extended APIC ID described by the type
> CPUID_AMD_PROCESSOR_TOPOLOGY_EAX.
> - @retval EBX Core Indentifiers described by the
> type
> + @retval EBX Core Identifiers described by the type
> CPUID_AMD_PROCESSOR_TOPOLOGY_EBX.
> - @retval ECX Node Indentifiers described by the
> type
> + @retval ECX Node Identifiers described by the type
> CPUID_AMD_PROCESSOR_TOPOLOGY_ECX.
> @retval EDX Reserved.
> **/
> diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h
> b/MdePkg/Include/Register/Amd/Fam17Msr.h
> index 37b935dcdb30..6ef45a9b21d3 100644
> --- a/MdePkg/Include/Register/Amd/Fam17Msr.h
> +++ b/MdePkg/Include/Register/Amd/Fam17Msr.h
> @@ -10,7 +10,7 @@
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @par Specification Reference:
> - AMD64 Architecture Programming Manaul volume 2,
> March 2017, Sections 15.34
> + AMD64 Architecture Programming Manual volume 2,
> March 2017, Sections 15.34
>
> **/
>
> diff --git a/MdePkg/Include/Register/Amd/Msr.h
> b/MdePkg/Include/Register/Amd/Msr.h
> index e74de7a1df48..084eb892cdd9 100644
> --- a/MdePkg/Include/Register/Amd/Msr.h
> +++ b/MdePkg/Include/Register/Amd/Msr.h
> @@ -10,7 +10,7 @@
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @par Specification Reference:
> - AMD64 Architecture Programming Manaul volume 2,
> March 2017, Sections 15.34
> + AMD64 Architecture Programming Manual volume 2,
> March 2017, Sections 15.34
>
> **/
>
> diff --git
> a/MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
> b/MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
> index 2edc1363b7c4..c56d20df66a4 100644
> ---
> a/MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
> +++
> b/MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
> @@ -1,5 +1,5 @@
> /** @file
> - MSR Defintions for Intel Atom processors based on
> the Goldmont Plus microarchitecture.
> + MSR Definitions for Intel Atom processors based on
> the Goldmont Plus microarchitecture.
>
> Provides defines for Machine Specific Registers(MSR)
> indexes. Data structures
> are provided for MSRs that contain one or more bit
> fields. If the MSR value
> diff --git
> a/MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h
> b/MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h
> index 30f96f0e82fa..03cac77c19a6 100644
> --- a/MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h
> +++ b/MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h
> @@ -1,5 +1,5 @@
> /** @file
> - MSR Defintions for Intel processors based on the
> Skylake/Kabylake/Coffeelake/Cannonlake
> microarchitecture.
> + MSR Definitions for Intel processors based on the
> Skylake/Kabylake/Coffeelake/Cannonlake
> microarchitecture.
>
> Provides defines for Machine Specific Registers(MSR)
> indexes. Data structures
> are provided for MSRs that contain one or more bit
> fields. If the MSR value
> diff --git
> a/MdePkg/Include/Register/Intel/StmResourceDescriptor.h
> b/MdePkg/Include/Register/Intel/StmResourceDescriptor.h
> index da4c91d0f4b8..3e426701e83c 100644
> ---
> a/MdePkg/Include/Register/Intel/StmResourceDescriptor.h
> +++
> b/MdePkg/Include/Register/Intel/StmResourceDescriptor.h
> @@ -179,7 +179,7 @@ typedef struct {
> } STM_RSC_ALL_RESOURCES_DESC;
>
> /**
> - STM Register Volation Descriptor
> + STM Register Violation Descriptor
> **/
> typedef struct {
> STM_RSC_DESC_HEADER Hdr;
> --
> 2.21.0
>
>
>
^ permalink raw reply [flat|nested] 122+ messages in thread
* [PATCH 31/79] NetworkPkg: Fix a typo
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (29 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 30/79] MdePkg/Register: " Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-03 17:18 ` Leif Lindholm
2019-12-03 16:15 ` [PATCH 32/79] NetworkPkg/ArpDxe: Fix various typos Philippe Mathieu-Daudé
` (41 subsequent siblings)
72 siblings, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel
Cc: Philippe Mathieu-Daude, Antoine Cœur, Andrew Fish,
Laszlo Ersek, Leif Lindholm, Michael D Kinney
Correctly write 'malformatted' in documentation, comments and
debug strings.
Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/Dhcp4Dxe/Dhcp4Option.h | 6 +++---
NetworkPkg/Ip4Dxe/Ip4Icmp.h | 2 +-
NetworkPkg/Ip4Dxe/Ip4Igmp.h | 2 +-
NetworkPkg/Ip4Dxe/Ip4Option.h | 4 ++--
NetworkPkg/Ip6Dxe/Ip6Icmp.h | 4 ++--
NetworkPkg/Mtftp4Dxe/Mtftp4Option.h | 4 ++--
NetworkPkg/Dhcp4Dxe/Dhcp4Option.c | 10 +++++-----
NetworkPkg/Ip4Dxe/Ip4Icmp.c | 2 +-
NetworkPkg/Ip4Dxe/Ip4Igmp.c | 2 +-
NetworkPkg/Ip4Dxe/Ip4Option.c | 2 +-
NetworkPkg/Ip6Dxe/Ip6Icmp.c | 4 ++--
NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 10 +++++-----
NetworkPkg/Mtftp4Dxe/Mtftp4Option.c | 6 +++---
NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c | 2 +-
NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c | 2 +-
NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c | 2 +-
NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c | 2 +-
17 files changed, 33 insertions(+), 33 deletions(-)
diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
index 9e25386507ed..393176c8996d 100644
--- a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
+++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
@@ -133,7 +133,7 @@ DhcpIterateOptions (
@param[out] Para The variable to save the DHCP parameters.
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory to validate the packet.
- @retval EFI_INVALID_PARAMETER The options are mal-formated
+ @retval EFI_INVALID_PARAMETER The options are malformatted
@retval EFI_SUCCESS The options are parsed into OptionPoint
**/
@@ -167,7 +167,7 @@ DhcpValidateOptions (
@retval EFI_NOT_FOUND Cannot find any option.
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory to parse the packet.
- @retval EFI_INVALID_PARAMETER The options are mal-formated
+ @retval EFI_INVALID_PARAMETER The options are malformatted
@retval EFI_SUCCESS The options are parsed into OptionPoint
**/
@@ -211,7 +211,7 @@ DhcpAppendOption (
function.
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory
- @retval EFI_INVALID_PARAMETER The options in SeekPacket are mal-formated
+ @retval EFI_INVALID_PARAMETER The options in SeekPacket are malformatted
@retval EFI_SUCCESS The packet is build.
**/
diff --git a/NetworkPkg/Ip4Dxe/Ip4Icmp.h b/NetworkPkg/Ip4Dxe/Ip4Icmp.h
index 922886a96e67..a52200176f5a 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Icmp.h
+++ b/NetworkPkg/Ip4Dxe/Ip4Icmp.h
@@ -83,7 +83,7 @@ extern EFI_IP4_ICMP_TYPE mIp4SupportedIcmp[];
@param[in] Packet The content of the ICMP query with IP4 head
removed.
- @retval EFI_INVALID_PARAMETER The packet is malformated.
+ @retval EFI_INVALID_PARAMETER The packet is malformatted.
@retval EFI_SUCCESS The ICMP message is successfully processed.
@retval Others Failed to handle ICMP packet.
diff --git a/NetworkPkg/Ip4Dxe/Ip4Igmp.h b/NetworkPkg/Ip4Dxe/Ip4Igmp.h
index 0cc944594441..49c13ba3a7a0 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Igmp.h
+++ b/NetworkPkg/Ip4Dxe/Ip4Igmp.h
@@ -111,7 +111,7 @@ Ip4LeaveGroup (
@param[in] Head The IP4 header of the received message.
@param[in] Packet The IGMP message, without IP4 header.
- @retval EFI_INVALID_PARAMETER The IGMP message is malformated.
+ @retval EFI_INVALID_PARAMETER The IGMP message is malformatted.
@retval EFI_SUCCESS The IGMP message is successfully processed.
**/
diff --git a/NetworkPkg/Ip4Dxe/Ip4Option.h b/NetworkPkg/Ip4Dxe/Ip4Option.h
index 57a5a58725f0..a39fd2b4c69d 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Option.h
+++ b/NetworkPkg/Ip4Dxe/Ip4Option.h
@@ -20,7 +20,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
/**
Validate the IP4 option format for both the packets we received
and will transmit. It will compute the ICMP error message fields
- if the option is mal-formated. But this information isn't used.
+ if the option is malformatted. But this information isn't used.
@param[in] Option The first byte of the option
@param[in] OptionLen The length of the whole option
@@ -28,7 +28,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
otherwise the option we wants to transmit.
@retval TRUE The option is properly formatted
- @retval FALSE The option is mal-formated
+ @retval FALSE The option is malformatted
**/
BOOLEAN
diff --git a/NetworkPkg/Ip6Dxe/Ip6Icmp.h b/NetworkPkg/Ip6Dxe/Ip6Icmp.h
index 49a65f296adb..c63adb009519 100644
--- a/NetworkPkg/Ip6Dxe/Ip6Icmp.h
+++ b/NetworkPkg/Ip6Dxe/Ip6Icmp.h
@@ -35,7 +35,7 @@ extern EFI_IP6_ICMP_TYPE mIp6SupportedIcmp[];
@param[in] Packet The content of the ICMPv6 packet with IP head
removed.
- @retval EFI_INVALID_PARAMETER The packet is malformated.
+ @retval EFI_INVALID_PARAMETER The packet is malformatted.
@retval EFI_SUCCESS The ICMPv6 message successfully processed.
@retval Others Failed to handle the ICMPv6 packet.
@@ -80,7 +80,7 @@ Ip6IsAnycast (
@param[in] Pointer If not NULL, identifies the octet offset within
the invoking packet where the error was detected.
- @retval EFI_INVALID_PARAMETER The packet is malformated.
+ @retval EFI_INVALID_PARAMETER The packet is malformatted.
@retval EFI_OUT_OF_RESOURCES There is no sufficient resource to complete the
operation.
@retval EFI_SUCCESS The ICMPv6 message was successfully sent out.
diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h
index fcc4cbe8fdef..7bfe706f88c6 100644
--- a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h
+++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h
@@ -70,7 +70,7 @@ Mtftp4ExtractOptions (
@param Operation The current performed operation.
@param MtftpOption The MTFTP4_OPTION for easy access.
- @retval EFI_INVALID_PARAMETER The option is mal-formated
+ @retval EFI_INVALID_PARAMETER The option is malformatted
@retval EFI_UNSUPPORTED Some option isn't supported
@retval EFI_SUCCESS The option are OK and has been parsed.
@@ -93,7 +93,7 @@ Mtftp4ParseOption (
@param Operation The current performed operation.
@param MtftpOption The MTFTP_OPTION for easy access.
- @retval EFI_INVALID_PARAMETER The packet option is mal-formated
+ @retval EFI_INVALID_PARAMETER The packet option is malformatted
@retval EFI_UNSUPPORTED Some option isn't supported
@retval EFI_SUCCESS The option are OK and has been parsed.
diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c
index 3adbf55d0612..3b077de11177 100644
--- a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c
+++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c
@@ -230,7 +230,7 @@ DhcpOptionIsValid (
@param[out] Para The variable to save the interested parameter
@retval EFI_SUCCESS The DHCP option is successfully extracted.
- @retval EFI_INVALID_PARAMETER The DHCP option is mal-formated
+ @retval EFI_INVALID_PARAMETER The DHCP option is malformatted
**/
EFI_STATUS
@@ -303,7 +303,7 @@ DhcpGetParameter (
option.
@retval EFI_SUCCESS All the options are valid
- @retval EFI_INVALID_PARAMETER The options are mal-formated.
+ @retval EFI_INVALID_PARAMETER The options are malformatted.
**/
EFI_STATUS
@@ -538,7 +538,7 @@ DhcpFillOption (
@retval EFI_NOT_FOUND Cannot find any option.
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory to parse the packet.
- @retval EFI_INVALID_PARAMETER The options are mal-formated
+ @retval EFI_INVALID_PARAMETER The options are malformatted
@retval EFI_SUCCESS The options are parsed into OptionPoint
**/
@@ -639,7 +639,7 @@ ON_EXIT:
@param[out] Para The variable to save the DHCP parameters.
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory to validate the packet.
- @retval EFI_INVALID_PARAMETER The options are mal-formated
+ @retval EFI_INVALID_PARAMETER The options are malformatted
@retval EFI_SUCCESS The options are parsed into OptionPoint
**/
@@ -770,7 +770,7 @@ DhcpAppendOption (
function.
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory
- @retval EFI_INVALID_PARAMETER The options in SeekPacket are mal-formated
+ @retval EFI_INVALID_PARAMETER The options in SeekPacket are malformatted
@retval EFI_SUCCESS The packet is build.
**/
diff --git a/NetworkPkg/Ip4Dxe/Ip4Icmp.c b/NetworkPkg/Ip4Dxe/Ip4Icmp.c
index 052d6b77f79a..833ffa74ff0d 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Icmp.c
+++ b/NetworkPkg/Ip4Dxe/Ip4Icmp.c
@@ -319,7 +319,7 @@ Ip4ProcessIcmpQuery (
@param[in] Packet The content of the ICMP query with IP4 head
removed.
- @retval EFI_INVALID_PARAMETER The packet is malformated.
+ @retval EFI_INVALID_PARAMETER The packet is malformatted.
@retval EFI_SUCCESS The ICMP message is successfully processed.
@retval Others Failed to handle ICMP packet.
diff --git a/NetworkPkg/Ip4Dxe/Ip4Igmp.c b/NetworkPkg/Ip4Dxe/Ip4Igmp.c
index 41d9bce9717e..e69b2fe7fc08 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Igmp.c
+++ b/NetworkPkg/Ip4Dxe/Ip4Igmp.c
@@ -401,7 +401,7 @@ Ip4LeaveGroup (
@param[in] Head The IP4 header of the received message.
@param[in] Packet The IGMP message, without IP4 header.
- @retval EFI_INVALID_PARAMETER The IGMP message is malformated.
+ @retval EFI_INVALID_PARAMETER The IGMP message is malformatted.
@retval EFI_SUCCESS The IGMP message is successfully processed.
**/
diff --git a/NetworkPkg/Ip4Dxe/Ip4Option.c b/NetworkPkg/Ip4Dxe/Ip4Option.c
index f1c10014e85c..b3c598c64a38 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Option.c
+++ b/NetworkPkg/Ip4Dxe/Ip4Option.c
@@ -19,7 +19,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
otherwise the option we wants to transmit.
@retval TRUE The option is properly formatted
- @retval FALSE The option is mal-formated
+ @retval FALSE The option is malformatted
**/
BOOLEAN
diff --git a/NetworkPkg/Ip6Dxe/Ip6Icmp.c b/NetworkPkg/Ip6Dxe/Ip6Icmp.c
index 79fa34e0413f..bf9b17d907ef 100644
--- a/NetworkPkg/Ip6Dxe/Ip6Icmp.c
+++ b/NetworkPkg/Ip6Dxe/Ip6Icmp.c
@@ -393,7 +393,7 @@ Ip6ProcessIcmpInformation (
@param[in] Packet The content of the ICMPv6 packet with IP head
removed.
- @retval EFI_INVALID_PARAMETER The packet is malformated.
+ @retval EFI_INVALID_PARAMETER The packet is malformatted.
@retval EFI_SUCCESS The ICMPv6 message successfully processed.
@retval Others Failed to handle the ICMPv6 packet.
@@ -554,7 +554,7 @@ Ip6IsAnycast (
@param[in] Pointer If not NULL, identifies the octet offset within
the invoking packet where the error was detected.
- @retval EFI_INVALID_PARAMETER The packet is malformated.
+ @retval EFI_INVALID_PARAMETER The packet is malformatted.
@retval EFI_OUT_OF_RESOURCES There is no sufficient resource to complete the
operation.
@retval EFI_SUCCESS The ICMPv6 message was successfully sent out.
diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
index a39c20be3d34..4f8a1226dae7 100644
--- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
+++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
@@ -2983,7 +2983,7 @@ NetLibGetNicHandle (
@param[out] Ip4Address The pointer to the converted IPv4 address.
@retval EFI_SUCCESS Convert to IPv4 address successfully.
- @retval EFI_INVALID_PARAMETER The string is mal-formated or Ip4Address is NULL.
+ @retval EFI_INVALID_PARAMETER The string is malformatted or Ip4Address is NULL.
**/
EFI_STATUS
@@ -3013,7 +3013,7 @@ NetLibAsciiStrToIp4 (
@param[out] Ip6Address The pointer to the converted IPv6 address.
@retval EFI_SUCCESS Convert to IPv6 address successfully.
- @retval EFI_INVALID_PARAMETER The string is mal-formated or Ip6Address is NULL.
+ @retval EFI_INVALID_PARAMETER The string is malformatted or Ip6Address is NULL.
**/
EFI_STATUS
@@ -3042,7 +3042,7 @@ NetLibAsciiStrToIp6 (
@param[out] Ip4Address The pointer to the converted IPv4 address.
@retval EFI_SUCCESS Convert to IPv4 address successfully.
- @retval EFI_INVALID_PARAMETER The string is mal-formated or Ip4Address is NULL.
+ @retval EFI_INVALID_PARAMETER The string is malformatted or Ip4Address is NULL.
**/
EFI_STATUS
@@ -3072,7 +3072,7 @@ NetLibStrToIp4 (
@param[out] Ip6Address The pointer to the converted IPv6 address.
@retval EFI_SUCCESS Convert to IPv6 address successfully.
- @retval EFI_INVALID_PARAMETER The string is mal-formated or Ip6Address is NULL.
+ @retval EFI_INVALID_PARAMETER The string is malformatted or Ip6Address is NULL.
**/
EFI_STATUS
@@ -3103,7 +3103,7 @@ NetLibStrToIp6 (
@param[out] PrefixLength The pointer to the converted prefix length.
@retval EFI_SUCCESS Convert to IPv6 address successfully.
- @retval EFI_INVALID_PARAMETER The string is mal-formated or Ip6Address is NULL.
+ @retval EFI_INVALID_PARAMETER The string is malformatted or Ip6Address is NULL.
**/
EFI_STATUS
diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.c b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.c
index d97f157f1744..013fe008eee8 100644
--- a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.c
+++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.c
@@ -155,7 +155,7 @@ NetStringToIp (
options on output
@param Options The option array to fill in
- @retval EFI_INVALID_PARAMETER The packet is mal-formated
+ @retval EFI_INVALID_PARAMETER The packet is malformatted
@retval EFI_BUFFER_TOO_SMALL The Options array is too small
@retval EFI_SUCCESS The packet has been parsed into the Options array.
@@ -398,7 +398,7 @@ Mtftp4ExtractMcast (
@param Operation The current performed operation.
@param MtftpOption The MTFTP4_OPTION for easy access.
- @retval EFI_INVALID_PARAMETER The option is mal-formated
+ @retval EFI_INVALID_PARAMETER The option is malformatted
@retval EFI_UNSUPPORTED Some option isn't supported
@retval EFI_SUCCESS The option are OK and has been parsed.
@@ -516,7 +516,7 @@ Mtftp4ParseOption (
@param Operation The current performed operation.
@param MtftpOption The MTFTP_OPTION for easy access.
- @retval EFI_INVALID_PARAMETER The packet option is mal-formated
+ @retval EFI_INVALID_PARAMETER The packet option is malformatted
@retval EFI_UNSUPPORTED Some option isn't supported
@retval EFI_SUCCESS The option are OK and has been parsed.
diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c b/NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c
index 24c965afb580..8e1338221b12 100644
--- a/NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c
+++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c
@@ -533,7 +533,7 @@ Mtftp4RrqHandleOack (
Mtftp4SendError (
Instance,
EFI_MTFTP4_ERRORCODE_ILLEGAL_OPERATION,
- (UINT8 *) "Mal-formated OACK packet"
+ (UINT8 *) "Malformatted OACK packet"
);
}
diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c b/NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c
index 14156b801ee6..bd13244b999b 100644
--- a/NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c
+++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c
@@ -291,7 +291,7 @@ Mtftp4WrqHandleOack (
Mtftp4SendError (
Instance,
EFI_MTFTP4_ERRORCODE_ILLEGAL_OPERATION,
- (UINT8 *) "Mal-formated OACK packet"
+ (UINT8 *) "Malformatted OACK packet"
);
}
diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c b/NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c
index 897358e5f133..a830d432916c 100644
--- a/NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c
+++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c
@@ -517,7 +517,7 @@ Mtftp6RrqHandleOack (
Mtftp6SendError (
Instance,
EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION,
- (UINT8 *) "Mal-formated OACK packet"
+ (UINT8 *) "Malformatted OACK packet"
);
}
diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c b/NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c
index 2860f3870206..ce3315cc2c26 100644
--- a/NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c
+++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c
@@ -332,7 +332,7 @@ Mtftp6WrqHandleOack (
Mtftp6SendError (
Instance,
EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION,
- (UINT8 *) "Mal-formated OACK packet"
+ (UINT8 *) "Malformatted OACK packet"
);
}
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [PATCH 31/79] NetworkPkg: Fix a typo
2019-12-03 16:15 ` [PATCH 31/79] NetworkPkg: Fix a typo Philippe Mathieu-Daudé
@ 2019-12-03 17:18 ` Leif Lindholm
2019-12-03 17:20 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 122+ messages in thread
From: Leif Lindholm @ 2019-12-03 17:18 UTC (permalink / raw)
To: Philippe Mathieu-Daude
Cc: devel, Antoine Cœur, Andrew Fish, Laszlo Ersek,
Michael D Kinney, Jiaxin Wu, Siyuan Fu, Maciej Rabeda
Hi Phil,
On Tue, Dec 03, 2019 at 17:15:14 +0100, Philippe Mathieu-Daude wrote:
> Correctly write 'malformatted' in documentation, comments and
> debug strings.
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
I would have expected:
Jiaxin Wu <jiaxin.wu@intel.com>
Siyuan Fu <siyuan.fu@intel.com>
Maciej Rabeda <maciej.rabeda@intel.com>
to be cc:d on NetworkPkg patches (added here).
Was there a GetMaintainer.py failure?
/
Leif
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> NetworkPkg/Dhcp4Dxe/Dhcp4Option.h | 6 +++---
> NetworkPkg/Ip4Dxe/Ip4Icmp.h | 2 +-
> NetworkPkg/Ip4Dxe/Ip4Igmp.h | 2 +-
> NetworkPkg/Ip4Dxe/Ip4Option.h | 4 ++--
> NetworkPkg/Ip6Dxe/Ip6Icmp.h | 4 ++--
> NetworkPkg/Mtftp4Dxe/Mtftp4Option.h | 4 ++--
> NetworkPkg/Dhcp4Dxe/Dhcp4Option.c | 10 +++++-----
> NetworkPkg/Ip4Dxe/Ip4Icmp.c | 2 +-
> NetworkPkg/Ip4Dxe/Ip4Igmp.c | 2 +-
> NetworkPkg/Ip4Dxe/Ip4Option.c | 2 +-
> NetworkPkg/Ip6Dxe/Ip6Icmp.c | 4 ++--
> NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 10 +++++-----
> NetworkPkg/Mtftp4Dxe/Mtftp4Option.c | 6 +++---
> NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c | 2 +-
> NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c | 2 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c | 2 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c | 2 +-
> 17 files changed, 33 insertions(+), 33 deletions(-)
>
> diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
> index 9e25386507ed..393176c8996d 100644
> --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
> +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
> @@ -133,7 +133,7 @@ DhcpIterateOptions (
> @param[out] Para The variable to save the DHCP parameters.
>
> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to validate the packet.
> - @retval EFI_INVALID_PARAMETER The options are mal-formated
> + @retval EFI_INVALID_PARAMETER The options are malformatted
> @retval EFI_SUCCESS The options are parsed into OptionPoint
>
> **/
> @@ -167,7 +167,7 @@ DhcpValidateOptions (
>
> @retval EFI_NOT_FOUND Cannot find any option.
> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to parse the packet.
> - @retval EFI_INVALID_PARAMETER The options are mal-formated
> + @retval EFI_INVALID_PARAMETER The options are malformatted
> @retval EFI_SUCCESS The options are parsed into OptionPoint
>
> **/
> @@ -211,7 +211,7 @@ DhcpAppendOption (
> function.
>
> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory
> - @retval EFI_INVALID_PARAMETER The options in SeekPacket are mal-formated
> + @retval EFI_INVALID_PARAMETER The options in SeekPacket are malformatted
> @retval EFI_SUCCESS The packet is build.
>
> **/
> diff --git a/NetworkPkg/Ip4Dxe/Ip4Icmp.h b/NetworkPkg/Ip4Dxe/Ip4Icmp.h
> index 922886a96e67..a52200176f5a 100644
> --- a/NetworkPkg/Ip4Dxe/Ip4Icmp.h
> +++ b/NetworkPkg/Ip4Dxe/Ip4Icmp.h
> @@ -83,7 +83,7 @@ extern EFI_IP4_ICMP_TYPE mIp4SupportedIcmp[];
> @param[in] Packet The content of the ICMP query with IP4 head
> removed.
>
> - @retval EFI_INVALID_PARAMETER The packet is malformated.
> + @retval EFI_INVALID_PARAMETER The packet is malformatted.
> @retval EFI_SUCCESS The ICMP message is successfully processed.
> @retval Others Failed to handle ICMP packet.
>
> diff --git a/NetworkPkg/Ip4Dxe/Ip4Igmp.h b/NetworkPkg/Ip4Dxe/Ip4Igmp.h
> index 0cc944594441..49c13ba3a7a0 100644
> --- a/NetworkPkg/Ip4Dxe/Ip4Igmp.h
> +++ b/NetworkPkg/Ip4Dxe/Ip4Igmp.h
> @@ -111,7 +111,7 @@ Ip4LeaveGroup (
> @param[in] Head The IP4 header of the received message.
> @param[in] Packet The IGMP message, without IP4 header.
>
> - @retval EFI_INVALID_PARAMETER The IGMP message is malformated.
> + @retval EFI_INVALID_PARAMETER The IGMP message is malformatted.
> @retval EFI_SUCCESS The IGMP message is successfully processed.
>
> **/
> diff --git a/NetworkPkg/Ip4Dxe/Ip4Option.h b/NetworkPkg/Ip4Dxe/Ip4Option.h
> index 57a5a58725f0..a39fd2b4c69d 100644
> --- a/NetworkPkg/Ip4Dxe/Ip4Option.h
> +++ b/NetworkPkg/Ip4Dxe/Ip4Option.h
> @@ -20,7 +20,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> /**
> Validate the IP4 option format for both the packets we received
> and will transmit. It will compute the ICMP error message fields
> - if the option is mal-formated. But this information isn't used.
> + if the option is malformatted. But this information isn't used.
>
> @param[in] Option The first byte of the option
> @param[in] OptionLen The length of the whole option
> @@ -28,7 +28,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> otherwise the option we wants to transmit.
>
> @retval TRUE The option is properly formatted
> - @retval FALSE The option is mal-formated
> + @retval FALSE The option is malformatted
>
> **/
> BOOLEAN
> diff --git a/NetworkPkg/Ip6Dxe/Ip6Icmp.h b/NetworkPkg/Ip6Dxe/Ip6Icmp.h
> index 49a65f296adb..c63adb009519 100644
> --- a/NetworkPkg/Ip6Dxe/Ip6Icmp.h
> +++ b/NetworkPkg/Ip6Dxe/Ip6Icmp.h
> @@ -35,7 +35,7 @@ extern EFI_IP6_ICMP_TYPE mIp6SupportedIcmp[];
> @param[in] Packet The content of the ICMPv6 packet with IP head
> removed.
>
> - @retval EFI_INVALID_PARAMETER The packet is malformated.
> + @retval EFI_INVALID_PARAMETER The packet is malformatted.
> @retval EFI_SUCCESS The ICMPv6 message successfully processed.
> @retval Others Failed to handle the ICMPv6 packet.
>
> @@ -80,7 +80,7 @@ Ip6IsAnycast (
> @param[in] Pointer If not NULL, identifies the octet offset within
> the invoking packet where the error was detected.
>
> - @retval EFI_INVALID_PARAMETER The packet is malformated.
> + @retval EFI_INVALID_PARAMETER The packet is malformatted.
> @retval EFI_OUT_OF_RESOURCES There is no sufficient resource to complete the
> operation.
> @retval EFI_SUCCESS The ICMPv6 message was successfully sent out.
> diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h
> index fcc4cbe8fdef..7bfe706f88c6 100644
> --- a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h
> +++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h
> @@ -70,7 +70,7 @@ Mtftp4ExtractOptions (
> @param Operation The current performed operation.
> @param MtftpOption The MTFTP4_OPTION for easy access.
>
> - @retval EFI_INVALID_PARAMETER The option is mal-formated
> + @retval EFI_INVALID_PARAMETER The option is malformatted
> @retval EFI_UNSUPPORTED Some option isn't supported
> @retval EFI_SUCCESS The option are OK and has been parsed.
>
> @@ -93,7 +93,7 @@ Mtftp4ParseOption (
> @param Operation The current performed operation.
> @param MtftpOption The MTFTP_OPTION for easy access.
>
> - @retval EFI_INVALID_PARAMETER The packet option is mal-formated
> + @retval EFI_INVALID_PARAMETER The packet option is malformatted
> @retval EFI_UNSUPPORTED Some option isn't supported
> @retval EFI_SUCCESS The option are OK and has been parsed.
>
> diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c
> index 3adbf55d0612..3b077de11177 100644
> --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c
> +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c
> @@ -230,7 +230,7 @@ DhcpOptionIsValid (
> @param[out] Para The variable to save the interested parameter
>
> @retval EFI_SUCCESS The DHCP option is successfully extracted.
> - @retval EFI_INVALID_PARAMETER The DHCP option is mal-formated
> + @retval EFI_INVALID_PARAMETER The DHCP option is malformatted
>
> **/
> EFI_STATUS
> @@ -303,7 +303,7 @@ DhcpGetParameter (
> option.
>
> @retval EFI_SUCCESS All the options are valid
> - @retval EFI_INVALID_PARAMETER The options are mal-formated.
> + @retval EFI_INVALID_PARAMETER The options are malformatted.
>
> **/
> EFI_STATUS
> @@ -538,7 +538,7 @@ DhcpFillOption (
>
> @retval EFI_NOT_FOUND Cannot find any option.
> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to parse the packet.
> - @retval EFI_INVALID_PARAMETER The options are mal-formated
> + @retval EFI_INVALID_PARAMETER The options are malformatted
> @retval EFI_SUCCESS The options are parsed into OptionPoint
>
> **/
> @@ -639,7 +639,7 @@ ON_EXIT:
> @param[out] Para The variable to save the DHCP parameters.
>
> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to validate the packet.
> - @retval EFI_INVALID_PARAMETER The options are mal-formated
> + @retval EFI_INVALID_PARAMETER The options are malformatted
> @retval EFI_SUCCESS The options are parsed into OptionPoint
>
> **/
> @@ -770,7 +770,7 @@ DhcpAppendOption (
> function.
>
> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory
> - @retval EFI_INVALID_PARAMETER The options in SeekPacket are mal-formated
> + @retval EFI_INVALID_PARAMETER The options in SeekPacket are malformatted
> @retval EFI_SUCCESS The packet is build.
>
> **/
> diff --git a/NetworkPkg/Ip4Dxe/Ip4Icmp.c b/NetworkPkg/Ip4Dxe/Ip4Icmp.c
> index 052d6b77f79a..833ffa74ff0d 100644
> --- a/NetworkPkg/Ip4Dxe/Ip4Icmp.c
> +++ b/NetworkPkg/Ip4Dxe/Ip4Icmp.c
> @@ -319,7 +319,7 @@ Ip4ProcessIcmpQuery (
> @param[in] Packet The content of the ICMP query with IP4 head
> removed.
>
> - @retval EFI_INVALID_PARAMETER The packet is malformated.
> + @retval EFI_INVALID_PARAMETER The packet is malformatted.
> @retval EFI_SUCCESS The ICMP message is successfully processed.
> @retval Others Failed to handle ICMP packet.
>
> diff --git a/NetworkPkg/Ip4Dxe/Ip4Igmp.c b/NetworkPkg/Ip4Dxe/Ip4Igmp.c
> index 41d9bce9717e..e69b2fe7fc08 100644
> --- a/NetworkPkg/Ip4Dxe/Ip4Igmp.c
> +++ b/NetworkPkg/Ip4Dxe/Ip4Igmp.c
> @@ -401,7 +401,7 @@ Ip4LeaveGroup (
> @param[in] Head The IP4 header of the received message.
> @param[in] Packet The IGMP message, without IP4 header.
>
> - @retval EFI_INVALID_PARAMETER The IGMP message is malformated.
> + @retval EFI_INVALID_PARAMETER The IGMP message is malformatted.
> @retval EFI_SUCCESS The IGMP message is successfully processed.
>
> **/
> diff --git a/NetworkPkg/Ip4Dxe/Ip4Option.c b/NetworkPkg/Ip4Dxe/Ip4Option.c
> index f1c10014e85c..b3c598c64a38 100644
> --- a/NetworkPkg/Ip4Dxe/Ip4Option.c
> +++ b/NetworkPkg/Ip4Dxe/Ip4Option.c
> @@ -19,7 +19,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> otherwise the option we wants to transmit.
>
> @retval TRUE The option is properly formatted
> - @retval FALSE The option is mal-formated
> + @retval FALSE The option is malformatted
>
> **/
> BOOLEAN
> diff --git a/NetworkPkg/Ip6Dxe/Ip6Icmp.c b/NetworkPkg/Ip6Dxe/Ip6Icmp.c
> index 79fa34e0413f..bf9b17d907ef 100644
> --- a/NetworkPkg/Ip6Dxe/Ip6Icmp.c
> +++ b/NetworkPkg/Ip6Dxe/Ip6Icmp.c
> @@ -393,7 +393,7 @@ Ip6ProcessIcmpInformation (
> @param[in] Packet The content of the ICMPv6 packet with IP head
> removed.
>
> - @retval EFI_INVALID_PARAMETER The packet is malformated.
> + @retval EFI_INVALID_PARAMETER The packet is malformatted.
> @retval EFI_SUCCESS The ICMPv6 message successfully processed.
> @retval Others Failed to handle the ICMPv6 packet.
>
> @@ -554,7 +554,7 @@ Ip6IsAnycast (
> @param[in] Pointer If not NULL, identifies the octet offset within
> the invoking packet where the error was detected.
>
> - @retval EFI_INVALID_PARAMETER The packet is malformated.
> + @retval EFI_INVALID_PARAMETER The packet is malformatted.
> @retval EFI_OUT_OF_RESOURCES There is no sufficient resource to complete the
> operation.
> @retval EFI_SUCCESS The ICMPv6 message was successfully sent out.
> diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> index a39c20be3d34..4f8a1226dae7 100644
> --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> @@ -2983,7 +2983,7 @@ NetLibGetNicHandle (
> @param[out] Ip4Address The pointer to the converted IPv4 address.
>
> @retval EFI_SUCCESS Convert to IPv4 address successfully.
> - @retval EFI_INVALID_PARAMETER The string is mal-formated or Ip4Address is NULL.
> + @retval EFI_INVALID_PARAMETER The string is malformatted or Ip4Address is NULL.
>
> **/
> EFI_STATUS
> @@ -3013,7 +3013,7 @@ NetLibAsciiStrToIp4 (
> @param[out] Ip6Address The pointer to the converted IPv6 address.
>
> @retval EFI_SUCCESS Convert to IPv6 address successfully.
> - @retval EFI_INVALID_PARAMETER The string is mal-formated or Ip6Address is NULL.
> + @retval EFI_INVALID_PARAMETER The string is malformatted or Ip6Address is NULL.
>
> **/
> EFI_STATUS
> @@ -3042,7 +3042,7 @@ NetLibAsciiStrToIp6 (
> @param[out] Ip4Address The pointer to the converted IPv4 address.
>
> @retval EFI_SUCCESS Convert to IPv4 address successfully.
> - @retval EFI_INVALID_PARAMETER The string is mal-formated or Ip4Address is NULL.
> + @retval EFI_INVALID_PARAMETER The string is malformatted or Ip4Address is NULL.
>
> **/
> EFI_STATUS
> @@ -3072,7 +3072,7 @@ NetLibStrToIp4 (
> @param[out] Ip6Address The pointer to the converted IPv6 address.
>
> @retval EFI_SUCCESS Convert to IPv6 address successfully.
> - @retval EFI_INVALID_PARAMETER The string is mal-formated or Ip6Address is NULL.
> + @retval EFI_INVALID_PARAMETER The string is malformatted or Ip6Address is NULL.
>
> **/
> EFI_STATUS
> @@ -3103,7 +3103,7 @@ NetLibStrToIp6 (
> @param[out] PrefixLength The pointer to the converted prefix length.
>
> @retval EFI_SUCCESS Convert to IPv6 address successfully.
> - @retval EFI_INVALID_PARAMETER The string is mal-formated or Ip6Address is NULL.
> + @retval EFI_INVALID_PARAMETER The string is malformatted or Ip6Address is NULL.
>
> **/
> EFI_STATUS
> diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.c b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.c
> index d97f157f1744..013fe008eee8 100644
> --- a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.c
> +++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.c
> @@ -155,7 +155,7 @@ NetStringToIp (
> options on output
> @param Options The option array to fill in
>
> - @retval EFI_INVALID_PARAMETER The packet is mal-formated
> + @retval EFI_INVALID_PARAMETER The packet is malformatted
> @retval EFI_BUFFER_TOO_SMALL The Options array is too small
> @retval EFI_SUCCESS The packet has been parsed into the Options array.
>
> @@ -398,7 +398,7 @@ Mtftp4ExtractMcast (
> @param Operation The current performed operation.
> @param MtftpOption The MTFTP4_OPTION for easy access.
>
> - @retval EFI_INVALID_PARAMETER The option is mal-formated
> + @retval EFI_INVALID_PARAMETER The option is malformatted
> @retval EFI_UNSUPPORTED Some option isn't supported
> @retval EFI_SUCCESS The option are OK and has been parsed.
>
> @@ -516,7 +516,7 @@ Mtftp4ParseOption (
> @param Operation The current performed operation.
> @param MtftpOption The MTFTP_OPTION for easy access.
>
> - @retval EFI_INVALID_PARAMETER The packet option is mal-formated
> + @retval EFI_INVALID_PARAMETER The packet option is malformatted
> @retval EFI_UNSUPPORTED Some option isn't supported
> @retval EFI_SUCCESS The option are OK and has been parsed.
>
> diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c b/NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c
> index 24c965afb580..8e1338221b12 100644
> --- a/NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c
> +++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c
> @@ -533,7 +533,7 @@ Mtftp4RrqHandleOack (
> Mtftp4SendError (
> Instance,
> EFI_MTFTP4_ERRORCODE_ILLEGAL_OPERATION,
> - (UINT8 *) "Mal-formated OACK packet"
> + (UINT8 *) "Malformatted OACK packet"
> );
> }
>
> diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c b/NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c
> index 14156b801ee6..bd13244b999b 100644
> --- a/NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c
> +++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c
> @@ -291,7 +291,7 @@ Mtftp4WrqHandleOack (
> Mtftp4SendError (
> Instance,
> EFI_MTFTP4_ERRORCODE_ILLEGAL_OPERATION,
> - (UINT8 *) "Mal-formated OACK packet"
> + (UINT8 *) "Malformatted OACK packet"
> );
> }
>
> diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c b/NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c
> index 897358e5f133..a830d432916c 100644
> --- a/NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c
> +++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c
> @@ -517,7 +517,7 @@ Mtftp6RrqHandleOack (
> Mtftp6SendError (
> Instance,
> EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION,
> - (UINT8 *) "Mal-formated OACK packet"
> + (UINT8 *) "Malformatted OACK packet"
> );
> }
>
> diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c b/NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c
> index 2860f3870206..ce3315cc2c26 100644
> --- a/NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c
> +++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c
> @@ -332,7 +332,7 @@ Mtftp6WrqHandleOack (
> Mtftp6SendError (
> Instance,
> EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION,
> - (UINT8 *) "Mal-formated OACK packet"
> + (UINT8 *) "Malformatted OACK packet"
> );
> }
>
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 122+ messages in thread* Re: [PATCH 31/79] NetworkPkg: Fix a typo
2019-12-03 17:18 ` Leif Lindholm
@ 2019-12-03 17:20 ` Philippe Mathieu-Daudé
2019-12-04 14:02 ` [edk2-devel] " Maciej Rabeda
0 siblings, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 17:20 UTC (permalink / raw)
To: Leif Lindholm
Cc: devel, Antoine Cœur, Andrew Fish, Laszlo Ersek,
Michael D Kinney, Jiaxin Wu, Siyuan Fu, Maciej Rabeda
On 12/3/19 6:18 PM, Leif Lindholm wrote:
> Hi Phil,
>
> On Tue, Dec 03, 2019 at 17:15:14 +0100, Philippe Mathieu-Daude wrote:
>> Correctly write 'malformatted' in documentation, comments and
>> debug strings.
>>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>
> I would have expected:
> Jiaxin Wu <jiaxin.wu@intel.com>
> Siyuan Fu <siyuan.fu@intel.com>
> Maciej Rabeda <maciej.rabeda@intel.com>
> to be cc:d on NetworkPkg patches (added here).
> Was there a GetMaintainer.py failure?
Human failure due to manual edition :S
Thanks for caring to Cc to correct maintainers.
> /
> Leif
>
>> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
>> ---
>> NetworkPkg/Dhcp4Dxe/Dhcp4Option.h | 6 +++---
>> NetworkPkg/Ip4Dxe/Ip4Icmp.h | 2 +-
>> NetworkPkg/Ip4Dxe/Ip4Igmp.h | 2 +-
>> NetworkPkg/Ip4Dxe/Ip4Option.h | 4 ++--
>> NetworkPkg/Ip6Dxe/Ip6Icmp.h | 4 ++--
>> NetworkPkg/Mtftp4Dxe/Mtftp4Option.h | 4 ++--
>> NetworkPkg/Dhcp4Dxe/Dhcp4Option.c | 10 +++++-----
>> NetworkPkg/Ip4Dxe/Ip4Icmp.c | 2 +-
>> NetworkPkg/Ip4Dxe/Ip4Igmp.c | 2 +-
>> NetworkPkg/Ip4Dxe/Ip4Option.c | 2 +-
>> NetworkPkg/Ip6Dxe/Ip6Icmp.c | 4 ++--
>> NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 10 +++++-----
>> NetworkPkg/Mtftp4Dxe/Mtftp4Option.c | 6 +++---
>> NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c | 2 +-
>> NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c | 2 +-
>> NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c | 2 +-
>> NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c | 2 +-
>> 17 files changed, 33 insertions(+), 33 deletions(-)
>>
>> diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
>> index 9e25386507ed..393176c8996d 100644
>> --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
>> +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
>> @@ -133,7 +133,7 @@ DhcpIterateOptions (
>> @param[out] Para The variable to save the DHCP parameters.
>>
>> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to validate the packet.
>> - @retval EFI_INVALID_PARAMETER The options are mal-formated
>> + @retval EFI_INVALID_PARAMETER The options are malformatted
>> @retval EFI_SUCCESS The options are parsed into OptionPoint
>>
>> **/
>> @@ -167,7 +167,7 @@ DhcpValidateOptions (
>>
>> @retval EFI_NOT_FOUND Cannot find any option.
>> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to parse the packet.
>> - @retval EFI_INVALID_PARAMETER The options are mal-formated
>> + @retval EFI_INVALID_PARAMETER The options are malformatted
>> @retval EFI_SUCCESS The options are parsed into OptionPoint
>>
>> **/
>> @@ -211,7 +211,7 @@ DhcpAppendOption (
>> function.
>>
>> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory
>> - @retval EFI_INVALID_PARAMETER The options in SeekPacket are mal-formated
>> + @retval EFI_INVALID_PARAMETER The options in SeekPacket are malformatted
>> @retval EFI_SUCCESS The packet is build.
>>
>> **/
>> diff --git a/NetworkPkg/Ip4Dxe/Ip4Icmp.h b/NetworkPkg/Ip4Dxe/Ip4Icmp.h
>> index 922886a96e67..a52200176f5a 100644
>> --- a/NetworkPkg/Ip4Dxe/Ip4Icmp.h
>> +++ b/NetworkPkg/Ip4Dxe/Ip4Icmp.h
>> @@ -83,7 +83,7 @@ extern EFI_IP4_ICMP_TYPE mIp4SupportedIcmp[];
>> @param[in] Packet The content of the ICMP query with IP4 head
>> removed.
>>
>> - @retval EFI_INVALID_PARAMETER The packet is malformated.
>> + @retval EFI_INVALID_PARAMETER The packet is malformatted.
>> @retval EFI_SUCCESS The ICMP message is successfully processed.
>> @retval Others Failed to handle ICMP packet.
>>
>> diff --git a/NetworkPkg/Ip4Dxe/Ip4Igmp.h b/NetworkPkg/Ip4Dxe/Ip4Igmp.h
>> index 0cc944594441..49c13ba3a7a0 100644
>> --- a/NetworkPkg/Ip4Dxe/Ip4Igmp.h
>> +++ b/NetworkPkg/Ip4Dxe/Ip4Igmp.h
>> @@ -111,7 +111,7 @@ Ip4LeaveGroup (
>> @param[in] Head The IP4 header of the received message.
>> @param[in] Packet The IGMP message, without IP4 header.
>>
>> - @retval EFI_INVALID_PARAMETER The IGMP message is malformated.
>> + @retval EFI_INVALID_PARAMETER The IGMP message is malformatted.
>> @retval EFI_SUCCESS The IGMP message is successfully processed.
>>
>> **/
>> diff --git a/NetworkPkg/Ip4Dxe/Ip4Option.h b/NetworkPkg/Ip4Dxe/Ip4Option.h
>> index 57a5a58725f0..a39fd2b4c69d 100644
>> --- a/NetworkPkg/Ip4Dxe/Ip4Option.h
>> +++ b/NetworkPkg/Ip4Dxe/Ip4Option.h
>> @@ -20,7 +20,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>> /**
>> Validate the IP4 option format for both the packets we received
>> and will transmit. It will compute the ICMP error message fields
>> - if the option is mal-formated. But this information isn't used.
>> + if the option is malformatted. But this information isn't used.
>>
>> @param[in] Option The first byte of the option
>> @param[in] OptionLen The length of the whole option
>> @@ -28,7 +28,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>> otherwise the option we wants to transmit.
>>
>> @retval TRUE The option is properly formatted
>> - @retval FALSE The option is mal-formated
>> + @retval FALSE The option is malformatted
>>
>> **/
>> BOOLEAN
>> diff --git a/NetworkPkg/Ip6Dxe/Ip6Icmp.h b/NetworkPkg/Ip6Dxe/Ip6Icmp.h
>> index 49a65f296adb..c63adb009519 100644
>> --- a/NetworkPkg/Ip6Dxe/Ip6Icmp.h
>> +++ b/NetworkPkg/Ip6Dxe/Ip6Icmp.h
>> @@ -35,7 +35,7 @@ extern EFI_IP6_ICMP_TYPE mIp6SupportedIcmp[];
>> @param[in] Packet The content of the ICMPv6 packet with IP head
>> removed.
>>
>> - @retval EFI_INVALID_PARAMETER The packet is malformated.
>> + @retval EFI_INVALID_PARAMETER The packet is malformatted.
>> @retval EFI_SUCCESS The ICMPv6 message successfully processed.
>> @retval Others Failed to handle the ICMPv6 packet.
>>
>> @@ -80,7 +80,7 @@ Ip6IsAnycast (
>> @param[in] Pointer If not NULL, identifies the octet offset within
>> the invoking packet where the error was detected.
>>
>> - @retval EFI_INVALID_PARAMETER The packet is malformated.
>> + @retval EFI_INVALID_PARAMETER The packet is malformatted.
>> @retval EFI_OUT_OF_RESOURCES There is no sufficient resource to complete the
>> operation.
>> @retval EFI_SUCCESS The ICMPv6 message was successfully sent out.
>> diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h
>> index fcc4cbe8fdef..7bfe706f88c6 100644
>> --- a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h
>> +++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h
>> @@ -70,7 +70,7 @@ Mtftp4ExtractOptions (
>> @param Operation The current performed operation.
>> @param MtftpOption The MTFTP4_OPTION for easy access.
>>
>> - @retval EFI_INVALID_PARAMETER The option is mal-formated
>> + @retval EFI_INVALID_PARAMETER The option is malformatted
>> @retval EFI_UNSUPPORTED Some option isn't supported
>> @retval EFI_SUCCESS The option are OK and has been parsed.
>>
>> @@ -93,7 +93,7 @@ Mtftp4ParseOption (
>> @param Operation The current performed operation.
>> @param MtftpOption The MTFTP_OPTION for easy access.
>>
>> - @retval EFI_INVALID_PARAMETER The packet option is mal-formated
>> + @retval EFI_INVALID_PARAMETER The packet option is malformatted
>> @retval EFI_UNSUPPORTED Some option isn't supported
>> @retval EFI_SUCCESS The option are OK and has been parsed.
>>
>> diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c
>> index 3adbf55d0612..3b077de11177 100644
>> --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c
>> +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c
>> @@ -230,7 +230,7 @@ DhcpOptionIsValid (
>> @param[out] Para The variable to save the interested parameter
>>
>> @retval EFI_SUCCESS The DHCP option is successfully extracted.
>> - @retval EFI_INVALID_PARAMETER The DHCP option is mal-formated
>> + @retval EFI_INVALID_PARAMETER The DHCP option is malformatted
>>
>> **/
>> EFI_STATUS
>> @@ -303,7 +303,7 @@ DhcpGetParameter (
>> option.
>>
>> @retval EFI_SUCCESS All the options are valid
>> - @retval EFI_INVALID_PARAMETER The options are mal-formated.
>> + @retval EFI_INVALID_PARAMETER The options are malformatted.
>>
>> **/
>> EFI_STATUS
>> @@ -538,7 +538,7 @@ DhcpFillOption (
>>
>> @retval EFI_NOT_FOUND Cannot find any option.
>> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to parse the packet.
>> - @retval EFI_INVALID_PARAMETER The options are mal-formated
>> + @retval EFI_INVALID_PARAMETER The options are malformatted
>> @retval EFI_SUCCESS The options are parsed into OptionPoint
>>
>> **/
>> @@ -639,7 +639,7 @@ ON_EXIT:
>> @param[out] Para The variable to save the DHCP parameters.
>>
>> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to validate the packet.
>> - @retval EFI_INVALID_PARAMETER The options are mal-formated
>> + @retval EFI_INVALID_PARAMETER The options are malformatted
>> @retval EFI_SUCCESS The options are parsed into OptionPoint
>>
>> **/
>> @@ -770,7 +770,7 @@ DhcpAppendOption (
>> function.
>>
>> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory
>> - @retval EFI_INVALID_PARAMETER The options in SeekPacket are mal-formated
>> + @retval EFI_INVALID_PARAMETER The options in SeekPacket are malformatted
>> @retval EFI_SUCCESS The packet is build.
>>
>> **/
>> diff --git a/NetworkPkg/Ip4Dxe/Ip4Icmp.c b/NetworkPkg/Ip4Dxe/Ip4Icmp.c
>> index 052d6b77f79a..833ffa74ff0d 100644
>> --- a/NetworkPkg/Ip4Dxe/Ip4Icmp.c
>> +++ b/NetworkPkg/Ip4Dxe/Ip4Icmp.c
>> @@ -319,7 +319,7 @@ Ip4ProcessIcmpQuery (
>> @param[in] Packet The content of the ICMP query with IP4 head
>> removed.
>>
>> - @retval EFI_INVALID_PARAMETER The packet is malformated.
>> + @retval EFI_INVALID_PARAMETER The packet is malformatted.
>> @retval EFI_SUCCESS The ICMP message is successfully processed.
>> @retval Others Failed to handle ICMP packet.
>>
>> diff --git a/NetworkPkg/Ip4Dxe/Ip4Igmp.c b/NetworkPkg/Ip4Dxe/Ip4Igmp.c
>> index 41d9bce9717e..e69b2fe7fc08 100644
>> --- a/NetworkPkg/Ip4Dxe/Ip4Igmp.c
>> +++ b/NetworkPkg/Ip4Dxe/Ip4Igmp.c
>> @@ -401,7 +401,7 @@ Ip4LeaveGroup (
>> @param[in] Head The IP4 header of the received message.
>> @param[in] Packet The IGMP message, without IP4 header.
>>
>> - @retval EFI_INVALID_PARAMETER The IGMP message is malformated.
>> + @retval EFI_INVALID_PARAMETER The IGMP message is malformatted.
>> @retval EFI_SUCCESS The IGMP message is successfully processed.
>>
>> **/
>> diff --git a/NetworkPkg/Ip4Dxe/Ip4Option.c b/NetworkPkg/Ip4Dxe/Ip4Option.c
>> index f1c10014e85c..b3c598c64a38 100644
>> --- a/NetworkPkg/Ip4Dxe/Ip4Option.c
>> +++ b/NetworkPkg/Ip4Dxe/Ip4Option.c
>> @@ -19,7 +19,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>> otherwise the option we wants to transmit.
>>
>> @retval TRUE The option is properly formatted
>> - @retval FALSE The option is mal-formated
>> + @retval FALSE The option is malformatted
>>
>> **/
>> BOOLEAN
>> diff --git a/NetworkPkg/Ip6Dxe/Ip6Icmp.c b/NetworkPkg/Ip6Dxe/Ip6Icmp.c
>> index 79fa34e0413f..bf9b17d907ef 100644
>> --- a/NetworkPkg/Ip6Dxe/Ip6Icmp.c
>> +++ b/NetworkPkg/Ip6Dxe/Ip6Icmp.c
>> @@ -393,7 +393,7 @@ Ip6ProcessIcmpInformation (
>> @param[in] Packet The content of the ICMPv6 packet with IP head
>> removed.
>>
>> - @retval EFI_INVALID_PARAMETER The packet is malformated.
>> + @retval EFI_INVALID_PARAMETER The packet is malformatted.
>> @retval EFI_SUCCESS The ICMPv6 message successfully processed.
>> @retval Others Failed to handle the ICMPv6 packet.
>>
>> @@ -554,7 +554,7 @@ Ip6IsAnycast (
>> @param[in] Pointer If not NULL, identifies the octet offset within
>> the invoking packet where the error was detected.
>>
>> - @retval EFI_INVALID_PARAMETER The packet is malformated.
>> + @retval EFI_INVALID_PARAMETER The packet is malformatted.
>> @retval EFI_OUT_OF_RESOURCES There is no sufficient resource to complete the
>> operation.
>> @retval EFI_SUCCESS The ICMPv6 message was successfully sent out.
>> diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
>> index a39c20be3d34..4f8a1226dae7 100644
>> --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
>> +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
>> @@ -2983,7 +2983,7 @@ NetLibGetNicHandle (
>> @param[out] Ip4Address The pointer to the converted IPv4 address.
>>
>> @retval EFI_SUCCESS Convert to IPv4 address successfully.
>> - @retval EFI_INVALID_PARAMETER The string is mal-formated or Ip4Address is NULL.
>> + @retval EFI_INVALID_PARAMETER The string is malformatted or Ip4Address is NULL.
>>
>> **/
>> EFI_STATUS
>> @@ -3013,7 +3013,7 @@ NetLibAsciiStrToIp4 (
>> @param[out] Ip6Address The pointer to the converted IPv6 address.
>>
>> @retval EFI_SUCCESS Convert to IPv6 address successfully.
>> - @retval EFI_INVALID_PARAMETER The string is mal-formated or Ip6Address is NULL.
>> + @retval EFI_INVALID_PARAMETER The string is malformatted or Ip6Address is NULL.
>>
>> **/
>> EFI_STATUS
>> @@ -3042,7 +3042,7 @@ NetLibAsciiStrToIp6 (
>> @param[out] Ip4Address The pointer to the converted IPv4 address.
>>
>> @retval EFI_SUCCESS Convert to IPv4 address successfully.
>> - @retval EFI_INVALID_PARAMETER The string is mal-formated or Ip4Address is NULL.
>> + @retval EFI_INVALID_PARAMETER The string is malformatted or Ip4Address is NULL.
>>
>> **/
>> EFI_STATUS
>> @@ -3072,7 +3072,7 @@ NetLibStrToIp4 (
>> @param[out] Ip6Address The pointer to the converted IPv6 address.
>>
>> @retval EFI_SUCCESS Convert to IPv6 address successfully.
>> - @retval EFI_INVALID_PARAMETER The string is mal-formated or Ip6Address is NULL.
>> + @retval EFI_INVALID_PARAMETER The string is malformatted or Ip6Address is NULL.
>>
>> **/
>> EFI_STATUS
>> @@ -3103,7 +3103,7 @@ NetLibStrToIp6 (
>> @param[out] PrefixLength The pointer to the converted prefix length.
>>
>> @retval EFI_SUCCESS Convert to IPv6 address successfully.
>> - @retval EFI_INVALID_PARAMETER The string is mal-formated or Ip6Address is NULL.
>> + @retval EFI_INVALID_PARAMETER The string is malformatted or Ip6Address is NULL.
>>
>> **/
>> EFI_STATUS
>> diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.c b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.c
>> index d97f157f1744..013fe008eee8 100644
>> --- a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.c
>> +++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.c
>> @@ -155,7 +155,7 @@ NetStringToIp (
>> options on output
>> @param Options The option array to fill in
>>
>> - @retval EFI_INVALID_PARAMETER The packet is mal-formated
>> + @retval EFI_INVALID_PARAMETER The packet is malformatted
>> @retval EFI_BUFFER_TOO_SMALL The Options array is too small
>> @retval EFI_SUCCESS The packet has been parsed into the Options array.
>>
>> @@ -398,7 +398,7 @@ Mtftp4ExtractMcast (
>> @param Operation The current performed operation.
>> @param MtftpOption The MTFTP4_OPTION for easy access.
>>
>> - @retval EFI_INVALID_PARAMETER The option is mal-formated
>> + @retval EFI_INVALID_PARAMETER The option is malformatted
>> @retval EFI_UNSUPPORTED Some option isn't supported
>> @retval EFI_SUCCESS The option are OK and has been parsed.
>>
>> @@ -516,7 +516,7 @@ Mtftp4ParseOption (
>> @param Operation The current performed operation.
>> @param MtftpOption The MTFTP_OPTION for easy access.
>>
>> - @retval EFI_INVALID_PARAMETER The packet option is mal-formated
>> + @retval EFI_INVALID_PARAMETER The packet option is malformatted
>> @retval EFI_UNSUPPORTED Some option isn't supported
>> @retval EFI_SUCCESS The option are OK and has been parsed.
>>
>> diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c b/NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c
>> index 24c965afb580..8e1338221b12 100644
>> --- a/NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c
>> +++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c
>> @@ -533,7 +533,7 @@ Mtftp4RrqHandleOack (
>> Mtftp4SendError (
>> Instance,
>> EFI_MTFTP4_ERRORCODE_ILLEGAL_OPERATION,
>> - (UINT8 *) "Mal-formated OACK packet"
>> + (UINT8 *) "Malformatted OACK packet"
>> );
>> }
>>
>> diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c b/NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c
>> index 14156b801ee6..bd13244b999b 100644
>> --- a/NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c
>> +++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c
>> @@ -291,7 +291,7 @@ Mtftp4WrqHandleOack (
>> Mtftp4SendError (
>> Instance,
>> EFI_MTFTP4_ERRORCODE_ILLEGAL_OPERATION,
>> - (UINT8 *) "Mal-formated OACK packet"
>> + (UINT8 *) "Malformatted OACK packet"
>> );
>> }
>>
>> diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c b/NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c
>> index 897358e5f133..a830d432916c 100644
>> --- a/NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c
>> +++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c
>> @@ -517,7 +517,7 @@ Mtftp6RrqHandleOack (
>> Mtftp6SendError (
>> Instance,
>> EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION,
>> - (UINT8 *) "Mal-formated OACK packet"
>> + (UINT8 *) "Malformatted OACK packet"
>> );
>> }
>>
>> diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c b/NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c
>> index 2860f3870206..ce3315cc2c26 100644
>> --- a/NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c
>> +++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c
>> @@ -332,7 +332,7 @@ Mtftp6WrqHandleOack (
>> Mtftp6SendError (
>> Instance,
>> EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION,
>> - (UINT8 *) "Mal-formated OACK packet"
>> + (UINT8 *) "Malformatted OACK packet"
>> );
>> }
>>
>> --
>> 2.21.0
>>
>
^ permalink raw reply [flat|nested] 122+ messages in thread
* Re: [edk2-devel] [PATCH 31/79] NetworkPkg: Fix a typo
2019-12-03 17:20 ` Philippe Mathieu-Daudé
@ 2019-12-04 14:02 ` Maciej Rabeda
0 siblings, 0 replies; 122+ messages in thread
From: Maciej Rabeda @ 2019-12-04 14:02 UTC (permalink / raw)
To: devel, philmd, Leif Lindholm
Cc: Antoine Cœur, Andrew Fish, Laszlo Ersek, Michael D Kinney,
Jiaxin Wu, Siyuan Fu, Maciej Rabeda
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
On 03-Dec-19 18:20, Philippe Mathieu-Daudé wrote:
> On 12/3/19 6:18 PM, Leif Lindholm wrote:
>> Hi Phil,
>>
>> On Tue, Dec 03, 2019 at 17:15:14 +0100, Philippe Mathieu-Daude wrote:
>>> Correctly write 'malformatted' in documentation, comments and
>>> debug strings.
>>>
>>> Cc: Andrew Fish <afish@apple.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>
>> I would have expected:
>> Jiaxin Wu <jiaxin.wu@intel.com>
>> Siyuan Fu <siyuan.fu@intel.com>
>> Maciej Rabeda <maciej.rabeda@intel.com>
>> to be cc:d on NetworkPkg patches (added here).
>> Was there a GetMaintainer.py failure?
>
> Human failure due to manual edition :S
>
> Thanks for caring to Cc to correct maintainers.
>
>> /
>> Leif
>>
>>> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
>>> ---
>>> NetworkPkg/Dhcp4Dxe/Dhcp4Option.h | 6 +++---
>>> NetworkPkg/Ip4Dxe/Ip4Icmp.h | 2 +-
>>> NetworkPkg/Ip4Dxe/Ip4Igmp.h | 2 +-
>>> NetworkPkg/Ip4Dxe/Ip4Option.h | 4 ++--
>>> NetworkPkg/Ip6Dxe/Ip6Icmp.h | 4 ++--
>>> NetworkPkg/Mtftp4Dxe/Mtftp4Option.h | 4 ++--
>>> NetworkPkg/Dhcp4Dxe/Dhcp4Option.c | 10 +++++-----
>>> NetworkPkg/Ip4Dxe/Ip4Icmp.c | 2 +-
>>> NetworkPkg/Ip4Dxe/Ip4Igmp.c | 2 +-
>>> NetworkPkg/Ip4Dxe/Ip4Option.c | 2 +-
>>> NetworkPkg/Ip6Dxe/Ip6Icmp.c | 4 ++--
>>> NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 10 +++++-----
>>> NetworkPkg/Mtftp4Dxe/Mtftp4Option.c | 6 +++---
>>> NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c | 2 +-
>>> NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c | 2 +-
>>> NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c | 2 +-
>>> NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c | 2 +-
>>> 17 files changed, 33 insertions(+), 33 deletions(-)
>>>
>>> diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
>>> b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
>>> index 9e25386507ed..393176c8996d 100644
>>> --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
>>> +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
>>> @@ -133,7 +133,7 @@ DhcpIterateOptions (
>>> @param[out] Para The variable to save the DHCP
>>> parameters.
>>> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to
>>> validate the packet.
>>> - @retval EFI_INVALID_PARAMETER The options are mal-formated
>>> + @retval EFI_INVALID_PARAMETER The options are malformatted
>>> @retval EFI_SUCCESS The options are parsed into
>>> OptionPoint
>>> **/
>>> @@ -167,7 +167,7 @@ DhcpValidateOptions (
>>> @retval EFI_NOT_FOUND Cannot find any option.
>>> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to
>>> parse the packet.
>>> - @retval EFI_INVALID_PARAMETER The options are mal-formated
>>> + @retval EFI_INVALID_PARAMETER The options are malformatted
>>> @retval EFI_SUCCESS The options are parsed into
>>> OptionPoint
>>> **/
>>> @@ -211,7 +211,7 @@ DhcpAppendOption (
>>> function.
>>> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory
>>> - @retval EFI_INVALID_PARAMETER The options in SeekPacket are
>>> mal-formated
>>> + @retval EFI_INVALID_PARAMETER The options in SeekPacket are
>>> malformatted
>>> @retval EFI_SUCCESS The packet is build.
>>> **/
>>> diff --git a/NetworkPkg/Ip4Dxe/Ip4Icmp.h b/NetworkPkg/Ip4Dxe/Ip4Icmp.h
>>> index 922886a96e67..a52200176f5a 100644
>>> --- a/NetworkPkg/Ip4Dxe/Ip4Icmp.h
>>> +++ b/NetworkPkg/Ip4Dxe/Ip4Icmp.h
>>> @@ -83,7 +83,7 @@ extern EFI_IP4_ICMP_TYPE mIp4SupportedIcmp[];
>>> @param[in] Packet The content of the ICMP query
>>> with IP4 head
>>> removed.
>>> - @retval EFI_INVALID_PARAMETER The packet is malformated.
>>> + @retval EFI_INVALID_PARAMETER The packet is malformatted.
>>> @retval EFI_SUCCESS The ICMP message is successfully
>>> processed.
>>> @retval Others Failed to handle ICMP packet.
>>> diff --git a/NetworkPkg/Ip4Dxe/Ip4Igmp.h
>>> b/NetworkPkg/Ip4Dxe/Ip4Igmp.h
>>> index 0cc944594441..49c13ba3a7a0 100644
>>> --- a/NetworkPkg/Ip4Dxe/Ip4Igmp.h
>>> +++ b/NetworkPkg/Ip4Dxe/Ip4Igmp.h
>>> @@ -111,7 +111,7 @@ Ip4LeaveGroup (
>>> @param[in] Head The IP4 header of the received
>>> message.
>>> @param[in] Packet The IGMP message, without IP4
>>> header.
>>> - @retval EFI_INVALID_PARAMETER The IGMP message is malformated.
>>> + @retval EFI_INVALID_PARAMETER The IGMP message is malformatted.
>>> @retval EFI_SUCCESS The IGMP message is successfully
>>> processed.
>>> **/
>>> diff --git a/NetworkPkg/Ip4Dxe/Ip4Option.h
>>> b/NetworkPkg/Ip4Dxe/Ip4Option.h
>>> index 57a5a58725f0..a39fd2b4c69d 100644
>>> --- a/NetworkPkg/Ip4Dxe/Ip4Option.h
>>> +++ b/NetworkPkg/Ip4Dxe/Ip4Option.h
>>> @@ -20,7 +20,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>>> /**
>>> Validate the IP4 option format for both the packets we received
>>> and will transmit. It will compute the ICMP error message fields
>>> - if the option is mal-formated. But this information isn't used.
>>> + if the option is malformatted. But this information isn't used.
>>> @param[in] Option The first byte of the option
>>> @param[in] OptionLen The length of the whole option
>>> @@ -28,7 +28,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>>> otherwise the option we wants to
>>> transmit.
>>> @retval TRUE The option is properly formatted
>>> - @retval FALSE The option is mal-formated
>>> + @retval FALSE The option is malformatted
>>> **/
>>> BOOLEAN
>>> diff --git a/NetworkPkg/Ip6Dxe/Ip6Icmp.h b/NetworkPkg/Ip6Dxe/Ip6Icmp.h
>>> index 49a65f296adb..c63adb009519 100644
>>> --- a/NetworkPkg/Ip6Dxe/Ip6Icmp.h
>>> +++ b/NetworkPkg/Ip6Dxe/Ip6Icmp.h
>>> @@ -35,7 +35,7 @@ extern EFI_IP6_ICMP_TYPE mIp6SupportedIcmp[];
>>> @param[in] Packet The content of the ICMPv6 packet
>>> with IP head
>>> removed.
>>> - @retval EFI_INVALID_PARAMETER The packet is malformated.
>>> + @retval EFI_INVALID_PARAMETER The packet is malformatted.
>>> @retval EFI_SUCCESS The ICMPv6 message successfully
>>> processed.
>>> @retval Others Failed to handle the ICMPv6 packet.
>>> @@ -80,7 +80,7 @@ Ip6IsAnycast (
>>> @param[in] Pointer If not NULL, identifies the octet
>>> offset within
>>> the invoking packet where the
>>> error was detected.
>>> - @retval EFI_INVALID_PARAMETER The packet is malformated.
>>> + @retval EFI_INVALID_PARAMETER The packet is malformatted.
>>> @retval EFI_OUT_OF_RESOURCES There is no sufficient resource
>>> to complete the
>>> operation.
>>> @retval EFI_SUCCESS The ICMPv6 message was
>>> successfully sent out.
>>> diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h
>>> b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h
>>> index fcc4cbe8fdef..7bfe706f88c6 100644
>>> --- a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h
>>> +++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h
>>> @@ -70,7 +70,7 @@ Mtftp4ExtractOptions (
>>> @param Operation The current performed operation.
>>> @param MtftpOption The MTFTP4_OPTION for easy access.
>>> - @retval EFI_INVALID_PARAMETER The option is mal-formated
>>> + @retval EFI_INVALID_PARAMETER The option is malformatted
>>> @retval EFI_UNSUPPORTED Some option isn't supported
>>> @retval EFI_SUCCESS The option are OK and has been
>>> parsed.
>>> @@ -93,7 +93,7 @@ Mtftp4ParseOption (
>>> @param Operation The current performed operation.
>>> @param MtftpOption The MTFTP_OPTION for easy access.
>>> - @retval EFI_INVALID_PARAMETER The packet option is mal-formated
>>> + @retval EFI_INVALID_PARAMETER The packet option is malformatted
>>> @retval EFI_UNSUPPORTED Some option isn't supported
>>> @retval EFI_SUCCESS The option are OK and has been
>>> parsed.
>>> diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c
>>> b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c
>>> index 3adbf55d0612..3b077de11177 100644
>>> --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c
>>> +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c
>>> @@ -230,7 +230,7 @@ DhcpOptionIsValid (
>>> @param[out] Para The variable to save the
>>> interested parameter
>>> @retval EFI_SUCCESS The DHCP option is successfully
>>> extracted.
>>> - @retval EFI_INVALID_PARAMETER The DHCP option is mal-formated
>>> + @retval EFI_INVALID_PARAMETER The DHCP option is malformatted
>>> **/
>>> EFI_STATUS
>>> @@ -303,7 +303,7 @@ DhcpGetParameter (
>>> option.
>>> @retval EFI_SUCCESS All the options are valid
>>> - @retval EFI_INVALID_PARAMETER The options are mal-formated.
>>> + @retval EFI_INVALID_PARAMETER The options are malformatted.
>>> **/
>>> EFI_STATUS
>>> @@ -538,7 +538,7 @@ DhcpFillOption (
>>> @retval EFI_NOT_FOUND Cannot find any option.
>>> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to
>>> parse the packet.
>>> - @retval EFI_INVALID_PARAMETER The options are mal-formated
>>> + @retval EFI_INVALID_PARAMETER The options are malformatted
>>> @retval EFI_SUCCESS The options are parsed into
>>> OptionPoint
>>> **/
>>> @@ -639,7 +639,7 @@ ON_EXIT:
>>> @param[out] Para The variable to save the DHCP
>>> parameters.
>>> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to
>>> validate the packet.
>>> - @retval EFI_INVALID_PARAMETER The options are mal-formated
>>> + @retval EFI_INVALID_PARAMETER The options are malformatted
>>> @retval EFI_SUCCESS The options are parsed into
>>> OptionPoint
>>> **/
>>> @@ -770,7 +770,7 @@ DhcpAppendOption (
>>> function.
>>> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory
>>> - @retval EFI_INVALID_PARAMETER The options in SeekPacket are
>>> mal-formated
>>> + @retval EFI_INVALID_PARAMETER The options in SeekPacket are
>>> malformatted
>>> @retval EFI_SUCCESS The packet is build.
>>> **/
>>> diff --git a/NetworkPkg/Ip4Dxe/Ip4Icmp.c b/NetworkPkg/Ip4Dxe/Ip4Icmp.c
>>> index 052d6b77f79a..833ffa74ff0d 100644
>>> --- a/NetworkPkg/Ip4Dxe/Ip4Icmp.c
>>> +++ b/NetworkPkg/Ip4Dxe/Ip4Icmp.c
>>> @@ -319,7 +319,7 @@ Ip4ProcessIcmpQuery (
>>> @param[in] Packet The content of the ICMP query
>>> with IP4 head
>>> removed.
>>> - @retval EFI_INVALID_PARAMETER The packet is malformated.
>>> + @retval EFI_INVALID_PARAMETER The packet is malformatted.
>>> @retval EFI_SUCCESS The ICMP message is successfully
>>> processed.
>>> @retval Others Failed to handle ICMP packet.
>>> diff --git a/NetworkPkg/Ip4Dxe/Ip4Igmp.c
>>> b/NetworkPkg/Ip4Dxe/Ip4Igmp.c
>>> index 41d9bce9717e..e69b2fe7fc08 100644
>>> --- a/NetworkPkg/Ip4Dxe/Ip4Igmp.c
>>> +++ b/NetworkPkg/Ip4Dxe/Ip4Igmp.c
>>> @@ -401,7 +401,7 @@ Ip4LeaveGroup (
>>> @param[in] Head The IP4 header of the received
>>> message.
>>> @param[in] Packet The IGMP message, without IP4
>>> header.
>>> - @retval EFI_INVALID_PARAMETER The IGMP message is malformated.
>>> + @retval EFI_INVALID_PARAMETER The IGMP message is malformatted.
>>> @retval EFI_SUCCESS The IGMP message is successfully
>>> processed.
>>> **/
>>> diff --git a/NetworkPkg/Ip4Dxe/Ip4Option.c
>>> b/NetworkPkg/Ip4Dxe/Ip4Option.c
>>> index f1c10014e85c..b3c598c64a38 100644
>>> --- a/NetworkPkg/Ip4Dxe/Ip4Option.c
>>> +++ b/NetworkPkg/Ip4Dxe/Ip4Option.c
>>> @@ -19,7 +19,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>>> otherwise the option we wants to
>>> transmit.
>>> @retval TRUE The option is properly formatted
>>> - @retval FALSE The option is mal-formated
>>> + @retval FALSE The option is malformatted
>>> **/
>>> BOOLEAN
>>> diff --git a/NetworkPkg/Ip6Dxe/Ip6Icmp.c b/NetworkPkg/Ip6Dxe/Ip6Icmp.c
>>> index 79fa34e0413f..bf9b17d907ef 100644
>>> --- a/NetworkPkg/Ip6Dxe/Ip6Icmp.c
>>> +++ b/NetworkPkg/Ip6Dxe/Ip6Icmp.c
>>> @@ -393,7 +393,7 @@ Ip6ProcessIcmpInformation (
>>> @param[in] Packet The content of the ICMPv6 packet
>>> with IP head
>>> removed.
>>> - @retval EFI_INVALID_PARAMETER The packet is malformated.
>>> + @retval EFI_INVALID_PARAMETER The packet is malformatted.
>>> @retval EFI_SUCCESS The ICMPv6 message successfully
>>> processed.
>>> @retval Others Failed to handle the ICMPv6 packet.
>>> @@ -554,7 +554,7 @@ Ip6IsAnycast (
>>> @param[in] Pointer If not NULL, identifies the octet
>>> offset within
>>> the invoking packet where the
>>> error was detected.
>>> - @retval EFI_INVALID_PARAMETER The packet is malformated.
>>> + @retval EFI_INVALID_PARAMETER The packet is malformatted.
>>> @retval EFI_OUT_OF_RESOURCES There is no sufficient resource
>>> to complete the
>>> operation.
>>> @retval EFI_SUCCESS The ICMPv6 message was
>>> successfully sent out.
>>> diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
>>> b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
>>> index a39c20be3d34..4f8a1226dae7 100644
>>> --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
>>> +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
>>> @@ -2983,7 +2983,7 @@ NetLibGetNicHandle (
>>> @param[out] Ip4Address The pointer to the converted IPv4
>>> address.
>>> @retval EFI_SUCCESS Convert to IPv4 address
>>> successfully.
>>> - @retval EFI_INVALID_PARAMETER The string is mal-formated or
>>> Ip4Address is NULL.
>>> + @retval EFI_INVALID_PARAMETER The string is malformatted or
>>> Ip4Address is NULL.
>>> **/
>>> EFI_STATUS
>>> @@ -3013,7 +3013,7 @@ NetLibAsciiStrToIp4 (
>>> @param[out] Ip6Address The pointer to the converted IPv6
>>> address.
>>> @retval EFI_SUCCESS Convert to IPv6 address
>>> successfully.
>>> - @retval EFI_INVALID_PARAMETER The string is mal-formated or
>>> Ip6Address is NULL.
>>> + @retval EFI_INVALID_PARAMETER The string is malformatted or
>>> Ip6Address is NULL.
>>> **/
>>> EFI_STATUS
>>> @@ -3042,7 +3042,7 @@ NetLibAsciiStrToIp6 (
>>> @param[out] Ip4Address The pointer to the converted IPv4
>>> address.
>>> @retval EFI_SUCCESS Convert to IPv4 address
>>> successfully.
>>> - @retval EFI_INVALID_PARAMETER The string is mal-formated or
>>> Ip4Address is NULL.
>>> + @retval EFI_INVALID_PARAMETER The string is malformatted or
>>> Ip4Address is NULL.
>>> **/
>>> EFI_STATUS
>>> @@ -3072,7 +3072,7 @@ NetLibStrToIp4 (
>>> @param[out] Ip6Address The pointer to the converted IPv6
>>> address.
>>> @retval EFI_SUCCESS Convert to IPv6 address
>>> successfully.
>>> - @retval EFI_INVALID_PARAMETER The string is mal-formated or
>>> Ip6Address is NULL.
>>> + @retval EFI_INVALID_PARAMETER The string is malformatted or
>>> Ip6Address is NULL.
>>> **/
>>> EFI_STATUS
>>> @@ -3103,7 +3103,7 @@ NetLibStrToIp6 (
>>> @param[out] PrefixLength The pointer to the converted
>>> prefix length.
>>> @retval EFI_SUCCESS Convert to IPv6 address
>>> successfully.
>>> - @retval EFI_INVALID_PARAMETER The string is mal-formated or
>>> Ip6Address is NULL.
>>> + @retval EFI_INVALID_PARAMETER The string is malformatted or
>>> Ip6Address is NULL.
>>> **/
>>> EFI_STATUS
>>> diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.c
>>> b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.c
>>> index d97f157f1744..013fe008eee8 100644
>>> --- a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.c
>>> +++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.c
>>> @@ -155,7 +155,7 @@ NetStringToIp (
>>> options on output
>>> @param Options The option array to fill in
>>> - @retval EFI_INVALID_PARAMETER The packet is mal-formated
>>> + @retval EFI_INVALID_PARAMETER The packet is malformatted
>>> @retval EFI_BUFFER_TOO_SMALL The Options array is too small
>>> @retval EFI_SUCCESS The packet has been parsed into
>>> the Options array.
>>> @@ -398,7 +398,7 @@ Mtftp4ExtractMcast (
>>> @param Operation The current performed operation.
>>> @param MtftpOption The MTFTP4_OPTION for easy access.
>>> - @retval EFI_INVALID_PARAMETER The option is mal-formated
>>> + @retval EFI_INVALID_PARAMETER The option is malformatted
>>> @retval EFI_UNSUPPORTED Some option isn't supported
>>> @retval EFI_SUCCESS The option are OK and has been
>>> parsed.
>>> @@ -516,7 +516,7 @@ Mtftp4ParseOption (
>>> @param Operation The current performed operation.
>>> @param MtftpOption The MTFTP_OPTION for easy access.
>>> - @retval EFI_INVALID_PARAMETER The packet option is mal-formated
>>> + @retval EFI_INVALID_PARAMETER The packet option is malformatted
>>> @retval EFI_UNSUPPORTED Some option isn't supported
>>> @retval EFI_SUCCESS The option are OK and has been
>>> parsed.
>>> diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c
>>> b/NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c
>>> index 24c965afb580..8e1338221b12 100644
>>> --- a/NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c
>>> +++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c
>>> @@ -533,7 +533,7 @@ Mtftp4RrqHandleOack (
>>> Mtftp4SendError (
>>> Instance,
>>> EFI_MTFTP4_ERRORCODE_ILLEGAL_OPERATION,
>>> - (UINT8 *) "Mal-formated OACK packet"
>>> + (UINT8 *) "Malformatted OACK packet"
>>> );
>>> }
>>> diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c
>>> b/NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c
>>> index 14156b801ee6..bd13244b999b 100644
>>> --- a/NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c
>>> +++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c
>>> @@ -291,7 +291,7 @@ Mtftp4WrqHandleOack (
>>> Mtftp4SendError (
>>> Instance,
>>> EFI_MTFTP4_ERRORCODE_ILLEGAL_OPERATION,
>>> - (UINT8 *) "Mal-formated OACK packet"
>>> + (UINT8 *) "Malformatted OACK packet"
>>> );
>>> }
>>> diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c
>>> b/NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c
>>> index 897358e5f133..a830d432916c 100644
>>> --- a/NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c
>>> +++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c
>>> @@ -517,7 +517,7 @@ Mtftp6RrqHandleOack (
>>> Mtftp6SendError (
>>> Instance,
>>> EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION,
>>> - (UINT8 *) "Mal-formated OACK packet"
>>> + (UINT8 *) "Malformatted OACK packet"
>>> );
>>> }
>>> diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c
>>> b/NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c
>>> index 2860f3870206..ce3315cc2c26 100644
>>> --- a/NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c
>>> +++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c
>>> @@ -332,7 +332,7 @@ Mtftp6WrqHandleOack (
>>> Mtftp6SendError (
>>> Instance,
>>> EFI_MTFTP6_ERRORCODE_ILLEGAL_OPERATION,
>>> - (UINT8 *) "Mal-formated OACK packet"
>>> + (UINT8 *) "Malformatted OACK packet"
>>> );
>>> }
>>> --
>>> 2.21.0
>>>
>>
>
>
>
>
^ permalink raw reply [flat|nested] 122+ messages in thread
* [PATCH 32/79] NetworkPkg/ArpDxe: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (30 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 31/79] NetworkPkg: Fix a typo Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-04 13:20 ` [edk2-devel] " Maciej Rabeda
2019-12-03 16:15 ` [PATCH 33/79] NetworkPkg/Dhcp4Dxe: " Philippe Mathieu-Daudé
` (40 subsequent siblings)
72 siblings, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel
Cc: Antoine Coeur, Jiaxin Wu, Siyuan Fu, Maciej Rabeda,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in documentation, comments and debug strings.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/ArpDxe/ArpDriver.h | 10 +++++-----
NetworkPkg/ArpDxe/ArpImpl.h | 14 +++++++-------
NetworkPkg/ArpDxe/ArpDriver.c | 14 +++++++-------
NetworkPkg/ArpDxe/ArpImpl.c | 16 ++++++++--------
NetworkPkg/ArpDxe/ArpMain.c | 10 +++++-----
5 files changed, 32 insertions(+), 32 deletions(-)
diff --git a/NetworkPkg/ArpDxe/ArpDriver.h b/NetworkPkg/ArpDxe/ArpDriver.h
index 0b5b06ee37d5..7dbc1c187820 100644
--- a/NetworkPkg/ArpDxe/ArpDriver.h
+++ b/NetworkPkg/ArpDxe/ArpDriver.h
@@ -30,7 +30,7 @@ extern EFI_COMPONENT_NAME_PROTOCOL gArpComponentName;
extern EFI_COMPONENT_NAME2_PROTOCOL gArpComponentName2;
//
-// Function prototypes for the Drivr Binding Protocol
+// Function prototypes for the Driver Binding Protocol
//
/**
Tests to see if this driver supports a given controller.
@@ -55,7 +55,7 @@ extern EFI_COMPONENT_NAME2_PROTOCOL gArpComponentName2;
@retval EFI_ACCESS_DENIED The device specified by ControllerHandle and
RemainingDevicePath is already being managed by
a different driver or an application that
- requires exclusive acces. Currently not implemented.
+ requires exclusive access. Currently not implemented.
@retval EFI_UNSUPPORTED The device specified by ControllerHandle and
RemainingDevicePath is not supported by the
driver specified by This.
@@ -97,7 +97,7 @@ ArpDriverBindingSupported (
Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of
resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -159,7 +159,7 @@ ArpDriverBindingStop (
then a new handle is created. If it is a pointer to an existing
UEFI handle, then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child
@@ -183,7 +183,7 @@ ArpServiceBindingCreateChild (
@param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param ChildHandle Handle of the child to destroy
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is
being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
diff --git a/NetworkPkg/ArpDxe/ArpImpl.h b/NetworkPkg/ArpDxe/ArpImpl.h
index 47eedc1cb6f7..506f3e6ef61e 100644
--- a/NetworkPkg/ArpDxe/ArpImpl.h
+++ b/NetworkPkg/ArpDxe/ArpImpl.h
@@ -436,7 +436,7 @@ ArpRequest (
If the request is in the internal ARP request queue, the request is aborted
immediately and its ResolvedEvent is signaled. Only an asynchronous address
- request needs to be canceled. If TargeSwAddress and ResolveEvent are both
+ request needs to be canceled. If TargetSwAddress and ResolvedEvent are both
NULL, all the pending asynchronous requests that have been issued by This
instance will be cancelled and their corresponding events will be signaled.
@@ -599,7 +599,7 @@ ArpDeleteCacheEntry (
);
/**
- Send out an arp frame using the CachEntry and the ArpOpCode.
+ Send out an arp frame using the CacheEntry and the ArpOpCode.
@param[in] Instance Pointer to the instance context data.
@param[in] CacheEntry Pointer to the configuration data used to
@@ -636,7 +636,7 @@ ArpInitInstance (
/**
Process the Arp packets received from Mnp, the procedure conforms to RFC826.
- @param[in] Context Pointer to the context data registerd to the
+ @param[in] Context Pointer to the context data registered to the
Event.
@return None.
@@ -652,7 +652,7 @@ ArpOnFrameRcvdDpc (
Queue ArpOnFrameRcvdDpc as a DPC at TPL_CALLBACK.
@param[in] Event The Event this notify function registered to.
- @param[in] Context Pointer to the context data registerd to the
+ @param[in] Context Pointer to the context data registered to the
Event.
@return None.
@@ -668,7 +668,7 @@ ArpOnFrameRcvd (
/**
Process the already sent arp packets.
- @param[in] Context Pointer to the context data registerd to the
+ @param[in] Context Pointer to the context data registered to the
Event.
@return None.
@@ -684,7 +684,7 @@ ArpOnFrameSentDpc (
Request ArpOnFrameSentDpc as a DPC at TPL_CALLBACK.
@param[in] Event The Event this notify function registered to.
- @param[in] Context Pointer to the context data registerd to the
+ @param[in] Context Pointer to the context data registered to the
Event.
@return None.
@@ -701,7 +701,7 @@ ArpOnFrameSent (
Process the arp cache olding and drive the retrying arp requests.
@param[in] Event The Event this notify function registered to.
- @param[in] Context Pointer to the context data registerd to the
+ @param[in] Context Pointer to the context data registered to the
Event.
@return None.
diff --git a/NetworkPkg/ArpDxe/ArpDriver.c b/NetworkPkg/ArpDxe/ArpDriver.c
index 632d691d7588..f50beb55bf9f 100644
--- a/NetworkPkg/ArpDxe/ArpDriver.c
+++ b/NetworkPkg/ArpDxe/ArpDriver.c
@@ -195,7 +195,7 @@ ArpCleanService (
if (ArpService->PeriodicTimer != NULL) {
//
- // Cancle and close the PeriodicTimer.
+ // Cancel and close the PeriodicTimer.
//
gBS->SetTimer (ArpService->PeriodicTimer, TimerCancel, 0);
gBS->CloseEvent (ArpService->PeriodicTimer);
@@ -203,7 +203,7 @@ ArpCleanService (
if (ArpService->RxToken.Event != NULL) {
//
- // Cancle the RxToken and close the event in the RxToken.
+ // Cancel the RxToken and close the event in the RxToken.
//
ArpService->Mnp->Cancel (ArpService->Mnp, NULL);
gBS->CloseEvent (ArpService->RxToken.Event);
@@ -288,7 +288,7 @@ ArpDestroyChildEntryInHandleBuffer (
@retval EFI_ACCESS_DENIED The device specified by ControllerHandle and
RemainingDevicePath is already being managed by
a different driver or an application that
- requires exclusive acces. Currently not implemented.
+ requires exclusive access. Currently not implemented.
@retval EFI_UNSUPPORTED The device specified by ControllerHandle and
RemainingDevicePath is not supported by the
driver specified by This.
@@ -363,7 +363,7 @@ ArpDriverBindingSupported (
Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of
resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -547,7 +547,7 @@ ArpDriverBindingStop (
then a new handle is created. If it is a pointer to an existing
UEFI handle, then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child
@@ -598,7 +598,7 @@ ArpServiceBindingCreateChild (
NULL
);
if (EFI_ERROR (Status)) {
- DEBUG ((EFI_D_ERROR, "ArpSBCreateChild: faild to install ARP protocol, %r.\n", Status));
+ DEBUG ((EFI_D_ERROR, "ArpSBCreateChild: failed to install ARP protocol, %r.\n", Status));
FreePool (Instance);
return Status;
@@ -672,7 +672,7 @@ ERROR:
@param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param ChildHandle Handle of the child to destroy
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is
being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
diff --git a/NetworkPkg/ArpDxe/ArpImpl.c b/NetworkPkg/ArpDxe/ArpImpl.c
index 0e9ef103eff9..9cdb33f2bd66 100644
--- a/NetworkPkg/ArpDxe/ArpImpl.c
+++ b/NetworkPkg/ArpDxe/ArpImpl.c
@@ -55,7 +55,7 @@ ArpInitInstance (
/**
Process the Arp packets received from Mnp, the procedure conforms to RFC826.
- @param[in] Context Pointer to the context data registerd to the
+ @param[in] Context Pointer to the context data registered to the
Event.
@return None.
@@ -316,7 +316,7 @@ RESTART_RECEIVE:
Queue ArpOnFrameRcvdDpc as a DPC at TPL_CALLBACK.
@param[in] Event The Event this notify function registered to.
- @param[in] Context Pointer to the context data registerd to the
+ @param[in] Context Pointer to the context data registered to the
Event.
@return None.
@@ -338,7 +338,7 @@ ArpOnFrameRcvd (
/**
Process the already sent arp packets.
- @param[in] Context Pointer to the context data registerd to the
+ @param[in] Context Pointer to the context data registered to the
Event.
@return None.
@@ -377,7 +377,7 @@ ArpOnFrameSentDpc (
Request ArpOnFrameSentDpc as a DPC at TPL_CALLBACK.
@param[in] Event The Event this notify function registered to.
- @param[in] Context Pointer to the context data registerd to the
+ @param[in] Context Pointer to the context data registered to the
Event.
@return None.
@@ -401,7 +401,7 @@ ArpOnFrameSent (
Process the arp cache olding and drive the retrying arp requests.
@param[in] Event The Event this notify function registered to.
- @param[in] Context Pointer to the context data registerd to the
+ @param[in] Context Pointer to the context data registered to the
Event.
@return None.
@@ -1008,7 +1008,7 @@ ArpConfigureInstance (
/**
- Send out an arp frame using the CachEntry and the ArpOpCode.
+ Send out an arp frame using the CacheEntry and the ArpOpCode.
@param[in] Instance Pointer to the instance context data.
@param[in] CacheEntry Pointer to the configuration data used to
@@ -1344,7 +1344,7 @@ ArpDeleteCacheEntry (
);
//
- // Delete the cache entries inthe ResolvedCacheTable.
+ // Delete the cache entries in the ResolvedCacheTable.
//
Count += ArpDeleteCacheEntryInTable (
&ArpService->ResolvedCacheTable,
@@ -1466,7 +1466,7 @@ ArpFindCacheEntry (
ArpService = Instance->ArpService;
//
- // Init the FounEntries used to hold the found cache entries.
+ // Init the FoundEntries used to hold the found cache entries.
//
NetMapInit (&FoundEntries);
diff --git a/NetworkPkg/ArpDxe/ArpMain.c b/NetworkPkg/ArpDxe/ArpMain.c
index f06121fed452..6e8690a93689 100644
--- a/NetworkPkg/ArpDxe/ArpMain.c
+++ b/NetworkPkg/ArpDxe/ArpMain.c
@@ -175,7 +175,7 @@ ArpAdd (
OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
//
- // See whether the entry to add exists. Check the DeinedCacheTable first.
+ // See whether the entry to add exists. Check the DeniedCacheTable first.
//
CacheEntry = ArpFindDeniedCacheEntry (
ArpService,
@@ -198,7 +198,7 @@ ArpAdd (
if ((CacheEntry != NULL) && !Overwrite) {
//
- // The entry to add exists, if not Overwirte, deny this add request.
+ // The entry to add exists, if not Overwrite, deny this add request.
//
Status = EFI_ACCESS_DENIED;
goto UNLOCK_EXIT;
@@ -542,7 +542,7 @@ ArpRequest (
ProtocolAddress.AddressPtr = TargetSwAddress;
//
- // Initialize the TargetHwAddrss to a zero address.
+ // Initialize the TargetHwAddress to a zero address.
//
ZeroMem (TargetHwAddress, SnpMode->HwAddressSize);
@@ -675,7 +675,7 @@ SIGNAL_USER:
If the request is in the internal ARP request queue, the request is aborted
immediately and its ResolvedEvent is signaled. Only an asynchronous address
- request needs to be canceled. If TargeSwAddress and ResolveEvent are both
+ request needs to be canceled. If TargetSwAddress and ResolvedEvent are both
NULL, all the pending asynchronous requests that have been issued by This
instance will be cancelled and their corresponding events will be signaled.
@@ -729,7 +729,7 @@ ArpCancel (
//
// Dispatch the DPCs queued by the NotifyFunction of the events signaled
- // by ArpCancleRequest.
+ // by ArpCancelRequest.
//
DispatchDpc ();
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [edk2-devel] [PATCH 32/79] NetworkPkg/ArpDxe: Fix various typos
2019-12-03 16:15 ` [PATCH 32/79] NetworkPkg/ArpDxe: Fix various typos Philippe Mathieu-Daudé
@ 2019-12-04 13:20 ` Maciej Rabeda
0 siblings, 0 replies; 122+ messages in thread
From: Maciej Rabeda @ 2019-12-04 13:20 UTC (permalink / raw)
To: devel, philmd; +Cc: Antoine Coeur, Jiaxin Wu, Siyuan Fu, Maciej Rabeda
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
On 03-Dec-19 17:15, Philippe Mathieu-Daudé wrote:
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in documentation, comments and debug strings.
>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> NetworkPkg/ArpDxe/ArpDriver.h | 10 +++++-----
> NetworkPkg/ArpDxe/ArpImpl.h | 14 +++++++-------
> NetworkPkg/ArpDxe/ArpDriver.c | 14 +++++++-------
> NetworkPkg/ArpDxe/ArpImpl.c | 16 ++++++++--------
> NetworkPkg/ArpDxe/ArpMain.c | 10 +++++-----
> 5 files changed, 32 insertions(+), 32 deletions(-)
>
> diff --git a/NetworkPkg/ArpDxe/ArpDriver.h b/NetworkPkg/ArpDxe/ArpDriver.h
> index 0b5b06ee37d5..7dbc1c187820 100644
> --- a/NetworkPkg/ArpDxe/ArpDriver.h
> +++ b/NetworkPkg/ArpDxe/ArpDriver.h
> @@ -30,7 +30,7 @@ extern EFI_COMPONENT_NAME_PROTOCOL gArpComponentName;
> extern EFI_COMPONENT_NAME2_PROTOCOL gArpComponentName2;
>
> //
> -// Function prototypes for the Drivr Binding Protocol
> +// Function prototypes for the Driver Binding Protocol
> //
> /**
> Tests to see if this driver supports a given controller.
> @@ -55,7 +55,7 @@ extern EFI_COMPONENT_NAME2_PROTOCOL gArpComponentName2;
> @retval EFI_ACCESS_DENIED The device specified by ControllerHandle and
> RemainingDevicePath is already being managed by
> a different driver or an application that
> - requires exclusive acces. Currently not implemented.
> + requires exclusive access. Currently not implemented.
> @retval EFI_UNSUPPORTED The device specified by ControllerHandle and
> RemainingDevicePath is not supported by the
> driver specified by This.
> @@ -97,7 +97,7 @@ ArpDriverBindingSupported (
> Currently not implemented.
> @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of
> resources.
> - @retval Others The driver failded to start the device.
> + @retval Others The driver failed to start the device.
>
> **/
> EFI_STATUS
> @@ -159,7 +159,7 @@ ArpDriverBindingStop (
> then a new handle is created. If it is a pointer to an existing
> UEFI handle, then the protocol is added to the existing UEFI handle.
>
> - @retval EFI_SUCCES The protocol was added to ChildHandle.
> + @retval EFI_SUCCESS The protocol was added to ChildHandle.
> @retval EFI_INVALID_PARAMETER ChildHandle is NULL.
> @retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
> the child
> @@ -183,7 +183,7 @@ ArpServiceBindingCreateChild (
> @param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
> @param ChildHandle Handle of the child to destroy
>
> - @retval EFI_SUCCES The protocol was removed from ChildHandle.
> + @retval EFI_SUCCESS The protocol was removed from ChildHandle.
> @retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is
> being removed.
> @retval EFI_INVALID_PARAMETER Child handle is NULL.
> diff --git a/NetworkPkg/ArpDxe/ArpImpl.h b/NetworkPkg/ArpDxe/ArpImpl.h
> index 47eedc1cb6f7..506f3e6ef61e 100644
> --- a/NetworkPkg/ArpDxe/ArpImpl.h
> +++ b/NetworkPkg/ArpDxe/ArpImpl.h
> @@ -436,7 +436,7 @@ ArpRequest (
>
> If the request is in the internal ARP request queue, the request is aborted
> immediately and its ResolvedEvent is signaled. Only an asynchronous address
> - request needs to be canceled. If TargeSwAddress and ResolveEvent are both
> + request needs to be canceled. If TargetSwAddress and ResolvedEvent are both
> NULL, all the pending asynchronous requests that have been issued by This
> instance will be cancelled and their corresponding events will be signaled.
>
> @@ -599,7 +599,7 @@ ArpDeleteCacheEntry (
> );
>
> /**
> - Send out an arp frame using the CachEntry and the ArpOpCode.
> + Send out an arp frame using the CacheEntry and the ArpOpCode.
>
> @param[in] Instance Pointer to the instance context data.
> @param[in] CacheEntry Pointer to the configuration data used to
> @@ -636,7 +636,7 @@ ArpInitInstance (
> /**
> Process the Arp packets received from Mnp, the procedure conforms to RFC826.
>
> - @param[in] Context Pointer to the context data registerd to the
> + @param[in] Context Pointer to the context data registered to the
> Event.
>
> @return None.
> @@ -652,7 +652,7 @@ ArpOnFrameRcvdDpc (
> Queue ArpOnFrameRcvdDpc as a DPC at TPL_CALLBACK.
>
> @param[in] Event The Event this notify function registered to.
> - @param[in] Context Pointer to the context data registerd to the
> + @param[in] Context Pointer to the context data registered to the
> Event.
>
> @return None.
> @@ -668,7 +668,7 @@ ArpOnFrameRcvd (
> /**
> Process the already sent arp packets.
>
> - @param[in] Context Pointer to the context data registerd to the
> + @param[in] Context Pointer to the context data registered to the
> Event.
>
> @return None.
> @@ -684,7 +684,7 @@ ArpOnFrameSentDpc (
> Request ArpOnFrameSentDpc as a DPC at TPL_CALLBACK.
>
> @param[in] Event The Event this notify function registered to.
> - @param[in] Context Pointer to the context data registerd to the
> + @param[in] Context Pointer to the context data registered to the
> Event.
>
> @return None.
> @@ -701,7 +701,7 @@ ArpOnFrameSent (
> Process the arp cache olding and drive the retrying arp requests.
>
> @param[in] Event The Event this notify function registered to.
> - @param[in] Context Pointer to the context data registerd to the
> + @param[in] Context Pointer to the context data registered to the
> Event.
>
> @return None.
> diff --git a/NetworkPkg/ArpDxe/ArpDriver.c b/NetworkPkg/ArpDxe/ArpDriver.c
> index 632d691d7588..f50beb55bf9f 100644
> --- a/NetworkPkg/ArpDxe/ArpDriver.c
> +++ b/NetworkPkg/ArpDxe/ArpDriver.c
> @@ -195,7 +195,7 @@ ArpCleanService (
>
> if (ArpService->PeriodicTimer != NULL) {
> //
> - // Cancle and close the PeriodicTimer.
> + // Cancel and close the PeriodicTimer.
> //
> gBS->SetTimer (ArpService->PeriodicTimer, TimerCancel, 0);
> gBS->CloseEvent (ArpService->PeriodicTimer);
> @@ -203,7 +203,7 @@ ArpCleanService (
>
> if (ArpService->RxToken.Event != NULL) {
> //
> - // Cancle the RxToken and close the event in the RxToken.
> + // Cancel the RxToken and close the event in the RxToken.
> //
> ArpService->Mnp->Cancel (ArpService->Mnp, NULL);
> gBS->CloseEvent (ArpService->RxToken.Event);
> @@ -288,7 +288,7 @@ ArpDestroyChildEntryInHandleBuffer (
> @retval EFI_ACCESS_DENIED The device specified by ControllerHandle and
> RemainingDevicePath is already being managed by
> a different driver or an application that
> - requires exclusive acces. Currently not implemented.
> + requires exclusive access. Currently not implemented.
> @retval EFI_UNSUPPORTED The device specified by ControllerHandle and
> RemainingDevicePath is not supported by the
> driver specified by This.
> @@ -363,7 +363,7 @@ ArpDriverBindingSupported (
> Currently not implemented.
> @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of
> resources.
> - @retval Others The driver failded to start the device.
> + @retval Others The driver failed to start the device.
>
> **/
> EFI_STATUS
> @@ -547,7 +547,7 @@ ArpDriverBindingStop (
> then a new handle is created. If it is a pointer to an existing
> UEFI handle, then the protocol is added to the existing UEFI handle.
>
> - @retval EFI_SUCCES The protocol was added to ChildHandle.
> + @retval EFI_SUCCESS The protocol was added to ChildHandle.
> @retval EFI_INVALID_PARAMETER ChildHandle is NULL.
> @retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
> the child
> @@ -598,7 +598,7 @@ ArpServiceBindingCreateChild (
> NULL
> );
> if (EFI_ERROR (Status)) {
> - DEBUG ((EFI_D_ERROR, "ArpSBCreateChild: faild to install ARP protocol, %r.\n", Status));
> + DEBUG ((EFI_D_ERROR, "ArpSBCreateChild: failed to install ARP protocol, %r.\n", Status));
>
> FreePool (Instance);
> return Status;
> @@ -672,7 +672,7 @@ ERROR:
> @param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
> @param ChildHandle Handle of the child to destroy
>
> - @retval EFI_SUCCES The protocol was removed from ChildHandle.
> + @retval EFI_SUCCESS The protocol was removed from ChildHandle.
> @retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is
> being removed.
> @retval EFI_INVALID_PARAMETER Child handle is NULL.
> diff --git a/NetworkPkg/ArpDxe/ArpImpl.c b/NetworkPkg/ArpDxe/ArpImpl.c
> index 0e9ef103eff9..9cdb33f2bd66 100644
> --- a/NetworkPkg/ArpDxe/ArpImpl.c
> +++ b/NetworkPkg/ArpDxe/ArpImpl.c
> @@ -55,7 +55,7 @@ ArpInitInstance (
> /**
> Process the Arp packets received from Mnp, the procedure conforms to RFC826.
>
> - @param[in] Context Pointer to the context data registerd to the
> + @param[in] Context Pointer to the context data registered to the
> Event.
>
> @return None.
> @@ -316,7 +316,7 @@ RESTART_RECEIVE:
> Queue ArpOnFrameRcvdDpc as a DPC at TPL_CALLBACK.
>
> @param[in] Event The Event this notify function registered to.
> - @param[in] Context Pointer to the context data registerd to the
> + @param[in] Context Pointer to the context data registered to the
> Event.
>
> @return None.
> @@ -338,7 +338,7 @@ ArpOnFrameRcvd (
> /**
> Process the already sent arp packets.
>
> - @param[in] Context Pointer to the context data registerd to the
> + @param[in] Context Pointer to the context data registered to the
> Event.
>
> @return None.
> @@ -377,7 +377,7 @@ ArpOnFrameSentDpc (
> Request ArpOnFrameSentDpc as a DPC at TPL_CALLBACK.
>
> @param[in] Event The Event this notify function registered to.
> - @param[in] Context Pointer to the context data registerd to the
> + @param[in] Context Pointer to the context data registered to the
> Event.
>
> @return None.
> @@ -401,7 +401,7 @@ ArpOnFrameSent (
> Process the arp cache olding and drive the retrying arp requests.
>
> @param[in] Event The Event this notify function registered to.
> - @param[in] Context Pointer to the context data registerd to the
> + @param[in] Context Pointer to the context data registered to the
> Event.
>
> @return None.
> @@ -1008,7 +1008,7 @@ ArpConfigureInstance (
>
>
> /**
> - Send out an arp frame using the CachEntry and the ArpOpCode.
> + Send out an arp frame using the CacheEntry and the ArpOpCode.
>
> @param[in] Instance Pointer to the instance context data.
> @param[in] CacheEntry Pointer to the configuration data used to
> @@ -1344,7 +1344,7 @@ ArpDeleteCacheEntry (
> );
>
> //
> - // Delete the cache entries inthe ResolvedCacheTable.
> + // Delete the cache entries in the ResolvedCacheTable.
> //
> Count += ArpDeleteCacheEntryInTable (
> &ArpService->ResolvedCacheTable,
> @@ -1466,7 +1466,7 @@ ArpFindCacheEntry (
> ArpService = Instance->ArpService;
>
> //
> - // Init the FounEntries used to hold the found cache entries.
> + // Init the FoundEntries used to hold the found cache entries.
> //
> NetMapInit (&FoundEntries);
>
> diff --git a/NetworkPkg/ArpDxe/ArpMain.c b/NetworkPkg/ArpDxe/ArpMain.c
> index f06121fed452..6e8690a93689 100644
> --- a/NetworkPkg/ArpDxe/ArpMain.c
> +++ b/NetworkPkg/ArpDxe/ArpMain.c
> @@ -175,7 +175,7 @@ ArpAdd (
> OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
>
> //
> - // See whether the entry to add exists. Check the DeinedCacheTable first.
> + // See whether the entry to add exists. Check the DeniedCacheTable first.
> //
> CacheEntry = ArpFindDeniedCacheEntry (
> ArpService,
> @@ -198,7 +198,7 @@ ArpAdd (
>
> if ((CacheEntry != NULL) && !Overwrite) {
> //
> - // The entry to add exists, if not Overwirte, deny this add request.
> + // The entry to add exists, if not Overwrite, deny this add request.
> //
> Status = EFI_ACCESS_DENIED;
> goto UNLOCK_EXIT;
> @@ -542,7 +542,7 @@ ArpRequest (
> ProtocolAddress.AddressPtr = TargetSwAddress;
>
> //
> - // Initialize the TargetHwAddrss to a zero address.
> + // Initialize the TargetHwAddress to a zero address.
> //
> ZeroMem (TargetHwAddress, SnpMode->HwAddressSize);
>
> @@ -675,7 +675,7 @@ SIGNAL_USER:
>
> If the request is in the internal ARP request queue, the request is aborted
> immediately and its ResolvedEvent is signaled. Only an asynchronous address
> - request needs to be canceled. If TargeSwAddress and ResolveEvent are both
> + request needs to be canceled. If TargetSwAddress and ResolvedEvent are both
> NULL, all the pending asynchronous requests that have been issued by This
> instance will be cancelled and their corresponding events will be signaled.
>
> @@ -729,7 +729,7 @@ ArpCancel (
>
> //
> // Dispatch the DPCs queued by the NotifyFunction of the events signaled
> - // by ArpCancleRequest.
> + // by ArpCancelRequest.
> //
> DispatchDpc ();
>
^ permalink raw reply [flat|nested] 122+ messages in thread
* [PATCH 33/79] NetworkPkg/Dhcp4Dxe: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (31 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 32/79] NetworkPkg/ArpDxe: Fix various typos Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-04 13:25 ` [edk2-devel] " Maciej Rabeda
2019-12-03 16:15 ` [PATCH 34/79] NetworkPkg/Dhcp6Dxe: " Philippe Mathieu-Daudé
` (39 subsequent siblings)
72 siblings, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel
Cc: Antoine Coeur, Jiaxin Wu, Siyuan Fu, Maciej Rabeda,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h | 4 +--
NetworkPkg/Dhcp4Dxe/Dhcp4Io.h | 2 +-
NetworkPkg/Dhcp4Dxe/Dhcp4Option.h | 18 +++++++-------
NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c | 8 +++---
NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c | 6 ++---
NetworkPkg/Dhcp4Dxe/Dhcp4Io.c | 12 ++++-----
NetworkPkg/Dhcp4Dxe/Dhcp4Option.c | 26 ++++++++++----------
7 files changed, 38 insertions(+), 38 deletions(-)
diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h b/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h
index cebde20dca5b..f6370582cbd1 100644
--- a/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h
+++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h
@@ -104,7 +104,7 @@ Dhcp4DriverBindingStop (
then a new handle is created. If it is a pointer to an existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child
@@ -128,7 +128,7 @@ Dhcp4ServiceBindingCreateChild (
@param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param ChildHandle Handle of the child to destroy
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Io.h b/NetworkPkg/Dhcp4Dxe/Dhcp4Io.h
index 01283e5e17b9..0dd6b46b87d0 100644
--- a/NetworkPkg/Dhcp4Dxe/Dhcp4Io.h
+++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Io.h
@@ -108,7 +108,7 @@ DhcpSendMessage (
/**
Each DHCP service has three timer. Two of them are count down timer.
One for the packet retransmission. The other is to collect the offers.
- The third timer increaments the lease life which is compared to T1, T2,
+ The third timer increments the lease life which is compared to T1, T2,
and lease to determine the time to renew and rebind the lease.
DhcpOnTimerTick will be called once every second.
diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
index 393176c8996d..a58bb1b0baa8 100644
--- a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
+++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
@@ -81,9 +81,9 @@ typedef struct {
///
/// Structure used to describe and validate the format of DHCP options.
/// Type is the options' data type, such as DHCP_OPTION_INT8. MinOccur
-/// is the minium occurance of this data type. MaxOccur is defined
+/// is the minimum occurrence of this data type. MaxOccur is defined
/// similarly. If MaxOccur is -1, it means that there is no limit on the
-/// maximum occurance. Alert tells whether DHCP client should further
+/// maximum occurrence. Alert tells whether DHCP client should further
/// inspect the option to parse DHCP_PARAMETER.
///
typedef struct {
@@ -114,8 +114,8 @@ EFI_STATUS
found
@param[in] Context The opaque parameter for Check
- @retval EFI_SUCCESS The DHCP packet's options are well formated
- @retval EFI_INVALID_PARAMETER The DHCP packet's options are not well formated
+ @retval EFI_SUCCESS The DHCP packet's options are well formatted
+ @retval EFI_INVALID_PARAMETER The DHCP packet's options are not well formatted
**/
EFI_STATUS
@@ -133,7 +133,7 @@ DhcpIterateOptions (
@param[out] Para The variable to save the DHCP parameters.
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory to validate the packet.
- @retval EFI_INVALID_PARAMETER The options are malformatted
+ @retval EFI_INVALID_PARAMETER The options are mal-formatted
@retval EFI_SUCCESS The options are parsed into OptionPoint
**/
@@ -146,8 +146,8 @@ DhcpValidateOptions (
/**
Parse the options of a DHCP packet. It supports RFC 3396: Encoding
Long Options in DHCP. That is, it will combine all the option value
- of all the occurances of each option.
- A little bit of implemenation:
+ of all the occurrences of each option.
+ A little bit of implementation:
It adopts the "Key indexed counting" algorithm. First, it allocates
an array of 256 DHCP_OPTION_COUNTs because DHCP option tag is encoded
as a UINT8. It then iterates the DHCP packet to get data length of
@@ -167,7 +167,7 @@ DhcpValidateOptions (
@retval EFI_NOT_FOUND Cannot find any option.
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory to parse the packet.
- @retval EFI_INVALID_PARAMETER The options are malformatted
+ @retval EFI_INVALID_PARAMETER The options are mal-formatted
@retval EFI_SUCCESS The options are parsed into OptionPoint
**/
@@ -211,7 +211,7 @@ DhcpAppendOption (
function.
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory
- @retval EFI_INVALID_PARAMETER The options in SeekPacket are malformatted
+ @retval EFI_INVALID_PARAMETER The options in SeekPacket are mal-formatted
@retval EFI_SUCCESS The packet is build.
**/
diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c b/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c
index e891b6888307..970141abfe3a 100644
--- a/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c
+++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c
@@ -326,7 +326,7 @@ Dhcp4DriverBindingStart (
}
//
- // Install the Dhcp4ServiceBinding Protocol onto ControlerHandle
+ // Install the Dhcp4ServiceBinding Protocol onto ControllerHandle
//
Status = gBS->InstallMultipleProtocolInterfaces (
&ControllerHandle,
@@ -438,7 +438,7 @@ Dhcp4DriverBindingStop (
DhcpSb = DHCP_SERVICE_FROM_THIS (ServiceBinding);
if (!IsListEmpty (&DhcpSb->Children)) {
//
- // Destroy all the children instances before destory the service.
+ // Destroy all the children instances before destroy the service.
//
List = &DhcpSb->Children;
Status = NetDestroyLinkList (
@@ -523,7 +523,7 @@ DhcpInitProtocol (
then a new handle is created. If it is a pointer to an existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child
@@ -617,7 +617,7 @@ Dhcp4ServiceBindingCreateChild (
@param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param ChildHandle Handle of the child to destroy
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c b/NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c
index 0b35bdf4df95..82905337908d 100644
--- a/NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c
+++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c
@@ -64,7 +64,7 @@ EfiDhcp4GetModeData (
not NULL. Otherwise, the state was left unchanged.
@retval EFI_ACCESS_DENIED This instance of the EFI DHCPv4 Protocol driver was not in the
Dhcp4Stopped, Dhcp4Init, Dhcp4InitReboot, or Dhcp4Bound state;
- Or onother instance of this EFI DHCPv4 Protocol driver is already
+ Or another instance of this EFI DHCPv4 Protocol driver is already
in a valid configured state.
@retval EFI_INVALID_PARAMETER Some parameter is NULL.
@retval EFI_OUT_OF_RESOURCES Required system resources could not be allocated.
@@ -611,7 +611,7 @@ DhcpYieldControl (
not NULL. Otherwise, the state was left unchanged.
@retval EFI_ACCESS_DENIED This instance of the EFI DHCPv4 Protocol driver was not in the
Dhcp4Stopped, Dhcp4Init, Dhcp4InitReboot, or Dhcp4Bound state;
- Or onother instance of this EFI DHCPv4 Protocol driver is already
+ Or another instance of this EFI DHCPv4 Protocol driver is already
in a valid configured state.
@retval EFI_INVALID_PARAMETER Some parameter is NULL.
@retval EFI_OUT_OF_RESOURCES Required system resources could not be allocated.
@@ -805,7 +805,7 @@ EfiDhcp4Start (
}
//
- // Check Media Satus.
+ // Check Media Status.
//
MediaStatus = EFI_SUCCESS;
NetLibDetectMediaWaitTimeout (DhcpSb->Controller, DHCP_CHECK_MEDIA_WAITING_TIME, &MediaStatus);
diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Io.c b/NetworkPkg/Dhcp4Dxe/Dhcp4Io.c
index 4728b94c5803..34c72d690a31 100644
--- a/NetworkPkg/Dhcp4Dxe/Dhcp4Io.c
+++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Io.c
@@ -604,7 +604,7 @@ DhcpEndSession (
is, all the option value that we care.
@retval EFI_SUCCESS The packet is successfully processed.
- @retval Others Some error occured.
+ @retval Others Some error occurred.
**/
EFI_STATUS
@@ -632,7 +632,7 @@ DhcpHandleSelect (
//
// Call the user's callback. The action according to the return is as:
- // 1. EFI_SUCESS: stop waiting for more offers, select the offer now
+ // 1. EFI_SUCCESS: stop waiting for more offers, select the offer now
// 2. EFI_NOT_READY: wait for more offers
// 3. EFI_ABORTED: abort the address acquiring.
//
@@ -679,7 +679,7 @@ ON_EXIT:
is, all the option value that we care.
@retval EFI_SUCCESS The packet is successfully processed.
- @retval Others Some error occured.
+ @retval Others Some error occurred.
**/
EFI_STATUS
@@ -772,7 +772,7 @@ ON_EXIT:
is, all the option value that we care.
@retval EFI_SUCCESS The packet is successfully processed.
- @retval Others Some error occured.
+ @retval Others Some error occurred.
**/
EFI_STATUS
@@ -856,7 +856,7 @@ ON_EXIT:
is, all the option value that we care.
@retval EFI_SUCCESS The packet is successfully processed.
- @retval Others Some error occured.
+ @retval Others Some error occurred.
**/
EFI_STATUS
@@ -1473,7 +1473,7 @@ DhcpRetransmit (
/**
Each DHCP service has three timer. Two of them are count down timer.
One for the packet retransmission. The other is to collect the offers.
- The third timer increaments the lease life which is compared to T1, T2,
+ The third timer increments the lease life which is compared to T1, T2,
and lease to determine the time to renew and rebind the lease.
DhcpOnTimerTick will be called once every second.
diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c
index 3b077de11177..37a63022c55f 100644
--- a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c
+++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c
@@ -195,7 +195,7 @@ DhcpOptionIsValid (
}
//
- // Validate the occurance of the option unit is with in [MinOccur, MaxOccur]
+ // Validate the occurrence of the option unit is with in [MinOccur, MaxOccur]
//
Occur = Len / Unit;
@@ -230,7 +230,7 @@ DhcpOptionIsValid (
@param[out] Para The variable to save the interested parameter
@retval EFI_SUCCESS The DHCP option is successfully extracted.
- @retval EFI_INVALID_PARAMETER The DHCP option is malformatted
+ @retval EFI_INVALID_PARAMETER The DHCP option is mal-formatted
**/
EFI_STATUS
@@ -303,7 +303,7 @@ DhcpGetParameter (
option.
@retval EFI_SUCCESS All the options are valid
- @retval EFI_INVALID_PARAMETER The options are malformatted.
+ @retval EFI_INVALID_PARAMETER The options are mal-formatted.
**/
EFI_STATUS
@@ -376,8 +376,8 @@ DhcpIterateBufferOptions (
found
@param[in] Context The opaque parameter for Check
- @retval EFI_SUCCESS The DHCP packet's options are well formated
- @retval EFI_INVALID_PARAMETER The DHCP packet's options are not well formated
+ @retval EFI_SUCCESS The DHCP packet's options are well formatted
+ @retval EFI_INVALID_PARAMETER The DHCP packet's options are not well formatted
**/
EFI_STATUS
@@ -438,7 +438,7 @@ DhcpIterateOptions (
/**
Call back function to DhcpIterateOptions to compute each option's
- length. It just adds the data length of all the occurances of this
+ length. It just adds the data length of all the occurrences of this
Tag. Context is an array of 256 DHCP_OPTION_COUNT.
@param[in] Tag The current option to check
@@ -473,7 +473,7 @@ DhcpGetOptionLen (
@param[in] Tag The option to consolidate its data
@param[in] Len The length of option data
- @param[in] Data The data of the option's current occurance
+ @param[in] Data The data of the option's current occurrence
@param[in] Context The context, which is DHCP_OPTION_CONTEXT. This
array is just a wrap to pass THREE parameters.
@@ -517,8 +517,8 @@ DhcpFillOption (
/**
Parse the options of a DHCP packet. It supports RFC 3396: Encoding
Long Options in DHCP. That is, it will combine all the option value
- of all the occurances of each option.
- A little bit of implemenation:
+ of all the occurrences of each option.
+ A little bit of implementation:
It adopts the "Key indexed counting" algorithm. First, it allocates
an array of 256 DHCP_OPTION_COUNTs because DHCP option tag is encoded
as a UINT8. It then iterates the DHCP packet to get data length of
@@ -538,7 +538,7 @@ DhcpFillOption (
@retval EFI_NOT_FOUND Cannot find any option.
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory to parse the packet.
- @retval EFI_INVALID_PARAMETER The options are malformatted
+ @retval EFI_INVALID_PARAMETER The options are mal-formatted
@retval EFI_SUCCESS The options are parsed into OptionPoint
**/
@@ -639,7 +639,7 @@ ON_EXIT:
@param[out] Para The variable to save the DHCP parameters.
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory to validate the packet.
- @retval EFI_INVALID_PARAMETER The options are malformatted
+ @retval EFI_INVALID_PARAMETER The options are mal-formatted
@retval EFI_SUCCESS The options are parsed into OptionPoint
**/
@@ -770,7 +770,7 @@ DhcpAppendOption (
function.
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory
- @retval EFI_INVALID_PARAMETER The options in SeekPacket are malformatted
+ @retval EFI_INVALID_PARAMETER The options in SeekPacket are mal-formatted
@retval EFI_SUCCESS The packet is build.
**/
@@ -794,7 +794,7 @@ DhcpBuild (
UINT8 *Buf;
//
- // Use an array of DHCP_OPTION to mark the existance
+ // Use an array of DHCP_OPTION to mark the existence
// and position of each valid options.
//
Mark = AllocatePool (sizeof (DHCP_OPTION) * DHCP_MAX_OPTIONS);
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [edk2-devel] [PATCH 33/79] NetworkPkg/Dhcp4Dxe: Fix various typos
2019-12-03 16:15 ` [PATCH 33/79] NetworkPkg/Dhcp4Dxe: " Philippe Mathieu-Daudé
@ 2019-12-04 13:25 ` Maciej Rabeda
0 siblings, 0 replies; 122+ messages in thread
From: Maciej Rabeda @ 2019-12-04 13:25 UTC (permalink / raw)
To: devel, philmd; +Cc: Antoine Coeur, Jiaxin Wu, Siyuan Fu, Maciej Rabeda
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
On 03-Dec-19 17:15, Philippe Mathieu-Daudé wrote:
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h | 4 +--
> NetworkPkg/Dhcp4Dxe/Dhcp4Io.h | 2 +-
> NetworkPkg/Dhcp4Dxe/Dhcp4Option.h | 18 +++++++-------
> NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c | 8 +++---
> NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c | 6 ++---
> NetworkPkg/Dhcp4Dxe/Dhcp4Io.c | 12 ++++-----
> NetworkPkg/Dhcp4Dxe/Dhcp4Option.c | 26 ++++++++++----------
> 7 files changed, 38 insertions(+), 38 deletions(-)
>
> diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h b/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h
> index cebde20dca5b..f6370582cbd1 100644
> --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h
> +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h
> @@ -104,7 +104,7 @@ Dhcp4DriverBindingStop (
> then a new handle is created. If it is a pointer to an existing UEFI handle,
> then the protocol is added to the existing UEFI handle.
>
> - @retval EFI_SUCCES The protocol was added to ChildHandle.
> + @retval EFI_SUCCESS The protocol was added to ChildHandle.
> @retval EFI_INVALID_PARAMETER ChildHandle is NULL.
> @retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
> the child
> @@ -128,7 +128,7 @@ Dhcp4ServiceBindingCreateChild (
> @param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
> @param ChildHandle Handle of the child to destroy
>
> - @retval EFI_SUCCES The protocol was removed from ChildHandle.
> + @retval EFI_SUCCESS The protocol was removed from ChildHandle.
> @retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
> @retval EFI_INVALID_PARAMETER Child handle is NULL.
> @retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
> diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Io.h b/NetworkPkg/Dhcp4Dxe/Dhcp4Io.h
> index 01283e5e17b9..0dd6b46b87d0 100644
> --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Io.h
> +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Io.h
> @@ -108,7 +108,7 @@ DhcpSendMessage (
> /**
> Each DHCP service has three timer. Two of them are count down timer.
> One for the packet retransmission. The other is to collect the offers.
> - The third timer increaments the lease life which is compared to T1, T2,
> + The third timer increments the lease life which is compared to T1, T2,
> and lease to determine the time to renew and rebind the lease.
> DhcpOnTimerTick will be called once every second.
>
> diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
> index 393176c8996d..a58bb1b0baa8 100644
> --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
> +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.h
> @@ -81,9 +81,9 @@ typedef struct {
> ///
> /// Structure used to describe and validate the format of DHCP options.
> /// Type is the options' data type, such as DHCP_OPTION_INT8. MinOccur
> -/// is the minium occurance of this data type. MaxOccur is defined
> +/// is the minimum occurrence of this data type. MaxOccur is defined
> /// similarly. If MaxOccur is -1, it means that there is no limit on the
> -/// maximum occurance. Alert tells whether DHCP client should further
> +/// maximum occurrence. Alert tells whether DHCP client should further
> /// inspect the option to parse DHCP_PARAMETER.
> ///
> typedef struct {
> @@ -114,8 +114,8 @@ EFI_STATUS
> found
> @param[in] Context The opaque parameter for Check
>
> - @retval EFI_SUCCESS The DHCP packet's options are well formated
> - @retval EFI_INVALID_PARAMETER The DHCP packet's options are not well formated
> + @retval EFI_SUCCESS The DHCP packet's options are well formatted
> + @retval EFI_INVALID_PARAMETER The DHCP packet's options are not well formatted
>
> **/
> EFI_STATUS
> @@ -133,7 +133,7 @@ DhcpIterateOptions (
> @param[out] Para The variable to save the DHCP parameters.
>
> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to validate the packet.
> - @retval EFI_INVALID_PARAMETER The options are malformatted
> + @retval EFI_INVALID_PARAMETER The options are mal-formatted
> @retval EFI_SUCCESS The options are parsed into OptionPoint
>
> **/
> @@ -146,8 +146,8 @@ DhcpValidateOptions (
> /**
> Parse the options of a DHCP packet. It supports RFC 3396: Encoding
> Long Options in DHCP. That is, it will combine all the option value
> - of all the occurances of each option.
> - A little bit of implemenation:
> + of all the occurrences of each option.
> + A little bit of implementation:
> It adopts the "Key indexed counting" algorithm. First, it allocates
> an array of 256 DHCP_OPTION_COUNTs because DHCP option tag is encoded
> as a UINT8. It then iterates the DHCP packet to get data length of
> @@ -167,7 +167,7 @@ DhcpValidateOptions (
>
> @retval EFI_NOT_FOUND Cannot find any option.
> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to parse the packet.
> - @retval EFI_INVALID_PARAMETER The options are malformatted
> + @retval EFI_INVALID_PARAMETER The options are mal-formatted
> @retval EFI_SUCCESS The options are parsed into OptionPoint
>
> **/
> @@ -211,7 +211,7 @@ DhcpAppendOption (
> function.
>
> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory
> - @retval EFI_INVALID_PARAMETER The options in SeekPacket are malformatted
> + @retval EFI_INVALID_PARAMETER The options in SeekPacket are mal-formatted
> @retval EFI_SUCCESS The packet is build.
>
> **/
> diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c b/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c
> index e891b6888307..970141abfe3a 100644
> --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c
> +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c
> @@ -326,7 +326,7 @@ Dhcp4DriverBindingStart (
> }
>
> //
> - // Install the Dhcp4ServiceBinding Protocol onto ControlerHandle
> + // Install the Dhcp4ServiceBinding Protocol onto ControllerHandle
> //
> Status = gBS->InstallMultipleProtocolInterfaces (
> &ControllerHandle,
> @@ -438,7 +438,7 @@ Dhcp4DriverBindingStop (
> DhcpSb = DHCP_SERVICE_FROM_THIS (ServiceBinding);
> if (!IsListEmpty (&DhcpSb->Children)) {
> //
> - // Destroy all the children instances before destory the service.
> + // Destroy all the children instances before destroy the service.
> //
> List = &DhcpSb->Children;
> Status = NetDestroyLinkList (
> @@ -523,7 +523,7 @@ DhcpInitProtocol (
> then a new handle is created. If it is a pointer to an existing UEFI handle,
> then the protocol is added to the existing UEFI handle.
>
> - @retval EFI_SUCCES The protocol was added to ChildHandle.
> + @retval EFI_SUCCESS The protocol was added to ChildHandle.
> @retval EFI_INVALID_PARAMETER ChildHandle is NULL.
> @retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
> the child
> @@ -617,7 +617,7 @@ Dhcp4ServiceBindingCreateChild (
> @param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
> @param ChildHandle Handle of the child to destroy
>
> - @retval EFI_SUCCES The protocol was removed from ChildHandle.
> + @retval EFI_SUCCESS The protocol was removed from ChildHandle.
> @retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
> @retval EFI_INVALID_PARAMETER Child handle is NULL.
> @retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
> diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c b/NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c
> index 0b35bdf4df95..82905337908d 100644
> --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c
> +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c
> @@ -64,7 +64,7 @@ EfiDhcp4GetModeData (
> not NULL. Otherwise, the state was left unchanged.
> @retval EFI_ACCESS_DENIED This instance of the EFI DHCPv4 Protocol driver was not in the
> Dhcp4Stopped, Dhcp4Init, Dhcp4InitReboot, or Dhcp4Bound state;
> - Or onother instance of this EFI DHCPv4 Protocol driver is already
> + Or another instance of this EFI DHCPv4 Protocol driver is already
> in a valid configured state.
> @retval EFI_INVALID_PARAMETER Some parameter is NULL.
> @retval EFI_OUT_OF_RESOURCES Required system resources could not be allocated.
> @@ -611,7 +611,7 @@ DhcpYieldControl (
> not NULL. Otherwise, the state was left unchanged.
> @retval EFI_ACCESS_DENIED This instance of the EFI DHCPv4 Protocol driver was not in the
> Dhcp4Stopped, Dhcp4Init, Dhcp4InitReboot, or Dhcp4Bound state;
> - Or onother instance of this EFI DHCPv4 Protocol driver is already
> + Or another instance of this EFI DHCPv4 Protocol driver is already
> in a valid configured state.
> @retval EFI_INVALID_PARAMETER Some parameter is NULL.
> @retval EFI_OUT_OF_RESOURCES Required system resources could not be allocated.
> @@ -805,7 +805,7 @@ EfiDhcp4Start (
> }
>
> //
> - // Check Media Satus.
> + // Check Media Status.
> //
> MediaStatus = EFI_SUCCESS;
> NetLibDetectMediaWaitTimeout (DhcpSb->Controller, DHCP_CHECK_MEDIA_WAITING_TIME, &MediaStatus);
> diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Io.c b/NetworkPkg/Dhcp4Dxe/Dhcp4Io.c
> index 4728b94c5803..34c72d690a31 100644
> --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Io.c
> +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Io.c
> @@ -604,7 +604,7 @@ DhcpEndSession (
> is, all the option value that we care.
>
> @retval EFI_SUCCESS The packet is successfully processed.
> - @retval Others Some error occured.
> + @retval Others Some error occurred.
>
> **/
> EFI_STATUS
> @@ -632,7 +632,7 @@ DhcpHandleSelect (
>
> //
> // Call the user's callback. The action according to the return is as:
> - // 1. EFI_SUCESS: stop waiting for more offers, select the offer now
> + // 1. EFI_SUCCESS: stop waiting for more offers, select the offer now
> // 2. EFI_NOT_READY: wait for more offers
> // 3. EFI_ABORTED: abort the address acquiring.
> //
> @@ -679,7 +679,7 @@ ON_EXIT:
> is, all the option value that we care.
>
> @retval EFI_SUCCESS The packet is successfully processed.
> - @retval Others Some error occured.
> + @retval Others Some error occurred.
>
> **/
> EFI_STATUS
> @@ -772,7 +772,7 @@ ON_EXIT:
> is, all the option value that we care.
>
> @retval EFI_SUCCESS The packet is successfully processed.
> - @retval Others Some error occured.
> + @retval Others Some error occurred.
>
> **/
> EFI_STATUS
> @@ -856,7 +856,7 @@ ON_EXIT:
> is, all the option value that we care.
>
> @retval EFI_SUCCESS The packet is successfully processed.
> - @retval Others Some error occured.
> + @retval Others Some error occurred.
>
> **/
> EFI_STATUS
> @@ -1473,7 +1473,7 @@ DhcpRetransmit (
> /**
> Each DHCP service has three timer. Two of them are count down timer.
> One for the packet retransmission. The other is to collect the offers.
> - The third timer increaments the lease life which is compared to T1, T2,
> + The third timer increments the lease life which is compared to T1, T2,
> and lease to determine the time to renew and rebind the lease.
> DhcpOnTimerTick will be called once every second.
>
> diff --git a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c
> index 3b077de11177..37a63022c55f 100644
> --- a/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c
> +++ b/NetworkPkg/Dhcp4Dxe/Dhcp4Option.c
> @@ -195,7 +195,7 @@ DhcpOptionIsValid (
> }
>
> //
> - // Validate the occurance of the option unit is with in [MinOccur, MaxOccur]
> + // Validate the occurrence of the option unit is with in [MinOccur, MaxOccur]
> //
> Occur = Len / Unit;
>
> @@ -230,7 +230,7 @@ DhcpOptionIsValid (
> @param[out] Para The variable to save the interested parameter
>
> @retval EFI_SUCCESS The DHCP option is successfully extracted.
> - @retval EFI_INVALID_PARAMETER The DHCP option is malformatted
> + @retval EFI_INVALID_PARAMETER The DHCP option is mal-formatted
>
> **/
> EFI_STATUS
> @@ -303,7 +303,7 @@ DhcpGetParameter (
> option.
>
> @retval EFI_SUCCESS All the options are valid
> - @retval EFI_INVALID_PARAMETER The options are malformatted.
> + @retval EFI_INVALID_PARAMETER The options are mal-formatted.
>
> **/
> EFI_STATUS
> @@ -376,8 +376,8 @@ DhcpIterateBufferOptions (
> found
> @param[in] Context The opaque parameter for Check
>
> - @retval EFI_SUCCESS The DHCP packet's options are well formated
> - @retval EFI_INVALID_PARAMETER The DHCP packet's options are not well formated
> + @retval EFI_SUCCESS The DHCP packet's options are well formatted
> + @retval EFI_INVALID_PARAMETER The DHCP packet's options are not well formatted
>
> **/
> EFI_STATUS
> @@ -438,7 +438,7 @@ DhcpIterateOptions (
>
> /**
> Call back function to DhcpIterateOptions to compute each option's
> - length. It just adds the data length of all the occurances of this
> + length. It just adds the data length of all the occurrences of this
> Tag. Context is an array of 256 DHCP_OPTION_COUNT.
>
> @param[in] Tag The current option to check
> @@ -473,7 +473,7 @@ DhcpGetOptionLen (
>
> @param[in] Tag The option to consolidate its data
> @param[in] Len The length of option data
> - @param[in] Data The data of the option's current occurance
> + @param[in] Data The data of the option's current occurrence
> @param[in] Context The context, which is DHCP_OPTION_CONTEXT. This
> array is just a wrap to pass THREE parameters.
>
> @@ -517,8 +517,8 @@ DhcpFillOption (
> /**
> Parse the options of a DHCP packet. It supports RFC 3396: Encoding
> Long Options in DHCP. That is, it will combine all the option value
> - of all the occurances of each option.
> - A little bit of implemenation:
> + of all the occurrences of each option.
> + A little bit of implementation:
> It adopts the "Key indexed counting" algorithm. First, it allocates
> an array of 256 DHCP_OPTION_COUNTs because DHCP option tag is encoded
> as a UINT8. It then iterates the DHCP packet to get data length of
> @@ -538,7 +538,7 @@ DhcpFillOption (
>
> @retval EFI_NOT_FOUND Cannot find any option.
> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to parse the packet.
> - @retval EFI_INVALID_PARAMETER The options are malformatted
> + @retval EFI_INVALID_PARAMETER The options are mal-formatted
> @retval EFI_SUCCESS The options are parsed into OptionPoint
>
> **/
> @@ -639,7 +639,7 @@ ON_EXIT:
> @param[out] Para The variable to save the DHCP parameters.
>
> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory to validate the packet.
> - @retval EFI_INVALID_PARAMETER The options are malformatted
> + @retval EFI_INVALID_PARAMETER The options are mal-formatted
> @retval EFI_SUCCESS The options are parsed into OptionPoint
>
> **/
> @@ -770,7 +770,7 @@ DhcpAppendOption (
> function.
>
> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory
> - @retval EFI_INVALID_PARAMETER The options in SeekPacket are malformatted
> + @retval EFI_INVALID_PARAMETER The options in SeekPacket are mal-formatted
> @retval EFI_SUCCESS The packet is build.
>
> **/
> @@ -794,7 +794,7 @@ DhcpBuild (
> UINT8 *Buf;
>
> //
> - // Use an array of DHCP_OPTION to mark the existance
> + // Use an array of DHCP_OPTION to mark the existence
> // and position of each valid options.
> //
> Mark = AllocatePool (sizeof (DHCP_OPTION) * DHCP_MAX_OPTIONS);
^ permalink raw reply [flat|nested] 122+ messages in thread
* [PATCH 34/79] NetworkPkg/Dhcp6Dxe: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (32 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 33/79] NetworkPkg/Dhcp4Dxe: " Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-04 13:28 ` [edk2-devel] " Maciej Rabeda
2019-12-03 16:15 ` [PATCH 35/79] NetworkPkg/DnsDxe: Fix a typo Philippe Mathieu-Daudé
` (38 subsequent siblings)
72 siblings, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel
Cc: Antoine Coeur, Jiaxin Wu, Siyuan Fu, Maciej Rabeda,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h | 4 +--
NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h | 12 ++++-----
NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c | 12 ++++-----
NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c | 12 ++++-----
NetworkPkg/Dhcp6Dxe/Dhcp6Io.c | 26 ++++++++++----------
NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c | 16 ++++++------
6 files changed, 41 insertions(+), 41 deletions(-)
diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h b/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h
index a609eddf2474..1b8744b9b8d2 100644
--- a/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h
+++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h
@@ -108,7 +108,7 @@ Dhcp6DriverBindingStop (
then a new handle is created. If it is a pointer to an existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child.
@@ -132,7 +132,7 @@ Dhcp6ServiceBindingCreateChild (
@param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param ChildHandle Handle of the child to destroy.
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h b/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h
index 6a302adf2944..2f18eb360957 100644
--- a/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h
+++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h
@@ -71,7 +71,7 @@ Dhcp6CleanupModeData (
@param[in] Base The base value of the time.
@param[in] IsFirstRt If TRUE, it is the first time to calculate expire time.
- @param[in] NeedSigned If TRUE, the the signed factor is needed.
+ @param[in] NeedSigned If TRUE, the signed factor is needed.
@return Expire The calculated result for the new expire time.
@@ -165,7 +165,7 @@ Dhcp6OnTransmitted (
@param[in, out] Buf The pointer to buffer.
@param[in] OptType The option type.
- @param[in] OptLen The lenght of option content.s
+ @param[in] OptLen The length of option content.s
@param[in] Data The pointer to the option content.
@return Buf The position to append the next option.
@@ -270,7 +270,7 @@ Dhcp6SeekIaOption (
/**
Parse the address option and update the address info.
- @param[in] CurrentIa The pointer to the Ia Address in control blcok.
+ @param[in] CurrentIa The pointer to the Ia Address in control block.
@param[in] IaInnerOpt The pointer to the buffer.
@param[in] IaInnerLen The length to parse.
@param[out] AddrNum The number of addresses.
@@ -287,7 +287,7 @@ Dhcp6ParseAddrOption (
);
/**
- Create a control blcok for the Ia according to the corresponding options.
+ Create a control block for the Ia according to the corresponding options.
@param[in] Instance The pointer to DHCP6 Instance.
@param[in] IaInnerOpt The pointer to the inner options in the Ia option.
@@ -327,7 +327,7 @@ Dhcp6CacheIa (
/**
- Append CacheIa to the currrent IA. Meanwhile, clear CacheIa.ValidLifetime to 0.
+ Append CacheIa to the current IA. Meanwhile, clear CacheIa.ValidLifetime to 0.
@param[in] Instance The pointer to DHCP6 instance.
@@ -338,7 +338,7 @@ Dhcp6AppendCacheIa (
);
/**
- Calculate the Dhcp6 get mapping timeout by adding additinal delay to the IP6 DAD transmits count.
+ Calculate the Dhcp6 get mapping timeout by adding additional delay to the IP6 DAD transmits count.
@param[in] Ip6Cfg The pointer to Ip6 config protocol.
@param[out] TimeOut The time out value in 100ns units.
diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c b/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c
index 2ffdba73a563..f0b236835f86 100644
--- a/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c
+++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c
@@ -1,6 +1,6 @@
/** @file
Driver Binding functions and Service Binding functions
- implementationfor for Dhcp6 Driver.
+ implementation for Dhcp6 Driver.
Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
@@ -300,7 +300,7 @@ Dhcp6CreateInstance (
//
// There is a timer for each Dhcp6 instance, which is used to track the
- // lease time of Ia and the retransmisson time of all sent packets.
+ // lease time of Ia and the retransmission time of all sent packets.
//
Status = gBS->CreateEvent (
EVT_NOTIFY_SIGNAL | EVT_TIMER,
@@ -445,7 +445,7 @@ Dhcp6DriverBindingStart (
DHCP6_SERVICE *Service;
//
- // Check the Dhcp6 serivce whether already started.
+ // Check the Dhcp6 service whether already started.
//
Status = gBS->OpenProtocol (
ControllerHandle,
@@ -551,7 +551,7 @@ Dhcp6DriverBindingStop (
Service = DHCP6_SERVICE_FROM_THIS (ServiceBinding);
if (!IsListEmpty (&Service->Child)) {
//
- // Destroy all the children instances before destory the service.
+ // Destroy all the children instances before destroy the service.
//
List = &Service->Child;
Status = NetDestroyLinkList (
@@ -603,7 +603,7 @@ ON_EXIT:
then a new handle is created. If it is a pointer to an existing
UEFI handle, then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval other The child handle was not created.
@@ -715,7 +715,7 @@ ON_ERROR:
@param[in] This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param[in] ChildHandle Handle of the child to destroy
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c b/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c
index 44c340ed0c6a..bb4c1d12a987 100644
--- a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c
+++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c
@@ -96,7 +96,7 @@ EfiDhcp6Start (
OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
//
- // Check Media Satus.
+ // Check Media Status.
//
MediaStatus = EFI_SUCCESS;
NetLibDetectMediaWaitTimeout (Service->Controller, DHCP_CHECK_MEDIA_WAITING_TIME, &MediaStatus);
@@ -220,7 +220,7 @@ EfiDhcp6Stop (
}
//
- // Poll udp out of the net tpl if synchoronus call.
+ // Poll udp out of the net tpl if synchronous call.
//
if (Instance->Config->IaInfoEvent == NULL) {
ASSERT (Udp6 != NULL);
@@ -694,7 +694,7 @@ EfiDhcp6InfoRequest (
}
//
- // Poll udp out of the net tpl if synchoronus call.
+ // Poll udp out of the net tpl if synchronous call.
//
if (TimeoutEvent == NULL) {
@@ -823,7 +823,7 @@ EfiDhcp6RenewRebind (
gBS->RestoreTPL (OldTpl);
//
- // Poll udp out of the net tpl if synchoronus call.
+ // Poll udp out of the net tpl if synchronous call.
//
if (Instance->Config->IaInfoEvent == NULL) {
@@ -958,7 +958,7 @@ EfiDhcp6Decline (
gBS->RestoreTPL (OldTpl);
//
- // Poll udp out of the net tpl if synchoronus call.
+ // Poll udp out of the net tpl if synchronous call.
//
if (Instance->Config->IaInfoEvent == NULL) {
@@ -1099,7 +1099,7 @@ EfiDhcp6Release (
gBS->RestoreTPL (OldTpl);
//
- // Poll udp out of the net tpl if synchoronus call.
+ // Poll udp out of the net tpl if synchronous call.
//
if (Instance->Config->IaInfoEvent == NULL) {
while (Instance->UdpSts == EFI_ALREADY_STARTED) {
diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Io.c b/NetworkPkg/Dhcp6Dxe/Dhcp6Io.c
index 4f8393cb36ce..7ce618058ae7 100644
--- a/NetworkPkg/Dhcp6Dxe/Dhcp6Io.c
+++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Io.c
@@ -58,7 +58,7 @@ Dhcp6EnqueueRetry (
TxCb->Elapsed = Elapsed;
//
- // Calculate the retransmission according to the the message type.
+ // Calculate the retransmission according to the message type.
//
switch (Packet->Dhcp6.Header.MessageType) {
case Dhcp6MsgSolicit:
@@ -548,13 +548,13 @@ Dhcp6UpdateIaInfo (
ASSERT (Instance->Config != NULL);
//
- // If the reply was received in reponse to a solicit with rapid commit option,
+ // If the reply was received in response to a solicit with rapid commit option,
// request, renew or rebind message, the client updates the information it has
// recorded about IAs from the IA options contained in the reply message:
// 1. record the T1 and T2 times
// 2. add any new addresses in the IA
// 3. discard any addresses from the IA, that have a valid lifetime of 0
- // 4. update lifetimes for any addresses that alread recorded
+ // 4. update lifetimes for any addresses that already recorded
// 5. leave unchanged any information about addresses
//
// See details in the section-18.1.8 of rfc-3315.
@@ -941,7 +941,7 @@ Dhcp6SendSolicitMsg (
}
//
- // Create the Dhcp6 packet and initialize commone fields.
+ // Create the Dhcp6 packet and initialize common fields.
//
Packet = AllocateZeroPool (DHCP6_BASE_PACKET_SIZE + UserLen);
if (Packet == NULL) {
@@ -1123,7 +1123,7 @@ Dhcp6SendRequestMsg (
}
//
- // Create the Dhcp6 packet and initialize commone fields.
+ // Create the Dhcp6 packet and initialize common fields.
//
Packet = AllocateZeroPool (DHCP6_BASE_PACKET_SIZE + UserLen);
if (Packet == NULL) {
@@ -1281,7 +1281,7 @@ Dhcp6SendDeclineMsg (
ServerId = (EFI_DHCP6_DUID *) (Option + 2);
//
- // Create the Dhcp6 packet and initialize commone fields.
+ // Create the Dhcp6 packet and initialize common fields.
//
Packet = AllocateZeroPool (DHCP6_BASE_PACKET_SIZE);
if (Packet == NULL) {
@@ -1415,7 +1415,7 @@ Dhcp6SendReleaseMsg (
ServerId = (EFI_DHCP6_DUID *) (Option + 2);
//
- // Create the Dhcp6 packet and initialize commone fields.
+ // Create the Dhcp6 packet and initialize common fields.
//
Packet = AllocateZeroPool (DHCP6_BASE_PACKET_SIZE);
if (Packet == NULL) {
@@ -1546,7 +1546,7 @@ Dhcp6SendRenewRebindMsg (
}
//
- // Create the Dhcp6 packet and initialize commone fields.
+ // Create the Dhcp6 packet and initialize common fields.
//
Packet = AllocateZeroPool (DHCP6_BASE_PACKET_SIZE + UserLen);
if (Packet == NULL) {
@@ -1829,7 +1829,7 @@ Dhcp6SendInfoRequestMsg (
}
//
- // Create the Dhcp6 packet and initialize commone fields.
+ // Create the Dhcp6 packet and initialize common fields.
//
Packet = AllocateZeroPool (DHCP6_BASE_PACKET_SIZE + UserLen);
if (Packet == NULL) {
@@ -2149,7 +2149,7 @@ Dhcp6HandleReplyMsg (
Instance->UdpSts = EFI_SUCCESS;
//
- // For async, signal the Ia event to inform Ia infomation update.
+ // For async, signal the Ia event to inform Ia information update.
//
if (Instance->Config->IaInfoEvent != NULL) {
gBS->SignalEvent (Instance->Config->IaInfoEvent);
@@ -2212,14 +2212,14 @@ Dhcp6HandleReplyMsg (
//
// Maybe this is a new round DHCP process due to some reason, such as NotOnLink
- // ReplyMsg for ConfirmMsg should triger new round to acquire new address. In that
+ // ReplyMsg for ConfirmMsg should trigger new round to acquire new address. In that
// case, clear old address.ValidLifetime and append to new address. Therefore, DHCP
// consumers can be notified to flush old address.
//
Dhcp6AppendCacheIa (Instance);
//
- // For async, signal the Ia event to inform Ia infomation update.
+ // For async, signal the Ia event to inform Ia information update.
//
if (Instance->Config->IaInfoEvent != NULL) {
gBS->SignalEvent (Instance->Config->IaInfoEvent);
@@ -2430,7 +2430,7 @@ Dhcp6HandleAdvertiseMsg (
//
// If the client does receives a valid reply message that includes a rapid
- // commit option since a solicit with rapid commit optioin sent before, select
+ // commit option since a solicit with rapid commit option sent before, select
// this reply message. Or else, process the advertise messages as normal.
// See details in the section-17.1.4 of rfc-3315.
//
diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c b/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c
index a8a938211572..d249a1cca7a1 100644
--- a/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c
+++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c
@@ -312,7 +312,7 @@ Dhcp6CleanupModeData (
@param[in] Base The base value of the time.
@param[in] IsFirstRt If TRUE, it is the first time to calculate expire time.
- @param[in] NeedSigned If TRUE, the the signed factor is needed.
+ @param[in] NeedSigned If TRUE, the signed factor is needed.
@return Expire The calculated result for the new expire time.
@@ -506,7 +506,7 @@ Dhcp6DepriveAddress (
//
// If release all Ia addresses, just copy the configured Ia and then set
// its address count as zero.
- // We may decline/release part of addresses at the begining. So it's a
+ // We may decline/release part of addresses at the beginning. So it's a
// forwarding step to update address infor for decline/release, while the
// other infor such as Ia state will be updated when receiving reply.
//
@@ -995,7 +995,7 @@ Dhcp6SeekIaOption (
/**
Check whether the incoming IPv6 address in IaAddr is one of the maintained
- addresses in the IA control blcok.
+ addresses in the IA control block.
@param[in] IaAddr The pointer to the IA Address to be checked.
@param[in] CurrentIa The pointer to the IA in IA control block.
@@ -1023,9 +1023,9 @@ Dhcp6AddrIsInCurrentIa (
}
/**
- Parse the address option and update the address infomation.
+ Parse the address option and update the address information.
- @param[in] CurrentIa The pointer to the Ia Address in control blcok.
+ @param[in] CurrentIa The pointer to the Ia Address in control block.
@param[in] IaInnerOpt The pointer to the buffer.
@param[in] IaInnerLen The length to parse.
@param[out] AddrNum The number of addresses.
@@ -1107,7 +1107,7 @@ Dhcp6ParseAddrOption (
/**
- Create a control blcok for the Ia according to the corresponding options.
+ Create a control block for the Ia according to the corresponding options.
@param[in] Instance The pointer to DHCP6 Instance.
@param[in] IaInnerOpt The pointer to the inner options in the Ia option.
@@ -1229,7 +1229,7 @@ Dhcp6CacheIa (
}
/**
- Append CacheIa to the currrent IA. Meanwhile, clear CacheIa.ValidLifetime to 0.
+ Append CacheIa to the current IA. Meanwhile, clear CacheIa.ValidLifetime to 0.
@param[in] Instance The pointer to DHCP6 instance.
@@ -1285,7 +1285,7 @@ Dhcp6AppendCacheIa (
}
/**
- Calculate the Dhcp6 get mapping timeout by adding additinal delay to the IP6 DAD transmits count.
+ Calculate the Dhcp6 get mapping timeout by adding additional delay to the IP6 DAD transmits count.
@param[in] Ip6Cfg The pointer to Ip6 config protocol.
@param[out] TimeOut The time out value in 100ns units.
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [edk2-devel] [PATCH 34/79] NetworkPkg/Dhcp6Dxe: Fix various typos
2019-12-03 16:15 ` [PATCH 34/79] NetworkPkg/Dhcp6Dxe: " Philippe Mathieu-Daudé
@ 2019-12-04 13:28 ` Maciej Rabeda
0 siblings, 0 replies; 122+ messages in thread
From: Maciej Rabeda @ 2019-12-04 13:28 UTC (permalink / raw)
To: devel, philmd; +Cc: Antoine Coeur, Jiaxin Wu, Siyuan Fu, Maciej Rabeda
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
On 03-Dec-19 17:15, Philippe Mathieu-Daudé wrote:
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h | 4 +--
> NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h | 12 ++++-----
> NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c | 12 ++++-----
> NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c | 12 ++++-----
> NetworkPkg/Dhcp6Dxe/Dhcp6Io.c | 26 ++++++++++----------
> NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c | 16 ++++++------
> 6 files changed, 41 insertions(+), 41 deletions(-)
>
> diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h b/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h
> index a609eddf2474..1b8744b9b8d2 100644
> --- a/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h
> +++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h
> @@ -108,7 +108,7 @@ Dhcp6DriverBindingStop (
> then a new handle is created. If it is a pointer to an existing UEFI handle,
> then the protocol is added to the existing UEFI handle.
>
> - @retval EFI_SUCCES The protocol was added to ChildHandle.
> + @retval EFI_SUCCESS The protocol was added to ChildHandle.
> @retval EFI_INVALID_PARAMETER ChildHandle is NULL.
> @retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
> the child.
> @@ -132,7 +132,7 @@ Dhcp6ServiceBindingCreateChild (
> @param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
> @param ChildHandle Handle of the child to destroy.
>
> - @retval EFI_SUCCES The protocol was removed from ChildHandle.
> + @retval EFI_SUCCESS The protocol was removed from ChildHandle.
> @retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
> @retval EFI_INVALID_PARAMETER Child handle is NULL.
> @retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
> diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h b/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h
> index 6a302adf2944..2f18eb360957 100644
> --- a/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h
> +++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h
> @@ -71,7 +71,7 @@ Dhcp6CleanupModeData (
>
> @param[in] Base The base value of the time.
> @param[in] IsFirstRt If TRUE, it is the first time to calculate expire time.
> - @param[in] NeedSigned If TRUE, the the signed factor is needed.
> + @param[in] NeedSigned If TRUE, the signed factor is needed.
>
> @return Expire The calculated result for the new expire time.
>
> @@ -165,7 +165,7 @@ Dhcp6OnTransmitted (
>
> @param[in, out] Buf The pointer to buffer.
> @param[in] OptType The option type.
> - @param[in] OptLen The lenght of option content.s
> + @param[in] OptLen The length of option content.s
> @param[in] Data The pointer to the option content.
>
> @return Buf The position to append the next option.
> @@ -270,7 +270,7 @@ Dhcp6SeekIaOption (
> /**
> Parse the address option and update the address info.
>
> - @param[in] CurrentIa The pointer to the Ia Address in control blcok.
> + @param[in] CurrentIa The pointer to the Ia Address in control block.
> @param[in] IaInnerOpt The pointer to the buffer.
> @param[in] IaInnerLen The length to parse.
> @param[out] AddrNum The number of addresses.
> @@ -287,7 +287,7 @@ Dhcp6ParseAddrOption (
> );
>
> /**
> - Create a control blcok for the Ia according to the corresponding options.
> + Create a control block for the Ia according to the corresponding options.
>
> @param[in] Instance The pointer to DHCP6 Instance.
> @param[in] IaInnerOpt The pointer to the inner options in the Ia option.
> @@ -327,7 +327,7 @@ Dhcp6CacheIa (
>
>
> /**
> - Append CacheIa to the currrent IA. Meanwhile, clear CacheIa.ValidLifetime to 0.
> + Append CacheIa to the current IA. Meanwhile, clear CacheIa.ValidLifetime to 0.
>
> @param[in] Instance The pointer to DHCP6 instance.
>
> @@ -338,7 +338,7 @@ Dhcp6AppendCacheIa (
> );
>
> /**
> - Calculate the Dhcp6 get mapping timeout by adding additinal delay to the IP6 DAD transmits count.
> + Calculate the Dhcp6 get mapping timeout by adding additional delay to the IP6 DAD transmits count.
>
> @param[in] Ip6Cfg The pointer to Ip6 config protocol.
> @param[out] TimeOut The time out value in 100ns units.
> diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c b/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c
> index 2ffdba73a563..f0b236835f86 100644
> --- a/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c
> +++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c
> @@ -1,6 +1,6 @@
> /** @file
> Driver Binding functions and Service Binding functions
> - implementationfor for Dhcp6 Driver.
> + implementation for Dhcp6 Driver.
>
> Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
>
> @@ -300,7 +300,7 @@ Dhcp6CreateInstance (
>
> //
> // There is a timer for each Dhcp6 instance, which is used to track the
> - // lease time of Ia and the retransmisson time of all sent packets.
> + // lease time of Ia and the retransmission time of all sent packets.
> //
> Status = gBS->CreateEvent (
> EVT_NOTIFY_SIGNAL | EVT_TIMER,
> @@ -445,7 +445,7 @@ Dhcp6DriverBindingStart (
> DHCP6_SERVICE *Service;
>
> //
> - // Check the Dhcp6 serivce whether already started.
> + // Check the Dhcp6 service whether already started.
> //
> Status = gBS->OpenProtocol (
> ControllerHandle,
> @@ -551,7 +551,7 @@ Dhcp6DriverBindingStop (
> Service = DHCP6_SERVICE_FROM_THIS (ServiceBinding);
> if (!IsListEmpty (&Service->Child)) {
> //
> - // Destroy all the children instances before destory the service.
> + // Destroy all the children instances before destroy the service.
> //
> List = &Service->Child;
> Status = NetDestroyLinkList (
> @@ -603,7 +603,7 @@ ON_EXIT:
> then a new handle is created. If it is a pointer to an existing
> UEFI handle, then the protocol is added to the existing UEFI handle.
>
> - @retval EFI_SUCCES The protocol was added to ChildHandle.
> + @retval EFI_SUCCESS The protocol was added to ChildHandle.
> @retval EFI_INVALID_PARAMETER ChildHandle is NULL.
> @retval other The child handle was not created.
>
> @@ -715,7 +715,7 @@ ON_ERROR:
> @param[in] This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
> @param[in] ChildHandle Handle of the child to destroy
>
> - @retval EFI_SUCCES The protocol was removed from ChildHandle.
> + @retval EFI_SUCCESS The protocol was removed from ChildHandle.
> @retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
> @retval EFI_INVALID_PARAMETER Child handle is NULL.
> @retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
> diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c b/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c
> index 44c340ed0c6a..bb4c1d12a987 100644
> --- a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c
> +++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c
> @@ -96,7 +96,7 @@ EfiDhcp6Start (
> OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
>
> //
> - // Check Media Satus.
> + // Check Media Status.
> //
> MediaStatus = EFI_SUCCESS;
> NetLibDetectMediaWaitTimeout (Service->Controller, DHCP_CHECK_MEDIA_WAITING_TIME, &MediaStatus);
> @@ -220,7 +220,7 @@ EfiDhcp6Stop (
> }
>
> //
> - // Poll udp out of the net tpl if synchoronus call.
> + // Poll udp out of the net tpl if synchronous call.
> //
> if (Instance->Config->IaInfoEvent == NULL) {
> ASSERT (Udp6 != NULL);
> @@ -694,7 +694,7 @@ EfiDhcp6InfoRequest (
> }
>
> //
> - // Poll udp out of the net tpl if synchoronus call.
> + // Poll udp out of the net tpl if synchronous call.
> //
> if (TimeoutEvent == NULL) {
>
> @@ -823,7 +823,7 @@ EfiDhcp6RenewRebind (
> gBS->RestoreTPL (OldTpl);
>
> //
> - // Poll udp out of the net tpl if synchoronus call.
> + // Poll udp out of the net tpl if synchronous call.
> //
> if (Instance->Config->IaInfoEvent == NULL) {
>
> @@ -958,7 +958,7 @@ EfiDhcp6Decline (
> gBS->RestoreTPL (OldTpl);
>
> //
> - // Poll udp out of the net tpl if synchoronus call.
> + // Poll udp out of the net tpl if synchronous call.
> //
> if (Instance->Config->IaInfoEvent == NULL) {
>
> @@ -1099,7 +1099,7 @@ EfiDhcp6Release (
> gBS->RestoreTPL (OldTpl);
>
> //
> - // Poll udp out of the net tpl if synchoronus call.
> + // Poll udp out of the net tpl if synchronous call.
> //
> if (Instance->Config->IaInfoEvent == NULL) {
> while (Instance->UdpSts == EFI_ALREADY_STARTED) {
> diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Io.c b/NetworkPkg/Dhcp6Dxe/Dhcp6Io.c
> index 4f8393cb36ce..7ce618058ae7 100644
> --- a/NetworkPkg/Dhcp6Dxe/Dhcp6Io.c
> +++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Io.c
> @@ -58,7 +58,7 @@ Dhcp6EnqueueRetry (
> TxCb->Elapsed = Elapsed;
>
> //
> - // Calculate the retransmission according to the the message type.
> + // Calculate the retransmission according to the message type.
> //
> switch (Packet->Dhcp6.Header.MessageType) {
> case Dhcp6MsgSolicit:
> @@ -548,13 +548,13 @@ Dhcp6UpdateIaInfo (
>
> ASSERT (Instance->Config != NULL);
> //
> - // If the reply was received in reponse to a solicit with rapid commit option,
> + // If the reply was received in response to a solicit with rapid commit option,
> // request, renew or rebind message, the client updates the information it has
> // recorded about IAs from the IA options contained in the reply message:
> // 1. record the T1 and T2 times
> // 2. add any new addresses in the IA
> // 3. discard any addresses from the IA, that have a valid lifetime of 0
> - // 4. update lifetimes for any addresses that alread recorded
> + // 4. update lifetimes for any addresses that already recorded
> // 5. leave unchanged any information about addresses
> //
> // See details in the section-18.1.8 of rfc-3315.
> @@ -941,7 +941,7 @@ Dhcp6SendSolicitMsg (
> }
>
> //
> - // Create the Dhcp6 packet and initialize commone fields.
> + // Create the Dhcp6 packet and initialize common fields.
> //
> Packet = AllocateZeroPool (DHCP6_BASE_PACKET_SIZE + UserLen);
> if (Packet == NULL) {
> @@ -1123,7 +1123,7 @@ Dhcp6SendRequestMsg (
> }
>
> //
> - // Create the Dhcp6 packet and initialize commone fields.
> + // Create the Dhcp6 packet and initialize common fields.
> //
> Packet = AllocateZeroPool (DHCP6_BASE_PACKET_SIZE + UserLen);
> if (Packet == NULL) {
> @@ -1281,7 +1281,7 @@ Dhcp6SendDeclineMsg (
> ServerId = (EFI_DHCP6_DUID *) (Option + 2);
>
> //
> - // Create the Dhcp6 packet and initialize commone fields.
> + // Create the Dhcp6 packet and initialize common fields.
> //
> Packet = AllocateZeroPool (DHCP6_BASE_PACKET_SIZE);
> if (Packet == NULL) {
> @@ -1415,7 +1415,7 @@ Dhcp6SendReleaseMsg (
> ServerId = (EFI_DHCP6_DUID *) (Option + 2);
>
> //
> - // Create the Dhcp6 packet and initialize commone fields.
> + // Create the Dhcp6 packet and initialize common fields.
> //
> Packet = AllocateZeroPool (DHCP6_BASE_PACKET_SIZE);
> if (Packet == NULL) {
> @@ -1546,7 +1546,7 @@ Dhcp6SendRenewRebindMsg (
> }
>
> //
> - // Create the Dhcp6 packet and initialize commone fields.
> + // Create the Dhcp6 packet and initialize common fields.
> //
> Packet = AllocateZeroPool (DHCP6_BASE_PACKET_SIZE + UserLen);
> if (Packet == NULL) {
> @@ -1829,7 +1829,7 @@ Dhcp6SendInfoRequestMsg (
> }
>
> //
> - // Create the Dhcp6 packet and initialize commone fields.
> + // Create the Dhcp6 packet and initialize common fields.
> //
> Packet = AllocateZeroPool (DHCP6_BASE_PACKET_SIZE + UserLen);
> if (Packet == NULL) {
> @@ -2149,7 +2149,7 @@ Dhcp6HandleReplyMsg (
> Instance->UdpSts = EFI_SUCCESS;
>
> //
> - // For async, signal the Ia event to inform Ia infomation update.
> + // For async, signal the Ia event to inform Ia information update.
> //
> if (Instance->Config->IaInfoEvent != NULL) {
> gBS->SignalEvent (Instance->Config->IaInfoEvent);
> @@ -2212,14 +2212,14 @@ Dhcp6HandleReplyMsg (
>
> //
> // Maybe this is a new round DHCP process due to some reason, such as NotOnLink
> - // ReplyMsg for ConfirmMsg should triger new round to acquire new address. In that
> + // ReplyMsg for ConfirmMsg should trigger new round to acquire new address. In that
> // case, clear old address.ValidLifetime and append to new address. Therefore, DHCP
> // consumers can be notified to flush old address.
> //
> Dhcp6AppendCacheIa (Instance);
>
> //
> - // For async, signal the Ia event to inform Ia infomation update.
> + // For async, signal the Ia event to inform Ia information update.
> //
> if (Instance->Config->IaInfoEvent != NULL) {
> gBS->SignalEvent (Instance->Config->IaInfoEvent);
> @@ -2430,7 +2430,7 @@ Dhcp6HandleAdvertiseMsg (
>
> //
> // If the client does receives a valid reply message that includes a rapid
> - // commit option since a solicit with rapid commit optioin sent before, select
> + // commit option since a solicit with rapid commit option sent before, select
> // this reply message. Or else, process the advertise messages as normal.
> // See details in the section-17.1.4 of rfc-3315.
> //
> diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c b/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c
> index a8a938211572..d249a1cca7a1 100644
> --- a/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c
> +++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c
> @@ -312,7 +312,7 @@ Dhcp6CleanupModeData (
>
> @param[in] Base The base value of the time.
> @param[in] IsFirstRt If TRUE, it is the first time to calculate expire time.
> - @param[in] NeedSigned If TRUE, the the signed factor is needed.
> + @param[in] NeedSigned If TRUE, the signed factor is needed.
>
> @return Expire The calculated result for the new expire time.
>
> @@ -506,7 +506,7 @@ Dhcp6DepriveAddress (
> //
> // If release all Ia addresses, just copy the configured Ia and then set
> // its address count as zero.
> - // We may decline/release part of addresses at the begining. So it's a
> + // We may decline/release part of addresses at the beginning. So it's a
> // forwarding step to update address infor for decline/release, while the
> // other infor such as Ia state will be updated when receiving reply.
> //
> @@ -995,7 +995,7 @@ Dhcp6SeekIaOption (
>
> /**
> Check whether the incoming IPv6 address in IaAddr is one of the maintained
> - addresses in the IA control blcok.
> + addresses in the IA control block.
>
> @param[in] IaAddr The pointer to the IA Address to be checked.
> @param[in] CurrentIa The pointer to the IA in IA control block.
> @@ -1023,9 +1023,9 @@ Dhcp6AddrIsInCurrentIa (
> }
>
> /**
> - Parse the address option and update the address infomation.
> + Parse the address option and update the address information.
>
> - @param[in] CurrentIa The pointer to the Ia Address in control blcok.
> + @param[in] CurrentIa The pointer to the Ia Address in control block.
> @param[in] IaInnerOpt The pointer to the buffer.
> @param[in] IaInnerLen The length to parse.
> @param[out] AddrNum The number of addresses.
> @@ -1107,7 +1107,7 @@ Dhcp6ParseAddrOption (
>
>
> /**
> - Create a control blcok for the Ia according to the corresponding options.
> + Create a control block for the Ia according to the corresponding options.
>
> @param[in] Instance The pointer to DHCP6 Instance.
> @param[in] IaInnerOpt The pointer to the inner options in the Ia option.
> @@ -1229,7 +1229,7 @@ Dhcp6CacheIa (
> }
>
> /**
> - Append CacheIa to the currrent IA. Meanwhile, clear CacheIa.ValidLifetime to 0.
> + Append CacheIa to the current IA. Meanwhile, clear CacheIa.ValidLifetime to 0.
>
> @param[in] Instance The pointer to DHCP6 instance.
>
> @@ -1285,7 +1285,7 @@ Dhcp6AppendCacheIa (
> }
>
> /**
> - Calculate the Dhcp6 get mapping timeout by adding additinal delay to the IP6 DAD transmits count.
> + Calculate the Dhcp6 get mapping timeout by adding additional delay to the IP6 DAD transmits count.
>
> @param[in] Ip6Cfg The pointer to Ip6 config protocol.
> @param[out] TimeOut The time out value in 100ns units.
^ permalink raw reply [flat|nested] 122+ messages in thread
* [PATCH 35/79] NetworkPkg/DnsDxe: Fix a typo
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (33 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 34/79] NetworkPkg/Dhcp6Dxe: " Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-04 13:35 ` [edk2-devel] " Maciej Rabeda
2019-12-03 16:15 ` [PATCH 36/79] NetworkPkg/DnsDxe: Fix various typos Philippe Mathieu-Daudé
` (37 subsequent siblings)
72 siblings, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel
Cc: Philippe Mathieu-Daude, Antoine Cœur, Jiaxin Wu, Siyuan Fu,
Maciej Rabeda
Fix the same typo in various comments.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/DnsDxe/DnsImpl.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/NetworkPkg/DnsDxe/DnsImpl.c b/NetworkPkg/DnsDxe/DnsImpl.c
index ca4ef506a08a..4c232740be3f 100644
--- a/NetworkPkg/DnsDxe/DnsImpl.c
+++ b/NetworkPkg/DnsDxe/DnsImpl.c
@@ -1179,7 +1179,7 @@ ParseDnsResponse (
RemainingLength = Length;
//
- // Check whether the remaining packet length is avaiable or not.
+ // Check whether the remaining packet length is available or not.
//
if (RemainingLength <= sizeof (DNS_HEADER)) {
*Completed = FALSE;
@@ -1217,7 +1217,7 @@ ParseDnsResponse (
QueryNameLen = (UINT32) AsciiStrLen (QueryName) + 1;
//
- // Check whether the remaining packet length is avaiable or not.
+ // Check whether the remaining packet length is available or not.
//
if (RemainingLength <= QueryNameLen + sizeof (DNS_QUERY_SECTION)) {
*Completed = FALSE;
@@ -1376,7 +1376,7 @@ ParseDnsResponse (
//
while (AnswerSectionNum < DnsHeader->AnswersNum) {
//
- // Check whether the remaining packet length is avaiable or not.
+ // Check whether the remaining packet length is available or not.
//
if (RemainingLength <= sizeof (UINT16) + sizeof (DNS_ANSWER_SECTION)) {
*Completed = FALSE;
@@ -1404,7 +1404,7 @@ ParseDnsResponse (
AnswerSection->DataLength = NTOHS (AnswerSection->DataLength);
//
- // Check whether the remaining packet length is avaiable or not.
+ // Check whether the remaining packet length is available or not.
//
if (RemainingLength < AnswerSection->DataLength) {
*Completed = FALSE;
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [edk2-devel] [PATCH 35/79] NetworkPkg/DnsDxe: Fix a typo
2019-12-03 16:15 ` [PATCH 35/79] NetworkPkg/DnsDxe: Fix a typo Philippe Mathieu-Daudé
@ 2019-12-04 13:35 ` Maciej Rabeda
0 siblings, 0 replies; 122+ messages in thread
From: Maciej Rabeda @ 2019-12-04 13:35 UTC (permalink / raw)
To: devel, philmd; +Cc: Antoine Cœur, Jiaxin Wu, Siyuan Fu, Maciej Rabeda
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
On 03-Dec-19 17:15, Philippe Mathieu-Daudé wrote:
> Fix the same typo in various comments.
>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@intel.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> NetworkPkg/DnsDxe/DnsImpl.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/NetworkPkg/DnsDxe/DnsImpl.c b/NetworkPkg/DnsDxe/DnsImpl.c
> index ca4ef506a08a..4c232740be3f 100644
> --- a/NetworkPkg/DnsDxe/DnsImpl.c
> +++ b/NetworkPkg/DnsDxe/DnsImpl.c
> @@ -1179,7 +1179,7 @@ ParseDnsResponse (
> RemainingLength = Length;
>
> //
> - // Check whether the remaining packet length is avaiable or not.
> + // Check whether the remaining packet length is available or not.
> //
> if (RemainingLength <= sizeof (DNS_HEADER)) {
> *Completed = FALSE;
> @@ -1217,7 +1217,7 @@ ParseDnsResponse (
> QueryNameLen = (UINT32) AsciiStrLen (QueryName) + 1;
>
> //
> - // Check whether the remaining packet length is avaiable or not.
> + // Check whether the remaining packet length is available or not.
> //
> if (RemainingLength <= QueryNameLen + sizeof (DNS_QUERY_SECTION)) {
> *Completed = FALSE;
> @@ -1376,7 +1376,7 @@ ParseDnsResponse (
> //
> while (AnswerSectionNum < DnsHeader->AnswersNum) {
> //
> - // Check whether the remaining packet length is avaiable or not.
> + // Check whether the remaining packet length is available or not.
> //
> if (RemainingLength <= sizeof (UINT16) + sizeof (DNS_ANSWER_SECTION)) {
> *Completed = FALSE;
> @@ -1404,7 +1404,7 @@ ParseDnsResponse (
> AnswerSection->DataLength = NTOHS (AnswerSection->DataLength);
>
> //
> - // Check whether the remaining packet length is avaiable or not.
> + // Check whether the remaining packet length is available or not.
> //
> if (RemainingLength < AnswerSection->DataLength) {
> *Completed = FALSE;
^ permalink raw reply [flat|nested] 122+ messages in thread
* [PATCH 36/79] NetworkPkg/DnsDxe: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (34 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 35/79] NetworkPkg/DnsDxe: Fix a typo Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-04 13:36 ` [edk2-devel] " Maciej Rabeda
2019-12-03 16:15 ` [PATCH 37/79] NetworkPkg/DpcDxe: Fix few typos Philippe Mathieu-Daudé
` (36 subsequent siblings)
72 siblings, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel
Cc: Antoine Coeur, Jiaxin Wu, Siyuan Fu, Maciej Rabeda,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/DnsDxe/DnsDriver.h | 12 ++++-----
NetworkPkg/DnsDxe/DnsImpl.h | 28 ++++++++++----------
NetworkPkg/DnsDxe/DnsDriver.c | 12 ++++-----
NetworkPkg/DnsDxe/DnsImpl.c | 20 +++++++-------
NetworkPkg/DnsDxe/DnsProtocol.c | 16 +++++------
5 files changed, 44 insertions(+), 44 deletions(-)
diff --git a/NetworkPkg/DnsDxe/DnsDriver.h b/NetworkPkg/DnsDxe/DnsDriver.h
index 471b1134ddb3..67365ca81a1b 100644
--- a/NetworkPkg/DnsDxe/DnsDriver.h
+++ b/NetworkPkg/DnsDxe/DnsDriver.h
@@ -318,7 +318,7 @@ Dns4DriverBindingSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -446,7 +446,7 @@ Dns6DriverBindingSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -504,7 +504,7 @@ Dns6DriverBindingStop (
then a new handle is created. If it is a pointer to an existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child
@@ -528,7 +528,7 @@ Dns4ServiceBindingCreateChild (
@param[in] This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param[in] ChildHandle Handle of the child to destroy
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
@@ -555,7 +555,7 @@ Dns4ServiceBindingDestroyChild (
then a new handle is created. If it is a pointer to an existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child
@@ -579,7 +579,7 @@ Dns6ServiceBindingCreateChild (
@param[in] This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param[in] ChildHandle Handle of the child to destroy
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
diff --git a/NetworkPkg/DnsDxe/DnsImpl.h b/NetworkPkg/DnsDxe/DnsImpl.h
index fdab9c75e3f3..10bc399e9ed5 100644
--- a/NetworkPkg/DnsDxe/DnsImpl.h
+++ b/NetworkPkg/DnsDxe/DnsImpl.h
@@ -182,7 +182,7 @@ typedef struct {
@param[in] TokenMap All DNSv4 Token entrys.
@param[in] TokenEntry TokenEntry need to be removed.
- @retval EFI_SUCCESS Remove TokenEntry from TokenMap sucessfully.
+ @retval EFI_SUCCESS Remove TokenEntry from TokenMap successfully.
@retval EFI_NOT_FOUND TokenEntry is not found in TokenMap.
**/
@@ -198,7 +198,7 @@ Dns4RemoveTokenEntry (
@param[in] TokenMap All DNSv6 Token entrys.
@param[in] TokenEntry TokenEntry need to be removed.
- @retval EFI_SUCCESS Remove TokenEntry from TokenMap sucessfully.
+ @retval EFI_SUCCESS Remove TokenEntry from TokenMap successfully.
@retval EFI_NOT_FOUND TokenEntry is not found in TokenMap.
**/
@@ -209,7 +209,7 @@ Dns6RemoveTokenEntry (
);
/**
- This function cancle the token specified by Arg in the Map.
+ This function cancel the token specified by Arg in the Map.
@param[in] Map Pointer to the NET_MAP.
@param[in] Item Pointer to the NET_MAP_ITEM.
@@ -233,7 +233,7 @@ Dns4CancelTokens (
);
/**
- This function cancle the token specified by Arg in the Map.
+ This function cancel the token specified by Arg in the Map.
@param[in] Map Pointer to the NET_MAP.
@param[in] Item Pointer to the NET_MAP_ITEM.
@@ -263,7 +263,7 @@ Dns6CancelTokens (
@param[in] Token Pointer to the token to be get.
@param[out] TokenEntry Pointer to TokenEntry corresponding Token.
- @retval EFI_SUCCESS Get the TokenEntry from the TokensMap sucessfully.
+ @retval EFI_SUCCESS Get the TokenEntry from the TokensMap successfully.
@retval EFI_NOT_FOUND TokenEntry is not found in TokenMap.
**/
@@ -282,7 +282,7 @@ GetDns4TokenEntry (
@param[in] Token Pointer to the token to be get.
@param[out] TokenEntry Pointer to TokenEntry corresponding Token.
- @retval EFI_SUCCESS Get the TokenEntry from the TokensMap sucessfully.
+ @retval EFI_SUCCESS Get the TokenEntry from the TokensMap successfully.
@retval EFI_NOT_FOUND TokenEntry is not found in TokenMap.
**/
@@ -410,7 +410,7 @@ DnsDummyExtFree (
@param UdpCfgData The UDP configure data to reconfigure the UDP_IO
@retval TRUE The default address is retrieved and UDP is reconfigured.
- @retval FALSE Some error occured.
+ @retval FALSE Some error occurred.
**/
BOOLEAN
@@ -429,7 +429,7 @@ Dns4GetMapping (
@param UdpCfgData The UDP configure data to reconfigure the UDP_IO
@retval TRUE Configure the Udp6 instance successfully.
- @retval FALSE Some error occured.
+ @retval FALSE Some error occurred.
**/
BOOLEAN
@@ -743,7 +743,7 @@ Dns4GetModeData (
@retval EFI_SUCCESS The operation completed successfully.
@retval EFI_UNSUPPORTED The designated protocol is not supported.
- @retval EFI_INVALID_PARAMTER Thisis NULL.
+ @retval EFI_INVALID_PARAMETER This is NULL.
The StationIp address provided in DnsConfigData is not a
valid unicast.
DnsServerList is NULL while DnsServerListCount
@@ -869,9 +869,9 @@ Dns4GeneralLookUp (
@param[in] This Pointer to EFI_DNS4_PROTOCOL instance.
@param[in] DeleteFlag If FALSE, this function is to add one entry to the
- DNS Cahce. If TRUE, this function will delete
+ DNS Cache. If TRUE, this function will delete
matching DNS Cache entry.
- @param[in] Override If TRUE, the maching DNS cache entry will be
+ @param[in] Override If TRUE, the matching DNS cache entry will be
overwritten with the supplied parameter. If FALSE,
EFI_ACCESS_DENIED will be returned if the entry to
be added is already existed.
@@ -989,7 +989,7 @@ Dns6GetModeData (
storage to be allocated and released by caller.
@retval EFI_SUCCESS The operation completed successfully.
- @retval EFI_INVALID_PARAMTER This is NULL.
+ @retval EFI_INVALID_PARAMETER This is NULL.
The StationIp address provided in DnsConfigData is not zero and not a valid unicast.
DnsServerList is NULL while DnsServerList Count is not ZERO.
DnsServerList Count is ZERO while DnsServerList is not NULL.
@@ -1117,9 +1117,9 @@ Dns6GeneralLookUp (
@param[in] This Pointer to EFI_DNS6_PROTOCOL instance.
@param[in] DeleteFlag If FALSE, this function is to add one entry to the
- DNS Cahce. If TRUE, this function will delete
+ DNS Cache. If TRUE, this function will delete
matching DNS Cache entry.
- @param[in] Override If TRUE, the maching DNS cache entry will be
+ @param[in] Override If TRUE, the matching DNS cache entry will be
overwritten with the supplied parameter. If FALSE,
EFI_ACCESS_DENIED will be returned if the entry to
be added is already existed.
diff --git a/NetworkPkg/DnsDxe/DnsDriver.c b/NetworkPkg/DnsDxe/DnsDriver.c
index ad007da8b7d6..f099da8a5a95 100644
--- a/NetworkPkg/DnsDxe/DnsDriver.c
+++ b/NetworkPkg/DnsDxe/DnsDriver.c
@@ -630,7 +630,7 @@ Dns4DriverBindingSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -894,7 +894,7 @@ Dns6DriverBindingSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -1057,7 +1057,7 @@ Dns6DriverBindingStop (
then a new handle is created. If it is a pointer to an existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child
@@ -1186,7 +1186,7 @@ ON_ERROR:
@param[in] This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param[in] ChildHandle Handle of the child to destroy
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
@@ -1300,7 +1300,7 @@ Dns4ServiceBindingDestroyChild (
then a new handle is created. If it is a pointer to an existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child
@@ -1429,7 +1429,7 @@ ON_ERROR:
@param[in] This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param[in] ChildHandle Handle of the child to destroy
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
diff --git a/NetworkPkg/DnsDxe/DnsImpl.c b/NetworkPkg/DnsDxe/DnsImpl.c
index 4c232740be3f..25628a5704f0 100644
--- a/NetworkPkg/DnsDxe/DnsImpl.c
+++ b/NetworkPkg/DnsDxe/DnsImpl.c
@@ -14,7 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
@param[in] TokenMap All DNSv4 Token entrys.
@param[in] TokenEntry TokenEntry need to be removed.
- @retval EFI_SUCCESS Remove TokenEntry from TokenMap sucessfully.
+ @retval EFI_SUCCESS Remove TokenEntry from TokenMap successfully.
@retval EFI_NOT_FOUND TokenEntry is not found in TokenMap.
**/
@@ -49,7 +49,7 @@ Dns4RemoveTokenEntry (
@param[in] TokenMap All DNSv6 Token entrys.
@param[in] TokenEntry TokenEntry need to be removed.
- @retval EFI_SUCCESS Remove TokenEntry from TokenMap sucessfully.
+ @retval EFI_SUCCESS Remove TokenEntry from TokenMap successfully.
@retval EFI_NOT_FOUND TokenEntry is not found in TokenMap.
**/
@@ -79,7 +79,7 @@ Dns6RemoveTokenEntry (
}
/**
- This function cancle the token specified by Arg in the Map.
+ This function cancel the token specified by Arg in the Map.
@param[in] Map Pointer to the NET_MAP.
@param[in] Item Pointer to the NET_MAP_ITEM.
@@ -139,7 +139,7 @@ Dns4CancelTokens (
}
/**
- This function cancle the token specified by Arg in the Map.
+ This function cancel the token specified by Arg in the Map.
@param[in] Map Pointer to the NET_MAP.
@param[in] Item Pointer to the NET_MAP_ITEM.
@@ -205,7 +205,7 @@ Dns6CancelTokens (
@param[in] Token Pointer to the token to be get.
@param[out] TokenEntry Pointer to TokenEntry corresponding Token.
- @retval EFI_SUCCESS Get the TokenEntry from the TokensMap sucessfully.
+ @retval EFI_SUCCESS Get the TokenEntry from the TokensMap successfully.
@retval EFI_NOT_FOUND TokenEntry is not found in TokenMap.
**/
@@ -241,7 +241,7 @@ GetDns4TokenEntry (
@param[in] Token Pointer to the token to be get.
@param[out] TokenEntry Pointer to TokenEntry corresponding Token.
- @retval EFI_SUCCESS Get the TokenEntry from the TokensMap sucessfully.
+ @retval EFI_SUCCESS Get the TokenEntry from the TokensMap successfully.
@retval EFI_NOT_FOUND TokenEntry is not found in TokenMap.
**/
@@ -530,7 +530,7 @@ DnsDummyExtFree (
@param UdpCfgData The UDP configure data to reconfigure the UDP_IO
@retval TRUE The default address is retrieved and UDP is reconfigured.
- @retval FALSE Some error occured.
+ @retval FALSE Some error occurred.
**/
BOOLEAN
@@ -582,7 +582,7 @@ Dns4GetMapping (
@param UdpCfgData The UDP configure data to reconfigure the UDP_IO
@retval TRUE Configure the Udp6 instance successfully.
- @retval FALSE Some error occured.
+ @retval FALSE Some error occurred.
**/
BOOLEAN
@@ -2101,7 +2101,7 @@ DnsOnTimerRetransmit (
}
//
- // Retransmit the packet if haven't reach the maxmium retry count,
+ // Retransmit the packet if haven't reach the maximum retry count,
// otherwise exit the transfer.
//
if (++Dns4TokenEntry->RetryCounting <= Dns4TokenEntry->Token->RetryCount) {
@@ -2145,7 +2145,7 @@ DnsOnTimerRetransmit (
}
//
- // Retransmit the packet if haven't reach the maxmium retry count,
+ // Retransmit the packet if haven't reach the maximum retry count,
// otherwise exit the transfer.
//
if (++Dns6TokenEntry->RetryCounting <= Dns6TokenEntry->Token->RetryCount) {
diff --git a/NetworkPkg/DnsDxe/DnsProtocol.c b/NetworkPkg/DnsDxe/DnsProtocol.c
index 9b98e90ddf1e..4acc5fca46cf 100644
--- a/NetworkPkg/DnsDxe/DnsProtocol.c
+++ b/NetworkPkg/DnsDxe/DnsProtocol.c
@@ -158,7 +158,7 @@ ON_EXIT:
@retval EFI_SUCCESS The operation completed successfully.
@retval EFI_UNSUPPORTED The designated protocol is not supported.
- @retval EFI_INVALID_PARAMTER Thisis NULL.
+ @retval EFI_INVALID_PARAMETER This is NULL.
The StationIp address provided in DnsConfigData is not a
valid unicast.
DnsServerList is NULL while DnsServerListCount
@@ -721,9 +721,9 @@ ON_EXIT:
@param[in] This Pointer to EFI_DNS4_PROTOCOL instance.
@param[in] DeleteFlag If FALSE, this function is to add one entry to the
- DNS Cahce. If TRUE, this function will delete
+ DNS Cache. If TRUE, this function will delete
matching DNS Cache entry.
- @param[in] Override If TRUE, the maching DNS cache entry will be
+ @param[in] Override If TRUE, the matching DNS cache entry will be
overwritten with the supplied parameter. If FALSE,
EFI_ACCESS_DENIED will be returned if the entry to
be added is already existed.
@@ -864,7 +864,7 @@ Dns4Cancel (
OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
//
- // Cancle the tokens specified by Token for this instance.
+ // Cancel the tokens specified by Token for this instance.
//
Status = Dns4InstanceCancelToken (Instance, Token);
@@ -1007,7 +1007,7 @@ ON_EXIT:
storage to be allocated and released by caller.
@retval EFI_SUCCESS The operation completed successfully.
- @retval EFI_INVALID_PARAMTER This is NULL.
+ @retval EFI_INVALID_PARAMETER This is NULL.
The StationIp address provided in DnsConfigData is not zero and not a valid unicast.
DnsServerList is NULL while DnsServerList Count is not ZERO.
DnsServerList Count is ZERO while DnsServerList is not NULL.
@@ -1566,9 +1566,9 @@ ON_EXIT:
@param[in] This Pointer to EFI_DNS6_PROTOCOL instance.
@param[in] DeleteFlag If FALSE, this function is to add one entry to the
- DNS Cahce. If TRUE, this function will delete
+ DNS Cache. If TRUE, this function will delete
matching DNS Cache entry.
- @param[in] Override If TRUE, the maching DNS cache entry will be
+ @param[in] Override If TRUE, the matching DNS cache entry will be
overwritten with the supplied parameter. If FALSE,
EFI_ACCESS_DENIED will be returned if the entry to
be added is already existed.
@@ -1713,7 +1713,7 @@ Dns6Cancel (
OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
//
- // Cancle the tokens specified by Token for this instance.
+ // Cancel the tokens specified by Token for this instance.
//
Status = Dns6InstanceCancelToken (Instance, Token);
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [edk2-devel] [PATCH 36/79] NetworkPkg/DnsDxe: Fix various typos
2019-12-03 16:15 ` [PATCH 36/79] NetworkPkg/DnsDxe: Fix various typos Philippe Mathieu-Daudé
@ 2019-12-04 13:36 ` Maciej Rabeda
0 siblings, 0 replies; 122+ messages in thread
From: Maciej Rabeda @ 2019-12-04 13:36 UTC (permalink / raw)
To: devel, philmd; +Cc: Antoine Coeur, Jiaxin Wu, Siyuan Fu, Maciej Rabeda
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
On 03-Dec-19 17:15, Philippe Mathieu-Daudé wrote:
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> NetworkPkg/DnsDxe/DnsDriver.h | 12 ++++-----
> NetworkPkg/DnsDxe/DnsImpl.h | 28 ++++++++++----------
> NetworkPkg/DnsDxe/DnsDriver.c | 12 ++++-----
> NetworkPkg/DnsDxe/DnsImpl.c | 20 +++++++-------
> NetworkPkg/DnsDxe/DnsProtocol.c | 16 +++++------
> 5 files changed, 44 insertions(+), 44 deletions(-)
>
> diff --git a/NetworkPkg/DnsDxe/DnsDriver.h b/NetworkPkg/DnsDxe/DnsDriver.h
> index 471b1134ddb3..67365ca81a1b 100644
> --- a/NetworkPkg/DnsDxe/DnsDriver.h
> +++ b/NetworkPkg/DnsDxe/DnsDriver.h
> @@ -318,7 +318,7 @@ Dns4DriverBindingSupported (
> @retval EFI_SUCCESS The device was started.
> @retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
> @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
> - @retval Others The driver failded to start the device.
> + @retval Others The driver failed to start the device.
>
> **/
> EFI_STATUS
> @@ -446,7 +446,7 @@ Dns6DriverBindingSupported (
> @retval EFI_SUCCESS The device was started.
> @retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
> @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
> - @retval Others The driver failded to start the device.
> + @retval Others The driver failed to start the device.
>
> **/
> EFI_STATUS
> @@ -504,7 +504,7 @@ Dns6DriverBindingStop (
> then a new handle is created. If it is a pointer to an existing UEFI handle,
> then the protocol is added to the existing UEFI handle.
>
> - @retval EFI_SUCCES The protocol was added to ChildHandle.
> + @retval EFI_SUCCESS The protocol was added to ChildHandle.
> @retval EFI_INVALID_PARAMETER ChildHandle is NULL.
> @retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
> the child
> @@ -528,7 +528,7 @@ Dns4ServiceBindingCreateChild (
> @param[in] This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
> @param[in] ChildHandle Handle of the child to destroy
>
> - @retval EFI_SUCCES The protocol was removed from ChildHandle.
> + @retval EFI_SUCCESS The protocol was removed from ChildHandle.
> @retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
> @retval EFI_INVALID_PARAMETER Child handle is NULL.
> @retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
> @@ -555,7 +555,7 @@ Dns4ServiceBindingDestroyChild (
> then a new handle is created. If it is a pointer to an existing UEFI handle,
> then the protocol is added to the existing UEFI handle.
>
> - @retval EFI_SUCCES The protocol was added to ChildHandle.
> + @retval EFI_SUCCESS The protocol was added to ChildHandle.
> @retval EFI_INVALID_PARAMETER ChildHandle is NULL.
> @retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
> the child
> @@ -579,7 +579,7 @@ Dns6ServiceBindingCreateChild (
> @param[in] This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
> @param[in] ChildHandle Handle of the child to destroy
>
> - @retval EFI_SUCCES The protocol was removed from ChildHandle.
> + @retval EFI_SUCCESS The protocol was removed from ChildHandle.
> @retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
> @retval EFI_INVALID_PARAMETER Child handle is NULL.
> @retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
> diff --git a/NetworkPkg/DnsDxe/DnsImpl.h b/NetworkPkg/DnsDxe/DnsImpl.h
> index fdab9c75e3f3..10bc399e9ed5 100644
> --- a/NetworkPkg/DnsDxe/DnsImpl.h
> +++ b/NetworkPkg/DnsDxe/DnsImpl.h
> @@ -182,7 +182,7 @@ typedef struct {
> @param[in] TokenMap All DNSv4 Token entrys.
> @param[in] TokenEntry TokenEntry need to be removed.
>
> - @retval EFI_SUCCESS Remove TokenEntry from TokenMap sucessfully.
> + @retval EFI_SUCCESS Remove TokenEntry from TokenMap successfully.
> @retval EFI_NOT_FOUND TokenEntry is not found in TokenMap.
>
> **/
> @@ -198,7 +198,7 @@ Dns4RemoveTokenEntry (
> @param[in] TokenMap All DNSv6 Token entrys.
> @param[in] TokenEntry TokenEntry need to be removed.
>
> - @retval EFI_SUCCESS Remove TokenEntry from TokenMap sucessfully.
> + @retval EFI_SUCCESS Remove TokenEntry from TokenMap successfully.
> @retval EFI_NOT_FOUND TokenEntry is not found in TokenMap.
>
> **/
> @@ -209,7 +209,7 @@ Dns6RemoveTokenEntry (
> );
>
> /**
> - This function cancle the token specified by Arg in the Map.
> + This function cancel the token specified by Arg in the Map.
>
> @param[in] Map Pointer to the NET_MAP.
> @param[in] Item Pointer to the NET_MAP_ITEM.
> @@ -233,7 +233,7 @@ Dns4CancelTokens (
> );
>
> /**
> - This function cancle the token specified by Arg in the Map.
> + This function cancel the token specified by Arg in the Map.
>
> @param[in] Map Pointer to the NET_MAP.
> @param[in] Item Pointer to the NET_MAP_ITEM.
> @@ -263,7 +263,7 @@ Dns6CancelTokens (
> @param[in] Token Pointer to the token to be get.
> @param[out] TokenEntry Pointer to TokenEntry corresponding Token.
>
> - @retval EFI_SUCCESS Get the TokenEntry from the TokensMap sucessfully.
> + @retval EFI_SUCCESS Get the TokenEntry from the TokensMap successfully.
> @retval EFI_NOT_FOUND TokenEntry is not found in TokenMap.
>
> **/
> @@ -282,7 +282,7 @@ GetDns4TokenEntry (
> @param[in] Token Pointer to the token to be get.
> @param[out] TokenEntry Pointer to TokenEntry corresponding Token.
>
> - @retval EFI_SUCCESS Get the TokenEntry from the TokensMap sucessfully.
> + @retval EFI_SUCCESS Get the TokenEntry from the TokensMap successfully.
> @retval EFI_NOT_FOUND TokenEntry is not found in TokenMap.
>
> **/
> @@ -410,7 +410,7 @@ DnsDummyExtFree (
> @param UdpCfgData The UDP configure data to reconfigure the UDP_IO
>
> @retval TRUE The default address is retrieved and UDP is reconfigured.
> - @retval FALSE Some error occured.
> + @retval FALSE Some error occurred.
>
> **/
> BOOLEAN
> @@ -429,7 +429,7 @@ Dns4GetMapping (
> @param UdpCfgData The UDP configure data to reconfigure the UDP_IO
>
> @retval TRUE Configure the Udp6 instance successfully.
> - @retval FALSE Some error occured.
> + @retval FALSE Some error occurred.
>
> **/
> BOOLEAN
> @@ -743,7 +743,7 @@ Dns4GetModeData (
>
> @retval EFI_SUCCESS The operation completed successfully.
> @retval EFI_UNSUPPORTED The designated protocol is not supported.
> - @retval EFI_INVALID_PARAMTER Thisis NULL.
> + @retval EFI_INVALID_PARAMETER This is NULL.
> The StationIp address provided in DnsConfigData is not a
> valid unicast.
> DnsServerList is NULL while DnsServerListCount
> @@ -869,9 +869,9 @@ Dns4GeneralLookUp (
>
> @param[in] This Pointer to EFI_DNS4_PROTOCOL instance.
> @param[in] DeleteFlag If FALSE, this function is to add one entry to the
> - DNS Cahce. If TRUE, this function will delete
> + DNS Cache. If TRUE, this function will delete
> matching DNS Cache entry.
> - @param[in] Override If TRUE, the maching DNS cache entry will be
> + @param[in] Override If TRUE, the matching DNS cache entry will be
> overwritten with the supplied parameter. If FALSE,
> EFI_ACCESS_DENIED will be returned if the entry to
> be added is already existed.
> @@ -989,7 +989,7 @@ Dns6GetModeData (
> storage to be allocated and released by caller.
>
> @retval EFI_SUCCESS The operation completed successfully.
> - @retval EFI_INVALID_PARAMTER This is NULL.
> + @retval EFI_INVALID_PARAMETER This is NULL.
> The StationIp address provided in DnsConfigData is not zero and not a valid unicast.
> DnsServerList is NULL while DnsServerList Count is not ZERO.
> DnsServerList Count is ZERO while DnsServerList is not NULL.
> @@ -1117,9 +1117,9 @@ Dns6GeneralLookUp (
>
> @param[in] This Pointer to EFI_DNS6_PROTOCOL instance.
> @param[in] DeleteFlag If FALSE, this function is to add one entry to the
> - DNS Cahce. If TRUE, this function will delete
> + DNS Cache. If TRUE, this function will delete
> matching DNS Cache entry.
> - @param[in] Override If TRUE, the maching DNS cache entry will be
> + @param[in] Override If TRUE, the matching DNS cache entry will be
> overwritten with the supplied parameter. If FALSE,
> EFI_ACCESS_DENIED will be returned if the entry to
> be added is already existed.
> diff --git a/NetworkPkg/DnsDxe/DnsDriver.c b/NetworkPkg/DnsDxe/DnsDriver.c
> index ad007da8b7d6..f099da8a5a95 100644
> --- a/NetworkPkg/DnsDxe/DnsDriver.c
> +++ b/NetworkPkg/DnsDxe/DnsDriver.c
> @@ -630,7 +630,7 @@ Dns4DriverBindingSupported (
> @retval EFI_SUCCESS The device was started.
> @retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
> @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
> - @retval Others The driver failded to start the device.
> + @retval Others The driver failed to start the device.
>
> **/
> EFI_STATUS
> @@ -894,7 +894,7 @@ Dns6DriverBindingSupported (
> @retval EFI_SUCCESS The device was started.
> @retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
> @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
> - @retval Others The driver failded to start the device.
> + @retval Others The driver failed to start the device.
>
> **/
> EFI_STATUS
> @@ -1057,7 +1057,7 @@ Dns6DriverBindingStop (
> then a new handle is created. If it is a pointer to an existing UEFI handle,
> then the protocol is added to the existing UEFI handle.
>
> - @retval EFI_SUCCES The protocol was added to ChildHandle.
> + @retval EFI_SUCCESS The protocol was added to ChildHandle.
> @retval EFI_INVALID_PARAMETER ChildHandle is NULL.
> @retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
> the child
> @@ -1186,7 +1186,7 @@ ON_ERROR:
> @param[in] This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
> @param[in] ChildHandle Handle of the child to destroy
>
> - @retval EFI_SUCCES The protocol was removed from ChildHandle.
> + @retval EFI_SUCCESS The protocol was removed from ChildHandle.
> @retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
> @retval EFI_INVALID_PARAMETER Child handle is NULL.
> @retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
> @@ -1300,7 +1300,7 @@ Dns4ServiceBindingDestroyChild (
> then a new handle is created. If it is a pointer to an existing UEFI handle,
> then the protocol is added to the existing UEFI handle.
>
> - @retval EFI_SUCCES The protocol was added to ChildHandle.
> + @retval EFI_SUCCESS The protocol was added to ChildHandle.
> @retval EFI_INVALID_PARAMETER ChildHandle is NULL.
> @retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
> the child
> @@ -1429,7 +1429,7 @@ ON_ERROR:
> @param[in] This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
> @param[in] ChildHandle Handle of the child to destroy
>
> - @retval EFI_SUCCES The protocol was removed from ChildHandle.
> + @retval EFI_SUCCESS The protocol was removed from ChildHandle.
> @retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
> @retval EFI_INVALID_PARAMETER Child handle is NULL.
> @retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
> diff --git a/NetworkPkg/DnsDxe/DnsImpl.c b/NetworkPkg/DnsDxe/DnsImpl.c
> index 4c232740be3f..25628a5704f0 100644
> --- a/NetworkPkg/DnsDxe/DnsImpl.c
> +++ b/NetworkPkg/DnsDxe/DnsImpl.c
> @@ -14,7 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> @param[in] TokenMap All DNSv4 Token entrys.
> @param[in] TokenEntry TokenEntry need to be removed.
>
> - @retval EFI_SUCCESS Remove TokenEntry from TokenMap sucessfully.
> + @retval EFI_SUCCESS Remove TokenEntry from TokenMap successfully.
> @retval EFI_NOT_FOUND TokenEntry is not found in TokenMap.
>
> **/
> @@ -49,7 +49,7 @@ Dns4RemoveTokenEntry (
> @param[in] TokenMap All DNSv6 Token entrys.
> @param[in] TokenEntry TokenEntry need to be removed.
>
> - @retval EFI_SUCCESS Remove TokenEntry from TokenMap sucessfully.
> + @retval EFI_SUCCESS Remove TokenEntry from TokenMap successfully.
> @retval EFI_NOT_FOUND TokenEntry is not found in TokenMap.
>
> **/
> @@ -79,7 +79,7 @@ Dns6RemoveTokenEntry (
> }
>
> /**
> - This function cancle the token specified by Arg in the Map.
> + This function cancel the token specified by Arg in the Map.
>
> @param[in] Map Pointer to the NET_MAP.
> @param[in] Item Pointer to the NET_MAP_ITEM.
> @@ -139,7 +139,7 @@ Dns4CancelTokens (
> }
>
> /**
> - This function cancle the token specified by Arg in the Map.
> + This function cancel the token specified by Arg in the Map.
>
> @param[in] Map Pointer to the NET_MAP.
> @param[in] Item Pointer to the NET_MAP_ITEM.
> @@ -205,7 +205,7 @@ Dns6CancelTokens (
> @param[in] Token Pointer to the token to be get.
> @param[out] TokenEntry Pointer to TokenEntry corresponding Token.
>
> - @retval EFI_SUCCESS Get the TokenEntry from the TokensMap sucessfully.
> + @retval EFI_SUCCESS Get the TokenEntry from the TokensMap successfully.
> @retval EFI_NOT_FOUND TokenEntry is not found in TokenMap.
>
> **/
> @@ -241,7 +241,7 @@ GetDns4TokenEntry (
> @param[in] Token Pointer to the token to be get.
> @param[out] TokenEntry Pointer to TokenEntry corresponding Token.
>
> - @retval EFI_SUCCESS Get the TokenEntry from the TokensMap sucessfully.
> + @retval EFI_SUCCESS Get the TokenEntry from the TokensMap successfully.
> @retval EFI_NOT_FOUND TokenEntry is not found in TokenMap.
>
> **/
> @@ -530,7 +530,7 @@ DnsDummyExtFree (
> @param UdpCfgData The UDP configure data to reconfigure the UDP_IO
>
> @retval TRUE The default address is retrieved and UDP is reconfigured.
> - @retval FALSE Some error occured.
> + @retval FALSE Some error occurred.
>
> **/
> BOOLEAN
> @@ -582,7 +582,7 @@ Dns4GetMapping (
> @param UdpCfgData The UDP configure data to reconfigure the UDP_IO
>
> @retval TRUE Configure the Udp6 instance successfully.
> - @retval FALSE Some error occured.
> + @retval FALSE Some error occurred.
>
> **/
> BOOLEAN
> @@ -2101,7 +2101,7 @@ DnsOnTimerRetransmit (
> }
>
> //
> - // Retransmit the packet if haven't reach the maxmium retry count,
> + // Retransmit the packet if haven't reach the maximum retry count,
> // otherwise exit the transfer.
> //
> if (++Dns4TokenEntry->RetryCounting <= Dns4TokenEntry->Token->RetryCount) {
> @@ -2145,7 +2145,7 @@ DnsOnTimerRetransmit (
> }
>
> //
> - // Retransmit the packet if haven't reach the maxmium retry count,
> + // Retransmit the packet if haven't reach the maximum retry count,
> // otherwise exit the transfer.
> //
> if (++Dns6TokenEntry->RetryCounting <= Dns6TokenEntry->Token->RetryCount) {
> diff --git a/NetworkPkg/DnsDxe/DnsProtocol.c b/NetworkPkg/DnsDxe/DnsProtocol.c
> index 9b98e90ddf1e..4acc5fca46cf 100644
> --- a/NetworkPkg/DnsDxe/DnsProtocol.c
> +++ b/NetworkPkg/DnsDxe/DnsProtocol.c
> @@ -158,7 +158,7 @@ ON_EXIT:
>
> @retval EFI_SUCCESS The operation completed successfully.
> @retval EFI_UNSUPPORTED The designated protocol is not supported.
> - @retval EFI_INVALID_PARAMTER Thisis NULL.
> + @retval EFI_INVALID_PARAMETER This is NULL.
> The StationIp address provided in DnsConfigData is not a
> valid unicast.
> DnsServerList is NULL while DnsServerListCount
> @@ -721,9 +721,9 @@ ON_EXIT:
>
> @param[in] This Pointer to EFI_DNS4_PROTOCOL instance.
> @param[in] DeleteFlag If FALSE, this function is to add one entry to the
> - DNS Cahce. If TRUE, this function will delete
> + DNS Cache. If TRUE, this function will delete
> matching DNS Cache entry.
> - @param[in] Override If TRUE, the maching DNS cache entry will be
> + @param[in] Override If TRUE, the matching DNS cache entry will be
> overwritten with the supplied parameter. If FALSE,
> EFI_ACCESS_DENIED will be returned if the entry to
> be added is already existed.
> @@ -864,7 +864,7 @@ Dns4Cancel (
> OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
>
> //
> - // Cancle the tokens specified by Token for this instance.
> + // Cancel the tokens specified by Token for this instance.
> //
> Status = Dns4InstanceCancelToken (Instance, Token);
>
> @@ -1007,7 +1007,7 @@ ON_EXIT:
> storage to be allocated and released by caller.
>
> @retval EFI_SUCCESS The operation completed successfully.
> - @retval EFI_INVALID_PARAMTER This is NULL.
> + @retval EFI_INVALID_PARAMETER This is NULL.
> The StationIp address provided in DnsConfigData is not zero and not a valid unicast.
> DnsServerList is NULL while DnsServerList Count is not ZERO.
> DnsServerList Count is ZERO while DnsServerList is not NULL.
> @@ -1566,9 +1566,9 @@ ON_EXIT:
>
> @param[in] This Pointer to EFI_DNS6_PROTOCOL instance.
> @param[in] DeleteFlag If FALSE, this function is to add one entry to the
> - DNS Cahce. If TRUE, this function will delete
> + DNS Cache. If TRUE, this function will delete
> matching DNS Cache entry.
> - @param[in] Override If TRUE, the maching DNS cache entry will be
> + @param[in] Override If TRUE, the matching DNS cache entry will be
> overwritten with the supplied parameter. If FALSE,
> EFI_ACCESS_DENIED will be returned if the entry to
> be added is already existed.
> @@ -1713,7 +1713,7 @@ Dns6Cancel (
> OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
>
> //
> - // Cancle the tokens specified by Token for this instance.
> + // Cancel the tokens specified by Token for this instance.
> //
> Status = Dns6InstanceCancelToken (Instance, Token);
>
^ permalink raw reply [flat|nested] 122+ messages in thread
* [PATCH 37/79] NetworkPkg/DpcDxe: Fix few typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (35 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 36/79] NetworkPkg/DnsDxe: Fix various typos Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-04 13:37 ` [edk2-devel] " Maciej Rabeda
2019-12-03 16:15 ` [PATCH 38/79] NetworkPkg/HttpBootDxe: Fix a typo in variable name Philippe Mathieu-Daudé
` (35 subsequent siblings)
72 siblings, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel
Cc: Antoine Coeur, Jiaxin Wu, Siyuan Fu, Maciej Rabeda,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix few typos in comments and documentation.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/DpcDxe/Dpc.h | 2 +-
NetworkPkg/Include/Protocol/Dpc.h | 2 +-
NetworkPkg/DpcDxe/Dpc.c | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/NetworkPkg/DpcDxe/Dpc.h b/NetworkPkg/DpcDxe/Dpc.h
index 2017a215e352..a5e6f7b62f90 100644
--- a/NetworkPkg/DpcDxe/Dpc.h
+++ b/NetworkPkg/DpcDxe/Dpc.h
@@ -24,7 +24,7 @@ Abstract:
#include <Protocol/Dpc.h>
//
-// Internal data struture for managing DPCs. A DPC entry is either on the free
+// Internal data structure for managing DPCs. A DPC entry is either on the free
// list or on a DPC queue at a specific EFI_TPL.
//
typedef struct {
diff --git a/NetworkPkg/Include/Protocol/Dpc.h b/NetworkPkg/Include/Protocol/Dpc.h
index 1e1d0d316d54..5e50f6cf308c 100644
--- a/NetworkPkg/Include/Protocol/Dpc.h
+++ b/NetworkPkg/Include/Protocol/Dpc.h
@@ -20,7 +20,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
}
//
-// Forward reference for pure ANSI compatability
+// Forward reference for pure ANSI compatibility
//
typedef struct _EFI_DPC_PROTOCOL EFI_DPC_PROTOCOL;
diff --git a/NetworkPkg/DpcDxe/Dpc.c b/NetworkPkg/DpcDxe/Dpc.c
index 8a490949dc8c..7c85dd8757c3 100644
--- a/NetworkPkg/DpcDxe/Dpc.c
+++ b/NetworkPkg/DpcDxe/Dpc.c
@@ -28,7 +28,7 @@ EFI_DPC_PROTOCOL mDpc = {
};
//
-// Global variables used to meaasure the DPC Queue Depths
+// Global variables used to measure the DPC Queue Depths
//
UINTN mDpcQueueDepth = 0;
UINTN mMaxDpcQueueDepth = 0;
@@ -42,7 +42,7 @@ UINTN mMaxDpcQueueDepth = 0;
LIST_ENTRY mDpcEntryFreeList = INITIALIZE_LIST_HEAD_VARIABLE(mDpcEntryFreeList);
//
-// An array of DPC queues. A DPC queue is allocated for every leval EFI_TPL value.
+// An array of DPC queues. A DPC queue is allocated for every level EFI_TPL value.
// As DPCs are queued, they are added to the end of the linked list.
// As DPCs are dispatched, they are removed from the beginning of the linked list.
//
@@ -299,7 +299,7 @@ DpcDispatchDpc (
@param ImageHandle The image handle of the driver.
@param SystemTable The system table.
- @retval EFI_SUCCES The DPC queues were initialized and the EFI_DPC_PROTOCOL was
+ @retval EFI_SUCCESS The DPC queues were initialized and the EFI_DPC_PROTOCOL was
installed onto a new handle.
@retval Others Failed to install EFI_DPC_PROTOCOL.
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [edk2-devel] [PATCH 37/79] NetworkPkg/DpcDxe: Fix few typos
2019-12-03 16:15 ` [PATCH 37/79] NetworkPkg/DpcDxe: Fix few typos Philippe Mathieu-Daudé
@ 2019-12-04 13:37 ` Maciej Rabeda
0 siblings, 0 replies; 122+ messages in thread
From: Maciej Rabeda @ 2019-12-04 13:37 UTC (permalink / raw)
To: devel, philmd; +Cc: Antoine Coeur, Jiaxin Wu, Siyuan Fu, Maciej Rabeda
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
On 03-Dec-19 17:15, Philippe Mathieu-Daudé wrote:
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix few typos in comments and documentation.
>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> NetworkPkg/DpcDxe/Dpc.h | 2 +-
> NetworkPkg/Include/Protocol/Dpc.h | 2 +-
> NetworkPkg/DpcDxe/Dpc.c | 6 +++---
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/NetworkPkg/DpcDxe/Dpc.h b/NetworkPkg/DpcDxe/Dpc.h
> index 2017a215e352..a5e6f7b62f90 100644
> --- a/NetworkPkg/DpcDxe/Dpc.h
> +++ b/NetworkPkg/DpcDxe/Dpc.h
> @@ -24,7 +24,7 @@ Abstract:
> #include <Protocol/Dpc.h>
>
> //
> -// Internal data struture for managing DPCs. A DPC entry is either on the free
> +// Internal data structure for managing DPCs. A DPC entry is either on the free
> // list or on a DPC queue at a specific EFI_TPL.
> //
> typedef struct {
> diff --git a/NetworkPkg/Include/Protocol/Dpc.h b/NetworkPkg/Include/Protocol/Dpc.h
> index 1e1d0d316d54..5e50f6cf308c 100644
> --- a/NetworkPkg/Include/Protocol/Dpc.h
> +++ b/NetworkPkg/Include/Protocol/Dpc.h
> @@ -20,7 +20,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> }
>
> //
> -// Forward reference for pure ANSI compatability
> +// Forward reference for pure ANSI compatibility
> //
> typedef struct _EFI_DPC_PROTOCOL EFI_DPC_PROTOCOL;
>
> diff --git a/NetworkPkg/DpcDxe/Dpc.c b/NetworkPkg/DpcDxe/Dpc.c
> index 8a490949dc8c..7c85dd8757c3 100644
> --- a/NetworkPkg/DpcDxe/Dpc.c
> +++ b/NetworkPkg/DpcDxe/Dpc.c
> @@ -28,7 +28,7 @@ EFI_DPC_PROTOCOL mDpc = {
> };
>
> //
> -// Global variables used to meaasure the DPC Queue Depths
> +// Global variables used to measure the DPC Queue Depths
> //
> UINTN mDpcQueueDepth = 0;
> UINTN mMaxDpcQueueDepth = 0;
> @@ -42,7 +42,7 @@ UINTN mMaxDpcQueueDepth = 0;
> LIST_ENTRY mDpcEntryFreeList = INITIALIZE_LIST_HEAD_VARIABLE(mDpcEntryFreeList);
>
> //
> -// An array of DPC queues. A DPC queue is allocated for every leval EFI_TPL value.
> +// An array of DPC queues. A DPC queue is allocated for every level EFI_TPL value.
> // As DPCs are queued, they are added to the end of the linked list.
> // As DPCs are dispatched, they are removed from the beginning of the linked list.
> //
> @@ -299,7 +299,7 @@ DpcDispatchDpc (
> @param ImageHandle The image handle of the driver.
> @param SystemTable The system table.
>
> - @retval EFI_SUCCES The DPC queues were initialized and the EFI_DPC_PROTOCOL was
> + @retval EFI_SUCCESS The DPC queues were initialized and the EFI_DPC_PROTOCOL was
> installed onto a new handle.
> @retval Others Failed to install EFI_DPC_PROTOCOL.
>
^ permalink raw reply [flat|nested] 122+ messages in thread
* [PATCH 38/79] NetworkPkg/HttpBootDxe: Fix a typo in variable name
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (36 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 37/79] NetworkPkg/DpcDxe: Fix few typos Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-04 13:52 ` [edk2-devel] " Maciej Rabeda
2019-12-03 16:15 ` [PATCH 39/79] NetworkPkg/HttpBootDxe: Fix various typos Philippe Mathieu-Daudé
` (34 subsequent siblings)
72 siblings, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel
Cc: Philippe Mathieu-Daude, Antoine Cœur, Jiaxin Wu, Siyuan Fu,
Maciej Rabeda
Correctly write 'Initialized'.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/HttpBootDxe/HttpBootConfig.h | 2 +-
NetworkPkg/HttpBootDxe/HttpBootConfig.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/NetworkPkg/HttpBootDxe/HttpBootConfig.h b/NetworkPkg/HttpBootDxe/HttpBootConfig.h
index ce2116e248b5..84eab425b04f 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootConfig.h
+++ b/NetworkPkg/HttpBootDxe/HttpBootConfig.h
@@ -32,7 +32,7 @@ extern UINT8 HttpBootConfigVfrBin[];
struct _HTTP_BOOT_FORM_CALLBACK_INFO {
UINT32 Signature;
- BOOLEAN Initilized;
+ BOOLEAN Initialized;
EFI_HANDLE ChildHandle;
EFI_DEVICE_PATH_PROTOCOL *HiiVendorDevicePath;
EFI_HII_HANDLE RegisteredHandle;
diff --git a/NetworkPkg/HttpBootDxe/HttpBootConfig.c b/NetworkPkg/HttpBootDxe/HttpBootConfig.c
index 245bd49a621a..646c907b1215 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootConfig.c
+++ b/NetworkPkg/HttpBootDxe/HttpBootConfig.c
@@ -552,7 +552,7 @@ HttpBootConfigFormInit (
CallbackInfo = &Private->CallbackInfo;
- if (CallbackInfo->Initilized) {
+ if (CallbackInfo->Initialized) {
return EFI_SUCCESS;
}
@@ -632,7 +632,7 @@ HttpBootConfigFormInit (
FreePool (MacString);
FreePool (OldMenuString);
- CallbackInfo->Initilized = TRUE;
+ CallbackInfo->Initialized = TRUE;
return EFI_SUCCESS;
}
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [edk2-devel] [PATCH 38/79] NetworkPkg/HttpBootDxe: Fix a typo in variable name
2019-12-03 16:15 ` [PATCH 38/79] NetworkPkg/HttpBootDxe: Fix a typo in variable name Philippe Mathieu-Daudé
@ 2019-12-04 13:52 ` Maciej Rabeda
0 siblings, 0 replies; 122+ messages in thread
From: Maciej Rabeda @ 2019-12-04 13:52 UTC (permalink / raw)
To: devel, philmd; +Cc: Antoine Cœur, Jiaxin Wu, Siyuan Fu, Maciej Rabeda
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
On 03-Dec-19 17:15, Philippe Mathieu-Daudé wrote:
> Correctly write 'Initialized'.
>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@intel.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> NetworkPkg/HttpBootDxe/HttpBootConfig.h | 2 +-
> NetworkPkg/HttpBootDxe/HttpBootConfig.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootConfig.h b/NetworkPkg/HttpBootDxe/HttpBootConfig.h
> index ce2116e248b5..84eab425b04f 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootConfig.h
> +++ b/NetworkPkg/HttpBootDxe/HttpBootConfig.h
> @@ -32,7 +32,7 @@ extern UINT8 HttpBootConfigVfrBin[];
>
> struct _HTTP_BOOT_FORM_CALLBACK_INFO {
> UINT32 Signature;
> - BOOLEAN Initilized;
> + BOOLEAN Initialized;
> EFI_HANDLE ChildHandle;
> EFI_DEVICE_PATH_PROTOCOL *HiiVendorDevicePath;
> EFI_HII_HANDLE RegisteredHandle;
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootConfig.c b/NetworkPkg/HttpBootDxe/HttpBootConfig.c
> index 245bd49a621a..646c907b1215 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootConfig.c
> +++ b/NetworkPkg/HttpBootDxe/HttpBootConfig.c
> @@ -552,7 +552,7 @@ HttpBootConfigFormInit (
>
> CallbackInfo = &Private->CallbackInfo;
>
> - if (CallbackInfo->Initilized) {
> + if (CallbackInfo->Initialized) {
> return EFI_SUCCESS;
> }
>
> @@ -632,7 +632,7 @@ HttpBootConfigFormInit (
> FreePool (MacString);
> FreePool (OldMenuString);
>
> - CallbackInfo->Initilized = TRUE;
> + CallbackInfo->Initialized = TRUE;
> return EFI_SUCCESS;
> }
>
^ permalink raw reply [flat|nested] 122+ messages in thread
* [PATCH 39/79] NetworkPkg/HttpBootDxe: Fix various typos
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (37 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 38/79] NetworkPkg/HttpBootDxe: Fix a typo in variable name Philippe Mathieu-Daudé
@ 2019-12-03 16:15 ` Philippe Mathieu-Daudé
2019-12-04 13:53 ` [edk2-devel] " Maciej Rabeda
2019-12-03 16:26 ` [PATCH 00/79] Fix a bunch of typos (part 1) Cœur
` (33 subsequent siblings)
72 siblings, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-03 16:15 UTC (permalink / raw)
To: devel
Cc: Antoine Coeur, Jiaxin Wu, Siyuan Fu, Maciej Rabeda,
Philippe Mathieu-Daude
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/HttpBootDxe/HttpBootDhcp4.h | 2 +-
NetworkPkg/HttpBootDxe/HttpBootDhcp6.h | 4 ++--
NetworkPkg/HttpBootDxe/HttpBootDxe.h | 6 +++---
NetworkPkg/HttpBootDxe/HttpBootSupport.h | 10 +++++-----
NetworkPkg/HttpBootDxe/HttpBootDhcp4.c | 2 +-
NetworkPkg/HttpBootDxe/HttpBootDhcp6.c | 10 +++++-----
NetworkPkg/HttpBootDxe/HttpBootDxe.c | 8 ++++----
NetworkPkg/HttpBootDxe/HttpBootImpl.c | 2 +-
NetworkPkg/HttpBootDxe/HttpBootSupport.c | 12 ++++++------
9 files changed, 28 insertions(+), 28 deletions(-)
diff --git a/NetworkPkg/HttpBootDxe/HttpBootDhcp4.h b/NetworkPkg/HttpBootDxe/HttpBootDhcp4.h
index 2c2fa28302a3..74bbdac58e86 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootDhcp4.h
+++ b/NetworkPkg/HttpBootDxe/HttpBootDhcp4.h
@@ -41,7 +41,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
/// DHCP offer types among HTTP boot.
/// Dhcp4 and Dhcp6 share this definition, and corresponding
-/// relatioinship is as follows:
+/// relationship is as follows:
/// Dhcp4Discover <> Dhcp6Solicit
/// Dhcp4Offer <> Dhcp6Advertise
/// Dhcp4Request <> Dhcp6Request
diff --git a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.h b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.h
index e21f272aa1ac..e1a652031976 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.h
+++ b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.h
@@ -110,8 +110,8 @@ HttpBootDhcp6Sarr (
@param[in] Private The pointer to HTTP_BOOT_PRIVATE_DATA.
- @retval EFI_SUCCESS Switch the IP policy succesfully.
- @retval Others Unexpect error happened.
+ @retval EFI_SUCCESS Switch the IP policy successfully.
+ @retval Others Unexpected error happened.
**/
EFI_STATUS
diff --git a/NetworkPkg/HttpBootDxe/HttpBootDxe.h b/NetworkPkg/HttpBootDxe/HttpBootDxe.h
index 89b7d6aa702b..0b45f9de0bdb 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootDxe.h
+++ b/NetworkPkg/HttpBootDxe/HttpBootDxe.h
@@ -147,7 +147,7 @@ struct _HTTP_BOOT_PRIVATE_DATA {
HTTP_BOOT_VIRTUAL_NIC *Ip6Nic;
//
- // Cousumed children
+ // Consumed children
//
EFI_HANDLE Ip6Child;
EFI_HANDLE Dhcp4Child;
@@ -348,7 +348,7 @@ HttpBootIp4DxeDriverBindingSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -476,7 +476,7 @@ HttpBootIp6DxeDriverBindingSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
diff --git a/NetworkPkg/HttpBootDxe/HttpBootSupport.h b/NetworkPkg/HttpBootDxe/HttpBootSupport.h
index 10f62f6ec31a..81d072ae3734 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootSupport.h
+++ b/NetworkPkg/HttpBootDxe/HttpBootSupport.h
@@ -98,7 +98,7 @@ typedef struct {
/**
Create a HTTP_IO_HEADER to hold the HTTP header items.
- @param[in] MaxHeaderCount The maximun number of HTTP header in this holder.
+ @param[in] MaxHeaderCount The maximum number of HTTP header in this holder.
@return A pointer of the HTTP header holder or NULL if failed.
@@ -109,7 +109,7 @@ HttpBootCreateHeader (
);
/**
- Destroy the HTTP_IO_HEADER and release the resouces.
+ Destroy the HTTP_IO_HEADER and release the resources.
@param[in] HttpIoHeader Point to the HTTP header holder to be destroyed.
@@ -300,7 +300,7 @@ HttpIoCreateIo (
);
/**
- Destroy the HTTP_IO and release the resouces.
+ Destroy the HTTP_IO and release the resources.
@param[in] HttpIo The HTTP_IO which wraps the HTTP service to be destroyed.
@@ -320,7 +320,7 @@ HttpIoDestroyIo (
@param[in] BodyLength Length in bytes of the HTTP body.
@param[in] Body Body associated with the HTTP request.
- @retval EFI_SUCCESS The HTTP request is trasmitted.
+ @retval EFI_SUCCESS The HTTP request is transmitted.
@retval EFI_INVALID_PARAMETER One or more parameters are invalid.
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory.
@retval EFI_DEVICE_ERROR An unexpected network or system error occurred.
@@ -406,7 +406,7 @@ HttpBootParseFilePath (
@retval EFI_INVALID_PARAMETER ImageType, Uri or UriParser is NULL.
@retval EFI_INVALID_PARAMETER HeaderCount is not zero, and Headers is NULL.
@retval EFI_NOT_FOUND Failed to identify the image type.
- @retval Others Unexpect error happened.
+ @retval Others Unexpected error happened.
**/
EFI_STATUS
diff --git a/NetworkPkg/HttpBootDxe/HttpBootDhcp4.c b/NetworkPkg/HttpBootDxe/HttpBootDhcp4.c
index b5dd6e09567a..1da05dbf0e95 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootDhcp4.c
+++ b/NetworkPkg/HttpBootDxe/HttpBootDhcp4.c
@@ -94,7 +94,7 @@ HttpBootBuildDhcp4Options (
OptEnt.Uuid->Type = 0;
if (EFI_ERROR (NetLibGetSystemGuid ((EFI_GUID *) OptEnt.Uuid->Guid))) {
//
- // Zero the Guid to indicate NOT programable if failed to get system Guid.
+ // Zero the Guid to indicate NOT programmable if failed to get system Guid.
//
ZeroMem (OptEnt.Uuid->Guid, sizeof (EFI_GUID));
}
diff --git a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c
index 8a1dd66ceec0..4905bca4ad19 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c
+++ b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c
@@ -126,7 +126,7 @@ HttpBootBuildDhcp6Options (
@param[in] OptTag The required option tag.
@retval NULL Failed to parse the required option.
- @retval Others The postion of the required option in buffer.
+ @retval Others The position of the required option in buffer.
**/
EFI_DHCP6_PACKET_OPTION *
@@ -225,7 +225,7 @@ HttpBootParseDhcp6Packet (
}
//
// The offer with assigned client address is NOT a proxy offer.
- // An ia_na option, embeded with valid ia_addr option and a status_code of success.
+ // An ia_na option, embedded with valid ia_addr option and a status_code of success.
//
Option = Options[HTTP_BOOT_DHCP6_IDX_IA_NA];
if (Option != NULL) {
@@ -514,7 +514,7 @@ HttpBootDhcp6CallBack (
@retval EFI_SUCCESS Found a valid gateway address successfully.
@retval EFI_TIMEOUT The operation is time out.
- @retval Other Unexpect error happened.
+ @retval Other Unexpected error happened.
**/
EFI_STATUS
@@ -628,8 +628,8 @@ ON_EXIT:
@param[in] Private The pointer to HTTP_BOOT_PRIVATE_DATA.
- @retval EFI_SUCCESS Switch the IP policy succesfully.
- @retval Others Unexpect error happened.
+ @retval EFI_SUCCESS Switch the IP policy successfully.
+ @retval Others Unexpected error happened.
**/
EFI_STATUS
diff --git a/NetworkPkg/HttpBootDxe/HttpBootDxe.c b/NetworkPkg/HttpBootDxe/HttpBootDxe.c
index 2efdd9be101a..5d9c24f4a22a 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootDxe.c
+++ b/NetworkPkg/HttpBootDxe/HttpBootDxe.c
@@ -382,7 +382,7 @@ HttpBootIp4DxeDriverBindingSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -720,7 +720,7 @@ HttpBootIp4DxeDriverBindingStop (
}
//
- // Destory all child instance and uninstall protocol interface.
+ // Destroy all child instance and uninstall protocol interface.
//
HttpBootDestroyIp4Children (This, Private);
@@ -871,7 +871,7 @@ HttpBootIp6DxeDriverBindingSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -1250,7 +1250,7 @@ HttpBootIp6DxeDriverBindingStop (
}
//
- // Destory all child instance and uninstall protocol interface.
+ // Destroy all child instance and uninstall protocol interface.
//
HttpBootDestroyIp6Children (This, Private);
diff --git a/NetworkPkg/HttpBootDxe/HttpBootImpl.c b/NetworkPkg/HttpBootDxe/HttpBootImpl.c
index 5eeb1ea2b4a7..4a51f35cddbe 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootImpl.c
+++ b/NetworkPkg/HttpBootDxe/HttpBootImpl.c
@@ -14,7 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
@param[in] Private Pointer to HTTP Boot private data.
- @retval EFI_SUCCESS HTTP Boot Callback Protocol installed succesfully.
+ @retval EFI_SUCCESS HTTP Boot Callback Protocol installed successfully.
@retval Others Failed to install HTTP Boot Callback Protocol.
**/
diff --git a/NetworkPkg/HttpBootDxe/HttpBootSupport.c b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
index 61814d3b64ff..5b0e054a05eb 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootSupport.c
+++ b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
@@ -494,7 +494,7 @@ Exit:
/**
Create a HTTP_IO_HEADER to hold the HTTP header items.
- @param[in] MaxHeaderCount The maximun number of HTTP header in this holder.
+ @param[in] MaxHeaderCount The maximum number of HTTP header in this holder.
@return A pointer of the HTTP header holder or NULL if failed.
@@ -522,7 +522,7 @@ HttpBootCreateHeader (
}
/**
- Destroy the HTTP_IO_HEADER and release the resouces.
+ Destroy the HTTP_IO_HEADER and release the resources.
@param[in] HttpIoHeader Point to the HTTP header holder to be destroyed.
@@ -765,7 +765,7 @@ HttpIoCreateIo (
}
//
- // Create events for variuos asynchronous operations.
+ // Create events for various asynchronous operations.
//
Status = gBS->CreateEvent (
EVT_NOTIFY_SIGNAL,
@@ -817,7 +817,7 @@ ON_ERROR:
}
/**
- Destroy the HTTP_IO and release the resouces.
+ Destroy the HTTP_IO and release the resources.
@param[in] HttpIo The HTTP_IO which wraps the HTTP service to be destroyed.
@@ -878,7 +878,7 @@ HttpIoDestroyIo (
@param[in] BodyLength Length in bytes of the HTTP body.
@param[in] Body Body associated with the HTTP request.
- @retval EFI_SUCCESS The HTTP request is trasmitted.
+ @retval EFI_SUCCESS The HTTP request is transmitted.
@retval EFI_INVALID_PARAMETER One or more parameters are invalid.
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory.
@retval EFI_DEVICE_ERROR An unexpected network or system error occurred.
@@ -1179,7 +1179,7 @@ HttpBootParseFilePath (
@retval EFI_INVALID_PARAMETER ImageType, Uri or UriParser is NULL.
@retval EFI_INVALID_PARAMETER HeaderCount is not zero, and Headers is NULL.
@retval EFI_NOT_FOUND Failed to identify the image type.
- @retval Others Unexpect error happened.
+ @retval Others Unexpected error happened.
**/
EFI_STATUS
--
2.21.0
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [edk2-devel] [PATCH 39/79] NetworkPkg/HttpBootDxe: Fix various typos
2019-12-03 16:15 ` [PATCH 39/79] NetworkPkg/HttpBootDxe: Fix various typos Philippe Mathieu-Daudé
@ 2019-12-04 13:53 ` Maciej Rabeda
0 siblings, 0 replies; 122+ messages in thread
From: Maciej Rabeda @ 2019-12-04 13:53 UTC (permalink / raw)
To: devel, philmd; +Cc: Antoine Coeur, Jiaxin Wu, Siyuan Fu, Maciej Rabeda
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
On 03-Dec-19 17:15, Philippe Mathieu-Daudé wrote:
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> NetworkPkg/HttpBootDxe/HttpBootDhcp4.h | 2 +-
> NetworkPkg/HttpBootDxe/HttpBootDhcp6.h | 4 ++--
> NetworkPkg/HttpBootDxe/HttpBootDxe.h | 6 +++---
> NetworkPkg/HttpBootDxe/HttpBootSupport.h | 10 +++++-----
> NetworkPkg/HttpBootDxe/HttpBootDhcp4.c | 2 +-
> NetworkPkg/HttpBootDxe/HttpBootDhcp6.c | 10 +++++-----
> NetworkPkg/HttpBootDxe/HttpBootDxe.c | 8 ++++----
> NetworkPkg/HttpBootDxe/HttpBootImpl.c | 2 +-
> NetworkPkg/HttpBootDxe/HttpBootSupport.c | 12 ++++++------
> 9 files changed, 28 insertions(+), 28 deletions(-)
>
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootDhcp4.h b/NetworkPkg/HttpBootDxe/HttpBootDhcp4.h
> index 2c2fa28302a3..74bbdac58e86 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootDhcp4.h
> +++ b/NetworkPkg/HttpBootDxe/HttpBootDhcp4.h
> @@ -41,7 +41,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>
> /// DHCP offer types among HTTP boot.
> /// Dhcp4 and Dhcp6 share this definition, and corresponding
> -/// relatioinship is as follows:
> +/// relationship is as follows:
> /// Dhcp4Discover <> Dhcp6Solicit
> /// Dhcp4Offer <> Dhcp6Advertise
> /// Dhcp4Request <> Dhcp6Request
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.h b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.h
> index e21f272aa1ac..e1a652031976 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.h
> +++ b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.h
> @@ -110,8 +110,8 @@ HttpBootDhcp6Sarr (
>
> @param[in] Private The pointer to HTTP_BOOT_PRIVATE_DATA.
>
> - @retval EFI_SUCCESS Switch the IP policy succesfully.
> - @retval Others Unexpect error happened.
> + @retval EFI_SUCCESS Switch the IP policy successfully.
> + @retval Others Unexpected error happened.
>
> **/
> EFI_STATUS
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootDxe.h b/NetworkPkg/HttpBootDxe/HttpBootDxe.h
> index 89b7d6aa702b..0b45f9de0bdb 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootDxe.h
> +++ b/NetworkPkg/HttpBootDxe/HttpBootDxe.h
> @@ -147,7 +147,7 @@ struct _HTTP_BOOT_PRIVATE_DATA {
> HTTP_BOOT_VIRTUAL_NIC *Ip6Nic;
>
> //
> - // Cousumed children
> + // Consumed children
> //
> EFI_HANDLE Ip6Child;
> EFI_HANDLE Dhcp4Child;
> @@ -348,7 +348,7 @@ HttpBootIp4DxeDriverBindingSupported (
> @retval EFI_SUCCESS The device was started.
> @retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
> @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
> - @retval Others The driver failded to start the device.
> + @retval Others The driver failed to start the device.
>
> **/
> EFI_STATUS
> @@ -476,7 +476,7 @@ HttpBootIp6DxeDriverBindingSupported (
> @retval EFI_SUCCESS The device was started.
> @retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
> @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
> - @retval Others The driver failded to start the device.
> + @retval Others The driver failed to start the device.
>
> **/
> EFI_STATUS
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootSupport.h b/NetworkPkg/HttpBootDxe/HttpBootSupport.h
> index 10f62f6ec31a..81d072ae3734 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootSupport.h
> +++ b/NetworkPkg/HttpBootDxe/HttpBootSupport.h
> @@ -98,7 +98,7 @@ typedef struct {
> /**
> Create a HTTP_IO_HEADER to hold the HTTP header items.
>
> - @param[in] MaxHeaderCount The maximun number of HTTP header in this holder.
> + @param[in] MaxHeaderCount The maximum number of HTTP header in this holder.
>
> @return A pointer of the HTTP header holder or NULL if failed.
>
> @@ -109,7 +109,7 @@ HttpBootCreateHeader (
> );
>
> /**
> - Destroy the HTTP_IO_HEADER and release the resouces.
> + Destroy the HTTP_IO_HEADER and release the resources.
>
> @param[in] HttpIoHeader Point to the HTTP header holder to be destroyed.
>
> @@ -300,7 +300,7 @@ HttpIoCreateIo (
> );
>
> /**
> - Destroy the HTTP_IO and release the resouces.
> + Destroy the HTTP_IO and release the resources.
>
> @param[in] HttpIo The HTTP_IO which wraps the HTTP service to be destroyed.
>
> @@ -320,7 +320,7 @@ HttpIoDestroyIo (
> @param[in] BodyLength Length in bytes of the HTTP body.
> @param[in] Body Body associated with the HTTP request.
>
> - @retval EFI_SUCCESS The HTTP request is trasmitted.
> + @retval EFI_SUCCESS The HTTP request is transmitted.
> @retval EFI_INVALID_PARAMETER One or more parameters are invalid.
> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory.
> @retval EFI_DEVICE_ERROR An unexpected network or system error occurred.
> @@ -406,7 +406,7 @@ HttpBootParseFilePath (
> @retval EFI_INVALID_PARAMETER ImageType, Uri or UriParser is NULL.
> @retval EFI_INVALID_PARAMETER HeaderCount is not zero, and Headers is NULL.
> @retval EFI_NOT_FOUND Failed to identify the image type.
> - @retval Others Unexpect error happened.
> + @retval Others Unexpected error happened.
>
> **/
> EFI_STATUS
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootDhcp4.c b/NetworkPkg/HttpBootDxe/HttpBootDhcp4.c
> index b5dd6e09567a..1da05dbf0e95 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootDhcp4.c
> +++ b/NetworkPkg/HttpBootDxe/HttpBootDhcp4.c
> @@ -94,7 +94,7 @@ HttpBootBuildDhcp4Options (
> OptEnt.Uuid->Type = 0;
> if (EFI_ERROR (NetLibGetSystemGuid ((EFI_GUID *) OptEnt.Uuid->Guid))) {
> //
> - // Zero the Guid to indicate NOT programable if failed to get system Guid.
> + // Zero the Guid to indicate NOT programmable if failed to get system Guid.
> //
> ZeroMem (OptEnt.Uuid->Guid, sizeof (EFI_GUID));
> }
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c
> index 8a1dd66ceec0..4905bca4ad19 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c
> +++ b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c
> @@ -126,7 +126,7 @@ HttpBootBuildDhcp6Options (
> @param[in] OptTag The required option tag.
>
> @retval NULL Failed to parse the required option.
> - @retval Others The postion of the required option in buffer.
> + @retval Others The position of the required option in buffer.
>
> **/
> EFI_DHCP6_PACKET_OPTION *
> @@ -225,7 +225,7 @@ HttpBootParseDhcp6Packet (
> }
> //
> // The offer with assigned client address is NOT a proxy offer.
> - // An ia_na option, embeded with valid ia_addr option and a status_code of success.
> + // An ia_na option, embedded with valid ia_addr option and a status_code of success.
> //
> Option = Options[HTTP_BOOT_DHCP6_IDX_IA_NA];
> if (Option != NULL) {
> @@ -514,7 +514,7 @@ HttpBootDhcp6CallBack (
>
> @retval EFI_SUCCESS Found a valid gateway address successfully.
> @retval EFI_TIMEOUT The operation is time out.
> - @retval Other Unexpect error happened.
> + @retval Other Unexpected error happened.
>
> **/
> EFI_STATUS
> @@ -628,8 +628,8 @@ ON_EXIT:
>
> @param[in] Private The pointer to HTTP_BOOT_PRIVATE_DATA.
>
> - @retval EFI_SUCCESS Switch the IP policy succesfully.
> - @retval Others Unexpect error happened.
> + @retval EFI_SUCCESS Switch the IP policy successfully.
> + @retval Others Unexpected error happened.
>
> **/
> EFI_STATUS
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootDxe.c b/NetworkPkg/HttpBootDxe/HttpBootDxe.c
> index 2efdd9be101a..5d9c24f4a22a 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootDxe.c
> +++ b/NetworkPkg/HttpBootDxe/HttpBootDxe.c
> @@ -382,7 +382,7 @@ HttpBootIp4DxeDriverBindingSupported (
> @retval EFI_SUCCESS The device was started.
> @retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
> @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
> - @retval Others The driver failded to start the device.
> + @retval Others The driver failed to start the device.
>
> **/
> EFI_STATUS
> @@ -720,7 +720,7 @@ HttpBootIp4DxeDriverBindingStop (
> }
>
> //
> - // Destory all child instance and uninstall protocol interface.
> + // Destroy all child instance and uninstall protocol interface.
> //
> HttpBootDestroyIp4Children (This, Private);
>
> @@ -871,7 +871,7 @@ HttpBootIp6DxeDriverBindingSupported (
> @retval EFI_SUCCESS The device was started.
> @retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
> @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
> - @retval Others The driver failded to start the device.
> + @retval Others The driver failed to start the device.
>
> **/
> EFI_STATUS
> @@ -1250,7 +1250,7 @@ HttpBootIp6DxeDriverBindingStop (
> }
>
> //
> - // Destory all child instance and uninstall protocol interface.
> + // Destroy all child instance and uninstall protocol interface.
> //
> HttpBootDestroyIp6Children (This, Private);
>
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootImpl.c b/NetworkPkg/HttpBootDxe/HttpBootImpl.c
> index 5eeb1ea2b4a7..4a51f35cddbe 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootImpl.c
> +++ b/NetworkPkg/HttpBootDxe/HttpBootImpl.c
> @@ -14,7 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @param[in] Private Pointer to HTTP Boot private data.
>
> - @retval EFI_SUCCESS HTTP Boot Callback Protocol installed succesfully.
> + @retval EFI_SUCCESS HTTP Boot Callback Protocol installed successfully.
> @retval Others Failed to install HTTP Boot Callback Protocol.
>
> **/
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootSupport.c b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> index 61814d3b64ff..5b0e054a05eb 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> +++ b/NetworkPkg/HttpBootDxe/HttpBootSupport.c
> @@ -494,7 +494,7 @@ Exit:
> /**
> Create a HTTP_IO_HEADER to hold the HTTP header items.
>
> - @param[in] MaxHeaderCount The maximun number of HTTP header in this holder.
> + @param[in] MaxHeaderCount The maximum number of HTTP header in this holder.
>
> @return A pointer of the HTTP header holder or NULL if failed.
>
> @@ -522,7 +522,7 @@ HttpBootCreateHeader (
> }
>
> /**
> - Destroy the HTTP_IO_HEADER and release the resouces.
> + Destroy the HTTP_IO_HEADER and release the resources.
>
> @param[in] HttpIoHeader Point to the HTTP header holder to be destroyed.
>
> @@ -765,7 +765,7 @@ HttpIoCreateIo (
> }
>
> //
> - // Create events for variuos asynchronous operations.
> + // Create events for various asynchronous operations.
> //
> Status = gBS->CreateEvent (
> EVT_NOTIFY_SIGNAL,
> @@ -817,7 +817,7 @@ ON_ERROR:
> }
>
> /**
> - Destroy the HTTP_IO and release the resouces.
> + Destroy the HTTP_IO and release the resources.
>
> @param[in] HttpIo The HTTP_IO which wraps the HTTP service to be destroyed.
>
> @@ -878,7 +878,7 @@ HttpIoDestroyIo (
> @param[in] BodyLength Length in bytes of the HTTP body.
> @param[in] Body Body associated with the HTTP request.
>
> - @retval EFI_SUCCESS The HTTP request is trasmitted.
> + @retval EFI_SUCCESS The HTTP request is transmitted.
> @retval EFI_INVALID_PARAMETER One or more parameters are invalid.
> @retval EFI_OUT_OF_RESOURCES Failed to allocate memory.
> @retval EFI_DEVICE_ERROR An unexpected network or system error occurred.
> @@ -1179,7 +1179,7 @@ HttpBootParseFilePath (
> @retval EFI_INVALID_PARAMETER ImageType, Uri or UriParser is NULL.
> @retval EFI_INVALID_PARAMETER HeaderCount is not zero, and Headers is NULL.
> @retval EFI_NOT_FOUND Failed to identify the image type.
> - @retval Others Unexpect error happened.
> + @retval Others Unexpected error happened.
>
> **/
> EFI_STATUS
^ permalink raw reply [flat|nested] 122+ messages in thread
* Re: [PATCH 00/79] Fix a bunch of typos (part 1)
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (38 preceding siblings ...)
2019-12-03 16:15 ` [PATCH 39/79] NetworkPkg/HttpBootDxe: Fix various typos Philippe Mathieu-Daudé
@ 2019-12-03 16:26 ` Cœur
[not found] ` <20191203161602.15969-61-philmd@redhat.com>
` (32 subsequent siblings)
72 siblings, 0 replies; 122+ messages in thread
From: Cœur @ 2019-12-03 16:26 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel, Achin Gupta, Andrew Fish,
Anthony Perard, Ard Biesheuvel, Chao Zhang, Chasel Chiu,
Eric Dong, Hao A Wu, Jian J Wang, Jiaxin Wu, Jiewen Yao,
Jordan Justen, Julien Grall, Laszlo Ersek, Leif Lindholm,
Liming Gao, Maciej Rabeda, Michael D Kinney, Nate DeSimone,
Ray Ni, Siyuan Fu, Star Zeng, Supreeth Venkatesh, Xiaoyu Lu,
Zhichao Gao
Woah, thank you for the work, Philippe.
Tell me if there is anything I can do to help.
Antoine
Le 04/12/2019 à 00:14, Philippe Mathieu-Daude a écrit :
> Around February of this year, Antoine posted various patches fixing
> a huge quantity of typos, over 8000+ lines (such [1]).
>
> The community merged the smaller patches, and told him his patches
> were too big, and he should split them.
> Around June, Antoine opened a GitHub pull request [2], due to the
> size of his patchset. We told him the project doesn't accept GitHub
> PR.
>
> Since I find his cleanup work very valuable for the project, I
> spent few hours trying to salvage a chunk of it, splitting per
> maintainer areas, each patch not to big to avoid reviewers burning
> out. I expect each maintainer to take his patches.
>
> I wanted to split Antoine work in 3 parts, but I'm about at 80
> patches, for only 1854 lines changed, so enough for a first round.
>
> Oh, and it is easier to review the patches using '--word-diff=color'
> git option :)
>
> Regards,
>
> Phil.
>
> P.D.: I think the project is really failing at getting new
> contributors involved, and keeping them. But that is another topic.
>
> [1] https://edk2.groups.io/g/devel/message/43043
> [2] https://edk2.groups.io/g/devel/message/42941
>
> Antoine Coeur (72):
> CryptoPkg/OpensslLib: Fix few typos
> EmbeddedPkg/FdtLib: Fix a typo
> EmbeddedPkg/VirtualKeyboard: Fix few typos
> EmulatorPkg/Sec: Fix various typos
> EmulatorPkg/Unix: Fix various typos
> EmulatorPkg/Win: Fix various typos
> FatPkg/EnhancedFatDxe: Fix various typos
> FatPkg/FatPei: Fix few typos
> IntelFsp2WrapperPkg: Fix various typos
> MdeModulePkg/Application: Improve French translation
> MdeModulePkg/Application: Fix various typos
> MdeModulePkg/Bus/Ata: Fix various typos
> MdeModulePkg/Bus/I2c: Fix few typos
> MdeModulePkg/Bus/Isa: Fix various typos
> MdeModulePkg/Bus/Scsi: Fix various typos
> MdeModulePkg/Bus/Sd: Fix various typos
> MdeModulePkg/Core/Pei: Fix various typos
> MdeModulePkg/Core/PiSmmCore: Fix various typos
> MdeModulePkg/UsbMass: Fix various typos
> MdeModulePkg/UsbMouse: Fix few typos
> MdeModulePkg/UsbBus: Fix various typos
> MdeModulePkg/Usb: Fix various typos
> MdePkg/IndustryStandard: Fix various typos
> MdePkg/Library/Dxe: Fix various typos
> MdePkg/Library/Pci: Fix various typos
> MdePkg/Library/Smm: Fix various typos
> MdePkg/Ppi: Fix various typos
> MdePkg/Register: Fix various typos
> NetworkPkg/ArpDxe: Fix various typos
> NetworkPkg/Dhcp4Dxe: Fix various typos
> NetworkPkg/Dhcp6Dxe: Fix various typos
> NetworkPkg/DnsDxe: Fix various typos
> NetworkPkg/DpcDxe: Fix few typos
> NetworkPkg/HttpBootDxe: Fix various typos
> NetworkPkg/HttpDxe: Fix various typos
> NetworkPkg/Ip4Dxe: Fix various typos
> NetworkPkg/Ip6Dxe: Fix various typos
> NetworkPkg/IScsiDxe: Fix various typos
> NetworkPkg/Library: Fix various typos
> NetworkPkg/MnpDxe: Fix various typos
> NetworkPkg/Mtftp4Dxe: Fix various typos
> NetworkPkg/Mtftp6Dxe: Fix various typos
> NetworkPkg/SnpDxe: Fix few typos
> NetworkPkg/TcpDxe/Sock: Fix few typos
> NetworkPkg/TcpDxe/Tcp: Fix various typos
> NetworkPkg/Tls: Fix few typos
> NetworkPkg/Udp4Dxe: Fix various typos
> NetworkPkg/Udp6Dxe: Fix various typos
> NetworkPkg/UefiPxeBcDxe: Fix various typos
> NetworkPkg/VlanConfigDxe: Fix few typos
> OvmfPkg/Acpi: Fix few typos
> OvmfPkg/Csm: Fix various typos
> OvmfPkg/Qemu: Fix various typos
> OvmfPkg/Virtio: Fix few typos
> OvmfPkg/Xen: Fix various typos
> PcAtChipsetPkg: Fix few typos
> SecurityPkg: Fix few typos
> SecurityPkg/Hash2DxeCrypto: Fix few typos
> SecurityPkg/Library/Tpm: Fix various typos
> SecurityPkg/Tcg: Fix various typos
> SecurityPkg/VariableAuthenticated: Fix few typos
> ShellPkg/Application: Fix various typos
> ShellPkg/DynamicCommand: Fix various typos
> SignedCapsulePkg: Fix various typos
> SignedCapsulePkg/Universal: Fix various typos
> SourceLevelDebugPkg/DebugAgent: Fix various typos
> SourceLevelDebugPkg/DebugCommunicationLib: Fix various typos
> SourceLevelDebugPkg: Fix few typos
> StandaloneMmPkg: Fix few typos
> UefiCpuPkg/CpuDxe: Fix few typos
> UefiCpuPkg/PiSmm: Fix various typos
> UefiCpuPkg/Smm: Fix various typos
>
> Philippe Mathieu-Daude (7):
> EmbeddedPkg/VirtualKeyboard: Fix a typo in EFI_INVALID_PARAMETER
> MdeModulePkg/UsbBusDxe: Fix a typo
> NetworkPkg: Fix a typo
> NetworkPkg/DnsDxe: Fix a typo
> NetworkPkg/HttpBootDxe: Fix a typo in variable name
> OvmfPkg/Xen: Fix a typo
> StandaloneMmPkg: Fix a typo
>
> SignedCapsulePkg/SignedCapsulePkg.dec | 4 +-
> MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf | 2 +-
> MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf | 2 +-
> MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf | 10 ++--
> MdePkg/Library/DxePcdLib/DxePcdLib.inf | 2 +-
> NetworkPkg/MnpDxe/MnpDxe.inf | 2 +-
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf | 2 +-
> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf | 4 +-
> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf | 4 +-
> SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf | 2 +-
> SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf | 2 +-
> SecurityPkg/Tcg/TcgSmm/TcgSmm.inf | 2 +-
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.inf | 2 +-
> StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf | 2 +-
> EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h | 36 +++++++-------
> EmbeddedPkg/Include/libfdt.h | 2 +-
> EmulatorPkg/Sec/Sec.h | 4 +-
> EmulatorPkg/Win/Host/WinGop.h | 2 +-
> EmulatorPkg/Win/Host/WinHost.h | 2 +-
> FatPkg/EnhancedFatDxe/Fat.h | 6 +--
> FatPkg/FatPei/FatLitePeim.h | 2 +-
> IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h | 2 +-
> IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h | 4 +-
> MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.h | 2 +-
> MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.h | 2 +-
> MdeModulePkg/Bus/Ata/AhciPei/AhciPei.h | 4 +-
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h | 4 +-
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.h | 4 +-
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.h | 2 +-
> MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h | 12 ++---
> MdeModulePkg/Bus/I2c/I2cDxe/I2cDxe.h | 4 +-
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 14 +++---
> MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.h | 2 +-
> MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.h | 2 +-
> MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.h | 4 +-
> MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 10 ++--
> MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.h | 2 +-
> MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h | 6 +--
> MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.h | 2 +-
> MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.h | 6 +--
> MdeModulePkg/Bus/Sd/SdDxe/SdDxe.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.h | 14 +++---
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h | 10 ++--
> MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h | 4 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.h | 4 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.h | 2 +-
> MdeModulePkg/Core/Pei/PeiMain.h | 20 ++++----
> MdeModulePkg/Core/PiSmmCore/HeapGuard.h | 2 +-
> MdeModulePkg/Core/PiSmmCore/PiSmmCore.h | 12 ++---
> MdeModulePkg/Core/PiSmmCore/PiSmmCorePrivateData.h | 6 +--
> MdePkg/Include/IndustryStandard/Acpi10.h | 4 +-
> MdePkg/Include/IndustryStandard/Acpi20.h | 4 +-
> MdePkg/Include/IndustryStandard/Acpi30.h | 4 +-
> MdePkg/Include/IndustryStandard/Acpi40.h | 2 +-
> MdePkg/Include/IndustryStandard/Acpi50.h | 6 +--
> MdePkg/Include/IndustryStandard/Acpi51.h | 4 +-
> MdePkg/Include/IndustryStandard/Acpi60.h | 4 +-
> MdePkg/Include/IndustryStandard/Acpi61.h | 4 +-
> MdePkg/Include/IndustryStandard/Acpi62.h | 8 +--
> MdePkg/Include/IndustryStandard/Atapi.h | 40 +++++++--------
> MdePkg/Include/IndustryStandard/ElTorito.h | 4 +-
> MdePkg/Include/IndustryStandard/Emmc.h | 2 +-
> MdePkg/Include/IndustryStandard/IpmiNetFnBridge.h | 4 +-
> MdePkg/Include/IndustryStandard/Nvme.h | 10 ++--
> MdePkg/Include/IndustryStandard/Pci22.h | 20 ++++----
> MdePkg/Include/IndustryStandard/PeImage.h | 2 +-
> MdePkg/Include/IndustryStandard/Scsi.h | 2 +-
> MdePkg/Include/IndustryStandard/SmBus.h | 2 +-
> MdePkg/Include/IndustryStandard/Tpm12.h | 2 +-
> MdePkg/Include/Library/DxeServicesLib.h | 2 +-
> MdePkg/Include/Library/PciCf8Lib.h | 4 +-
> MdePkg/Include/Library/PciExpressLib.h | 4 +-
> MdePkg/Include/Library/PciLib.h | 4 +-
> MdePkg/Include/Library/PciSegmentLib.h | 4 +-
> MdePkg/Include/Library/SmmLib.h | 4 +-
> MdePkg/Include/Library/SmmMemLib.h | 4 +-
> MdePkg/Include/Library/SmmPeriodicSmiLib.h | 6 +--
> MdePkg/Include/Ppi/BlockIo.h | 4 +-
> MdePkg/Include/Ppi/BlockIo2.h | 2 +-
> MdePkg/Include/Ppi/Capsule.h | 2 +-
> MdePkg/Include/Ppi/Decompress.h | 2 +-
> MdePkg/Include/Ppi/DeviceRecoveryModule.h | 2 +-
> MdePkg/Include/Ppi/IsaHc.h | 2 +-
> MdePkg/Include/Ppi/MpServices.h | 2 +-
> MdePkg/Include/Ppi/Pcd.h | 4 +-
> MdePkg/Include/Ppi/RecoveryModule.h | 2 +-
> MdePkg/Include/Ppi/TemporaryRamDone.h | 2 +-
> MdePkg/Include/Ppi/VectorHandoffInfo.h | 2 +-
> MdePkg/Include/Register/Amd/Cpuid.h | 8 +--
> MdePkg/Include/Register/Amd/Fam17Msr.h | 2 +-
> MdePkg/Include/Register/Amd/Msr.h | 2 +-
> MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h | 2 +-
> MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h | 2 +-
> MdePkg/Include/Register/Intel/StmResourceDescriptor.h | 2 +-
> NetworkPkg/ArpDxe/ArpDriver.h | 10 ++--
> NetworkPkg/ArpDxe/ArpImpl.h | 14 +++---
> NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h | 4 +-
> NetworkPkg/Dhcp4Dxe/Dhcp4Io.h | 2 +-
> NetworkPkg/Dhcp4Dxe/Dhcp4Option.h | 18 +++----
> NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h | 4 +-
> NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h | 12 ++---
> NetworkPkg/DnsDxe/DnsDriver.h | 12 ++---
> NetworkPkg/DnsDxe/DnsImpl.h | 28 +++++------
> NetworkPkg/DpcDxe/Dpc.h | 2 +-
> NetworkPkg/HttpBootDxe/HttpBootConfig.h | 2 +-
> NetworkPkg/HttpBootDxe/HttpBootDhcp4.h | 2 +-
> NetworkPkg/HttpBootDxe/HttpBootDhcp6.h | 4 +-
> NetworkPkg/HttpBootDxe/HttpBootDxe.h | 6 +--
> NetworkPkg/HttpBootDxe/HttpBootSupport.h | 10 ++--
> NetworkPkg/HttpDxe/HttpDriver.h | 8 +--
> NetworkPkg/HttpDxe/HttpProto.h | 16 +++---
> NetworkPkg/HttpDxe/HttpsSupport.h | 2 +-
> NetworkPkg/IScsiDxe/IScsiMisc.h | 8 +--
> NetworkPkg/IScsiDxe/IScsiProto.h | 10 ++--
> NetworkPkg/Include/Library/HttpLib.h | 2 +-
> NetworkPkg/Include/Library/IpIoLib.h | 4 +-
> NetworkPkg/Include/Library/NetLib.h | 2 +-
> NetworkPkg/Include/Library/TcpIoLib.h | 6 +--
> NetworkPkg/Include/Library/UdpIoLib.h | 6 +--
> NetworkPkg/Include/Protocol/Dpc.h | 2 +-
> NetworkPkg/Ip4Dxe/Ip4Common.h | 14 +++---
> NetworkPkg/Ip4Dxe/Ip4Config2Impl.h | 2 +-
> NetworkPkg/Ip4Dxe/Ip4Driver.h | 6 +--
> NetworkPkg/Ip4Dxe/Ip4Icmp.h | 10 ++--
> NetworkPkg/Ip4Dxe/Ip4If.h | 4 +-
> NetworkPkg/Ip4Dxe/Ip4Igmp.h | 4 +-
> NetworkPkg/Ip4Dxe/Ip4Impl.h | 8 +--
> NetworkPkg/Ip4Dxe/Ip4Input.h | 6 +--
> NetworkPkg/Ip4Dxe/Ip4Option.h | 4 +-
> NetworkPkg/Ip4Dxe/Ip4Output.h | 4 +-
> NetworkPkg/Ip4Dxe/Ip4Route.h | 12 ++---
> NetworkPkg/Ip6Dxe/Ip6ConfigImpl.h | 4 +-
> NetworkPkg/Ip6Dxe/Ip6Driver.h | 8 +--
> NetworkPkg/Ip6Dxe/Ip6Icmp.h | 4 +-
> NetworkPkg/Ip6Dxe/Ip6If.h | 4 +-
> NetworkPkg/Ip6Dxe/Ip6Impl.h | 8 +--
> NetworkPkg/Ip6Dxe/Ip6Input.h | 6 +--
> NetworkPkg/Ip6Dxe/Ip6Mld.h | 2 +-
> NetworkPkg/Ip6Dxe/Ip6Nd.h | 4 +-
> NetworkPkg/Ip6Dxe/Ip6Route.h | 10 ++--
> NetworkPkg/MnpDxe/MnpDriver.h | 6 +--
> NetworkPkg/MnpDxe/MnpImpl.h | 14 +++---
> NetworkPkg/Mtftp4Dxe/Mtftp4Driver.h | 2 +-
> NetworkPkg/Mtftp4Dxe/Mtftp4Impl.h | 2 +-
> NetworkPkg/Mtftp4Dxe/Mtftp4Option.h | 6 +--
> NetworkPkg/Mtftp4Dxe/Mtftp4Support.h | 2 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Driver.h | 4 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Impl.h | 4 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Option.h | 2 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Support.h | 2 +-
> NetworkPkg/SnpDxe/Snp.h | 8 +--
> NetworkPkg/TcpDxe/SockImpl.h | 2 +-
> NetworkPkg/TcpDxe/Socket.h | 36 +++++++-------
> NetworkPkg/TcpDxe/TcpDriver.h | 8 +--
> NetworkPkg/TcpDxe/TcpFunc.h | 4 +-
> NetworkPkg/TcpDxe/TcpMain.h | 4 +-
> NetworkPkg/TcpDxe/TcpOption.h | 6 +--
> NetworkPkg/TcpDxe/TcpProto.h | 14 +++---
> NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h | 2 +-
> NetworkPkg/TlsDxe/TlsDriver.h | 4 +-
> NetworkPkg/Udp4Dxe/Udp4Driver.h | 4 +-
> NetworkPkg/Udp4Dxe/Udp4Impl.h | 4 +-
> NetworkPkg/Udp6Dxe/Udp6Driver.h | 6 +--
> NetworkPkg/Udp6Dxe/Udp6Impl.h | 12 ++---
> NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.h | 2 +-
> NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h | 8 +--
> NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h | 4 +-
> NetworkPkg/UefiPxeBcDxe/PxeBcSupport.h | 16 +++---
> NetworkPkg/VlanConfigDxe/VlanConfigImpl.h | 6 +--
> OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h | 10 ++--
> OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h | 8 +--
> OvmfPkg/Csm/Include/Framework/BootScript.h | 2 +-
> OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h | 2 +-
> OvmfPkg/Csm/Include/Protocol/IsaAcpi.h | 2 +-
> OvmfPkg/Csm/Include/Protocol/IsaIo.h | 2 +-
> OvmfPkg/Csm/Include/Protocol/LegacyBios.h | 6 +--
> OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h | 4 +-
> OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h | 2 +-
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h | 8 +--
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h | 4 +-
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h | 2 +-
> OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h | 2 +-
> OvmfPkg/Include/IndustryStandard/Xen/grant_table.h | 4 +-
> OvmfPkg/Include/IndustryStandard/Xen/io/blkif.h | 2 +-
> OvmfPkg/Include/Library/VirtioLib.h | 2 +-
> OvmfPkg/Include/Protocol/XenBus.h | 4 +-
> OvmfPkg/Include/Protocol/XenIo.h | 2 +-
> OvmfPkg/XenBusDxe/DriverBinding.h | 2 +-
> OvmfPkg/XenBusDxe/EventChannel.h | 2 +-
> OvmfPkg/XenBusDxe/GrantTable.h | 4 +-
> OvmfPkg/XenPvBlkDxe/BlockIo.h | 6 +--
> OvmfPkg/XenPvBlkDxe/DriverBinding.h | 2 +-
> SecurityPkg/Include/Library/TcgStorageCoreLib.h | 4 +-
> SecurityPkg/Include/Library/TpmCommLib.h | 4 +-
> SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h | 6 +--
> ShellPkg/Application/Shell/ConsoleLogger.h | 4 +-
> ShellPkg/Application/Shell/FileHandleWrappers.h | 6 +--
> ShellPkg/Application/Shell/Shell.h | 2 +-
> ShellPkg/Application/Shell/ShellEnvVar.h | 36 +++++++-------
> ShellPkg/Application/Shell/ShellManParser.h | 10 ++--
> ShellPkg/Application/Shell/ShellParametersProtocol.h | 20 ++++----
> ShellPkg/Application/Shell/ShellProtocol.h | 12 ++---
> ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h | 2 +-
> ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.h | 2 +-
> SignedCapsulePkg/Include/Guid/EdkiiSystemFmpCapsule.h | 4 +-
> SignedCapsulePkg/Include/Library/IniParsingLib.h | 14 +++---
> SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h | 2 +-
> SourceLevelDebugPkg/Include/Ia32/ProcessorContext.h | 2 +-
> SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h | 2 +-
> SourceLevelDebugPkg/Include/TransferProtocol.h | 6 +--
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h | 6 +--
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/ArchDebugSupport.h | 2 +-
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/DebugException.h | 2 +-
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/ArchDebugSupport.h | 2 +-
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/DebugException.h | 2 +-
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Internal.h | 4 +-
> UefiCpuPkg/CpuDxe/CpuDxe.h | 2 +-
> UefiCpuPkg/CpuDxe/CpuGdt.h | 2 +-
> UefiCpuPkg/CpuDxe/CpuMp.h | 4 +-
> UefiCpuPkg/CpuDxe/CpuPageTable.h | 2 +-
> UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h | 4 +-
> UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h | 4 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 12 ++---
> NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigVfr.vfr | 6 +--
> CryptoPkg/Library/OpensslLib/rand_pool.c | 8 +--
> CryptoPkg/Library/OpensslLib/rand_pool_noise.c | 2 +-
> EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c | 16 +++---
> EmulatorPkg/Sec/Sec.c | 5 +-
> EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 2 +-
> EmulatorPkg/Unix/Host/BlockIo.c | 12 ++---
> EmulatorPkg/Unix/Host/EmuThunk.c | 2 +-
> EmulatorPkg/Unix/Host/Host.c | 26 +++++-----
> EmulatorPkg/Unix/Host/LinuxPacketFilter.c | 2 +-
> EmulatorPkg/Unix/Host/Pthreads.c | 2 +-
> EmulatorPkg/Win/Host/WinBlockIo.c | 4 +-
> EmulatorPkg/Win/Host/WinFileSystem.c | 2 +-
> EmulatorPkg/Win/Host/WinGopInput.c | 4 +-
> EmulatorPkg/Win/Host/WinGopScreen.c | 14 +++---
> EmulatorPkg/Win/Host/WinHost.c | 10 ++--
> FatPkg/EnhancedFatDxe/Delete.c | 2 +-
> FatPkg/EnhancedFatDxe/DirectoryManage.c | 2 +-
> FatPkg/EnhancedFatDxe/Fat.c | 2 +-
> FatPkg/EnhancedFatDxe/FileName.c | 2 +-
> FatPkg/EnhancedFatDxe/FileSpace.c | 6 +--
> FatPkg/EnhancedFatDxe/Flush.c | 4 +-
> FatPkg/FatPei/FatLiteApi.c | 2 +-
> FatPkg/FatPei/Mbr.c | 2 +-
> IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 2 +-
> IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c | 4 +-
> IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c | 4 +-
> MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 2 +-
> MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 4 +-
> MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c | 2 +-
> MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c | 2 +-
> MdeModulePkg/Bus/Ata/AhciPei/AhciMode.c | 8 +--
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 14 +++---
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c | 8 +--
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c | 16 +++---
> MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c | 10 ++--
> MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c | 4 +-
> MdeModulePkg/Bus/I2c/I2cDxe/I2cBus.c | 4 +-
> MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c | 2 +-
> MdeModulePkg/Bus/Isa/IsaBusDxe/IsaBusDxe.c | 6 +--
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 16 +++---
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c | 20 ++++----
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c | 4 +-
> MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.c | 2 +-
> MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.c | 4 +-
> MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 6 +--
> MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 32 ++++++------
> MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c | 2 +-
> MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c | 12 ++---
> MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c | 12 ++---
> MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.c | 2 +-
> MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c | 2 +-
> MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHci.c | 6 +--
> MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 10 ++--
> MdeModulePkg/Bus/Sd/SdDxe/SdDxe.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbBotPei/BotPeim.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c | 12 ++---
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c | 4 +-
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c | 8 +--
> MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusPei/UsbIoPeim.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c | 8 +--
> MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c | 6 +--
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c | 4 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.c | 4 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.c | 4 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c | 4 +-
> MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/MouseHid.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c | 2 +-
> MdeModulePkg/Core/Pei/Dependency/Dependency.c | 4 +-
> MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 28 +++++------
> MdeModulePkg/Core/Pei/FwVol/FwVol.c | 8 +--
> MdeModulePkg/Core/Pei/Hob/Hob.c | 2 +-
> MdeModulePkg/Core/Pei/Image/Image.c | 8 +--
> MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 10 ++--
> MdeModulePkg/Core/Pei/PeiMain/PeiMain.c | 4 +-
> MdeModulePkg/Core/Pei/Ppi/Ppi.c | 2 +-
> MdeModulePkg/Core/Pei/Security/Security.c | 2 +-
> MdeModulePkg/Core/PiSmmCore/Dependency.c | 4 +-
> MdeModulePkg/Core/PiSmmCore/Dispatcher.c | 24 ++++-----
> MdeModulePkg/Core/PiSmmCore/HeapGuard.c | 4 +-
> MdeModulePkg/Core/PiSmmCore/Locate.c | 8 +--
> MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c | 8 +--
> MdeModulePkg/Core/PiSmmCore/Page.c | 4 +-
> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 10 ++--
> MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 8 +--
> MdeModulePkg/Core/PiSmmCore/Smi.c | 2 +-
> MdeModulePkg/Core/PiSmmCore/SmramProfileRecord.c | 4 +-
> MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.c | 10 ++--
> MdePkg/Library/DxeHobLib/HobLib.c | 2 +-
> MdePkg/Library/DxeIoLibCpuIo2/IoLib.c | 2 +-
> MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.c | 6 +--
> MdePkg/Library/DxeServicesLib/DxeServicesLib.c | 12 ++---
> MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.c | 2 +-
> MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c | 2 +-
> MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePciSegmentLib.c | 2 +-
> MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c | 4 +-
> MdePkg/Library/SmmMemLib/SmmMemLib.c | 4 +-
> MdePkg/Library/SmmPciExpressLib/PciExpressLib.c | 4 +-
> MdePkg/Library/SmmPciLibPciRootBridgeIo/PciLib.c | 6 +--
> MdePkg/Library/SmmPeriodicSmiLib/SmmPeriodicSmiLib.c | 42 ++++++++--------
> MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.c | 2 +-
> NetworkPkg/ArpDxe/ArpDriver.c | 14 +++---
> NetworkPkg/ArpDxe/ArpImpl.c | 16 +++---
> NetworkPkg/ArpDxe/ArpMain.c | 10 ++--
> NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c | 8 +--
> NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c | 6 +--
> NetworkPkg/Dhcp4Dxe/Dhcp4Io.c | 12 ++---
> NetworkPkg/Dhcp4Dxe/Dhcp4Option.c | 26 +++++-----
> NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c | 12 ++---
> NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c | 12 ++---
> NetworkPkg/Dhcp6Dxe/Dhcp6Io.c | 26 +++++-----
> NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c | 16 +++---
> NetworkPkg/DnsDxe/DnsDriver.c | 12 ++---
> NetworkPkg/DnsDxe/DnsImpl.c | 28 +++++------
> NetworkPkg/DnsDxe/DnsProtocol.c | 16 +++---
> NetworkPkg/DpcDxe/Dpc.c | 6 +--
> NetworkPkg/HttpBootDxe/HttpBootConfig.c | 4 +-
> NetworkPkg/HttpBootDxe/HttpBootDhcp4.c | 2 +-
> NetworkPkg/HttpBootDxe/HttpBootDhcp6.c | 10 ++--
> NetworkPkg/HttpBootDxe/HttpBootDxe.c | 8 +--
> NetworkPkg/HttpBootDxe/HttpBootImpl.c | 2 +-
> NetworkPkg/HttpBootDxe/HttpBootSupport.c | 12 ++---
> NetworkPkg/HttpDxe/HttpDriver.c | 12 ++---
> NetworkPkg/HttpDxe/HttpImpl.c | 10 ++--
> NetworkPkg/HttpDxe/HttpProto.c | 22 ++++-----
> NetworkPkg/HttpDxe/HttpsSupport.c | 2 +-
> NetworkPkg/IScsiDxe/ComponentName.c | 2 +-
> NetworkPkg/IScsiDxe/IScsiCHAP.c | 4 +-
> NetworkPkg/IScsiDxe/IScsiConfig.c | 6 +--
> NetworkPkg/IScsiDxe/IScsiDhcp.c | 4 +-
> NetworkPkg/IScsiDxe/IScsiDriver.c | 10 ++--
> NetworkPkg/IScsiDxe/IScsiMisc.c | 6 +--
> NetworkPkg/IScsiDxe/IScsiProto.c | 40 +++++++--------
> NetworkPkg/Ip4Dxe/Ip4Common.c | 10 ++--
> NetworkPkg/Ip4Dxe/Ip4Config2Impl.c | 10 ++--
> NetworkPkg/Ip4Dxe/Ip4Config2Nv.c | 4 +-
> NetworkPkg/Ip4Dxe/Ip4Driver.c | 10 ++--
> NetworkPkg/Ip4Dxe/Ip4Icmp.c | 2 +-
> NetworkPkg/Ip4Dxe/Ip4If.c | 14 +++---
> NetworkPkg/Ip4Dxe/Ip4Igmp.c | 8 +--
> NetworkPkg/Ip4Dxe/Ip4Impl.c | 14 +++---
> NetworkPkg/Ip4Dxe/Ip4Input.c | 28 +++++------
> NetworkPkg/Ip4Dxe/Ip4Option.c | 4 +-
> NetworkPkg/Ip4Dxe/Ip4Output.c | 12 ++---
> NetworkPkg/Ip4Dxe/Ip4Route.c | 14 +++---
> NetworkPkg/Ip6Dxe/Ip6Common.c | 2 +-
> NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c | 10 ++--
> NetworkPkg/Ip6Dxe/Ip6ConfigNv.c | 6 +--
> NetworkPkg/Ip6Dxe/Ip6Driver.c | 12 ++---
> NetworkPkg/Ip6Dxe/Ip6Icmp.c | 6 +--
> NetworkPkg/Ip6Dxe/Ip6If.c | 10 ++--
> NetworkPkg/Ip6Dxe/Ip6Impl.c | 10 ++--
> NetworkPkg/Ip6Dxe/Ip6Input.c | 20 ++++----
> NetworkPkg/Ip6Dxe/Ip6Mld.c | 8 +--
> NetworkPkg/Ip6Dxe/Ip6Nd.c | 12 ++---
> NetworkPkg/Ip6Dxe/Ip6Output.c | 2 +-
> NetworkPkg/Ip6Dxe/Ip6Route.c | 6 +--
> NetworkPkg/Library/DxeHttpLib/DxeHttpLib.c | 4 +-
> NetworkPkg/Library/DxeIpIoLib/DxeIpIoLib.c | 16 +++---
> NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 26 +++++-----
> NetworkPkg/Library/DxeNetLib/NetBuffer.c | 4 +-
> NetworkPkg/Library/DxeTcpIoLib/DxeTcpIoLib.c | 10 ++--
> NetworkPkg/Library/DxeUdpIoLib/DxeUdpIoLib.c | 10 ++--
> NetworkPkg/MnpDxe/MnpConfig.c | 14 +++---
> NetworkPkg/MnpDxe/MnpDriver.c | 10 ++--
> NetworkPkg/MnpDxe/MnpIo.c | 8 +--
> NetworkPkg/MnpDxe/MnpMain.c | 6 +--
> NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c | 4 +-
> NetworkPkg/Mtftp4Dxe/Mtftp4Impl.c | 10 ++--
> NetworkPkg/Mtftp4Dxe/Mtftp4Option.c | 20 ++++----
> NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c | 10 ++--
> NetworkPkg/Mtftp4Dxe/Mtftp4Support.c | 6 +--
> NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c | 8 +--
> NetworkPkg/Mtftp6Dxe/Mtftp6Driver.c | 4 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Impl.c | 4 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Option.c | 4 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c | 10 ++--
> NetworkPkg/Mtftp6Dxe/Mtftp6Support.c | 8 +--
> NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c | 4 +-
> NetworkPkg/SnpDxe/Callback.c | 2 +-
> NetworkPkg/SnpDxe/Shutdown.c | 2 +-
> NetworkPkg/SnpDxe/Snp.c | 6 +--
> NetworkPkg/SnpDxe/WaitForPacket.c | 2 +-
> NetworkPkg/TcpDxe/SockImpl.c | 4 +-
> NetworkPkg/TcpDxe/SockInterface.c | 10 ++--
> NetworkPkg/TcpDxe/TcpDispatcher.c | 6 +--
> NetworkPkg/TcpDxe/TcpDriver.c | 10 ++--
> NetworkPkg/TcpDxe/TcpInput.c | 8 +--
> NetworkPkg/TcpDxe/TcpMain.c | 4 +-
> NetworkPkg/TcpDxe/TcpMisc.c | 2 +-
> NetworkPkg/TcpDxe/TcpOption.c | 2 +-
> NetworkPkg/TcpDxe/TcpOutput.c | 4 +-
> NetworkPkg/TcpDxe/TcpTimer.c | 2 +-
> NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 6 +--
> NetworkPkg/TlsDxe/TlsDriver.c | 4 +-
> NetworkPkg/Udp4Dxe/Udp4Driver.c | 4 +-
> NetworkPkg/Udp4Dxe/Udp4Impl.c | 12 ++---
> NetworkPkg/Udp4Dxe/Udp4Main.c | 4 +-
> NetworkPkg/Udp6Dxe/Udp6Driver.c | 8 +--
> NetworkPkg/Udp6Dxe/Udp6Impl.c | 18 +++----
> NetworkPkg/Udp6Dxe/Udp6Main.c | 12 ++---
> NetworkPkg/UefiPxeBcDxe/PxeBcBoot.c | 4 +-
> NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c | 10 ++--
> NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c | 18 +++----
> NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c | 4 +-
> NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c | 10 ++--
> NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c | 12 ++---
> NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c | 8 +--
> NetworkPkg/VlanConfigDxe/VlanConfigDriver.c | 8 +--
> OvmfPkg/AcpiPlatformDxe/BootScript.c | 2 +-
> OvmfPkg/AcpiPlatformDxe/Qemu.c | 4 +-
> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 2 +-
> OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c | 4 +-
> OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c | 6 +--
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 6 +--
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c | 4 +-
> OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c | 8 +--
> OvmfPkg/Csm/LegacyBiosDxe/Thunk.c | 4 +-
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c | 14 +++---
> OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c | 18 +++----
> OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c | 4 +-
> OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 4 +-
> OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c | 2 +-
> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c | 2 +-
> OvmfPkg/Library/VirtioLib/VirtioLib.c | 2 +-
> OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c | 6 +--
> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbInfo.c | 4 +-
> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c | 8 +--
> OvmfPkg/QemuVideoDxe/Driver.c | 2 +-
> OvmfPkg/VirtioNetDxe/DriverBinding.c | 2 +-
> OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c | 2 +-
> OvmfPkg/VirtioRngDxe/VirtioRng.c | 2 +-
> OvmfPkg/VirtioScsiDxe/VirtioScsi.c | 2 +-
> OvmfPkg/XenBusDxe/XenBus.c | 2 +-
> OvmfPkg/XenBusDxe/XenBusDxe.c | 6 +--
> OvmfPkg/XenBusDxe/XenStore.c | 4 +-
> OvmfPkg/XenPvBlkDxe/BlockFront.c | 2 +-
> OvmfPkg/XenPvBlkDxe/BlockIo.c | 8 +--
> OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.c | 2 +-
> PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c | 2 +-
> PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c | 6 +--
> SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c | 2 +-
> SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c | 2 +-
> SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c | 2 +-
> SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c | 2 +-
> SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.c | 2 +-
> SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c | 2 +-
> SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c | 2 +-
> SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c | 2 +-
> SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c | 4 +-
> SecurityPkg/Library/Tpm2CommandLib/Tpm2Miscellaneous.c | 2 +-
> SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 4 +-
> SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c | 6 +--
> SecurityPkg/Library/TpmCommLib/TisPc.c | 2 +-
> SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c | 2 +-
> SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.c | 2 +-
> SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c | 10 ++--
> SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 2 +-
> SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c | 8 +--
> SecurityPkg/Tcg/PhysicalPresencePei/PhysicalPresencePei.c | 2 +-
> SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c | 2 +-
> SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 +-
> SecurityPkg/Tcg/TcgPei/TcgPei.c | 8 +--
> SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigFileExplorer.c | 2 +-
> SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c | 2 +-
> ShellPkg/Application/Shell/ConsoleLogger.c | 12 ++---
> ShellPkg/Application/Shell/ConsoleWrappers.c | 2 +-
> ShellPkg/Application/Shell/FileHandleWrappers.c | 8 +--
> ShellPkg/Application/Shell/Shell.c | 8 +--
> ShellPkg/Application/Shell/ShellEnvVar.c | 8 +--
> ShellPkg/Application/Shell/ShellManParser.c | 20 ++++----
> ShellPkg/Application/Shell/ShellParametersProtocol.c | 26 +++++-----
> ShellPkg/Application/Shell/ShellProtocol.c | 36 +++++++-------
> ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 4 +-
> ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.c | 2 +-
> ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.c | 4 +-
> ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c | 4 +-
> ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 8 +--
> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.c | 2 +-
> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.c | 4 +-
> SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c | 26 +++++-----
> SignedCapsulePkg/Universal/RecoveryModuleLoadPei/ParseConfigProfile.c | 2 +-
> SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.c | 14 +++---
> SignedCapsulePkg/Universal/SystemFirmwareUpdate/ParseConfigProfile.c | 2 +-
> SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c | 4 +-
> SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.c | 8 +--
> SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c | 4 +-
> SourceLevelDebugPkg/DebugAgentDxe/DebugAgentDxe.c | 2 +-
> SourceLevelDebugPkg/DebugAgentPei/DebugAgentPei.c | 2 +-
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c | 52 ++++++++++----------
> SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/DxeDebugAgentLib.c | 2 +-
> SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c | 6 +--
> SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c | 10 ++--
> SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebugAgentLib.c | 10 ++--
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.c | 2 +-
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Common.c | 2 +-
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Dxe.c | 2 +-
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Transfer.c | 4 +-
> StandaloneMmPkg/Core/Dependency.c | 2 +-
> StandaloneMmPkg/Core/Dispatcher.c | 2 +-
> StandaloneMmPkg/Core/FwVol.c | 2 +-
> StandaloneMmPkg/Core/StandaloneMmCore.c | 2 +-
> UefiCpuPkg/CpuDxe/CpuDxe.c | 8 +--
> UefiCpuPkg/CpuDxe/CpuGdt.c | 2 +-
> UefiCpuPkg/CpuDxe/CpuMp.c | 4 +-
> UefiCpuPkg/CpuDxe/CpuPageTable.c | 6 +--
> UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c | 4 +-
> UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c | 2 +-
> UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 4 +-
> UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c | 4 +-
> UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c | 2 +-
> UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 4 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 4 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 6 +--
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c | 2 +-
> EmulatorPkg/Sec/Ia32/SwitchRam.S | 18 +++----
> EmulatorPkg/Sec/Ia32/SwitchRam.asm | 20 ++++----
> EmulatorPkg/Sec/X64/SwitchRam.S | 2 +-
> EmulatorPkg/Sec/X64/SwitchRam.asm | 2 +-
> EmulatorPkg/Unix/GdbRun.sh | 4 +-
> EmulatorPkg/Unix/Host/X64/Gasket.S | 4 +-
> EmulatorPkg/Unix/Host/X64/SwitchStack.S | 2 +-
> EmulatorPkg/Unix/lldbefi.py | 14 +++---
> IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nasm | 6 +--
> IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/SecEntry.nasm | 2 +-
> IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Stack.nasm | 2 +-
> MdeModulePkg/Application/UiApp/FrontPageStrings.uni | 6 +--
> MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.uni | 2 +-
> MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.uni | 2 +-
> MdePkg/Library/DxePcdLib/DxePcdLib.uni | 2 +-
> NetworkPkg/MnpDxe/MnpDxe.uni | 4 +-
> OvmfPkg/AcpiTables/Facp.aslc | 8 +--
> OvmfPkg/AcpiTables/Facs.aslc | 4 +-
> OvmfPkg/AcpiTables/Madt.aslc | 2 +-
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni | 8 +--
> OvmfPkg/QemuVideoDxe/VbeShim.asm | 14 +++---
> SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.uni | 4 +-
> SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.uni | 2 +-
> SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.uni | 2 +-
> SecurityPkg/Tcg/TcgSmm/TcgSmm.uni | 2 +-
> ShellPkg/Application/ShellCTestApp/README.txt | 2 +-
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/AsmFuncs.nasm | 4 +-
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.uni | 2 +-
> UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm | 2 +-
> 587 files changed, 1853 insertions(+), 1854 deletions(-)
>
^ permalink raw reply [flat|nested] 122+ messages in thread[parent not found: <20191203161602.15969-61-philmd@redhat.com>]
* Re: [PATCH 60/79] OvmfPkg/Xen: Fix a typo
[not found] ` <20191203161602.15969-61-philmd@redhat.com>
@ 2019-12-03 16:45 ` Anthony PERARD
2019-12-03 21:05 ` Laszlo Ersek
1 sibling, 0 replies; 122+ messages in thread
From: Anthony PERARD @ 2019-12-03 16:45 UTC (permalink / raw)
To: Philippe Mathieu-Daude
Cc: devel, Antoine Cœur, Jordan Justen, Laszlo Ersek,
Ard Biesheuvel, Julien Grall
On Tue, Dec 03, 2019 at 05:15:43PM +0100, Philippe Mathieu-Daude wrote:
> Fix a typo in a comment.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien@xen.org>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks,
--
Anthony PERARD
^ permalink raw reply [flat|nested] 122+ messages in thread* Re: [PATCH 60/79] OvmfPkg/Xen: Fix a typo
[not found] ` <20191203161602.15969-61-philmd@redhat.com>
2019-12-03 16:45 ` [PATCH 60/79] OvmfPkg/Xen: Fix a typo Anthony PERARD
@ 2019-12-03 21:05 ` Laszlo Ersek
1 sibling, 0 replies; 122+ messages in thread
From: Laszlo Ersek @ 2019-12-03 21:05 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel
Cc: Antoine Cœur, Jordan Justen, Ard Biesheuvel, Anthony Perard,
Julien Grall
On 12/03/19 17:15, Philippe Mathieu-Daude wrote:
> Fix a typo in a comment.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien@xen.org>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> OvmfPkg/XenBusDxe/GrantTable.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/XenBusDxe/GrantTable.h b/OvmfPkg/XenBusDxe/GrantTable.h
> index 0d8434d1fe76..2cc889b6433f 100644
> --- a/OvmfPkg/XenBusDxe/GrantTable.h
> +++ b/OvmfPkg/XenBusDxe/GrantTable.h
> @@ -27,7 +27,7 @@ XenGrantTableInit (
> );
>
> /**
> - Desinitilize the Grant Table.
> + De-initialize the Grant Table.
> **/
> VOID
> XenGrantTableDeinit (
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-62-philmd@redhat.com>]
* Re: [PATCH 61/79] OvmfPkg/Xen: Fix various typos
[not found] ` <20191203161602.15969-62-philmd@redhat.com>
@ 2019-12-03 16:56 ` Anthony PERARD
2019-12-03 21:06 ` Laszlo Ersek
2019-12-04 3:39 ` Cœur
0 siblings, 2 replies; 122+ messages in thread
From: Anthony PERARD @ 2019-12-03 16:56 UTC (permalink / raw)
To: Philippe Mathieu-Daude
Cc: devel, Antoine Coeur, Jordan Justen, Laszlo Ersek, Ard Biesheuvel,
Julien Grall
On Tue, Dec 03, 2019 at 05:15:44PM +0100, Philippe Mathieu-Daude wrote:
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien@xen.org>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
There's seems to be missing SoB from Antoine. Could that be added?
I might try to send the part of this patch that modify the Xen public
headers upstream (the headers in IndustryStandard/Xen).
Otherwise, the patch looks fine.
Thanks,
--
Anthony PERARD
^ permalink raw reply [flat|nested] 122+ messages in thread* Re: [PATCH 61/79] OvmfPkg/Xen: Fix various typos
2019-12-03 16:56 ` [PATCH 61/79] OvmfPkg/Xen: Fix various typos Anthony PERARD
@ 2019-12-03 21:06 ` Laszlo Ersek
2019-12-04 3:39 ` Cœur
1 sibling, 0 replies; 122+ messages in thread
From: Laszlo Ersek @ 2019-12-03 21:06 UTC (permalink / raw)
To: Anthony PERARD, Philippe Mathieu-Daude
Cc: devel, Antoine Coeur, Jordan Justen, Ard Biesheuvel, Julien Grall
On 12/03/19 17:56, Anthony PERARD wrote:
> On Tue, Dec 03, 2019 at 05:15:44PM +0100, Philippe Mathieu-Daude wrote:
>> From: Antoine Coeur <coeur@gmx.fr>
>>
>> Fix various typos in comments and documentation.
>>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Anthony Perard <anthony.perard@citrix.com>
>> Cc: Julien Grall <julien@xen.org>
>> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
>> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
>
> There's seems to be missing SoB from Antoine. Could that be added?
>
> I might try to send the part of this patch that modify the Xen public
> headers upstream (the headers in IndustryStandard/Xen).
>
> Otherwise, the patch looks fine.
I'll give an A-b here later, conditional on Anthony's R-b or A-b.
Thanks
Laszlo
^ permalink raw reply [flat|nested] 122+ messages in thread
* Re: [PATCH 61/79] OvmfPkg/Xen: Fix various typos
2019-12-03 16:56 ` [PATCH 61/79] OvmfPkg/Xen: Fix various typos Anthony PERARD
2019-12-03 21:06 ` Laszlo Ersek
@ 2019-12-04 3:39 ` Cœur
2019-12-04 16:07 ` [edk2-devel] " Michael D Kinney
1 sibling, 1 reply; 122+ messages in thread
From: Cœur @ 2019-12-04 3:39 UTC (permalink / raw)
To: Anthony PERARD, Philippe Mathieu-Daude
Cc: devel, Jordan Justen, Laszlo Ersek, Ard Biesheuvel, Julien Grall
Le 04/12/2019 à 00:56, Anthony PERARD a écrit :
> There's seems to be missing SoB from Antoine. Could that be added?
Hi, no need to worry about my attribution: it's really just spellchecking.
^ permalink raw reply [flat|nested] 122+ messages in thread
* Re: [edk2-devel] [PATCH 61/79] OvmfPkg/Xen: Fix various typos
2019-12-04 3:39 ` Cœur
@ 2019-12-04 16:07 ` Michael D Kinney
2019-12-09 13:06 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 122+ messages in thread
From: Michael D Kinney @ 2019-12-04 16:07 UTC (permalink / raw)
To: devel@edk2.groups.io, coeur@gmx.fr, Anthony PERARD,
Philippe Mathieu-Daude, Kinney, Michael D
Cc: Justen, Jordan L, Laszlo Ersek, Ard Biesheuvel, Julien Grall
Antoine,
Signed-off-by is much more than attribution.
It is a statement that the contribution follows the COO.
https://github.com/tianocore/edk2#developer-certificate-of-origin
Best regards,
Mike
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Cœur
> Sent: Tuesday, December 3, 2019 7:40 PM
> To: Anthony PERARD <anthony.perard@citrix.com>;
> Philippe Mathieu-Daude <philmd@redhat.com>
> Cc: devel@edk2.groups.io; Justen, Jordan L
> <jordan.l.justen@intel.com>; Laszlo Ersek
> <lersek@redhat.com>; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>; Julien Grall
> <julien@xen.org>
> Subject: Re: [edk2-devel] [PATCH 61/79] OvmfPkg/Xen:
> Fix various typos
>
>
> Le 04/12/2019 à 00:56, Anthony PERARD a écrit :
> > There's seems to be missing SoB from Antoine. Could
> that be added?
>
> Hi, no need to worry about my attribution: it's really
> just spellchecking.
>
>
>
>
^ permalink raw reply [flat|nested] 122+ messages in thread
* Re: [edk2-devel] [PATCH 61/79] OvmfPkg/Xen: Fix various typos
2019-12-04 16:07 ` [edk2-devel] " Michael D Kinney
@ 2019-12-09 13:06 ` Philippe Mathieu-Daudé
2019-12-09 17:53 ` Michael D Kinney
0 siblings, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-09 13:06 UTC (permalink / raw)
To: Kinney, Michael D, devel@edk2.groups.io, coeur@gmx.fr,
Anthony PERARD
Cc: Justen, Jordan L, Laszlo Ersek, Ard Biesheuvel, Julien Grall
Hi Mike,
On 12/4/19 5:07 PM, Kinney, Michael D wrote:
> Antoine,
>
> Signed-off-by is much more than attribution.
>
> It is a statement that the contribution follows the COO.
Some of Antoine patches have his S-o-b, some don't.
Would it be acceptable if Antoine replies to the cover with "for my
patches: Signed-off-by: Antoine Coeur <coeur@gmx.fr>" and I add his tag
before respining v2?
> https://github.com/tianocore/edk2#developer-certificate-of-origin
>
> Best regards,
>
> Mike
>
>
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On
>> Behalf Of Cœur
>> Sent: Tuesday, December 3, 2019 7:40 PM
>> To: Anthony PERARD <anthony.perard@citrix.com>;
>> Philippe Mathieu-Daude <philmd@redhat.com>
>> Cc: devel@edk2.groups.io; Justen, Jordan L
>> <jordan.l.justen@intel.com>; Laszlo Ersek
>> <lersek@redhat.com>; Ard Biesheuvel
>> <ard.biesheuvel@linaro.org>; Julien Grall
>> <julien@xen.org>
>> Subject: Re: [edk2-devel] [PATCH 61/79] OvmfPkg/Xen:
>> Fix various typos
>>
>>
>> Le 04/12/2019 à 00:56, Anthony PERARD a écrit :
>>> There's seems to be missing SoB from Antoine. Could
>> that be added?
>>
>> Hi, no need to worry about my attribution: it's really
>> just spellchecking.
>>
>>
>>
>>
>
^ permalink raw reply [flat|nested] 122+ messages in thread
* Re: [edk2-devel] [PATCH 61/79] OvmfPkg/Xen: Fix various typos
2019-12-09 13:06 ` Philippe Mathieu-Daudé
@ 2019-12-09 17:53 ` Michael D Kinney
0 siblings, 0 replies; 122+ messages in thread
From: Michael D Kinney @ 2019-12-09 17:53 UTC (permalink / raw)
To: devel@edk2.groups.io, philmd@redhat.com, coeur@gmx.fr,
Anthony PERARD, Kinney, Michael D
Cc: Justen, Jordan L, Laszlo Ersek, Ard Biesheuvel, Julien Grall
Yes. That is a good approach.
Mike
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Philippe Mathieu-Daudé
> Sent: Monday, December 9, 2019 5:07 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>;
> devel@edk2.groups.io; coeur@gmx.fr; Anthony PERARD
> <anthony.perard@citrix.com>
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>;
> Laszlo Ersek <lersek@redhat.com>; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>; Julien Grall
> <julien@xen.org>
> Subject: Re: [edk2-devel] [PATCH 61/79] OvmfPkg/Xen:
> Fix various typos
>
> Hi Mike,
>
> On 12/4/19 5:07 PM, Kinney, Michael D wrote:
> > Antoine,
> >
> > Signed-off-by is much more than attribution.
> >
> > It is a statement that the contribution follows the
> COO.
>
> Some of Antoine patches have his S-o-b, some don't.
>
> Would it be acceptable if Antoine replies to the cover
> with "for my
> patches: Signed-off-by: Antoine Coeur <coeur@gmx.fr>"
> and I add his tag
> before respining v2?
>
> > https://github.com/tianocore/edk2#developer-
> certificate-of-origin
> >
> > Best regards,
> >
> > Mike
> >
> >
> >> -----Original Message-----
> >> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> >> Behalf Of Cœur
> >> Sent: Tuesday, December 3, 2019 7:40 PM
> >> To: Anthony PERARD <anthony.perard@citrix.com>;
> >> Philippe Mathieu-Daude <philmd@redhat.com>
> >> Cc: devel@edk2.groups.io; Justen, Jordan L
> >> <jordan.l.justen@intel.com>; Laszlo Ersek
> >> <lersek@redhat.com>; Ard Biesheuvel
> >> <ard.biesheuvel@linaro.org>; Julien Grall
> >> <julien@xen.org>
> >> Subject: Re: [edk2-devel] [PATCH 61/79] OvmfPkg/Xen:
> >> Fix various typos
> >>
> >>
> >> Le 04/12/2019 à 00:56, Anthony PERARD a écrit :
> >>> There's seems to be missing SoB from Antoine. Could
> >> that be added?
> >>
> >> Hi, no need to worry about my attribution: it's
> really
> >> just spellchecking.
> >>
> >>
> >>
> >>
> >
>
>
>
^ permalink raw reply [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-76-philmd@redhat.com>]
* Re: [PATCH 75/79] StandaloneMmPkg: Fix a typo
[not found] ` <20191203161602.15969-76-philmd@redhat.com>
@ 2019-12-03 19:44 ` Yao, Jiewen
0 siblings, 0 replies; 122+ messages in thread
From: Yao, Jiewen @ 2019-12-03 19:44 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Cœur, Achin Gupta, Supreeth Venkatesh
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: Philippe Mathieu-Daude <philmd@redhat.com>
> Sent: Wednesday, December 4, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Philippe Mathieu-Daude <philmd@redhat.com>; Antoine Cœur
> <coeur@gmx.fr>; Achin Gupta <achin.gupta@arm.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Subject: [PATCH 75/79] StandaloneMmPkg: Fix a typo
>
> Fix a typo in a comment.
>
> Cc: Achin Gupta <achin.gupta@arm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> StandaloneMmPkg/Core/Dispatcher.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/StandaloneMmPkg/Core/Dispatcher.c
> b/StandaloneMmPkg/Core/Dispatcher.c
> index fe10e65c4bf0..2f795d01dc1f 100644
> --- a/StandaloneMmPkg/Core/Dispatcher.c
> +++ b/StandaloneMmPkg/Core/Dispatcher.c
> @@ -431,7 +431,7 @@ MmLoadImage (
> //
> // Copy the PDB file name to our temporary string, and replace .pdb with .efi
> // The PDB file name is limited in the range of 0~255.
> - // If the length is bigger than 255, trim the redudant characters to avoid
> overflow in array boundary.
> + // If the length is bigger than 255, trim the redundant characters to avoid
> overflow in array boundary.
> //
> for (Index = 0; Index < sizeof (EfiFileName) - 4; Index++) {
> EfiFileName[Index] = ImageContext.PdbPointer[Index + StartIndex];
> --
> 2.21.0
^ permalink raw reply [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-77-philmd@redhat.com>]
* Re: [PATCH 76/79] StandaloneMmPkg: Fix few typos
[not found] ` <20191203161602.15969-77-philmd@redhat.com>
@ 2019-12-03 19:45 ` Yao, Jiewen
0 siblings, 0 replies; 122+ messages in thread
From: Yao, Jiewen @ 2019-12-03 19:45 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Achin Gupta, Supreeth Venkatesh
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: Philippe Mathieu-Daude <philmd@redhat.com>
> Sent: Wednesday, December 4, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Achin Gupta <achin.gupta@arm.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Supreeth Venkatesh
> <supreeth.venkatesh@arm.com>; Philippe Mathieu-Daude
> <philmd@redhat.com>
> Subject: [PATCH 76/79] StandaloneMmPkg: Fix few typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix few typos in comments.
>
> Cc: Achin Gupta <achin.gupta@arm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
>
> StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMm
> PeCoffExtraActionLib.inf | 2 +-
> StandaloneMmPkg/Core/Dependency.c | 2 +-
> StandaloneMmPkg/Core/FwVol.c | 2 +-
> StandaloneMmPkg/Core/StandaloneMmCore.c |
> 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git
> a/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneM
> mPeCoffExtraActionLib.inf
> b/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneM
> mPeCoffExtraActionLib.inf
> index e972ba3bc7b8..89083df679a1 100644
> ---
> a/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneM
> mPeCoffExtraActionLib.inf
> +++
> b/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneM
> mPeCoffExtraActionLib.inf
> @@ -1,5 +1,5 @@
> #/** @file
> -# PeCoff extra action libary for DXE phase that run Unix emulator.
> +# PeCoff extra action library for DXE phase that run Unix emulator.
> #
> # Lib to provide memory journal status code reporting Routines
> # Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
> diff --git a/StandaloneMmPkg/Core/Dependency.c
> b/StandaloneMmPkg/Core/Dependency.c
> index 7c6e76748b2b..e0f2d3518369 100644
> --- a/StandaloneMmPkg/Core/Dependency.c
> +++ b/StandaloneMmPkg/Core/Dependency.c
> @@ -372,7 +372,7 @@ MmIsSchedulable (
> // The math is done out of order, but it should not matter. That is
> // we may add in the sizeof (EFI_GUID) before we account for the OP Code.
> // This is not an issue, since we just need the correct end result. You
> - // need to be careful using Iterator in the loop as it's intermediate value
> + // need to be careful using Iterator in the loop as its intermediate value
> // may be strange.
> //
> Iterator++;
> diff --git a/StandaloneMmPkg/Core/FwVol.c b/StandaloneMmPkg/Core/FwVol.c
> index 314329ea065a..856d86011d31 100644
> --- a/StandaloneMmPkg/Core/FwVol.c
> +++ b/StandaloneMmPkg/Core/FwVol.c
> @@ -50,7 +50,7 @@ MmCoreFfsFindMmDriver (
>
> Routine Description:
> Given the pointer to the Firmware Volume Header find the
> - MM driver and return it's PE32 image.
> + MM driver and return its PE32 image.
>
> Arguments:
> FwVolHeader - Pointer to memory mapped FV
> diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.c
> b/StandaloneMmPkg/Core/StandaloneMmCore.c
> index c52164683de8..ac3e2c0b1b93 100644
> --- a/StandaloneMmPkg/Core/StandaloneMmCore.c
> +++ b/StandaloneMmPkg/Core/StandaloneMmCore.c
> @@ -354,7 +354,7 @@ MmEntryPoint (
> //PlatformHookBeforeMmDispatch ();
>
> //
> - // If a legacy boot has occured, then make sure gMmCorePrivate is not
> accessed
> + // If a legacy boot has occurred, then make sure gMmCorePrivate is not
> accessed
> //
>
> //
> --
> 2.21.0
^ permalink raw reply [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-57-philmd@redhat.com>]
* Re: [PATCH 56/79] OvmfPkg/Acpi: Fix few typos
[not found] ` <20191203161602.15969-57-philmd@redhat.com>
@ 2019-12-03 20:48 ` Laszlo Ersek
0 siblings, 0 replies; 122+ messages in thread
From: Laszlo Ersek @ 2019-12-03 20:48 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel
Cc: Antoine Coeur, Jordan Justen, Ard Biesheuvel
On 12/03/19 17:15, Philippe Mathieu-Daude wrote:
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix few typos in comments and documentation.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> OvmfPkg/Csm/Include/Protocol/IsaAcpi.h | 2 +-
> OvmfPkg/AcpiPlatformDxe/BootScript.c | 2 +-
> OvmfPkg/AcpiTables/Facp.aslc | 8 ++++----
> OvmfPkg/AcpiTables/Facs.aslc | 4 ++--
> OvmfPkg/AcpiTables/Madt.aslc | 2 +-
> 5 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/OvmfPkg/Csm/Include/Protocol/IsaAcpi.h b/OvmfPkg/Csm/Include/Protocol/IsaAcpi.h
> index 12aeb1227c54..0ff57aa118ca 100644
> --- a/OvmfPkg/Csm/Include/Protocol/IsaAcpi.h
> +++ b/OvmfPkg/Csm/Include/Protocol/IsaAcpi.h
> @@ -131,7 +131,7 @@ EFI_STATUS
>
> This services sets the power state of the ISA controller specified by Device to
> the power state specified by OnOff. TRUE denotes on, FALSE denotes off.
> - If the power state is sucessfully set on the ISA Controller, then
> + If the power state is successfully set on the ISA Controller, then
> EFI_SUCCESS is returned.
>
> @param[in] This The pointer to the EFI_ISA_ACPI_PROTOCOL instance.
> diff --git a/OvmfPkg/AcpiPlatformDxe/BootScript.c b/OvmfPkg/AcpiPlatformDxe/BootScript.c
> index 7137994471bd..7b1b9586da41 100644
> --- a/OvmfPkg/AcpiPlatformDxe/BootScript.c
> +++ b/OvmfPkg/AcpiPlatformDxe/BootScript.c
> @@ -240,7 +240,7 @@ FatalError:
> Script opcodes. If the function returns successfully,
> the caller must set the S3Context pointer -- originally
> returned by AllocateS3Context() -- immediately to NULL,
> - because the ownership of S3Context has been transfered.
> + because the ownership of S3Context has been transferred.
>
> @retval EFI_SUCCESS The translation of S3Context to ACPI S3 Boot Script
> opcodes has been successfully executed or queued. (This
> diff --git a/OvmfPkg/AcpiTables/Facp.aslc b/OvmfPkg/AcpiTables/Facp.aslc
> index 8829c1808a70..657a8c645821 100644
> --- a/OvmfPkg/AcpiTables/Facp.aslc
> +++ b/OvmfPkg/AcpiTables/Facp.aslc
> @@ -21,7 +21,7 @@ EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_TABLE FACP = {
> EFI_ACPI_CREATOR_ID, // ASL compiler vendor ID
> EFI_ACPI_CREATOR_REVISION // ASL compiler revision number
> },
> - 0, // Physical addesss of FACS
> + 0, // Physical address of FACS
> 0, // Physical address of DSDT
> RESERVED, // System Interrupt Model in ACPI 1.0, eliminated in 2.0
> EFI_ACPI_2_0_PM_PROFILE_UNSPECIFIED, // Preferred PM profile
> @@ -62,8 +62,8 @@ EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_TABLE FACP = {
> GAS2_IO(RESET_REG, 1), // Extended address of the Reset Register
> RESET_VALUE, // Value for the Reset Register to reset the system
> { RESERVED }, // reserved[3]
> - 0, // 64-bit physical addesss of FACS, set at installation
> - 0, // 64-bit physical addesss of DSDT, set at installation
> + 0, // 64-bit physical address of FACS, set at installation
> + 0, // 64-bit physical address of DSDT, set at installation
>
> GAS2_IO(PM1a_EVT_BLK, PM1_EVT_LEN), // Ext. addr. of PM 1a Event Reg Blk
> { 0 }, // PM 1b Event Reg Blk unsupported
> @@ -83,7 +83,7 @@ ReferenceAcpiTable (
> {
> //
> // Reference the table being generated to prevent the optimizer from removing the
> - // data structure from the exeutable
> + // data structure from the executable
> //
> return (VOID*)&FACP;
> }
> diff --git a/OvmfPkg/AcpiTables/Facs.aslc b/OvmfPkg/AcpiTables/Facs.aslc
> index 56f86c1ca4fd..8257c4bc6416 100644
> --- a/OvmfPkg/AcpiTables/Facs.aslc
> +++ b/OvmfPkg/AcpiTables/Facs.aslc
> @@ -70,8 +70,8 @@ ReferenceAcpiTable (
> )
> {
> //
> - // Reference the table being generated to prevent the optimizer from removing the
> - // data structure from the exeutable
> + // Reference the table being generated to prevent the optimizer from removing the
The line above introduces a stray space character before the CRLF.
Please remove it. (I.e., the line starting with "Reference..." should
not be changed.) With that:
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks
Laszlo
> + // data structure from the executable
> //
> return (VOID*)&FACS;
> }
> diff --git a/OvmfPkg/AcpiTables/Madt.aslc b/OvmfPkg/AcpiTables/Madt.aslc
> index 44ffd3726500..02fc3649a0d0 100644
> --- a/OvmfPkg/AcpiTables/Madt.aslc
> +++ b/OvmfPkg/AcpiTables/Madt.aslc
> @@ -147,7 +147,7 @@ ReferenceAcpiTable (
> {
> //
> // Reference the table being generated to prevent the optimizer from removing the
> - // data structure from the exeutable
> + // data structure from the executable
> //
> return (VOID*)&Madt;
> }
>
^ permalink raw reply [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-58-philmd@redhat.com>]
* Re: [PATCH 57/79] OvmfPkg/Csm: Fix various typos
[not found] ` <20191203161602.15969-58-philmd@redhat.com>
@ 2019-12-03 20:50 ` Laszlo Ersek
2019-12-03 23:31 ` David Woodhouse
0 siblings, 1 reply; 122+ messages in thread
From: Laszlo Ersek @ 2019-12-03 20:50 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel
Cc: Antoine Coeur, Jordan Justen, Ard Biesheuvel, David Woodhouse
On 12/03/19 17:15, Philippe Mathieu-Daude wrote:
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in documentation, comments and strings.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf | 2 +-
> OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h | 10 +++++-----
> OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h | 8 ++++----
> OvmfPkg/Csm/Include/Framework/BootScript.h | 2 +-
> OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h | 2 +-
> OvmfPkg/Csm/Include/Protocol/IsaIo.h | 2 +-
> OvmfPkg/Csm/Include/Protocol/LegacyBios.h | 6 +++---
> OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h | 4 ++--
> OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h | 2 +-
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h | 8 ++++----
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h | 4 ++--
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h | 2 +-
> OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c | 4 ++--
> OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c | 6 +++---
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 6 +++---
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c | 4 ++--
> OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c | 8 ++++----
> OvmfPkg/Csm/LegacyBiosDxe/Thunk.c | 4 ++--
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c | 14 +++++++-------
> OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c | 18 +++++++++---------
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni | 8 ++++----
> 21 files changed, 62 insertions(+), 62 deletions(-)
CC'ing David -- David is the designated Reviewer for OvmfPkg/Csm/, based
on "Maintainers.txt".
Conditional on David's R-b, you can add:
Acked-by: Laszlo Ersek <lersek@redhat.com>
Thanks
Laszlo
> diff --git a/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf b/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf
> index 5cc64a1b2df2..9a790d34a0e4 100644
> --- a/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf
> +++ b/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf
> @@ -1,5 +1,5 @@
> ## @file
> -# Legacy Boot Maintainence UI module is library for BDS phase.
> +# Legacy Boot Maintenance UI module is library for BDS phase.
> #
> # Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.<BR>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> diff --git a/OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h b/OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h
> index 951f4e6f768f..522e8ab15bb9 100644
> --- a/OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h
> +++ b/OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h
> @@ -241,7 +241,7 @@ BiosVideoCheckForVga (
>
>
> /**
> - Release resource for biso video instance.
> + Release resource for bios video instance.
>
> @param BiosVideoPrivate Video child device private data structure
>
> @@ -347,9 +347,9 @@ BiosVideoGraphicsOutputVbeBlt (
>
>
> /**
> - Grahpics Output protocol instance to block transfer for VGA device.
> + Graphics Output protocol instance to block transfer for VGA device.
>
> - @param This Pointer to Grahpics Output protocol instance
> + @param This Pointer to Graphics Output protocol instance
> @param BltBuffer The data to transfer to screen
> @param BltOperation The operation to perform
> @param SourceX The X coordinate of the source for BltOperation
> @@ -412,7 +412,7 @@ BiosVideoVgaMiniPortSetMode (
> /**
> Event handler for Exit Boot Service.
>
> - @param Event The event that be siganlled when exiting boot service.
> + @param Event The event that be signalled when exiting boot service.
> @param Context Pointer to instance of BIOS_VIDEO_DEV.
>
> **/
> @@ -506,7 +506,7 @@ BiosVideoChildHandleUninstall (
> );
>
> /**
> - Release resource for biso video instance.
> + Release resource for bios video instance.
>
> @param BiosVideoPrivate Video child device private data structure
>
> diff --git a/OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h b/OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h
> index dbf706179ff9..88065f15c645 100644
> --- a/OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h
> +++ b/OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h
> @@ -250,7 +250,7 @@ typedef struct {
> #define VESA_BIOS_EXTENSIONS_VERSION_3_0 0x0300
>
> //
> -// Super VGA Information Block Capabilities field bit defintions
> +// Super VGA Information Block Capabilities field bit definitions
> //
> #define VESA_BIOS_EXTENSIONS_CAPABILITY_8_BIT_DAC 0x01 // 0: DAC width is fixed at 6 bits/color
> // 1: DAC width switchable to 8 bits/color
> @@ -358,7 +358,7 @@ typedef struct {
> } VESA_BIOS_EXTENSIONS_MODE_INFORMATION_BLOCK;
>
> //
> -// Super VGA Mode Information Block ModeAttributes field bit defintions
> +// Super VGA Mode Information Block ModeAttributes field bit definitions
> //
> #define VESA_BIOS_EXTENSIONS_MODE_ATTRIBUTE_HARDWARE 0x0001 // 0: Mode not supported in handware
> // 1: Mode supported in handware
> @@ -396,7 +396,7 @@ typedef struct {
> #define VESA_BIOS_EXTENSIONS_MODE_ATTRIBUTE_DUAL_DISPLAY 0x1000 // 0: No dual display start address support
> // 1: Dual display start address support
> //
> -// Super VGA Mode Information Block WinAAttribite/WinBAttributes field bit defintions
> +// Super VGA Mode Information Block WinAAttribite/WinBAttributes field bit definitions
> //
> #define VESA_BIOS_EXTENSIONS_WINX_ATTRIBUTE_RELOCATABLE 0x01 // 0: Single non-relocatable window only
> // 1: Relocatable window(s) are supported
> @@ -407,7 +407,7 @@ typedef struct {
> #define VESA_BIOS_EXTENSIONS_WINX_ATTRIBUTE_WRITABLE 0x04 // 0: Window is not writable
> // 1: Window is writable
> //
> -// Super VGA Mode Information Block DirectColorMode field bit defintions
> +// Super VGA Mode Information Block DirectColorMode field bit definitions
> //
> #define VESA_BIOS_EXTENSIONS_DIRECT_COLOR_MODE_PROG_COLOR_RAMP 0x01 // 0: Color ram is fixed
> // 1: Color ramp is programmable
> diff --git a/OvmfPkg/Csm/Include/Framework/BootScript.h b/OvmfPkg/Csm/Include/Framework/BootScript.h
> index cb7220c1a7bd..a3518ea837cd 100644
> --- a/OvmfPkg/Csm/Include/Framework/BootScript.h
> +++ b/OvmfPkg/Csm/Include/Framework/BootScript.h
> @@ -1,5 +1,5 @@
> /** @file
> - This file contains the boot script defintions that are shared between the
> + This file contains the boot script definitions that are shared between the
> Boot Script Executor PPI and the Boot Script Save Protocol.
>
> Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
> diff --git a/OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h b/OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h
> index 04cbae1ef5ae..f10fc5231289 100644
> --- a/OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h
> +++ b/OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h
> @@ -271,7 +271,7 @@ typedef struct {
>
> ///
> /// Inconsistent with specification here:
> -/// The following defintion may not comply with Framework Specification HII 0.92. To
> +/// The following definition may not comply with Framework Specification HII 0.92. To
> /// keep the inconsistant is for implementation needed.
> ///@{
> typedef struct {
> diff --git a/OvmfPkg/Csm/Include/Protocol/IsaIo.h b/OvmfPkg/Csm/Include/Protocol/IsaIo.h
> index 30000305fb7d..8807e421feec 100644
> --- a/OvmfPkg/Csm/Include/Protocol/IsaIo.h
> +++ b/OvmfPkg/Csm/Include/Protocol/IsaIo.h
> @@ -145,7 +145,7 @@ typedef struct {
> @param[in] SrcOffset The offset of the source in ISA MMIO space.
> @param[in] Count The number tranfers to perform for this copy operation.
>
> - @retval EFI_SUCCESS The data was copied sucessfully.
> + @retval EFI_SUCCESS The data was copied successfully.
> @retval EFI_UNSUPPORTED The DestOffset or SrcOffset is not valid for this device.
> @retval EFI_INVALID_PARAMETER Width or Count, or both, were invalid.
> @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
> diff --git a/OvmfPkg/Csm/Include/Protocol/LegacyBios.h b/OvmfPkg/Csm/Include/Protocol/LegacyBios.h
> index 36761da39740..cd585a8d58f3 100644
> --- a/OvmfPkg/Csm/Include/Protocol/LegacyBios.h
> +++ b/OvmfPkg/Csm/Include/Protocol/LegacyBios.h
> @@ -1,7 +1,7 @@
> /** @file
> The EFI Legacy BIOS Protocol is used to abstract legacy Option ROM usage
> under EFI and Legacy OS boot. This file also includes all the related
> - COMPATIBILIY16 structures and defintions.
> + COMPATIBILIY16 structures and definitions.
>
> Note: The names for EFI_IA32_REGISTER_SET elements were picked to follow
> well known naming conventions.
> @@ -213,7 +213,7 @@ typedef struct {
> /// value of the start of the PCI Express memory-mapped configuration registers and
> /// must be filled in prior to EfiCompatibility code issuing the Compatibility16 function
> /// Compatibility16InitializeYourself().
> - /// Compatibility16InitializeYourself() is defined in Compatability16
> + /// Compatibility16InitializeYourself() is defined in Compatibility16
> /// Functions.
> ///
> UINT32 PciExpressBase;
> @@ -251,7 +251,7 @@ typedef struct {
>
> ///
> /// Functions provided by the CSM binary which communicate between the EfiCompatibility
> -/// and Compatability16 code.
> +/// and Compatibility16 code.
> ///
> /// Inconsistent with the specification here:
> /// The member's name started with "Compatibility16" [defined in Intel Framework
> diff --git a/OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h b/OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h
> index 0a164dad3bde..607ef358f0b0 100644
> --- a/OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h
> +++ b/OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h
> @@ -1,5 +1,5 @@
> /** @file
> - The EFI Legacy BIOS Patform Protocol is used to mate a Legacy16
> + The EFI Legacy BIOS Platform Protocol is used to mate a Legacy16
> implementation with this EFI code. The EFI driver that produces
> the Legacy BIOS protocol is generic and consumes this protocol.
> A driver that matches the Legacy16 produces this protocol
> @@ -383,7 +383,7 @@ typedef enum {
> ///
> /// ShadowAddress First free OpROM area, after other OpROMs have been dispatched..
> ///
> - /// Compatibility16Table Pointer to the Compatability16 Table.
> + /// Compatibility16Table Pointer to the Compatibility16 Table.
> ///
> /// AdditionalData NULL.
> ///
> diff --git a/OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h b/OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h
> index 41ff58e14cfa..5071c712ff9c 100644
> --- a/OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h
> +++ b/OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h
> @@ -30,7 +30,7 @@ typedef struct _EFI_VGA_MINI_PORT_PROTOCOL EFI_VGA_MINI_PORT_PROTOCOL;
> ModeNumber of 1 is a request for an 80x50 text mode. If ModeNumber is greater
> than MaxModeNumber, then EFI_UNSUPPORTED is returned. If the VGA controller
> is not functioning properly, then EFI_DEVICE_ERROR is returned. If the VGA
> - controller is sucessfully set to the mode number specified by ModeNumber, then
> + controller is successfully set to the mode number specified by ModeNumber, then
> EFI_SUCCESS is returned.
>
> @param[in] This A pointer to the EFI_VGA_MINI_PORT_PROTOCOL instance.
> diff --git a/OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h b/OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h
> index a72c8470f6e4..88ec93d428bf 100644
> --- a/OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h
> +++ b/OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h
> @@ -501,7 +501,7 @@ typedef struct {
> EFI_GENERIC_MEMORY_TEST_PROTOCOL *GenericMemoryTest;
>
> //
> - // TRUE if PCI Interupt Line registers have been programmed.
> + // TRUE if PCI Interrupt Line registers have been programmed.
> //
> BOOLEAN PciInterruptLine;
>
> @@ -706,7 +706,7 @@ LegacyBiosInt86 (
> the Stack argument
>
> @param This Protocol instance pointer.
> - @param Segment Segemnt of 16-bit mode call
> + @param Segment Segment of 16-bit mode call
> @param Offset Offset of 16-bit mdoe call
> @param Regs Register contexted passed into (and returned) from
> thunk to 16-bit mode
> @@ -1004,7 +1004,7 @@ InitLegacyIdeController (
>
> /**
> Program the interrupt routing register in all the PCI devices. On a PC AT system
> - this register contains the 8259 IRQ vector that matches it's PCI interrupt.
> + this register contains the 8259 IRQ vector that matches its PCI interrupt.
>
> @param Private Legacy BIOS Instance data
>
> @@ -1418,7 +1418,7 @@ RelocateImageUnder4GIfNeeded (
> the Stack argument
>
> @param This Protocol instance pointer.
> - @param Segment Segemnt of 16-bit mode call
> + @param Segment Segment of 16-bit mode call
> @param Offset Offset of 16-bit mdoe call
> @param Regs Register contexted passed into (and returned) from thunk to
> 16-bit mode
> diff --git a/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h b/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h
> index 0c491318c272..87290294df26 100644
> --- a/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h
> +++ b/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h
> @@ -1,5 +1,5 @@
> /** @file
> - Legacy boot maintainence Ui definition.
> + Legacy boot maintenance Ui definition.
>
> Copyright (c) 2004 - 2015, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -61,7 +61,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>
>
> //
> -// String Contant
> +// String Constant
> //
> #define STR_FLOPPY L"Floppy Drive #%02x"
> #define STR_HARDDISK L"HardDisk Drive #%02x"
> diff --git a/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h b/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h
> index e16fc3941515..13354865745d 100644
> --- a/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h
> +++ b/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h
> @@ -1,5 +1,5 @@
> /** @file
> - Legacy Boot Maintainence UI definition.
> + Legacy Boot Maintenance UI definition.
>
> Copyright (c) 2004 - 2015, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> diff --git a/OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c b/OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c
> index 0640656dba14..0a189bc59205 100644
> --- a/OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c
> +++ b/OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c
> @@ -381,7 +381,7 @@ BiosVideoDriverBindingStart (
> (FeaturePcdGet (PcdBiosVideoCheckVbeEnable) || FeaturePcdGet (PcdBiosVideoCheckVgaEnable))) {
> //
> // If RemainingDevicePath is the End of Device Path Node,
> - // don't create any child device and return EFI_SUCESS
> + // don't create any child device and return EFI_SUCCESS
> Status = EFI_SUCCESS;
> goto Done;
> }
> @@ -3211,7 +3211,7 @@ BiosVideoVgaMiniPortSetMode (
> /**
> Event handler for Exit Boot Service.
>
> - @param Event The event that be siganlled when exiting boot service.
> + @param Event The event that be signalled when exiting boot service.
> @param Context Pointer to instance of BIOS_VIDEO_DEV.
>
> **/
> diff --git a/OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c b/OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c
> index a07bb82da7f6..9c60c4a4cfc4 100644
> --- a/OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c
> +++ b/OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c
> @@ -282,7 +282,7 @@ GetSelectedVgaDeviceInfo (
> Status = gBS->HandleProtocol (HandleBuffer[Index], &gEfiPciIoProtocolGuid, (VOID**)&PciIo);
> if (!EFI_ERROR (Status)) {
> //
> - // Detemine if this is in the correct bus range.
> + // Determine if this is in the correct bus range.
> //
> Status = PciIo->GetLocation (PciIo, &Segment, &Bus, &Device, &Function);
> if (EFI_ERROR(Status) || (Bus < MinBus || Bus > MaxBus)) {
> @@ -501,7 +501,7 @@ GetPlatformHandle (
>
> //
> // Be sure to only fill out correct information based on platform
> - // configureation.
> + // configuration.
> //
> HddInfo[HddIndex].Status |= HDD_PRIMARY;
> HddInfo[HddIndex].Bus = (UINT32)Bus;
> @@ -882,7 +882,7 @@ TranslatePirq (
> if (PirqData == 0) {
>
> //
> - // No unused interrpts, so start reusing them.
> + // No unused interrupts, so start reusing them.
> //
> MatchData = (UINT8) (~MatchData);
> }
> diff --git a/OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c b/OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c
> index 5e795bfe6570..dd3608a64ece 100644
> --- a/OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c
> +++ b/OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c
> @@ -107,7 +107,7 @@ AllocateLegacyMemory (
> 64 KB blocks.
>
> Note: inconsistency with the Framework CSM spec. Per the spec, this function may be
> - invoked only once. This limitation is relaxed to allow multiple calls in this implemenation.
> + invoked only once. This limitation is relaxed to allow multiple calls in this implementation.
>
> @param This Protocol instance pointer.
> @param LegacyMemorySize Size of required region
> @@ -319,7 +319,7 @@ ShadowAndStartLegacy16 (
> Private->LegacyBiosImageSize = (UINT32) LegacyBiosImageSize;
>
> //
> - // Can only shadow into memory allocated for legacy useage.
> + // Can only shadow into memory allocated for legacy usage.
> //
> ASSERT (Private->BiosStart > Private->OptionRom);
>
> @@ -983,7 +983,7 @@ LegacyBiosInstall (
> );
>
> //
> - // Allocate 0 - 4K for real mode interupt vectors and BDA.
> + // Allocate 0 - 4K for real mode interrupt vectors and BDA.
> //
> AllocateLegacyMemory (
> AllocateAddress,
> diff --git a/OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c b/OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c
> index cd4cd24f4246..20784504d501 100644
> --- a/OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c
> +++ b/OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c
> @@ -962,7 +962,7 @@ GenericLegacyBoot (
> }
>
> //
> - // We do not ASSERT if SmbiosTable not found. It is possbile that a platform does not produce SmbiosTable.
> + // We do not ASSERT if SmbiosTable not found. It is possible that a platform does not produce SmbiosTable.
> //
> if (mReserveSmbiosEntryPoint == 0) {
> DEBUG ((EFI_D_INFO, "Smbios table is not found!\n"));
> @@ -982,7 +982,7 @@ GenericLegacyBoot (
> );
> }
> //
> - // We do not ASSERT if AcpiTable not found. It is possbile that a platform does not produce AcpiTable.
> + // We do not ASSERT if AcpiTable not found. It is possible that a platform does not produce AcpiTable.
> //
> if (AcpiTable == NULL) {
> DEBUG ((EFI_D_INFO, "ACPI table is not found!\n"));
> diff --git a/OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c b/OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c
> index dc1f760876a6..2656dafde943 100644
> --- a/OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c
> +++ b/OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c
> @@ -678,7 +678,7 @@ TranslateBusPirq (
>
>
> Search busses starting from slot bus for final bus >= Secondary bus and
> -final bus <= Suborninate bus. Assumption is bus entries increase in bus
> +final bus <= Subordinate bus. Assumption is bus entries increase in bus
> number.
> Starting PIRQ is A,B,C,D.
> Bus 2, Device 7 satisfies search criteria. Rotate (A,B,C,D) left by device
> @@ -914,7 +914,7 @@ InstallLegacyIrqHandler (
> Legacy8259 = Private->Legacy8259;
> //
> // Disable interrupt in PIC, in case shared, to prevent an
> - // interrupt from occuring.
> + // interrupt from occurring.
> //
> Legacy8259->GetMask (
> Legacy8259,
> @@ -1049,7 +1049,7 @@ InstallLegacyIrqHandler (
>
> /**
> Program the interrupt routing register in all the PCI devices. On a PC AT system
> - this register contains the 8259 IRQ vector that matches it's PCI interrupt.
> + this register contains the 8259 IRQ vector that matches its PCI interrupt.
>
> @param Private Legacy BIOS Instance data
>
> @@ -2582,7 +2582,7 @@ LegacyBiosInstallRom (
> // do not follow the standard of setting AX = 0 on success.
> //
> //
> - // The ROM could have updated it's size so we need to read again.
> + // The ROM could have updated its size so we need to read again.
> //
> if (((EFI_LEGACY_EXPANSION_ROM_HEADER *) RuntimeAddress)->Signature != PCI_EXPANSION_ROM_HEADER_SIGNATURE) {
> //
> diff --git a/OvmfPkg/Csm/LegacyBiosDxe/Thunk.c b/OvmfPkg/Csm/LegacyBiosDxe/Thunk.c
> index a4985ede77a5..6432030a23ac 100644
> --- a/OvmfPkg/Csm/LegacyBiosDxe/Thunk.c
> +++ b/OvmfPkg/Csm/LegacyBiosDxe/Thunk.c
> @@ -127,8 +127,8 @@ LegacyBiosFarCall86 (
> Provide NULL interrupt handler which is used to check
> if there is more than one HW interrupt registers with the CPU AP.
>
> - @param InterruptType - The type of interrupt that occured
> - @param SystemContext - A pointer to the system context when the interrupt occured
> + @param InterruptType - The type of interrupt that occurred
> + @param SystemContext - A pointer to the system context when the interrupt occurred
>
> **/
> VOID
> diff --git a/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c b/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c
> index af7d80eb5f04..35470abf914a 100644
> --- a/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c
> +++ b/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c
> @@ -1,5 +1,5 @@
> /** @file
> - Legacy Boot Maintainence UI implementation.
> + Legacy Boot Maintenance UI implementation.
>
> Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<BR>
> (C) Copyright 2018 Hewlett Packard Enterprise Development LP<BR>
> @@ -237,10 +237,10 @@ OrderLegacyBootOption4SameType (
>
> /**
> Update the legacy BBS boot option. L"LegacyDevOrder" and gEfiLegacyDevOrderVariableGuid EFI Variable
> - is udpated with the new Legacy Boot order. The EFI Variable of "Boot####" and gEfiGlobalVariableGuid
> + is updated with the new Legacy Boot order. The EFI Variable of "Boot####" and gEfiGlobalVariableGuid
> is also updated.
>
> - @param NVMapData The data for egacy BBS boot.
> + @param NVMapData The data for legacy BBS boot.
>
> @return EFI_SUCCESS The function completed successfully.
> @retval EFI_NOT_FOUND If L"LegacyDevOrder" and gEfiLegacyDevOrderVariableGuid EFI Variable can not be found.
> @@ -725,7 +725,7 @@ CreateLegacyMenuStringToken (
> Create a dynamic page so that Legacy Device boot order
> can be set for specified device type.
>
> - @param UpdatePageId The form ID. It also spefies the legacy device type.
> + @param UpdatePageId The form ID. It also specifies the legacy device type.
>
>
> **/
> @@ -1127,8 +1127,8 @@ LegacyBootOptionCallback (
> if (QuestionId == FORM_FLOPPY_BOOT_ID) {
> if (!mFirstEnterLegacyForm) {
> //
> - // The leagcyBootMaintUiLib depends on the LegacyBootManagerLib to realize its functionality.
> - // We need to do the leagcy boot options related actions after the LegacyBootManagerLib has been initialized.
> + // The legacyBootMaintUiLib depends on the LegacyBootManagerLib to realize its functionality.
> + // We need to do the legacy boot options related actions after the LegacyBootManagerLib has been initialized.
> // Opening the legacy menus is the appropriate time that the LegacyBootManagerLib has already been initialized.
> //
> mFirstEnterLegacyForm = TRUE;
> @@ -1403,7 +1403,7 @@ GetLegacyOptions (
> @param ImageHandle The image handle.
> @param SystemTable The system table.
>
> - @retval EFI_SUCEESS Install Boot manager menu success.
> + @retval EFI_SUCCESS Install Boot manager menu success.
> @retval Other Return error status.
>
> **/
> diff --git a/OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c b/OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c
> index 6138a32ad78e..6ed45785be72 100644
> --- a/OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c
> +++ b/OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c
> @@ -173,7 +173,7 @@ LegacyBmBuildLegacyDevNameString (
> StringDesc = (CHAR8 *) (((UINTN) CurBBSEntry->DescStringSegment << 4) + CurBBSEntry->DescStringOffset);
> if (NULL != StringDesc) {
> //
> - // Only get fisrt 32 characters, this is suggested by BBS spec
> + // Only get first 32 characters, this is suggested by BBS spec
> //
> CopyMem (StringBufferA, StringDesc, LEGACY_BM_BOOT_DESCRIPTION_LENGTH);
> StringBufferA[LEGACY_BM_BOOT_DESCRIPTION_LENGTH] = 0;
> @@ -378,9 +378,9 @@ LegacyBmDeleteAllBootOptions (
> /**
> Delete all the invalid legacy boot options.
>
> - @retval EFI_SUCCESS All invalide legacy boot options are deleted.
> + @retval EFI_SUCCESS All invalid legacy boot options are deleted.
> @retval EFI_OUT_OF_RESOURCES Fail to allocate necessary memory.
> - @retval EFI_NOT_FOUND Fail to retrive variable of boot order.
> + @retval EFI_NOT_FOUND Fail to retrieve variable of boot order.
> **/
> EFI_STATUS
> LegacyBmDeleteAllInvalidBootOptions (
> @@ -499,7 +499,7 @@ LegacyBmDeleteAllInvalidBootOptions (
> /**
> Create legacy boot option.
>
> - @param BootOption Ponter to the boot option which will be crated.
> + @param BootOption Pointer to the boot option which will be crated.
> @param BbsEntry The input bbs entry info.
> @param BbsIndex The BBS index.
>
> @@ -615,10 +615,10 @@ LegacyBmFillDevOrderBuf (
> @param BbsTable The BBS table.
> @param BbsCount The BBS Count.
>
> - @retval EFI_SUCCES The buffer is created and the EFI variable named
> + @retval EFI_SUCCESS The buffer is created and the EFI variable named
> VAR_LEGACY_DEV_ORDER and EfiLegacyDevOrderGuid is
> set correctly.
> - @retval EFI_OUT_OF_RESOURCES Memmory or storage is not enough.
> + @retval EFI_OUT_OF_RESOURCES Memory or storage is not enough.
> @retval EFI_DEVICE_ERROR Fail to add the device order into EFI variable fail
> because of hardware error.
> **/
> @@ -742,7 +742,7 @@ LegacyBmCreateDevOrder (
>
> @retval EFI_SUCCESS The boot devices are added successfully.
> @retval EFI_NOT_FOUND The legacy boot devices are not found.
> - @retval EFI_OUT_OF_RESOURCES Memmory or storage is not enough.
> + @retval EFI_OUT_OF_RESOURCES Memory or storage is not enough.
> @retval EFI_DEVICE_ERROR Fail to add the legacy device boot order into EFI variable
> because of hardware error.
> **/
> @@ -1042,7 +1042,7 @@ LegacyBmUpdateDevOrder (
> @param DeviceType The device type.
> @param BbsIndex The BBS index to set the highest priority. Ignore when -1.
> @param LocalBbsTable The BBS table.
> - @param Priority The prority table.
> + @param Priority The priority table.
>
> @retval EFI_SUCCESS The function completes successfully.
> @retval EFI_NOT_FOUND Failed to find device.
> @@ -1494,7 +1494,7 @@ LegacyBmRefreshAllBootOption (
> //
> // Same algorithm pattern as the EfiBootManagerRefreshAllBootOption
> // Firstly delete the invalid legacy boot options,
> - // then enumreate and save the newly appeared legacy boot options
> + // then enumerate and save the newly appeared legacy boot options
> // the last step is legacy boot option special action to refresh the LegacyDevOrder variable
> //
> LegacyBmDeleteAllInvalidBootOptions ();
> diff --git a/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni b/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni
> index c2c100d378b3..f29e1449a749 100644
> --- a/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni
> +++ b/OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni
> @@ -1,7 +1,7 @@
> // /** @file
> -// Legacy Boot Maintainence UI module is library for BDS phase.
> +// Legacy Boot Maintenance UI module is library for BDS phase.
> //
> -// Legacy Boot Maintainence UI module is library for BDS phase.
> +// Legacy Boot Maintenance UI module is library for BDS phase.
> //
> // Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
> //
> @@ -11,10 +11,10 @@
>
> #string STR_MODULE_ABSTRACT
> #language en-US
> -"Legacy Boot Maintainence UI module is library for BDS phase."
> +"Legacy Boot Maintenance UI module is library for BDS phase."
>
> #string STR_MODULE_DESCRIPTION
> #language en-US
> -"Legacy Boot Maintainence UI module is library for BDS phase."
> +"Legacy Boot Maintenance UI module is library for BDS phase."
>
>
>
^ permalink raw reply [flat|nested] 122+ messages in thread* Re: [PATCH 57/79] OvmfPkg/Csm: Fix various typos
2019-12-03 20:50 ` [PATCH 57/79] OvmfPkg/Csm: Fix various typos Laszlo Ersek
@ 2019-12-03 23:31 ` David Woodhouse
2019-12-04 14:07 ` [edk2-devel] " Philippe Mathieu-Daudé
0 siblings, 1 reply; 122+ messages in thread
From: David Woodhouse @ 2019-12-03 23:31 UTC (permalink / raw)
To: Laszlo Ersek, Philippe Mathieu-Daude, devel
Cc: Antoine Coeur, Jordan Justen, Ard Biesheuvel
[-- Attachment #1: Type: text/plain, Size: 2806 bytes --]
On Tue, 2019-12-03 at 21:50 +0100, Laszlo Ersek wrote:
> On 12/03/19 17:15, Philippe Mathieu-Daude wrote:
> > From: Antoine Coeur <coeur@gmx.fr>
> >
> > Fix various typos in documentation, comments and strings.
> >
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> > Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> > ---
> > OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf | 2 +-
> > OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h | 10 +++++-----
> > OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h | 8 ++++----
> > OvmfPkg/Csm/Include/Framework/BootScript.h | 2 +-
> > OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h | 2 +-
> > OvmfPkg/Csm/Include/Protocol/IsaIo.h | 2 +-
> > OvmfPkg/Csm/Include/Protocol/LegacyBios.h | 6 +++---
> > OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h | 4 ++--
> > OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h | 2 +-
> > OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h | 8 ++++----
> > OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h | 4 ++--
> > OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h | 2 +-
> > OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c | 4 ++--
> > OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c | 6 +++---
> > OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 6 +++---
> > OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c | 4 ++--
> > OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c | 8 ++++----
> > OvmfPkg/Csm/LegacyBiosDxe/Thunk.c | 4 ++--
> > OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c | 14 +++++++-------
> > OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c | 18 +++++++++---------
> > OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni | 8 ++++----
> > 21 files changed, 62 insertions(+), 62 deletions(-)
>
> CC'ing David -- David is the designated Reviewer for OvmfPkg/Csm/, based
> on "Maintainers.txt".
>
> Conditional on David's R-b, you can add:
>
> Acked-by: Laszlo Ersek <lersek@redhat.com>
Looks sane to me, except there's one line in which you make a
correction but still leave BIOS spelled in lower case as 'bios'.
Shouldn't that have capitals?
Reviewed-by: David Woodhouse <dwmw2@infradead.org>
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5174 bytes --]
^ permalink raw reply [flat|nested] 122+ messages in thread
* Re: [edk2-devel] [PATCH 57/79] OvmfPkg/Csm: Fix various typos
2019-12-03 23:31 ` David Woodhouse
@ 2019-12-04 14:07 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-04 14:07 UTC (permalink / raw)
To: devel, dwmw2, Laszlo Ersek; +Cc: Antoine Coeur, Jordan Justen, Ard Biesheuvel
On 12/4/19 12:31 AM, David Woodhouse wrote:
> On Tue, 2019-12-03 at 21:50 +0100, Laszlo Ersek wrote:
>> On 12/03/19 17:15, Philippe Mathieu-Daude wrote:
>>> From: Antoine Coeur <coeur@gmx.fr>
>>>
>>> Fix various typos in documentation, comments and strings.
>>>
>>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
>>> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
>>> ---
>>> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf | 2 +-
>>> OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h | 10 +++++-----
>>> OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h | 8 ++++----
>>> OvmfPkg/Csm/Include/Framework/BootScript.h | 2 +-
>>> OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h | 2 +-
>>> OvmfPkg/Csm/Include/Protocol/IsaIo.h | 2 +-
>>> OvmfPkg/Csm/Include/Protocol/LegacyBios.h | 6 +++---
>>> OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h | 4 ++--
>>> OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h | 2 +-
>>> OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h | 8 ++++----
>>> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h | 4 ++--
>>> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h | 2 +-
>>> OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c | 4 ++--
>>> OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c | 6 +++---
>>> OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 6 +++---
>>> OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c | 4 ++--
>>> OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c | 8 ++++----
>>> OvmfPkg/Csm/LegacyBiosDxe/Thunk.c | 4 ++--
>>> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c | 14 +++++++-------
>>> OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c | 18 +++++++++---------
>>> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni | 8 ++++----
>>> 21 files changed, 62 insertions(+), 62 deletions(-)
>>
>> CC'ing David -- David is the designated Reviewer for OvmfPkg/Csm/, based
>> on "Maintainers.txt".
>>
>> Conditional on David's R-b, you can add:
>>
>> Acked-by: Laszlo Ersek <lersek@redhat.com>
>
> Looks sane to me, except there's one line in which you make a
> correction but still leave BIOS spelled in lower case as 'bios'.
> Shouldn't that have capitals?
OK I'll update.
>
> Reviewed-by: David Woodhouse <dwmw2@infradead.org>
Thanks both!
^ permalink raw reply [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-59-philmd@redhat.com>]
* Re: [PATCH 58/79] OvmfPkg/Qemu: Fix various typos
[not found] ` <20191203161602.15969-59-philmd@redhat.com>
@ 2019-12-03 21:00 ` Laszlo Ersek
2019-12-09 12:55 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 122+ messages in thread
From: Laszlo Ersek @ 2019-12-03 21:00 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel
Cc: Antoine Coeur, Jordan Justen, Ard Biesheuvel
On 12/03/19 17:15, Philippe Mathieu-Daude wrote:
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf | 4 ++--
> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf | 4 ++--
> OvmfPkg/AcpiPlatformDxe/Qemu.c | 4 ++--
> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 2 +-
> OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c | 4 ++--
> OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c | 2 +-
> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c | 2 +-
> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbInfo.c | 4 ++--
> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c | 8 ++++----
> OvmfPkg/QemuVideoDxe/Driver.c | 2 +-
> OvmfPkg/QemuVideoDxe/VbeShim.asm | 14 +++++++-------
> 11 files changed, 25 insertions(+), 25 deletions(-)
>
> diff --git a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf
> index ca6326e833ed..8125fd0735a1 100644
> --- a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf
> +++ b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf
> @@ -1,8 +1,8 @@
> ## @file
> -# Component description file for QEMU Flash Fimware Volume Block DXE driver
> +# Component description file for QEMU Flash Firmware Volume Block DXE driver
> # module.
> #
> -# This DXE runtime driver implements and produces the Fimware Volue Block
> +# This DXE runtime driver implements and produces the Firmware Volue Block
> # Protocol for a QEMU flash device.
> #
> # Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.<BR>
> diff --git a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf
> index 241e912e2967..4715d5fc437e 100644
> --- a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf
> +++ b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf
> @@ -1,8 +1,8 @@
> ## @file
> -# Component description file for QEMU Flash Fimware Volume Block SMM driver
> +# Component description file for QEMU Flash Firmware Volume Block SMM driver
> # module.
> #
> -# This SMM driver implements and produces the SMM Fimware Volue Block Protocol
> +# This SMM driver implements and produces the SMM Firmware Volue Block Protocol
> # for a QEMU flash device.
> #
> # Copyright (C) 2015, Red Hat, Inc.
> diff --git a/OvmfPkg/AcpiPlatformDxe/Qemu.c b/OvmfPkg/AcpiPlatformDxe/Qemu.c
> index f60e00f58af3..7fb42270043f 100644
> --- a/OvmfPkg/AcpiPlatformDxe/Qemu.c
> +++ b/OvmfPkg/AcpiPlatformDxe/Qemu.c
> @@ -137,7 +137,7 @@ QemuInstallAcpiMadtTable (
> ++Iso;
>
> //
> - // Set Level-tiggered, Active High for all possible PCI link targets.
> + // Set Level-triggered, Active High for all possible PCI link targets.
> //
> for (Loop = 0; Loop < 16; ++Loop) {
> if ((PcdGet16 (Pcd8259LegacyModeEdgeLevel) & (1 << Loop)) == 0) {
> @@ -148,7 +148,7 @@ QemuInstallAcpiMadtTable (
> Iso->Bus = 0x00; // ISA
> Iso->Source = (UINT8) Loop;
> Iso->GlobalSystemInterruptVector = (UINT32) Loop;
> - Iso->Flags = 0x000D; // Level-tiggered, Active High
> + Iso->Flags = 0x000D; // Level-triggered, Active High
> ++Iso;
> }
> ASSERT (
> diff --git a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c
> index bc1a891dbaf1..75a3a88a3612 100644
> --- a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c
> +++ b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c
> @@ -1113,7 +1113,7 @@ InstallQemuFwCfgTables (
> goto UninstallAcpiTables;
> }
> //
> - // Ownership of S3Context has been transfered.
> + // Ownership of S3Context has been transferred.
> //
> S3Context = NULL;
> }
> diff --git a/OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c b/OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c
> index 49bdfdf65043..1839f11f3301 100644
> --- a/OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c
> +++ b/OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c
> @@ -1156,7 +1156,7 @@ PciBitFieldAndThenOr32 (
> Size into the buffer specified by Buffer. This function only allows the PCI
> configuration registers from a single PCI function to be read. Size is
> returned. When possible 32-bit PCI configuration read cycles are used to read
> - from StartAdress to StartAddress + Size. Due to alignment restrictions, 8-bit
> + from StartAddress to StartAddress + Size. Due to alignment restrictions, 8-bit
> and 16-bit PCI configuration read cycles may be used at the beginning and the
> end of the range.
>
> @@ -1193,7 +1193,7 @@ PciReadBuffer (
> Size from the buffer specified by Buffer. This function only allows the PCI
> configuration registers from a single PCI function to be written. Size is
> returned. When possible 32-bit PCI configuration write cycles are used to
> - write from StartAdress to StartAddress + Size. Due to alignment restrictions,
> + write from StartAddress to StartAddress + Size. Due to alignment restrictions,
> 8-bit and 16-bit PCI configuration write cycles may be used at the beginning
> and the end of the range.
>
> diff --git a/OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c b/OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c
> index 586c2dec125c..ceffb17fa622 100644
> --- a/OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c
> +++ b/OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c
> @@ -412,7 +412,7 @@ typedef struct {
> If the call doesn't succeed, the contents of this
> structure is indeterminate.
>
> - @param[out] IsFinal In case of successul parsing, this parameter signals
> + @param[out] IsFinal In case of successful parsing, this parameter signals
> whether the node just parsed is the final node in the
> device path. The call after a final node will attempt
> to start parsing the next path. If the call doesn't
> diff --git a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c
> index 59d4680e5ec1..983680f8b6dd 100644
> --- a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c
> +++ b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c
> @@ -164,7 +164,7 @@ AllocFwCfgDmaAccessBuffer (
>
> //
> // As per UEFI spec, in order to map a host address with
> - // BusMasterCommomBuffer64, the buffer must be allocated using the IOMMU
> + // BusMasterCommonBuffer64, the buffer must be allocated using the IOMMU
> // AllocateBuffer()
> //
> Status = mIoMmuProtocol->AllocateBuffer (
> diff --git a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbInfo.c b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbInfo.c
> index 859d1e70c5c2..7a6dfb9c21d6 100644
> --- a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbInfo.c
> +++ b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbInfo.c
> @@ -21,7 +21,7 @@
> #include <Pi/PiFirmwareVolume.h>
>
> //
> -// The protocols, PPI and GUID defintions for this module
> +// The protocols, PPI and GUID definitions for this module
> //
> #include <Guid/SystemNvDataGuid.h>
> //
> @@ -41,7 +41,7 @@ typedef struct {
>
> EFI_FVB_MEDIA_INFO mPlatformFvbMediaInfo[] = {
> //
> - // Systen NvStorage FVB
> + // System NvStorage FVB
> //
> {
> FixedPcdGet32 (PcdFlashNvStorageVariableSize) +
> diff --git a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c
> index edf438a422fa..b7b99129a80e 100644
> --- a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c
> +++ b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c
> @@ -15,7 +15,7 @@
> **/
>
> //
> -// The protocols, PPI and GUID defintions for this module
> +// The protocols, PPI and GUID definitions for this module
> //
> #include <Protocol/DevicePath.h>
> #include <Protocol/FirmwareVolumeBlock.h>
> @@ -118,7 +118,7 @@ GetFvbInstance (
> returned
> Global - Pointer to ESAL_FWB_GLOBAL that contains all
> instance data
> - FwhInstance - The EFI_FW_VOL_INSTANCE fimrware instance structure
> + FwhInstance - The EFI_FW_VOL_INSTANCE firmware instance structure
>
> Returns:
> EFI_SUCCESS - Successfully returns
> @@ -695,7 +695,7 @@ FvbProtocolWrite (
> Writes data beginning at Lba:Offset from FV. The write terminates either
> when *NumBytes of data have been written, or when a block boundary is
> reached. *NumBytes is updated to reflect the actual number of bytes
> - written. The write opertion does not include erase. This routine will
> + written. The write operation does not include erase. This routine will
> attempt to write only the specified bytes. If the writes do not stick,
> it will return an error.
>
> @@ -740,7 +740,7 @@ FvbProtocolRead (
> Reads data beginning at Lba:Offset from FV. The Read terminates either
> when *NumBytes of data have been read, or when a block boundary is
> reached. *NumBytes is updated to reflect the actual number of bytes
> - written. The write opertion does not include erase. This routine will
> + written. The write operation does not include erase. This routine will
> attempt to write only the specified bytes. If the writes do not stick,
> it will return an error.
>
> diff --git a/OvmfPkg/QemuVideoDxe/Driver.c b/OvmfPkg/QemuVideoDxe/Driver.c
> index 522110ef4e09..6a4a860b3c25 100644
> --- a/OvmfPkg/QemuVideoDxe/Driver.c
> +++ b/OvmfPkg/QemuVideoDxe/Driver.c
> @@ -206,7 +206,7 @@ QemuVideoControllerDriverStart (
> OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
>
> //
> - // Allocate Private context data for GOP inteface.
> + // Allocate Private context data for GOP interface.
> //
> Private = AllocateZeroPool (sizeof (QEMU_VIDEO_PRIVATE_DATA));
> if (Private == NULL) {
> diff --git a/OvmfPkg/QemuVideoDxe/VbeShim.asm b/OvmfPkg/QemuVideoDxe/VbeShim.asm
> index cb2a60d8278d..1d284b264124 100644
> --- a/OvmfPkg/QemuVideoDxe/VbeShim.asm
> +++ b/OvmfPkg/QemuVideoDxe/VbeShim.asm
> @@ -49,7 +49,7 @@ Handler:
> je ReadEdid
> cmp ah, 0x00
> je SetModeLegacy
> - DebugLog StrUnkownFunction
> + DebugLog StrUnknownFunction
> Hang:
> jmp Hang
>
> @@ -93,7 +93,7 @@ GetModeInfo:
> and cx, ~0x4000 ; clear potentially set LFB bit in mode number
> cmp cx, 0x00f1
> je KnownMode1
> - DebugLog StrUnkownMode
> + DebugLog StrUnknownMode
> jmp Hang
> KnownMode1:
> ; target (es:di) set on input
> @@ -155,7 +155,7 @@ SetMode:
>
> cmp bx, 0x40f1
> je KnownMode2
> - DebugLog StrUnkownMode
> + DebugLog StrUnknownMode
> jmp Hang
> KnownMode2:
>
> @@ -203,7 +203,7 @@ SetModeLegacy:
> je KnownMode3
> cmp al, 0x12
> je KnownMode4
> - DebugLog StrUnkownMode
> + DebugLog StrUnknownMode
> jmp Hang
> KnownMode3:
> mov al, 0x30
> @@ -252,7 +252,7 @@ StrExitSuccess:
> StrExitUnsupported:
> db 'Unsupported', 0x0a, 0
>
> -StrUnkownFunction:
> +StrUnknownFunction:
> db 'Unknown Function', 0x0a, 0
>
> StrEnterGetInfo:
> @@ -270,8 +270,8 @@ StrEnterSetMode:
> StrEnterSetModeLegacy:
> db 'SetModeLegacy', 0x0a, 0
>
> -StrUnkownMode:
> - db 'Unkown Mode', 0x0a, 0
> +StrUnknownMode:
> + db 'Unknown Mode', 0x0a, 0
>
> StrGetPmCapabilities:
> db 'GetPmCapabilities', 0x0a, 0
>
If you modify "VbeShim.asm", then please re-run "VbeShim.sh", for
updating "VbeShim.h".
Looks OK to me otherwise.
(Note: I'm not commenting on the structure of the individual patches. It
could be cleaned up some more; for example 56/79 has a Csm hunk that
could go into 57/79. For another example, 56/79 and 58/79 split
modifications to AcpiPlatformDxe between each other, quite confusingly
-- why not fix all transfered -> transferred typos in the same module in
a single patch? But, I don't want to introduce even more churn. So I'm
not asking for restructuring the series.)
Thanks,
Laszlo
^ permalink raw reply [flat|nested] 122+ messages in thread* Re: [PATCH 58/79] OvmfPkg/Qemu: Fix various typos
2019-12-03 21:00 ` [PATCH 58/79] OvmfPkg/Qemu: " Laszlo Ersek
@ 2019-12-09 12:55 ` Philippe Mathieu-Daudé
2019-12-09 13:00 ` Philippe Mathieu-Daudé
2019-12-09 15:44 ` Laszlo Ersek
0 siblings, 2 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-09 12:55 UTC (permalink / raw)
To: Laszlo Ersek, devel
Cc: Antoine Coeur, Jordan Justen, Ard Biesheuvel, Gerd Hoffmann
Hi Laszlo,
On 12/3/19 10:00 PM, Laszlo Ersek wrote:
> On 12/03/19 17:15, Philippe Mathieu-Daude wrote:
>> From: Antoine Coeur <coeur@gmx.fr>
>>
>> Fix various typos in comments and documentation.
>>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
>> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
>> ---
>> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf | 4 ++--
>> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf | 4 ++--
>> OvmfPkg/AcpiPlatformDxe/Qemu.c | 4 ++--
>> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 2 +-
>> OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c | 4 ++--
>> OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c | 2 +-
>> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c | 2 +-
>> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbInfo.c | 4 ++--
>> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c | 8 ++++----
>> OvmfPkg/QemuVideoDxe/Driver.c | 2 +-
>> OvmfPkg/QemuVideoDxe/VbeShim.asm | 14 +++++++-------
>> 11 files changed, 25 insertions(+), 25 deletions(-)
>>
[...]>> diff --git a/OvmfPkg/QemuVideoDxe/VbeShim.asm
b/OvmfPkg/QemuVideoDxe/VbeShim.asm
>> index cb2a60d8278d..1d284b264124 100644
>> --- a/OvmfPkg/QemuVideoDxe/VbeShim.asm
>> +++ b/OvmfPkg/QemuVideoDxe/VbeShim.asm
>> @@ -49,7 +49,7 @@ Handler:
>> je ReadEdid
>> cmp ah, 0x00
>> je SetModeLegacy
>> - DebugLog StrUnkownFunction
>> + DebugLog StrUnknownFunction
>> Hang:
>> jmp Hang
>>
>> @@ -93,7 +93,7 @@ GetModeInfo:
>> and cx, ~0x4000 ; clear potentially set LFB bit in mode number
>> cmp cx, 0x00f1
>> je KnownMode1
>> - DebugLog StrUnkownMode
>> + DebugLog StrUnknownMode
>> jmp Hang
>> KnownMode1:
>> ; target (es:di) set on input
>> @@ -155,7 +155,7 @@ SetMode:
>>
>> cmp bx, 0x40f1
>> je KnownMode2
>> - DebugLog StrUnkownMode
>> + DebugLog StrUnknownMode
>> jmp Hang
>> KnownMode2:
>>
>> @@ -203,7 +203,7 @@ SetModeLegacy:
>> je KnownMode3
>> cmp al, 0x12
>> je KnownMode4
>> - DebugLog StrUnkownMode
>> + DebugLog StrUnknownMode
>> jmp Hang
>> KnownMode3:
>> mov al, 0x30
>> @@ -252,7 +252,7 @@ StrExitSuccess:
>> StrExitUnsupported:
>> db 'Unsupported', 0x0a, 0
>>
>> -StrUnkownFunction:
>> +StrUnknownFunction:
>> db 'Unknown Function', 0x0a, 0
>>
>> StrEnterGetInfo:
>> @@ -270,8 +270,8 @@ StrEnterSetMode:
>> StrEnterSetModeLegacy:
>> db 'SetModeLegacy', 0x0a, 0
>>
>> -StrUnkownMode:
>> - db 'Unkown Mode', 0x0a, 0
>> +StrUnknownMode:
>> + db 'Unknown Mode', 0x0a, 0
>>
>> StrGetPmCapabilities:
>> db 'GetPmCapabilities', 0x0a, 0
>>
>
> If you modify "VbeShim.asm", then please re-run "VbeShim.sh", for
> updating "VbeShim.h".
The DEBUG macro at the head of VbeShim.asm is commented out:
;%define DEBUG
So the string "Unknown Mode" is not used.
Side note, running VbeShim.sh on Fedora 30 I get:
$ git diff --word-diff
--- a/OvmfPkg/QemuVideoDxe/VbeShim.h
+++ b/OvmfPkg/QemuVideoDxe/VbeShim.h
@@ -523,13 +523,13 @@ STATIC CONST UINT8 mVbeShim[] = {
/* 0000020A cmp ax,0x4f02 */ 0x3D, 0x02, 0x4F,
/* 0000020D jz 0x269 */ 0x74, 0x5A,
/* 0000020F cmp ax,0x4f03 */ 0x3D, 0x03, 0x4F,
/* 00000212 jz [-word-]{+near+} 0x331 */ 0x0F,
0x84, 0x1B, 0x01,
/* 00000216 cmp ax,0x4f10 */ 0x3D, 0x10, 0x4F,
/* 00000219 jz [-word-]{+near+} 0x336 */ 0x0F,
0x84, 0x19, 0x01,
/* 0000021D cmp ax,0x4f15 */ 0x3D, 0x15, 0x4F,
/* 00000220 jz [-word-]{+near+} 0x338 */ 0x0F,
0x84, 0x14, 0x01,
/* 00000224 cmp ah,0x0 */ 0x80, 0xFC, 0x00,
/* 00000227 jz [-word-]{+near+} 0x33a */ 0x0F,
0x84, 0x0F, 0x01,
/* 0000022B jmp short 0x22b */ 0xEB, 0xFE,
/* 0000022D push es */ 0x06,
/* 0000022E push di */ 0x57,
@@ -547,7 +547,7 @@ STATIC CONST UINT8 mVbeShim[] = {
/* 0000023F pop ds */ 0x1F,
/* 00000240 pop di */ 0x5F,
/* 00000241 pop es */ 0x07,
/* 00000242 jmp[-word-] 0x34c */ 0xE9, 0x07, 0x01,
/* 00000245 push es */ 0x06,
/* 00000246 push di */ 0x57,
/* 00000247 push ds */ 0x1E,
@@ -568,7 +568,7 @@ STATIC CONST UINT8 mVbeShim[] = {
/* 00000263 pop ds */ 0x1F,
/* 00000264 pop di */ 0x5F,
/* 00000265 pop es */ 0x07,
/* 00000266 jmp[-word-] 0x34c */ 0xE9, 0xE3, 0x00,
/* 00000269 push dx */ 0x52,
/* 0000026A push ax */ 0x50,
/* 0000026B cmp bx,0x40f1 */ 0x81, 0xFB, 0xF1, 0x40,
@@ -688,14 +688,14 @@ STATIC CONST UINT8 mVbeShim[] = {
/* 0000033C jz 0x345 */ 0x74, 0x07,
/* 0000033E cmp al,0x12 */ 0x3C, 0x12,
/* 00000340 jz 0x349 */ 0x74, 0x07,
/* 00000342 jmp[-word-] 0x22b */ 0xE9, 0xE6, 0xFE,
/* 00000345 mov al,0x30 */ 0xB0, 0x30,
/* 00000347 jmp short 0x34b */ 0xEB, 0x02,
/* 00000349 mov al,0x20 */ 0xB0, 0x20,
/* 0000034B [-iretw-]{+iret+} */ 0xCF,
/* 0000034C mov ax,0x4f */ 0xB8, 0x4F, 0x00,
/* 0000034F [-iretw-]{+iret+} */ 0xCF,
/* 00000350 mov ax,0x14f */ 0xB8, 0x4F, 0x01,
/* 00000353 [-iretw-]{+iret+} */ 0xCF,
};
#endif
The nasm packaged is:
$ nasm -v
NASM version 2.13.03 compiled on Feb 2 2019
While NASM 2.12 is documented here:
https://github.com/tianocore/tianocore.github.io/wiki/Nasm-Setup
Should I downgrade it?
^ permalink raw reply [flat|nested] 122+ messages in thread* Re: [PATCH 58/79] OvmfPkg/Qemu: Fix various typos
2019-12-09 12:55 ` Philippe Mathieu-Daudé
@ 2019-12-09 13:00 ` Philippe Mathieu-Daudé
2019-12-09 16:12 ` Laszlo Ersek
2019-12-09 15:44 ` Laszlo Ersek
1 sibling, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-09 13:00 UTC (permalink / raw)
To: Laszlo Ersek, devel
Cc: Antoine Coeur, Jordan Justen, Ard Biesheuvel, Gerd Hoffmann
On 12/9/19 1:55 PM, Philippe Mathieu-Daudé wrote:
> Hi Laszlo,
>
> On 12/3/19 10:00 PM, Laszlo Ersek wrote:
>> On 12/03/19 17:15, Philippe Mathieu-Daude wrote:
>>> From: Antoine Coeur <coeur@gmx.fr>
>>>
>>> Fix various typos in comments and documentation.
>>>
>>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
>>> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
>>> ---
>>> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf |
>>> 4 ++--
>>> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf |
>>> 4 ++--
>>> OvmfPkg/AcpiPlatformDxe/Qemu.c |
>>> 4 ++--
>>> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c |
>>> 2 +-
>>> OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c |
>>> 4 ++--
>>> OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c |
>>> 2 +-
>>> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c |
>>> 2 +-
>>> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbInfo.c |
>>> 4 ++--
>>> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c |
>>> 8 ++++----
>>> OvmfPkg/QemuVideoDxe/Driver.c |
>>> 2 +-
>>> OvmfPkg/QemuVideoDxe/VbeShim.asm |
>>> 14 +++++++-------
>>> 11 files changed, 25 insertions(+), 25 deletions(-)
>>>
> [...]>> diff --git a/OvmfPkg/QemuVideoDxe/VbeShim.asm
> b/OvmfPkg/QemuVideoDxe/VbeShim.asm
>>> index cb2a60d8278d..1d284b264124 100644
>>> --- a/OvmfPkg/QemuVideoDxe/VbeShim.asm
>>> +++ b/OvmfPkg/QemuVideoDxe/VbeShim.asm
>>> @@ -49,7 +49,7 @@ Handler:
>>> je ReadEdid
>>> cmp ah, 0x00
>>> je SetModeLegacy
>>> - DebugLog StrUnkownFunction
>>> + DebugLog StrUnknownFunction
>>> Hang:
>>> jmp Hang
>>> @@ -93,7 +93,7 @@ GetModeInfo:
>>> and cx, ~0x4000 ; clear potentially set LFB bit in mode
>>> number
>>> cmp cx, 0x00f1
>>> je KnownMode1
>>> - DebugLog StrUnkownMode
>>> + DebugLog StrUnknownMode
>>> jmp Hang
>>> KnownMode1:
>>> ; target (es:di) set on input
>>> @@ -155,7 +155,7 @@ SetMode:
>>> cmp bx, 0x40f1
>>> je KnownMode2
>>> - DebugLog StrUnkownMode
>>> + DebugLog StrUnknownMode
>>> jmp Hang
>>> KnownMode2:
>>> @@ -203,7 +203,7 @@ SetModeLegacy:
>>> je KnownMode3
>>> cmp al, 0x12
>>> je KnownMode4
>>> - DebugLog StrUnkownMode
>>> + DebugLog StrUnknownMode
>>> jmp Hang
>>> KnownMode3:
>>> mov al, 0x30
>>> @@ -252,7 +252,7 @@ StrExitSuccess:
>>> StrExitUnsupported:
>>> db 'Unsupported', 0x0a, 0
>>> -StrUnkownFunction:
>>> +StrUnknownFunction:
>>> db 'Unknown Function', 0x0a, 0
>>> StrEnterGetInfo:
>>> @@ -270,8 +270,8 @@ StrEnterSetMode:
>>> StrEnterSetModeLegacy:
>>> db 'SetModeLegacy', 0x0a, 0
>>> -StrUnkownMode:
>>> - db 'Unkown Mode', 0x0a, 0
>>> +StrUnknownMode:
>>> + db 'Unknown Mode', 0x0a, 0
>>> StrGetPmCapabilities:
>>> db 'GetPmCapabilities', 0x0a, 0
>>>
>>
>> If you modify "VbeShim.asm", then please re-run "VbeShim.sh", for
>> updating "VbeShim.h".
>
> The DEBUG macro at the head of VbeShim.asm is commented out:
>
> ;%define DEBUG
>
>
> So the string "Unknown Mode" is not used.
>
> Side note, running VbeShim.sh on Fedora 30 I get:
>
> $ git diff --word-diff
> --- a/OvmfPkg/QemuVideoDxe/VbeShim.h
> +++ b/OvmfPkg/QemuVideoDxe/VbeShim.h
> @@ -523,13 +523,13 @@ STATIC CONST UINT8 mVbeShim[] = {
> /* 0000020A cmp ax,0x4f02 */ 0x3D, 0x02, 0x4F,
> /* 0000020D jz 0x269 */ 0x74, 0x5A,
> /* 0000020F cmp ax,0x4f03 */ 0x3D, 0x03, 0x4F,
> /* 00000212 jz [-word-]{+near+} 0x331 */ 0x0F,
> 0x84, 0x1B, 0x01,
> /* 00000216 cmp ax,0x4f10 */ 0x3D, 0x10, 0x4F,
> /* 00000219 jz [-word-]{+near+} 0x336 */ 0x0F,
> 0x84, 0x19, 0x01,
> /* 0000021D cmp ax,0x4f15 */ 0x3D, 0x15, 0x4F,
> /* 00000220 jz [-word-]{+near+} 0x338 */ 0x0F,
> 0x84, 0x14, 0x01,
> /* 00000224 cmp ah,0x0 */ 0x80, 0xFC, 0x00,
> /* 00000227 jz [-word-]{+near+} 0x33a */ 0x0F,
> 0x84, 0x0F, 0x01,
> /* 0000022B jmp short 0x22b */ 0xEB, 0xFE,
> /* 0000022D push es */ 0x06,
> /* 0000022E push di */ 0x57,
> @@ -547,7 +547,7 @@ STATIC CONST UINT8 mVbeShim[] = {
> /* 0000023F pop ds */ 0x1F,
> /* 00000240 pop di */ 0x5F,
> /* 00000241 pop es */ 0x07,
> /* 00000242 jmp[-word-] 0x34c */ 0xE9, 0x07, 0x01,
> /* 00000245 push es */ 0x06,
> /* 00000246 push di */ 0x57,
> /* 00000247 push ds */ 0x1E,
> @@ -568,7 +568,7 @@ STATIC CONST UINT8 mVbeShim[] = {
> /* 00000263 pop ds */ 0x1F,
> /* 00000264 pop di */ 0x5F,
> /* 00000265 pop es */ 0x07,
> /* 00000266 jmp[-word-] 0x34c */ 0xE9, 0xE3, 0x00,
> /* 00000269 push dx */ 0x52,
> /* 0000026A push ax */ 0x50,
> /* 0000026B cmp bx,0x40f1 */ 0x81, 0xFB, 0xF1, 0x40,
> @@ -688,14 +688,14 @@ STATIC CONST UINT8 mVbeShim[] = {
> /* 0000033C jz 0x345 */ 0x74, 0x07,
> /* 0000033E cmp al,0x12 */ 0x3C, 0x12,
> /* 00000340 jz 0x349 */ 0x74, 0x07,
> /* 00000342 jmp[-word-] 0x22b */ 0xE9, 0xE6, 0xFE,
> /* 00000345 mov al,0x30 */ 0xB0, 0x30,
> /* 00000347 jmp short 0x34b */ 0xEB, 0x02,
> /* 00000349 mov al,0x20 */ 0xB0, 0x20,
> /* 0000034B [-iretw-]{+iret+} */ 0xCF,
> /* 0000034C mov ax,0x4f */ 0xB8, 0x4F, 0x00,
> /* 0000034F [-iretw-]{+iret+} */ 0xCF,
> /* 00000350 mov ax,0x14f */ 0xB8, 0x4F, 0x01,
> /* 00000353 [-iretw-]{+iret+} */ 0xCF,
> };
> #endif
>
> The nasm packaged is:
>
> $ nasm -v
> NASM version 2.13.03 compiled on Feb 2 2019
>
> While NASM 2.12 is documented here:
>
> https://github.com/tianocore/tianocore.github.io/wiki/Nasm-Setup
>
> Should I downgrade it?
I forgot, to have VbeShim.sh succeed, I also have this local change:
-- >8 --
diff --git a/OvmfPkg/QemuVideoDxe/VbeShim.sh
b/OvmfPkg/QemuVideoDxe/VbeShim.sh
index aea28be35f5c..92b345befe1f 100755
--- a/OvmfPkg/QemuVideoDxe/VbeShim.sh
+++ b/OvmfPkg/QemuVideoDxe/VbeShim.sh
@@ -28,7 +28,7 @@ trap exit_handler EXIT
#
# Assemble the source file.
#
-nasm -o "$STEM".bin -- "$STEM".asm
+nasm -fbin "$STEM".asm -o "$STEM".bin
#
# Disassemble it, in order to get a binary dump associated with the
source.
---
Because I had this error:
$ sh -x OvmfPkg/QemuVideoDxe/VbeShim.sh
[...]
++ dirname -- OvmfPkg/QemuVideoDxe/VbeShim.sh
++ basename -- OvmfPkg/QemuVideoDxe/VbeShim.sh .sh
+ STEM=OvmfPkg/QemuVideoDxe/VbeShim
+ trap exit_handler EXIT
+ nasm -o OvmfPkg/QemuVideoDxe/VbeShim.bin --
OvmfPkg/QemuVideoDxe/VbeShim.asm
nasm: error: more than one input file specified
nasm: error: more than one input file specified
nasm: error: more than one input file specified
type `nasm -h' for help
+ exit_handler
Which is rather confuse, because the help is still recommending the
current form:
$ nasm -h
usage: nasm [-@ response file] [-o outfile] [-f format] [-l listfile]
[options...] [--] filename
or nasm -v (or --v) for version info
-t assemble in SciTech TASM compatible mode
-E (or -e) preprocess only (writes output to stdout by default)
-a don't preprocess (assemble only)
-M generate Makefile dependencies on stdout
-MG d:o, missing files assumed generated
-MF <file> set Makefile dependency file
-MD <file> assemble and generate dependencies
-MT <file> dependency target name
-MQ <file> dependency target name (quoted)
-MP emit phony target
-Z<file> redirect error messages to file
-s redirect error messages to stdout
-g generate debugging information
-F format select a debugging format
-gformat same as -g -F format
-o outfile write output to an outfile
-f format select an output format
-l listfile write listing to a listfile
-I<path> adds a pathname to the include file path
-O<digit> optimize branch offsets
-O0: No optimization
-O1: Minimal optimization
-Ox: Multipass optimization (default)
-P<file> pre-includes a file
-D<macro>[=<value>] pre-defines a macro
-U<macro> undefines a macro
-X<format> specifies error reporting format (gnu or vc)
-w+foo enables warning foo (equiv. -Wfoo)
-w-foo disable warning foo (equiv. -Wno-foo)
-w[+-]error[=foo] can be used to promote warnings to errors
-h show invocation summary and exit
--prefix,--postfix
these options prepend or append the given string
to all extern and global variables
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [PATCH 58/79] OvmfPkg/Qemu: Fix various typos
2019-12-09 13:00 ` Philippe Mathieu-Daudé
@ 2019-12-09 16:12 ` Laszlo Ersek
0 siblings, 0 replies; 122+ messages in thread
From: Laszlo Ersek @ 2019-12-09 16:12 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, devel
Cc: Antoine Coeur, Jordan Justen, Ard Biesheuvel, Gerd Hoffmann
On 12/09/19 14:00, Philippe Mathieu-Daudé wrote:
> I forgot, to have VbeShim.sh succeed, I also have this local change:
>
> -- >8 --
> diff --git a/OvmfPkg/QemuVideoDxe/VbeShim.sh
> b/OvmfPkg/QemuVideoDxe/VbeShim.sh
> index aea28be35f5c..92b345befe1f 100755
> --- a/OvmfPkg/QemuVideoDxe/VbeShim.sh
> +++ b/OvmfPkg/QemuVideoDxe/VbeShim.sh
> @@ -28,7 +28,7 @@ trap exit_handler EXIT
> #
> # Assemble the source file.
> #
> -nasm -o "$STEM".bin -- "$STEM".asm
> +nasm -fbin "$STEM".asm -o "$STEM".bin
>
> #
> # Disassemble it, in order to get a binary dump associated with the
> source.
> ---
>
> Because I had this error:
>
> $ sh -x OvmfPkg/QemuVideoDxe/VbeShim.sh
> [...]
> ++ dirname -- OvmfPkg/QemuVideoDxe/VbeShim.sh
> ++ basename -- OvmfPkg/QemuVideoDxe/VbeShim.sh .sh
> + STEM=OvmfPkg/QemuVideoDxe/VbeShim
> + trap exit_handler EXIT
> + nasm -o OvmfPkg/QemuVideoDxe/VbeShim.bin --
> OvmfPkg/QemuVideoDxe/VbeShim.asm
> nasm: error: more than one input file specified
> nasm: error: more than one input file specified
> nasm: error: more than one input file specified
> type `nasm -h' for help
> + exit_handler
>
> Which is rather confuse, because the help is still recommending the
> current form:
>
> $ nasm -h
> usage: nasm [-@ response file] [-o outfile] [-f format] [-l listfile]
> [options...] [--] filename
> or nasm -v (or --v) for version info
>
> -t assemble in SciTech TASM compatible mode
> -E (or -e) preprocess only (writes output to stdout by default)
> -a don't preprocess (assemble only)
> -M generate Makefile dependencies on stdout
> -MG d:o, missing files assumed generated
> -MF <file> set Makefile dependency file
> -MD <file> assemble and generate dependencies
> -MT <file> dependency target name
> -MQ <file> dependency target name (quoted)
> -MP emit phony target
>
> -Z<file> redirect error messages to file
> -s redirect error messages to stdout
>
> -g generate debugging information
>
> -F format select a debugging format
>
> -gformat same as -g -F format
>
> -o outfile write output to an outfile
>
> -f format select an output format
>
> -l listfile write listing to a listfile
>
> -I<path> adds a pathname to the include file path
> -O<digit> optimize branch offsets
> -O0: No optimization
> -O1: Minimal optimization
> -Ox: Multipass optimization (default)
>
> -P<file> pre-includes a file
> -D<macro>[=<value>] pre-defines a macro
> -U<macro> undefines a macro
> -X<format> specifies error reporting format (gnu or vc)
> -w+foo enables warning foo (equiv. -Wfoo)
> -w-foo disable warning foo (equiv. -Wno-foo)
>
> -w[+-]error[=foo] can be used to promote warnings to errors
> -h show invocation summary and exit
>
> --prefix,--postfix
> these options prepend or append the given string
> to all extern and global variables
>
Yeah I think this is a NASM regression. In my version of NASM
(nasm-2.10.07-7.el7.x86_64, on RHEL7), the manual says, near "-f":
> To see a list of valid output formats, use the -hf option.
And when I invoke NASM like that, I get:
> valid output formats for -f are (`*' denotes default):
> * bin flat-form binary files (e.g. DOS .COM, .SYS)
So NASM either removed any default for "-f", or changed the default. Let
me check...
At upstream commit e91f5cc1322e ("preproc: fix %undef of macro aliases,
and add %ifdefalias", 2019-10-23), the source file "output/outform.h"
still contains:
> #ifndef OF_DEFAULT
> #define OF_DEFAULT of_bin
> #endif
This can be overridden when building NASM:
> * Default config = -DOF_ALL -DOF_DEFAULT=of_bin
However, if I check Fedora dist-git at commit 0150c8afb52f ("Rebuilt for
Python 3.8", 2019-08-19) (the HEAD of the f30 branch), then I do *not*
see any OF_DEFAULT mentions.
...
NASM in Fedora 30 seems to be based on 2.14.02. Upstream tag "nasm-2.14"
contains commit 987dc9c9dbe3 ("Make any execution limit configurable,
add eval limit", 2018-06-12). This commit seems to have changed how the
"--" options-terminator is processed:
> @@ -1068,25 +1062,61 @@ static bool process_arg(char *p, char *q, int pass)
> case '-':
> {
> const struct textargs *tx;
> + size_t olen, plen;
>
> - if (p[2] == 0) { /* -- => stop processing options */
> + p += 2;
> +
> + if (!*p) { /* -- => stop processing options */
> stopoptions = true;
> break;
> }
I don't know if this is actually the problem, it just looks related. Can
you report a bug in the upstream tracker? <https://bugzilla.nasm.us/>
If NASM upstream confirms the bug, then I'd like to request that you
please submit this patch for "OvmfPkg/QemuVideoDxe/VbeShim.sh",
including a comment to the upstream NASM bug report.
To be clear, the original -- now apparently broken -- NASM command line
follows the "Utility Syntax Guidelines" from POSIX:
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap12.html#tag_12_02
See in particular Guideline 9 ("All options should precede operands on
the command line") and Guideline 10 ("The first '--' argument that is
not an option-argument should be accepted as a delimiter indicating the
end of options"). Namely:
* '-o "$STEM".bin' is an option, taking an option-argument. Therefore it
should go first.
* The argument '--' is the end-of-options delimiter, which is generally
recommended every time an operand is substituted. (For example, if we
want to delete "$HELLO", we don't just write 'rm -rf "$HELLO"', but
"rm -rf -- "$HELLO".)
* The argument '"$STEM".asm' is an operand.
The command line that your patch adds:
- breaks Guideline 9, because it intermixes options and operands;
- breaks Guideline 6, because it contracts "-f" with "bin" into a single
argument, even though "-f" takes a mandatory -- i.e. not optional --
option-argument (such as "bin"). Per guideline 6, if an option
requires a mandatory option-argument, then the option itself, and its
argument, should be separate arguments.
I don't meant that your patch is wrong -- I mean that NASM could be
wrong to require us to use this syntax. Hence my request to file a bug
report for upstream NASM first.
Thank you!
Laszlo
^ permalink raw reply [flat|nested] 122+ messages in thread
* Re: [PATCH 58/79] OvmfPkg/Qemu: Fix various typos
2019-12-09 12:55 ` Philippe Mathieu-Daudé
2019-12-09 13:00 ` Philippe Mathieu-Daudé
@ 2019-12-09 15:44 ` Laszlo Ersek
1 sibling, 0 replies; 122+ messages in thread
From: Laszlo Ersek @ 2019-12-09 15:44 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, devel
Cc: Antoine Coeur, Jordan Justen, Ard Biesheuvel, Gerd Hoffmann
On 12/09/19 13:55, Philippe Mathieu-Daudé wrote:
> Hi Laszlo,
>
> On 12/3/19 10:00 PM, Laszlo Ersek wrote:
>> On 12/03/19 17:15, Philippe Mathieu-Daude wrote:
>>> From: Antoine Coeur <coeur@gmx.fr>
>>>
>>> Fix various typos in comments and documentation.
>>>
>>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
>>> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
>>> ---
>>> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf |
>>> 4 ++--
>>> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf |
>>> 4 ++--
>>> OvmfPkg/AcpiPlatformDxe/Qemu.c |
>>> 4 ++--
>>> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c |
>>> 2 +-
>>> OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c |
>>> 4 ++--
>>> OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c |
>>> 2 +-
>>> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c |
>>> 2 +-
>>> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbInfo.c |
>>> 4 ++--
>>> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c |
>>> 8 ++++----
>>> OvmfPkg/QemuVideoDxe/Driver.c |
>>> 2 +-
>>> OvmfPkg/QemuVideoDxe/VbeShim.asm |
>>> 14 +++++++-------
>>> 11 files changed, 25 insertions(+), 25 deletions(-)
>>>
> [...]>> diff --git a/OvmfPkg/QemuVideoDxe/VbeShim.asm
> b/OvmfPkg/QemuVideoDxe/VbeShim.asm
>>> index cb2a60d8278d..1d284b264124 100644
>>> --- a/OvmfPkg/QemuVideoDxe/VbeShim.asm
>>> +++ b/OvmfPkg/QemuVideoDxe/VbeShim.asm
>>> @@ -49,7 +49,7 @@ Handler:
>>> je ReadEdid
>>> cmp ah, 0x00
>>> je SetModeLegacy
>>> - DebugLog StrUnkownFunction
>>> + DebugLog StrUnknownFunction
>>> Hang:
>>> jmp Hang
>>> @@ -93,7 +93,7 @@ GetModeInfo:
>>> and cx, ~0x4000 ; clear potentially set LFB bit in mode
>>> number
>>> cmp cx, 0x00f1
>>> je KnownMode1
>>> - DebugLog StrUnkownMode
>>> + DebugLog StrUnknownMode
>>> jmp Hang
>>> KnownMode1:
>>> ; target (es:di) set on input
>>> @@ -155,7 +155,7 @@ SetMode:
>>> cmp bx, 0x40f1
>>> je KnownMode2
>>> - DebugLog StrUnkownMode
>>> + DebugLog StrUnknownMode
>>> jmp Hang
>>> KnownMode2:
>>> @@ -203,7 +203,7 @@ SetModeLegacy:
>>> je KnownMode3
>>> cmp al, 0x12
>>> je KnownMode4
>>> - DebugLog StrUnkownMode
>>> + DebugLog StrUnknownMode
>>> jmp Hang
>>> KnownMode3:
>>> mov al, 0x30
>>> @@ -252,7 +252,7 @@ StrExitSuccess:
>>> StrExitUnsupported:
>>> db 'Unsupported', 0x0a, 0
>>> -StrUnkownFunction:
>>> +StrUnknownFunction:
>>> db 'Unknown Function', 0x0a, 0
>>> StrEnterGetInfo:
>>> @@ -270,8 +270,8 @@ StrEnterSetMode:
>>> StrEnterSetModeLegacy:
>>> db 'SetModeLegacy', 0x0a, 0
>>> -StrUnkownMode:
>>> - db 'Unkown Mode', 0x0a, 0
>>> +StrUnknownMode:
>>> + db 'Unknown Mode', 0x0a, 0
>>> StrGetPmCapabilities:
>>> db 'GetPmCapabilities', 0x0a, 0
>>>
>>
>> If you modify "VbeShim.asm", then please re-run "VbeShim.sh", for
>> updating "VbeShim.h".
>
> The DEBUG macro at the head of VbeShim.asm is commented out:
>
> ;%define DEBUG
>
>
> So the string "Unknown Mode" is not used.
Hmmm, OK. I did realize that DEBUG was commented out, and that that made
"StrUnkownMode" un-referenced.
However, I didn't know that NASM would eliminate unreferenced data.
>
> Side note, running VbeShim.sh on Fedora 30 I get:
>
> $ git diff --word-diff
> --- a/OvmfPkg/QemuVideoDxe/VbeShim.h
> +++ b/OvmfPkg/QemuVideoDxe/VbeShim.h
> @@ -523,13 +523,13 @@ STATIC CONST UINT8 mVbeShim[] = {
> /* 0000020A cmp ax,0x4f02 */ 0x3D, 0x02, 0x4F,
> /* 0000020D jz 0x269 */ 0x74, 0x5A,
> /* 0000020F cmp ax,0x4f03 */ 0x3D, 0x03, 0x4F,
> /* 00000212 jz [-word-]{+near+} 0x331 */ 0x0F, 0x84,
> 0x1B, 0x01,
> /* 00000216 cmp ax,0x4f10 */ 0x3D, 0x10, 0x4F,
> /* 00000219 jz [-word-]{+near+} 0x336 */ 0x0F, 0x84,
> 0x19, 0x01,
> /* 0000021D cmp ax,0x4f15 */ 0x3D, 0x15, 0x4F,
> /* 00000220 jz [-word-]{+near+} 0x338 */ 0x0F, 0x84,
> 0x14, 0x01,
> /* 00000224 cmp ah,0x0 */ 0x80, 0xFC, 0x00,
> /* 00000227 jz [-word-]{+near+} 0x33a */ 0x0F, 0x84,
> 0x0F, 0x01,
> /* 0000022B jmp short 0x22b */ 0xEB, 0xFE,
> /* 0000022D push es */ 0x06,
> /* 0000022E push di */ 0x57,
> @@ -547,7 +547,7 @@ STATIC CONST UINT8 mVbeShim[] = {
> /* 0000023F pop ds */ 0x1F,
> /* 00000240 pop di */ 0x5F,
> /* 00000241 pop es */ 0x07,
> /* 00000242 jmp[-word-] 0x34c */ 0xE9, 0x07, 0x01,
> /* 00000245 push es */ 0x06,
> /* 00000246 push di */ 0x57,
> /* 00000247 push ds */ 0x1E,
> @@ -568,7 +568,7 @@ STATIC CONST UINT8 mVbeShim[] = {
> /* 00000263 pop ds */ 0x1F,
> /* 00000264 pop di */ 0x5F,
> /* 00000265 pop es */ 0x07,
> /* 00000266 jmp[-word-] 0x34c */ 0xE9, 0xE3, 0x00,
> /* 00000269 push dx */ 0x52,
> /* 0000026A push ax */ 0x50,
> /* 0000026B cmp bx,0x40f1 */ 0x81, 0xFB, 0xF1, 0x40,
> @@ -688,14 +688,14 @@ STATIC CONST UINT8 mVbeShim[] = {
> /* 0000033C jz 0x345 */ 0x74, 0x07,
> /* 0000033E cmp al,0x12 */ 0x3C, 0x12,
> /* 00000340 jz 0x349 */ 0x74, 0x07,
> /* 00000342 jmp[-word-] 0x22b */ 0xE9, 0xE6, 0xFE,
> /* 00000345 mov al,0x30 */ 0xB0, 0x30,
> /* 00000347 jmp short 0x34b */ 0xEB, 0x02,
> /* 00000349 mov al,0x20 */ 0xB0, 0x20,
> /* 0000034B [-iretw-]{+iret+} */ 0xCF,
> /* 0000034C mov ax,0x4f */ 0xB8, 0x4F, 0x00,
> /* 0000034F [-iretw-]{+iret+} */ 0xCF,
> /* 00000350 mov ax,0x14f */ 0xB8, 0x4F, 0x01,
> /* 00000353 [-iretw-]{+iret+} */ 0xCF,
> };
> #endif
>
> The nasm packaged is:
>
> $ nasm -v
> NASM version 2.13.03 compiled on Feb 2 2019
>
> While NASM 2.12 is documented here:
>
> https://github.com/tianocore/tianocore.github.io/wiki/Nasm-Setup
>
> Should I downgrade it?
>
No, don't bother, just please update the commit message that the byte
array in "VbeShim.h" does *not* change, as a result of this patch.
With the commit message update:
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-60-philmd@redhat.com>]
* Re: [PATCH 59/79] OvmfPkg/Virtio: Fix few typos
[not found] ` <20191203161602.15969-60-philmd@redhat.com>
@ 2019-12-03 21:00 ` Laszlo Ersek
0 siblings, 0 replies; 122+ messages in thread
From: Laszlo Ersek @ 2019-12-03 21:00 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel
Cc: Antoine Coeur, Jordan Justen, Ard Biesheuvel
On 12/03/19 17:15, Philippe Mathieu-Daude wrote:
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix few typos in comments and documentation.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> OvmfPkg/Include/Library/VirtioLib.h | 2 +-
> OvmfPkg/Library/VirtioLib/VirtioLib.c | 2 +-
> OvmfPkg/VirtioNetDxe/DriverBinding.c | 2 +-
> OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c | 2 +-
> OvmfPkg/VirtioRngDxe/VirtioRng.c | 2 +-
> OvmfPkg/VirtioScsiDxe/VirtioScsi.c | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/OvmfPkg/Include/Library/VirtioLib.h b/OvmfPkg/Include/Library/VirtioLib.h
> index e817a4206f62..e714ec7aee50 100644
> --- a/OvmfPkg/Include/Library/VirtioLib.h
> +++ b/OvmfPkg/Include/Library/VirtioLib.h
> @@ -292,7 +292,7 @@ Virtio10WriteFeatures (
> VIRTIO_UNMAP_SHARED.
>
>
> - @retval EFI_SUCCESS The NumberOfBytes is succesfully mapped.
> + @retval EFI_SUCCESS The NumberOfBytes is successfully mapped.
> @retval EFI_UNSUPPORTED The HostAddress cannot be mapped as a
> common buffer.
> @retval EFI_INVALID_PARAMETER One or more parameters are invalid.
> diff --git a/OvmfPkg/Library/VirtioLib/VirtioLib.c b/OvmfPkg/Library/VirtioLib/VirtioLib.c
> index 555d2a5ce7c9..e09324813c2d 100644
> --- a/OvmfPkg/Library/VirtioLib/VirtioLib.c
> +++ b/OvmfPkg/Library/VirtioLib/VirtioLib.c
> @@ -452,7 +452,7 @@ Virtio10WriteFeatures (
> VIRTIO_UNMAP_SHARED.
>
>
> - @retval EFI_SUCCESS The NumberOfBytes is succesfully mapped.
> + @retval EFI_SUCCESS The NumberOfBytes is successfully mapped.
> @retval EFI_UNSUPPORTED The HostAddress cannot be mapped as a
> common buffer.
> @retval EFI_INVALID_PARAMETER One or more parameters are invalid.
> diff --git a/OvmfPkg/VirtioNetDxe/DriverBinding.c b/OvmfPkg/VirtioNetDxe/DriverBinding.c
> index eb0e873657a4..3c400a604650 100644
> --- a/OvmfPkg/VirtioNetDxe/DriverBinding.c
> +++ b/OvmfPkg/VirtioNetDxe/DriverBinding.c
> @@ -419,7 +419,7 @@ VirtioNetDriverBindingSupported (
> device error.Currently not implemented.
> @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a
> lack of resources.
> - @retval Others The driver failded to start the device.
> + @retval Others The driver failed to start the device.
>
> **/
>
> diff --git a/OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c b/OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c
> index dc684650d665..d1e3ecfa5a0f 100644
> --- a/OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c
> +++ b/OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c
> @@ -118,7 +118,7 @@ VirtioNetUninitRing (
> a lack of resources.
> @return Status codes from
> VirtioMapAllBytesInSharedBuffer()
> - @retval EFI_SUCCESS Caller-supplied buffer is succesfully mapped.
> + @retval EFI_SUCCESS Caller-supplied buffer is successfully mapped.
> */
> EFI_STATUS
> EFIAPI
> diff --git a/OvmfPkg/VirtioRngDxe/VirtioRng.c b/OvmfPkg/VirtioRngDxe/VirtioRng.c
> index d0e2468c2373..4e2b710f9e49 100644
> --- a/OvmfPkg/VirtioRngDxe/VirtioRng.c
> +++ b/OvmfPkg/VirtioRngDxe/VirtioRng.c
> @@ -156,7 +156,7 @@ VirtioRngGetRNG (
>
> Dev = VIRTIO_ENTROPY_SOURCE_FROM_RNG (This);
> //
> - // Map Buffer's system phyiscal address to device address
> + // Map Buffer's system physical address to device address
> //
> Status = VirtioMapAllBytesInSharedBuffer (
> Dev->VirtIo,
> diff --git a/OvmfPkg/VirtioScsiDxe/VirtioScsi.c b/OvmfPkg/VirtioScsiDxe/VirtioScsi.c
> index e50a697daa15..935d15439579 100644
> --- a/OvmfPkg/VirtioScsiDxe/VirtioScsi.c
> +++ b/OvmfPkg/VirtioScsiDxe/VirtioScsi.c
> @@ -497,7 +497,7 @@ VirtioScsiPassThru (
> // * we perform the request fine
> // * but we fail to unmap the "InDataMapping"
> //
> - // In that case simply returing the EFI_DEVICE_ERROR is not sufficient. In
> + // In that case simply returning the EFI_DEVICE_ERROR is not sufficient. In
> // addition to the error code we also need to update Packet fields
> // accordingly so that we report the full loss of the incoming transfer.
> //
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-80-philmd@redhat.com>]
* Re: [PATCH 79/79] UefiCpuPkg/Smm: Fix various typos
[not found] ` <20191203161602.15969-80-philmd@redhat.com>
@ 2019-12-03 21:05 ` Laszlo Ersek
2019-12-06 7:24 ` Dong, Eric
1 sibling, 0 replies; 122+ messages in thread
From: Laszlo Ersek @ 2019-12-03 21:05 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel; +Cc: Antoine Coeur, Eric Dong, Ray Ni
On 12/03/19 17:16, Philippe Mathieu-Daude wrote:
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h | 4 ++--
> UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h | 4 ++--
> UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c | 4 ++--
> UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c | 2 +-
> UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 4 ++--
> UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c | 4 ++--
> UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm | 2 +-
> 7 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h b/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h
> index 39ca304b31e6..dbcd57e0ad42 100644
> --- a/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h
> +++ b/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h
> @@ -338,7 +338,7 @@ SmmCpuFeaturesSetSmmRegister (
> from the save state.
>
> @retval EFI_SUCCESS The register was read from Save State.
> - @retval EFI_INVALID_PARAMTER Buffer is NULL.
> + @retval EFI_INVALID_PARAMETER Buffer is NULL.
> @retval EFI_UNSUPPORTED This function does not support reading Register.
>
> **/
> @@ -364,7 +364,7 @@ SmmCpuFeaturesReadSaveStateRegister (
> @param[in] Buffer Upon entry, this holds the new CPU register value.
>
> @retval EFI_SUCCESS The register was written to Save State.
> - @retval EFI_INVALID_PARAMTER Buffer is NULL.
> + @retval EFI_INVALID_PARAMETER Buffer is NULL.
> @retval EFI_UNSUPPORTED This function does not support writing Register.
> **/
> EFI_STATUS
> diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h
> index 018e918360d3..da551cc4a6a6 100644
> --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h
> +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h
> @@ -138,7 +138,7 @@ GetPiResource (
> );
>
> /**
> - This functin initialize STM configuration table.
> + This function initialize STM configuration table.
> **/
> VOID
> StmSmmConfigurationTableInit (
> @@ -169,7 +169,7 @@ GetStmResource (
>
> /**
> This function fixes up the address of the global variable or function
> - referred in SmiEntry assembly files to be the absoute address.
> + referred in SmiEntry assembly files to be the absolute address.
> **/
> VOID
> EFIAPI
> diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
> index 72c2aeca4c13..6a2670d55918 100644
> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
> @@ -68,7 +68,7 @@ CommonExceptionHandlerWorker (
> //
> ArchRestoreExceptionContext (ExceptionType, SystemContext, ExceptionHandlerData);
> //
> - // Rlease spin lock for ApicId
> + // Release spin lock for ApicId
> //
> ReleaseSpinLock (&ReservedVectors[ExceptionType].SpinLock);
> break;
> @@ -230,7 +230,7 @@ InitializeCpuExceptionHandlersWorker (
> IdtEntryCount = (IdtDescriptor.Limit + 1) / sizeof (IA32_IDT_GATE_DESCRIPTOR);
> if (IdtEntryCount > CPU_EXCEPTION_NUM) {
> //
> - // CPU exeption library only setup CPU_EXCEPTION_NUM exception handler at most
> + // CPU exception library only setup CPU_EXCEPTION_NUM exception handler at most
> //
> IdtEntryCount = CPU_EXCEPTION_NUM;
> }
> diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c
> index ec705fc489af..e7977d49b771 100644
> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c
> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c
> @@ -1,5 +1,5 @@
> /** @file
> - CPU exception handler library implemenation for SMM modules.
> + CPU exception handler library implementation for SMM modules.
>
> Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c
> index bddb7a219ce4..a00786a8ebef 100644
> --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c
> +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c
> @@ -540,7 +540,7 @@ SmmCpuFeaturesSetSmmRegister (
> from the save state.
>
> @retval EFI_SUCCESS The register was read from Save State.
> - @retval EFI_INVALID_PARAMTER Buffer is NULL.
> + @retval EFI_INVALID_PARAMETER Buffer is NULL.
> @retval EFI_UNSUPPORTED This function does not support reading Register.
>
> **/
> @@ -569,7 +569,7 @@ SmmCpuFeaturesReadSaveStateRegister (
> @param[in] Buffer Upon entry, this holds the new CPU register value.
>
> @retval EFI_SUCCESS The register was written to Save State.
> - @retval EFI_INVALID_PARAMTER Buffer is NULL.
> + @retval EFI_INVALID_PARAMETER Buffer is NULL.
> @retval EFI_UNSUPPORTED This function does not support writing Register.
> **/
> EFI_STATUS
> diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c
> index 52a376c27db1..f7f8afacffb5 100644
> --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c
> +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c
> @@ -913,7 +913,7 @@ AddPiResource (
> }
>
> //
> - // Copy EndResource for intialization
> + // Copy EndResource for initialization
> //
> mStmResourcesPtr = (UINT8 *)(UINTN)NewResource;
> mStmResourceTotalSize = NewResourceSize;
> @@ -1236,7 +1236,7 @@ LoadMonitor (
> /**
> This function return BIOS STM resource.
> Produced by SmmStm.
> - Comsumed by SmmMpService when Init.
> + Consumed by SmmMpService when Init.
>
> @return BIOS STM resource
>
> diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm b/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm
> index 5ee846e4f9ea..f09d8df1e6bc 100644
> --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm
> +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm
> @@ -15,7 +15,7 @@
> %include "StuffRsbNasm.inc"
>
> ;
> -; Variables referrenced by C code
> +; Variables referenced by C code
> ;
>
> %define MSR_IA32_MISC_ENABLE 0x1A0
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 122+ messages in thread* Re: [PATCH 79/79] UefiCpuPkg/Smm: Fix various typos
[not found] ` <20191203161602.15969-80-philmd@redhat.com>
2019-12-03 21:05 ` [PATCH 79/79] UefiCpuPkg/Smm: Fix various typos Laszlo Ersek
@ 2019-12-06 7:24 ` Dong, Eric
1 sibling, 0 replies; 122+ messages in thread
From: Dong, Eric @ 2019-12-06 7:24 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Ni, Ray, Laszlo Ersek
Reviewed-by: Eric Dong <eric.dong@intel.com>
> -----Original Message-----
> From: Philippe Mathieu-Daude [mailto:philmd@redhat.com]
> Sent: Wednesday, December 4, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Dong, Eric <eric.dong@intel.com>; Ni,
> Ray <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com>; Philippe
> Mathieu-Daude <philmd@redhat.com>
> Subject: [PATCH 79/79] UefiCpuPkg/Smm: Fix various typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h | 4 ++--
> UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h | 4 ++--
> UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c |
> 4 ++--
> UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c | 2 +-
> UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 4 ++-
> -
> UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c | 4 ++--
> UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm | 2 +-
> 7 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h
> b/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h
> index 39ca304b31e6..dbcd57e0ad42 100644
> --- a/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h
> +++ b/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h
> @@ -338,7 +338,7 @@ SmmCpuFeaturesSetSmmRegister (
> from the save state.
>
> @retval EFI_SUCCESS The register was read from Save State.
> - @retval EFI_INVALID_PARAMTER Buffer is NULL.
> + @retval EFI_INVALID_PARAMETER Buffer is NULL.
> @retval EFI_UNSUPPORTED This function does not support reading
> Register.
>
> **/
> @@ -364,7 +364,7 @@ SmmCpuFeaturesReadSaveStateRegister (
> @param[in] Buffer Upon entry, this holds the new CPU register value.
>
> @retval EFI_SUCCESS The register was written to Save State.
> - @retval EFI_INVALID_PARAMTER Buffer is NULL.
> + @retval EFI_INVALID_PARAMETER Buffer is NULL.
> @retval EFI_UNSUPPORTED This function does not support writing
> Register.
> **/
> EFI_STATUS
> diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h
> b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h
> index 018e918360d3..da551cc4a6a6 100644
> --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h
> +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h
> @@ -138,7 +138,7 @@ GetPiResource (
> );
>
> /**
> - This functin initialize STM configuration table.
> + This function initialize STM configuration table.
> **/
> VOID
> StmSmmConfigurationTableInit (
> @@ -169,7 +169,7 @@ GetStmResource (
>
> /**
> This function fixes up the address of the global variable or function
> - referred in SmiEntry assembly files to be the absoute address.
> + referred in SmiEntry assembly files to be the absolute address.
> **/
> VOID
> EFIAPI
> diff --git
> a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
> b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
> index 72c2aeca4c13..6a2670d55918 100644
> ---
> a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
> +++
> b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
> @@ -68,7 +68,7 @@ CommonExceptionHandlerWorker (
> //
> ArchRestoreExceptionContext (ExceptionType, SystemContext,
> ExceptionHandlerData);
> //
> - // Rlease spin lock for ApicId
> + // Release spin lock for ApicId
> //
> ReleaseSpinLock (&ReservedVectors[ExceptionType].SpinLock);
> break;
> @@ -230,7 +230,7 @@ InitializeCpuExceptionHandlersWorker (
> IdtEntryCount = (IdtDescriptor.Limit + 1) / sizeof
> (IA32_IDT_GATE_DESCRIPTOR);
> if (IdtEntryCount > CPU_EXCEPTION_NUM) {
> //
> - // CPU exeption library only setup CPU_EXCEPTION_NUM exception
> handler at most
> + // CPU exception library only setup CPU_EXCEPTION_NUM exception
> + handler at most
> //
> IdtEntryCount = CPU_EXCEPTION_NUM;
> }
> diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c
> b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c
> index ec705fc489af..e7977d49b771 100644
> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c
> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c
> @@ -1,5 +1,5 @@
> /** @file
> - CPU exception handler library implemenation for SMM modules.
> + CPU exception handler library implementation for SMM modules.
>
> Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent diff --git
> a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c
> b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c
> index bddb7a219ce4..a00786a8ebef 100644
> --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c
> +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c
> @@ -540,7 +540,7 @@ SmmCpuFeaturesSetSmmRegister (
> from the save state.
>
> @retval EFI_SUCCESS The register was read from Save State.
> - @retval EFI_INVALID_PARAMTER Buffer is NULL.
> + @retval EFI_INVALID_PARAMETER Buffer is NULL.
> @retval EFI_UNSUPPORTED This function does not support reading
> Register.
>
> **/
> @@ -569,7 +569,7 @@ SmmCpuFeaturesReadSaveStateRegister (
> @param[in] Buffer Upon entry, this holds the new CPU register value.
>
> @retval EFI_SUCCESS The register was written to Save State.
> - @retval EFI_INVALID_PARAMTER Buffer is NULL.
> + @retval EFI_INVALID_PARAMETER Buffer is NULL.
> @retval EFI_UNSUPPORTED This function does not support writing
> Register.
> **/
> EFI_STATUS
> diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c
> b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c
> index 52a376c27db1..f7f8afacffb5 100644
> --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c
> +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c
> @@ -913,7 +913,7 @@ AddPiResource (
> }
>
> //
> - // Copy EndResource for intialization
> + // Copy EndResource for initialization
> //
> mStmResourcesPtr = (UINT8 *)(UINTN)NewResource;
> mStmResourceTotalSize = NewResourceSize; @@ -1236,7 +1236,7 @@
> LoadMonitor (
> /**
> This function return BIOS STM resource.
> Produced by SmmStm.
> - Comsumed by SmmMpService when Init.
> + Consumed by SmmMpService when Init.
>
> @return BIOS STM resource
>
> diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm
> b/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm
> index 5ee846e4f9ea..f09d8df1e6bc 100644
> --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm
> +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm
> @@ -15,7 +15,7 @@
> %include "StuffRsbNasm.inc"
>
> ;
> -; Variables referrenced by C code
> +; Variables referenced by C code
> ;
>
> %define MSR_IA32_MISC_ENABLE 0x1A0
> --
> 2.21.0
^ permalink raw reply [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-73-philmd@redhat.com>]
* Re: [PATCH 72/79] SourceLevelDebugPkg/DebugAgent: Fix various typos
[not found] ` <20191203161602.15969-73-philmd@redhat.com>
@ 2019-12-04 1:03 ` Wu, Hao A
0 siblings, 0 replies; 122+ messages in thread
From: Wu, Hao A @ 2019-12-04 1:03 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io; +Cc: Antoine Coeur
> -----Original Message-----
> From: Philippe Mathieu-Daude [mailto:philmd@redhat.com]
> Sent: Wednesday, December 04, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur; Wu, Hao A; Philippe Mathieu-Daude
> Subject: [PATCH 72/79] SourceLevelDebugPkg/DebugAgent: Fix various typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in documentation, comments and debug strings.
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h
> | 6 +--
>
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/ArchDe
> bugSupport.h | 2 +-
>
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/DebugE
> xception.h | 2 +-
>
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/ArchDeb
> ugSupport.h | 2 +-
>
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/DebugEx
> ception.h | 2 +-
> SourceLevelDebugPkg/DebugAgentDxe/DebugAgentDxe.c |
> 2 +-
> SourceLevelDebugPkg/DebugAgentPei/DebugAgentPei.c | 2
> +-
>
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.
> c | 52 ++++++++++----------
>
> SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/DxeDebugAgentLi
> b.c | 2 +-
> SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c
> | 6 +--
>
> SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAg
> entLib.c | 10 ++--
>
> SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebugAgent
> Lib.c | 10 ++--
>
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/AsmFun
> cs.nasm | 4 +-
> 13 files changed, 51 insertions(+), 51 deletions(-)
>
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.
> h
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.
> h
> index 71d7802d1548..07ddccad335d 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.
> h
> +++
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.
> h
> @@ -17,7 +17,7 @@ typedef struct {
> } DEBUG_CPU_DATA;
>
> typedef struct {
> - SPIN_LOCK MpContextSpinLock; ///< Lock for writting MP context
> + SPIN_LOCK MpContextSpinLock; ///< Lock for writing MP context
> SPIN_LOCK DebugPortSpinLock; ///< Lock for access debug port
> SPIN_LOCK MailboxSpinLock; ///< Lock for accessing mail box
> UINT8 CpuBreakMask[DEBUG_CPU_MAX_COUNT/8]; ///<
> Bitmask of all breaking CPUs
> @@ -26,8 +26,8 @@ typedef struct {
> UINT32 BspIndex; ///< Processor index value of BSP
> UINT32 BreakAtCpuIndex; ///< Processor index value of the
> current breaking CPU
> UINT32 DebugTimerInitCount; ///< Record BSP's init timer count
> - BOOLEAN IpiSentByAp; ///< TRUR: IPI is sent by AP. TALSE: IPI
> is sent by BSP
> - BOOLEAN RunCommandSet; ///< TRUE: RUN commmand is
> executing. FALSE : RUN command has been executed.
> + BOOLEAN IpiSentByAp; ///< TRUE: IPI is sent by AP. FALSE: IPI
> is sent by BSP
> + BOOLEAN RunCommandSet; ///< TRUE: RUN command is
> executing. FALSE: RUN command has been executed.
> } DEBUG_MP_CONTEXT;
>
> extern DEBUG_MP_CONTEXT volatile mDebugMpContext;
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/Arch
> DebugSupport.h
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/Arch
> DebugSupport.h
> index d816bdaecdbe..3acb0352bf76 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/Arch
> DebugSupport.h
> +++
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/Arch
> DebugSupport.h
> @@ -1,5 +1,5 @@
> /** @file
> - IA32 specific defintions for debug agent library instance.
> + IA32 specific definitions for debug agent library instance.
>
> Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/Debu
> gException.h
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/Debu
> gException.h
> index 750b3e4724eb..9147fabe6c3e 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/Debu
> gException.h
> +++
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/Debu
> gException.h
> @@ -1,5 +1,5 @@
> /** @file
> - Exception defintions.
> + Exception definitions.
>
> Copyright (c) 2010, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/ArchD
> ebugSupport.h
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/ArchD
> ebugSupport.h
> index 4ee12b771e9c..1e45941a9927 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/ArchD
> ebugSupport.h
> +++
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/ArchD
> ebugSupport.h
> @@ -1,5 +1,5 @@
> /** @file
> - X64 specific defintions for debug agent library instance.
> + X64 specific definitions for debug agent library instance.
>
> Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/Debug
> Exception.h
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/Debug
> Exception.h
> index 750b3e4724eb..9147fabe6c3e 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/Debug
> Exception.h
> +++
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/Debug
> Exception.h
> @@ -1,5 +1,5 @@
> /** @file
> - Exception defintions.
> + Exception definitions.
>
> Copyright (c) 2010, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> diff --git a/SourceLevelDebugPkg/DebugAgentDxe/DebugAgentDxe.c
> b/SourceLevelDebugPkg/DebugAgentDxe/DebugAgentDxe.c
> index 7ed4edb810a1..33fc9f3646dc 100644
> --- a/SourceLevelDebugPkg/DebugAgentDxe/DebugAgentDxe.c
> +++ b/SourceLevelDebugPkg/DebugAgentDxe/DebugAgentDxe.c
> @@ -41,7 +41,7 @@ DisableDebugTimerExitBootService (
> @param[in] SystemTable A pointer to the EFI System Table.
>
> @retval EFI_SUCCESS The entry point is executed successfully.
> - @retval other Some error occurs when initialzed Debug Agent.
> + @retval other Some error occurs when initialized Debug Agent.
>
> **/
> EFI_STATUS
> diff --git a/SourceLevelDebugPkg/DebugAgentPei/DebugAgentPei.c
> b/SourceLevelDebugPkg/DebugAgentPei/DebugAgentPei.c
> index 4ef1945cd88e..fc2a8f75abf7 100644
> --- a/SourceLevelDebugPkg/DebugAgentPei/DebugAgentPei.c
> +++ b/SourceLevelDebugPkg/DebugAgentPei/DebugAgentPei.c
> @@ -21,7 +21,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> @param[in] PeiServices Pointer to PEI Services Table
>
> @retval EFI_SUCCESS Debug Agent successfully initialized.
> - @retval other Some error occurs when initialzed Debug Agent.
> + @retval other Some error occurs when initialized Debug Agent.
>
> **/
> EFI_STATUS
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAge
> nt.c
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAge
> nt.c
> index 3ab4a81589c8..8021437ca903 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAge
> nt.c
> +++
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAge
> nt.c
> @@ -1,5 +1,5 @@
> /** @file
> - Commond Debug Agent library implementition. It mainly includes
> + Commond Debug Agent library implementation. It mainly includes
> the first C function called by exception/interrupt handlers,
> read/write debug packet to communication with HOST based on transfer
> protocol.
> @@ -594,7 +594,7 @@ DebugAgentDataMsgPrint (
> Index ++;
> if (Index >= Length) {
> //
> - // The last character of debug message has been foramtted in buffer
> + // The last character of debug message has been formatted in buffer
> //
> DestBuffer += AsciiSPrint(DestBuffer,
> DEBUG_DATA_MAXIMUM_REAL_DATA - (DestBuffer - Buffer), "]\n");
> SendDebugMsgPacket (Buffer, DestBuffer - Buffer);
> @@ -723,7 +723,7 @@ SetDebugSetting (
> }
>
> /**
> - Exectue GO command.
> + Execute GO command.
>
> @param[in] CpuContext Pointer to saved CPU context.
>
> @@ -1081,12 +1081,12 @@ DecompressDataInPlace (
> @param[out] IncompatibilityFlag If IncompatibilityFlag is not NULL, return
> TRUE: Compatible packet received.
> FALSE: Incompatible packet received.
> - @param[in] Timeout Time out value to wait for acknowlege from
> HOST.
> + @param[in] Timeout Time out value to wait for acknowledge from
> HOST.
> The unit is microsecond.
> @param[in] SkipStartSymbol TRUE: Skip time out when reading start
> symbol.
> FALSE: Does not Skip time out when reading start symbol.
>
> - @retval RETURN_SUCCESS A valid package was reveived in InputPacket.
> + @retval RETURN_SUCCESS A valid package was received in InputPacket.
> @retval RETURN_TIMEOUT Timeout occurs.
>
> **/
> @@ -1190,17 +1190,17 @@ ReceivePacket (
> Receive acknowledge packet OK from HOST in specified time.
>
> @param[in] Command The command type issued by TARGET.
> - @param[in] Timeout Time out value to wait for acknowlege from
> HOST.
> + @param[in] Timeout Time out value to wait for acknowledge from
> HOST.
> The unit is microsecond.
> @param[out] BreakReceived If BreakReceived is not NULL,
> - TRUE is retured if break-in symbol received.
> - FALSE is retured if break-in symbol not received.
> + TRUE is returned if break-in symbol received.
> + FALSE is returned if break-in symbol not received.
> @param[out] IncompatibilityFlag If IncompatibilityFlag is not NULL, return
> TRUE: Compatible packet received.
> FALSE: Incompatible packet received.
>
> - @retval RETRUEN_SUCCESS Succeed to receive acknowlege packet from
> HOST,
> - the type of acknowlege packet saved in Ack.
> + @retval RETURN_SUCCESS Succeed to receive acknowledge packet from
> HOST,
> + the type of acknowledge packet saved in Ack.
> @retval RETURN_TIMEOUT Specified timeout value was up.
>
> **/
> @@ -1497,7 +1497,7 @@ CompressData (
> }
>
> /**
> - Read memory with speicifed width and send packet with response data to
> HOST.
> + Read memory with specified width and send packet with response data to
> HOST.
>
> @param[in] Data Pointer to response data buffer.
> @param[in] Count The number of data with specified Width.
> @@ -1669,16 +1669,16 @@ SendDataResponsePacket (
> Try to attach the HOST.
>
> Send init break packet to HOST:
> - If no acknowlege received in specified Timeout, return RETURN_TIMEOUT.
> - If received acknowlege, check the revision of HOST.
> + If no acknowledge received in specified Timeout, return RETURN_TIMEOUT.
> + If received acknowledge, check the revision of HOST.
> Set Attach Flag if attach successfully.
>
> @param[in] BreakCause Break cause of this break event.
> - @param[in] Timeout Time out value to wait for acknowlege from HOST.
> + @param[in] Timeout Time out value to wait for acknowledge from
> HOST.
> The unit is microsecond.
> @param[out] BreakReceived If BreakReceived is not NULL,
> - TRUE is retured if break-in symbol received.
> - FALSE is retured if break-in symbol not received.
> + TRUE is returned if break-in symbol received.
> + FALSE is returned if break-in symbol not received.
> **/
> RETURN_STATUS
> AttachHost (
> @@ -1732,8 +1732,8 @@ AttachHost (
> @param[in] BreakCause Break cause of this break event.
> @param[in] ProcessorIndex Processor index value.
> @param[out] BreakReceived If BreakReceived is not NULL,
> - TRUE is retured if break-in symbol received.
> - FALSE is retured if break-in symbol not received.
> + TRUE is returned if break-in symbol received.
> + FALSE is returned if break-in symbol not received.
>
> **/
> VOID
> @@ -1777,7 +1777,7 @@ SendBreakPacketToHost (
>
> It received the command packet from HOST, and sent response data packet
> to HOST.
>
> - @param[in] Vector Vector value of exception or interrutp.
> + @param[in] Vector Vector value of exception or interrupt.
> @param[in, out] CpuContext Pointer to saved CPU context.
> @param[in] BreakReceived TRUE means break-in symbol received.
> FALSE means break-in symbol not received.
> @@ -1881,20 +1881,20 @@ CommandCommunication (
>
> Mailbox = GetMailboxPointer ();
> if (DebugHeader->SequenceNo == Mailbox->HostSequenceNo) {
> - DebugAgentMsgPrint (DEBUG_AGENT_WARNING, "TARGET: Receive one
> old command[%x] agaist command[%x]\n", DebugHeader->SequenceNo,
> Mailbox->HostSequenceNo);
> + DebugAgentMsgPrint (DEBUG_AGENT_WARNING, "TARGET: Receive one
> old command[%x] against command[%x]\n", DebugHeader->SequenceNo,
> Mailbox->HostSequenceNo);
> SendAckPacket (Mailbox->LastAck);
> ReleaseMpSpinLock (&mDebugMpContext.DebugPortSpinLock);
> continue;
> } else if (DebugHeader->SequenceNo == (UINT8) (Mailbox->HostSequenceNo
> + 1)) {
> UpdateMailboxContent (Mailbox,
> DEBUG_MAILBOX_HOST_SEQUENCE_NO_INDEX, (UINT8) DebugHeader-
> >SequenceNo);
> } else {
> - DebugAgentMsgPrint (DEBUG_AGENT_WARNING, "Receive one invalid
> comamnd[%x] agaist command[%x]\n", DebugHeader->SequenceNo, Mailbox-
> >HostSequenceNo);
> + DebugAgentMsgPrint (DEBUG_AGENT_WARNING, "Receive one invalid
> command[%x] against command[%x]\n", DebugHeader->SequenceNo, Mailbox-
> >HostSequenceNo);
> ReleaseMpSpinLock (&mDebugMpContext.DebugPortSpinLock);
> continue;
> }
>
> //
> - // Save CPU content before executing HOST commond
> + // Save CPU content before executing HOST command
> //
> UpdateMailboxContent (Mailbox,
> DEBUG_MAILBOX_EXCEPTION_BUFFER_POINTER_INDEX, (UINT64)(UINTN)
> &AgentExceptionBuffer.JumpBuffer);
> if (SetJump (&AgentExceptionBuffer.JumpBuffer) != 0) {
> @@ -2019,7 +2019,7 @@ CommandCommunication (
>
> } else {
> //
> - // If reveived HALT command, need to defer the GO command
> + // If received HALT command, need to defer the GO command
> //
> SendAckPacket (DEBUG_COMMAND_HALT_PROCESSED);
> HaltDeferred = FALSE;
> @@ -2300,7 +2300,7 @@ CommandCommunication (
> /**
> C function called in interrupt handler.
>
> - @param[in] Vector Vector value of exception or interrutp.
> + @param[in] Vector Vector value of exception or interrupt.
> @param[in] CpuContext Pointer to save CPU context.
>
> **/
> @@ -2341,7 +2341,7 @@ InterruptProcess (
> if (MultiProcessorDebugSupport()) {
> ProcessorIndex = GetProcessorIndex ();
> //
> - // If this processor has alreay halted before, need to check it later
> + // If this processor has already halted before, need to check it later
> //
> if (IsCpuStopped (ProcessorIndex)) {
> IssuedViewPoint = ProcessorIndex;
> @@ -2372,7 +2372,7 @@ InterruptProcess (
>
> if (MultiProcessorDebugSupport()) {
> //
> - // If RUN commmand is executing, wait for it done.
> + // If RUN command is executing, wait for it done.
> //
> while (mDebugMpContext.RunCommandSet) {
> CpuPause ();
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/DxeDebugAgent
> Lib.c
> b/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/DxeDebugAgent
> Lib.c
> index 1f388d9c0281..bb37aa99b4d4 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/DxeDebugAgent
> Lib.c
> +++
> b/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/DxeDebugAgent
> Lib.c
> @@ -1,5 +1,5 @@
> /** @file
> - Debug Agent library implementition for Dxe Core and Dxr modules.
> + Debug Agent library implementation for Dxe Core and Dxr modules.
>
> Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c
> b/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c
> index 07f47262d24e..3e64852e9027 100644
> --- a/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c
> +++ b/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c
> @@ -9,7 +9,7 @@
> #include "DxeDebugAgentLib.h"
>
> //
> -// Serial I/O Protocol Interface defintions.
> +// Serial I/O Protocol Interface definitions.
> //
>
> /**
> @@ -231,7 +231,7 @@ typedef struct {
> } DEBUG_SERIAL_FIFO;
>
> //
> -// Global Varibles
> +// Global Variables
> //
> EFI_HANDLE mSerialIoHandle = NULL;
> UINTN mLoopbackBuffer = 0;
> @@ -389,7 +389,7 @@ SerialReset (
> mSerialIoMode.ControlMask = SERIAL_PORT_DEFAULT_CONTROL_MASK;
> mLoopbackBuffer = 0;
> //
> - // Not reset serial devcie hardware indeed.
> + // Not reset serial device hardware indeed.
> //
> return EFI_SUCCESS;
> }
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebug
> AgentLib.c
> b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebug
> AgentLib.c
> index da2a75e91246..51e07f70e7bb 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebug
> AgentLib.c
> +++
> b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebug
> AgentLib.c
> @@ -1,5 +1,5 @@
> /** @file
> - SEC Core Debug Agent Library instance implementition.
> + SEC Core Debug Agent Library instance implementation.
>
> Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -198,7 +198,7 @@ GetMailboxPointer (
>
> MailboxLocationInHob = GetMailboxLocationFromHob ();
> //
> - // Compare mailbox in IDT enry with mailbox in HOB,
> + // Compare mailbox in IDT entry with mailbox in HOB,
> // need to fix mailbox location if HOB moved by PEI CORE
> //
> if (MailboxLocationInHob != MailboxLocationInIdt &&
> MailboxLocationInHob != NULL) {
> @@ -323,7 +323,7 @@ DebugAgentCallbackMemoryDiscoveredPpi (
>
> This function is used to set up debug environment for SEC and PEI phase.
>
> - If InitFlag is DEBUG_AGENT_INIT_PREMEM_SEC, it will overirde IDT table
> entries
> + If InitFlag is DEBUG_AGENT_INIT_PREMEM_SEC, it will override IDT table
> entries
> and initialize debug port. It will enable interrupt to support break-in feature.
> It will set up debug agent Mailbox in cache-as-ramfrom. It will be called
> before
> physical memory is ready.
> @@ -546,7 +546,7 @@ InitializeDebugAgent (
> SetDebugFlag (DEBUG_AGENT_FLAG_INIT_ARCH, DEBUG_ARCH_SYMBOL);
> //
> // Register for a callback once memory has been initialized.
> - // If memery has been ready, the callback funtion will be invoked
> immediately
> + // If memory has been ready, the callback function will be invoked
> immediately
> //
> Status = PeiServicesNotifyPpi
> (&mDebugAgentMemoryDiscoveredNotifyList[0]);
> if (EFI_ERROR (Status)) {
> @@ -626,7 +626,7 @@ InitializeDebugAgent (
> EnableInterrupts ();
> }
> //
> - // If Function is not NULL, invoke it always whatever debug agent was
> initialized sucesssfully or not.
> + // If Function is not NULL, invoke it always whatever debug agent was
> initialized successfully or not.
> //
> if (Function != NULL) {
> Function (Context);
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebugAg
> entLib.c
> b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebugAg
> entLib.c
> index b759918e8531..37b0e8f39759 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebugAg
> entLib.c
> +++
> b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebugAg
> entLib.c
> @@ -1,5 +1,5 @@
> /** @file
> - Debug Agent library implementition.
> + Debug Agent library implementation.
>
> Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -152,13 +152,13 @@ RestoreDebugRegister (
> /**
> Initialize debug agent.
>
> - This function is used to set up debug enviroment for source level debug
> + This function is used to set up debug environment for source level debug
> in SMM code.
>
> - If InitFlag is DEBUG_AGENT_INIT_SMM, it will overirde IDT table entries
> + If InitFlag is DEBUG_AGENT_INIT_SMM, it will override IDT table entries
> and initialize debug port. It will get debug agent Mailbox from GUIDed HOB,
> it it exists, debug agent wiil copied it into the local Mailbox in SMM space.
> - it will overirde IDT table entries and initialize debug port. Context will be
> + it will override IDT table entries and initialize debug port. Context will be
> NULL.
> If InitFlag is DEBUG_AGENT_INIT_ENTER_SMI, debug agent will save Debug
> Registers and get local Mailbox in SMM space. Context will be NULL.
> @@ -295,7 +295,7 @@ InitializeDebugAgent (
> Mailbox = GetMailboxPointer ();
> if (GetDebugFlag (DEBUG_AGENT_FLAG_AGENT_IN_PROGRESS) == 1) {
> //
> - // If Debug Agent has been communicaton state with HOST, we need skip
> + // If Debug Agent has been communication state with HOST, we need skip
> // any break points set in SMM, set Skip Breakpoint flag
> //
> mSkipBreakpoint = TRUE;
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/AsmF
> uncs.nasm
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/AsmF
> uncs.nasm
> index a5a734a46351..912256ba455a 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/AsmF
> uncs.nasm
> +++
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/AsmF
> uncs.nasm
> @@ -226,7 +226,7 @@ NoExtrPush:
> push ebx ; temporarily save value of ebx on stack
> cpuid ; use CPUID to determine if FXSAVE/FXRESTOR and
> ; DE are supported
> - pop ebx ; retore value of ebx that was overwritten by CPUID
> + pop ebx ; restore value of ebx that was overwritten by CPUID
> mov eax, cr4
> push eax ; push cr4 firstly
> test edx, BIT24 ; Test for FXSAVE/FXRESTOR support
> @@ -407,7 +407,7 @@ NoExtrPush:
> mov esp, ebp
> pop ebp ; restore ebp maybe updated
> pop esp ; restore esp maybe updated
> - sub esp, 4 * 3 ; restore interupt pushced stack
> + sub esp, 4 * 3 ; restore interrupt pushced stack
>
> iretd
>
> --
> 2.21.0
^ permalink raw reply [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-74-philmd@redhat.com>]
* Re: [PATCH 73/79] SourceLevelDebugPkg/DebugCommunicationLib: Fix various typos
[not found] ` <20191203161602.15969-74-philmd@redhat.com>
@ 2019-12-04 1:03 ` Wu, Hao A
0 siblings, 0 replies; 122+ messages in thread
From: Wu, Hao A @ 2019-12-04 1:03 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io; +Cc: Antoine Coeur
> -----Original Message-----
> From: Philippe Mathieu-Daude [mailto:philmd@redhat.com]
> Sent: Wednesday, December 04, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur; Wu, Hao A; Philippe Mathieu-Daude
> Subject: [PATCH 73/79] SourceLevelDebugPkg/DebugCommunicationLib: Fix
> various typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
>
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCom
> municationLibSerialPort.inf | 2 +-
> SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
> | 2 +-
>
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunic
> ationLibUsb3Internal.h | 4 ++--
>
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCom
> municationLibSerialPort.c | 2 +-
>
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunic
> ationLibUsb3Common.c | 2 +-
>
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunic
> ationLibUsb3Dxe.c | 2 +-
>
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunic
> ationLibUsb3Transfer.c | 4 ++--
>
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCom
> municationLibSerialPort.uni | 2 +-
> 8 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.inf
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.inf
> index 668e0bef178e..21af18cfb0b0 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.inf
> +++
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.inf
> @@ -1,5 +1,5 @@
> ## @file
> -# Debug Communication Library instance based on serila port.
> +# Debug Communication Library instance based on serial port.
> #
> # Copyright (c) 2010 - 2014, Intel Corporation. All rights reserved.<BR>
> #
> diff --git a/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
> b/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
> index bc7a00b537c7..73e0f19f92a9 100644
> --- a/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
> +++ b/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
> @@ -30,7 +30,7 @@ VOID
> /**
> Initialize the debug port.
>
> - This function will initialize debug port to get it ready for data transmition. If
> + This function will initialize debug port to get it ready for data transmission. If
> certain Debug Communication Library instance has to save some private data
> in the
> stack, this function must work on the mode that doesn't return to the caller,
> then
> the caller needs to wrap up all rest of logic after DebugPortInitialize() into
> one
> diff --git
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Internal.h
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Internal.h
> index 72ed2c74162f..df50220f33dc 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Internal.h
> +++
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Internal.h
> @@ -85,7 +85,7 @@
> #define XHC_DEBUG_PORT_ON_OFF_DELAY 100000
>
> //
> -// USB debug device string descritpor (header size + unicode string length)
> +// USB debug device string descriptor (header size + unicode string length)
> //
> #define STRING0_DESC_LEN 4
> #define MANU_DESC_LEN 12
> @@ -680,7 +680,7 @@ USB3InitializeReal (
> @param Direction The direction of data transfer.
> @param Data Array of pointers to the buffers of data to transmit
> from or receive into.
> - @param DataLength The lenght of the data buffer.
> + @param DataLength The length of the data buffer.
> @param Timeout Indicates the maximum time, in millisecond,
> which
> the transfer is allowed to complete.
>
> diff --git
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.c
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.c
> index 604c7e6d52ce..045026508e80 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.c
> +++
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.c
> @@ -15,7 +15,7 @@
> /**
> Initialize the debug port.
>
> - This function will initialize debug port to get it ready for data transmition. If
> + This function will initialize debug port to get it ready for data transmission. If
> certain Debug Communication Library instance has to save some private data
> in the
> stack, this function must work on the mode that doesn't return to the caller,
> then
> the caller needs to wrap up all rest of logic after DebugPortInitialize() into
> one
> diff --git
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Common.c
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Common.c
> index 4e49a7437f8b..d76314a42ae6 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Common.c
> +++
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Common.c
> @@ -162,7 +162,7 @@ XhcClearDebugRegBit (
> }
>
> /**
> - Program and eanble XHCI MMIO base address.
> + Program and enable XHCI MMIO base address.
>
> @return XHCI MMIO base address.
>
> diff --git
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Dxe.c
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Dxe.c
> index d4245465ce74..d2ff2d52a70f 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Dxe.c
> +++
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Dxe.c
> @@ -25,7 +25,7 @@ EFI_PCI_IO_PROTOCOL *mUsb3PciIo = NULL;
> /**
> Creates a named event that can be signaled.
>
> - This function creates an event using NotifyTpl, NoifyFunction.
> + This function creates an event using NotifyTpl, NotifyFunction.
> If Name is NULL, then ASSERT().
> If NotifyTpl is not a legal TPL value, then ASSERT().
> If NotifyFunction is NULL, then ASSERT().
> diff --git
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Transfer.c
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Transfer.c
> index a3e3c134d8f1..262cfab3fbb4 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Transfer.c
> +++
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
> icationLibUsb3Transfer.c
> @@ -152,7 +152,7 @@ XhcCheckNewEvent (
>
> EvtRing->EventRingDequeue += sizeof (TRB_TEMPLATE);
> //
> - // If the dequeue pointer is beyond the ring, then roll-back it to the begining
> of the ring.
> + // If the dequeue pointer is beyond the ring, then roll-back it to the beginning
> of the ring.
> //
> if ((UINTN)EvtRing->EventRingDequeue >= ((UINTN) EvtRing->EventRingSeg0
> + sizeof (TRB_TEMPLATE) * EvtRing->TrbNumber)) {
> EvtRing->EventRingDequeue = EvtRing->EventRingSeg0;
> @@ -510,7 +510,7 @@ XhcCreateUrb (
> @param Direction The direction of data transfer.
> @param Data Array of pointers to the buffers of data to transmit
> from or receive into.
> - @param DataLength The lenght of the data buffer.
> + @param DataLength The length of the data buffer.
> @param Timeout Indicates the maximum time, in microsecond,
> which
> the transfer is allowed to complete.
>
> diff --git
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.uni
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.uni
> index f8e46fcfaef8..4bea6d51e032 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.uni
> +++
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.uni
> @@ -1,5 +1,5 @@
> // /** @file
> -// Debug Communication Library instance based on serila port.
> +// Debug Communication Library instance based on serial port.
> //
> // Debug Communication Library instance based on serial port.
> //
> --
> 2.21.0
^ permalink raw reply [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-75-philmd@redhat.com>]
* Re: [PATCH 74/79] SourceLevelDebugPkg: Fix few typos
[not found] ` <20191203161602.15969-75-philmd@redhat.com>
@ 2019-12-04 1:03 ` Wu, Hao A
0 siblings, 0 replies; 122+ messages in thread
From: Wu, Hao A @ 2019-12-04 1:03 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io; +Cc: Antoine Coeur
> -----Original Message-----
> From: Philippe Mathieu-Daude [mailto:philmd@redhat.com]
> Sent: Wednesday, December 04, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur; Wu, Hao A; Philippe Mathieu-Daude
> Subject: [PATCH 74/79] SourceLevelDebugPkg: Fix few typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Correctly write 'definitions' in comments and documentation.
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> SourceLevelDebugPkg/Include/Ia32/ProcessorContext.h | 2 +-
> SourceLevelDebugPkg/Include/TransferProtocol.h | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/SourceLevelDebugPkg/Include/Ia32/ProcessorContext.h
> b/SourceLevelDebugPkg/Include/Ia32/ProcessorContext.h
> index 71f596f285bd..2c5cf03cec90 100644
> --- a/SourceLevelDebugPkg/Include/Ia32/ProcessorContext.h
> +++ b/SourceLevelDebugPkg/Include/Ia32/ProcessorContext.h
> @@ -1,5 +1,5 @@
> /** @file
> - IA32/x64 architecture specific defintions needed by debug transfer protocol.It
> is only
> + IA32/x64 architecture specific definitions needed by debug transfer
> protocol.It is only
> intended to be used by Debug related module implementation.
>
> Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.<BR>
> diff --git a/SourceLevelDebugPkg/Include/TransferProtocol.h
> b/SourceLevelDebugPkg/Include/TransferProtocol.h
> index 3904ba27dcb8..154e74165e8d 100644
> --- a/SourceLevelDebugPkg/Include/TransferProtocol.h
> +++ b/SourceLevelDebugPkg/Include/TransferProtocol.h
> @@ -1,5 +1,5 @@
> /** @file
> - Transfer protocol defintions used by debug agent and host. It is only
> + Transfer protocol definitions used by debug agent and host. It is only
> intended to be used by Debug related module implementation.
>
> Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR>
> @@ -140,7 +140,7 @@ typedef struct {
> UINT64 StopAddress;
> } DEBUG_DATA_RESPONSE_BREAK_CAUSE;
> //
> -// Break type defintions for DEBUG_DATA_BREAK_CAUSE
> +// Break type definitions for DEBUG_DATA_BREAK_CAUSE
> //
> #define DEBUG_DATA_BREAK_CAUSE_UNKNOWN 0
> #define DEBUG_DATA_BREAK_CAUSE_HW_BREAKPOINT 1
> @@ -160,7 +160,7 @@ typedef struct {
> UINT8 CpuMode;
> } DEBUG_DATA_RESPONSE_ARCH_MODE;
> //
> -// Cpu architecture defintions for DEBUG_DATA_RESPONSE_ARCH_MODE
> +// Cpu architecture definitions for DEBUG_DATA_RESPONSE_ARCH_MODE
> //
> #define DEBUG_DATA_BREAK_CPU_ARCH_IA16 0
> #define DEBUG_DATA_BREAK_CPU_ARCH_IA32 1
> --
> 2.21.0
^ permalink raw reply [flat|nested] 122+ messages in thread
* Re: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (51 preceding siblings ...)
[not found] ` <20191203161602.15969-75-philmd@redhat.com>
@ 2019-12-04 1:16 ` Nate DeSimone
2019-12-04 1:27 ` Liming Gao
2019-12-04 16:29 ` Philippe Mathieu-Daudé
[not found] ` <20191203161602.15969-78-philmd@redhat.com>
` (19 subsequent siblings)
72 siblings, 2 replies; 122+ messages in thread
From: Nate DeSimone @ 2019-12-04 1:16 UTC (permalink / raw)
To: devel@edk2.groups.io, philmd@redhat.com, Achin Gupta, Andrew Fish,
Anthony Perard, Ard Biesheuvel, Zhang, Chao B, Chiu, Chasel,
Dong, Eric, Wu, Hao A, Wang, Jian J, Wu, Jiaxin, Yao, Jiewen,
Justen, Jordan L, Julien Grall, Laszlo Ersek, Leif Lindholm,
Gao, Liming, Rabeda, Maciej, Kinney, Michael D, Ni, Ray,
Fu, Siyuan, Zeng, Star, Supreeth Venkatesh, Lu, XiaoyuX,
Gao, Zhichao
Cc: Antoine Cœur
Hi Philippe and Antoine,
Thank you very much for doing this work!
Please note that the mailing list currently has the braindead behavior only allowing a user to send 40 emails in a 30 minute window. I believe this is done to prevent spamming. Because of this, only patches 0-39 were actually received. Myself and Michael recently ran into this same problem with the Advanced Feature Refactor patch series. We worked around it by sending our emails in batches and waiting 30 minutes between each batch.
Thanks,
Nate
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Philippe Mathieu-Daudé
Sent: Tuesday, December 3, 2019 8:15 AM
To: devel@edk2.groups.io; Achin Gupta <achin.gupta@arm.com>; Andrew Fish <afish@apple.com>; Anthony Perard <anthony.perard@citrix.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>; Zhang, Chao B <chao.b.zhang@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Dong, Eric <eric.dong@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Julien Grall <julien@xen.org>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif.lindholm@linaro.org>; Gao, Liming <liming.gao@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>; Ni, Ray <ray.ni@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Zeng, Star <star.zeng@intel.com>; Supreeth Venkatesh <supreeth.venkatesh@arm.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
Cc: Antoine Cœur <coeur@gmx.fr>
Subject: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)
Around February of this year, Antoine posted various patches fixing
a huge quantity of typos, over 8000+ lines (such [1]).
The community merged the smaller patches, and told him his patches
were too big, and he should split them.
Around June, Antoine opened a GitHub pull request [2], due to the
size of his patchset. We told him the project doesn't accept GitHub
PR.
Since I find his cleanup work very valuable for the project, I
spent few hours trying to salvage a chunk of it, splitting per
maintainer areas, each patch not to big to avoid reviewers burning
out. I expect each maintainer to take his patches.
I wanted to split Antoine work in 3 parts, but I'm about at 80
patches, for only 1854 lines changed, so enough for a first round.
Oh, and it is easier to review the patches using '--word-diff=color'
git option :)
Regards,
Phil.
P.D.: I think the project is really failing at getting new
contributors involved, and keeping them. But that is another topic.
[1] https://edk2.groups.io/g/devel/message/43043
[2] https://edk2.groups.io/g/devel/message/42941
Antoine Coeur (72):
CryptoPkg/OpensslLib: Fix few typos
EmbeddedPkg/FdtLib: Fix a typo
EmbeddedPkg/VirtualKeyboard: Fix few typos
EmulatorPkg/Sec: Fix various typos
EmulatorPkg/Unix: Fix various typos
EmulatorPkg/Win: Fix various typos
FatPkg/EnhancedFatDxe: Fix various typos
FatPkg/FatPei: Fix few typos
IntelFsp2WrapperPkg: Fix various typos
MdeModulePkg/Application: Improve French translation
MdeModulePkg/Application: Fix various typos
MdeModulePkg/Bus/Ata: Fix various typos
MdeModulePkg/Bus/I2c: Fix few typos
MdeModulePkg/Bus/Isa: Fix various typos
MdeModulePkg/Bus/Scsi: Fix various typos
MdeModulePkg/Bus/Sd: Fix various typos
MdeModulePkg/Core/Pei: Fix various typos
MdeModulePkg/Core/PiSmmCore: Fix various typos
MdeModulePkg/UsbMass: Fix various typos
MdeModulePkg/UsbMouse: Fix few typos
MdeModulePkg/UsbBus: Fix various typos
MdeModulePkg/Usb: Fix various typos
MdePkg/IndustryStandard: Fix various typos
MdePkg/Library/Dxe: Fix various typos
MdePkg/Library/Pci: Fix various typos
MdePkg/Library/Smm: Fix various typos
MdePkg/Ppi: Fix various typos
MdePkg/Register: Fix various typos
NetworkPkg/ArpDxe: Fix various typos
NetworkPkg/Dhcp4Dxe: Fix various typos
NetworkPkg/Dhcp6Dxe: Fix various typos
NetworkPkg/DnsDxe: Fix various typos
NetworkPkg/DpcDxe: Fix few typos
NetworkPkg/HttpBootDxe: Fix various typos
NetworkPkg/HttpDxe: Fix various typos
NetworkPkg/Ip4Dxe: Fix various typos
NetworkPkg/Ip6Dxe: Fix various typos
NetworkPkg/IScsiDxe: Fix various typos
NetworkPkg/Library: Fix various typos
NetworkPkg/MnpDxe: Fix various typos
NetworkPkg/Mtftp4Dxe: Fix various typos
NetworkPkg/Mtftp6Dxe: Fix various typos
NetworkPkg/SnpDxe: Fix few typos
NetworkPkg/TcpDxe/Sock: Fix few typos
NetworkPkg/TcpDxe/Tcp: Fix various typos
NetworkPkg/Tls: Fix few typos
NetworkPkg/Udp4Dxe: Fix various typos
NetworkPkg/Udp6Dxe: Fix various typos
NetworkPkg/UefiPxeBcDxe: Fix various typos
NetworkPkg/VlanConfigDxe: Fix few typos
OvmfPkg/Acpi: Fix few typos
OvmfPkg/Csm: Fix various typos
OvmfPkg/Qemu: Fix various typos
OvmfPkg/Virtio: Fix few typos
OvmfPkg/Xen: Fix various typos
PcAtChipsetPkg: Fix few typos
SecurityPkg: Fix few typos
SecurityPkg/Hash2DxeCrypto: Fix few typos
SecurityPkg/Library/Tpm: Fix various typos
SecurityPkg/Tcg: Fix various typos
SecurityPkg/VariableAuthenticated: Fix few typos
ShellPkg/Application: Fix various typos
ShellPkg/DynamicCommand: Fix various typos
SignedCapsulePkg: Fix various typos
SignedCapsulePkg/Universal: Fix various typos
SourceLevelDebugPkg/DebugAgent: Fix various typos
SourceLevelDebugPkg/DebugCommunicationLib: Fix various typos
SourceLevelDebugPkg: Fix few typos
StandaloneMmPkg: Fix few typos
UefiCpuPkg/CpuDxe: Fix few typos
UefiCpuPkg/PiSmm: Fix various typos
UefiCpuPkg/Smm: Fix various typos
Philippe Mathieu-Daude (7):
EmbeddedPkg/VirtualKeyboard: Fix a typo in EFI_INVALID_PARAMETER
MdeModulePkg/UsbBusDxe: Fix a typo
NetworkPkg: Fix a typo
NetworkPkg/DnsDxe: Fix a typo
NetworkPkg/HttpBootDxe: Fix a typo in variable name
OvmfPkg/Xen: Fix a typo
StandaloneMmPkg: Fix a typo
SignedCapsulePkg/SignedCapsulePkg.dec | 4 +-
MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf | 2 +-
MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf | 2 +-
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf | 10 ++--
MdePkg/Library/DxePcdLib/DxePcdLib.inf | 2 +-
NetworkPkg/MnpDxe/MnpDxe.inf | 2 +-
OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf | 2 +-
OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf | 4 +-
OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf | 4 +-
SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf | 2 +-
SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf | 2 +-
SecurityPkg/Tcg/TcgSmm/TcgSmm.inf | 2 +-
SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.inf | 2 +-
StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf | 2 +-
EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h | 36 +++++++-------
EmbeddedPkg/Include/libfdt.h | 2 +-
EmulatorPkg/Sec/Sec.h | 4 +-
EmulatorPkg/Win/Host/WinGop.h | 2 +-
EmulatorPkg/Win/Host/WinHost.h | 2 +-
FatPkg/EnhancedFatDxe/Fat.h | 6 +--
FatPkg/FatPei/FatLitePeim.h | 2 +-
IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h | 2 +-
IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h | 4 +-
MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.h | 2 +-
MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.h | 2 +-
MdeModulePkg/Bus/Ata/AhciPei/AhciPei.h | 4 +-
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h | 4 +-
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.h | 4 +-
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.h | 2 +-
MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h | 12 ++---
MdeModulePkg/Bus/I2c/I2cDxe/I2cDxe.h | 4 +-
MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 14 +++---
MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.h | 2 +-
MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.h | 2 +-
MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.h | 4 +-
MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 10 ++--
MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.h | 2 +-
MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h | 6 +--
MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.h | 2 +-
MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.h | 6 +--
MdeModulePkg/Bus/Sd/SdDxe/SdDxe.h | 2 +-
MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h | 2 +-
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.h | 14 +++---
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.h | 2 +-
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h | 2 +-
MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h | 2 +-
MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h | 2 +-
MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.h | 2 +-
MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h | 10 ++--
MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.h | 2 +-
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h | 4 +-
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.h | 4 +-
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.h | 2 +-
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.h | 2 +-
MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.h | 2 +-
MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.h | 2 +-
MdeModulePkg/Core/Pei/PeiMain.h | 20 ++++----
MdeModulePkg/Core/PiSmmCore/HeapGuard.h | 2 +-
MdeModulePkg/Core/PiSmmCore/PiSmmCore.h | 12 ++---
MdeModulePkg/Core/PiSmmCore/PiSmmCorePrivateData.h | 6 +--
MdePkg/Include/IndustryStandard/Acpi10.h | 4 +-
MdePkg/Include/IndustryStandard/Acpi20.h | 4 +-
MdePkg/Include/IndustryStandard/Acpi30.h | 4 +-
MdePkg/Include/IndustryStandard/Acpi40.h | 2 +-
MdePkg/Include/IndustryStandard/Acpi50.h | 6 +--
MdePkg/Include/IndustryStandard/Acpi51.h | 4 +-
MdePkg/Include/IndustryStandard/Acpi60.h | 4 +-
MdePkg/Include/IndustryStandard/Acpi61.h | 4 +-
MdePkg/Include/IndustryStandard/Acpi62.h | 8 +--
MdePkg/Include/IndustryStandard/Atapi.h | 40 +++++++--------
MdePkg/Include/IndustryStandard/ElTorito.h | 4 +-
MdePkg/Include/IndustryStandard/Emmc.h | 2 +-
MdePkg/Include/IndustryStandard/IpmiNetFnBridge.h | 4 +-
MdePkg/Include/IndustryStandard/Nvme.h | 10 ++--
MdePkg/Include/IndustryStandard/Pci22.h | 20 ++++----
MdePkg/Include/IndustryStandard/PeImage.h | 2 +-
MdePkg/Include/IndustryStandard/Scsi.h | 2 +-
MdePkg/Include/IndustryStandard/SmBus.h | 2 +-
MdePkg/Include/IndustryStandard/Tpm12.h | 2 +-
MdePkg/Include/Library/DxeServicesLib.h | 2 +-
MdePkg/Include/Library/PciCf8Lib.h | 4 +-
MdePkg/Include/Library/PciExpressLib.h | 4 +-
MdePkg/Include/Library/PciLib.h | 4 +-
MdePkg/Include/Library/PciSegmentLib.h | 4 +-
MdePkg/Include/Library/SmmLib.h | 4 +-
MdePkg/Include/Library/SmmMemLib.h | 4 +-
MdePkg/Include/Library/SmmPeriodicSmiLib.h | 6 +--
MdePkg/Include/Ppi/BlockIo.h | 4 +-
MdePkg/Include/Ppi/BlockIo2.h | 2 +-
MdePkg/Include/Ppi/Capsule.h | 2 +-
MdePkg/Include/Ppi/Decompress.h | 2 +-
MdePkg/Include/Ppi/DeviceRecoveryModule.h | 2 +-
MdePkg/Include/Ppi/IsaHc.h | 2 +-
MdePkg/Include/Ppi/MpServices.h | 2 +-
MdePkg/Include/Ppi/Pcd.h | 4 +-
MdePkg/Include/Ppi/RecoveryModule.h | 2 +-
MdePkg/Include/Ppi/TemporaryRamDone.h | 2 +-
MdePkg/Include/Ppi/VectorHandoffInfo.h | 2 +-
MdePkg/Include/Register/Amd/Cpuid.h | 8 +--
MdePkg/Include/Register/Amd/Fam17Msr.h | 2 +-
MdePkg/Include/Register/Amd/Msr.h | 2 +-
MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h | 2 +-
MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h | 2 +-
MdePkg/Include/Register/Intel/StmResourceDescriptor.h | 2 +-
NetworkPkg/ArpDxe/ArpDriver.h | 10 ++--
NetworkPkg/ArpDxe/ArpImpl.h | 14 +++---
NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h | 4 +-
NetworkPkg/Dhcp4Dxe/Dhcp4Io.h | 2 +-
NetworkPkg/Dhcp4Dxe/Dhcp4Option.h | 18 +++----
NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h | 4 +-
NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h | 12 ++---
NetworkPkg/DnsDxe/DnsDriver.h | 12 ++---
NetworkPkg/DnsDxe/DnsImpl.h | 28 +++++------
NetworkPkg/DpcDxe/Dpc.h | 2 +-
NetworkPkg/HttpBootDxe/HttpBootConfig.h | 2 +-
NetworkPkg/HttpBootDxe/HttpBootDhcp4.h | 2 +-
NetworkPkg/HttpBootDxe/HttpBootDhcp6.h | 4 +-
NetworkPkg/HttpBootDxe/HttpBootDxe.h | 6 +--
NetworkPkg/HttpBootDxe/HttpBootSupport.h | 10 ++--
NetworkPkg/HttpDxe/HttpDriver.h | 8 +--
NetworkPkg/HttpDxe/HttpProto.h | 16 +++---
NetworkPkg/HttpDxe/HttpsSupport.h | 2 +-
NetworkPkg/IScsiDxe/IScsiMisc.h | 8 +--
NetworkPkg/IScsiDxe/IScsiProto.h | 10 ++--
NetworkPkg/Include/Library/HttpLib.h | 2 +-
NetworkPkg/Include/Library/IpIoLib.h | 4 +-
NetworkPkg/Include/Library/NetLib.h | 2 +-
NetworkPkg/Include/Library/TcpIoLib.h | 6 +--
NetworkPkg/Include/Library/UdpIoLib.h | 6 +--
NetworkPkg/Include/Protocol/Dpc.h | 2 +-
NetworkPkg/Ip4Dxe/Ip4Common.h | 14 +++---
NetworkPkg/Ip4Dxe/Ip4Config2Impl.h | 2 +-
NetworkPkg/Ip4Dxe/Ip4Driver.h | 6 +--
NetworkPkg/Ip4Dxe/Ip4Icmp.h | 10 ++--
NetworkPkg/Ip4Dxe/Ip4If.h | 4 +-
NetworkPkg/Ip4Dxe/Ip4Igmp.h | 4 +-
NetworkPkg/Ip4Dxe/Ip4Impl.h | 8 +--
NetworkPkg/Ip4Dxe/Ip4Input.h | 6 +--
NetworkPkg/Ip4Dxe/Ip4Option.h | 4 +-
NetworkPkg/Ip4Dxe/Ip4Output.h | 4 +-
NetworkPkg/Ip4Dxe/Ip4Route.h | 12 ++---
NetworkPkg/Ip6Dxe/Ip6ConfigImpl.h | 4 +-
NetworkPkg/Ip6Dxe/Ip6Driver.h | 8 +--
NetworkPkg/Ip6Dxe/Ip6Icmp.h | 4 +-
NetworkPkg/Ip6Dxe/Ip6If.h | 4 +-
NetworkPkg/Ip6Dxe/Ip6Impl.h | 8 +--
NetworkPkg/Ip6Dxe/Ip6Input.h | 6 +--
NetworkPkg/Ip6Dxe/Ip6Mld.h | 2 +-
NetworkPkg/Ip6Dxe/Ip6Nd.h | 4 +-
NetworkPkg/Ip6Dxe/Ip6Route.h | 10 ++--
NetworkPkg/MnpDxe/MnpDriver.h | 6 +--
NetworkPkg/MnpDxe/MnpImpl.h | 14 +++---
NetworkPkg/Mtftp4Dxe/Mtftp4Driver.h | 2 +-
NetworkPkg/Mtftp4Dxe/Mtftp4Impl.h | 2 +-
NetworkPkg/Mtftp4Dxe/Mtftp4Option.h | 6 +--
NetworkPkg/Mtftp4Dxe/Mtftp4Support.h | 2 +-
NetworkPkg/Mtftp6Dxe/Mtftp6Driver.h | 4 +-
NetworkPkg/Mtftp6Dxe/Mtftp6Impl.h | 4 +-
NetworkPkg/Mtftp6Dxe/Mtftp6Option.h | 2 +-
NetworkPkg/Mtftp6Dxe/Mtftp6Support.h | 2 +-
NetworkPkg/SnpDxe/Snp.h | 8 +--
NetworkPkg/TcpDxe/SockImpl.h | 2 +-
NetworkPkg/TcpDxe/Socket.h | 36 +++++++-------
NetworkPkg/TcpDxe/TcpDriver.h | 8 +--
NetworkPkg/TcpDxe/TcpFunc.h | 4 +-
NetworkPkg/TcpDxe/TcpMain.h | 4 +-
NetworkPkg/TcpDxe/TcpOption.h | 6 +--
NetworkPkg/TcpDxe/TcpProto.h | 14 +++---
NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h | 2 +-
NetworkPkg/TlsDxe/TlsDriver.h | 4 +-
NetworkPkg/Udp4Dxe/Udp4Driver.h | 4 +-
NetworkPkg/Udp4Dxe/Udp4Impl.h | 4 +-
NetworkPkg/Udp6Dxe/Udp6Driver.h | 6 +--
NetworkPkg/Udp6Dxe/Udp6Impl.h | 12 ++---
NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.h | 2 +-
NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h | 8 +--
NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h | 4 +-
NetworkPkg/UefiPxeBcDxe/PxeBcSupport.h | 16 +++---
NetworkPkg/VlanConfigDxe/VlanConfigImpl.h | 6 +--
OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h | 10 ++--
OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h | 8 +--
OvmfPkg/Csm/Include/Framework/BootScript.h | 2 +-
OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h | 2 +-
OvmfPkg/Csm/Include/Protocol/IsaAcpi.h | 2 +-
OvmfPkg/Csm/Include/Protocol/IsaIo.h | 2 +-
OvmfPkg/Csm/Include/Protocol/LegacyBios.h | 6 +--
OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h | 4 +-
OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h | 2 +-
OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h | 8 +--
OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h | 4 +-
OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h | 2 +-
OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h | 2 +-
OvmfPkg/Include/IndustryStandard/Xen/grant_table.h | 4 +-
OvmfPkg/Include/IndustryStandard/Xen/io/blkif.h | 2 +-
OvmfPkg/Include/Library/VirtioLib.h | 2 +-
OvmfPkg/Include/Protocol/XenBus.h | 4 +-
OvmfPkg/Include/Protocol/XenIo.h | 2 +-
OvmfPkg/XenBusDxe/DriverBinding.h | 2 +-
OvmfPkg/XenBusDxe/EventChannel.h | 2 +-
OvmfPkg/XenBusDxe/GrantTable.h | 4 +-
OvmfPkg/XenPvBlkDxe/BlockIo.h | 6 +--
OvmfPkg/XenPvBlkDxe/DriverBinding.h | 2 +-
SecurityPkg/Include/Library/TcgStorageCoreLib.h | 4 +-
SecurityPkg/Include/Library/TpmCommLib.h | 4 +-
SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h | 6 +--
ShellPkg/Application/Shell/ConsoleLogger.h | 4 +-
ShellPkg/Application/Shell/FileHandleWrappers.h | 6 +--
ShellPkg/Application/Shell/Shell.h | 2 +-
ShellPkg/Application/Shell/ShellEnvVar.h | 36 +++++++-------
ShellPkg/Application/Shell/ShellManParser.h | 10 ++--
ShellPkg/Application/Shell/ShellParametersProtocol.h | 20 ++++----
ShellPkg/Application/Shell/ShellProtocol.h | 12 ++---
ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h | 2 +-
ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.h | 2 +-
SignedCapsulePkg/Include/Guid/EdkiiSystemFmpCapsule.h | 4 +-
SignedCapsulePkg/Include/Library/IniParsingLib.h | 14 +++---
SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h | 2 +-
SourceLevelDebugPkg/Include/Ia32/ProcessorContext.h | 2 +-
SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h | 2 +-
SourceLevelDebugPkg/Include/TransferProtocol.h | 6 +--
SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h | 6 +--
SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/ArchDebugSupport.h | 2 +-
SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/DebugException.h | 2 +-
SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/ArchDebugSupport.h | 2 +-
SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/DebugException.h | 2 +-
SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Internal.h | 4 +-
UefiCpuPkg/CpuDxe/CpuDxe.h | 2 +-
UefiCpuPkg/CpuDxe/CpuGdt.h | 2 +-
UefiCpuPkg/CpuDxe/CpuMp.h | 4 +-
UefiCpuPkg/CpuDxe/CpuPageTable.h | 2 +-
UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h | 4 +-
UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h | 4 +-
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 12 ++---
NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigVfr.vfr | 6 +--
CryptoPkg/Library/OpensslLib/rand_pool.c | 8 +--
CryptoPkg/Library/OpensslLib/rand_pool_noise.c | 2 +-
EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c | 16 +++---
EmulatorPkg/Sec/Sec.c | 5 +-
EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 2 +-
EmulatorPkg/Unix/Host/BlockIo.c | 12 ++---
EmulatorPkg/Unix/Host/EmuThunk.c | 2 +-
EmulatorPkg/Unix/Host/Host.c | 26 +++++-----
EmulatorPkg/Unix/Host/LinuxPacketFilter.c | 2 +-
EmulatorPkg/Unix/Host/Pthreads.c | 2 +-
EmulatorPkg/Win/Host/WinBlockIo.c | 4 +-
EmulatorPkg/Win/Host/WinFileSystem.c | 2 +-
EmulatorPkg/Win/Host/WinGopInput.c | 4 +-
EmulatorPkg/Win/Host/WinGopScreen.c | 14 +++---
EmulatorPkg/Win/Host/WinHost.c | 10 ++--
FatPkg/EnhancedFatDxe/Delete.c | 2 +-
FatPkg/EnhancedFatDxe/DirectoryManage.c | 2 +-
FatPkg/EnhancedFatDxe/Fat.c | 2 +-
FatPkg/EnhancedFatDxe/FileName.c | 2 +-
FatPkg/EnhancedFatDxe/FileSpace.c | 6 +--
FatPkg/EnhancedFatDxe/Flush.c | 4 +-
FatPkg/FatPei/FatLiteApi.c | 2 +-
FatPkg/FatPei/Mbr.c | 2 +-
IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 2 +-
IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c | 4 +-
IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c | 4 +-
MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 2 +-
MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 4 +-
MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c | 2 +-
MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c | 2 +-
MdeModulePkg/Bus/Ata/AhciPei/AhciMode.c | 8 +--
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 14 +++---
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c | 8 +--
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c | 16 +++---
MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c | 10 ++--
MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c | 4 +-
MdeModulePkg/Bus/I2c/I2cDxe/I2cBus.c | 4 +-
MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c | 2 +-
MdeModulePkg/Bus/Isa/IsaBusDxe/IsaBusDxe.c | 6 +--
MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 16 +++---
MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c | 20 ++++----
MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c | 4 +-
MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.c | 2 +-
MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.c | 4 +-
MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 6 +--
MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 32 ++++++------
MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c | 2 +-
MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c | 12 ++---
MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c | 12 ++---
MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.c | 2 +-
MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c | 2 +-
MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHci.c | 6 +--
MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 10 ++--
MdeModulePkg/Bus/Sd/SdDxe/SdDxe.c | 2 +-
MdeModulePkg/Bus/Usb/UsbBotPei/BotPeim.c | 2 +-
MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c | 2 +-
MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c | 2 +-
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c | 12 ++---
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c | 2 +-
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c | 2 +-
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c | 4 +-
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c | 8 +--
MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c | 2 +-
MdeModulePkg/Bus/Usb/UsbBusPei/UsbIoPeim.c | 2 +-
MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c | 8 +--
MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c | 6 +--
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c | 4 +-
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.c | 4 +-
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.c | 4 +-
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c | 4 +-
MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/MouseHid.c | 2 +-
MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c | 2 +-
MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c | 2 +-
MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c | 2 +-
MdeModulePkg/Core/Pei/Dependency/Dependency.c | 4 +-
MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 28 +++++------
MdeModulePkg/Core/Pei/FwVol/FwVol.c | 8 +--
MdeModulePkg/Core/Pei/Hob/Hob.c | 2 +-
MdeModulePkg/Core/Pei/Image/Image.c | 8 +--
MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 10 ++--
MdeModulePkg/Core/Pei/PeiMain/PeiMain.c | 4 +-
MdeModulePkg/Core/Pei/Ppi/Ppi.c | 2 +-
MdeModulePkg/Core/Pei/Security/Security.c | 2 +-
MdeModulePkg/Core/PiSmmCore/Dependency.c | 4 +-
MdeModulePkg/Core/PiSmmCore/Dispatcher.c | 24 ++++-----
MdeModulePkg/Core/PiSmmCore/HeapGuard.c | 4 +-
MdeModulePkg/Core/PiSmmCore/Locate.c | 8 +--
MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c | 8 +--
MdeModulePkg/Core/PiSmmCore/Page.c | 4 +-
MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 10 ++--
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 8 +--
MdeModulePkg/Core/PiSmmCore/Smi.c | 2 +-
MdeModulePkg/Core/PiSmmCore/SmramProfileRecord.c | 4 +-
MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.c | 10 ++--
MdePkg/Library/DxeHobLib/HobLib.c | 2 +-
MdePkg/Library/DxeIoLibCpuIo2/IoLib.c | 2 +-
MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.c | 6 +--
MdePkg/Library/DxeServicesLib/DxeServicesLib.c | 12 ++---
MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.c | 2 +-
MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c | 2 +-
MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePciSegmentLib.c | 2 +-
MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c | 4 +-
MdePkg/Library/SmmMemLib/SmmMemLib.c | 4 +-
MdePkg/Library/SmmPciExpressLib/PciExpressLib.c | 4 +-
MdePkg/Library/SmmPciLibPciRootBridgeIo/PciLib.c | 6 +--
MdePkg/Library/SmmPeriodicSmiLib/SmmPeriodicSmiLib.c | 42 ++++++++--------
MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.c | 2 +-
NetworkPkg/ArpDxe/ArpDriver.c | 14 +++---
NetworkPkg/ArpDxe/ArpImpl.c | 16 +++---
NetworkPkg/ArpDxe/ArpMain.c | 10 ++--
NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c | 8 +--
NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c | 6 +--
NetworkPkg/Dhcp4Dxe/Dhcp4Io.c | 12 ++---
NetworkPkg/Dhcp4Dxe/Dhcp4Option.c | 26 +++++-----
NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c | 12 ++---
NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c | 12 ++---
NetworkPkg/Dhcp6Dxe/Dhcp6Io.c | 26 +++++-----
NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c | 16 +++---
NetworkPkg/DnsDxe/DnsDriver.c | 12 ++---
NetworkPkg/DnsDxe/DnsImpl.c | 28 +++++------
NetworkPkg/DnsDxe/DnsProtocol.c | 16 +++---
NetworkPkg/DpcDxe/Dpc.c | 6 +--
NetworkPkg/HttpBootDxe/HttpBootConfig.c | 4 +-
NetworkPkg/HttpBootDxe/HttpBootDhcp4.c | 2 +-
NetworkPkg/HttpBootDxe/HttpBootDhcp6.c | 10 ++--
NetworkPkg/HttpBootDxe/HttpBootDxe.c | 8 +--
NetworkPkg/HttpBootDxe/HttpBootImpl.c | 2 +-
NetworkPkg/HttpBootDxe/HttpBootSupport.c | 12 ++---
NetworkPkg/HttpDxe/HttpDriver.c | 12 ++---
NetworkPkg/HttpDxe/HttpImpl.c | 10 ++--
NetworkPkg/HttpDxe/HttpProto.c | 22 ++++-----
NetworkPkg/HttpDxe/HttpsSupport.c | 2 +-
NetworkPkg/IScsiDxe/ComponentName.c | 2 +-
NetworkPkg/IScsiDxe/IScsiCHAP.c | 4 +-
NetworkPkg/IScsiDxe/IScsiConfig.c | 6 +--
NetworkPkg/IScsiDxe/IScsiDhcp.c | 4 +-
NetworkPkg/IScsiDxe/IScsiDriver.c | 10 ++--
NetworkPkg/IScsiDxe/IScsiMisc.c | 6 +--
NetworkPkg/IScsiDxe/IScsiProto.c | 40 +++++++--------
NetworkPkg/Ip4Dxe/Ip4Common.c | 10 ++--
NetworkPkg/Ip4Dxe/Ip4Config2Impl.c | 10 ++--
NetworkPkg/Ip4Dxe/Ip4Config2Nv.c | 4 +-
NetworkPkg/Ip4Dxe/Ip4Driver.c | 10 ++--
NetworkPkg/Ip4Dxe/Ip4Icmp.c | 2 +-
NetworkPkg/Ip4Dxe/Ip4If.c | 14 +++---
NetworkPkg/Ip4Dxe/Ip4Igmp.c | 8 +--
NetworkPkg/Ip4Dxe/Ip4Impl.c | 14 +++---
NetworkPkg/Ip4Dxe/Ip4Input.c | 28 +++++------
NetworkPkg/Ip4Dxe/Ip4Option.c | 4 +-
NetworkPkg/Ip4Dxe/Ip4Output.c | 12 ++---
NetworkPkg/Ip4Dxe/Ip4Route.c | 14 +++---
NetworkPkg/Ip6Dxe/Ip6Common.c | 2 +-
NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c | 10 ++--
NetworkPkg/Ip6Dxe/Ip6ConfigNv.c | 6 +--
NetworkPkg/Ip6Dxe/Ip6Driver.c | 12 ++---
NetworkPkg/Ip6Dxe/Ip6Icmp.c | 6 +--
NetworkPkg/Ip6Dxe/Ip6If.c | 10 ++--
NetworkPkg/Ip6Dxe/Ip6Impl.c | 10 ++--
NetworkPkg/Ip6Dxe/Ip6Input.c | 20 ++++----
NetworkPkg/Ip6Dxe/Ip6Mld.c | 8 +--
NetworkPkg/Ip6Dxe/Ip6Nd.c | 12 ++---
NetworkPkg/Ip6Dxe/Ip6Output.c | 2 +-
NetworkPkg/Ip6Dxe/Ip6Route.c | 6 +--
NetworkPkg/Library/DxeHttpLib/DxeHttpLib.c | 4 +-
NetworkPkg/Library/DxeIpIoLib/DxeIpIoLib.c | 16 +++---
NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 26 +++++-----
NetworkPkg/Library/DxeNetLib/NetBuffer.c | 4 +-
NetworkPkg/Library/DxeTcpIoLib/DxeTcpIoLib.c | 10 ++--
NetworkPkg/Library/DxeUdpIoLib/DxeUdpIoLib.c | 10 ++--
NetworkPkg/MnpDxe/MnpConfig.c | 14 +++---
NetworkPkg/MnpDxe/MnpDriver.c | 10 ++--
NetworkPkg/MnpDxe/MnpIo.c | 8 +--
NetworkPkg/MnpDxe/MnpMain.c | 6 +--
NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c | 4 +-
NetworkPkg/Mtftp4Dxe/Mtftp4Impl.c | 10 ++--
NetworkPkg/Mtftp4Dxe/Mtftp4Option.c | 20 ++++----
NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c | 10 ++--
NetworkPkg/Mtftp4Dxe/Mtftp4Support.c | 6 +--
NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c | 8 +--
NetworkPkg/Mtftp6Dxe/Mtftp6Driver.c | 4 +-
NetworkPkg/Mtftp6Dxe/Mtftp6Impl.c | 4 +-
NetworkPkg/Mtftp6Dxe/Mtftp6Option.c | 4 +-
NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c | 10 ++--
NetworkPkg/Mtftp6Dxe/Mtftp6Support.c | 8 +--
NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c | 4 +-
NetworkPkg/SnpDxe/Callback.c | 2 +-
NetworkPkg/SnpDxe/Shutdown.c | 2 +-
NetworkPkg/SnpDxe/Snp.c | 6 +--
NetworkPkg/SnpDxe/WaitForPacket.c | 2 +-
NetworkPkg/TcpDxe/SockImpl.c | 4 +-
NetworkPkg/TcpDxe/SockInterface.c | 10 ++--
NetworkPkg/TcpDxe/TcpDispatcher.c | 6 +--
NetworkPkg/TcpDxe/TcpDriver.c | 10 ++--
NetworkPkg/TcpDxe/TcpInput.c | 8 +--
NetworkPkg/TcpDxe/TcpMain.c | 4 +-
NetworkPkg/TcpDxe/TcpMisc.c | 2 +-
NetworkPkg/TcpDxe/TcpOption.c | 2 +-
NetworkPkg/TcpDxe/TcpOutput.c | 4 +-
NetworkPkg/TcpDxe/TcpTimer.c | 2 +-
NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 6 +--
NetworkPkg/TlsDxe/TlsDriver.c | 4 +-
NetworkPkg/Udp4Dxe/Udp4Driver.c | 4 +-
NetworkPkg/Udp4Dxe/Udp4Impl.c | 12 ++---
NetworkPkg/Udp4Dxe/Udp4Main.c | 4 +-
NetworkPkg/Udp6Dxe/Udp6Driver.c | 8 +--
NetworkPkg/Udp6Dxe/Udp6Impl.c | 18 +++----
NetworkPkg/Udp6Dxe/Udp6Main.c | 12 ++---
NetworkPkg/UefiPxeBcDxe/PxeBcBoot.c | 4 +-
NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c | 10 ++--
NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c | 18 +++----
NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c | 4 +-
NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c | 10 ++--
NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c | 12 ++---
NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c | 8 +--
NetworkPkg/VlanConfigDxe/VlanConfigDriver.c | 8 +--
OvmfPkg/AcpiPlatformDxe/BootScript.c | 2 +-
OvmfPkg/AcpiPlatformDxe/Qemu.c | 4 +-
OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 2 +-
OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c | 4 +-
OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c | 6 +--
OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 6 +--
OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c | 4 +-
OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c | 8 +--
OvmfPkg/Csm/LegacyBiosDxe/Thunk.c | 4 +-
OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c | 14 +++---
OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c | 18 +++----
OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c | 4 +-
OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 4 +-
OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c | 2 +-
OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c | 2 +-
OvmfPkg/Library/VirtioLib/VirtioLib.c | 2 +-
OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c | 6 +--
OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbInfo.c | 4 +-
OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c | 8 +--
OvmfPkg/QemuVideoDxe/Driver.c | 2 +-
OvmfPkg/VirtioNetDxe/DriverBinding.c | 2 +-
OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c | 2 +-
OvmfPkg/VirtioRngDxe/VirtioRng.c | 2 +-
OvmfPkg/VirtioScsiDxe/VirtioScsi.c | 2 +-
OvmfPkg/XenBusDxe/XenBus.c | 2 +-
OvmfPkg/XenBusDxe/XenBusDxe.c | 6 +--
OvmfPkg/XenBusDxe/XenStore.c | 4 +-
OvmfPkg/XenPvBlkDxe/BlockFront.c | 2 +-
OvmfPkg/XenPvBlkDxe/BlockIo.c | 8 +--
OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.c | 2 +-
PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c | 2 +-
PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c | 6 +--
SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c | 2 +-
SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c | 2 +-
SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c | 2 +-
SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c | 2 +-
SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.c | 2 +-
SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c | 2 +-
SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c | 2 +-
SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c | 2 +-
SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c | 4 +-
SecurityPkg/Library/Tpm2CommandLib/Tpm2Miscellaneous.c | 2 +-
SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 4 +-
SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c | 6 +--
SecurityPkg/Library/TpmCommLib/TisPc.c | 2 +-
SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c | 2 +-
SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.c | 2 +-
SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c | 10 ++--
SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 2 +-
SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c | 8 +--
SecurityPkg/Tcg/PhysicalPresencePei/PhysicalPresencePei.c | 2 +-
SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c | 2 +-
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 +-
SecurityPkg/Tcg/TcgPei/TcgPei.c | 8 +--
SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigFileExplorer.c | 2 +-
SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c | 2 +-
ShellPkg/Application/Shell/ConsoleLogger.c | 12 ++---
ShellPkg/Application/Shell/ConsoleWrappers.c | 2 +-
ShellPkg/Application/Shell/FileHandleWrappers.c | 8 +--
ShellPkg/Application/Shell/Shell.c | 8 +--
ShellPkg/Application/Shell/ShellEnvVar.c | 8 +--
ShellPkg/Application/Shell/ShellManParser.c | 20 ++++----
ShellPkg/Application/Shell/ShellParametersProtocol.c | 26 +++++-----
ShellPkg/Application/Shell/ShellProtocol.c | 36 +++++++-------
ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 4 +-
ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.c | 2 +-
ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.c | 4 +-
ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c | 4 +-
ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 8 +--
ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.c | 2 +-
ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.c | 4 +-
SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c | 26 +++++-----
SignedCapsulePkg/Universal/RecoveryModuleLoadPei/ParseConfigProfile.c | 2 +-
SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.c | 14 +++---
SignedCapsulePkg/Universal/SystemFirmwareUpdate/ParseConfigProfile.c | 2 +-
SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c | 4 +-
SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.c | 8 +--
SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c | 4 +-
SourceLevelDebugPkg/DebugAgentDxe/DebugAgentDxe.c | 2 +-
SourceLevelDebugPkg/DebugAgentPei/DebugAgentPei.c | 2 +-
SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c | 52 ++++++++++----------
SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/DxeDebugAgentLib.c | 2 +-
SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c | 6 +--
SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c | 10 ++--
SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebugAgentLib.c | 10 ++--
SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.c | 2 +-
SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Common.c | 2 +-
SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Dxe.c | 2 +-
SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Transfer.c | 4 +-
StandaloneMmPkg/Core/Dependency.c | 2 +-
StandaloneMmPkg/Core/Dispatcher.c | 2 +-
StandaloneMmPkg/Core/FwVol.c | 2 +-
StandaloneMmPkg/Core/StandaloneMmCore.c | 2 +-
UefiCpuPkg/CpuDxe/CpuDxe.c | 8 +--
UefiCpuPkg/CpuDxe/CpuGdt.c | 2 +-
UefiCpuPkg/CpuDxe/CpuMp.c | 4 +-
UefiCpuPkg/CpuDxe/CpuPageTable.c | 6 +--
UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c | 4 +-
UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c | 2 +-
UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 4 +-
UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c | 4 +-
UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c | 2 +-
UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c | 2 +-
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 4 +-
UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 4 +-
UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 6 +--
UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c | 2 +-
EmulatorPkg/Sec/Ia32/SwitchRam.S | 18 +++----
EmulatorPkg/Sec/Ia32/SwitchRam.asm | 20 ++++----
EmulatorPkg/Sec/X64/SwitchRam.S | 2 +-
EmulatorPkg/Sec/X64/SwitchRam.asm | 2 +-
EmulatorPkg/Unix/GdbRun.sh | 4 +-
EmulatorPkg/Unix/Host/X64/Gasket.S | 4 +-
EmulatorPkg/Unix/Host/X64/SwitchStack.S | 2 +-
EmulatorPkg/Unix/lldbefi.py | 14 +++---
IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nasm | 6 +--
IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/SecEntry.nasm | 2 +-
IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Stack.nasm | 2 +-
MdeModulePkg/Application/UiApp/FrontPageStrings.uni | 6 +--
MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.uni | 2 +-
MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.uni | 2 +-
MdePkg/Library/DxePcdLib/DxePcdLib.uni | 2 +-
NetworkPkg/MnpDxe/MnpDxe.uni | 4 +-
OvmfPkg/AcpiTables/Facp.aslc | 8 +--
OvmfPkg/AcpiTables/Facs.aslc | 4 +-
OvmfPkg/AcpiTables/Madt.aslc | 2 +-
OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni | 8 +--
OvmfPkg/QemuVideoDxe/VbeShim.asm | 14 +++---
SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.uni | 4 +-
SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.uni | 2 +-
SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.uni | 2 +-
SecurityPkg/Tcg/TcgSmm/TcgSmm.uni | 2 +-
ShellPkg/Application/ShellCTestApp/README.txt | 2 +-
SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/AsmFuncs.nasm | 4 +-
SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.uni | 2 +-
UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm | 2 +-
UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 2 +-
UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm | 2 +-
587 files changed, 1853 insertions(+), 1854 deletions(-)
--
2.21.0
^ permalink raw reply [flat|nested] 122+ messages in thread* Re: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)
2019-12-04 1:16 ` [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1) Nate DeSimone
@ 2019-12-04 1:27 ` Liming Gao
2019-12-04 9:09 ` Laszlo Ersek
2019-12-04 16:29 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 122+ messages in thread
From: Liming Gao @ 2019-12-04 1:27 UTC (permalink / raw)
To: Desimone, Nathaniel L, devel@edk2.groups.io, philmd@redhat.com,
Achin Gupta, Andrew Fish, Anthony Perard, Ard Biesheuvel,
Zhang, Chao B, Chiu, Chasel, Dong, Eric, Wu, Hao A, Wang, Jian J,
Wu, Jiaxin, Yao, Jiewen, Justen, Jordan L, Julien Grall,
Laszlo Ersek, Leif Lindholm, Rabeda, Maciej, Kinney, Michael D,
Ni, Ray, Fu, Siyuan, Zeng, Star, Supreeth Venkatesh, Lu, XiaoyuX,
Gao, Zhichao
Cc: Antoine C?ur
You can also mention the fork branch with all changes. Then, the reviewer can see all changes.
Thanks
Liming
>-----Original Message-----
>From: Desimone, Nathaniel L
>Sent: Wednesday, December 04, 2019 9:16 AM
>To: devel@edk2.groups.io; philmd@redhat.com; Achin Gupta
><achin.gupta@arm.com>; Andrew Fish <afish@apple.com>; Anthony Perard
><anthony.perard@citrix.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>;
>Zhang, Chao B <chao.b.zhang@intel.com>; Chiu, Chasel
><chasel.chiu@intel.com>; Dong, Eric <eric.dong@intel.com>; Wu, Hao A
><hao.a.wu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Wu, Jiaxin
><jiaxin.wu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Justen, Jordan
>L <jordan.l.justen@intel.com>; Julien Grall <julien@xen.org>; Laszlo Ersek
><lersek@redhat.com>; Leif Lindholm <leif.lindholm@linaro.org>; Gao, Liming
><liming.gao@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Kinney,
>Michael D <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>; Fu,
>Siyuan <siyuan.fu@intel.com>; Zeng, Star <star.zeng@intel.com>; Supreeth
>Venkatesh <supreeth.venkatesh@arm.com>; Lu, XiaoyuX
><xiaoyux.lu@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
>Cc: Antoine Cœur <coeur@gmx.fr>
>Subject: RE: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)
>
>Hi Philippe and Antoine,
>
>Thank you very much for doing this work!
>
>Please note that the mailing list currently has the braindead behavior only
>allowing a user to send 40 emails in a 30 minute window. I believe this is done
>to prevent spamming. Because of this, only patches 0-39 were actually
>received. Myself and Michael recently ran into this same problem with the
>Advanced Feature Refactor patch series. We worked around it by sending our
>emails in batches and waiting 30 minutes between each batch.
>
>Thanks,
>Nate
>
>-----Original Message-----
>From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Philippe
>Mathieu-Daudé
>Sent: Tuesday, December 3, 2019 8:15 AM
>To: devel@edk2.groups.io; Achin Gupta <achin.gupta@arm.com>; Andrew
>Fish <afish@apple.com>; Anthony Perard <anthony.perard@citrix.com>; Ard
>Biesheuvel <ard.biesheuvel@linaro.org>; Zhang, Chao B
><chao.b.zhang@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Dong, Eric
><eric.dong@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Wang, Jian J
><jian.j.wang@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Yao, Jiewen
><jiewen.yao@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>;
>Julien Grall <julien@xen.org>; Laszlo Ersek <lersek@redhat.com>; Leif
>Lindholm <leif.lindholm@linaro.org>; Gao, Liming <liming.gao@intel.com>;
>Rabeda, Maciej <maciej.rabeda@intel.com>; Kinney, Michael D
><michael.d.kinney@intel.com>; Desimone, Nathaniel L
><nathaniel.l.desimone@intel.com>; Philippe Mathieu-Daude
><philmd@redhat.com>; Ni, Ray <ray.ni@intel.com>; Fu, Siyuan
><siyuan.fu@intel.com>; Zeng, Star <star.zeng@intel.com>; Supreeth
>Venkatesh <supreeth.venkatesh@arm.com>; Lu, XiaoyuX
><xiaoyux.lu@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
>Cc: Antoine Cœur <coeur@gmx.fr>
>Subject: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)
>
>Around February of this year, Antoine posted various patches fixing
>a huge quantity of typos, over 8000+ lines (such [1]).
>
>The community merged the smaller patches, and told him his patches
>were too big, and he should split them.
>Around June, Antoine opened a GitHub pull request [2], due to the
>size of his patchset. We told him the project doesn't accept GitHub
>PR.
>
>Since I find his cleanup work very valuable for the project, I
>spent few hours trying to salvage a chunk of it, splitting per
>maintainer areas, each patch not to big to avoid reviewers burning
>out. I expect each maintainer to take his patches.
>
>I wanted to split Antoine work in 3 parts, but I'm about at 80
>patches, for only 1854 lines changed, so enough for a first round.
>
>Oh, and it is easier to review the patches using '--word-diff=color'
>git option :)
>
>Regards,
>
>Phil.
>
>P.D.: I think the project is really failing at getting new
>contributors involved, and keeping them. But that is another topic.
>
>[1] https://edk2.groups.io/g/devel/message/43043
>[2] https://edk2.groups.io/g/devel/message/42941
>
>Antoine Coeur (72):
> CryptoPkg/OpensslLib: Fix few typos
> EmbeddedPkg/FdtLib: Fix a typo
> EmbeddedPkg/VirtualKeyboard: Fix few typos
> EmulatorPkg/Sec: Fix various typos
> EmulatorPkg/Unix: Fix various typos
> EmulatorPkg/Win: Fix various typos
> FatPkg/EnhancedFatDxe: Fix various typos
> FatPkg/FatPei: Fix few typos
> IntelFsp2WrapperPkg: Fix various typos
> MdeModulePkg/Application: Improve French translation
> MdeModulePkg/Application: Fix various typos
> MdeModulePkg/Bus/Ata: Fix various typos
> MdeModulePkg/Bus/I2c: Fix few typos
> MdeModulePkg/Bus/Isa: Fix various typos
> MdeModulePkg/Bus/Scsi: Fix various typos
> MdeModulePkg/Bus/Sd: Fix various typos
> MdeModulePkg/Core/Pei: Fix various typos
> MdeModulePkg/Core/PiSmmCore: Fix various typos
> MdeModulePkg/UsbMass: Fix various typos
> MdeModulePkg/UsbMouse: Fix few typos
> MdeModulePkg/UsbBus: Fix various typos
> MdeModulePkg/Usb: Fix various typos
> MdePkg/IndustryStandard: Fix various typos
> MdePkg/Library/Dxe: Fix various typos
> MdePkg/Library/Pci: Fix various typos
> MdePkg/Library/Smm: Fix various typos
> MdePkg/Ppi: Fix various typos
> MdePkg/Register: Fix various typos
> NetworkPkg/ArpDxe: Fix various typos
> NetworkPkg/Dhcp4Dxe: Fix various typos
> NetworkPkg/Dhcp6Dxe: Fix various typos
> NetworkPkg/DnsDxe: Fix various typos
> NetworkPkg/DpcDxe: Fix few typos
> NetworkPkg/HttpBootDxe: Fix various typos
> NetworkPkg/HttpDxe: Fix various typos
> NetworkPkg/Ip4Dxe: Fix various typos
> NetworkPkg/Ip6Dxe: Fix various typos
> NetworkPkg/IScsiDxe: Fix various typos
> NetworkPkg/Library: Fix various typos
> NetworkPkg/MnpDxe: Fix various typos
> NetworkPkg/Mtftp4Dxe: Fix various typos
> NetworkPkg/Mtftp6Dxe: Fix various typos
> NetworkPkg/SnpDxe: Fix few typos
> NetworkPkg/TcpDxe/Sock: Fix few typos
> NetworkPkg/TcpDxe/Tcp: Fix various typos
> NetworkPkg/Tls: Fix few typos
> NetworkPkg/Udp4Dxe: Fix various typos
> NetworkPkg/Udp6Dxe: Fix various typos
> NetworkPkg/UefiPxeBcDxe: Fix various typos
> NetworkPkg/VlanConfigDxe: Fix few typos
> OvmfPkg/Acpi: Fix few typos
> OvmfPkg/Csm: Fix various typos
> OvmfPkg/Qemu: Fix various typos
> OvmfPkg/Virtio: Fix few typos
> OvmfPkg/Xen: Fix various typos
> PcAtChipsetPkg: Fix few typos
> SecurityPkg: Fix few typos
> SecurityPkg/Hash2DxeCrypto: Fix few typos
> SecurityPkg/Library/Tpm: Fix various typos
> SecurityPkg/Tcg: Fix various typos
> SecurityPkg/VariableAuthenticated: Fix few typos
> ShellPkg/Application: Fix various typos
> ShellPkg/DynamicCommand: Fix various typos
> SignedCapsulePkg: Fix various typos
> SignedCapsulePkg/Universal: Fix various typos
> SourceLevelDebugPkg/DebugAgent: Fix various typos
> SourceLevelDebugPkg/DebugCommunicationLib: Fix various typos
> SourceLevelDebugPkg: Fix few typos
> StandaloneMmPkg: Fix few typos
> UefiCpuPkg/CpuDxe: Fix few typos
> UefiCpuPkg/PiSmm: Fix various typos
> UefiCpuPkg/Smm: Fix various typos
>
>Philippe Mathieu-Daude (7):
> EmbeddedPkg/VirtualKeyboard: Fix a typo in EFI_INVALID_PARAMETER
> MdeModulePkg/UsbBusDxe: Fix a typo
> NetworkPkg: Fix a typo
> NetworkPkg/DnsDxe: Fix a typo
> NetworkPkg/HttpBootDxe: Fix a typo in variable name
> OvmfPkg/Xen: Fix a typo
> StandaloneMmPkg: Fix a typo
>
> SignedCapsulePkg/SignedCapsulePkg.dec | 4 +-
> MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
>| 2 +-
> MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf
>| 2 +-
> MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf |
>10 ++--
> MdePkg/Library/DxePcdLib/DxePcdLib.inf | 2 +-
> NetworkPkg/MnpDxe/MnpDxe.inf | 2 +-
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf
>| 2 +-
> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf
>| 4 +-
> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf
>| 4 +-
> SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf |
>2 +-
> SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
>| 2 +-
> SecurityPkg/Tcg/TcgSmm/TcgSmm.inf | 2 +-
>
>SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCom
>municationLibSerialPort.inf | 2 +-
>
>StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/Standalone
>MmPeCoffExtraActionLib.inf | 2 +-
> EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h
>| 36 +++++++-------
> EmbeddedPkg/Include/libfdt.h | 2 +-
> EmulatorPkg/Sec/Sec.h | 4 +-
> EmulatorPkg/Win/Host/WinGop.h | 2 +-
> EmulatorPkg/Win/Host/WinHost.h | 2 +-
> FatPkg/EnhancedFatDxe/Fat.h | 6 +--
> FatPkg/FatPei/FatLitePeim.h | 2 +-
> IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h
>| 2 +-
> IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h
>| 4 +-
> MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.h
>| 2 +-
> MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.h
>| 2 +-
> MdeModulePkg/Bus/Ata/AhciPei/AhciPei.h | 4
>+-
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h
>| 4 +-
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.h
>| 4 +-
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.h
>| 2 +-
> MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h |
>12 ++---
> MdeModulePkg/Bus/I2c/I2cDxe/I2cDxe.h | 4 +-
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
>| 14 +++---
> MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.h
>| 2 +-
> MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.h
>| 2 +-
> MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.h | 4
>+-
> MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h |
>10 ++--
> MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.h
>| 2 +-
> MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h
>| 6 +--
> MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.h
>| 2 +-
> MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.h | 6
>+--
> MdeModulePkg/Bus/Sd/SdDxe/SdDxe.h | 2
>+-
> MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h
>| 2 +-
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.h
>| 14 +++---
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.h
>| 2 +-
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h
>| 2 +-
> MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h
>| 2 +-
> MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h
>| 2 +-
> MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.h
>| 2 +-
> MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h |
>10 ++--
> MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.h
>| 2 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h
>| 4 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.h
>| 4 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.h
>| 2 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.h
>| 2 +-
>
>MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolut
>ePointer.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.h
>| 2 +-
> MdeModulePkg/Core/Pei/PeiMain.h | 20
>++++----
> MdeModulePkg/Core/PiSmmCore/HeapGuard.h
>| 2 +-
> MdeModulePkg/Core/PiSmmCore/PiSmmCore.h
>| 12 ++---
> MdeModulePkg/Core/PiSmmCore/PiSmmCorePrivateData.h
>| 6 +--
> MdePkg/Include/IndustryStandard/Acpi10.h | 4
>+-
> MdePkg/Include/IndustryStandard/Acpi20.h | 4
>+-
> MdePkg/Include/IndustryStandard/Acpi30.h | 4
>+-
> MdePkg/Include/IndustryStandard/Acpi40.h | 2
>+-
> MdePkg/Include/IndustryStandard/Acpi50.h | 6
>+--
> MdePkg/Include/IndustryStandard/Acpi51.h | 4
>+-
> MdePkg/Include/IndustryStandard/Acpi60.h | 4
>+-
> MdePkg/Include/IndustryStandard/Acpi61.h | 4
>+-
> MdePkg/Include/IndustryStandard/Acpi62.h | 8
>+--
> MdePkg/Include/IndustryStandard/Atapi.h | 40
>+++++++--------
> MdePkg/Include/IndustryStandard/ElTorito.h | 4
>+-
> MdePkg/Include/IndustryStandard/Emmc.h | 2
>+-
> MdePkg/Include/IndustryStandard/IpmiNetFnBridge.h
>| 4 +-
> MdePkg/Include/IndustryStandard/Nvme.h | 10
>++--
> MdePkg/Include/IndustryStandard/Pci22.h | 20
>++++----
> MdePkg/Include/IndustryStandard/PeImage.h | 2
>+-
> MdePkg/Include/IndustryStandard/Scsi.h | 2 +-
> MdePkg/Include/IndustryStandard/SmBus.h | 2
>+-
> MdePkg/Include/IndustryStandard/Tpm12.h | 2
>+-
> MdePkg/Include/Library/DxeServicesLib.h | 2 +-
> MdePkg/Include/Library/PciCf8Lib.h | 4 +-
> MdePkg/Include/Library/PciExpressLib.h | 4 +-
> MdePkg/Include/Library/PciLib.h | 4 +-
> MdePkg/Include/Library/PciSegmentLib.h | 4 +-
> MdePkg/Include/Library/SmmLib.h | 4 +-
> MdePkg/Include/Library/SmmMemLib.h | 4 +-
> MdePkg/Include/Library/SmmPeriodicSmiLib.h | 6
>+--
> MdePkg/Include/Ppi/BlockIo.h | 4 +-
> MdePkg/Include/Ppi/BlockIo2.h | 2 +-
> MdePkg/Include/Ppi/Capsule.h | 2 +-
> MdePkg/Include/Ppi/Decompress.h | 2 +-
> MdePkg/Include/Ppi/DeviceRecoveryModule.h |
>2 +-
> MdePkg/Include/Ppi/IsaHc.h | 2 +-
> MdePkg/Include/Ppi/MpServices.h | 2 +-
> MdePkg/Include/Ppi/Pcd.h | 4 +-
> MdePkg/Include/Ppi/RecoveryModule.h | 2 +-
> MdePkg/Include/Ppi/TemporaryRamDone.h | 2
>+-
> MdePkg/Include/Ppi/VectorHandoffInfo.h | 2 +-
> MdePkg/Include/Register/Amd/Cpuid.h | 8 +--
> MdePkg/Include/Register/Amd/Fam17Msr.h | 2
>+-
> MdePkg/Include/Register/Amd/Msr.h | 2 +-
> MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h
>| 2 +-
> MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h |
>2 +-
> MdePkg/Include/Register/Intel/StmResourceDescriptor.h
>| 2 +-
> NetworkPkg/ArpDxe/ArpDriver.h | 10 ++--
> NetworkPkg/ArpDxe/ArpImpl.h | 14 +++---
> NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h | 4 +-
> NetworkPkg/Dhcp4Dxe/Dhcp4Io.h | 2 +-
> NetworkPkg/Dhcp4Dxe/Dhcp4Option.h | 18
>+++----
> NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h | 4 +-
> NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h | 12 ++-
>--
> NetworkPkg/DnsDxe/DnsDriver.h | 12 ++---
> NetworkPkg/DnsDxe/DnsImpl.h | 28
>+++++------
> NetworkPkg/DpcDxe/Dpc.h | 2 +-
> NetworkPkg/HttpBootDxe/HttpBootConfig.h | 2
>+-
> NetworkPkg/HttpBootDxe/HttpBootDhcp4.h | 2
>+-
> NetworkPkg/HttpBootDxe/HttpBootDhcp6.h | 4
>+-
> NetworkPkg/HttpBootDxe/HttpBootDxe.h | 6
>+--
> NetworkPkg/HttpBootDxe/HttpBootSupport.h |
>10 ++--
> NetworkPkg/HttpDxe/HttpDriver.h | 8 +--
> NetworkPkg/HttpDxe/HttpProto.h | 16 +++--
>-
> NetworkPkg/HttpDxe/HttpsSupport.h | 2 +-
> NetworkPkg/IScsiDxe/IScsiMisc.h | 8 +--
> NetworkPkg/IScsiDxe/IScsiProto.h | 10 ++--
> NetworkPkg/Include/Library/HttpLib.h | 2 +-
> NetworkPkg/Include/Library/IpIoLib.h | 4 +-
> NetworkPkg/Include/Library/NetLib.h | 2 +-
> NetworkPkg/Include/Library/TcpIoLib.h | 6 +--
> NetworkPkg/Include/Library/UdpIoLib.h | 6 +--
> NetworkPkg/Include/Protocol/Dpc.h | 2 +-
> NetworkPkg/Ip4Dxe/Ip4Common.h | 14
>+++---
> NetworkPkg/Ip4Dxe/Ip4Config2Impl.h | 2 +-
> NetworkPkg/Ip4Dxe/Ip4Driver.h | 6 +--
> NetworkPkg/Ip4Dxe/Ip4Icmp.h | 10 ++--
> NetworkPkg/Ip4Dxe/Ip4If.h | 4 +-
> NetworkPkg/Ip4Dxe/Ip4Igmp.h | 4 +-
> NetworkPkg/Ip4Dxe/Ip4Impl.h | 8 +--
> NetworkPkg/Ip4Dxe/Ip4Input.h | 6 +--
> NetworkPkg/Ip4Dxe/Ip4Option.h | 4 +-
> NetworkPkg/Ip4Dxe/Ip4Output.h | 4 +-
> NetworkPkg/Ip4Dxe/Ip4Route.h | 12 ++---
> NetworkPkg/Ip6Dxe/Ip6ConfigImpl.h | 4 +-
> NetworkPkg/Ip6Dxe/Ip6Driver.h | 8 +--
> NetworkPkg/Ip6Dxe/Ip6Icmp.h | 4 +-
> NetworkPkg/Ip6Dxe/Ip6If.h | 4 +-
> NetworkPkg/Ip6Dxe/Ip6Impl.h | 8 +--
> NetworkPkg/Ip6Dxe/Ip6Input.h | 6 +--
> NetworkPkg/Ip6Dxe/Ip6Mld.h | 2 +-
> NetworkPkg/Ip6Dxe/Ip6Nd.h | 4 +-
> NetworkPkg/Ip6Dxe/Ip6Route.h | 10 ++--
> NetworkPkg/MnpDxe/MnpDriver.h | 6 +--
> NetworkPkg/MnpDxe/MnpImpl.h | 14 +++-
>--
> NetworkPkg/Mtftp4Dxe/Mtftp4Driver.h | 2 +-
> NetworkPkg/Mtftp4Dxe/Mtftp4Impl.h | 2 +-
> NetworkPkg/Mtftp4Dxe/Mtftp4Option.h | 6 +-
>-
> NetworkPkg/Mtftp4Dxe/Mtftp4Support.h | 2
>+-
> NetworkPkg/Mtftp6Dxe/Mtftp6Driver.h | 4 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Impl.h | 4 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Option.h | 2 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Support.h | 2
>+-
> NetworkPkg/SnpDxe/Snp.h | 8 +--
> NetworkPkg/TcpDxe/SockImpl.h | 2 +-
> NetworkPkg/TcpDxe/Socket.h | 36
>+++++++-------
> NetworkPkg/TcpDxe/TcpDriver.h | 8 +--
> NetworkPkg/TcpDxe/TcpFunc.h | 4 +-
> NetworkPkg/TcpDxe/TcpMain.h | 4 +-
> NetworkPkg/TcpDxe/TcpOption.h | 6 +--
> NetworkPkg/TcpDxe/TcpProto.h | 14 +++---
> NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h
>| 2 +-
> NetworkPkg/TlsDxe/TlsDriver.h | 4 +-
> NetworkPkg/Udp4Dxe/Udp4Driver.h | 4 +-
> NetworkPkg/Udp4Dxe/Udp4Impl.h | 4 +-
> NetworkPkg/Udp6Dxe/Udp6Driver.h | 6 +--
> NetworkPkg/Udp6Dxe/Udp6Impl.h | 12 ++--
>-
> NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.h | 2
>+-
> NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h | 8
>+--
> NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h | 4
>+-
> NetworkPkg/UefiPxeBcDxe/PxeBcSupport.h | 16
>+++---
> NetworkPkg/VlanConfigDxe/VlanConfigImpl.h | 6
>+--
> OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h |
>10 ++--
> OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h
>| 8 +--
> OvmfPkg/Csm/Include/Framework/BootScript.h |
>2 +-
>
>OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.
>h | 2 +-
> OvmfPkg/Csm/Include/Protocol/IsaAcpi.h | 2 +-
> OvmfPkg/Csm/Include/Protocol/IsaIo.h | 2 +-
> OvmfPkg/Csm/Include/Protocol/LegacyBios.h | 6
>+--
> OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h
>| 4 +-
> OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h | 2
>+-
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h
>| 8 +--
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h
>| 4 +-
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h
>| 2 +-
> OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h
>| 2 +-
> OvmfPkg/Include/IndustryStandard/Xen/grant_table.h
>| 4 +-
> OvmfPkg/Include/IndustryStandard/Xen/io/blkif.h |
>2 +-
> OvmfPkg/Include/Library/VirtioLib.h | 2 +-
> OvmfPkg/Include/Protocol/XenBus.h | 4 +-
> OvmfPkg/Include/Protocol/XenIo.h | 2 +-
> OvmfPkg/XenBusDxe/DriverBinding.h | 2 +-
> OvmfPkg/XenBusDxe/EventChannel.h | 2 +-
> OvmfPkg/XenBusDxe/GrantTable.h | 4 +-
> OvmfPkg/XenPvBlkDxe/BlockIo.h | 6 +--
> OvmfPkg/XenPvBlkDxe/DriverBinding.h | 2 +-
> SecurityPkg/Include/Library/TcgStorageCoreLib.h | 4
>+-
> SecurityPkg/Include/Library/TpmCommLib.h | 4
>+-
> SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h | 6
>+--
> ShellPkg/Application/Shell/ConsoleLogger.h | 4 +-
> ShellPkg/Application/Shell/FileHandleWrappers.h | 6
>+--
> ShellPkg/Application/Shell/Shell.h | 2 +-
> ShellPkg/Application/Shell/ShellEnvVar.h | 36
>+++++++-------
> ShellPkg/Application/Shell/ShellManParser.h | 10
>++--
> ShellPkg/Application/Shell/ShellParametersProtocol.h |
>20 ++++----
> ShellPkg/Application/Shell/ShellProtocol.h | 12 ++--
>-
> ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h
>| 2 +-
> ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.h
>| 2 +-
> SignedCapsulePkg/Include/Guid/EdkiiSystemFmpCapsule.h
>| 4 +-
> SignedCapsulePkg/Include/Library/IniParsingLib.h | 14
>+++---
>
>SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h
>| 2 +-
> SourceLevelDebugPkg/Include/Ia32/ProcessorContext.h
>| 2 +-
> SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
>| 2 +-
> SourceLevelDebugPkg/Include/TransferProtocol.h |
>6 +--
>
>SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.
>h | 6 +--
>
>SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/Arch
>DebugSupport.h | 2 +-
>
>SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/Debu
>gException.h | 2 +-
>
>SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/ArchD
>ebugSupport.h | 2 +-
>
>SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/Debu
>gException.h | 2 +-
>
>SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
>icationLibUsb3Internal.h | 4 +-
> UefiCpuPkg/CpuDxe/CpuDxe.h | 2 +-
> UefiCpuPkg/CpuDxe/CpuGdt.h | 2 +-
> UefiCpuPkg/CpuDxe/CpuMp.h | 4 +-
> UefiCpuPkg/CpuDxe/CpuPageTable.h | 2 +-
> UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h |
>4 +-
> UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h
>| 4 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
>| 12 ++---
> NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigVfr.vfr |
>6 +--
> CryptoPkg/Library/OpensslLib/rand_pool.c | 8 +--
> CryptoPkg/Library/OpensslLib/rand_pool_noise.c | 2
>+-
> EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c
>| 16 +++---
> EmulatorPkg/Sec/Sec.c | 5 +-
> EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 2
>+-
> EmulatorPkg/Unix/Host/BlockIo.c | 12 ++---
> EmulatorPkg/Unix/Host/EmuThunk.c | 2 +-
> EmulatorPkg/Unix/Host/Host.c | 26 +++++--
>---
> EmulatorPkg/Unix/Host/LinuxPacketFilter.c | 2 +-
> EmulatorPkg/Unix/Host/Pthreads.c | 2 +-
> EmulatorPkg/Win/Host/WinBlockIo.c | 4 +-
> EmulatorPkg/Win/Host/WinFileSystem.c | 2 +-
> EmulatorPkg/Win/Host/WinGopInput.c | 4 +-
> EmulatorPkg/Win/Host/WinGopScreen.c | 14
>+++---
> EmulatorPkg/Win/Host/WinHost.c | 10 ++--
> FatPkg/EnhancedFatDxe/Delete.c | 2 +-
> FatPkg/EnhancedFatDxe/DirectoryManage.c | 2
>+-
> FatPkg/EnhancedFatDxe/Fat.c | 2 +-
> FatPkg/EnhancedFatDxe/FileName.c | 2 +-
> FatPkg/EnhancedFatDxe/FileSpace.c | 6 +--
> FatPkg/EnhancedFatDxe/Flush.c | 4 +-
> FatPkg/FatPei/FatLiteApi.c | 2 +-
> FatPkg/FatPei/Mbr.c | 2 +-
> IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
>| 2 +-
>
>IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapp
>erPlatformLibSample.c | 4 +-
>
>IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrap
>perHobProcessLibSample.c | 4 +-
> MdeModulePkg/Application/CapsuleApp/CapsuleApp.c
>| 2 +-
> MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
>| 4 +-
> MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c
>| 2 +-
> MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
>| 2 +-
> MdeModulePkg/Bus/Ata/AhciPei/AhciMode.c |
>8 +--
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
>| 14 +++---
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c
>| 8 +--
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c
>| 16 +++---
> MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c |
>10 ++--
> MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c
>| 4 +-
> MdeModulePkg/Bus/I2c/I2cDxe/I2cBus.c | 4 +-
> MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c | 2 +-
> MdeModulePkg/Bus/Isa/IsaBusDxe/IsaBusDxe.c |
>6 +--
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
>| 16 +++---
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c
>| 20 ++++----
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c
>| 4 +-
> MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.c
>| 2 +-
> MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.c
>| 4 +-
> MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 6
>+--
> MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c |
>32 ++++++------
> MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c
>| 2 +-
> MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
>| 12 ++---
> MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c
>| 12 ++---
> MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.c
>| 2 +-
> MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
>| 2 +-
> MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHci.c | 6
>+--
> MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 10
>++--
> MdeModulePkg/Bus/Sd/SdDxe/SdDxe.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbBotPei/BotPeim.c |
>2 +-
> MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c |
>2 +-
> MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c |
>2 +-
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c |
>12 ++---
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c
>| 2 +-
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c
>| 2 +-
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c
>| 4 +-
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c
>| 8 +--
> MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c |
>2 +-
> MdeModulePkg/Bus/Usb/UsbBusPei/UsbIoPeim.c
>| 2 +-
> MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c |
>8 +--
> MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c
>| 6 +--
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c
>| 4 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.c
>| 4 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.c
>| 4 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c
>| 4 +-
> MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/MouseHid.c
>| 2 +-
>
>MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolut
>ePointer.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c
>| 2 +-
> MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c
>| 2 +-
> MdeModulePkg/Core/Pei/Dependency/Dependency.c
>| 4 +-
> MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c |
>28 +++++------
> MdeModulePkg/Core/Pei/FwVol/FwVol.c | 8
>+--
> MdeModulePkg/Core/Pei/Hob/Hob.c | 2 +-
> MdeModulePkg/Core/Pei/Image/Image.c | 8
>+--
> MdeModulePkg/Core/Pei/Memory/MemoryServices.c
>| 10 ++--
> MdeModulePkg/Core/Pei/PeiMain/PeiMain.c | 4
>+-
> MdeModulePkg/Core/Pei/Ppi/Ppi.c | 2 +-
> MdeModulePkg/Core/Pei/Security/Security.c | 2
>+-
> MdeModulePkg/Core/PiSmmCore/Dependency.c
>| 4 +-
> MdeModulePkg/Core/PiSmmCore/Dispatcher.c |
>24 ++++-----
> MdeModulePkg/Core/PiSmmCore/HeapGuard.c
>| 4 +-
> MdeModulePkg/Core/PiSmmCore/Locate.c | 8
>+--
> MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
>| 8 +--
> MdeModulePkg/Core/PiSmmCore/Page.c | 4
>+-
> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
>| 10 ++--
> MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c |
>8 +--
> MdeModulePkg/Core/PiSmmCore/Smi.c | 2
>+-
> MdeModulePkg/Core/PiSmmCore/SmramProfileRecord.c
>| 4 +-
> MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.c
>| 10 ++--
> MdePkg/Library/DxeHobLib/HobLib.c | 2 +-
> MdePkg/Library/DxeIoLibCpuIo2/IoLib.c | 2 +-
> MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.c
>| 6 +--
> MdePkg/Library/DxeServicesLib/DxeServicesLib.c |
>12 ++---
> MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.c
>| 2 +-
> MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c | 2
>+-
> MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePciSegmentLib.c
>| 2 +-
> MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c
>| 4 +-
> MdePkg/Library/SmmMemLib/SmmMemLib.c |
>4 +-
> MdePkg/Library/SmmPciExpressLib/PciExpressLib.c |
>4 +-
> MdePkg/Library/SmmPciLibPciRootBridgeIo/PciLib.c |
>6 +--
> MdePkg/Library/SmmPeriodicSmiLib/SmmPeriodicSmiLib.c
>| 42 ++++++++--------
> MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.c
>| 2 +-
> NetworkPkg/ArpDxe/ArpDriver.c | 14 +++---
> NetworkPkg/ArpDxe/ArpImpl.c | 16 +++---
> NetworkPkg/ArpDxe/ArpMain.c | 10 ++--
> NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c | 8 +--
> NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c | 6 +--
> NetworkPkg/Dhcp4Dxe/Dhcp4Io.c | 12 ++---
> NetworkPkg/Dhcp4Dxe/Dhcp4Option.c | 26
>+++++-----
> NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c | 12 ++-
>--
> NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c | 12 ++--
>-
> NetworkPkg/Dhcp6Dxe/Dhcp6Io.c | 26
>+++++-----
> NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c | 16
>+++---
> NetworkPkg/DnsDxe/DnsDriver.c | 12 ++---
> NetworkPkg/DnsDxe/DnsImpl.c | 28
>+++++------
> NetworkPkg/DnsDxe/DnsProtocol.c | 16 +++-
>--
> NetworkPkg/DpcDxe/Dpc.c | 6 +--
> NetworkPkg/HttpBootDxe/HttpBootConfig.c | 4
>+-
> NetworkPkg/HttpBootDxe/HttpBootDhcp4.c | 2
>+-
> NetworkPkg/HttpBootDxe/HttpBootDhcp6.c | 10
>++--
> NetworkPkg/HttpBootDxe/HttpBootDxe.c | 8
>+--
> NetworkPkg/HttpBootDxe/HttpBootImpl.c | 2
>+-
> NetworkPkg/HttpBootDxe/HttpBootSupport.c |
>12 ++---
> NetworkPkg/HttpDxe/HttpDriver.c | 12 ++---
> NetworkPkg/HttpDxe/HttpImpl.c | 10 ++--
> NetworkPkg/HttpDxe/HttpProto.c | 22 ++++-
>----
> NetworkPkg/HttpDxe/HttpsSupport.c | 2 +-
> NetworkPkg/IScsiDxe/ComponentName.c | 2
>+-
> NetworkPkg/IScsiDxe/IScsiCHAP.c | 4 +-
> NetworkPkg/IScsiDxe/IScsiConfig.c | 6 +--
> NetworkPkg/IScsiDxe/IScsiDhcp.c | 4 +-
> NetworkPkg/IScsiDxe/IScsiDriver.c | 10 ++--
> NetworkPkg/IScsiDxe/IScsiMisc.c | 6 +--
> NetworkPkg/IScsiDxe/IScsiProto.c | 40
>+++++++--------
> NetworkPkg/Ip4Dxe/Ip4Common.c | 10 ++--
> NetworkPkg/Ip4Dxe/Ip4Config2Impl.c | 10 ++--
> NetworkPkg/Ip4Dxe/Ip4Config2Nv.c | 4 +-
> NetworkPkg/Ip4Dxe/Ip4Driver.c | 10 ++--
> NetworkPkg/Ip4Dxe/Ip4Icmp.c | 2 +-
> NetworkPkg/Ip4Dxe/Ip4If.c | 14 +++---
> NetworkPkg/Ip4Dxe/Ip4Igmp.c | 8 +--
> NetworkPkg/Ip4Dxe/Ip4Impl.c | 14 +++---
> NetworkPkg/Ip4Dxe/Ip4Input.c | 28 +++++-
>-----
> NetworkPkg/Ip4Dxe/Ip4Option.c | 4 +-
> NetworkPkg/Ip4Dxe/Ip4Output.c | 12 ++---
> NetworkPkg/Ip4Dxe/Ip4Route.c | 14 +++---
> NetworkPkg/Ip6Dxe/Ip6Common.c | 2 +-
> NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c | 10 ++--
> NetworkPkg/Ip6Dxe/Ip6ConfigNv.c | 6 +--
> NetworkPkg/Ip6Dxe/Ip6Driver.c | 12 ++---
> NetworkPkg/Ip6Dxe/Ip6Icmp.c | 6 +--
> NetworkPkg/Ip6Dxe/Ip6If.c | 10 ++--
> NetworkPkg/Ip6Dxe/Ip6Impl.c | 10 ++--
> NetworkPkg/Ip6Dxe/Ip6Input.c | 20 ++++---
>-
> NetworkPkg/Ip6Dxe/Ip6Mld.c | 8 +--
> NetworkPkg/Ip6Dxe/Ip6Nd.c | 12 ++---
> NetworkPkg/Ip6Dxe/Ip6Output.c | 2 +-
> NetworkPkg/Ip6Dxe/Ip6Route.c | 6 +--
> NetworkPkg/Library/DxeHttpLib/DxeHttpLib.c | 4
>+-
> NetworkPkg/Library/DxeIpIoLib/DxeIpIoLib.c | 16
>+++---
> NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 26
>+++++-----
> NetworkPkg/Library/DxeNetLib/NetBuffer.c | 4
>+-
> NetworkPkg/Library/DxeTcpIoLib/DxeTcpIoLib.c | 10
>++--
> NetworkPkg/Library/DxeUdpIoLib/DxeUdpIoLib.c |
>10 ++--
> NetworkPkg/MnpDxe/MnpConfig.c | 14
>+++---
> NetworkPkg/MnpDxe/MnpDriver.c | 10 ++--
> NetworkPkg/MnpDxe/MnpIo.c | 8 +--
> NetworkPkg/MnpDxe/MnpMain.c | 6 +--
> NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c | 4 +-
> NetworkPkg/Mtftp4Dxe/Mtftp4Impl.c | 10 ++-
>-
> NetworkPkg/Mtftp4Dxe/Mtftp4Option.c | 20
>++++----
> NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c | 10 ++-
>-
> NetworkPkg/Mtftp4Dxe/Mtftp4Support.c | 6 +-
>-
> NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c | 8 +--
> NetworkPkg/Mtftp6Dxe/Mtftp6Driver.c | 4 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Impl.c | 4 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Option.c | 4 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c | 10 ++-
>-
> NetworkPkg/Mtftp6Dxe/Mtftp6Support.c | 8 +-
>-
> NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c | 4 +-
> NetworkPkg/SnpDxe/Callback.c | 2 +-
> NetworkPkg/SnpDxe/Shutdown.c | 2 +-
> NetworkPkg/SnpDxe/Snp.c | 6 +--
> NetworkPkg/SnpDxe/WaitForPacket.c | 2 +-
> NetworkPkg/TcpDxe/SockImpl.c | 4 +-
> NetworkPkg/TcpDxe/SockInterface.c | 10 ++--
> NetworkPkg/TcpDxe/TcpDispatcher.c | 6 +--
> NetworkPkg/TcpDxe/TcpDriver.c | 10 ++--
> NetworkPkg/TcpDxe/TcpInput.c | 8 +--
> NetworkPkg/TcpDxe/TcpMain.c | 4 +-
> NetworkPkg/TcpDxe/TcpMisc.c | 2 +-
> NetworkPkg/TcpDxe/TcpOption.c | 2 +-
> NetworkPkg/TcpDxe/TcpOutput.c | 4 +-
> NetworkPkg/TcpDxe/TcpTimer.c | 2 +-
> NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c |
>6 +--
> NetworkPkg/TlsDxe/TlsDriver.c | 4 +-
> NetworkPkg/Udp4Dxe/Udp4Driver.c | 4 +-
> NetworkPkg/Udp4Dxe/Udp4Impl.c | 12 ++--
>-
> NetworkPkg/Udp4Dxe/Udp4Main.c | 4 +-
> NetworkPkg/Udp6Dxe/Udp6Driver.c | 8 +--
> NetworkPkg/Udp6Dxe/Udp6Impl.c | 18 +++-
>---
> NetworkPkg/Udp6Dxe/Udp6Main.c | 12 ++--
>-
> NetworkPkg/UefiPxeBcDxe/PxeBcBoot.c | 4 +-
> NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c | 10
>++--
> NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c | 18
>+++----
> NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c | 4 +-
> NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c | 10
>++--
> NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c | 12
>++---
> NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c | 8
>+--
> NetworkPkg/VlanConfigDxe/VlanConfigDriver.c | 8
>+--
> OvmfPkg/AcpiPlatformDxe/BootScript.c | 2 +-
> OvmfPkg/AcpiPlatformDxe/Qemu.c | 4 +-
> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c |
>2 +-
> OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c |
>4 +-
> OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c |
>6 +--
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 6
>+--
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c
>| 4 +-
> OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c | 8 +-
>-
> OvmfPkg/Csm/LegacyBiosDxe/Thunk.c | 4 +-
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c
>| 14 +++---
> OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c
>| 18 +++----
> OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c | 4
>+-
> OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 4
>+-
> OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c
>| 2 +-
> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c
>| 2 +-
> OvmfPkg/Library/VirtioLib/VirtioLib.c | 2 +-
> OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c
>| 6 +--
> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbInfo.c
>| 4 +-
> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c
>| 8 +--
> OvmfPkg/QemuVideoDxe/Driver.c | 2 +-
> OvmfPkg/VirtioNetDxe/DriverBinding.c | 2 +-
> OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c | 2
>+-
> OvmfPkg/VirtioRngDxe/VirtioRng.c | 2 +-
> OvmfPkg/VirtioScsiDxe/VirtioScsi.c | 2 +-
> OvmfPkg/XenBusDxe/XenBus.c | 2 +-
> OvmfPkg/XenBusDxe/XenBusDxe.c | 6 +--
> OvmfPkg/XenBusDxe/XenStore.c | 4 +-
> OvmfPkg/XenPvBlkDxe/BlockFront.c | 2 +-
> OvmfPkg/XenPvBlkDxe/BlockIo.c | 8 +--
> OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.c | 2 +-
> PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c |
>2 +-
> PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c | 6
>+--
> SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c |
>2 +-
> SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c
>| 2 +-
> SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c
>| 2 +-
> SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c
>| 2 +-
>
>SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.
>c | 2 +-
>
>SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.
>c | 2 +-
> SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c
>| 2 +-
> SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c
>| 2 +-
> SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c
>| 4 +-
> SecurityPkg/Library/Tpm2CommandLib/Tpm2Miscellaneous.c
>| 2 +-
> SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
>| 4 +-
> SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c |
>6 +--
> SecurityPkg/Library/TpmCommLib/TisPc.c | 2 +-
> SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c
>| 2 +-
> SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.c
>| 2 +-
> SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
>| 10 ++--
> SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c |
>2 +-
> SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c | 8
>+--
> SecurityPkg/Tcg/PhysicalPresencePei/PhysicalPresencePei.c
>| 2 +-
> SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c | 2
>+-
> SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 +-
> SecurityPkg/Tcg/TcgPei/TcgPei.c | 8 +--
>
>SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfig
>FileExplorer.c | 2 +-
>
>SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigI
>mpl.c | 2 +-
> ShellPkg/Application/Shell/ConsoleLogger.c | 12
>++---
> ShellPkg/Application/Shell/ConsoleWrappers.c | 2
>+-
> ShellPkg/Application/Shell/FileHandleWrappers.c | 8
>+--
> ShellPkg/Application/Shell/Shell.c | 8 +--
> ShellPkg/Application/Shell/ShellEnvVar.c | 8 +--
> ShellPkg/Application/Shell/ShellManParser.c | 20
>++++----
> ShellPkg/Application/Shell/ShellParametersProtocol.c |
>26 +++++-----
> ShellPkg/Application/Shell/ShellProtocol.c | 36
>+++++++-------
> ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
>| 4 +-
> ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.c
>| 2 +-
> ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.c
>| 4 +-
> ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c
>| 4 +-
> ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
>| 8 +--
> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.c
>| 2 +-
>
>ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.c
>| 4 +-
> SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c |
>26 +++++-----
> SignedCapsulePkg/Universal/RecoveryModuleLoadPei/ParseConfigProfile.c
>| 2 +-
>
>SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoad
>Pei.c | 14 +++---
> SignedCapsulePkg/Universal/SystemFirmwareUpdate/ParseConfigProfile.c
>| 2 +-
>
>SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCom
>monDxe.c | 4 +-
>
>SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareRepor
>tDxe.c | 8 +--
>
>SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdat
>eDxe.c | 4 +-
> SourceLevelDebugPkg/DebugAgentDxe/DebugAgentDxe.c
>| 2 +-
> SourceLevelDebugPkg/DebugAgentPei/DebugAgentPei.c
>| 2 +-
>
>SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAge
>nt.c | 52 ++++++++++----------
>
>SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/DxeDebugAgen
>tLib.c | 2 +-
> SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c
>| 6 +--
>
>SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebug
>AgentLib.c | 10 ++--
>
>SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebugAg
>entLib.c | 10 ++--
>
>SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCom
>municationLibSerialPort.c | 2 +-
>
>SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
>icationLibUsb3Common.c | 2 +-
>
>SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
>icationLibUsb3Dxe.c | 2 +-
>
>SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommun
>icationLibUsb3Transfer.c | 4 +-
> StandaloneMmPkg/Core/Dependency.c | 2 +-
> StandaloneMmPkg/Core/Dispatcher.c | 2 +-
> StandaloneMmPkg/Core/FwVol.c | 2 +-
> StandaloneMmPkg/Core/StandaloneMmCore.c |
>2 +-
> UefiCpuPkg/CpuDxe/CpuDxe.c | 8 +--
> UefiCpuPkg/CpuDxe/CpuGdt.c | 2 +-
> UefiCpuPkg/CpuDxe/CpuMp.c | 4 +-
> UefiCpuPkg/CpuDxe/CpuPageTable.c | 6 +--
> UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
>| 4 +-
> UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c
>| 2 +-
> UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c
>| 4 +-
> UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c
>| 4 +-
> UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
>| 2 +-
> UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c
>| 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
>| 4 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c
>| 4 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c
>| 6 +--
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c
>| 2 +-
> EmulatorPkg/Sec/Ia32/SwitchRam.S | 18 +++--
>--
> EmulatorPkg/Sec/Ia32/SwitchRam.asm | 20
>++++----
> EmulatorPkg/Sec/X64/SwitchRam.S | 2 +-
> EmulatorPkg/Sec/X64/SwitchRam.asm | 2 +-
> EmulatorPkg/Unix/GdbRun.sh | 4 +-
> EmulatorPkg/Unix/Host/X64/Gasket.S | 4 +-
> EmulatorPkg/Unix/Host/X64/SwitchStack.S | 2 +-
> EmulatorPkg/Unix/lldbefi.py | 14 +++---
>
>IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nas
>m | 6 +--
>
>IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Sec
>Entry.nasm | 2 +-
>
>IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Sta
>ck.nasm | 2 +-
> MdeModulePkg/Application/UiApp/FrontPageStrings.uni
>| 6 +--
> MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.uni
>| 2 +-
> MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.uni
>| 2 +-
> MdePkg/Library/DxePcdLib/DxePcdLib.uni | 2 +-
> NetworkPkg/MnpDxe/MnpDxe.uni | 4 +-
> OvmfPkg/AcpiTables/Facp.aslc | 8 +--
> OvmfPkg/AcpiTables/Facs.aslc | 4 +-
> OvmfPkg/AcpiTables/Madt.aslc | 2 +-
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni
>| 8 +--
> OvmfPkg/QemuVideoDxe/VbeShim.asm | 14
>+++---
> SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.uni |
>4 +-
> SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.uni
>| 2 +-
> SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.uni | 2 +-
> SecurityPkg/Tcg/TcgSmm/TcgSmm.uni | 2 +-
> ShellPkg/Application/ShellCTestApp/README.txt | 2
>+-
>
>SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/AsmF
>uncs.nasm | 4 +-
>
>SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCom
>municationLibSerialPort.uni | 2 +-
> UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm
>| 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm
>| 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm
>| 2 +-
> 587 files changed, 1853 insertions(+), 1854 deletions(-)
>
>--
>2.21.0
>
>
>
^ permalink raw reply [flat|nested] 122+ messages in thread
* Re: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)
2019-12-04 1:27 ` Liming Gao
@ 2019-12-04 9:09 ` Laszlo Ersek
2019-12-04 14:57 ` Maciej Rabeda
0 siblings, 1 reply; 122+ messages in thread
From: Laszlo Ersek @ 2019-12-04 9:09 UTC (permalink / raw)
To: Gao, Liming, Desimone, Nathaniel L, devel@edk2.groups.io,
philmd@redhat.com, Achin Gupta, Andrew Fish, Anthony Perard,
Ard Biesheuvel, Zhang, Chao B, Chiu, Chasel, Dong, Eric,
Wu, Hao A, Wang, Jian J, Wu, Jiaxin, Yao, Jiewen,
Justen, Jordan L, Julien Grall, Leif Lindholm, Rabeda, Maciej,
Kinney, Michael D, Ni, Ray, Fu, Siyuan, Zeng, Star,
Supreeth Venkatesh, Lu, XiaoyuX, Gao, Zhichao
Cc: Antoine C?ur
On 12/04/19 02:27, Gao, Liming wrote:
> You can also mention the fork branch with all changes. Then, the reviewer can see all changes.
That's not good enough: people on the list that do not get a personal CC
of a given patch cannot comment on the patch *through the list*.
Laszlo
> Thanks
> Liming
>> -----Original Message-----
>> From: Desimone, Nathaniel L
>> Sent: Wednesday, December 04, 2019 9:16 AM
>> To: devel@edk2.groups.io; philmd@redhat.com; Achin Gupta
>> <achin.gupta@arm.com>; Andrew Fish <afish@apple.com>; Anthony Perard
>> <anthony.perard@citrix.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>;
>> Zhang, Chao B <chao.b.zhang@intel.com>; Chiu, Chasel
>> <chasel.chiu@intel.com>; Dong, Eric <eric.dong@intel.com>; Wu, Hao A
>> <hao.a.wu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Wu, Jiaxin
>> <jiaxin.wu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Justen, Jordan
>> L <jordan.l.justen@intel.com>; Julien Grall <julien@xen.org>; Laszlo Ersek
>> <lersek@redhat.com>; Leif Lindholm <leif.lindholm@linaro.org>; Gao, Liming
>> <liming.gao@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Kinney,
>> Michael D <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>; Fu,
>> Siyuan <siyuan.fu@intel.com>; Zeng, Star <star.zeng@intel.com>; Supreeth
>> Venkatesh <supreeth.venkatesh@arm.com>; Lu, XiaoyuX
>> <xiaoyux.lu@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
>> Cc: Antoine Cœur <coeur@gmx.fr>
>> Subject: RE: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)
>>
>> Hi Philippe and Antoine,
>>
>> Thank you very much for doing this work!
>>
>> Please note that the mailing list currently has the braindead behavior only
>> allowing a user to send 40 emails in a 30 minute window. I believe this is done
>> to prevent spamming. Because of this, only patches 0-39 were actually
>> received. Myself and Michael recently ran into this same problem with the
>> Advanced Feature Refactor patch series. We worked around it by sending our
>> emails in batches and waiting 30 minutes between each batch.
>>
>> Thanks,
>> Nate
^ permalink raw reply [flat|nested] 122+ messages in thread
* Re: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)
2019-12-04 9:09 ` Laszlo Ersek
@ 2019-12-04 14:57 ` Maciej Rabeda
0 siblings, 0 replies; 122+ messages in thread
From: Maciej Rabeda @ 2019-12-04 14:57 UTC (permalink / raw)
To: devel, lersek, Gao, Liming, Desimone, Nathaniel L,
philmd@redhat.com, Achin Gupta, Andrew Fish, Anthony Perard,
Ard Biesheuvel, Zhang, Chao B, Chiu, Chasel, Dong, Eric,
Wu, Hao A, Wang, Jian J, Wu, Jiaxin, Yao, Jiewen,
Justen, Jordan L, Julien Grall, Leif Lindholm, Rabeda, Maciej,
Kinney, Michael D, Ni, Ray, Fu, Siyuan, Zeng, Star,
Supreeth Venkatesh, Lu, XiaoyuX, Gao, Zhichao
Cc: Antoine C?ur
Philippe, Antoine,
I confirm that I have also received only 0-39 patches of the patchset. I
would like to give you the review stamp for the rest of typo fixes in
NetworkPkg.
Thanks,
Maciej
On 04-Dec-19 10:09, Laszlo Ersek wrote:
> On 12/04/19 02:27, Gao, Liming wrote:
>> You can also mention the fork branch with all changes. Then, the reviewer can see all changes.
> That's not good enough: people on the list that do not get a personal CC
> of a given patch cannot comment on the patch *through the list*.
>
> Laszlo
>
>> Thanks
>> Liming
>>> -----Original Message-----
>>> From: Desimone, Nathaniel L
>>> Sent: Wednesday, December 04, 2019 9:16 AM
>>> To: devel@edk2.groups.io; philmd@redhat.com; Achin Gupta
>>> <achin.gupta@arm.com>; Andrew Fish <afish@apple.com>; Anthony Perard
>>> <anthony.perard@citrix.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>;
>>> Zhang, Chao B <chao.b.zhang@intel.com>; Chiu, Chasel
>>> <chasel.chiu@intel.com>; Dong, Eric <eric.dong@intel.com>; Wu, Hao A
>>> <hao.a.wu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Wu, Jiaxin
>>> <jiaxin.wu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Justen, Jordan
>>> L <jordan.l.justen@intel.com>; Julien Grall <julien@xen.org>; Laszlo Ersek
>>> <lersek@redhat.com>; Leif Lindholm <leif.lindholm@linaro.org>; Gao, Liming
>>> <liming.gao@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Kinney,
>>> Michael D <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>; Fu,
>>> Siyuan <siyuan.fu@intel.com>; Zeng, Star <star.zeng@intel.com>; Supreeth
>>> Venkatesh <supreeth.venkatesh@arm.com>; Lu, XiaoyuX
>>> <xiaoyux.lu@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
>>> Cc: Antoine Cœur <coeur@gmx.fr>
>>> Subject: RE: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)
>>>
>>> Hi Philippe and Antoine,
>>>
>>> Thank you very much for doing this work!
>>>
>>> Please note that the mailing list currently has the braindead behavior only
>>> allowing a user to send 40 emails in a 30 minute window. I believe this is done
>>> to prevent spamming. Because of this, only patches 0-39 were actually
>>> received. Myself and Michael recently ran into this same problem with the
>>> Advanced Feature Refactor patch series. We worked around it by sending our
>>> emails in batches and waiting 30 minutes between each batch.
>>>
>>> Thanks,
>>> Nate
>
>
>
>
^ permalink raw reply [flat|nested] 122+ messages in thread
* Re: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)
2019-12-04 1:16 ` [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1) Nate DeSimone
2019-12-04 1:27 ` Liming Gao
@ 2019-12-04 16:29 ` Philippe Mathieu-Daudé
2019-12-04 16:44 ` Leif Lindholm
1 sibling, 1 reply; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-04 16:29 UTC (permalink / raw)
To: Desimone, Nathaniel L, devel@edk2.groups.io, Achin Gupta,
Andrew Fish, Anthony Perard, Ard Biesheuvel, Zhang, Chao B,
Chiu, Chasel, Dong, Eric, Wu, Hao A, Wang, Jian J, Wu, Jiaxin,
Yao, Jiewen, Justen, Jordan L, Julien Grall, Laszlo Ersek,
Leif Lindholm, Gao, Liming, Rabeda, Maciej, Kinney, Michael D,
Ni, Ray, Fu, Siyuan, Zeng, Star, Supreeth Venkatesh, Lu, XiaoyuX,
Gao, Zhichao
Cc: Antoine Cœur
On 12/4/19 2:16 AM, Desimone, Nathaniel L wrote:
> Hi Philippe and Antoine,
>
> Thank you very much for doing this work!
>
> Please note that the mailing list currently has the braindead behavior only allowing a user to send 40 emails in a 30 minute window. I believe this is done to prevent spamming. Because of this, only patches 0-39 were actually received. Myself and Michael recently ran into this same problem with the Advanced Feature Refactor patch series. We worked around it by sending our emails in batches and waiting 30 minutes between each batch.
Patches 40-79 were indeed discarded, and I couldn't reply to messages or
review other patches for 30min. I'll split this in batches of 30, to
still be able to reply to other threads in the list during the next
30min of my post. Very counter-productive :S
> Thanks,
> Nate
^ permalink raw reply [flat|nested] 122+ messages in thread
* Re: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)
2019-12-04 16:29 ` Philippe Mathieu-Daudé
@ 2019-12-04 16:44 ` Leif Lindholm
2019-12-04 22:15 ` Laszlo Ersek
0 siblings, 1 reply; 122+ messages in thread
From: Leif Lindholm @ 2019-12-04 16:44 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Desimone, Nathaniel L, devel@edk2.groups.io, Achin Gupta,
Andrew Fish, Anthony Perard, Ard Biesheuvel, Zhang, Chao B,
Chiu, Chasel, Dong, Eric, Wu, Hao A, Wang, Jian J, Wu, Jiaxin,
Yao, Jiewen, Justen, Jordan L, Julien Grall, Laszlo Ersek,
Gao, Liming, Rabeda, Maciej, Kinney, Michael D, Ni, Ray,
Fu, Siyuan, Zeng, Star, Supreeth Venkatesh, Lu, XiaoyuX,
Gao, Zhichao, Antoine Cœur
On Wed, Dec 04, 2019 at 17:29:02 +0100, Philippe Mathieu-Daudé wrote:
> On 12/4/19 2:16 AM, Desimone, Nathaniel L wrote:
> > Hi Philippe and Antoine,
> >
> > Thank you very much for doing this work!
> >
> > Please note that the mailing list currently has the braindead
> > behavior only allowing a user to send 40 emails in a 30 minute
> > window. I believe this is done to prevent spamming. Because of
> > this, only patches 0-39 were actually received. Myself and Michael
> > recently ran into this same problem with the Advanced Feature
> > Refactor patch series. We worked around it by sending our emails
> > in batches and waiting 30 minutes between each batch.
>
> Patches 40-79 were indeed discarded, and I couldn't reply to messages or
> review other patches for 30min. I'll split this in batches of 30, to still
> be able to reply to other threads in the list during the next 30min of my
> post. Very counter-productive :S
No need to resend 0-39, so you could just send the remaining as two
batches of 20.
/
Leif
^ permalink raw reply [flat|nested] 122+ messages in thread* Re: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)
2019-12-04 16:44 ` Leif Lindholm
@ 2019-12-04 22:15 ` Laszlo Ersek
2019-12-04 22:18 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 122+ messages in thread
From: Laszlo Ersek @ 2019-12-04 22:15 UTC (permalink / raw)
To: devel, leif.lindholm, Philippe Mathieu-Daudé
Cc: Desimone, Nathaniel L, Achin Gupta, Andrew Fish, Anthony Perard,
Ard Biesheuvel, Zhang, Chao B, Chiu, Chasel, Dong, Eric,
Wu, Hao A, Wang, Jian J, Wu, Jiaxin, Yao, Jiewen,
Justen, Jordan L, Julien Grall, Gao, Liming, Rabeda, Maciej,
Kinney, Michael D, Ni, Ray, Fu, Siyuan, Zeng, Star,
Supreeth Venkatesh, Lu, XiaoyuX, Gao, Zhichao, Antoine Cœur
On 12/04/19 17:44, Leif Lindholm wrote:
> On Wed, Dec 04, 2019 at 17:29:02 +0100, Philippe Mathieu-Daudé wrote:
>> On 12/4/19 2:16 AM, Desimone, Nathaniel L wrote:
>>> Hi Philippe and Antoine,
>>>
>>> Thank you very much for doing this work!
>>>
>>> Please note that the mailing list currently has the braindead
>>> behavior only allowing a user to send 40 emails in a 30 minute
>>> window. I believe this is done to prevent spamming. Because of
>>> this, only patches 0-39 were actually received. Myself and Michael
>>> recently ran into this same problem with the Advanced Feature
>>> Refactor patch series. We worked around it by sending our emails
>>> in batches and waiting 30 minutes between each batch.
>>
>> Patches 40-79 were indeed discarded, and I couldn't reply to messages or
>> review other patches for 30min. I'll split this in batches of 30, to still
>> be able to reply to other threads in the list during the next 30min of my
>> post. Very counter-productive :S
>
> No need to resend 0-39, so you could just send the remaining as two
> batches of 20.
Another approach could be the "--batch-size" and "--relogin-delay"
options of git-send-email.
Thanks,
Laszlo
^ permalink raw reply [flat|nested] 122+ messages in thread
* Re: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)
2019-12-04 22:15 ` Laszlo Ersek
@ 2019-12-04 22:18 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-04 22:18 UTC (permalink / raw)
To: Laszlo Ersek
Cc: edk2-devel-groups-io, Leif Lindholm, Desimone, Nathaniel L,
Achin Gupta, Andrew Fish, Anthony Perard, Ard Biesheuvel,
Zhang, Chao B, Chiu, Chasel, Dong, Eric, Wu, Hao A, Wang, Jian J,
Wu, Jiaxin, Yao, Jiewen, Justen, Jordan L, Julien Grall,
Gao, Liming, Rabeda, Maciej, Kinney, Michael D, Ni, Ray,
Fu, Siyuan, Zeng, Star, Supreeth Venkatesh, Lu, XiaoyuX,
Gao, Zhichao, Antoine Cœur
On Wed, Dec 4, 2019 at 11:15 PM Laszlo Ersek <lersek@redhat.com> wrote:
> On 12/04/19 17:44, Leif Lindholm wrote:
> > On Wed, Dec 04, 2019 at 17:29:02 +0100, Philippe Mathieu-Daudé wrote:
> >> On 12/4/19 2:16 AM, Desimone, Nathaniel L wrote:
> >>> Hi Philippe and Antoine,
> >>>
> >>> Thank you very much for doing this work!
> >>>
> >>> Please note that the mailing list currently has the braindead
> >>> behavior only allowing a user to send 40 emails in a 30 minute
> >>> window. I believe this is done to prevent spamming. Because of
> >>> this, only patches 0-39 were actually received. Myself and Michael
> >>> recently ran into this same problem with the Advanced Feature
> >>> Refactor patch series. We worked around it by sending our emails
> >>> in batches and waiting 30 minutes between each batch.
> >>
> >> Patches 40-79 were indeed discarded, and I couldn't reply to messages or
> >> review other patches for 30min. I'll split this in batches of 30, to still
> >> be able to reply to other threads in the list during the next 30min of my
> >> post. Very counter-productive :S
> >
> > No need to resend 0-39, so you could just send the remaining as two
> > batches of 20.
>
> Another approach could be the "--batch-size" and "--relogin-delay"
> options of git-send-email.
Excellent tip, I'll try it and share eventual tuned git-config options
to the list.
Thanks,
Phil.
^ permalink raw reply [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-78-philmd@redhat.com>]
* Re: [PATCH 77/79] UefiCpuPkg/CpuDxe: Fix few typos
[not found] ` <20191203161602.15969-78-philmd@redhat.com>
@ 2019-12-03 21:03 ` Laszlo Ersek
2019-12-06 7:24 ` Dong, Eric
1 sibling, 0 replies; 122+ messages in thread
From: Laszlo Ersek @ 2019-12-03 21:03 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel; +Cc: Antoine Coeur, Eric Dong, Ray Ni
On 12/03/19 17:16, Philippe Mathieu-Daude wrote:
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix few typos in comments and documentation.
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> UefiCpuPkg/CpuDxe/CpuDxe.h | 2 +-
> UefiCpuPkg/CpuDxe/CpuGdt.h | 2 +-
> UefiCpuPkg/CpuDxe/CpuMp.h | 4 ++--
> UefiCpuPkg/CpuDxe/CpuPageTable.h | 2 +-
> UefiCpuPkg/CpuDxe/CpuDxe.c | 8 ++++----
> UefiCpuPkg/CpuDxe/CpuGdt.c | 2 +-
> UefiCpuPkg/CpuDxe/CpuMp.c | 4 ++--
> UefiCpuPkg/CpuDxe/CpuPageTable.c | 6 +++---
> 8 files changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.h b/UefiCpuPkg/CpuDxe/CpuDxe.h
> index a6762f1a0b78..9299eaa63d8a 100644
> --- a/UefiCpuPkg/CpuDxe/CpuDxe.h
> +++ b/UefiCpuPkg/CpuDxe/CpuDxe.h
> @@ -208,7 +208,7 @@ CpuGetTimerValue (
> );
>
> /**
> - Set memory cacheability attributes for given range of memeory.
> + Set memory cacheability attributes for given range of memory.
>
> @param This Protocol instance structure
> @param BaseAddress Specifies the start address of the
> diff --git a/UefiCpuPkg/CpuDxe/CpuGdt.h b/UefiCpuPkg/CpuDxe/CpuGdt.h
> index e5c36f37b96a..3a0210b2f172 100644
> --- a/UefiCpuPkg/CpuDxe/CpuGdt.h
> +++ b/UefiCpuPkg/CpuDxe/CpuGdt.h
> @@ -1,5 +1,5 @@
> /** @file
> - C based implemention of IA32 interrupt handling only
> + C based implementation of IA32 interrupt handling only
> requiring a minimal assembly interrupt entry point.
>
> Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR>
> diff --git a/UefiCpuPkg/CpuDxe/CpuMp.h b/UefiCpuPkg/CpuDxe/CpuMp.h
> index e7e115fc8f3d..4ee171d8c491 100644
> --- a/UefiCpuPkg/CpuDxe/CpuMp.h
> +++ b/UefiCpuPkg/CpuDxe/CpuMp.h
> @@ -147,7 +147,7 @@ GetProcessorInfo (
> and releases the BSP to continue with other tasks.
> -# The caller can use the CheckEvent() and WaitForEvent() services to check
> the state of the WaitEvent created in step 1.
> - -# When the APs complete their task or TimeoutInMicroSecondss expires, the MP
> + -# When the APs complete their task or TimeoutInMicroSeconds expires, the MP
> Service signals WaitEvent by calling the EFI SignalEvent() function. If
> FailedCpuList is not NULL, its content is available when WaitEvent is
> signaled. If all APs returned from Procedure prior to the timeout, then
> @@ -254,7 +254,7 @@ StartupAllAPs (
> This function is used to dispatch one enabled AP to the function specified by
> Procedure passing in the argument specified by ProcedureArgument. If WaitEvent
> is NULL, execution is in blocking mode. The BSP waits until the AP finishes or
> - TimeoutInMicroSecondss expires. Otherwise, execution is in non-blocking mode.
> + TimeoutInMicroSeconds expires. Otherwise, execution is in non-blocking mode.
> BSP proceeds to the next task without waiting for the AP. If a non-blocking mode
> is requested after the UEFI Event EFI_EVENT_GROUP_READY_TO_BOOT is signaled,
> then EFI_UNSUPPORTED must be returned.
> diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.h b/UefiCpuPkg/CpuDxe/CpuPageTable.h
> index bad6784bcb51..0b2a02a2be5c 100644
> --- a/UefiCpuPkg/CpuDxe/CpuPageTable.h
> +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.h
> @@ -78,7 +78,7 @@ VOID *
>
> Caller should make sure BaseAddress and Length is at page boundary.
>
> - Caller need guarentee the TPL <= TPL_NOTIFY, if there is split page request.
> + Caller need guarantee the TPL <= TPL_NOTIFY, if there is split page request.
>
> @param PagingContext The paging context. NULL means get page table from current CPU context.
> @param BaseAddress The physical address that is the start address of a memory region.
> diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.c b/UefiCpuPkg/CpuDxe/CpuDxe.c
> index 7d7270e10b4a..a571fc3b1750 100644
> --- a/UefiCpuPkg/CpuDxe/CpuDxe.c
> +++ b/UefiCpuPkg/CpuDxe/CpuDxe.c
> @@ -393,7 +393,7 @@ CpuSetMemoryAttributes (
>
> //
> // If this function is called because GCD SetMemorySpaceAttributes () is called
> - // by RefreshGcdMemoryAttributes (), then we are just synchronzing GCD memory
> + // by RefreshGcdMemoryAttributes (), then we are just synchronizing GCD memory
> // map with MTRR values. So there is no need to modify MTRRs, just return immediately
> // to avoid unnecessary computing.
> //
> @@ -456,7 +456,7 @@ CpuSetMemoryAttributes (
> CurrentCacheType = MtrrGetMemoryAttribute(BaseAddress);
> if (CurrentCacheType != CacheType) {
> //
> - // call MTRR libary function
> + // call MTRR library function
> //
> Status = MtrrSetMemoryAttribute (
> BaseAddress,
> @@ -831,7 +831,7 @@ RefreshMemoryAttributesFromMtrr (
> Attributes = CurrentAttributes;
> } else {
> //
> - // If fixed MTRR attribute changed, then set memory attribute for previous atrribute
> + // If fixed MTRR attribute changed, then set memory attribute for previous attribute
> //
> if (CurrentAttributes != Attributes) {
> SetGcdMemorySpaceAttributes (
> @@ -1045,7 +1045,7 @@ IntersectMemoryDescriptor (
> @param Length Length of the MMIO space.
> @param Capabilities Capabilities of the MMIO space.
>
> - @retval EFI_SUCCES The MMIO space was added successfully.
> + @retval EFI_SUCCESS The MMIO space was added successfully.
> **/
> EFI_STATUS
> AddMemoryMappedIoSpace (
> diff --git a/UefiCpuPkg/CpuDxe/CpuGdt.c b/UefiCpuPkg/CpuDxe/CpuGdt.c
> index 87fd6955f24b..64efadeba601 100644
> --- a/UefiCpuPkg/CpuDxe/CpuGdt.c
> +++ b/UefiCpuPkg/CpuDxe/CpuGdt.c
> @@ -1,5 +1,5 @@
> /** @file
> - C based implemention of IA32 interrupt handling only
> + C based implementation of IA32 interrupt handling only
> requiring a minimal assembly interrupt entry point.
>
> Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR>
> diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/CpuMp.c
> index de6c6a5c330c..60ede38df4fc 100644
> --- a/UefiCpuPkg/CpuDxe/CpuMp.c
> +++ b/UefiCpuPkg/CpuDxe/CpuMp.c
> @@ -164,7 +164,7 @@ GetProcessorInfo (
> and releases the BSP to continue with other tasks.
> -# The caller can use the CheckEvent() and WaitForEvent() services to check
> the state of the WaitEvent created in step 1.
> - -# When the APs complete their task or TimeoutInMicroSecondss expires, the MP
> + -# When the APs complete their task or TimeoutInMicroSeconds expires, the MP
> Service signals WaitEvent by calling the EFI SignalEvent() function. If
> FailedCpuList is not NULL, its content is available when WaitEvent is
> signaled. If all APs returned from Procedure prior to the timeout, then
> @@ -281,7 +281,7 @@ StartupAllAPs (
> This function is used to dispatch one enabled AP to the function specified by
> Procedure passing in the argument specified by ProcedureArgument. If WaitEvent
> is NULL, execution is in blocking mode. The BSP waits until the AP finishes or
> - TimeoutInMicroSecondss expires. Otherwise, execution is in non-blocking mode.
> + TimeoutInMicroSeconds expires. Otherwise, execution is in non-blocking mode.
> BSP proceeds to the next task without waiting for the AP. If a non-blocking mode
> is requested after the UEFI Event EFI_EVENT_GROUP_READY_TO_BOOT is signaled,
> then EFI_UNSUPPORTED must be returned.
> diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.c b/UefiCpuPkg/CpuDxe/CpuPageTable.c
> index cb121771425a..0a02cb3f6b7e 100644
> --- a/UefiCpuPkg/CpuDxe/CpuPageTable.c
> +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.c
> @@ -776,7 +776,7 @@ ConvertMemoryPageAttributes (
> }
>
> //
> - // Below logic is to check 2M/4K page to make sure we donot waist memory.
> + // Below logic is to check 2M/4K page to make sure we do not waste memory.
> //
> Status = EFI_SUCCESS;
> while (Length != 0) {
> @@ -838,7 +838,7 @@ Done:
>
> Caller should make sure BaseAddress and Length is at page boundary.
>
> - Caller need guarentee the TPL <= TPL_NOTIFY, if there is split page request.
> + Caller need guarantee the TPL <= TPL_NOTIFY, if there is split page request.
>
> @param[in] PagingContext The paging context. NULL means get page table from current CPU context.
> @param[in] BaseAddress The physical address that is the start address of a memory region.
> @@ -969,7 +969,7 @@ RefreshGcdMemoryAttributesFromPaging (
> );
> if (EFI_ERROR (Status)) {
> //
> - // If we cannot udpate the capabilities, we cannot update its
> + // If we cannot update the capabilities, we cannot update its
> // attributes either. So just simply skip current block of memory.
> //
> DEBUG ((
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 122+ messages in thread* Re: [PATCH 77/79] UefiCpuPkg/CpuDxe: Fix few typos
[not found] ` <20191203161602.15969-78-philmd@redhat.com>
2019-12-03 21:03 ` [PATCH 77/79] UefiCpuPkg/CpuDxe: Fix few typos Laszlo Ersek
@ 2019-12-06 7:24 ` Dong, Eric
1 sibling, 0 replies; 122+ messages in thread
From: Dong, Eric @ 2019-12-06 7:24 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Ni, Ray, Laszlo Ersek
Reviewed-by: Eric Dong <eric.dong@intel.com>
> -----Original Message-----
> From: Philippe Mathieu-Daude [mailto:philmd@redhat.com]
> Sent: Wednesday, December 4, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Dong, Eric <eric.dong@intel.com>; Ni,
> Ray <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com>; Philippe
> Mathieu-Daude <philmd@redhat.com>
> Subject: [PATCH 77/79] UefiCpuPkg/CpuDxe: Fix few typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix few typos in comments and documentation.
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> UefiCpuPkg/CpuDxe/CpuDxe.h | 2 +-
> UefiCpuPkg/CpuDxe/CpuGdt.h | 2 +-
> UefiCpuPkg/CpuDxe/CpuMp.h | 4 ++--
> UefiCpuPkg/CpuDxe/CpuPageTable.h | 2 +-
> UefiCpuPkg/CpuDxe/CpuDxe.c | 8 ++++----
> UefiCpuPkg/CpuDxe/CpuGdt.c | 2 +-
> UefiCpuPkg/CpuDxe/CpuMp.c | 4 ++--
> UefiCpuPkg/CpuDxe/CpuPageTable.c | 6 +++---
> 8 files changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.h b/UefiCpuPkg/CpuDxe/CpuDxe.h
> index a6762f1a0b78..9299eaa63d8a 100644
> --- a/UefiCpuPkg/CpuDxe/CpuDxe.h
> +++ b/UefiCpuPkg/CpuDxe/CpuDxe.h
> @@ -208,7 +208,7 @@ CpuGetTimerValue (
> );
>
> /**
> - Set memory cacheability attributes for given range of memeory.
> + Set memory cacheability attributes for given range of memory.
>
> @param This Protocol instance structure
> @param BaseAddress Specifies the start address of the
> diff --git a/UefiCpuPkg/CpuDxe/CpuGdt.h b/UefiCpuPkg/CpuDxe/CpuGdt.h
> index e5c36f37b96a..3a0210b2f172 100644
> --- a/UefiCpuPkg/CpuDxe/CpuGdt.h
> +++ b/UefiCpuPkg/CpuDxe/CpuGdt.h
> @@ -1,5 +1,5 @@
> /** @file
> - C based implemention of IA32 interrupt handling only
> + C based implementation of IA32 interrupt handling only
> requiring a minimal assembly interrupt entry point.
>
> Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR> diff --
> git a/UefiCpuPkg/CpuDxe/CpuMp.h b/UefiCpuPkg/CpuDxe/CpuMp.h index
> e7e115fc8f3d..4ee171d8c491 100644
> --- a/UefiCpuPkg/CpuDxe/CpuMp.h
> +++ b/UefiCpuPkg/CpuDxe/CpuMp.h
> @@ -147,7 +147,7 @@ GetProcessorInfo (
> and releases the BSP to continue with other tasks.
> -# The caller can use the CheckEvent() and WaitForEvent() services to
> check
> the state of the WaitEvent created in step 1.
> - -# When the APs complete their task or TimeoutInMicroSecondss expires,
> the MP
> + -# When the APs complete their task or TimeoutInMicroSeconds
> + expires, the MP
> Service signals WaitEvent by calling the EFI SignalEvent() function. If
> FailedCpuList is not NULL, its content is available when WaitEvent is
> signaled. If all APs returned from Procedure prior to the timeout, then
> @@ -254,7 +254,7 @@ StartupAllAPs (
> This function is used to dispatch one enabled AP to the function specified
> by
> Procedure passing in the argument specified by ProcedureArgument. If
> WaitEvent
> is NULL, execution is in blocking mode. The BSP waits until the AP finishes or
> - TimeoutInMicroSecondss expires. Otherwise, execution is in non-blocking
> mode.
> + TimeoutInMicroSeconds expires. Otherwise, execution is in non-blocking
> mode.
> BSP proceeds to the next task without waiting for the AP. If a non-blocking
> mode
> is requested after the UEFI Event EFI_EVENT_GROUP_READY_TO_BOOT is
> signaled,
> then EFI_UNSUPPORTED must be returned.
> diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.h
> b/UefiCpuPkg/CpuDxe/CpuPageTable.h
> index bad6784bcb51..0b2a02a2be5c 100644
> --- a/UefiCpuPkg/CpuDxe/CpuPageTable.h
> +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.h
> @@ -78,7 +78,7 @@ VOID *
>
> Caller should make sure BaseAddress and Length is at page boundary.
>
> - Caller need guarentee the TPL <= TPL_NOTIFY, if there is split page request.
> + Caller need guarantee the TPL <= TPL_NOTIFY, if there is split page request.
>
> @param PagingContext The paging context. NULL means get page table
> from current CPU context.
> @param BaseAddress The physical address that is the start address of a
> memory region.
> diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.c b/UefiCpuPkg/CpuDxe/CpuDxe.c
> index 7d7270e10b4a..a571fc3b1750 100644
> --- a/UefiCpuPkg/CpuDxe/CpuDxe.c
> +++ b/UefiCpuPkg/CpuDxe/CpuDxe.c
> @@ -393,7 +393,7 @@ CpuSetMemoryAttributes (
>
> //
> // If this function is called because GCD SetMemorySpaceAttributes () is
> called
> - // by RefreshGcdMemoryAttributes (), then we are just synchronzing GCD
> memory
> + // by RefreshGcdMemoryAttributes (), then we are just synchronizing
> + GCD memory
> // map with MTRR values. So there is no need to modify MTRRs, just return
> immediately
> // to avoid unnecessary computing.
> //
> @@ -456,7 +456,7 @@ CpuSetMemoryAttributes (
> CurrentCacheType = MtrrGetMemoryAttribute(BaseAddress);
> if (CurrentCacheType != CacheType) {
> //
> - // call MTRR libary function
> + // call MTRR library function
> //
> Status = MtrrSetMemoryAttribute (
> BaseAddress,
> @@ -831,7 +831,7 @@ RefreshMemoryAttributesFromMtrr (
> Attributes = CurrentAttributes;
> } else {
> //
> - // If fixed MTRR attribute changed, then set memory attribute for
> previous atrribute
> + // If fixed MTRR attribute changed, then set memory attribute
> + for previous attribute
> //
> if (CurrentAttributes != Attributes) {
> SetGcdMemorySpaceAttributes ( @@ -1045,7 +1045,7 @@
> IntersectMemoryDescriptor (
> @param Length Length of the MMIO space.
> @param Capabilities Capabilities of the MMIO space.
>
> - @retval EFI_SUCCES The MMIO space was added successfully.
> + @retval EFI_SUCCESS The MMIO space was added successfully.
> **/
> EFI_STATUS
> AddMemoryMappedIoSpace (
> diff --git a/UefiCpuPkg/CpuDxe/CpuGdt.c b/UefiCpuPkg/CpuDxe/CpuGdt.c
> index 87fd6955f24b..64efadeba601 100644
> --- a/UefiCpuPkg/CpuDxe/CpuGdt.c
> +++ b/UefiCpuPkg/CpuDxe/CpuGdt.c
> @@ -1,5 +1,5 @@
> /** @file
> - C based implemention of IA32 interrupt handling only
> + C based implementation of IA32 interrupt handling only
> requiring a minimal assembly interrupt entry point.
>
> Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR> diff --
> git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/CpuMp.c index
> de6c6a5c330c..60ede38df4fc 100644
> --- a/UefiCpuPkg/CpuDxe/CpuMp.c
> +++ b/UefiCpuPkg/CpuDxe/CpuMp.c
> @@ -164,7 +164,7 @@ GetProcessorInfo (
> and releases the BSP to continue with other tasks.
> -# The caller can use the CheckEvent() and WaitForEvent() services to
> check
> the state of the WaitEvent created in step 1.
> - -# When the APs complete their task or TimeoutInMicroSecondss expires,
> the MP
> + -# When the APs complete their task or TimeoutInMicroSeconds
> + expires, the MP
> Service signals WaitEvent by calling the EFI SignalEvent() function. If
> FailedCpuList is not NULL, its content is available when WaitEvent is
> signaled. If all APs returned from Procedure prior to the timeout, then
> @@ -281,7 +281,7 @@ StartupAllAPs (
> This function is used to dispatch one enabled AP to the function specified
> by
> Procedure passing in the argument specified by ProcedureArgument. If
> WaitEvent
> is NULL, execution is in blocking mode. The BSP waits until the AP finishes or
> - TimeoutInMicroSecondss expires. Otherwise, execution is in non-blocking
> mode.
> + TimeoutInMicroSeconds expires. Otherwise, execution is in non-blocking
> mode.
> BSP proceeds to the next task without waiting for the AP. If a non-blocking
> mode
> is requested after the UEFI Event EFI_EVENT_GROUP_READY_TO_BOOT is
> signaled,
> then EFI_UNSUPPORTED must be returned.
> diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.c
> b/UefiCpuPkg/CpuDxe/CpuPageTable.c
> index cb121771425a..0a02cb3f6b7e 100644
> --- a/UefiCpuPkg/CpuDxe/CpuPageTable.c
> +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.c
> @@ -776,7 +776,7 @@ ConvertMemoryPageAttributes (
> }
>
> //
> - // Below logic is to check 2M/4K page to make sure we donot waist
> memory.
> + // Below logic is to check 2M/4K page to make sure we do not waste
> memory.
> //
> Status = EFI_SUCCESS;
> while (Length != 0) {
> @@ -838,7 +838,7 @@ Done:
>
> Caller should make sure BaseAddress and Length is at page boundary.
>
> - Caller need guarentee the TPL <= TPL_NOTIFY, if there is split page request.
> + Caller need guarantee the TPL <= TPL_NOTIFY, if there is split page request.
>
> @param[in] PagingContext The paging context. NULL means get page
> table from current CPU context.
> @param[in] BaseAddress The physical address that is the start address
> of a memory region.
> @@ -969,7 +969,7 @@ RefreshGcdMemoryAttributesFromPaging (
> );
> if (EFI_ERROR (Status)) {
> //
> - // If we cannot udpate the capabilities, we cannot update its
> + // If we cannot update the capabilities, we cannot update its
> // attributes either. So just simply skip current block of memory.
> //
> DEBUG ((
> --
> 2.21.0
^ permalink raw reply [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-79-philmd@redhat.com>]
* Re: [PATCH 78/79] UefiCpuPkg/PiSmm: Fix various typos
[not found] ` <20191203161602.15969-79-philmd@redhat.com>
@ 2019-12-03 21:04 ` Laszlo Ersek
2019-12-06 7:24 ` Dong, Eric
1 sibling, 0 replies; 122+ messages in thread
From: Laszlo Ersek @ 2019-12-03 21:04 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel; +Cc: Antoine Coeur, Eric Dong, Ray Ni
On 12/03/19 17:16, Philippe Mathieu-Daude wrote:
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 12 ++++++------
> UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c | 2 +-
> UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 4 ++--
> UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 4 ++--
> UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 6 +++---
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm | 2 +-
> 9 files changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> index daf977f654b4..7f5a0b2b267a 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> @@ -272,7 +272,7 @@ extern UINT8 mSmmSaveStateRegisterLma;
>
> @retval EFI_SUCCESS The register was read from Save State
> @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor
> - @retval EFI_INVALID_PARAMTER This or Buffer is NULL.
> + @retval EFI_INVALID_PARAMETER This or Buffer is NULL.
>
> **/
> EFI_STATUS
> @@ -296,7 +296,7 @@ SmmReadSaveState (
>
> @retval EFI_SUCCESS The register was written from Save State
> @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor
> - @retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct
> + @retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct
>
> **/
> EFI_STATUS
> @@ -324,7 +324,7 @@ This function supports reading a CPU Save State register in SMBase relocation ha
>
> @retval EFI_SUCCESS The register was read from Save State.
> @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor.
> -@retval EFI_INVALID_PARAMTER This or Buffer is NULL.
> +@retval EFI_INVALID_PARAMETER This or Buffer is NULL.
>
> **/
> EFI_STATUS
> @@ -351,7 +351,7 @@ This function supports writing a CPU Save State register in SMBase relocation ha
>
> @retval EFI_SUCCESS The register was written to Save State.
> @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor.
> -@retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct.
> +@retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct.
>
> **/
> EFI_STATUS
> @@ -1251,7 +1251,7 @@ EdkiiSmmGetMemoryAttributes (
>
> /**
> This function fixes up the address of the global variable or function
> - referred in SmmInit assembly files to be the absoute address.
> + referred in SmmInit assembly files to be the absolute address.
> **/
> VOID
> EFIAPI
> @@ -1260,7 +1260,7 @@ PiSmmCpuSmmInitFixupAddress (
>
> /**
> This function fixes up the address of the global variable or function
> - referred in SmiEntry assembly files to be the absoute address.
> + referred in SmiEntry assembly files to be the absolute address.
> **/
> VOID
> EFIAPI
> diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
> index 5d09130e5591..68e5003ad4c2 100644
> --- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
> +++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
> @@ -366,7 +366,7 @@ Communicate (
> @param FileHandle Handle of the file being invoked.
> @param PeiServices Pointer to PEI Services table.
>
> - @retval EFI_SUCEESS
> + @retval EFI_SUCCESS
> @return Others Some error occurs.
> **/
> EFI_STATUS
> diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c
> index 6be12d6c14cd..30f7d57bdd91 100644
> --- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c
> +++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c
> @@ -155,7 +155,7 @@ AllocateAcpiNvsMemoryBelow4G (
> @param[in] ImageHandle Image handle of this driver.
> @param[in] SystemTable A Pointer to the EFI System Table.
>
> - @retval EFI_SUCEESS
> + @retval EFI_SUCCESS
> @return Others Some error occurs.
> **/
> EFI_STATUS
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
> index 723fd5042ff4..db68e1316ec5 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
> @@ -215,7 +215,7 @@ DumpModuleInfoByIp (
>
> @retval EFI_SUCCESS The register was read from Save State
> @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor
> - @retval EFI_INVALID_PARAMTER This or Buffer is NULL.
> + @retval EFI_INVALID_PARAMETER This or Buffer is NULL.
>
> **/
> EFI_STATUS
> @@ -287,7 +287,7 @@ SmmReadSaveState (
>
> @retval EFI_SUCCESS The register was written from Save State
> @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor
> - @retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct
> + @retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct
>
> **/
> EFI_STATUS
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c
> index 55090e9c3e4f..9c5a92af6479 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c
> @@ -465,7 +465,7 @@ ConvertMemoryPageAttributes (
> }
>
> //
> - // Below logic is to check 2M/4K page to make sure we donot waist memory.
> + // Below logic is to check 2M/4K page to make sure we do not waste memory.
> //
> while (Length != 0) {
> PageEntry = GetPageTableEntry (BaseAddress, &PageAttribute);
> @@ -1065,7 +1065,7 @@ IsUefiPageNotPresent (
> }
>
> /**
> - Merge continous memory map entries whose type is
> + Merge continuous memory map entries whose type is
> EfiLoaderCode/Data, EfiBootServicesCode/Data, EfiConventionalMemory,
> EfiUnusableMemory, EfiACPIReclaimMemory, because the memory described by
> these entries will be set as NOT present in SMM page table.
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c b/UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c
> index b1a492725a0c..661cc51f361a 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c
> @@ -260,7 +260,7 @@ GetRegisterIndex (
>
> @retval EFI_SUCCESS The register was read from Save State.
> @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor.
> - @retval EFI_INVALID_PARAMTER This or Buffer is NULL.
> + @retval EFI_INVALID_PARAMETER This or Buffer is NULL.
>
> **/
> EFI_STATUS
> @@ -343,7 +343,7 @@ ReadSaveStateRegisterByIndex (
>
> @retval EFI_SUCCESS The register was read from Save State.
> @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor.
> - @retval EFI_INVALID_PARAMTER This or Buffer is NULL.
> + @retval EFI_INVALID_PARAMETER This or Buffer is NULL.
>
> **/
> EFI_STATUS
> @@ -455,7 +455,7 @@ ReadSaveStateRegister (
>
> @retval EFI_SUCCESS The register was written to Save State.
> @retval EFI_NOT_FOUND The register is not defined for the Save State of Processor.
> - @retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct.
> + @retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct.
>
> **/
> EFI_STATUS
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c
> index ce1bf9fb541c..8c9de1fdae70 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c
> @@ -58,7 +58,7 @@ SemaphoreHook (
> );
>
> //
> - // Use temp value to fix ICC complier warning
> + // Use temp value to fix ICC compiler warning
> //
> TempValue = (UINTN)&mSmmRelocationOriginalAddress;
> PatchInstructionX86 (
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm
> index db06d22d51f4..8bfba55b5d08 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm
> @@ -16,7 +16,7 @@
> %include "Nasm.inc"
>
> ;
> -; Variables referrenced by C code
> +; Variables referenced by C code
> ;
>
> %define MSR_IA32_S_CET 0x6A2
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm
> index 8d81582bb1dd..9cf3a6dcf9d5 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm
> @@ -72,7 +72,7 @@ BITS 64
> ASM_PFX(gPatchSmmInitStack):
> and sp, 0xfff0 ; make sure RSP is 16-byte aligned
> ;
> - ; Accoring to X64 calling convention, XMM0~5 are volatile, we need to save
> + ; According to X64 calling convention, XMM0~5 are volatile, we need to save
> ; them before calling C-function.
> ;
> sub rsp, 0x60
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 122+ messages in thread* Re: [PATCH 78/79] UefiCpuPkg/PiSmm: Fix various typos
[not found] ` <20191203161602.15969-79-philmd@redhat.com>
2019-12-03 21:04 ` [PATCH 78/79] UefiCpuPkg/PiSmm: Fix various typos Laszlo Ersek
@ 2019-12-06 7:24 ` Dong, Eric
1 sibling, 0 replies; 122+ messages in thread
From: Dong, Eric @ 2019-12-06 7:24 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Ni, Ray, Laszlo Ersek
Reviewed-by: Eric Dong <eric.dong@intel.com>
> -----Original Message-----
> From: Philippe Mathieu-Daude [mailto:philmd@redhat.com]
> Sent: Wednesday, December 4, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Dong, Eric <eric.dong@intel.com>; Ni,
> Ray <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com>; Philippe
> Mathieu-Daude <philmd@redhat.com>
> Subject: [PATCH 78/79] UefiCpuPkg/PiSmm: Fix various typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 12 ++++++---
> ---
> UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c | 2 +-
> UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 4 ++--
> UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 4 ++--
> UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 6 +++---
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm | 2 +-
> 9 files changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> index daf977f654b4..7f5a0b2b267a 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h
> @@ -272,7 +272,7 @@ extern UINT8 mSmmSaveStateRegisterLma;
>
> @retval EFI_SUCCESS The register was read from Save State
> @retval EFI_NOT_FOUND The register is not defined for the Save State of
> Processor
> - @retval EFI_INVALID_PARAMTER This or Buffer is NULL.
> + @retval EFI_INVALID_PARAMETER This or Buffer is NULL.
>
> **/
> EFI_STATUS
> @@ -296,7 +296,7 @@ SmmReadSaveState (
>
> @retval EFI_SUCCESS The register was written from Save State
> @retval EFI_NOT_FOUND The register is not defined for the Save State of
> Processor
> - @retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct
> + @retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct
>
> **/
> EFI_STATUS
> @@ -324,7 +324,7 @@ This function supports reading a CPU Save State
> register in SMBase relocation ha
>
> @retval EFI_SUCCESS The register was read from Save State.
> @retval EFI_NOT_FOUND The register is not defined for the Save State
> of Processor.
> -@retval EFI_INVALID_PARAMTER This or Buffer is NULL.
> +@retval EFI_INVALID_PARAMETER This or Buffer is NULL.
>
> **/
> EFI_STATUS
> @@ -351,7 +351,7 @@ This function supports writing a CPU Save State
> register in SMBase relocation ha
>
> @retval EFI_SUCCESS The register was written to Save State.
> @retval EFI_NOT_FOUND The register is not defined for the Save State
> of Processor.
> -@retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct.
> +@retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct.
>
> **/
> EFI_STATUS
> @@ -1251,7 +1251,7 @@ EdkiiSmmGetMemoryAttributes (
>
> /**
> This function fixes up the address of the global variable or function
> - referred in SmmInit assembly files to be the absoute address.
> + referred in SmmInit assembly files to be the absolute address.
> **/
> VOID
> EFIAPI
> @@ -1260,7 +1260,7 @@ PiSmmCpuSmmInitFixupAddress (
>
> /**
> This function fixes up the address of the global variable or function
> - referred in SmiEntry assembly files to be the absoute address.
> + referred in SmiEntry assembly files to be the absolute address.
> **/
> VOID
> EFIAPI
> diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
> b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
> index 5d09130e5591..68e5003ad4c2 100644
> --- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
> +++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
> @@ -366,7 +366,7 @@ Communicate (
> @param FileHandle Handle of the file being invoked.
> @param PeiServices Pointer to PEI Services table.
>
> - @retval EFI_SUCEESS
> + @retval EFI_SUCCESS
> @return Others Some error occurs.
> **/
> EFI_STATUS
> diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c
> b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c
> index 6be12d6c14cd..30f7d57bdd91 100644
> --- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c
> +++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c
> @@ -155,7 +155,7 @@ AllocateAcpiNvsMemoryBelow4G (
> @param[in] ImageHandle Image handle of this driver.
> @param[in] SystemTable A Pointer to the EFI System Table.
>
> - @retval EFI_SUCEESS
> + @retval EFI_SUCCESS
> @return Others Some error occurs.
> **/
> EFI_STATUS
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
> b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
> index 723fd5042ff4..db68e1316ec5 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
> @@ -215,7 +215,7 @@ DumpModuleInfoByIp (
>
> @retval EFI_SUCCESS The register was read from Save State
> @retval EFI_NOT_FOUND The register is not defined for the Save State of
> Processor
> - @retval EFI_INVALID_PARAMTER This or Buffer is NULL.
> + @retval EFI_INVALID_PARAMETER This or Buffer is NULL.
>
> **/
> EFI_STATUS
> @@ -287,7 +287,7 @@ SmmReadSaveState (
>
> @retval EFI_SUCCESS The register was written from Save State
> @retval EFI_NOT_FOUND The register is not defined for the Save State of
> Processor
> - @retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct
> + @retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct
>
> **/
> EFI_STATUS
> diff --git
> a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c
> b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c
> index 55090e9c3e4f..9c5a92af6479 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c
> @@ -465,7 +465,7 @@ ConvertMemoryPageAttributes (
> }
>
> //
> - // Below logic is to check 2M/4K page to make sure we donot waist
> memory.
> + // Below logic is to check 2M/4K page to make sure we do not waste
> memory.
> //
> while (Length != 0) {
> PageEntry = GetPageTableEntry (BaseAddress, &PageAttribute); @@ -
> 1065,7 +1065,7 @@ IsUefiPageNotPresent ( }
>
> /**
> - Merge continous memory map entries whose type is
> + Merge continuous memory map entries whose type is
> EfiLoaderCode/Data, EfiBootServicesCode/Data, EfiConventionalMemory,
> EfiUnusableMemory, EfiACPIReclaimMemory, because the memory
> described by
> these entries will be set as NOT present in SMM page table.
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c
> b/UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c
> index b1a492725a0c..661cc51f361a 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c
> @@ -260,7 +260,7 @@ GetRegisterIndex (
>
> @retval EFI_SUCCESS The register was read from Save State.
> @retval EFI_NOT_FOUND The register is not defined for the Save State
> of Processor.
> - @retval EFI_INVALID_PARAMTER This or Buffer is NULL.
> + @retval EFI_INVALID_PARAMETER This or Buffer is NULL.
>
> **/
> EFI_STATUS
> @@ -343,7 +343,7 @@ ReadSaveStateRegisterByIndex (
>
> @retval EFI_SUCCESS The register was read from Save State.
> @retval EFI_NOT_FOUND The register is not defined for the Save State
> of Processor.
> - @retval EFI_INVALID_PARAMTER This or Buffer is NULL.
> + @retval EFI_INVALID_PARAMETER This or Buffer is NULL.
>
> **/
> EFI_STATUS
> @@ -455,7 +455,7 @@ ReadSaveStateRegister (
>
> @retval EFI_SUCCESS The register was written to Save State.
> @retval EFI_NOT_FOUND The register is not defined for the Save State
> of Processor.
> - @retval EFI_INVALID_PARAMTER ProcessorIndex or Width is not correct.
> + @retval EFI_INVALID_PARAMETER ProcessorIndex or Width is not correct.
>
> **/
> EFI_STATUS
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c
> b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c
> index ce1bf9fb541c..8c9de1fdae70 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c
> @@ -58,7 +58,7 @@ SemaphoreHook (
> );
>
> //
> - // Use temp value to fix ICC complier warning
> + // Use temp value to fix ICC compiler warning
> //
> TempValue = (UINTN)&mSmmRelocationOriginalAddress;
> PatchInstructionX86 (
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm
> b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm
> index db06d22d51f4..8bfba55b5d08 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm
> @@ -16,7 +16,7 @@
> %include "Nasm.inc"
>
> ;
> -; Variables referrenced by C code
> +; Variables referenced by C code
> ;
>
> %define MSR_IA32_S_CET 0x6A2
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm
> b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm
> index 8d81582bb1dd..9cf3a6dcf9d5 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm
> @@ -72,7 +72,7 @@ BITS 64
> ASM_PFX(gPatchSmmInitStack):
> and sp, 0xfff0 ; make sure RSP is 16-byte aligned
> ;
> - ; Accoring to X64 calling convention, XMM0~5 are volatile, we need to save
> + ; According to X64 calling convention, XMM0~5 are volatile, we need
> + to save
> ; them before calling C-function.
> ;
> sub rsp, 0x60
> --
> 2.21.0
^ permalink raw reply [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-56-philmd@redhat.com>]
* Re: [PATCH 55/79] NetworkPkg/VlanConfigDxe: Fix few typos
[not found] ` <20191203161602.15969-56-philmd@redhat.com>
@ 2019-12-06 16:01 ` Rabeda, Maciej
0 siblings, 0 replies; 122+ messages in thread
From: Rabeda, Maciej @ 2019-12-06 16:01 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Wu, Jiaxin, Fu, Siyuan
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
Thanks!
Maciej
-----Original Message-----
From: Philippe Mathieu-Daude <philmd@redhat.com>
Sent: Tuesday, December 3, 2019 17:16
To: devel@edk2.groups.io
Cc: Antoine Coeur <coeur@gmx.fr>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
Subject: [PATCH 55/79] NetworkPkg/VlanConfigDxe: Fix few typos
From: Antoine Coeur <coeur@gmx.fr>
Correctly write 'EFI_SUCCESS' in the documentation.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/VlanConfigDxe/VlanConfigImpl.h | 6 +++---
NetworkPkg/VlanConfigDxe/VlanConfigDriver.c | 8 ++++----
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/NetworkPkg/VlanConfigDxe/VlanConfigImpl.h b/NetworkPkg/VlanConfigDxe/VlanConfigImpl.h
index 14f99c03b7d0..2f1f17e6ef95 100644
--- a/NetworkPkg/VlanConfigDxe/VlanConfigImpl.h
+++ b/NetworkPkg/VlanConfigDxe/VlanConfigImpl.h
@@ -185,7 +185,7 @@ VlanConfigComponentNameGetControllerName (
@param[in] RemainingDevicePath Optional parameter use to pick a specific child
device to start.
- @retval EFI_SUCCES This driver supports this device
+ @retval EFI_SUCCESS This driver supports this device
@retval EFI_ALREADY_STARTED This driver is already running on this device
@retval other This driver does not support this device
@@ -206,7 +206,7 @@ VlanConfigDriverBindingSupported (
@param[in] RemainingDevicePath Optional parameter use to pick a specific child
device to start.
- @retval EFI_SUCCES This driver is added to ControllerHandle
+ @retval EFI_SUCCESS This driver is added to ControllerHandle
@retval EFI_ALREADY_STARTED This driver is already running on ControllerHandle
@retval other This driver does not support this device
@@ -228,7 +228,7 @@ VlanConfigDriverBindingStart (
of children is zero stop the entire bus driver.
@param[in] ChildHandleBuffer List of Child Handles to Stop.
- @retval EFI_SUCCES This driver is removed ControllerHandle
+ @retval EFI_SUCCESS This driver is removed ControllerHandle
@retval other This driver was not removed from this device
**/
diff --git a/NetworkPkg/VlanConfigDxe/VlanConfigDriver.c b/NetworkPkg/VlanConfigDxe/VlanConfigDriver.c
index c717d9ea523c..ae636b763f93 100644
--- a/NetworkPkg/VlanConfigDxe/VlanConfigDriver.c
+++ b/NetworkPkg/VlanConfigDxe/VlanConfigDriver.c
@@ -24,7 +24,7 @@ EFI_DRIVER_BINDING_PROTOCOL gVlanConfigDriverBinding = {
@param[in] ImageHandle The image handle of the driver.
@param[in] SystemTable The system table.
- @retval EFI_SUCCES All the related protocols are installed on the driver.
+ @retval EFI_SUCCESS All the related protocols are installed on the driver.
@retval Others Failed to install protocols.
**/
@@ -54,7 +54,7 @@ VlanConfigDriverEntryPoint (
@param[in] RemainingDevicePath Optional parameter use to pick a specific child
device to start.
- @retval EFI_SUCCES This driver supports this device
+ @retval EFI_SUCCESS This driver supports this device
@retval EFI_ALREADY_STARTED This driver is already running on this device
@retval other This driver does not support this device
@@ -104,7 +104,7 @@ VlanConfigDriverBindingSupported (
@param[in] RemainingDevicePath Optional parameter use to pick a specific child
device to start.
- @retval EFI_SUCCES This driver is added to ControllerHandle
+ @retval EFI_SUCCESS This driver is added to ControllerHandle
@retval EFI_ALREADY_STARTED This driver is already running on ControllerHandle
@retval other This driver does not support this device
@@ -236,7 +236,7 @@ ErrorExit:
of children is zero stop the entire bus driver.
@param[in] ChildHandleBuffer List of Child Handles to Stop.
- @retval EFI_SUCCES This driver is removed ControllerHandle
+ @retval EFI_SUCCESS This driver is removed ControllerHandle
@retval other This driver was not removed from this device
**/
--
2.21.0
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
^ permalink raw reply related [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-55-philmd@redhat.com>]
* Re: [PATCH 54/79] NetworkPkg/UefiPxeBcDxe: Fix various typos
[not found] ` <20191203161602.15969-55-philmd@redhat.com>
@ 2019-12-06 16:01 ` Rabeda, Maciej
0 siblings, 0 replies; 122+ messages in thread
From: Rabeda, Maciej @ 2019-12-06 16:01 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Wu, Jiaxin, Fu, Siyuan
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
Thanks!
Maciej
-----Original Message-----
From: Philippe Mathieu-Daude <philmd@redhat.com>
Sent: Tuesday, December 3, 2019 17:16
To: devel@edk2.groups.io
Cc: Antoine Coeur <coeur@gmx.fr>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
Subject: [PATCH 54/79] NetworkPkg/UefiPxeBcDxe: Fix various typos
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.h | 2 +-
NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h | 8 ++++----
NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h | 4 ++--
NetworkPkg/UefiPxeBcDxe/PxeBcSupport.h | 16 ++++++++--------
NetworkPkg/UefiPxeBcDxe/PxeBcBoot.c | 4 ++--
NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c | 10 +++++-----
NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c | 18 +++++++++---------
NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c | 4 ++--
NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c | 10 +++++-----
NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c | 12 ++++++------
NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c | 8 ++++----
11 files changed, 48 insertions(+), 48 deletions(-)
diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.h b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.h
index 69b0502bbcd9..879da18a88e9 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.h
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.h
@@ -60,7 +60,7 @@
//
// Dhcp4 and Dhcp6 share this definition, and corresponding -// relatioinship is as follows:
+// relationship is as follows:
//
// Dhcp4Discover <> Dhcp6Solicit
// Dhcp4Offer <> Dhcp6Advertise
diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h
index ca40fdc9d336..ae4be775e85d 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h
@@ -123,7 +123,7 @@ typedef struct {
@retval EFI_ABORTED User canceled the operation.
@retval EFI_SUCCESS Selected the boot menu successfully.
- @retval EFI_NOT_READY Read the input key from the keybroad has not finish.
+ @retval EFI_NOT_READY Read the input key from the keyboard has not finish.
**/
EFI_STATUS
@@ -174,7 +174,7 @@ PxeBcParseDhcp6Packet (
@param[in] Private The pointer to the PxeBc private data.
@param[in] Address The pointer to the ready address.
- @retval EFI_SUCCESS Registered the address succesfully.
+ @retval EFI_SUCCESS Registered the address successfully.
@retval Others Failed to register the address.
**/
@@ -226,8 +226,8 @@ PxeBcDhcp6Discover (
@param[in] Private The pointer to PXEBC_PRIVATE_DATA.
- @retval EFI_SUCCESS Switch the IP policy succesfully.
- @retval Others Unexpect error happened.
+ @retval EFI_SUCCESS Switch the IP policy successfully.
+ @retval Others Unexpected error happened.
**/
EFI_STATUS
diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h b/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h
index 9a011e046543..7356c0ae9e58 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h
@@ -33,7 +33,7 @@
@param[in, out] BufferSize Pointer to buffer size.
@retval EFI_SUCCESS Successfully obtained the size of file.
- @retval EFI_NOT_FOUND Parse the tftp ptions failed.
+ @retval EFI_NOT_FOUND Parse the tftp options failed.
@retval EFI_DEVICE_ERROR The network device encountered an error during this operation.
@retval Others Did not obtain the size of the file.
@@ -119,7 +119,7 @@ PxeBcTftpWriteFile (
@param[in, out] BufferSize Pointer to buffer size.
@param[in] DontUseBuffer Indicates whether with a receive buffer.
- @retval EFI_SUCCES Successfully obtained the data from the file included in directory.
+ @retval EFI_SUCCESS Successfully obtained the data from the file included in directory.
@retval EFI_DEVICE_ERROR The network device encountered an error during this operation.
@retval Others Operation failed.
diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.h b/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.h
index 9264cd92c467..312572129e78 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.h
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.h
@@ -21,7 +21,7 @@
/**
- Flush the previous configration using the new station Ip address.
+ Flush the previous configuration using the new station Ip address.
@param[in] Private Pointer to PxeBc private data.
@param[in] StationIp Pointer to the station Ip address.
@@ -59,7 +59,7 @@ PxeBcCommonNotify (
@param Mode Pointer to EFI_PXE_BASE_CODE_MODE.
@param Ip4Addr The Ip4 address for resolution.
- @param MacAddress The resoluted MAC address if the resolution is successful.
+ @param MacAddress The resolved MAC address if the resolution is successful.
The value is undefined if resolution fails.
@retval TRUE Found a matched entry.
@@ -156,7 +156,7 @@ PxeBcConfigUdp4Write (
@param[in] StationIp Pointer to the station address.
@param[in, out] SrcPort Pointer to the source port.
- @retval EFI_SUCCESS Successfuly configured this instance.
+ @retval EFI_SUCCESS Successfully configured this instance.
@retval Others Failed to configure this instance.
**/
@@ -234,7 +234,7 @@ PxeBcUdp6Write (
@param[in] Session Pointer to the current UDPv4 session.
@param[in] OpFlags Operation flag for UdpRead/UdpWrite.
- @retval TRUE Succesfully passed the Ip filter.
+ @retval TRUE Successfully passed the Ip filter.
@retval FALSE Failed to pass the Ip filter.
**/
@@ -254,7 +254,7 @@ PxeBcCheckByIpFilter (
@param[in, out] DestIp Pointer to the dest Ip address.
@param[in] OpFlags Operation flag for UdpRead/UdpWrite.
- @retval TRUE Succesfully passed the IPv4 filter.
+ @retval TRUE Successfully passed the IPv4 filter.
@retval FALSE Failed to pass the IPv4 filter.
**/
@@ -275,7 +275,7 @@ PxeBcCheckByDestIp (
@param[in, out] DestPort Pointer to the destination port.
@param[in] OpFlags Operation flag for UdpRead/UdpWrite.
- @retval TRUE Succesfully passed the IPv4 filter.
+ @retval TRUE Successfully passed the IPv4 filter.
@retval FALSE Failed to pass the IPv4 filter.
**/
@@ -296,7 +296,7 @@ PxeBcCheckByDestPort (
@param[in, out] SrcIp Pointer to the source Ip address.
@param[in] OpFlags Operation flag for UdpRead/UdpWrite.
- @retval TRUE Succesfully passed the IPv4 filter.
+ @retval TRUE Successfully passed the IPv4 filter.
@retval FALSE Failed to pass the IPv4 filter.
**/
@@ -317,7 +317,7 @@ PxeBcFilterBySrcIp (
@param[in, out] SrcPort Pointer to the source port.
@param[in] OpFlags Operation flag for UdpRead/UdpWrite.
- @retval TRUE Succesfully passed the IPv4 filter.
+ @retval TRUE Successfully passed the IPv4 filter.
@retval FALSE Failed to pass the IPv4 filter.
**/
diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcBoot.c b/NetworkPkg/UefiPxeBcDxe/PxeBcBoot.c
index a982d3a29d9b..10bbb06f7593 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcBoot.c
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcBoot.c
@@ -257,7 +257,7 @@ ON_EXIT:
@retval EFI_ABORTED User cancel operation.
@retval EFI_SUCCESS Select the boot menu success.
- @retval EFI_NOT_READY Read the input key from the keybroad has not finish.
+ @retval EFI_NOT_READY Read the input key from the keyboard has not finish.
**/
EFI_STATUS
@@ -970,7 +970,7 @@ PxeBcDiscoverBootFile (
@param[in, out] Private Pointer to PxeBc private data.
@param[out] NewMakeCallback If TRUE, it is a new callback.
Otherwise, it is not new callback.
- @retval EFI_SUCCESS PxeBaseCodeCallbackProtocol installed succesfully.
+ @retval EFI_SUCCESS PxeBaseCodeCallbackProtocol installed successfully.
@retval Others Failed to install PxeBaseCodeCallbackProtocol.
**/
diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c
index bb5e53b5bf43..fb63cf61a97d 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c
@@ -78,7 +78,7 @@ PxeBcParseDhcp4Options (
/**
- Parse the PXE vender options and extract the information from them.
+ Parse the PXE vendor options and extract the information from them.
@param[in] Dhcp4Option Pointer to vendor options in buffer.
@param[in] VendorOption Pointer to structure to store information in vendor options.
@@ -312,7 +312,7 @@ PxeBcBuildDhcp4Options (
if (EFI_ERROR (NetLibGetSystemGuid ((EFI_GUID *) OptEnt.Uuid->Guid))) {
//
- // Zero the Guid to indicate NOT programable if failed to get system Guid.
+ // Zero the Guid to indicate NOT programmable if failed to get system Guid.
//
DEBUG ((EFI_D_WARN, "PXE: Failed to read system GUID from the smbios table!\n"));
ZeroMem (OptEnt.Uuid->Guid, sizeof (EFI_GUID)); @@ -1125,7 +1125,7 @@ PxeBcHandleDhcp4Offer (
}
} else {
//
- // Othewise, the bootfile name must be included in DhcpOnly offer.
+ // Otherwise, the bootfile name must be included in DhcpOnly offer.
//
if (Options[PXEBC_DHCP4_TAG_INDEX_BOOTFILE] == NULL) {
Status = EFI_NOT_FOUND;
@@ -1275,7 +1275,7 @@ PxeBcDhcp4CallBack (
//
if (EFI_ERROR (NetLibGetSystemGuid ((EFI_GUID *) Packet->Dhcp4.Header.ClientHwAddr))) {
//
- // Zero the Guid to indicate NOT programable if failed to get system Guid.
+ // Zero the Guid to indicate NOT programmable if failed to get system Guid.
//
DEBUG ((EFI_D_WARN, "PXE: Failed to read system GUID from the smbios table!\n"));
ZeroMem (Packet->Dhcp4.Header.ClientHwAddr, sizeof (EFI_GUID)); @@ -1464,7 +1464,7 @@ PxeBcDhcp4Discover (
if (Mode->SendGUID) {
if (EFI_ERROR (NetLibGetSystemGuid ((EFI_GUID *) Token.Packet->Dhcp4.Header.ClientHwAddr))) {
//
- // Zero the Guid to indicate NOT programable if failed to get system Guid.
+ // Zero the Guid to indicate NOT programmable if failed to get system Guid.
//
DEBUG ((EFI_D_WARN, "PXE: Failed to read system GUID from the smbios table!\n"));
ZeroMem (Token.Packet->Dhcp4.Header.ClientHwAddr, sizeof (EFI_GUID)); diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c
index 1164fbbdefed..8d71143b79f3 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c
@@ -25,7 +25,7 @@ EFI_IPv6_ADDRESS mAllDhcpRelayAndServersAddress = {{0xFF, 2, 0, 0, 0, 0, 0, 0,
@param[in] OptTag The required option tag.
@retval NULL Failed to parse the required option.
- @retval Others The postion of the required option in buffer.
+ @retval Others The position of the required option in buffer.
**/
EFI_DHCP6_PACKET_OPTION *
@@ -370,7 +370,7 @@ Exit:
@retval EFI_ABORTED User cancel operation.
@retval EFI_SUCCESS Selected the boot menu successfully.
- @retval EFI_NOT_READY Read the input key from the keybroad has not finish.
+ @retval EFI_NOT_READY Read the input key from the keyboard has not finish.
**/
EFI_STATUS
@@ -674,7 +674,7 @@ PxeBcParseDhcp6Packet (
//
// The offer with assigned client address is NOT a proxy offer.
- // An ia_na option, embeded with valid ia_addr option and a status_code of success.
+ // An ia_na option, embedded with valid ia_addr option and a status_code of success.
//
Option = Options[PXEBC_DHCP6_IDX_IA_NA];
if (Option != NULL) {
@@ -1431,7 +1431,7 @@ PxeBcHandleDhcp6Offer (
}
} else {
//
- // Othewise, the bootfilename must be included in DhcpOnly offer.
+ // Otherwise, the bootfilename must be included in DhcpOnly offer.
//
ASSERT (Cache6->OptList[PXEBC_DHCP6_IDX_BOOT_FILE_URL] != NULL);
}
@@ -1480,7 +1480,7 @@ PxeBcUnregisterIp6Address (
@retval EFI_SUCCESS Found a valid gateway address successfully.
@retval EFI_TIMEOUT The operation is time out.
- @retval Other Unexpect error happened.
+ @retval Other Unexpected error happened.
**/
EFI_STATUS
@@ -1594,7 +1594,7 @@ ON_EXIT:
@param[in] Private The pointer to PXEBC_PRIVATE_DATA.
@param[in] Address The pointer to the ready address.
- @retval EFI_SUCCESS Registered the address succesfully.
+ @retval EFI_SUCCESS Registered the address successfully.
@retval Others Failed to register the address.
**/
@@ -1774,8 +1774,8 @@ ON_EXIT:
@param[in] Private The pointer to PXEBC_PRIVATE_DATA.
- @retval EFI_SUCCESS Switch the IP policy succesfully.
- @retval Others Unexpect error happened.
+ @retval EFI_SUCCESS Switch the IP policy successfully.
+ @retval Others Unexpected error happened.
**/
EFI_STATUS
@@ -1915,7 +1915,7 @@ PxeBcDhcp6CallBack (
Callback = Private->PxeBcCallback;
//
- // Callback to user when any traffic ocurred if has.
+ // Callback to user when any traffic occurred if has.
//
if (Dhcp6Event != Dhcp6SelectAdvertise && Callback != NULL) {
Received = (BOOLEAN) (Dhcp6Event == Dhcp6RcvdAdvertise || Dhcp6Event == Dhcp6RcvdReply); diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c b/NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c
index b35edb687d30..0e2675be3c98 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c
@@ -1,5 +1,5 @@
/** @file
- Driver Binding functions implementationfor for UefiPxeBc Driver.
+ Driver Binding functions implementation for UefiPxeBc Driver.
(C) Copyright 2014 Hewlett-Packard Development Company, L.P.<BR>
Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved.<BR> @@ -1184,7 +1184,7 @@ PxeBcCreateIp6Children (
}
//
- // Set IPv6 avaiable flag and set default configure data for
+ // Set IPv6 available flag and set default configure data for
// Udp6Read and Ip6 instance.
//
Status = PxeBcCheckIpv6Support (ControllerHandle, Private, &Private->Mode.Ipv6Available); diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c b/NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c
index 639415b286a3..5d18207b6ce8 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c
@@ -204,7 +204,7 @@ EfiPxeBcStart (
//the active state, If the DHCP4 D.O.R.A started by IP4 auto
//configuration and has not been completed, the Dhcp4 state machine
//will not be in the right state for the PXE to start a new round D.O.R.A.
- //so we need to switch it's policy to static.
+ //so we need to switch its policy to static.
//
Status = PxeBcSetIp4Policy (Private);
if (EFI_ERROR (Status)) {
@@ -631,7 +631,7 @@ EfiPxeBcDiscover (
}
if (Index != Info->IpCnt) {
//
- // It's invalid if the first server doesn't accecpt any response
+ // It's invalid if the first server doesn't accept any response
// but any of the other servers does accept any response.
//
Status = EFI_INVALID_PARAMETER; @@ -1410,7 +1410,7 @@ EfiPxeBcUdpRead (
if (IsMatched) {
//
- // Copy the rececived packet to user if matched by filter.
+ // Copy the received packet to user if matched by filter.
//
if (Mode->UsingIpv6) {
Udp6Rx = Udp6Token.Packet.RxData; @@ -1685,7 +1685,7 @@ EfiPxeBcSetIpFilter (
for (Index = 0; Index < NewFilter->IpCnt; ++Index) {
if (IP4_IS_MULTICAST (EFI_NTOHL (NewFilter->IpList[Index].v4))) {
//
- // Join the mutilcast group.
+ // Join the multicast group.
//
Status = Private->Udp4Read->Groups (Private->Udp4Read, TRUE, &NewFilter->IpList[Index].v4);
if (EFI_ERROR (Status)) {
@@ -1723,7 +1723,7 @@ EfiPxeBcSetIpFilter (
for (Index = 0; Index < NewFilter->IpCnt; ++Index) {
if (IP6_IS_MULTICAST (&NewFilter->IpList[Index].v6)) {
//
- // Join the mutilcast group.
+ // Join the multicast group.
//
Status = Private->Udp6Read->Groups (Private->Udp6Read, TRUE, &NewFilter->IpList[Index].v6);
if (EFI_ERROR (Status)) {
diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c b/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c
index 6a390c249f67..addcafc0c88c 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c
@@ -106,8 +106,8 @@ PxeBcMtftp6CheckPacket (
@param[in] WindowSize Pointer to required window size.
@param[in, out] BufferSize Pointer to buffer size.
- @retval EFI_SUCCESS Sucessfully obtained the size of file.
- @retval EFI_NOT_FOUND Parse the tftp ptions failed.
+ @retval EFI_SUCCESS Successfully obtained the size of file.
+ @retval EFI_NOT_FOUND Parse the tftp options failed.
@retval EFI_DEVICE_ERROR The network device encountered an error during this operation.
@retval Others Has not obtained the size of the file.
@@ -512,7 +512,7 @@ PxeBcMtftp6ReadDirectory (
@param[in] PacketLen Length of EFI_MTFTP4_PACKET.
@param[in] Packet Pointer to EFI_MTFTP4_PACKET to be checked.
- @retval EFI_SUCCESS The current operation succeeeded.
+ @retval EFI_SUCCESS The current operation succeeded.
@retval EFI_ABORTED Abort the current transfer process.
**/
@@ -896,7 +896,7 @@ PxeBcMtftp4WriteFile (
@param[in, out] BufferSize Pointer to buffer size.
@param[in] DontUseBuffer Indicates whether to use a receive buffer.
- @retval EFI_SUCCES Successfully obtained the data from the file included in the directory.
+ @retval EFI_SUCCESS Successfully obtained the data from the file included in the directory.
@retval EFI_DEVICE_ERROR The network device encountered an error during this operation.
@retval Others Operation failed.
@@ -1037,7 +1037,7 @@ PxeBcTftpGetFileSize (
@param[in, out] BufferSize Pointer to buffer size.
@param[in] DontUseBuffer Indicates whether to use a receive buffer.
- @retval EFI_SUCCESS Sucessfully read the data from the special file.
+ @retval EFI_SUCCESS Successfully read the data from the special file.
@retval EFI_DEVICE_ERROR The network device encountered an error during this operation.
@retval Others Read data from file failed.
@@ -1143,7 +1143,7 @@ PxeBcTftpWriteFile (
@param[in, out] BufferSize Pointer to buffer size.
@param[in] DontUseBuffer Indicatse whether to use a receive buffer.
- @retval EFI_SUCCES Successfully obtained the data from the file included in the directory.
+ @retval EFI_SUCCESS Successfully obtained the data from the file included in the directory.
@retval EFI_DEVICE_ERROR The network device encountered an error during this operation.
@retval Others Operation failed.
diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c b/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c
index ae8eb48947fd..8eb1558d30a9 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c
@@ -11,7 +11,7 @@
/**
- Flush the previous configration using the new station Ip address.
+ Flush the previous configuration using the new station Ip address.
@param[in] Private The pointer to the PxeBc private data.
@param[in] StationIp The pointer to the station Ip address.
@@ -136,7 +136,7 @@ PxeBcCommonNotify (
@param Mode The pointer to EFI_PXE_BASE_CODE_MODE.
@param Ip4Addr The Ip4 address for resolution.
- @param MacAddress The resoluted MAC address if the resolution is successful.
+ @param MacAddress The resolved MAC address if the resolution is successful.
The value is undefined if the resolution fails.
@retval TRUE Found an matched entry.
@@ -1176,7 +1176,7 @@ PxeBcUdp4Read (
Token->Status == EFI_NOT_READY &&
EFI_ERROR (gBS->CheckEvent (TimeoutEvent))) {
//
- // Poll the token utill reply/ICMPv6 error message received or timeout.
+ // Poll the token until reply/ICMPv6 error message received or timeout.
//
Udp4->Poll (Udp4);
if (Token->Status == EFI_ICMP_ERROR || @@ -1280,7 +1280,7 @@ PxeBcUdp6Read (
Token->Status == EFI_NOT_READY &&
EFI_ERROR (gBS->CheckEvent (TimeoutEvent))) {
//
- // Poll the token utill reply/ICMPv6 error message received or timeout.
+ // Poll the token until reply/ICMPv6 error message received or timeout.
//
Udp6->Poll (Udp6);
if (Token->Status == EFI_ICMP_ERROR ||
--
2.21.0
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
^ permalink raw reply related [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-52-philmd@redhat.com>]
* Re: [PATCH 51/79] NetworkPkg/Tls: Fix few typos
[not found] ` <20191203161602.15969-52-philmd@redhat.com>
@ 2019-12-06 16:01 ` Rabeda, Maciej
0 siblings, 0 replies; 122+ messages in thread
From: Rabeda, Maciej @ 2019-12-06 16:01 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Wu, Jiaxin, Fu, Siyuan
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
Thanks!
Maciej
-----Original Message-----
From: Philippe Mathieu-Daude <philmd@redhat.com>
Sent: Tuesday, December 3, 2019 17:16
To: devel@edk2.groups.io
Cc: Antoine Coeur <coeur@gmx.fr>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
Subject: [PATCH 51/79] NetworkPkg/Tls: Fix few typos
From: Antoine Coeur <coeur@gmx.fr>
Fix few typos in comments and documentation.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h | 2 +-
NetworkPkg/TlsDxe/TlsDriver.h | 4 ++--
NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigVfr.vfr | 6 +++--- NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 6 +++---
NetworkPkg/TlsDxe/TlsDriver.c | 4 ++--
5 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h
index 89d02e39a319..e9af49289393 100644
--- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h
+++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h
@@ -207,7 +207,7 @@ TlsAuthConfigAccessExtractConfig (
@param Progress A pointer to a string filled in with the
offset of the most recent '&' before the
first failing name / value pair (or the
- beginn ing of the string if the failure
+ beginning of the string if the failure
is in the first name / value pair) or
the terminating NULL if all was
successful.
diff --git a/NetworkPkg/TlsDxe/TlsDriver.h b/NetworkPkg/TlsDxe/TlsDriver.h index e9b581d05459..64a81bd49063 100644
--- a/NetworkPkg/TlsDxe/TlsDriver.h
+++ b/NetworkPkg/TlsDxe/TlsDriver.h
@@ -189,7 +189,7 @@ TlsDriverEntryPoint (
then a new handle is created. If it is a pointer to an existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child.
@@ -213,7 +213,7 @@ TlsServiceBindingCreateChild (
@param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param ChildHandle Handle of the child to destroy.
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigVfr.vfr b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigVfr.vfr
index c622489afc82..99a7feafa20c 100644
--- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigVfr.vfr
+++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigVfr.vfr
@@ -19,7 +19,7 @@ formset
guid = TLS_AUTH_CONFIG_GUID;
//
- // ##1 Form1: Main form for Tls Auth configration
+ // ##1 Form1: Main form for Tls Auth configuration
//
form formid = TLS_AUTH_CONFIG_FORMID1_FORM,
title = STRING_TOKEN(STR_TLS_AUTH_CONFIG_TITLE);
@@ -27,7 +27,7 @@ formset
subtitle text = STRING_TOKEN(STR_NULL);
//
- // Display Server CA configration
+ // Display Server CA configuration
//
goto TLS_AUTH_CONFIG_FORMID2_FORM,
prompt = STRING_TOKEN(STR_TLS_AUTH_CONFIG_SERVER_CA),
@@ -38,7 +38,7 @@ formset
subtitle text = STRING_TOKEN(STR_NULL);
//
- // Display Client cert configration
+ // Display Client cert configuration
//
grayoutif TRUE; /// Current unsupported.
goto TLS_AUTH_CONFIG_FORMID3_FORM,
diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c
index 666216545277..715bc3a0a941 100644
--- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c
+++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c
@@ -298,7 +298,7 @@ ON_EXIT:
@param[in] QuestionIdBase Base question id of the cert list.
@param[in] DeleteIndex Cert index to delete.
- @retval EFI_SUCCESS Delete siganture successfully.
+ @retval EFI_SUCCESS Delete signature successfully.
@retval EFI_NOT_FOUND Can't find the signature item,
@retval EFI_OUT_OF_RESOURCES Could not allocate needed resources.
**/
@@ -597,7 +597,7 @@ DevicePathToStr (
@param DevicePath Device path.
- @retval NULL Not enough memory resourece for AllocateCopyPool.
+ @retval NULL Not enough memory resource for AllocateCopyPool.
@retval Other A new allocated string that represents the file name.
**/
@@ -1303,7 +1303,7 @@ TlsAuthConfigAccessExtractConfig (
@param Progress A pointer to a string filled in with the
offset of the most recent '&' before the
first failing name / value pair (or the
- beginn ing of the string if the failure
+ beginning of the string if the failure
is in the first name / value pair) or
the terminating NULL if all was
successful.
diff --git a/NetworkPkg/TlsDxe/TlsDriver.c b/NetworkPkg/TlsDxe/TlsDriver.c index 60ad396644f0..e42ac60764ff 100644
--- a/NetworkPkg/TlsDxe/TlsDriver.c
+++ b/NetworkPkg/TlsDxe/TlsDriver.c
@@ -298,7 +298,7 @@ ON_CLEAN_SERVICE:
then a new handle is created. If it is a pointer to an existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child.
@@ -391,7 +391,7 @@ ON_ERROR:
@param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param ChildHandle Handle of the child to destroy.
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
--
2.21.0
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
^ permalink raw reply related [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-51-philmd@redhat.com>]
* Re: [PATCH 50/79] NetworkPkg/TcpDxe/Tcp: Fix various typos
[not found] ` <20191203161602.15969-51-philmd@redhat.com>
@ 2019-12-06 16:02 ` Rabeda, Maciej
0 siblings, 0 replies; 122+ messages in thread
From: Rabeda, Maciej @ 2019-12-06 16:02 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Wu, Jiaxin, Fu, Siyuan
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
Thanks!
Maciej
-----Original Message-----
From: Philippe Mathieu-Daude <philmd@redhat.com>
Sent: Tuesday, December 3, 2019 17:16
To: devel@edk2.groups.io
Cc: Antoine Coeur <coeur@gmx.fr>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
Subject: [PATCH 50/79] NetworkPkg/TcpDxe/Tcp: Fix various typos
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in documentation, comments and debug strings.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/TcpDxe/TcpDriver.h | 8 ++++----
NetworkPkg/TcpDxe/TcpFunc.h | 4 ++--
NetworkPkg/TcpDxe/TcpMain.h | 4 ++--
NetworkPkg/TcpDxe/TcpOption.h | 6 +++---
NetworkPkg/TcpDxe/TcpProto.h | 14 +++++++-------
NetworkPkg/TcpDxe/TcpDispatcher.c | 6 +++---
NetworkPkg/TcpDxe/TcpDriver.c | 10 +++++-----
NetworkPkg/TcpDxe/TcpInput.c | 8 ++++----
NetworkPkg/TcpDxe/TcpMain.c | 4 ++--
NetworkPkg/TcpDxe/TcpMisc.c | 2 +-
NetworkPkg/TcpDxe/TcpOption.c | 2 +-
NetworkPkg/TcpDxe/TcpOutput.c | 4 ++--
NetworkPkg/TcpDxe/TcpTimer.c | 2 +-
13 files changed, 37 insertions(+), 37 deletions(-)
diff --git a/NetworkPkg/TcpDxe/TcpDriver.h b/NetworkPkg/TcpDxe/TcpDriver.h index 1ac412be6386..b90eed9f60a9 100644
--- a/NetworkPkg/TcpDxe/TcpDriver.h
+++ b/NetworkPkg/TcpDxe/TcpDriver.h
@@ -203,13 +203,13 @@ Tcp6DriverBindingStop (
);
/**
- The Callback funtion called after the TCP socket is created.
+ The Callback function called after the TCP socket is created.
@param[in] This Pointer to the socket just created.
@param[in] Context The context of the socket.
@retval EFI_SUCCESS This protocol is installed successfully.
- @retval other An error occured.
+ @retval other An error occurred.
**/
EFI_STATUS
@@ -248,7 +248,7 @@ TcpDestroySocketCallback (
If it is a pointer to an existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child.
@@ -272,7 +272,7 @@ TcpServiceBindingCreateChild (
@param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param ChildHandle Handle of the child to destroy.
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER The child handle is NULL.
@retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
diff --git a/NetworkPkg/TcpDxe/TcpFunc.h b/NetworkPkg/TcpDxe/TcpFunc.h index 5b8043e8ad52..05cd3c75dc51 100644
--- a/NetworkPkg/TcpDxe/TcpFunc.h
+++ b/NetworkPkg/TcpDxe/TcpFunc.h
@@ -46,7 +46,7 @@ TcpInitTcbLocal (
Initialize the peer related members.
@param[in, out] Tcb Pointer to the TCP_CB of this TCP instance.
- @param[in] Seg Pointer to the segment that contains the peer's intial information.
+ @param[in] Seg Pointer to the segment that contains the peer's initial information.
@param[in] Opt Pointer to the options announced by the peer.
**/
@@ -668,7 +668,7 @@ Tcp6RefreshNeighbor ( //
/**
- The procotol handler provided to the socket layer, used to
+ The protocol handler provided to the socket layer, used to
dispatch the socket level requests by calling the corresponding
TCP layer functions.
diff --git a/NetworkPkg/TcpDxe/TcpMain.h b/NetworkPkg/TcpDxe/TcpMain.h index 69b35427a17b..35f12a16a87c 100644
--- a/NetworkPkg/TcpDxe/TcpMain.h
+++ b/NetworkPkg/TcpDxe/TcpMain.h
@@ -230,7 +230,7 @@ Tcp4Connect (
@retval EFI_SUCCESS The listen token has been queued successfully.
@retval EFI_NOT_STARTED The EFI_TCP4_PROTOCOL instance hasn't been
configured.
- @retval EFI_ACCESS_DENIED The instatnce is not a passive one or it is not
+ @retval EFI_ACCESS_DENIED The instance is not a passive one or it is not
in Tcp4StateListen state, or a same listen token
has already existed in the listen token queue of
this TCP instance.
@@ -565,7 +565,7 @@ Tcp6Connect (
@retval EFI_INVALID_PARAMETER One or more of the following are TRUE:
- This is NULL.
- ListenToken is NULL.
- - ListentToken->CompletionToken.Event is NULL.
+ - ListenToken->CompletionToken.Event is NULL.
@retval EFI_OUT_OF_RESOURCES Could not allocate enough resources to finish the operation.
@retval EFI_DEVICE_ERROR Any unexpected error not belonging to the error
categories given above.
diff --git a/NetworkPkg/TcpDxe/TcpOption.h b/NetworkPkg/TcpDxe/TcpOption.h index b28f4e63370c..20a476ecebd6 100644
--- a/NetworkPkg/TcpDxe/TcpOption.h
+++ b/NetworkPkg/TcpDxe/TcpOption.h
@@ -40,12 +40,12 @@
#define TCP_OPTION_MSS_FAST ((TCP_OPTION_MSS << 24) | (TCP_OPTION_MSS_LEN << 16))
//
-// Other misc definations
+// Other misc definitions
//
#define TCP_OPTION_RCVD_MSS 0x01
#define TCP_OPTION_RCVD_WS 0x02
#define TCP_OPTION_RCVD_TS 0x04
-#define TCP_OPTION_MAX_WS 14 ///< Maxium window scale value
+#define TCP_OPTION_MAX_WS 14 ///< Maximum window scale value
#define TCP_OPTION_MAX_WIN 0xffff ///< Max window size in TCP header
///
@@ -111,7 +111,7 @@ TcpBuildOption (
successfully pasrsed options.
@retval 0 The options successfully pasrsed.
- @retval -1 Ilegal option was found.
+ @retval -1 Illegal option was found.
**/
INTN
diff --git a/NetworkPkg/TcpDxe/TcpProto.h b/NetworkPkg/TcpDxe/TcpProto.h index 403ac98a5c0e..53cfd48026c5 100644
--- a/NetworkPkg/TcpDxe/TcpProto.h
+++ b/NetworkPkg/TcpDxe/TcpProto.h
@@ -86,9 +86,9 @@
#define TCP_TICK 200 ///< Every TCP tick is 200ms.
#define TCP_TICK_HZ 5 ///< The frequence of TCP tick.
#define TCP_RTT_SHIFT 3 ///< SRTT & RTTVAR scaled by 8.
-#define TCP_RTO_MIN TCP_TICK_HZ ///< The minium value of RTO.
-#define TCP_RTO_MAX (TCP_TICK_HZ * 60) ///< The maxium value of RTO.
-#define TCP_FOLD_RTT 4 ///< Timeout threshod to fold RTT.
+#define TCP_RTO_MIN TCP_TICK_HZ ///< The minimum value of RTO.
+#define TCP_RTO_MAX (TCP_TICK_HZ * 60) ///< The maximum value of RTO.
+#define TCP_FOLD_RTT 4 ///< Timeout threshold to fold RTT.
//
// Default values for some timers
@@ -103,7 +103,7 @@
#define TCP_CONNECT_TIME (75 * TCP_TICK_HZ)
//
-// The header space to be reserved before TCP data to accomodate :
+// The header space to be reserved before TCP data to accommodate:
// 60byte IP head + 60byte TCP head + link layer head //
#define TCP_MAX_HEAD 192
@@ -236,7 +236,7 @@ struct _TCP_CONTROL_BLOCK {
LIST_ENTRY List; ///< Back and forward link entry
TCP_CB *Parent; ///< The parent TCP_CB structure
- SOCKET *Sk; ///< The socket it controled.
+ SOCKET *Sk; ///< The socket it controlled.
TCP_PEER LocalEnd; ///< Local endpoint.
TCP_PEER RemoteEnd;///< Remote endpoint.
@@ -320,9 +320,9 @@ struct _TCP_CONTROL_BLOCK {
//
UINT32 KeepAliveIdle; ///< Idle time before sending first probe.
UINT32 KeepAlivePeriod; ///< Interval for subsequent keep alive probe.
- UINT8 MaxKeepAlive; ///< Maxium keep alive probe times.
+ UINT8 MaxKeepAlive; ///< Maximum keep alive probe times.
UINT8 KeepAliveProbes; ///< The number of keep alive probe.
- UINT16 MaxRexmit; ///< The maxium number of retxmit before abort.
+ UINT16 MaxRexmit; ///< The maximum number of retxmit before abort.
UINT32 FinWait2Timeout; ///< The FIN_WAIT_2 timeout.
UINT32 TimeWaitTimeout; ///< The TIME_WAIT timeout.
UINT32 ConnectTimeout; ///< The connect establishment timeout.
diff --git a/NetworkPkg/TcpDxe/TcpDispatcher.c b/NetworkPkg/TcpDxe/TcpDispatcher.c
index 86beaf8cc513..2d23baa1d474 100644
--- a/NetworkPkg/TcpDxe/TcpDispatcher.c
+++ b/NetworkPkg/TcpDxe/TcpDispatcher.c
@@ -309,7 +309,7 @@ TcpFlushPcb (
if (Sock->DevicePath != NULL) {
//
- // Uninstall the device path protocl.
+ // Uninstall the device path protocol.
//
gBS->UninstallProtocolInterface (
Sock->SockHandle,
@@ -548,7 +548,7 @@ TcpConfigurePcb (
}
//
- // Initalize the operating information in this Tcb
+ // Initialize the operating information in this Tcb
//
ASSERT (Tcb->State == TCP_CLOSED &&
IsListEmpty (&Tcb->SndQue) &&
@@ -750,7 +750,7 @@ OnExit:
}
/**
- The procotol handler provided to the socket layer, which is used to
+ The protocol handler provided to the socket layer, which is used to
dispatch the socket level requests by calling the corresponding
TCP layer functions.
diff --git a/NetworkPkg/TcpDxe/TcpDriver.c b/NetworkPkg/TcpDxe/TcpDriver.c index 1817afa38665..c4dcb5e193ae 100644
--- a/NetworkPkg/TcpDxe/TcpDriver.c
+++ b/NetworkPkg/TcpDxe/TcpDriver.c
@@ -732,13 +732,13 @@ Tcp6DriverBindingStop ( }
/**
- The Callback funtion called after the TCP socket was created.
+ The Callback function called after the TCP socket was created.
@param[in] This Pointer to the socket just created
@param[in] Context Context of the socket
@retval EFI_SUCCESS This protocol installed successfully.
- @retval other An error occured.
+ @retval other An error occurred.
**/
EFI_STATUS
@@ -856,7 +856,7 @@ TcpDestroySocketCallback (
If it is a pointer to an existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child.
@@ -888,7 +888,7 @@ TcpServiceBindingCreateChild (
TcpProto.TcpPcb = NULL;
//
- // Create a tcp instance with defualt Tcp default
+ // Create a tcp instance with default Tcp default
// sock init data and TcpProto
//
mTcpDefaultSockData.ProtoData = &TcpProto;
@@ -930,7 +930,7 @@ TcpServiceBindingCreateChild (
@param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param ChildHandle Handle of the child to be destroyed.
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
diff --git a/NetworkPkg/TcpDxe/TcpInput.c b/NetworkPkg/TcpDxe/TcpInput.c index 42079671ee3a..5e6c8c54cabe 100644
--- a/NetworkPkg/TcpDxe/TcpInput.c
+++ b/NetworkPkg/TcpDxe/TcpInput.c
@@ -246,7 +246,7 @@ TcpComputeRtt (
//
// Step 2.4: Limit the RTO to at least 1 second
- // Step 2.5: Limit the RTO to a maxium value that
+ // Step 2.5: Limit the RTO to a maximum value that
// is at least 60 second
//
if (Tcb->Rto < TCP_RTO_MIN) {
@@ -681,7 +681,7 @@ TcpQueueData (
Adjust the send queue or the retransmit queue.
@param[in] Tcb Pointer to the TCP_CB of this TCP instance.
- @param[in] Ack The acknowledge seuqence number of the received segment.
+ @param[in] Ack The acknowledge sequence number of the received segment.
@retval 0 An error condition occurred.
@retval 1 No error occurred.
@@ -1024,7 +1024,7 @@ TcpInput (
goto StepSix;
} else {
//
- // Received a SYN segment without ACK, simultanous open.
+ // Received a SYN segment without ACK, simultaneous open.
//
TcpSetState (Tcb, TCP_SYN_RCVD);
@@ -1103,7 +1103,7 @@ TcpInput (
//
// This TCB comes from either a LISTEN TCB,
- // or active open TCB with simultanous open.
+ // or active open TCB with simultaneous open.
// Do NOT signal user CONNECTION refused
// if it comes from a LISTEN TCB.
//
diff --git a/NetworkPkg/TcpDxe/TcpMain.c b/NetworkPkg/TcpDxe/TcpMain.c index fa357cd01a83..75de71eb6ea3 100644
--- a/NetworkPkg/TcpDxe/TcpMain.c
+++ b/NetworkPkg/TcpDxe/TcpMain.c
@@ -282,7 +282,7 @@ Tcp4Connect (
@retval EFI_SUCCESS The listen token was queued successfully.
@retval EFI_NOT_STARTED The EFI_TCP4_PROTOCOL instance hasn't been
configured.
- @retval EFI_ACCESS_DENIED The instatnce is not a passive one or it is not
+ @retval EFI_ACCESS_DENIED The instance is not a passive one or it is not
in Tcp4StateListen state or a same listen token
has already existed in the listen token queue of
this TCP instance.
@@ -795,7 +795,7 @@ Tcp6Connect (
@retval EFI_INVALID_PARAMETER One or more of the following are TRUE:
- This is NULL.
- ListenToken is NULL.
- - ListentToken->CompletionToken.Event is NULL.
+ - ListenToken->CompletionToken.Event is NULL.
@retval EFI_OUT_OF_RESOURCES Could not allocate enough resource to finish the operation.
@retval EFI_DEVICE_ERROR Any unexpected error not belonging to a category listed above.
diff --git a/NetworkPkg/TcpDxe/TcpMisc.c b/NetworkPkg/TcpDxe/TcpMisc.c index 8b0313a02820..73ed33de85ad 100644
--- a/NetworkPkg/TcpDxe/TcpMisc.c
+++ b/NetworkPkg/TcpDxe/TcpMisc.c
@@ -89,7 +89,7 @@ TcpInitTcbLocal (
Initialize the peer related members.
@param[in, out] Tcb Pointer to the TCP_CB of this TCP instance.
- @param[in] Seg Pointer to the segment that contains the peer's intial info.
+ @param[in] Seg Pointer to the segment that contains the peer's initial info.
@param[in] Opt Pointer to the options announced by the peer.
**/
diff --git a/NetworkPkg/TcpDxe/TcpOption.c b/NetworkPkg/TcpDxe/TcpOption.c index bce814da6c99..c5dbd620e8a0 100644
--- a/NetworkPkg/TcpDxe/TcpOption.c
+++ b/NetworkPkg/TcpDxe/TcpOption.c
@@ -224,7 +224,7 @@ TcpBuildOption (
successfully pasrsed options.
@retval 0 The options are successfully pasrsed.
- @retval -1 Ilegal option was found.
+ @retval -1 Illegal option was found.
**/
INTN
diff --git a/NetworkPkg/TcpDxe/TcpOutput.c b/NetworkPkg/TcpDxe/TcpOutput.c index 96aada66c8d6..7d0cf0900a66 100644
--- a/NetworkPkg/TcpDxe/TcpOutput.c
+++ b/NetworkPkg/TcpDxe/TcpOutput.c
@@ -477,7 +477,7 @@ TcpGetSegmentSndQue (
//
// If SYN is set and out of the range, clear the flag.
- // Becuase the sequence of the first byte is SEG.SEQ+1,
+ // Because the sequence of the first byte is SEG.SEQ+1,
// adjust Offset by -1. If SYN is in the range, copy
// one byte less.
//
@@ -660,7 +660,7 @@ TcpRetransmit (
UINT32 Len;
//
- // Compute the maxium length of retransmission. It is
+ // Compute the maximum length of retransmission. It is
// limited by three factors:
// 1. Less than SndMss
// 2. Must in the current send window diff --git a/NetworkPkg/TcpDxe/TcpTimer.c b/NetworkPkg/TcpDxe/TcpTimer.c index 2df89094bb91..106d9470dba2 100644
--- a/NetworkPkg/TcpDxe/TcpTimer.c
+++ b/NetworkPkg/TcpDxe/TcpTimer.c
@@ -149,7 +149,7 @@ TcpConnectTimeout (
if (!TCP_CONNECTED (Tcb->State)) {
DEBUG (
(EFI_D_ERROR,
- "TcpConnectTimeout: connection closed because conenction timer timeout for TCB %p\n",
+ "TcpConnectTimeout: connection closed because connection timer
+ timeout for TCB %p\n",
Tcb)
);
--
2.21.0
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
^ permalink raw reply related [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-47-philmd@redhat.com>]
* Re: [PATCH 46/79] NetworkPkg/Mtftp4Dxe: Fix various typos
[not found] ` <20191203161602.15969-47-philmd@redhat.com>
@ 2019-12-06 16:02 ` Rabeda, Maciej
0 siblings, 0 replies; 122+ messages in thread
From: Rabeda, Maciej @ 2019-12-06 16:02 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Wu, Jiaxin, Fu, Siyuan
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
Thanks!
Maciej
-----Original Message-----
From: Philippe Mathieu-Daude <philmd@redhat.com>
Sent: Tuesday, December 3, 2019 17:15
To: devel@edk2.groups.io
Cc: Antoine Coeur <coeur@gmx.fr>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
Subject: [PATCH 46/79] NetworkPkg/Mtftp4Dxe: Fix various typos
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in documentation, comments and debug strings.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/Mtftp4Dxe/Mtftp4Driver.h | 2 +-
NetworkPkg/Mtftp4Dxe/Mtftp4Impl.h | 2 +-
NetworkPkg/Mtftp4Dxe/Mtftp4Option.h | 2 +- NetworkPkg/Mtftp4Dxe/Mtftp4Support.h | 2 +- NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c | 4 ++--
NetworkPkg/Mtftp4Dxe/Mtftp4Impl.c | 10 +++++-----
NetworkPkg/Mtftp4Dxe/Mtftp4Option.c | 14 +++++++-------
NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c | 8 ++++----
NetworkPkg/Mtftp4Dxe/Mtftp4Support.c | 6 +++---
NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c | 6 +++---
10 files changed, 28 insertions(+), 28 deletions(-)
diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.h b/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.h
index c90e69018629..6637c5a93ee5 100644
--- a/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.h
+++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.h
@@ -113,7 +113,7 @@ Mtftp4ServiceBindingCreateChild (
@param This The service binding instance
@param ChildHandle The child handle to destroy
- @retval EFI_INVALID_PARAMETER The parameter is invaid.
+ @retval EFI_INVALID_PARAMETER The parameter is invalid.
@retval EFI_UNSUPPORTED The child may have already been destroyed.
@retval EFI_SUCCESS The child is destroyed and removed from the
parent's child list.
diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Impl.h b/NetworkPkg/Mtftp4Dxe/Mtftp4Impl.h
index 33393d42472c..b16ac0a4a483 100644
--- a/NetworkPkg/Mtftp4Dxe/Mtftp4Impl.h
+++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Impl.h
@@ -201,7 +201,7 @@ Mtftp4WrqStart (
Start the MTFTP session to download.
It will first initialize some of the internal states then build and send a RRQ
- reqeuest packet, at last, it will start receive for the downloading.
+ request packet, at last, it will start receive for the downloading.
@param Instance The Mtftp session
@param Operation The MTFTP opcode, it may be a EFI_MTFTP4_OPCODE_RRQ
diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h
index 7bfe706f88c6..5f37b0f7b9e6 100644
--- a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h
+++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.h
@@ -45,7 +45,7 @@ typedef struct {
@param OptionList The point to get the option array.
@retval EFI_INVALID_PARAMETER The parametera are invalid or packet isn't a
- well-formated OACK packet.
+ well-formatted OACK packet.
@retval EFI_SUCCESS The option array is build
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory for the array
diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Support.h b/NetworkPkg/Mtftp4Dxe/Mtftp4Support.h
index cfa7582faa4b..95e9bad43ef1 100644
--- a/NetworkPkg/Mtftp4Dxe/Mtftp4Support.h
+++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Support.h
@@ -28,7 +28,7 @@ typedef struct {
RRQ and WRQ have different requirements for Start and End.
For example, during start up, WRQ initializes its whole valid block range
- to [0, 0xffff]. This is bacause the server will send us a ACK0 to inform us
+ to [0, 0xffff]. This is because the server will send us a ACK0 to
+ inform us
to start the upload. When the client received ACK0, it will remove 0 from the
range, get the next block number, which is 1, then upload the BLOCK1. For RRQ
without option negotiation, the server will directly send us the BLOCK1 in diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c b/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c
index 06c4e202d3ef..a795d262473e 100644
--- a/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c
+++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c
@@ -30,7 +30,7 @@ EFI_SERVICE_BINDING_PROTOCOL gMtftp4ServiceBindingTemplete = {
@param SystemTable The system table.
@retval EFI_SUCCESS The handles are successfully installed on the image.
- @retval others some EFI_ERROR occured.
+ @retval others some EFI_ERROR occurred.
**/
EFI_STATUS
@@ -632,7 +632,7 @@ ON_ERROR:
@param This The service binding instance
@param ChildHandle The child handle to destroy
- @retval EFI_INVALID_PARAMETER The parameter is invaid.
+ @retval EFI_INVALID_PARAMETER The parameter is invalid.
@retval EFI_UNSUPPORTED The child may have already been destroyed.
@retval EFI_SUCCESS The child is destroyed and removed from the
parent's child list.
diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Impl.c b/NetworkPkg/Mtftp4Dxe/Mtftp4Impl.c
index 70bd693e4e3a..990a9ef03027 100644
--- a/NetworkPkg/Mtftp4Dxe/Mtftp4Impl.c
+++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Impl.c
@@ -226,7 +226,7 @@ Mtftp4OverrideValid (
@param UdpCfgData The UDP configure data to reconfigure the UDP_IO
@retval TRUE The default address is retrieved and UDP is reconfigured.
- @retval FALSE Some error occured.
+ @retval FALSE Some error occurred.
**/
BOOLEAN
@@ -342,7 +342,7 @@ Mtftp4ConfigUnicastPort (
write file, and read directory.
@param This The MTFTP session
- @param Token The token than encapsues the user's request.
+ @param Token The token than encapsules the user's request.
@param Operation The operation to do
@retval EFI_INVALID_PARAMETER Some of the parameters are invalid.
@@ -601,9 +601,9 @@ EfiMtftp4GetModeData (
2.MtftpConfigData.UseDefaultSetting is FALSE and
MtftpConfigData.StationIp is not a valid IPv4
unicast address.
- 3.MtftpCofigData.UseDefaultSetting is FALSE and
+ 3.MtftpConfigData.UseDefaultSetting is
+ FALSE and
MtftpConfigData.SubnetMask is invalid.
- 4.MtftpCofigData.ServerIp is not a valid IPv4
+ 4.MtftpConfigData.ServerIp is not a
+ valid IPv4
unicast address.
5.MtftpConfigData.UseDefaultSetting is FALSE and
MtftpConfigData.GatewayIp is not a valid IPv4 @@ -946,7 +946,7 @@ EfiMtftp4ReadDirectory (
or ICMP ERROR packet. Retries occur only if no response packets are received
from the MTFTPv4 server before the timeout expires.
It is implemented with EfiMtftp4ReadFile: build a token, then pass it to
- EfiMtftp4ReadFile. In its check packet callback abort the opertions.
+ EfiMtftp4ReadFile. In its check packet callback abort the operations.
@param This Pointer to the EFI_MTFTP4_PROTOCOL instance
@param OverrideData Data that is used to override the existing
diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.c b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.c
index 013fe008eee8..21c1e421392b 100644
--- a/NetworkPkg/Mtftp4Dxe/Mtftp4Option.c
+++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Option.c
@@ -18,13 +18,13 @@ CHAR8 *mMtftp4SupportedOptions[MTFTP4_SUPPORTED_OPTIONS] = {
/**
- Check whether two ascii strings are equel, ignore the case.
+ Check whether two ascii strings are equal, ignore the case.
@param Str1 The first ascii string
@param Str2 The second ascii string
@retval TRUE Two strings are equal when case is ignored.
- @retval FALSE Two string are not equal.
+ @retval FALSE Two strings are not equal.
**/
BOOLEAN
@@ -93,7 +93,7 @@ NetStringToU32 (
Convert a string of the format "192.168.0.1" to an IP address.
@param Str The string representation of IP
- @param Ip The varible to get IP.
+ @param Ip The variable to get IP.
@retval EFI_INVALID_PARAMETER The IP string is invalid.
@retval EFI_SUCCESS The IP is parsed into the Ip
@@ -126,7 +126,7 @@ NetStringToIp (
Addr = (Addr << 8) | Byte;
//
- // Skip all the digitals and check whether the sepeator is the dot
+ // Skip all the digitals and check whether the separator is the dot
//
while (NET_IS_DIGIT (*Str)) {
Str++;
@@ -230,7 +230,7 @@ Mtftp4FillOptions (
@param OptionList The point to get the option array.
@retval EFI_INVALID_PARAMETER The parametera are invalid or packet isn't a
- well-formated OACK packet.
+ well-formatted OACK packet.
@retval EFI_SUCCESS The option array is build
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory for the array
@@ -314,7 +314,7 @@ Mtftp4ExtractMcast (
UINT32 Num;
//
- // The multicast option is formated like "204.0.0.1,1857,1"
+ // The multicast option is formatted like "204.0.0.1,1857,1"
// The server can also omit the ip and port, use ",,1"
//
if (*Value == ',') {
@@ -461,7 +461,7 @@ Mtftp4ParseOption (
} else if (NetStringEqualNoCase (This->OptionStr, (UINT8 *) "multicast")) {
//
// Multicast option, if it is a request, the value must be a zero
- // length string, otherwise, it is formated like "204.0.0.1,1857,1\0"
+ // length string, otherwise, it is formatted like "204.0.0.1,1857,1\0"
//
if (Request) {
if (*(This->ValueStr) != '\0') { diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c b/NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c
index 8e1338221b12..f1d456a6122d 100644
--- a/NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c
+++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c
@@ -34,7 +34,7 @@ Mtftp4RrqInput (
Start the MTFTP session to download.
It will first initialize some of the internal states then build and send a RRQ
- reqeuest packet, at last, it will start receive for the downloading.
+ request packet, at last, it will start receive for the downloading.
@param Instance The Mtftp session
@param Operation The MTFTP opcode, it may be a EFI_MTFTP4_OPCODE_RRQ
@@ -55,7 +55,7 @@ Mtftp4RrqStart (
//
// The valid block number range are [1, 0xffff]. For example:
// the client sends an RRQ request to the server, the server
- // transfers the DATA1 block. If option negoitation is ongoing,
+ // transfers the DATA1 block. If option negotiation is ongoing,
// the server will send back an OACK, then client will send ACK0.
//
Status = Mtftp4InitBlockRange (&Instance->Blocks, 1, 0xffff); @@ -544,8 +544,8 @@ Mtftp4RrqHandleOack (
//
// Save the multicast info. Always update the Master, only update the
- // multicast IP address, block size, window size, timeoute at the first time. If IP
- // address is updated, create a UDP child to receive the multicast.
+ // multicast IP address, block size, window size, timeout at the first time.
+ // If IP address is updated, create a UDP child to receive the multicast.
//
Instance->Master = Reply.Master;
diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Support.c b/NetworkPkg/Mtftp4Dxe/Mtftp4Support.c
index ad2ff7bf3a3f..6ca4842107df 100644
--- a/NetworkPkg/Mtftp4Dxe/Mtftp4Support.c
+++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Support.c
@@ -46,7 +46,7 @@ Mtftp4AllocateRange (
RRQ and WRQ have different requirements for Start and End.
For example, during start up, WRQ initializes its whole valid block range
- to [0, 0xffff]. This is bacause the server will send us a ACK0 to inform us
+ to [0, 0xffff]. This is because the server will send us a ACK0 to
+ inform us
to start the upload. When the client received ACK0, it will remove 0 from the
range, get the next block number, which is 1, then upload the BLOCK1. For RRQ
without option negotiation, the server will directly send us the BLOCK1 in @@ -197,7 +197,7 @@ Mtftp4RemoveBlockNum (
// 3. (Start < Num) && (End >= Num):
// if End == Num, only need to decrease the End by one because
// we have (Start < Num) && (Num == End), so (Start <= End - 1).
- // if (End > Num), the hold is splited into two holes, with
+ // if (End > Num), the hold is split into two holes, with
// [Start, Num - 1] and [Num + 1, End].
//
if (Range->Start > Num) {
@@ -649,7 +649,7 @@ Mtftp4OnTimerTick (
}
//
- // Retransmit the packet if haven't reach the maxmium retry count,
+ // Retransmit the packet if haven't reach the maximum retry count,
// otherwise exit the transfer.
//
if (++Instance->CurRetry < Instance->MaxRetry) { diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c b/NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c
index bd13244b999b..5d479fad4e7c 100644
--- a/NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c
+++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c
@@ -171,7 +171,7 @@ Mtftp4WrqHandleAck (
if (Expected < 0) {
//
- // The block range is empty. It may either because the the last
+ // The block range is empty. It may either because the last
// block has been ACKed, or the sequence number just looped back,
// that is, there is more than 0xffff blocks.
//
@@ -245,11 +245,11 @@ Mtftp4WrqOackValid (
@param Instance The MTFTP session
@param Packet The received OACK packet
@param Len The length of the packet
- @param Completed Whether the transmisson has completed. NOT used by
+ @param Completed Whether the transmission has completed. NOT used by
this function.
@retval EFI_SUCCESS The OACK process is OK
- @retval EFI_TFTP_ERROR Some error occured, and the session reset.
+ @retval EFI_TFTP_ERROR Some error occurred, and the session reset.
**/
EFI_STATUS
--
2.21.0
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
^ permalink raw reply related [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-53-philmd@redhat.com>]
* Re: [PATCH 52/79] NetworkPkg/Udp4Dxe: Fix various typos
[not found] ` <20191203161602.15969-53-philmd@redhat.com>
@ 2019-12-06 16:02 ` Rabeda, Maciej
0 siblings, 0 replies; 122+ messages in thread
From: Rabeda, Maciej @ 2019-12-06 16:02 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Wu, Jiaxin, Fu, Siyuan
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
Thanks!
Maciej
-----Original Message-----
From: Philippe Mathieu-Daude <philmd@redhat.com>
Sent: Tuesday, December 3, 2019 17:16
To: devel@edk2.groups.io
Cc: Antoine Coeur <coeur@gmx.fr>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
Subject: [PATCH 52/79] NetworkPkg/Udp4Dxe: Fix various typos
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/Udp4Dxe/Udp4Driver.h | 4 ++--
NetworkPkg/Udp4Dxe/Udp4Impl.h | 4 ++--
NetworkPkg/Udp4Dxe/Udp4Driver.c | 4 ++--
NetworkPkg/Udp4Dxe/Udp4Impl.c | 12 ++++++------
NetworkPkg/Udp4Dxe/Udp4Main.c | 4 ++--
5 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/NetworkPkg/Udp4Dxe/Udp4Driver.h b/NetworkPkg/Udp4Dxe/Udp4Driver.h index 4e9a0c73565a..741c839d57df 100644
--- a/NetworkPkg/Udp4Dxe/Udp4Driver.h
+++ b/NetworkPkg/Udp4Dxe/Udp4Driver.h
@@ -105,7 +105,7 @@ Udp4DriverBindingStop (
then a new handle is created. If it is a pointer to an existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child @@ -129,7 +129,7 @@ Udp4ServiceBindingCreateChild (
@param[in] This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param[in] ChildHandle Handle of the child to destroy
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
diff --git a/NetworkPkg/Udp4Dxe/Udp4Impl.h b/NetworkPkg/Udp4Dxe/Udp4Impl.h index a5dd1ecabe5f..115f9ed878ac 100644
--- a/NetworkPkg/Udp4Dxe/Udp4Impl.h
+++ b/NetworkPkg/Udp4Dxe/Udp4Impl.h
@@ -440,7 +440,7 @@ Udp4CleanService (
);
/**
- This function intializes the new created udp instance.
+ This function initializes the new created udp instance.
@param[in] Udp4Service Pointer to the UDP4_SERVICE_DATA.
@param[in, out] Instance Pointer to the un-initialized UDP4_INSTANCE_DATA.
@@ -574,7 +574,7 @@ Udp4TokenExist (
pseudo HeadSum to reduce some overhead.
@param[in] Packet Pointer to the NET_BUF contains the udp datagram.
- @param[in] HeadSum Checksum of the pseudo header execpt the length
+ @param[in] HeadSum Checksum of the pseudo header except the length
field.
@retval The 16-bit checksum of this udp datagram.
diff --git a/NetworkPkg/Udp4Dxe/Udp4Driver.c b/NetworkPkg/Udp4Dxe/Udp4Driver.c index 63b103b8efcc..44032682e2b8 100644
--- a/NetworkPkg/Udp4Dxe/Udp4Driver.c
+++ b/NetworkPkg/Udp4Dxe/Udp4Driver.c
@@ -286,7 +286,7 @@ Udp4DriverBindingStop (
then a new handle is created. If it is a pointer to an existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child @@ -421,7 +421,7 @@ ON_ERROR:
@param[in] This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param[in] ChildHandle Handle of the child to destroy
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
diff --git a/NetworkPkg/Udp4Dxe/Udp4Impl.c b/NetworkPkg/Udp4Dxe/Udp4Impl.c index fb1951fb1357..dc2a324c1181 100644
--- a/NetworkPkg/Udp4Dxe/Udp4Impl.c
+++ b/NetworkPkg/Udp4Dxe/Udp4Impl.c
@@ -119,7 +119,7 @@ Udp4CancelTokens (
@param[in] Udp4Session Pointer to the EFI_UDP4_SESSION_DATA abstracted
from the received udp datagram.
- @retval TRUE The udp datagram matches the receiving requirments of the
+ @retval TRUE The udp datagram matches the receiving requirements of the
udp Instance.
@retval FALSE Otherwise.
@@ -439,7 +439,7 @@ Udp4CheckTimeout (
/**
- This function intializes the new created udp instance.
+ This function initializes the new created udp instance.
@param[in] Udp4Service Pointer to the UDP4_SERVICE_DATA.
@param[in, out] Instance Pointer to the un-initialized UDP4_INSTANCE_DATA.
@@ -851,7 +851,7 @@ Udp4ValidateTxToken (
if ((UdpSessionData->DestinationPort == 0) && (ConfigData->RemotePort == 0)) {
//
- // Ambiguous, no avalaible DestinationPort for this token.
+ // Ambiguous, no available DestinationPort for this token.
//
return EFI_INVALID_PARAMETER;
}
@@ -864,7 +864,7 @@ Udp4ValidateTxToken (
}
} else if (EFI_IP4_EQUAL (&ConfigData->RemoteAddress, &mZeroIp4Addr)) {
//
- // the configured RemoteAddress is all zero, and the user doens't override the
+ // the configured RemoteAddress is all zero, and the user doesn't
+ override the
// destination address.
//
return EFI_INVALID_PARAMETER;
@@ -922,7 +922,7 @@ Udp4TokenExist (
pseudo HeadSum to reduce some overhead.
@param[in] Packet Pointer to the NET_BUF contains the udp datagram.
- @param[in] HeadSum Checksum of the pseudo header execpt the length
+ @param[in] HeadSum Checksum of the pseudo header except the length
field.
@retval The 16-bit checksum of this udp datagram.
@@ -1264,7 +1264,7 @@ Udp4InstanceCancelToken (
@param[in] Udp4Session Pointer to the EFI_UDP4_SESSION_DATA abstracted
from the received udp datagram.
- @retval TRUE The udp datagram matches the receiving requirments of the
+ @retval TRUE The udp datagram matches the receiving requirements of the
udp Instance.
@retval FALSE Otherwise.
diff --git a/NetworkPkg/Udp4Dxe/Udp4Main.c b/NetworkPkg/Udp4Dxe/Udp4Main.c index aa1956cd4b42..2a639f954726 100644
--- a/NetworkPkg/Udp4Dxe/Udp4Main.c
+++ b/NetworkPkg/Udp4Dxe/Udp4Main.c
@@ -367,7 +367,7 @@ Udp4Groups (
// Keep a local copy of the configured multicast IPs because IpIo receives
// datagrams from the 0 station address IP instance and then UDP delivers to
// the matched instance. This copy of multicast IPs is used to avoid receive
- // the mutlicast datagrams destined to multicast IPs the other instances configured.
+ // the multicast datagrams destined to multicast IPs the other instances configured.
//
if (JoinFlag) {
@@ -844,7 +844,7 @@ Udp4Cancel (
OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
//
- // Cancle the tokens specified by Token for this instance.
+ // Cancel the tokens specified by Token for this instance.
//
Status = Udp4InstanceCancelToken (Instance, Token);
--
2.21.0
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
^ permalink raw reply [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-54-philmd@redhat.com>]
* Re: [PATCH 53/79] NetworkPkg/Udp6Dxe: Fix various typos
[not found] ` <20191203161602.15969-54-philmd@redhat.com>
@ 2019-12-06 16:03 ` Rabeda, Maciej
0 siblings, 0 replies; 122+ messages in thread
From: Rabeda, Maciej @ 2019-12-06 16:03 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Wu, Jiaxin, Fu, Siyuan
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
Thanks!
Maciej
-----Original Message-----
From: Philippe Mathieu-Daude <philmd@redhat.com>
Sent: Tuesday, December 3, 2019 17:16
To: devel@edk2.groups.io
Cc: Antoine Coeur <coeur@gmx.fr>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
Subject: [PATCH 53/79] NetworkPkg/Udp6Dxe: Fix various typos
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/Udp6Dxe/Udp6Driver.h | 6 +++---
NetworkPkg/Udp6Dxe/Udp6Impl.h | 12 ++++++------
NetworkPkg/Udp6Dxe/Udp6Driver.c | 8 ++++----
NetworkPkg/Udp6Dxe/Udp6Impl.c | 18 +++++++++---------
NetworkPkg/Udp6Dxe/Udp6Main.c | 12 ++++++------
5 files changed, 28 insertions(+), 28 deletions(-)
diff --git a/NetworkPkg/Udp6Dxe/Udp6Driver.h b/NetworkPkg/Udp6Dxe/Udp6Driver.h index a08623979e86..577cebd5b1fd 100644
--- a/NetworkPkg/Udp6Dxe/Udp6Driver.h
+++ b/NetworkPkg/Udp6Dxe/Udp6Driver.h
@@ -78,7 +78,7 @@ Udp6DriverBindingSupported (
@param[in] RemainingDevicePath Optional parameter use to pick a specific child
device to start.
- @retval EFI_SUCCES This driver is added to ControllerHandle.
+ @retval EFI_SUCCESS This driver is added to ControllerHandle.
@retval EFI_OUT_OF_RESOURCES The required system resource can't be allocated.
@retval other This driver does not support this device.
@@ -132,7 +132,7 @@ Udp6DriverBindingStop (
then a new handle is created. If it is a pointer to an existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER This is NULL or ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child.
@@ -155,7 +155,7 @@ Udp6ServiceBindingCreateChild (
@param[in] This Protocol instance pointer.
@param[in] ChildHandle Handle of the child to destroy.
- @retval EFI_SUCCES The I/O services were removed from the child
+ @retval EFI_SUCCESS The I/O services were removed from the child
handle.
@retval EFI_UNSUPPORTED The child handle does not support the I/O services
that are being removed.
diff --git a/NetworkPkg/Udp6Dxe/Udp6Impl.h b/NetworkPkg/Udp6Dxe/Udp6Impl.h index 5ccbcebfdff1..55a4b8a909be 100644
--- a/NetworkPkg/Udp6Dxe/Udp6Impl.h
+++ b/NetworkPkg/Udp6Dxe/Udp6Impl.h
@@ -151,7 +151,7 @@ Udp6CleanInstance (
);
/**
- This function intializes the new created udp instance.
+ This function initializes the new created udp instance.
@param[in] Udp6Service Pointer to the UDP6_SERVICE_DATA.
@param[in, out] Instance Pointer to the un-initialized UDP6_INSTANCE_DATA.
@@ -221,7 +221,7 @@ Udp6GetModeData (
@retval EFI_SUCCESS The configuration settings were set, changed, or
reset successfully.
- @retval EFI_NO_MAPPING When the UdpConifgData.UseAnyStationAddress is set
+ @retval EFI_NO_MAPPING When the UdpConfigData.UseAnyStationAddress is set
to true and there is no address available for IP6
driver to binding source address to this
instance.
@@ -281,12 +281,12 @@ Udp6Configure (
.FragmentBuffer fields is NULL.
One or more of the
Token.Packet.TxData.UdpSessionData.
- DestinationAddres are not valid unicast IPv6
+ DestinationAddress are not valid
+ unicast IPv6
addresses, if the UdpSessionData is not NULL.
Token.Packet.TxData.UdpSessionData.
- DestinationAddres is NULL
+ DestinationAddress is NULL
Token.Packet.TxData.UdpSessionData.
- DestinatioPort is zero.
+ DestinationPort is zero.
Token.Packet.TxData.UdpSessionData is
NULL and this instance's
UdpConfigData.RemoteAddress is unspecified.
@@ -430,7 +430,7 @@ Udp6Groups (
/**
This function tries to bind the udp instance according to the configured port
- allocation stragety.
+ allocation strategy.
@param[in] InstanceList Pointer to the head of the list linking the udp
instances.
diff --git a/NetworkPkg/Udp6Dxe/Udp6Driver.c b/NetworkPkg/Udp6Dxe/Udp6Driver.c index 5334fd17343b..6021bb36993a 100644
--- a/NetworkPkg/Udp6Dxe/Udp6Driver.c
+++ b/NetworkPkg/Udp6Dxe/Udp6Driver.c
@@ -117,7 +117,7 @@ Udp6DriverBindingSupported (
@param[in] RemainingDevicePath Optional parameter use to pick a specific child
device to start.
- @retval EFI_SUCCES This driver is added to ControllerHandle.
+ @retval EFI_SUCCESS This driver is added to ControllerHandle.
@retval EFI_OUT_OF_RESOURCES The required system resource can't be allocated.
@retval other This driver does not support this device.
@@ -223,7 +223,7 @@ Udp6DestroyChildEntryInHandleBuffer (
of children is zero stop the entire bus driver.
@param[in] ChildHandleBuffer List of Child Handles to Stop. It is optional.
- @retval EFI_SUCCES This driver is removed ControllerHandle.
+ @retval EFI_SUCCESS This driver is removed ControllerHandle.
@retval EFI_DEVICE_ERROR Can't find the NicHandle from the ControllerHandle and specified GUID.
@retval other This driver was not removed from this device.
@@ -310,7 +310,7 @@ Udp6DriverBindingStop (
then a new handle is created. If it is a pointer to an existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER This is NULL or ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child.
@@ -443,7 +443,7 @@ ON_ERROR:
@param[in] This Protocol instance pointer.
@param[in] ChildHandle Handle of the child to destroy.
- @retval EFI_SUCCES The I/O services were removed from the child
+ @retval EFI_SUCCESS The I/O services were removed from the child
handle.
@retval EFI_UNSUPPORTED The child handle does not support the I/O services
that are being removed.
diff --git a/NetworkPkg/Udp6Dxe/Udp6Impl.c b/NetworkPkg/Udp6Dxe/Udp6Impl.c index aefcd3396c85..ba939fdbfc31 100644
--- a/NetworkPkg/Udp6Dxe/Udp6Impl.c
+++ b/NetworkPkg/Udp6Dxe/Udp6Impl.c
@@ -96,7 +96,7 @@ Udp6DgramRcvd (
);
/**
- This function cancle the token specified by Arg in the Map.
+ This function cancel the token specified by Arg in the Map.
@param[in] Map Pointer to the NET_MAP.
@param[in] Item Pointer to the NET_MAP_ITEM.
@@ -458,7 +458,7 @@ Udp6CheckTimeout (
/**
- This function intializes the new created udp instance.
+ This function initializes the new created udp instance.
@param[in] Udp6Service Pointer to the UDP6_SERVICE_DATA.
@param[in, out] Instance Pointer to the un-initialized UDP6_INSTANCE_DATA.
@@ -575,7 +575,7 @@ Udp6FindInstanceByPort (
/**
This function tries to bind the udp instance according to the configured port
- allocation stragety.
+ allocation strategy.
@param[in] InstanceList Pointer to the head of the list linking the udp
instances.
@@ -832,7 +832,7 @@ Udp6ValidateTxToken (
if ((UdpSessionData->DestinationPort == 0) && (ConfigData->RemotePort == 0)) {
//
- // Ambiguous; no avalaible DestinationPort for this token.
+ // Ambiguous; no available DestinationPort for this token.
//
return EFI_INVALID_PARAMETER;
}
@@ -841,7 +841,7 @@ Udp6ValidateTxToken (
NetIp6IsUnspecifiedAddr (&ConfigData->RemoteAddress)
) {
//
- // The DestinationAddress is not specificed.
+ // The DestinationAddress is not specified.
//
return EFI_INVALID_PARAMETER;
}
@@ -915,7 +915,7 @@ Udp6TokenExist (
pseudo HeadSum to reduce some overhead.
@param[in] Packet Pointer to the NET_BUF contains the udp datagram.
- @param[in] HeadSum Checksum of the pseudo header, execpt the length
+ @param[in] HeadSum Checksum of the pseudo header, except the length
field.
@return The 16-bit checksum of this udp datagram.
@@ -1123,7 +1123,7 @@ Udp6LeaveGroup (
/**
- This function cancle the token specified by Arg in the Map.
+ This function cancel the token specified by Arg in the Map.
@param[in] Map Pointer to the NET_MAP.
@param[in] Item Pointer to the NET_MAP_ITEM.
@@ -1276,7 +1276,7 @@ Udp6InstanceCancelToken (
from the received udp datagram.
@retval TRUE The udp datagram matches the receiving requirements of the Instance.
- @retval FALSE The udp datagram does not matche the receiving requirements of the Instance.
+ @retval FALSE The udp datagram does not match the receiving requirements of the Instance.
**/
BOOLEAN
@@ -1814,7 +1814,7 @@ Udp6SendPortUnreach (
);
//
- // Set the checksum as zero, and IP6 driver will calcuate it with pseudo header.
+ // Set the checksum as zero, and IP6 driver will calculate it with pseudo header.
//
IcmpErrHdr->Head.Checksum = 0;
diff --git a/NetworkPkg/Udp6Dxe/Udp6Main.c b/NetworkPkg/Udp6Dxe/Udp6Main.c index 0829b7b2a697..a33eb3c8cfde 100644
--- a/NetworkPkg/Udp6Dxe/Udp6Main.c
+++ b/NetworkPkg/Udp6Dxe/Udp6Main.c
@@ -104,7 +104,7 @@ Udp6GetModeData (
@retval EFI_SUCCESS The configuration settings were set, changed, or
reset successfully.
- @retval EFI_NO_MAPPING When the UdpConifgData.UseAnyStationAddress is set
+ @retval EFI_NO_MAPPING When the UdpConfigData.UseAnyStationAddress is set
to true and there is no address available for the IP6
driver to bind a source address to this instance.
@retval EFI_INVALID_PARAMETER One or more following conditions are TRUE:
@@ -368,7 +368,7 @@ Udp6Groups (
// Keep a local copy of the configured multicast IPs because IpIo receives
// datagrams from the 0 station address IP instance and then UDP delivers to
// the matched instance. This copy of multicast IPs is used to avoid receive
- // the mutlicast datagrams destinated to multicast IPs the other instances configured.
+ // the multicast datagrams destinated to multicast IPs the other instances configured.
//
if (JoinFlag) {
@@ -423,13 +423,13 @@ ON_EXIT:
One or more of the
Token.Packet.TxData.FragmentTable[].FragmentBuffer
fields is NULL. One or more of the
- Token.Packet.TxData.UdpSessionData.DestinationAddres
+
+ Token.Packet.TxData.UdpSessionData.DestinationAddress
are not valid unicast IPv6
addresses if the UdpSessionData is not NULL.
Token.Packet.TxData.UdpSessionData.
DestinationAddress is NULL
Token.Packet.TxData.UdpSessionData.
- DestinatioPort
+ DestinationPort
is zero.
Token.Packet.TxData.UdpSessionData is NULL and this
instance's UdpConfigData.RemoteAddress is unspecified.
@@ -586,7 +586,7 @@ Udp6Transmit (
}
} else {
//
- // Set the checksum is zero if the ConfigData->StationAddress is unspcified
+ // Set the checksum is zero if the ConfigData->StationAddress is
+ unspecified
// and the Ipv6 will fill the correct value of this checksum.
//
Udp6Header->Checksum = 0;
@@ -807,7 +807,7 @@ Udp6Cancel (
OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
//
- // Cancle the tokens specified by Token for this instance.
+ // Cancel the tokens specified by Token for this instance.
//
Status = Udp6InstanceCancelToken (Instance, Token);
--
2.21.0
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
^ permalink raw reply [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-43-philmd@redhat.com>]
* Re: [PATCH 42/79] NetworkPkg/Ip6Dxe: Fix various typos
[not found] ` <20191203161602.15969-43-philmd@redhat.com>
@ 2019-12-06 16:03 ` Rabeda, Maciej
0 siblings, 0 replies; 122+ messages in thread
From: Rabeda, Maciej @ 2019-12-06 16:03 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Wu, Jiaxin, Fu, Siyuan
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
Thanks!
Maciej
-----Original Message-----
From: Philippe Mathieu-Daude <philmd@redhat.com>
Sent: Tuesday, December 3, 2019 17:15
To: devel@edk2.groups.io
Cc: Antoine Coeur <coeur@gmx.fr>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
Subject: [PATCH 42/79] NetworkPkg/Ip6Dxe: Fix various typos
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/Ip6Dxe/Ip6ConfigImpl.h | 4 ++--
NetworkPkg/Ip6Dxe/Ip6Driver.h | 8 ++++----
NetworkPkg/Ip6Dxe/Ip6If.h | 4 ++--
NetworkPkg/Ip6Dxe/Ip6Impl.h | 8 ++++----
NetworkPkg/Ip6Dxe/Ip6Input.h | 6 +++---
NetworkPkg/Ip6Dxe/Ip6Mld.h | 2 +-
NetworkPkg/Ip6Dxe/Ip6Nd.h | 4 ++--
NetworkPkg/Ip6Dxe/Ip6Route.h | 10 +++++-----
NetworkPkg/Ip6Dxe/Ip6Common.c | 2 +-
NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c | 10 +++++-----
NetworkPkg/Ip6Dxe/Ip6ConfigNv.c | 6 +++---
NetworkPkg/Ip6Dxe/Ip6Driver.c | 12 ++++++------
NetworkPkg/Ip6Dxe/Ip6Icmp.c | 2 +-
NetworkPkg/Ip6Dxe/Ip6If.c | 10 +++++-----
NetworkPkg/Ip6Dxe/Ip6Impl.c | 10 +++++-----
NetworkPkg/Ip6Dxe/Ip6Input.c | 20 ++++++++++----------
NetworkPkg/Ip6Dxe/Ip6Mld.c | 8 ++++----
NetworkPkg/Ip6Dxe/Ip6Nd.c | 12 ++++++------
NetworkPkg/Ip6Dxe/Ip6Output.c | 2 +-
NetworkPkg/Ip6Dxe/Ip6Route.c | 6 +++---
20 files changed, 73 insertions(+), 73 deletions(-)
diff --git a/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.h b/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.h
index bfe3bbe53875..1c2eede2ab21 100644
--- a/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.h
+++ b/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.h
@@ -1,5 +1,5 @@
/** @file
- Definitions for EFI IPv6 Configuartion Protocol implementation.
+ Definitions for EFI IPv6 Configuration Protocol implementation.
Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
@@ -210,7 +210,7 @@ struct _IP6_CONFIG_INSTANCE {
/**
Read the configuration data from variable storage according to the VarName and
gEfiIp6ConfigProtocolGuid. It checks the integrity of variable data. If the
- data is corrupted, it clears the variable data to ZERO. Othewise, it outputs the
+ data is corrupted, it clears the variable data to ZERO. Otherwise, it
+ outputs the
configuration data to IP6_CONFIG_INSTANCE.
@param[in] VarName The pointer to the variable name
diff --git a/NetworkPkg/Ip6Dxe/Ip6Driver.h b/NetworkPkg/Ip6Dxe/Ip6Driver.h index b048dafdccc5..007f687c6e25 100644
--- a/NetworkPkg/Ip6Dxe/Ip6Driver.h
+++ b/NetworkPkg/Ip6Dxe/Ip6Driver.h
@@ -66,7 +66,7 @@ Ip6DriverEntryPoint (
);
//
-// Function prototypes for the Drivr Binding Protocol
+// Function prototypes for the Driver Binding Protocol
//
/**
@@ -98,7 +98,7 @@ Ip6DriverBindingSupported (
@param[in] RemainingDevicePath Optional parameter used to pick a specific child
device to start.
- @retval EFI_SUCCES This driver is added to ControllerHandle.
+ @retval EFI_SUCCESS This driver is added to ControllerHandle.
@retval EFI_ALREADY_STARTED This driver is already running on ControllerHandle.
@retval other This driver does not support this device.
@@ -147,7 +147,7 @@ Ip6DriverBindingStop (
is not NULL, then the I/O services are added to
the existing child handle.
- @retval EFI_SUCCES The child handle was created with the I/O services.
+ @retval EFI_SUCCESS The child handle was created with the I/O services.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child.
@retval other The child handle was not created.
@@ -166,7 +166,7 @@ Ip6ServiceBindingCreateChild (
@param[in] This Protocol instance pointer.
@param[in] ChildHandle Handle of the child to destroy.
- @retval EFI_SUCCES The I/O services were removed from the child
+ @retval EFI_SUCCESS The I/O services were removed from the child
handle.
@retval EFI_UNSUPPORTED The child handle does not support the I/O services
that are being removed.
diff --git a/NetworkPkg/Ip6Dxe/Ip6If.h b/NetworkPkg/Ip6Dxe/Ip6If.h index a8af4322eb93..ab43d8ea592a 100644
--- a/NetworkPkg/Ip6Dxe/Ip6If.h
+++ b/NetworkPkg/Ip6Dxe/Ip6If.h
@@ -1,5 +1,5 @@
/** @file
- Definition for IP6 pesudo interface structure.
+ Definition for IP6 pseudo interface structure.
Copyright (c) 2009 - 2010, Intel Corporation. All rights reserved.<BR>
@@ -203,7 +203,7 @@ Ip6OnFrameReceived (
@retval EFI_ALREADY_STARTED There is already a pending receive request.
@retval EFI_OUT_OF_RESOURCES Failed to allocate resources to receive.
- @retval EFI_SUCCESS The recieve request has been started.
+ @retval EFI_SUCCESS The receive request has been started.
**/
EFI_STATUS
diff --git a/NetworkPkg/Ip6Dxe/Ip6Impl.h b/NetworkPkg/Ip6Dxe/Ip6Impl.h index d46ee600d5cc..8919e9448900 100644
--- a/NetworkPkg/Ip6Dxe/Ip6Impl.h
+++ b/NetworkPkg/Ip6Dxe/Ip6Impl.h
@@ -139,7 +139,7 @@ struct _IP6_PROTOCOL {
UINT8 PrefixLength; // PrefixLength of the configured station address.
//
- // User's transmit/receive tokens, and received/deliverd packets
+ // User's transmit/receive tokens, and received/delivered packets
//
NET_MAP RxTokens;
NET_MAP TxTokens; // map between (User's Token, IP6_TXTOKE_WRAP)
@@ -412,7 +412,7 @@ EfiIp6GetModeData (
@retval EFI_DEVICE_ERROR An unexpected system or network error occurred. The EFI IPv6
Protocol driver instance was not opened.
@retval EFI_UNSUPPORTED Default protocol specified through
- Ip6ConfigData.DefaulProtocol isn't supported.
+ Ip6ConfigData.DefaultProtocol isn't supported.
**/
EFI_STATUS
@@ -470,7 +470,7 @@ EfiIp6Groups (
the destination IPv6 address arithmetically. The gateway address must be on the same subnet as the
configured station address.
- The default route is added with Destination and PrefixLegth both set to all zeros. The
+ The default route is added with Destination and PrefixLength both set
+ to all zeros. The
default route matches all destination IPv6 addresses that do not match any other routes.
All EFI IPv6 Protocol instances share a routing table.
@@ -642,7 +642,7 @@ EfiIp6Transmit (
is signaled.
Current Udp implementation creates an IP child for each Udp child.
- It initates a asynchronous receive immediately whether or not
+ It initiates a asynchronous receive immediately whether or not
there is no mapping. Therefore, disable the returning EFI_NO_MAPPING for now.
To enable it, the following check must be performed:
diff --git a/NetworkPkg/Ip6Dxe/Ip6Input.h b/NetworkPkg/Ip6Dxe/Ip6Input.h index 66ddf35ea4a6..76a4edb54c3c 100644
--- a/NetworkPkg/Ip6Dxe/Ip6Input.h
+++ b/NetworkPkg/Ip6Dxe/Ip6Input.h
@@ -149,7 +149,7 @@ Ip6InstanceDeliverPacket (
@retval EFI_SUCCESS The packet was bypassed, and all buffers remain the same.
@retval EFI_SUCCESS The packet was protected.
@retval EFI_ACCESS_DENIED The packet was discarded.
- @retval EFI_OUT_OF_RESOURCES There are not suffcient resources to complete the operation.
+ @retval EFI_OUT_OF_RESOURCES There are not sufficient resources to complete the operation.
@retval EFI_BUFFER_TOO_SMALL The number of non-empty blocks is bigger than the
number of input data blocks when building a fragment table.
@@ -192,11 +192,11 @@ Ip6CleanAssembleTable (
/**
Demultiple the packet. the packet delivery is processed in two
- passes. The first pass will enque a shared copy of the packet
+ passes. The first pass will enqueue a shared copy of the packet
to each IP6 child that accepts the packet. The second pass will
deliver a non-shared copy of the packet to each IP6 child that
has pending receive requests. Data is copied if more than one
- child wants to consume the packet bacause each IP child need
+ child wants to consume the packet because each IP child need
its own copy of the packet to make changes.
@param[in] IpSb The IP6 service instance that received the packet.
diff --git a/NetworkPkg/Ip6Dxe/Ip6Mld.h b/NetworkPkg/Ip6Dxe/Ip6Mld.h index d907a15c6e65..89dd6c21fb64 100644
--- a/NetworkPkg/Ip6Dxe/Ip6Mld.h
+++ b/NetworkPkg/Ip6Dxe/Ip6Mld.h
@@ -124,7 +124,7 @@ Ip6LeaveGroup (
@retval EFI_ALREADY_STARTED Wants to join the group, but is already a member of it.
@retval EFI_OUT_OF_RESOURCES Failed to allocate some resources.
- @retval EFI_DEVICE_ERROR Failed to set the group configuraton.
+ @retval EFI_DEVICE_ERROR Failed to set the group configuration.
@retval EFI_SUCCESS Successfully updated the group setting.
@retval EFI_NOT_FOUND Tried to leave a group of whom it isn't a member.
diff --git a/NetworkPkg/Ip6Dxe/Ip6Nd.h b/NetworkPkg/Ip6Dxe/Ip6Nd.h index 891a32d7d3ca..560dfa343782 100644
--- a/NetworkPkg/Ip6Dxe/Ip6Nd.h
+++ b/NetworkPkg/Ip6Dxe/Ip6Nd.h
@@ -587,7 +587,7 @@ Ip6ProcessRouterAdvertise (
the IP head removed.
@retval EFI_INVALID_PARAMETER The parameter is invalid.
- @retval EFI_OUT_OF_RESOURCES Insuffcient resources to complete the
+ @retval EFI_OUT_OF_RESOURCES Insufficient resources to complete the
operation.
@retval EFI_SUCCESS Successfully updated the route caches.
@@ -705,7 +705,7 @@ Ip6NdFasterTimerTicking (
/**
The heartbeat timer of ND module in 1 second. This time routine handles following
- things: 1) maitain default router list; 2) maintain prefix options;
+ things: 1) maintain default router list; 2) maintain prefix options;
3) maintain route caches.
@param[in] IpSb The IP6 service binding instance.
diff --git a/NetworkPkg/Ip6Dxe/Ip6Route.h b/NetworkPkg/Ip6Dxe/Ip6Route.h index 9ddc1ab7bc53..af20dbb149b0 100644
--- a/NetworkPkg/Ip6Dxe/Ip6Route.h
+++ b/NetworkPkg/Ip6Dxe/Ip6Route.h
@@ -1,5 +1,5 @@
/** @file
- EFI IP6 route table and route cache table defintions.
+ EFI IP6 route table and route cache table definitions.
Copyright (c) 2009 - 2010, Intel Corporation. All rights reserved.<BR>
@@ -110,7 +110,7 @@ Ip6FreeRouteCacheEntry (
/**
Find a route cache with the destination and source address. This is
- used by the ICMPv6 redirect messasge process.
+ used by the ICMPv6 redirect message process.
@param[in] RtTable The route table to search the cache for.
@param[in] Dest The destination address.
@@ -181,7 +181,7 @@ Ip6CleanRouteTable (
@param[in] GatewayAddress The next hop address. This is optional parameter
that may be NULL.
- @return NULL if it failed to allocate memeory. Otherwise, the newly created route entry.
+ @return NULL if it failed to allocate memory. Otherwise, the newly created route entry.
**/
IP6_ROUTE_ENTRY *
@@ -201,7 +201,7 @@ Ip6CreateRouteEntry (
2. The local route entries have precedence over the default route entry.
@param[in] RtTable The route table to search from.
- @param[in] Destination The destionation address to search. If NULL, search
+ @param[in] Destination The destination address to search. If NULL, search
the route table by NextHop.
@param[in] NextHop The next hop address. If NULL, search the route table
by Destination.
@@ -260,7 +260,7 @@ Ip6AddRoute (
@retval EFI_SUCCESS Successfully removed the route entry.
@retval EFI_NOT_FOUND There is no route entry in the table with that
- properity.
+ property.
**/
EFI_STATUS
diff --git a/NetworkPkg/Ip6Dxe/Ip6Common.c b/NetworkPkg/Ip6Dxe/Ip6Common.c index 4ae04f258ffc..840fff0e72e5 100644
--- a/NetworkPkg/Ip6Dxe/Ip6Common.c
+++ b/NetworkPkg/Ip6Dxe/Ip6Common.c
@@ -214,7 +214,7 @@ Ip6CreateLinkLocalAddr (
}
//
- // Get the interface id if it is manully configured.
+ // Get the interface id if it is manually configured.
//
Ip6Config = &IpSb->Ip6ConfigInstance.Ip6Config;
DataSize = sizeof (EFI_IP6_CONFIG_INTERFACE_ID); diff --git a/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c b/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c
index 6efed37a4d04..eb2a80b64f15 100644
--- a/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c
+++ b/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c
@@ -101,7 +101,7 @@ Ip6ConfigOnPolicyChanged (
}
//
- // All IPv6 children that use global unicast address as it's source address
+ // All IPv6 children that use global unicast address as its source
+ address
// should be destroyed now. The survivers are those use the link-local address
// or the unspecified address as the source address.
// TODO: Conduct a check here.
@@ -335,7 +335,7 @@ Ip6ConfigSignalEvent (
/**
Read the configuration data from variable storage according to the VarName and
gEfiIp6ConfigProtocolGuid. It checks the integrity of variable data. If the
- data is corrupted, it clears the variable data to ZERO. Othewise, it outputs the
+ data is corrupted, it clears the variable data to ZERO. Otherwise, it
+ outputs the
configuration data to IP6_CONFIG_INSTANCE.
@param[in] VarName The pointer to the variable name
@@ -612,7 +612,7 @@ Ip6ConfigGetIfInfo ( }
/**
- The work function for EfiIp6ConfigSetData() to set the alternative inteface ID
+ The work function for EfiIp6ConfigSetData() to set the alternative
+ interface ID
for the communication device managed by this IP6Config instance, if the link local
IPv6 addresses generated from the interface ID based on the default source the
EFI IPv6 Protocol uses is a duplicate address.
@@ -915,7 +915,7 @@ Ip6ManualAddrDadCallback (
under the current policy.
@retval EFI_INVALID_PARAMETER One or more fields in Data is invalid.
@retval EFI_OUT_OF_RESOURCES Fail to allocate resource to complete the operation.
- @retval EFI_NOT_READY An asynchrous process is invoked to set the specified
+ @retval EFI_NOT_READY An asynchronous process is invoked to set the specified
configuration data, and the process is not finished.
@retval EFI_ABORTED The manual addresses to be set equal current
configuration.
@@ -2034,7 +2034,7 @@ EfiIp6ConfigSetData (
}
} else {
//
- // Another asynchornous process is on the way.
+ // Another asynchronous process is on the way.
//
Status = EFI_ACCESS_DENIED;
}
diff --git a/NetworkPkg/Ip6Dxe/Ip6ConfigNv.c b/NetworkPkg/Ip6Dxe/Ip6ConfigNv.c index aac665d3d427..a0727d2666e9 100644
--- a/NetworkPkg/Ip6Dxe/Ip6ConfigNv.c
+++ b/NetworkPkg/Ip6Dxe/Ip6ConfigNv.c
@@ -407,7 +407,7 @@ Exit:
/**
This function converts the different format of address list to string format and
- then generates the corresponding text opcode to illustarate the address info in
+ then generates the corresponding text opcode to illustrate the
+ address info in
IP6 configuration page. Currently, the following formats are supported:
EFI_IP6_ADDRESS_INFO AddressType: Ip6ConfigNvHostAddress;
EFI_IPv6_ADDRESS AddressType: Ip6ConfigNvGatewayAddress and Ip6ConfigNvDnsAddress;
@@ -1470,7 +1470,7 @@ Exit:
@param[out] Progress A pointer to a string filled in with the
offset of the most recent '&' before the
first failing name / value pair (or the
- beginn ing of the string if the failure
+ beginning of the string if the failure
is in the first name / value pair) or
the terminating NULL if all was
successful.
@@ -1622,7 +1622,7 @@ Ip6GetCurrentSetting (
}
//
- // Get gateway adderss list.
+ // Get gateway address list.
//
if (Data != NULL) {
FreePool (Data);
diff --git a/NetworkPkg/Ip6Dxe/Ip6Driver.c b/NetworkPkg/Ip6Dxe/Ip6Driver.c index 63d8428dbced..7c13d6a3d4cc 100644
--- a/NetworkPkg/Ip6Dxe/Ip6Driver.c
+++ b/NetworkPkg/Ip6Dxe/Ip6Driver.c
@@ -498,7 +498,7 @@ ON_ERROR:
@param[in] RemainingDevicePath Optional parameter used to pick a specific child
device to start.
- @retval EFI_SUCCES This driver is added to ControllerHandle.
+ @retval EFI_SUCCESS This driver is added to ControllerHandle.
@retval EFI_ALREADY_STARTED This driver is already running on ControllerHandle.
@retval other This driver does not support this device.
@@ -547,7 +547,7 @@ Ip6DriverBindingStart (
Ip6Cfg = &IpSb->Ip6ConfigInstance.Ip6Config;
//
- // Install the Ip6ServiceBinding Protocol onto ControlerHandle
+ // Install the Ip6ServiceBinding Protocol onto ControllerHandle
//
Status = gBS->InstallMultipleProtocolInterfaces (
&ControllerHandle,
@@ -823,7 +823,7 @@ Exit:
is not NULL, then the I/O services are added to
the existing child handle.
- @retval EFI_SUCCES The child handle was created with the I/O services.
+ @retval EFI_SUCCESS The child handle was created with the I/O services.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child.
@retval other The child handle was not created.
@@ -925,7 +925,7 @@ ON_ERROR:
@param[in] This Protocol instance pointer.
@param[in] ChildHandle Handle of the child to destroy.
- @retval EFI_SUCCES The I/O services were removed from the child
+ @retval EFI_SUCCESS The I/O services were removed from the child
handle.
@retval EFI_UNSUPPORTED The child handle does not support the I/O services
that are being removed.
@@ -1005,14 +1005,14 @@ Ip6ServiceBindingDestroyChild (
// Uninstall the IP6 protocol first. Many thing happens during
// this:
// 1. The consumer of the IP6 protocol will be stopped if it
- // opens the protocol BY_DRIVER. For eaxmple, if MNP driver is
+ // opens the protocol BY_DRIVER. For example, if MNP driver is
// stopped, IP driver's stop function will be called, and uninstall
// EFI_IP6_PROTOCOL will trigger the UDP's stop function. This
// makes it possible to create the network stack bottom up, and
// stop it top down.
// 2. the upper layer will recycle the received packet. The recycle
// event's TPL is higher than this function. The recycle events
- // will be called back before preceeding. If any packets not recycled,
+ // will be called back before preceding. If any packets not recycled,
// that means there is a resource leak.
//
gBS->RestoreTPL (OldTpl);
diff --git a/NetworkPkg/Ip6Dxe/Ip6Icmp.c b/NetworkPkg/Ip6Dxe/Ip6Icmp.c index bf9b17d907ef..d43121e4cb9e 100644
--- a/NetworkPkg/Ip6Dxe/Ip6Icmp.c
+++ b/NetworkPkg/Ip6Dxe/Ip6Icmp.c
@@ -300,7 +300,7 @@ Ip6ProcessIcmpError (
}
//
- // Notify the upper-layer process that an ICMPv6 eror message is received.
+ // Notify the upper-layer process that an ICMPv6 error message is received.
//
IP6_GET_CLIP_INFO (Packet)->Status = EFI_ICMP_ERROR;
return Ip6Demultiplex (IpSb, Head, Packet); diff --git a/NetworkPkg/Ip6Dxe/Ip6If.c b/NetworkPkg/Ip6Dxe/Ip6If.c index 956c05c396aa..5b469710572c 100644
--- a/NetworkPkg/Ip6Dxe/Ip6If.c
+++ b/NetworkPkg/Ip6Dxe/Ip6If.c
@@ -1,5 +1,5 @@
/** @file
- Implement IP6 pesudo interface.
+ Implement IP6 pseudo interface.
Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
@@ -160,7 +160,7 @@ Ip6SetAddress (
//
- // Node should delay joining the solicited-node mulitcast address by a random delay
+ // Node should delay joining the solicited-node multicast address by
+ a random delay
// between 0 and MAX_RTR_SOLICITATION_DELAY (1 second).
// Thus queue the address to be processed in Duplicate Address Detection module
// after the delay time (in milliseconds).
@@ -497,7 +497,7 @@ Ip6OnFrameReceivedDpc (
}
//
- // Wrap the frame in a net buffer then deliever it to IP input.
+ // Wrap the frame in a net buffer then deliver it to IP input.
// IP will reassemble the packet, and deliver it to upper layer
//
Netfrag.Len = MnpRxData->DataLength; @@ -548,7 +548,7 @@ Ip6OnFrameReceived (
@retval EFI_ALREADY_STARTED There is already a pending receive request.
@retval EFI_OUT_OF_RESOURCES Failed to allocate resource to receive.
- @retval EFI_SUCCESS The recieve request has been started.
+ @retval EFI_SUCCESS The receive request has been started.
**/
EFI_STATUS
@@ -575,7 +575,7 @@ Ip6ReceiveFrame (
}
/**
- Callback funtion when frame transmission is finished. It will
+ Callback function when frame transmission is finished. It will
call the frame owner's callback function to tell it the result.
@param[in] Context Context which points to the token.
diff --git a/NetworkPkg/Ip6Dxe/Ip6Impl.c b/NetworkPkg/Ip6Dxe/Ip6Impl.c index 80862bfe9d09..826a5c252f1a 100644
--- a/NetworkPkg/Ip6Dxe/Ip6Impl.c
+++ b/NetworkPkg/Ip6Dxe/Ip6Impl.c
@@ -288,7 +288,7 @@ Ip6IsIllegalProtocol ( }
/**
- Intiialize the IP6_PROTOCOL structure to the unconfigured states.
+ Initialize the IP6_PROTOCOL structure to the unconfigured states.
@param[in] IpSb The IP6 service instance.
@param[in, out] IpInstance The IP6 child instance.
@@ -604,7 +604,7 @@ Ip6ServiceConfigMnp (
@retval EFI_DEVICE_ERROR An unexpected system or network error occurred. The EFI IPv6
Protocol driver instance was not opened.
@retval EFI_UNSUPPORTED Default protocol specified through
- Ip6ConfigData.DefaulProtocol isn't supported.
+ Ip6ConfigData.DefaultProtocol isn't supported.
**/
EFI_STATUS
@@ -787,7 +787,7 @@ ON_EXIT:
the destination IPv6 address arithmetically. The gateway address must be on the same subnet as the
configured station address.
- The default route is added with Destination and PrefixLegth both set to all zeros. The
+ The default route is added with Destination and PrefixLength both set
+ to all zeros. The
default route matches all destination IPv6 addresses that do not match any other routes.
All EFI IPv6 Protocol instances share a routing table.
@@ -1001,7 +1001,7 @@ Exit:
@param[in] Map The container of either user's transmit or receive
token.
@param[in] Item Current item to check against.
- @param[in] Context The Token to check againist.
+ @param[in] Context The Token to check against.
@retval EFI_ACCESS_DENIED The token or event has already been enqueued in IP
@retval EFI_SUCCESS The current item isn't the same token/event as the
@@ -1449,7 +1449,7 @@ Exit:
is signaled.
Current Udp implementation creates an IP child for each Udp child.
- It initates a asynchronous receive immediately no matter whether
+ It initiates a asynchronous receive immediately no matter whether
there is no mapping or not. Therefore, disable the returning EFI_NO_MAPPING for now.
To enable it, the following check must be performed:
diff --git a/NetworkPkg/Ip6Dxe/Ip6Input.c b/NetworkPkg/Ip6Dxe/Ip6Input.c index 57a52326e1bf..c42baa35b6b6 100644
--- a/NetworkPkg/Ip6Dxe/Ip6Input.c
+++ b/NetworkPkg/Ip6Dxe/Ip6Input.c
@@ -319,7 +319,7 @@ Ip6Reassemble (
}
//
- // Backup the first fragment in case the reasembly of that packet fail.
+ // Backup the first fragment in case the reassembly of that packet fail.
//
Duplicate = NetbufDuplicate (Packet, NULL, sizeof (EFI_IP6_HEADER));
if (Duplicate == NULL) {
@@ -371,7 +371,7 @@ Ip6Reassemble (
//
// Deliver the whole packet if all the fragments received.
// All fragments received if:
- // 1. received the last one, so, the totoal length is know
+ // 1. received the last one, so, the total length is known
// 2. received all the data. If the last fragment on the
// queue ends at the total length, all data is received.
//
@@ -380,7 +380,7 @@ Ip6Reassemble (
RemoveEntryList (&Assemble->Link);
//
- // If the packet is properly formated, the last fragment's End
+ // If the packet is properly formatted, the last fragment's End
// equals to the packet's total length. Otherwise, the packet
// is a fake, drop it now.
//
@@ -396,7 +396,7 @@ Ip6Reassemble (
//
// This TmpPacket is used to hold the unfragmentable part, i.e.,
// the IPv6 header and the unfragmentable extension headers. Be noted that
- // the Fragment Header is exluded.
+ // the Fragment Header is excluded.
//
TmpPacket = NetbufGetFragment (Fragment, 0, This->HeadLen, 0);
ASSERT (TmpPacket != NULL);
@@ -489,7 +489,7 @@ Ip6IpSecFree (
@retval EFI_SUCCESS The packet was bypassed, and all buffers remain the same.
@retval EFI_SUCCESS The packet was protected.
@retval EFI_ACCESS_DENIED The packet was discarded.
- @retval EFI_OUT_OF_RESOURCES There are not suffcient resources to complete the operation.
+ @retval EFI_OUT_OF_RESOURCES There are not sufficient resources to complete the operation.
@retval EFI_BUFFER_TOO_SMALL The number of non-empty blocks is bigger than the
number of input data blocks when building a fragment table.
@@ -718,7 +718,7 @@ ON_EXIT:
@param[in, out] Packet The received IP6 packet to be processed.
@param[in] Flag The link layer flag for the packet received, such
as multicast.
- @param[out] Payload The pointer to the payload of the recieved packet.
+ @param[out] Payload The pointer to the payload of the received packet.
it starts from the first byte of the extension header.
@param[out] LastHead The pointer of NextHeader of the last extension
header processed by IP6.
@@ -1070,7 +1070,7 @@ Ip6AcceptFrame (
//
// Packet may have been changed. The ownership of the packet
- // is transfered to the packet process logic.
+ // is transferred to the packet process logic.
//
Head = Packet->Ip.Ip6;
IP6_GET_CLIP_INFO (Packet)->Status = EFI_SUCCESS; @@ -1283,7 +1283,7 @@ Ip6InstanceFrameAcceptable (
Proto = NULL;
//
- // Dirty trick for the Tiano UEFI network stack implmentation. If
+ // Dirty trick for the Tiano UEFI network stack implementation. If
// ReceiveTimeout == -1, the receive of the packet for this instance
// is disabled. The UEFI spec don't have such captibility. We add
// this to improve the performance because IP will make a copy of @@ -1428,7 +1428,7 @@ Ip6InstanceEnquePacket (
}
//
- // Enque a shared copy of the packet.
+ // Enqueue a shared copy of the packet.
//
Clone = NetbufClone (Packet);
@@ -1661,7 +1661,7 @@ Ip6Demultiplex (
INTN Enqueued;
//
- // Two pass delivery: first, enque a shared copy of the packet
+ // Two pass delivery: first, enqueue a shared copy of the packet
// to each instance that accept the packet.
//
Enqueued = 0;
diff --git a/NetworkPkg/Ip6Dxe/Ip6Mld.c b/NetworkPkg/Ip6Dxe/Ip6Mld.c index b7a882b25975..ba12089dee25 100644
--- a/NetworkPkg/Ip6Dxe/Ip6Mld.c
+++ b/NetworkPkg/Ip6Dxe/Ip6Mld.c
@@ -383,7 +383,7 @@ ERROR:
@retval EFI_OUT_OF_RESOURCES There are not sufficient resources to complete
the operation.
- @retval EFI_SUCESS The address is added to the group address array.
+ @retval EFI_SUCCESS The address is added to the group address array.
**/
EFI_STATUS
@@ -496,8 +496,8 @@ Ip6JoinGroup (
}
//
- // Repeat the report once or twcie after short delays [Unsolicited Report Interval] (default:10s)
- // Simulate this operation as a Multicast-Address-Specific Query was received for that addresss.
+ // Repeat the report once or twice after short delays [Unsolicited
+ Report Interval] (default:10s) // Simulate this operation as a Multicast-Address-Specific Query was received for that address.
//
Group = Ip6CreateMldEntry (IpSb, Address, IP6_UNSOLICITED_REPORT_INTERVAL);
if (Group == NULL) {
@@ -604,7 +604,7 @@ Ip6LeaveGroup (
@retval EFI_ALREADY_STARTED Wants to join the group, but is already a member of it
@retval EFI_OUT_OF_RESOURCES Failed to allocate sufficient resources.
- @retval EFI_DEVICE_ERROR Failed to set the group configuraton.
+ @retval EFI_DEVICE_ERROR Failed to set the group configuration.
@retval EFI_SUCCESS Successfully updated the group setting.
@retval EFI_NOT_FOUND Try to leave the group which it isn't a member.
diff --git a/NetworkPkg/Ip6Dxe/Ip6Nd.c b/NetworkPkg/Ip6Dxe/Ip6Nd.c index 67d7022a7673..4288ef02dd46 100644
--- a/NetworkPkg/Ip6Dxe/Ip6Nd.c
+++ b/NetworkPkg/Ip6Dxe/Ip6Nd.c
@@ -1645,7 +1645,7 @@ Ip6ProcessNeighborSolicit (
//
// Sends a Neighbor Advertisement as response.
// Set the Router flag to zero since the node is a host.
- // If the source address of the solicitation is unspeicifed, and target address
+ // If the source address of the solicitation is unspecified, and
+ target address
// is one of the maintained address, reply a unsolicited multicast advertisement.
//
if (IsDAD && IsMaintained) {
@@ -2087,7 +2087,7 @@ Ip6ProcessRouterAdvertise (
}
//
- // If an valid router advertisment is received, stops router solicitation.
+ // If an valid router advertisement is received, stops router solicitation.
//
IpSb->RouterAdvertiseReceived = TRUE;
@@ -2251,7 +2251,7 @@ Ip6ProcessRouterAdvertise (
//
if (!Ip6IsOneOfSetAddress (IpSb, &StatelessAddress, NULL, NULL)) {
//
- // And also not in the DAD process, check its uniqeness firstly.
+ // And also not in the DAD process, check its uniqueness firstly.
//
if (Ip6FindDADEntry (IpSb, &StatelessAddress, NULL) == NULL) {
Status = Ip6SetAddress (
@@ -2303,7 +2303,7 @@ Ip6ProcessRouterAdvertise (
} else if (PrefixList->ValidLifetime <= 7200) {
//
- // If RemainingLifetime is less than or equls to 2 hours, ignore the
+ // If RemainingLifetime is less than or equals to 2 hours,
+ ignore the
// Prefix Information option with regards to the valid lifetime.
// TODO: If this option has been authenticated, set the valid lifetime.
//
@@ -2365,7 +2365,7 @@ Exit:
the IP head removed.
@retval EFI_INVALID_PARAMETER The parameter is invalid.
- @retval EFI_OUT_OF_RESOURCES Insuffcient resources to complete the
+ @retval EFI_OUT_OF_RESOURCES Insufficient resources to complete the
operation.
@retval EFI_SUCCESS Successfully updated the route caches.
@@ -3069,7 +3069,7 @@ Ip6NdFasterTimerTicking (
/**
The heartbeat timer of ND module in 1 second. This time routine handles following
- things: 1) maitain default router list; 2) maintain prefix options;
+ things: 1) maintain default router list; 2) maintain prefix options;
3) maintain route caches.
@param[in] IpSb The IP6 service binding instance.
diff --git a/NetworkPkg/Ip6Dxe/Ip6Output.c b/NetworkPkg/Ip6Dxe/Ip6Output.c index 6ab4459bab9c..2a2eae4b854f 100644
--- a/NetworkPkg/Ip6Dxe/Ip6Output.c
+++ b/NetworkPkg/Ip6Dxe/Ip6Output.c
@@ -870,7 +870,7 @@ Ip6Output (
for (Index = 0, Offset = 0, PacketLen = Mtu; Index < Num; Index++) {
//
- // Get fragment from the Packet, append UnFragnmentLen spare buffer
+ // Get fragment from the Packet, append UnFragmentLen spare
+ buffer
// before the fragmented data, the corresponding data is filled in later.
//
Fragment = NetbufGetFragment (Packet, Offset, PacketLen, UnFragmentLen); diff --git a/NetworkPkg/Ip6Dxe/Ip6Route.c b/NetworkPkg/Ip6Dxe/Ip6Route.c index c8d79cd6dbcc..c24361d2957c 100644
--- a/NetworkPkg/Ip6Dxe/Ip6Route.c
+++ b/NetworkPkg/Ip6Dxe/Ip6Route.c
@@ -44,7 +44,7 @@ Ip6RouteCacheHash (
@param[in] GatewayAddress The next hop address. This is an optional parameter
that may be NULL.
- @return NULL if failed to allocate memeory; otherwise, the newly created route entry.
+ @return NULL if failed to allocate memory; otherwise, the newly created route entry.
**/
IP6_ROUTE_ENTRY *
@@ -105,7 +105,7 @@ Ip6FreeRouteEntry (
2. The local route entries have precedence over the default route entry.
@param[in] RtTable The route table to search from.
- @param[in] Destination The destionation address to search. If NULL, search
+ @param[in] Destination The destination address to search. If NULL, search
the route table by NextHop.
@param[in] NextHop The next hop address. If NULL, search the route table
by Destination.
@@ -210,7 +210,7 @@ Ip6FreeRouteCacheEntry (
/**
Find a route cache with the destination and source address. This is
- used by the ICMPv6 redirect messasge process.
+ used by the ICMPv6 redirect message process.
@param[in] RtTable The route table to search the cache for.
@param[in] Dest The destination address.
--
2.21.0
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
^ permalink raw reply related [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-45-philmd@redhat.com>]
* Re: [PATCH 44/79] NetworkPkg/Library: Fix various typos
[not found] ` <20191203161602.15969-45-philmd@redhat.com>
@ 2019-12-06 16:04 ` Rabeda, Maciej
0 siblings, 0 replies; 122+ messages in thread
From: Rabeda, Maciej @ 2019-12-06 16:04 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Wu, Jiaxin, Fu, Siyuan
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
Thanks!
Maciej
-----Original Message-----
From: Philippe Mathieu-Daude <philmd@redhat.com>
Sent: Tuesday, December 3, 2019 17:15
To: devel@edk2.groups.io
Cc: Antoine Coeur <coeur@gmx.fr>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
Subject: [PATCH 44/79] NetworkPkg/Library: Fix various typos
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/Include/Library/HttpLib.h | 2 +-
NetworkPkg/Include/Library/IpIoLib.h | 4 ++--
NetworkPkg/Include/Library/NetLib.h | 2 +-
NetworkPkg/Include/Library/TcpIoLib.h | 6 +++---
NetworkPkg/Include/Library/UdpIoLib.h | 6 +++---
NetworkPkg/Library/DxeHttpLib/DxeHttpLib.c | 4 ++--
NetworkPkg/Library/DxeIpIoLib/DxeIpIoLib.c | 16 ++++++++--------
NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 16 ++++++++--------
NetworkPkg/Library/DxeNetLib/NetBuffer.c | 4 ++--
NetworkPkg/Library/DxeTcpIoLib/DxeTcpIoLib.c | 10 +++++----- NetworkPkg/Library/DxeUdpIoLib/DxeUdpIoLib.c | 10 +++++-----
11 files changed, 40 insertions(+), 40 deletions(-)
diff --git a/NetworkPkg/Include/Library/HttpLib.h b/NetworkPkg/Include/Library/HttpLib.h
index 93100eb350e5..a906126b3d6e 100644
--- a/NetworkPkg/Include/Library/HttpLib.h
+++ b/NetworkPkg/Include/Library/HttpLib.h
@@ -425,7 +425,7 @@ HttpFreeHeaderFields (
the HTTP request message.
@param[in] Url The URL of a remote host.
@param[out] RequestMsg Pointer to the created HTTP request message.
- NULL if any error occured.
+ NULL if any error occurred.
@param[out] RequestMsgSize Size of the RequestMsg (in bytes).
@retval EFI_SUCCESS If HTTP request string was created successfully.
diff --git a/NetworkPkg/Include/Library/IpIoLib.h b/NetworkPkg/Include/Library/IpIoLib.h
index 2d6e090f754e..d95413e87eb1 100644
--- a/NetworkPkg/Include/Library/IpIoLib.h
+++ b/NetworkPkg/Include/Library/IpIoLib.h
@@ -403,7 +403,7 @@ IpIoOpen (
This function is called after IpIoOpen(). The data to be sent is wrapped in
Pkt. The IP instance wrapped in IpIo is used for sending by default but can be
- overriden by Sender. Other sending configs, like source address and gateway
+ overridden by Sender. Other sending configs, like source address and
+ gateway
address etc., are specified in OverrideData.
@param[in, out] IpIo Pointer to an IP_IO instance used for sending IP
@@ -508,7 +508,7 @@ IpIoConfigIp (
This function pairs with IpIoAddIp(). The IpInfo is previously created by
IpIoAddIp(). The IP_IO_IP_INFO::RefCnt is decremented and the IP instance
- will be dstroyed if the RefCnt is zero.
+ will be destroyed if the RefCnt is zero.
@param[in] IpIo The pointer to the IP_IO instance.
@param[in] IpInfo The pointer to the IpInfo to be removed.
diff --git a/NetworkPkg/Include/Library/NetLib.h b/NetworkPkg/Include/Library/NetLib.h
index 786382a1fcff..858d0b6ba07c 100644
--- a/NetworkPkg/Include/Library/NetLib.h
+++ b/NetworkPkg/Include/Library/NetLib.h
@@ -748,7 +748,7 @@ EFI_STATUS
If it has been removed, then restart the traversal from the head.
If it hasn't been removed, then continue with the next node directly.
This function will end the iterate and return the CallBack's last return value if error happens,
- or retrun EFI_SUCCESS if 2 complete passes are made with no changes in the number of children in the list.
+ or return EFI_SUCCESS if 2 complete passes are made with no changes in the number of children in the list.
@param[in] List The head of the list.
@param[in] CallBack Pointer to the callback function to destroy one node in the list.
diff --git a/NetworkPkg/Include/Library/TcpIoLib.h b/NetworkPkg/Include/Library/TcpIoLib.h
index 63872f615c0a..13c163ce9920 100644
--- a/NetworkPkg/Include/Library/TcpIoLib.h
+++ b/NetworkPkg/Include/Library/TcpIoLib.h
@@ -200,7 +200,7 @@ TcpIoReset (
@param[in] TcpIo The TcpIo wrapping the TCP socket.
@param[in] Packet The packet to transmit.
- @retval EFI_SUCCESS The packet is trasmitted.
+ @retval EFI_SUCCESS The packet is transmitted.
@retval EFI_INVALID_PARAMETER One or more parameters are invalid.
@retval EFI_UNSUPPORTED One or more of the control options are not
supported in the implementation.
@@ -221,14 +221,14 @@ TcpIoTransmit (
@param[in, out] TcpIo The TcpIo which wraps the socket to be destroyed.
@param[in] Packet The buffer to hold the data copy from the socket rx buffer.
- @param[in] AsyncMode Is this receive asyncronous or not.
+ @param[in] AsyncMode Is this receive asynchronous or not.
@param[in] Timeout The time to wait for receiving the amount of data the Packet
can hold. Set to NULL for infinite wait.
@retval EFI_SUCCESS The required amount of data is received from the socket.
@retval EFI_INVALID_PARAMETER One or more parameters are invalid.
@retval EFI_DEVICE_ERROR An unexpected network or system error occurred.
- @retval EFI_OUT_OF_RESOURCES Failed to allocate momery.
+ @retval EFI_OUT_OF_RESOURCES Failed to allocate memory.
@retval EFI_TIMEOUT Failed to receive the required amount of data in the
specified time period.
@retval Others Other errors as indicated.
diff --git a/NetworkPkg/Include/Library/UdpIoLib.h b/NetworkPkg/Include/Library/UdpIoLib.h
index c3cddfafb151..cd4ebeb87a43 100644
--- a/NetworkPkg/Include/Library/UdpIoLib.h
+++ b/NetworkPkg/Include/Library/UdpIoLib.h
@@ -43,7 +43,7 @@ typedef struct {
This prototype is used by both receive and sending when calling
UdpIoRecvDatagram() or UdpIoSendDatagram(). When receiving, Netbuf is allocated by the
- UDP access point and released by the user. When sending, the user allocates the the NetBuf,
+ UDP access point and released by the user. When sending, the user
+ allocates the NetBuf,
which is then provided to the callback as a reference.
@param[in] Packet The packet received or sent.
@@ -197,7 +197,7 @@ BOOLEAN
@param[in] UdpIo The UDP_IO to cancel packet.
@param[in] IoStatus The IoStatus to return to the packet owners.
- @param[in] ToCancel The select funtion to test whether to cancel this
+ @param[in] ToCancel The select function to test whether to cancel this
packet or not.
@param[in] Context The opaque parameter to the ToCancel.
@@ -228,7 +228,7 @@ UdpIoCancelDgrams (
@param[in] ImageHandle The image handle for the driver.
@param[in] Configure The function to configure the created UDP child.
@param[in] UdpVersion The UDP protocol version, UDP4 or UDP6.
- @param[in] Context The opaque parameter for the Configure funtion.
+ @param[in] Context The opaque parameter for the Configure function.
@return The newly-created UDP_IO, or NULL if failed.
diff --git a/NetworkPkg/Library/DxeHttpLib/DxeHttpLib.c b/NetworkPkg/Library/DxeHttpLib/DxeHttpLib.c
index 8b74554cd961..180d9321025a 100644
--- a/NetworkPkg/Library/DxeHttpLib/DxeHttpLib.c
+++ b/NetworkPkg/Library/DxeHttpLib/DxeHttpLib.c
@@ -1677,7 +1677,7 @@ HttpGetFieldNameAndValue (
/**
Free existing HeaderFields.
- @param[in] HeaderFields Pointer to array of key/value header pairs waitting for free.
+ @param[in] HeaderFields Pointer to array of key/value header pairs waiting for free.
@param[in] FieldCount The number of header pairs in HeaderFields.
**/
@@ -1717,7 +1717,7 @@ HttpFreeHeaderFields (
the HTTP request message.
@param[in] Url The URL of a remote host.
@param[out] RequestMsg Pointer to the created HTTP request message.
- NULL if any error occured.
+ NULL if any error occurred.
@param[out] RequestMsgSize Size of the RequestMsg (in bytes).
@retval EFI_SUCCESS If HTTP request string was created successfully.
diff --git a/NetworkPkg/Library/DxeIpIoLib/DxeIpIoLib.c b/NetworkPkg/Library/DxeIpIoLib/DxeIpIoLib.c
index d45f0070b3fc..0a816da00140 100644
--- a/NetworkPkg/Library/DxeIpIoLib/DxeIpIoLib.c
+++ b/NetworkPkg/Library/DxeIpIoLib/DxeIpIoLib.c
@@ -123,7 +123,7 @@ IpIoTransmitHandler (
@retval EFI_SUCCESS The IP child is created and the IP protocol
interface is retrieved.
- @retval EFI_UNSUPPORTED Upsupported IpVersion.
+ @retval EFI_UNSUPPORTED Unsupported IpVersion.
@retval Others The required operation failed.
**/
@@ -191,7 +191,7 @@ IpIoCreateIpChildOpenProtocol (
/**
- This function close the previously openned IP protocol and destroy the IP child.
+ This function close the previously opened IP protocol and destroy the IP child.
@param[in] ControllerHandle The controller handle.
@param[in] ImageHandle The image handle.
@@ -201,7 +201,7 @@ IpIoCreateIpChildOpenProtocol (
@retval EFI_SUCCESS The IP protocol is closed and the relevant IP child
is destroyed.
- @retval EFI_UNSUPPORTED Upsupported IpVersion.
+ @retval EFI_UNSUPPORTED Unsupported IpVersion.
@retval Others The required operation failed.
**/
@@ -228,7 +228,7 @@ IpIoCloseProtocolDestroyIpChild (
}
//
- // Close the previously openned IP protocol.
+ // Close the previously opened IP protocol.
//
Status = gBS->CloseProtocol (
ChildHandle,
@@ -626,7 +626,7 @@ IpIoExtFree (
@param[in] Context Pointer to the context.
@param[in] NotifyData Pointer to the notify data.
@param[in] Dest Pointer to the destination IP address.
- @param[in] Override Pointer to the overriden IP_IO data.
+ @param[in] Override Pointer to the overridden IP_IO data.
@return Pointer to the data structure created to wrap the packet. If any error occurs,
then return NULL.
@@ -1497,7 +1497,7 @@ IpIoStop (
IpIo->IsConfigured = FALSE;
//
- // Detroy the Ip List used by IpIo
+ // Destroy the Ip List used by IpIo
//
while (!IsListEmpty (&(IpIo->IpList))) { @@ -1577,7 +1577,7 @@ IpIoDestroy (
This function is called after IpIoOpen(). The data to be sent is wrapped in
Pkt. The IP instance wrapped in IpIo is used for sending by default but can be
- overriden by Sender. Other sending configs, like source address and gateway
+ overridden by Sender. Other sending configs, like source address and
+ gateway
address etc., are specified in OverrideData.
@param[in, out] IpIo Pointer to an IP_IO instance used for sending IP
@@ -1991,7 +1991,7 @@ IpIoConfigIp (
This function pairs with IpIoAddIp(). The IpInfo is previously created by
IpIoAddIp(). The IP_IO_IP_INFO::RefCnt is decremented and the IP instance
- will be dstroyed if the RefCnt is zero.
+ will be destroyed if the RefCnt is zero.
@param[in] IpIo Pointer to the IP_IO instance.
@param[in] IpInfo Pointer to the IpInfo to be removed.
diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
index 4f8a1226dae7..2a555a7b90fa 100644
--- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
+++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
@@ -36,7 +36,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#define DEFAULT_ZERO_START ((UINTN) ~0)
//
-// All the supported IP4 maskes in host byte order.
+// All the supported IP4 masks in host byte order.
//
GLOBAL_REMOVE_IF_UNREFERENCED IP4_ADDR gIp4AllMasks[IP4_MASK_NUM] = {
0x00000000,
@@ -130,7 +130,7 @@ GLOBAL_REMOVE_IF_UNREFERENCED VLAN_DEVICE_PATH mNetVlanDevicePathTemplate = {
to send the syslog packets. The caller isn't required to close
the SNP after use because the SNP is opened by HandleProtocol.
- @return The point to SNP if one is properly openned. Otherwise NULL
+ @return The point to SNP if one is properly opened. Otherwise NULL
**/
EFI_SIMPLE_NETWORK_PROTOCOL *
@@ -304,7 +304,7 @@ ON_EXIT:
@param[in] File The file that contains the current log
@param[in] Line The line of code in the File that contains the current log
@param[in] Message The log message
- @param[in] BufLen The lenght of the Buf
+ @param[in] BufLen The length of the Buf
@param[out] Buf The buffer to put the packet data
@return The length of the syslog packet built, 0 represents no packet is built.
@@ -480,7 +480,7 @@ NetDebugASPrint (
Because it isn't open the SNP BY_DRIVER, apply caution when using it.
@param Level The severity level of the message.
- @param Module The Moudle that generates the log.
+ @param Module The Module that generates the log.
@param File The file that contains the log.
@param Line The exact line that contains the log.
@param Message The user message to log.
@@ -518,7 +518,7 @@ NetDebugOutput (
}
//
- // Allocate a maxium of 1024 bytes, the caller should ensure
+ // Allocate a maximum of 1024 bytes, the caller should ensure
// that the message plus the ethernet/ip/udp header is shorter
// than this
//
@@ -1129,7 +1129,7 @@ NetListInsertBefore (
If it has been removed, then restart the traversal from the head.
If it hasn't been removed, then continue with the next node directly.
This function will end the iterate and return the CallBack's last return value if error happens,
- or retrun EFI_SUCCESS if 2 complete passes are made with no changes in the number of children in the list.
+ or return EFI_SUCCESS if 2 complete passes are made with no changes in the number of children in the list.
@param[in] List The head of the list.
@param[in] CallBack Pointer to the callback function to destroy one node in the list.
@@ -1353,7 +1353,7 @@ NetMapGetCount (
Return one allocated item.
If the Recycled doubly linked list of the netmap is empty, it will try to allocate
- a batch of items if there are enough resources and add corresponding nodes to the begining
+ a batch of items if there are enough resources and add corresponding
+ nodes to the beginning
of the Recycled doubly linked list of the netmap. Otherwise, it will directly remove
the fist node entry of the Recycled doubly linked list and return the corresponding item.
@@ -3299,7 +3299,7 @@ NetLibGetSystemGuid (
String = (CHAR8 *) (Smbios.Raw + Smbios.Hdr->Length);
//
- // Step 2: Skip over unformated string section.
+ // Step 2: Skip over unformatted string section.
//
do {
//
diff --git a/NetworkPkg/Library/DxeNetLib/NetBuffer.c b/NetworkPkg/Library/DxeNetLib/NetBuffer.c
index 2408e9a10456..a232802c9a21 100644
--- a/NetworkPkg/Library/DxeNetLib/NetBuffer.c
+++ b/NetworkPkg/Library/DxeNetLib/NetBuffer.c
@@ -602,7 +602,7 @@ NetbufGetFragment (
if (HeadSpace != 0) {
//
- // Allocate an extra block to accomdate the head space.
+ // Allocate an extra block to accommodate the head space.
//
BlockOpNum++;
@@ -791,7 +791,7 @@ NetbufFromExt (
if (Len == 0) {
//
- // Increament the index number to point to the next
+ // Increment the index number to point to the next
// non-empty fragment.
//
Index++;
diff --git a/NetworkPkg/Library/DxeTcpIoLib/DxeTcpIoLib.c b/NetworkPkg/Library/DxeTcpIoLib/DxeTcpIoLib.c
index 341295d0b7af..6f87a0eada98 100644
--- a/NetworkPkg/Library/DxeTcpIoLib/DxeTcpIoLib.c
+++ b/NetworkPkg/Library/DxeTcpIoLib/DxeTcpIoLib.c
@@ -304,7 +304,7 @@ TcpIoCreateSocket (
}
//
- // Create events for variuos asynchronous operations.
+ // Create events for various asynchronous operations.
//
Status = gBS->CreateEvent (
EVT_NOTIFY_SIGNAL,
@@ -745,7 +745,7 @@ TcpIoReset (
@param[in] TcpIo The TcpIo wrapping the TCP socket.
@param[in] Packet The packet to transmit.
- @retval EFI_SUCCESS The packet is trasmitted.
+ @retval EFI_SUCCESS The packet is transmitted.
@retval EFI_INVALID_PARAMETER One or more parameters are invalid.
@retval EFI_UNSUPPORTED One or more of the control options are not
supported in the implementation.
@@ -807,7 +807,7 @@ TcpIoTransmit (
Status = EFI_DEVICE_ERROR;
//
- // Trasnmit the packet.
+ // Transmit the packet.
//
if (TcpIo->TcpVersion == TCP_VERSION_4) {
TcpIo->TxToken.Tcp4Token.Packet.TxData = (EFI_TCP4_TRANSMIT_DATA *) Data; @@ -862,14 +862,14 @@ ON_EXIT:
@param[in, out] TcpIo The TcpIo which wraps the socket to be destroyed.
@param[in] Packet The buffer to hold the data copy from the socket rx buffer.
- @param[in] AsyncMode Is this receive asyncronous or not.
+ @param[in] AsyncMode Is this receive asynchronous or not.
@param[in] Timeout The time to wait for receiving the amount of data the Packet
can hold. Set to NULL for infinite wait.
@retval EFI_SUCCESS The required amount of data is received from the socket.
@retval EFI_INVALID_PARAMETER One or more parameters are invalid.
@retval EFI_DEVICE_ERROR An unexpected network or system error occurred.
- @retval EFI_OUT_OF_RESOURCES Failed to allocate momery.
+ @retval EFI_OUT_OF_RESOURCES Failed to allocate memory.
@retval EFI_TIMEOUT Failed to receive the required amount of data in the
specified time period.
@retval Others Other errors as indicated.
diff --git a/NetworkPkg/Library/DxeUdpIoLib/DxeUdpIoLib.c b/NetworkPkg/Library/DxeUdpIoLib/DxeUdpIoLib.c
index 155cb3104972..0034a5694f92 100644
--- a/NetworkPkg/Library/DxeUdpIoLib/DxeUdpIoLib.c
+++ b/NetworkPkg/Library/DxeUdpIoLib/DxeUdpIoLib.c
@@ -147,7 +147,7 @@ UdpIoRecycleDgram (
/**
The event handle for UDP receive request.
- It will build a NET_BUF from the recieved UDP data, then deliver it
+ It will build a NET_BUF from the received UDP data, then deliver it
to the receiver.
@param[in] Context The UDP RX token.
@@ -335,7 +335,7 @@ UdpIoOnDgramRcvd (
@param[in] UdpIo The UdpIo to receive packets from.
@param[in] CallBack The function to call when receive finished.
@param[in] Context The opaque parameter to the CallBack.
- @param[in] HeadLen The head length to reserver for the packet.
+ @param[in] HeadLen The head length to reserve for the packet.
@return The Wrapped request or NULL if failed to allocate resources or some errors happened.
@@ -410,7 +410,7 @@ UdpIoCreateRxToken (
@param[in] UdpIo The UdpIo to send packet to.
@param[in] Packet The user's packet.
@param[in] EndPoint The local and remote access point.
- @param[in] Gateway The overrided next hop.
+ @param[in] Gateway The overridden next hop.
@param[in] CallBack The function to call when transmission completed.
@param[in] Context The opaque parameter to the call back.
@@ -590,7 +590,7 @@ UdpIoCreateTxToken (
@param[in] ImageHandle The image handle for the driver.
@param[in] Configure The function to configure the created UDP child.
@param[in] UdpVersion The UDP protocol version, UDP4 or UDP6.
- @param[in] Context The opaque parameter for the Configure funtion.
+ @param[in] Context The opaque parameter for the Configure function.
@return Newly-created UDP_IO or NULL if failed.
@@ -755,7 +755,7 @@ FREE_MEM:
@param[in] UdpIo The UDP_IO to cancel packet.
@param[in] IoStatus The IoStatus to return to the packet owners.
- @param[in] ToCancel The select funtion to test whether to cancel this
+ @param[in] ToCancel The select function to test whether to cancel this
packet or not.
@param[in] Context The opaque parameter to the ToCancel.
--
2.21.0
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
^ permalink raw reply related [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-42-philmd@redhat.com>]
* Re: [PATCH 41/79] NetworkPkg/Ip4Dxe: Fix various typos
[not found] ` <20191203161602.15969-42-philmd@redhat.com>
@ 2019-12-06 16:04 ` Rabeda, Maciej
0 siblings, 0 replies; 122+ messages in thread
From: Rabeda, Maciej @ 2019-12-06 16:04 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Wu, Jiaxin, Fu, Siyuan
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
Thanks!
Maciej
-----Original Message-----
From: Philippe Mathieu-Daude <philmd@redhat.com>
Sent: Tuesday, December 3, 2019 17:15
To: devel@edk2.groups.io
Cc: Antoine Coeur <coeur@gmx.fr>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
Subject: [PATCH 41/79] NetworkPkg/Ip4Dxe: Fix various typos
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/Ip4Dxe/Ip4Common.h | 14 +++++-----
NetworkPkg/Ip4Dxe/Ip4Config2Impl.h | 2 +-
NetworkPkg/Ip4Dxe/Ip4Driver.h | 6 ++---
NetworkPkg/Ip4Dxe/Ip4Icmp.h | 8 +++---
NetworkPkg/Ip4Dxe/Ip4If.h | 4 +--
NetworkPkg/Ip4Dxe/Ip4Igmp.h | 2 +-
NetworkPkg/Ip4Dxe/Ip4Impl.h | 8 +++---
NetworkPkg/Ip4Dxe/Ip4Input.h | 6 ++---
NetworkPkg/Ip4Dxe/Ip4Output.h | 4 +--
NetworkPkg/Ip4Dxe/Ip4Route.h | 12 ++++-----
NetworkPkg/Ip4Dxe/Ip4Common.c | 10 +++----
NetworkPkg/Ip4Dxe/Ip4Config2Impl.c | 10 +++----
NetworkPkg/Ip4Dxe/Ip4Config2Nv.c | 4 +--
NetworkPkg/Ip4Dxe/Ip4Driver.c | 10 +++----
NetworkPkg/Ip4Dxe/Ip4If.c | 14 +++++-----
NetworkPkg/Ip4Dxe/Ip4Igmp.c | 6 ++---
NetworkPkg/Ip4Dxe/Ip4Impl.c | 14 +++++-----
NetworkPkg/Ip4Dxe/Ip4Input.c | 28 ++++++++++----------
NetworkPkg/Ip4Dxe/Ip4Option.c | 2 +-
NetworkPkg/Ip4Dxe/Ip4Output.c | 12 ++++-----
NetworkPkg/Ip4Dxe/Ip4Route.c | 14 +++++-----
21 files changed, 95 insertions(+), 95 deletions(-)
diff --git a/NetworkPkg/Ip4Dxe/Ip4Common.h b/NetworkPkg/Ip4Dxe/Ip4Common.h index 8fbfd5487219..a84602d45ac0 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Common.h
+++ b/NetworkPkg/Ip4Dxe/Ip4Common.h
@@ -23,7 +23,7 @@ typedef struct _IP4_SERVICE IP4_SERVICE;
#define IP4_LINK_PROMISC 0x00000004
//
-// IP4 address cast type classfication. Keep it true that any
+// IP4 address cast type classification. Keep it true that any
// type bigger than or equal to LOCAL_BROADCAST is broadcast.
//
#define IP4_PROMISCUOUS 1
@@ -63,13 +63,13 @@ typedef struct _IP4_SERVICE IP4_SERVICE;
#define IP4_IS_BROADCAST(CastType) ((CastType) >= IP4_LOCAL_BROADCAST)
///
-/// Conver the Microsecond to second. IP transmit/receive time is
+/// Convert the Microsecond to second. IP transmit/receive time is
/// in the unit of microsecond. IP ticks once per second.
///
#define IP4_US_TO_SEC(Us) (((Us) + 999999) / 1000000)
/**
- Return the cast type (Unicast/Boradcast) specific to an
+ Return the cast type (Unicast/Broadcast) specific to an
interface. All the addresses are host byte ordered.
@param[in] IpAddr The IP address to classify in host byte order
@@ -77,7 +77,7 @@ typedef struct _IP4_SERVICE IP4_SERVICE;
@return The cast type of this IP address specific to the interface.
@retval IP4_LOCAL_HOST The IpAddr equals to the interface's address
- @retval IP4_SUBNET_BROADCAST The IpAddr is a directed subnet boradcast to the
+ @retval IP4_SUBNET_BROADCAST The IpAddr is a directed subnet
+ broadcast to the
interface
@retval IP4_NET_BROADCAST The IpAddr is a network broadcast to the interface
@retval 0 Otherwise.
@@ -146,7 +146,7 @@ Ip4FindNet (
Find an interface of the service with the same Ip/Netmask pair.
@param[in] IpSb Ip4 service binding instance
- @param[in] Ip The Ip adress to find (host byte order)
+ @param[in] Ip The Ip address to find (host byte order)
@param[in] Netmask The network to find (host byte order)
@return The IP4_INTERFACE point if found, otherwise NULL @@ -199,10 +199,10 @@ Ip4NtohHead (
/**
Validate that Ip/Netmask pair is OK to be used as station
address. Only continuous netmasks are supported. and check
- that StationAddress is a unicast address on the newtwork.
+ that StationAddress is a unicast address on the network.
@param[in] Ip The IP address to validate.
- @param[in] Netmask The netmaks of the IP.
+ @param[in] Netmask The netmask of the IP.
@retval TRUE The Ip/Netmask pair is valid.
@retval FALSE The Ip/Netmask pair is invalid.
diff --git a/NetworkPkg/Ip4Dxe/Ip4Config2Impl.h b/NetworkPkg/Ip4Dxe/Ip4Config2Impl.h
index 1716dde399ab..0e4639e77c78 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Config2Impl.h
+++ b/NetworkPkg/Ip4Dxe/Ip4Config2Impl.h
@@ -205,7 +205,7 @@ typedef struct {
/**
Read the configuration data from variable storage according to the VarName and
gEfiIp4Config2ProtocolGuid. It checks the integrity of variable data. If the
- data is corrupted, it clears the variable data to ZERO. Othewise, it outputs the
+ data is corrupted, it clears the variable data to ZERO. Otherwise, it
+ outputs the
configuration data to IP4_CONFIG2_INSTANCE.
@param[in] VarName The pointer to the variable name
diff --git a/NetworkPkg/Ip4Dxe/Ip4Driver.h b/NetworkPkg/Ip4Dxe/Ip4Driver.h index be374715703c..d94bdf3bdec1 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Driver.h
+++ b/NetworkPkg/Ip4Dxe/Ip4Driver.h
@@ -47,7 +47,7 @@ Ip4DriverEntryPoint (
);
//
-// Function prototypes for the Drivr Binding Protocol
+// Function prototypes for the Driver Binding Protocol
//
/**
Test to see if this driver supports ControllerHandle. This service @@ -143,7 +143,7 @@ Ip4DriverBindingStop (
then a new handle is created. If it is a pointer to an existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child @@ -167,7 +167,7 @@ Ip4ServiceBindingCreateChild (
@param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param ChildHandle Handle of the child to destroy
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
diff --git a/NetworkPkg/Ip4Dxe/Ip4Icmp.h b/NetworkPkg/Ip4Dxe/Ip4Icmp.h index a52200176f5a..a23952dbdded 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Icmp.h
+++ b/NetworkPkg/Ip4Dxe/Ip4Icmp.h
@@ -10,7 +10,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #define __EFI_IP4_ICMP_H__
//
- // ICMP type definations
+ // ICMP type definitions
//
#define ICMP_ECHO_REPLY 0
#define ICMP_DEST_UNREACHABLE 3
@@ -27,7 +27,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#define ICMP_DEFAULT_CODE 0
//
- // ICMP code definations for ICMP_DEST_UNREACHABLE
+ // ICMP code definitions for ICMP_DEST_UNREACHABLE
//
#define ICMP_NET_UNREACHABLE 0
#define ICMP_HOST_UNREACHABLE 1
@@ -44,13 +44,13 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #define ICMP_HOST_UNREACHABLE_TOS 12
//
- // ICMP code definations for ICMP_TIME_EXCEEDED
+ // ICMP code definitions for ICMP_TIME_EXCEEDED
//
#define ICMP_TIMEOUT_IN_TRANSIT 0
#define ICMP_TIMEOUT_REASSEMBLE 1 // Host may generate
//
- // ICMP code definations for ICMP_TIME_EXCEEDED
+ // ICMP code definitions for ICMP_TIME_EXCEEDED
//
#define ICMP_NET_REDIRECT 0
#define ICMP_HOST_REDIRECT 1
diff --git a/NetworkPkg/Ip4Dxe/Ip4If.h b/NetworkPkg/Ip4Dxe/Ip4If.h index d73bb5285f97..ec951d30434e 100644
--- a/NetworkPkg/Ip4Dxe/Ip4If.h
+++ b/NetworkPkg/Ip4Dxe/Ip4If.h
@@ -1,5 +1,5 @@
/** @file
- Definition for IP4 pesudo interface structure.
+ Definition for IP4 pseudo interface structure.
Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -325,7 +325,7 @@ Ip4CancelReceive (
@retval EFI_ALREADY_STARTED There is already a pending receive request.
@retval EFI_OUT_OF_RESOURCES Failed to allocate resource to receive.
- @retval EFI_SUCCESS The recieve request has been started.
+ @retval EFI_SUCCESS The receive request has been started.
@retval other Other error occurs.
**/
diff --git a/NetworkPkg/Ip4Dxe/Ip4Igmp.h b/NetworkPkg/Ip4Dxe/Ip4Igmp.h index 49c13ba3a7a0..56631bd4afb3 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Igmp.h
+++ b/NetworkPkg/Ip4Dxe/Ip4Igmp.h
@@ -170,7 +170,7 @@ Ip4CombineGroups (
@param Count The number of group addresses in the Groups.
@param Addr The IP4 multicast address to remove.
- @return The nubmer of group addresses in the Groups after remove.
+ @return The number of group addresses in the Groups after remove.
It is Count if the Addr isn't in the Groups.
**/
diff --git a/NetworkPkg/Ip4Dxe/Ip4Impl.h b/NetworkPkg/Ip4Dxe/Ip4Impl.h index a322a85981a5..e8ff33d38adc 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Impl.h
+++ b/NetworkPkg/Ip4Dxe/Ip4Impl.h
@@ -1,5 +1,5 @@
/** @file
- Ip4 internal functions and type defintions.
+ Ip4 internal functions and type definitions.
Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.<BR>
(C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR> @@ -134,7 +134,7 @@ struct _IP4_PROTOCOL {
LIST_ENTRY Link; // Link to all the IP protocol from the service
//
- // User's transmit/receive tokens, and received/deliverd packets
+ // User's transmit/receive tokens, and received/delivered packets
//
NET_MAP RxTokens;
NET_MAP TxTokens; // map between (User's Token, IP4_TXTOKE_WRAP)
@@ -260,7 +260,7 @@ Ip4ServiceConfigMnp (
);
/**
- Intiialize the IP4_PROTOCOL structure to the unconfigured states.
+ Initialize the IP4_PROTOCOL structure to the unconfigured states.
@param IpSb The IP4 service instance.
@param IpInstance The IP4 child instance.
@@ -315,7 +315,7 @@ Ip4Cancel (
@retval EFI_ALREADY_STARTED Want to join the group, but already a member of it
@retval EFI_OUT_OF_RESOURCES Failed to allocate some resources.
- @retval EFI_DEVICE_ERROR Failed to set the group configuraton
+ @retval EFI_DEVICE_ERROR Failed to set the group configuration
@retval EFI_SUCCESS Successfully updated the group setting.
@retval EFI_NOT_FOUND Try to leave the group which it isn't a member.
diff --git a/NetworkPkg/Ip4Dxe/Ip4Input.h b/NetworkPkg/Ip4Dxe/Ip4Input.h index f4d45d1613d0..9bd86e15c9cf 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Input.h
+++ b/NetworkPkg/Ip4Dxe/Ip4Input.h
@@ -128,7 +128,7 @@ Ip4AccpetFrame (
/**
Demultiple the packet. the packet delivery is processed in two
- passes. The first pass will enque a shared copy of the packet
+ passes. The first pass will enqueue a shared copy of the packet
to each IP4 child that accepts the packet. The second pass will
deliver a non-shared copy of the packet to each IP4 child that
has pending receive requests. Data is copied if more than one @@ -215,7 +215,7 @@ Ip4PacketTimerTicking (
actions: bypass the packet, discard the packet, or protect the packet.
@param[in] IpSb The IP4 service instance.
- @param[in, out] Head The The caller supplied IP4 header.
+ @param[in, out] Head The caller supplied IP4 header.
@param[in, out] Netbuf The IP4 packet to be processed by IPsec.
@param[in, out] Options The caller supplied options.
@param[in, out] OptionsLen The length of the option.
@@ -227,7 +227,7 @@ Ip4PacketTimerTicking (
@retval EFI_SUCCESS The packet was bypassed and all buffers remain the same.
@retval EFI_SUCCESS The packet was protected.
@retval EFI_ACCESS_DENIED The packet was discarded.
- @retval EFI_OUT_OF_RESOURCES There is no suffcient resource to complete the operation.
+ @retval EFI_OUT_OF_RESOURCES There is no sufficient resource to complete the operation.
@retval EFI_BUFFER_TOO_SMALL The number of non-empty block is bigger than the
number of input data blocks when build a fragment table.
diff --git a/NetworkPkg/Ip4Dxe/Ip4Output.h b/NetworkPkg/Ip4Dxe/Ip4Output.h index ae54f8b485ca..bb6fa641b090 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Output.h
+++ b/NetworkPkg/Ip4Dxe/Ip4Output.h
@@ -99,10 +99,10 @@ Ip4CancelPacket (
Fragment, Ttl, Protocol, Src and Dst. All the fields
are in host byte order. This function will fill in
the Ver, HeadLen, and checksum.
- @param Option The orginal IP4 option to copy from
+ @param Option The original IP4 option to copy from
@param OptLen The length of the IP4 option
- @retval EFI_BAD_BUFFER_SIZE There is no enought room in the head space of
+ @retval EFI_BAD_BUFFER_SIZE There is no enough room in the head
+ space of
Packet.
@retval EFI_SUCCESS The IP4 header is successfully added to the packet.
diff --git a/NetworkPkg/Ip4Dxe/Ip4Route.h b/NetworkPkg/Ip4Dxe/Ip4Route.h index 4b0b5282ab5a..b4d91667e959 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Route.h
+++ b/NetworkPkg/Ip4Dxe/Ip4Route.h
@@ -1,5 +1,5 @@
/** @file
- EFI IP4 route table and route cache table defintions.
+ EFI IP4 route table and route cache table definitions.
Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -56,8 +56,8 @@ typedef struct { /// /// The route cache table is organized as a hash table. Each /// IP4 route table has a embedded route cache. For now the -/// route cache and route table are binded togehter. But keep -/// the route cache a seperated structure in case we want to
+/// route cache and route table are binded together. But keep /// the
+route cache a separated structure in case we want to
/// detach them later.
///
typedef struct {
@@ -138,7 +138,7 @@ Ip4AddRoute (
@retval EFI_SUCCESS The route entry is successfully removed
@retval EFI_NOT_FOUND There is no route entry in the table with that
- properity.
+ property.
**/
EFI_STATUS
@@ -151,7 +151,7 @@ Ip4DelRoute (
/**
Find a route cache with the dst and src. This is used by ICMP
- redirect messasge process. All kinds of redirect is treated as
+ redirect message process. All kinds of redirect is treated as
host redirect according to RFC1122. So, only route cache entries
are modified according to the ICMP redirect message.
@@ -215,7 +215,7 @@ Ip4Route (
@param[in] IpInstance The IP4 child that requests the route table.
@retval EFI_SUCCESS The route table is successfully build
- @retval EFI_OUT_OF_RESOURCES Failed to allocate the memory for the rotue table.
+ @retval EFI_OUT_OF_RESOURCES Failed to allocate the memory for the route table.
**/
EFI_STATUS
diff --git a/NetworkPkg/Ip4Dxe/Ip4Common.c b/NetworkPkg/Ip4Dxe/Ip4Common.c index c756a2dbf7e4..f4269b8ea495 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Common.c
+++ b/NetworkPkg/Ip4Dxe/Ip4Common.c
@@ -9,7 +9,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
/**
- Return the cast type (Unicast/Boradcast) specific to an
+ Return the cast type (Unicast/Broadcast) specific to an
interface. All the addresses are host byte ordered.
@param[in] IpAddr The IP address to classify in host byte order
@@ -17,7 +17,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
@return The cast type of this IP address specific to the interface.
@retval IP4_LOCAL_HOST The IpAddr equals to the interface's address
- @retval IP4_SUBNET_BROADCAST The IpAddr is a directed subnet boradcast to the
+ @retval IP4_SUBNET_BROADCAST The IpAddr is a directed subnet
+ broadcast to the
interface
@retval IP4_NET_BROADCAST The IpAddr is a network broadcast to the interface
@retval 0 Otherwise.
@@ -182,7 +182,7 @@ Ip4FindNet (
Find an interface of the service with the same Ip/Netmask pair.
@param[in] IpSb Ip4 service binding instance
- @param[in] Ip The Ip adress to find (host byte order)
+ @param[in] Ip The Ip address to find (host byte order)
@param[in] Netmask The network to find (host byte order)
@return The IP4_INTERFACE point if found, otherwise NULL @@ -266,10 +266,10 @@ Ip4NtohHead (
/**
Validate that Ip/Netmask pair is OK to be used as station
address. Only continuous netmasks are supported. and check
- that StationAddress is a unicast address on the newtwork.
+ that StationAddress is a unicast address on the network.
@param[in] Ip The IP address to validate.
- @param[in] Netmask The netmaks of the IP.
+ @param[in] Netmask The netmask of the IP.
@retval TRUE The Ip/Netmask pair is valid.
@retval FALSE The Ip/Netmask pair is invalid.
diff --git a/NetworkPkg/Ip4Dxe/Ip4Config2Impl.c b/NetworkPkg/Ip4Dxe/Ip4Config2Impl.c
index 9dca48ddd645..9cfad5916d10 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Config2Impl.c
+++ b/NetworkPkg/Ip4Dxe/Ip4Config2Impl.c
@@ -174,7 +174,7 @@ Ip4Config2SignalEvent (
/**
Read the configuration data from variable storage according to the VarName and
gEfiIp4Config2ProtocolGuid. It checks the integrity of variable data. If the
- data is corrupted, it clears the variable data to ZERO. Othewise, it outputs the
+ data is corrupted, it clears the variable data to ZERO. Otherwise, it
+ outputs the
configuration data to IP4_CONFIG2_INSTANCE.
@param[in] VarName The pointer to the variable name
@@ -377,7 +377,7 @@ Ip4Config2WriteConfigData (
@param[out] Table The built IP4 route table.
@retval EFI_SUCCESS The route table is successfully build
- @retval EFI_NOT_FOUND Failed to allocate the memory for the rotue table.
+ @retval EFI_NOT_FOUND Failed to allocate the memory for the route table.
**/
EFI_STATUS
@@ -912,7 +912,7 @@ Ip4StartAutoConfig (
//
// A host must not invoke DHCP configuration if it is already
- // participating in the DHCP configuraiton process.
+ // participating in the DHCP configuration process.
//
if (Instance->Dhcp4Handle != NULL) {
return EFI_SUCCESS;
@@ -1234,7 +1234,7 @@ Ip4Config2SetPolicy (
under the current policy.
@retval EFI_INVALID_PARAMETER One or more fields in Data is invalid.
@retval EFI_OUT_OF_RESOURCES Fail to allocate resource to complete the operation.
- @retval EFI_NOT_READY An asynchrous process is invoked to set the specified
+ @retval EFI_NOT_READY An asynchronous process is invoked to set the specified
configuration data, and the process is not finished.
@retval EFI_ABORTED The manual addresses to be set equal current
configuration.
@@ -1721,7 +1721,7 @@ EfiIp4Config2SetData (
}
} else {
//
- // Another asynchornous process is on the way.
+ // Another asynchronous process is on the way.
//
Status = EFI_ACCESS_DENIED;
}
diff --git a/NetworkPkg/Ip4Dxe/Ip4Config2Nv.c b/NetworkPkg/Ip4Dxe/Ip4Config2Nv.c
index a4d2996a60e6..63014ca31907 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Config2Nv.c
+++ b/NetworkPkg/Ip4Dxe/Ip4Config2Nv.c
@@ -988,7 +988,7 @@ Failure:
@param[out] Progress A pointer to a string filled in with the
offset of the most recent '&' before the
first failing name / value pair (or the
- beginn ing of the string if the failure
+ beginning of the string if the failure
is in the first name / value pair) or
the terminating NULL if all was
successful.
@@ -1098,7 +1098,7 @@ Ip4FormRouteConfig (
variable and its data.
@retval EFI_DEVICE_ERROR The variable could not be saved.
@retval EFI_UNSUPPORTED The specified Action is not supported by the
- callback.Currently not implemented.
+ callback. Currently not implemented.
@retval EFI_INVALID_PARAMETERS Passing in wrong parameter.
@retval Others Other errors as indicated.
diff --git a/NetworkPkg/Ip4Dxe/Ip4Driver.c b/NetworkPkg/Ip4Dxe/Ip4Driver.c index 62be8b681a18..7fed659ca101 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Driver.c
+++ b/NetworkPkg/Ip4Dxe/Ip4Driver.c
@@ -581,7 +581,7 @@ Ip4DriverBindingStart (
Ip4Cfg2 = &IpSb->Ip4Config2Instance.Ip4Config2;
//
- // Install the Ip4ServiceBinding Protocol onto ControlerHandle
+ // Install the Ip4ServiceBinding Protocol onto ControllerHandle
//
Status = gBS->InstallMultipleProtocolInterfaces (
&ControllerHandle,
@@ -829,7 +829,7 @@ ON_ERROR:
then a new handle is created. If it is a pointer to an existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child @@ -933,7 +933,7 @@ ON_ERROR:
@param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param ChildHandle Handle of the child to destroy
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval EFI_ACCESS_DENIED The protocol could not be removed from the ChildHandle
@@ -1020,14 +1020,14 @@ Ip4ServiceBindingDestroyChild (
// Uninstall the IP4 protocol first. Many thing happens during
// this:
// 1. The consumer of the IP4 protocol will be stopped if it
- // opens the protocol BY_DRIVER. For eaxmple, if MNP driver is
+ // opens the protocol BY_DRIVER. For example, if MNP driver is
// stopped, IP driver's stop function will be called, and uninstall
// EFI_IP4_PROTOCOL will trigger the UDP's stop function. This
// makes it possible to create the network stack bottom up, and
// stop it top down.
// 2. the upper layer will recycle the received packet. The recycle
// event's TPL is higher than this function. The recycle events
- // will be called back before preceeding. If any packets not recycled,
+ // will be called back before preceding. If any packets not recycled,
// that means there is a resource leak.
//
gBS->RestoreTPL (OldTpl);
diff --git a/NetworkPkg/Ip4Dxe/Ip4If.c b/NetworkPkg/Ip4Dxe/Ip4If.c index 53a333037f94..db459e97c8a8 100644
--- a/NetworkPkg/Ip4Dxe/Ip4If.c
+++ b/NetworkPkg/Ip4Dxe/Ip4If.c
@@ -1,5 +1,5 @@
/** @file
- Implement IP4 pesudo interface.
+ Implement IP4 pseudo interface.
Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -9,13 +9,13 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include "Ip4Impl.h"
//
-// Mac address with all zero, used to determine whethter the ARP
+// Mac address with all zero, used to determine whether the ARP
// resolve succeeded. Failed ARP requests zero the MAC address buffer.
//
EFI_MAC_ADDRESS mZeroMacAddress;
/**
- Callback funtion when frame transmission is finished. It will
+ Callback function when frame transmission is finished. It will
call the frame owner's callback function to tell it the result.
@param[in] Context Context which is point to the token.
@@ -563,7 +563,7 @@ Ip4SetAddress (
//
// Set the ip/netmask, then compute the subnet broadcast
// and network broadcast for easy access. When computing
- // nework broadcast, the subnet mask is most like longer
+ // network broadcast, the subnet mask is most like longer
// than the default netmask (not subneted) as defined in
// RFC793. If that isn't the case, we are aggregating the
// networks, use the subnet's mask instead.
@@ -979,7 +979,7 @@ Ip4OnArpResolved (
/**
- Callback funtion when frame transmission is finished. It will
+ Callback function when frame transmission is finished. It will
call the frame owner's callback function to tell it the result.
@param[in] Context Context which is point to the token.
@@ -1251,7 +1251,7 @@ Ip4OnFrameReceivedDpc (
}
//
- // Wrap the frame in a net buffer then deliever it to IP input.
+ // Wrap the frame in a net buffer then deliver it to IP input.
// IP will reassemble the packet, and deliver it to upper layer
//
Netfrag.Len = MnpRxData->DataLength; @@ -1307,7 +1307,7 @@ Ip4OnFrameReceived (
@retval EFI_ALREADY_STARTED There is already a pending receive request.
@retval EFI_OUT_OF_RESOURCES Failed to allocate resource to receive.
- @retval EFI_SUCCESS The recieve request has been started.
+ @retval EFI_SUCCESS The receive request has been started.
@retval other Other error occurs.
**/
diff --git a/NetworkPkg/Ip4Dxe/Ip4Igmp.c b/NetworkPkg/Ip4Dxe/Ip4Igmp.c index e69b2fe7fc08..f69ba762fe4d 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Igmp.c
+++ b/NetworkPkg/Ip4Dxe/Ip4Igmp.c
@@ -149,7 +149,7 @@ Ip4FindMac (
@param[in] IpSb The IP4 service instance that requests the
transmission.
- @param[in] Dst The destinaton to send to.
+ @param[in] Dst The destination to send to.
@param[in] Type The IGMP message type, such as IGMP v1 membership
report.
@param[in] Group The group address in the IGMP message head.
@@ -273,7 +273,7 @@ Ip4JoinGroup (
//
// If the IP service already is a member in the group, just
- // increase the refernce count and return.
+ // increase the reference count and return.
//
Group = Ip4FindGroup (IgmpCtrl, Address);
@@ -587,7 +587,7 @@ Ip4CombineGroups (
@param Count The number of group addresses in the Groups.
@param Addr The IP4 multicast address to remove.
- @return The nubmer of group addresses in the Groups after remove.
+ @return The number of group addresses in the Groups after remove.
It is Count if the Addr isn't in the Groups.
**/
diff --git a/NetworkPkg/Ip4Dxe/Ip4Impl.c b/NetworkPkg/Ip4Dxe/Ip4Impl.c index ec6f0370772b..5935d405dd59 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Impl.c
+++ b/NetworkPkg/Ip4Dxe/Ip4Impl.c
@@ -198,7 +198,7 @@ EfiIp4Routes (
@retval EFI_NOT_STARTED This instance has not been started.
@retval EFI_NO_MAPPING When using the default address, configuration (DHCP, BOOTP,
RARP, etc.) is not finished yet.
- @retval EFI_INVALID_PARAMETER One or more pameters are invalid.
+ @retval EFI_INVALID_PARAMETER One or more parameters are invalid.
@retval EFI_ACCESS_DENIED The transmit completion token with the same Token.Event
was already in the transmit queue.
@retval EFI_NOT_READY The completion token could not be queued because the transmit
@@ -525,7 +525,7 @@ Ip4ServiceConfigMnp (
/**
- Intiialize the IP4_PROTOCOL structure to the unconfigured states.
+ Initialize the IP4_PROTOCOL structure to the unconfigured states.
@param IpSb The IP4 service instance.
@param IpInstance The IP4 child instance.
@@ -985,7 +985,7 @@ ON_EXIT:
@retval EFI_ALREADY_STARTED Want to join the group, but already a member of it.
@retval EFI_OUT_OF_RESOURCES Failed to allocate some resources.
- @retval EFI_DEVICE_ERROR Failed to set the group configuraton.
+ @retval EFI_DEVICE_ERROR Failed to set the group configuration.
@retval EFI_SUCCESS Successfully updated the group setting.
@retval EFI_NOT_FOUND Try to leave the group which it isn't a member.
@@ -1043,7 +1043,7 @@ Ip4Groups (
//
// Leave the group. Leave all the groups if GroupAddress is NULL.
// Must iterate from the end to the beginning because the GroupCount
- // is decreamented each time an address is removed..
+ // is decremented each time an address is removed..
//
for (Index = IpInstance->GroupCount; Index > 0 ; Index--) {
ASSERT (IpInstance->Groups != NULL); @@ -1283,7 +1283,7 @@ ON_EXIT:
@param[in] Map The container of either user's transmit or receive
token.
@param[in] Item Current item to check against.
- @param[in] Context The Token to check againist.
+ @param[in] Context The Token to check against.
@retval EFI_ACCESS_DENIED The token or event has already been enqueued in IP.
@retval EFI_SUCCESS The current item isn't the same token/event as the
@@ -1557,7 +1557,7 @@ Ip4OnPacketSent (
@retval EFI_NOT_STARTED This instance has not been started.
@retval EFI_NO_MAPPING When using the default address, configuration (DHCP, BOOTP,
RARP, etc.) is not finished yet.
- @retval EFI_INVALID_PARAMETER One or more pameters are invalid.
+ @retval EFI_INVALID_PARAMETER One or more parameters are invalid.
@retval EFI_ACCESS_DENIED The transmit completion token with the same Token.Event
was already in the transmit queue.
@retval EFI_NOT_READY The completion token could not be queued because the transmit
@@ -1619,7 +1619,7 @@ EfiIp4Transmit (
}
//
- // make sure that token is properly formated
+ // make sure that token is properly formatted
//
Status = Ip4TxTokenValid (Token, IpIf, Config->RawData);
diff --git a/NetworkPkg/Ip4Dxe/Ip4Input.c b/NetworkPkg/Ip4Dxe/Ip4Input.c index 24c584658803..fec242c71f4f 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Input.c
+++ b/NetworkPkg/Ip4Dxe/Ip4Input.c
@@ -387,7 +387,7 @@ Ip4Reassemble (
RemoveEntryList (&Assemble->Link);
//
- // If the packet is properly formated, the last fragment's End
+ // If the packet is properly formatted, the last fragment's End
// equals to the packet's total length. Otherwise, the packet
// is a fake, drop it now.
//
@@ -468,7 +468,7 @@ Ip4IpSecFree (
actions: bypass the packet, discard the packet, or protect the packet.
@param[in] IpSb The IP4 service instance.
- @param[in, out] Head The The caller supplied IP4 header.
+ @param[in, out] Head The caller supplied IP4 header.
@param[in, out] Netbuf The IP4 packet to be processed by IPsec.
@param[in, out] Options The caller supplied options.
@param[in, out] OptionsLen The length of the option.
@@ -480,7 +480,7 @@ Ip4IpSecFree (
@retval EFI_SUCCESS The packet was bypassed and all buffers remain the same.
@retval EFI_SUCCESS The packet was protected.
@retval EFI_ACCESS_DENIED The packet was discarded.
- @retval EFI_OUT_OF_RESOURCES There is no suffcient resource to complete the operation.
+ @retval EFI_OUT_OF_RESOURCES There is no sufficient resource to complete the operation.
@retval EFI_BUFFER_TOO_SMALL The number of non-empty block is bigger than the
number of input data blocks when build a fragment table.
@@ -625,7 +625,7 @@ Ip4IpSecProcessPacket (
}
//
- // Free orginal Netbuf.
+ // Free original Netbuf.
//
NetIpSecNetbufFree (*Netbuf);
*Netbuf = TxWrap->Packet;
@@ -689,8 +689,8 @@ ON_EXIT:
@param[in] Flag The link layer flag for the packet received, such
as multicast.
- @retval EFI_SEUCCESS The recieved packet is in well form.
- @retval EFI_INVAILD_PARAMETER The recieved packet is malformed.
+ @retval EFI_SUCCESS The received packet is in well form.
+ @retval EFI_INVALID_PARAMETER The received packet is malformed.
**/
EFI_STATUS
@@ -891,8 +891,8 @@ Ip4AccpetFrame (
ZeroMem (&ZeroHead, sizeof (IP4_HEAD));
if (0 == CompareMem (Head, &ZeroHead, sizeof (IP4_HEAD))) {
// Packet may have been changed. Head, HeadLen, TotalLen, and
- // info must be reloaded bofore use. The ownership of the packet
- // is transfered to the packet process logic.
+ // info must be reloaded before use. The ownership of the packet //
+ is transferred to the packet process logic.
//
Head = (IP4_HEAD *) NetbufGetByte (Packet, 0, NULL);
ASSERT (Head != NULL);
@@ -973,7 +973,7 @@ Ip4InstanceFrameAcceptable (
Config = &IpInstance->ConfigData;
//
- // Dirty trick for the Tiano UEFI network stack implmentation. If
+ // Dirty trick for the Tiano UEFI network stack implementation. If
// ReceiveTimeout == -1, the receive of the packet for this instance
// is disabled. The UEFI spec don't have such capability. We add
// this to improve the performance because IP will make a copy of @@ -1086,7 +1086,7 @@ Ip4InstanceEnquePacket (
}
//
- // Enque a shared copy of the packet.
+ // Enqueue a shared copy of the packet.
//
Clone = NetbufClone (Packet);
@@ -1365,7 +1365,7 @@ Ip4InterfaceEnquePacket (
//
// First, check that the packet is acceptable to this interface
// and find the local cast type for the interface. A packet sent
- // to say 192.168.1.1 should NOT be delliever to 10.0.0.1 unless
+ // to say 192.168.1.1 should NOT be deliver to 10.0.0.1 unless
// promiscuous receiving.
//
LocalType = 0;
@@ -1381,7 +1381,7 @@ Ip4InterfaceEnquePacket (
} else {
//
- // Check the destination againist local IP. If the station
+ // Check the destination against local IP. If the station
// address is 0.0.0.0, it means receiving all the IP destined
// to local non-zero IP. Otherwise, it is necessary to compare
// the destination to the interface's IP address.
@@ -1463,7 +1463,7 @@ Ip4InterfaceDeliverPacket (
/**
Demultiple the packet. the packet delivery is processed in two
- passes. The first pass will enque a shared copy of the packet
+ passes. The first pass will enqueue a shared copy of the packet
to each IP4 child that accepts the packet. The second pass will
deliver a non-shared copy of the packet to each IP4 child that
has pending receive requests. Data is copied if more than one @@ -1495,7 +1495,7 @@ Ip4Demultiplex (
INTN Enqueued;
//
- // Two pass delivery: first, enque a shared copy of the packet
+ // Two pass delivery: first, enqueue a shared copy of the packet
// to each instance that accept the packet.
//
Enqueued = 0;
diff --git a/NetworkPkg/Ip4Dxe/Ip4Option.c b/NetworkPkg/Ip4Dxe/Ip4Option.c index b3c598c64a38..0f6e444ce8be 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Option.c
+++ b/NetworkPkg/Ip4Dxe/Ip4Option.c
@@ -181,7 +181,7 @@ Ip4CopyOption (
//
// Head length is in the unit of 4 bytes. Now, Len is the
- // acutal option length to appear in the IP header.
+ // actual option length to appear in the IP header.
//
Len = ((Next + 3) &~0x03);
diff --git a/NetworkPkg/Ip4Dxe/Ip4Output.c b/NetworkPkg/Ip4Dxe/Ip4Output.c index 5eb3814089cb..c161b72542be 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Output.c
+++ b/NetworkPkg/Ip4Dxe/Ip4Output.c
@@ -21,10 +21,10 @@ UINT16 mIp4Id;
Fragment, Ttl, Protocol, Src and Dst. All the fields
are in host byte order. This function will fill in
the Ver, HeadLen, and checksum.
- @param Option The orginal IP4 option to copy from
+ @param Option The original IP4 option to copy from
@param OptLen The length of the IP4 option
- @retval EFI_BAD_BUFFER_SIZE There is no enought room in the head space of
+ @retval EFI_BAD_BUFFER_SIZE There is no enough room in the head
+ space of
Packet.
@retval EFI_SUCCESS The IP4 header is successfully added to the packet.
@@ -300,7 +300,7 @@ Ip4Output (
} else if (GateWay == IP4_ALLZERO_ADDRESS) {
//
- // Route the packet unless overrided, that is, GateWay isn't zero.
+ // Route the packet unless overridden, that is, GateWay isn't zero.
//
if (IpInstance == NULL) {
CacheEntry = Ip4Route (IpSb->DefaultRouteTable, Head->Dst, Head->Src, IpIf->SubnetMask, TRUE); @@ -331,7 +331,7 @@ Ip4Output (
if (Packet->TotalSize + HeadLen > Mtu) {
//
- // Fragmentation is diabled for RawData mode.
+ // Fragmentation is disabled for RawData mode.
//
if (RawData) {
return EFI_BAD_BUFFER_SIZE;
@@ -399,7 +399,7 @@ Ip4Output (
}
//
- // Send the first fragment, it is either the orginal packet, or the
+ // Send the first fragment, it is either the original packet, or the
// first fragment of a fragmented packet. It seems that there is a subtle
// bug here: what if the caller free the packet in Callback and IpIf (or
// MNP child used by that interface) still holds the fragments and try @@ -420,7 +420,7 @@ Ip4Output (
// is bound with the Packet. It will only be freed when all
// the references to Packet have been released. Upon then, the
// Packet's OnFree callback will release the IP4_TXTOKEN_WRAP,
- // and singal the user's recycle event. So, also no problem for
+ // and signal the user's recycle event. So, also no problem for
// upper layer's packets.
//
Ip4PrependHead (Packet, Head, Option, OptLen); diff --git a/NetworkPkg/Ip4Dxe/Ip4Route.c b/NetworkPkg/Ip4Dxe/Ip4Route.c index 124c0730ad87..386011934b19 100644
--- a/NetworkPkg/Ip4Dxe/Ip4Route.c
+++ b/NetworkPkg/Ip4Dxe/Ip4Route.c
@@ -9,14 +9,14 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
/**
- Allocate a route entry then initialize it with the Dest/Netmaks
+ Allocate a route entry then initialize it with the Dest/Netmask
and Gateway.
@param[in] Dest The destination network
@param[in] Netmask The destination network mask
@param[in] GateWay The nexthop address
- @return NULL if failed to allocate memeory, otherwise the newly created
+ @return NULL if failed to allocate memory, otherwise the newly
+ created
route entry.
**/
@@ -129,7 +129,7 @@ Ip4FreeRouteCacheEntry (
/**
Initialize an empty route cache table.
- @param[in, out] RtCache The rotue cache table to initialize.
+ @param[in, out] RtCache The route cache table to initialize.
**/
VOID
@@ -359,7 +359,7 @@ Ip4AddRoute (
@retval EFI_SUCCESS The route entry is successfully removed
@retval EFI_NOT_FOUND There is no route entry in the table with that
- properity.
+ property.
**/
EFI_STATUS
@@ -396,7 +396,7 @@ Ip4DelRoute (
/**
Find a route cache with the dst and src. This is used by ICMP
- redirect messasge process. All kinds of redirect is treated as
+ redirect message process. All kinds of redirect is treated as
host redirect according to RFC1122. So, only route cache entries
are modified according to the ICMP redirect message.
@@ -444,7 +444,7 @@ Ip4FindRouteCache (
2. The local route entries have precedence over the default route entry.
@param[in] RtTable The route table to search from
- @param[in] Dst The destionation address to search
+ @param[in] Dst The destination address to search
@return NULL if no route matches the Dst, otherwise the point to the
most specific route to the Dst.
@@ -605,7 +605,7 @@ Ip4Route (
@param[in] IpInstance The IP4 child that requests the route table.
@retval EFI_SUCCESS The route table is successfully build
- @retval EFI_OUT_OF_RESOURCES Failed to allocate the memory for the rotue table.
+ @retval EFI_OUT_OF_RESOURCES Failed to allocate the memory for the route table.
**/
EFI_STATUS
--
2.21.0
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
^ permalink raw reply related [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-50-philmd@redhat.com>]
* Re: [PATCH 49/79] NetworkPkg/TcpDxe/Sock: Fix few typos
[not found] ` <20191203161602.15969-50-philmd@redhat.com>
@ 2019-12-06 16:04 ` Rabeda, Maciej
0 siblings, 0 replies; 122+ messages in thread
From: Rabeda, Maciej @ 2019-12-06 16:04 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Wu, Jiaxin, Fu, Siyuan
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
Thanks!
Maciej
-----Original Message-----
From: Philippe Mathieu-Daude <philmd@redhat.com>
Sent: Tuesday, December 3, 2019 17:16
To: devel@edk2.groups.io
Cc: Antoine Coeur <coeur@gmx.fr>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
Subject: [PATCH 49/79] NetworkPkg/TcpDxe/Sock: Fix few typos
From: Antoine Coeur <coeur@gmx.fr>
Fix few typos in comments and documentation.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/TcpDxe/SockImpl.h | 2 +-
NetworkPkg/TcpDxe/Socket.h | 36 ++++++++++----------
NetworkPkg/TcpDxe/SockImpl.c | 4 +--
NetworkPkg/TcpDxe/SockInterface.c | 10 +++---
4 files changed, 26 insertions(+), 26 deletions(-)
diff --git a/NetworkPkg/TcpDxe/SockImpl.h b/NetworkPkg/TcpDxe/SockImpl.h index f255b2fb5fad..5ec0435592d7 100644
--- a/NetworkPkg/TcpDxe/SockImpl.h
+++ b/NetworkPkg/TcpDxe/SockImpl.h
@@ -93,7 +93,7 @@ SockCancelToken (
@param[in] SockInitData Pointer to the initial data of the socket.
- @return Pointer to the newly created socket, return NULL when exception occured.
+ @return Pointer to the newly created socket, return NULL when exception occurred.
**/
SOCKET *
diff --git a/NetworkPkg/TcpDxe/Socket.h b/NetworkPkg/TcpDxe/Socket.h index 874708ea575a..9448710a916a 100644
--- a/NetworkPkg/TcpDxe/Socket.h
+++ b/NetworkPkg/TcpDxe/Socket.h
@@ -107,8 +107,8 @@
@param[in] Sock Pointer to the socket.
- @retval TRUE The socket is unconfigued.
- @retval FALSE The socket is not unconfigued.
+ @retval TRUE The socket is unconfigured.
+ @retval FALSE The socket is not unconfigured.
**/
#define SOCK_IS_UNCONFIGURED(Sock) ((Sock)->ConfigureState == SO_UNCONFIGURED) @@ -118,8 +118,8 @@
@param[in] Sock Pointer to the socket
- @retval TRUE The socket is configued
- @retval FALSE The socket is not configued
+ @retval TRUE The socket is configured
+ @retval FALSE The socket is not configured
**/
#define SOCK_IS_CONFIGURED(Sock) \
@@ -131,8 +131,8 @@
@param[in] Sock Pointer to the socket.
- @retval TRUE The socket is configued to active mode.
- @retval FALSE The socket is not configued to active mode.
+ @retval TRUE The socket is configured to active mode.
+ @retval FALSE The socket is not configured to active mode.
**/
#define SOCK_IS_CONFIGURED_ACTIVE(Sock) ((Sock)->ConfigureState == SO_CONFIGURED_ACTIVE) @@ -142,8 +142,8 @@
@param[in] Sock Pointer to the socket.
- @retval TRUE The socket is configued to passive mode.
- @retval FALSE The socket is not configued to passive mode.
+ @retval TRUE The socket is configured to passive mode.
+ @retval FALSE The socket is not configured to passive mode.
**/
#define SOCK_IS_CONNECTED_PASSIVE(Sock) ((Sock)->ConfigureState == SO_CONFIGURED_PASSIVE) @@ -380,13 +380,13 @@ EFI_STATUS
);
/**
- The Callback funtion called after the TCP socket is created.
+ The Callback function called after the TCP socket is created.
@param[in] This Pointer to the socket just created.
@param[in] Context Context of the socket.
@retval EFI_SUCCESS This protocol installed successfully.
- @retval other Some error occured.
+ @retval other Some error occurred.
**/
typedef
@@ -429,7 +429,7 @@ typedef struct _SOCK_INIT_DATA {
// Callbacks after socket is created and before socket is to be destroyed.
//
SOCK_CREATE_CALLBACK CreateCallback; ///< Callback after created
- SOCK_DESTROY_CALLBACK DestroyCallback; ///< Callback before destroied
+ SOCK_DESTROY_CALLBACK DestroyCallback; ///< Callback before
+ destroyed
VOID *Context; ///< The context of the callback
//
@@ -501,7 +501,7 @@ struct _TCP_SOCKET {
// Callbacks after socket is created and before socket is to be destroyed.
//
SOCK_CREATE_CALLBACK CreateCallback; ///< Callback after created
- SOCK_DESTROY_CALLBACK DestroyCallback; ///< Callback before destroied
+ SOCK_DESTROY_CALLBACK DestroyCallback; ///< Callback before destroyed
VOID *Context; ///< The context of the callback
};
@@ -512,7 +512,7 @@ typedef struct _SOCK_TOKEN {
LIST_ENTRY TokenList; ///< The entry to add in the token list
SOCK_COMPLETION_TOKEN *Token; ///< The application's token
UINT32 RemainDataLen; ///< Unprocessed data length
- SOCKET *Sock; ///< The poninter to the socket this token
+ SOCKET *Sock; ///< The pointer to the socket this token
///< belongs to } SOCK_TOKEN;
@@ -524,7 +524,7 @@ typedef struct _TCP_RSV_DATA { } TCP_RSV_DATA;
//
-// Socket provided oprerations for low layer protocol implemented in SockImpl.c
+// Socket provided operations for low layer protocol implemented in
+SockImpl.c
//
/**
@@ -676,12 +676,12 @@ SockNoMoreData (
/**
Create a socket and its associated protocol control block
- with the intial data SockInitData and protocol specific
+ with the initial data SockInitData and protocol specific
data ProtoData.
- @param[in] SockInitData Inital data to setting the socket.
+ @param[in] SockInitData Initial data to setting the socket.
- @return Pointer to the newly created socket. If NULL, an error condition occured.
+ @return Pointer to the newly created socket. If NULL, an error condition occurred.
**/
SOCKET *
@@ -723,7 +723,7 @@ SockConfigure (
/**
Initiate a connection establishment process.
- @param[in] Sock Pointer to the socket to initiate the initate the
+ @param[in] Sock Pointer to the socket to initiate the
connection.
@param[in] Token Pointer to the token used for the connection
operation.
diff --git a/NetworkPkg/TcpDxe/SockImpl.c b/NetworkPkg/TcpDxe/SockImpl.c index fb28e2ed40d3..564e621ef93b 100644
--- a/NetworkPkg/TcpDxe/SockImpl.c
+++ b/NetworkPkg/TcpDxe/SockImpl.c
@@ -89,7 +89,7 @@ SockFreeFoo (
@param[in] BufLen The maximum length of the data buffer to
store the received data in the socket layer.
- @return The length of the data can be retreived.
+ @return The length of the data can be retrieved.
**/
UINT32
@@ -270,7 +270,7 @@ SockProcessSndToken (
);
//
- // Proceess it in the light of SockType
+ // Process it in the light of SockType
//
SndToken = (SOCK_IO_TOKEN *) SockToken->Token;
TxData = SndToken->Packet.TxData;
diff --git a/NetworkPkg/TcpDxe/SockInterface.c b/NetworkPkg/TcpDxe/SockInterface.c
index ed0a031d3964..6217eb52dac5 100644
--- a/NetworkPkg/TcpDxe/SockInterface.c
+++ b/NetworkPkg/TcpDxe/SockInterface.c
@@ -255,12 +255,12 @@ SockDestroyChild (
/**
Create a socket and its associated protocol control block
- with the intial data SockInitData and protocol specific
+ with the initial data SockInitData and protocol specific
data ProtoData.
- @param[in] SockInitData Inital data to setting the socket.
+ @param[in] SockInitData Initial data to setting the socket.
- @return Pointer to the newly created socket. If NULL, an error condition occured.
+ @return Pointer to the newly created socket. If NULL, an error condition occurred.
**/
SOCKET *
@@ -397,7 +397,7 @@ OnExit:
/**
Initiate a connection establishment process.
- @param[in] Sock Pointer to the socket to initiate the initate the
+ @param[in] Sock Pointer to the socket to initiate the
connection.
@param[in] Token Pointer to the token used for the connection
operation.
@@ -474,7 +474,7 @@ OnExit:
@param[in] Sock Pointer to the socket to accept connections.
@param[in] Token The token to accept a connection.
- @retval EFI_SUCCESS Either a connection is accpeted or the Token is
+ @retval EFI_SUCCESS Either a connection is accepted or the Token is
buffered for further acception.
@retval EFI_ACCESS_DENIED Failed to get the lock to access the socket, or the
socket is closed, or the socket is not configured to
--
2.21.0
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
^ permalink raw reply related [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-48-philmd@redhat.com>]
* Re: [PATCH 47/79] NetworkPkg/Mtftp6Dxe: Fix various typos
[not found] ` <20191203161602.15969-48-philmd@redhat.com>
@ 2019-12-06 16:05 ` Rabeda, Maciej
0 siblings, 0 replies; 122+ messages in thread
From: Rabeda, Maciej @ 2019-12-06 16:05 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Wu, Jiaxin, Fu, Siyuan
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
Thanks!
Maciej
-----Original Message-----
From: Philippe Mathieu-Daude <philmd@redhat.com>
Sent: Tuesday, December 3, 2019 17:16
To: devel@edk2.groups.io
Cc: Antoine Coeur <coeur@gmx.fr>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
Subject: [PATCH 47/79] NetworkPkg/Mtftp6Dxe: Fix various typos
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in documentation, comments and strings.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/Mtftp6Dxe/Mtftp6Driver.h | 4 ++--
NetworkPkg/Mtftp6Dxe/Mtftp6Impl.h | 4 ++--
NetworkPkg/Mtftp6Dxe/Mtftp6Option.h | 2 +- NetworkPkg/Mtftp6Dxe/Mtftp6Support.h | 2 +- NetworkPkg/Mtftp6Dxe/Mtftp6Driver.c | 4 ++--
NetworkPkg/Mtftp6Dxe/Mtftp6Impl.c | 4 ++--
NetworkPkg/Mtftp6Dxe/Mtftp6Option.c | 4 ++--
NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c | 8 ++++----
NetworkPkg/Mtftp6Dxe/Mtftp6Support.c | 8 ++++----
NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c | 2 +-
10 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Driver.h b/NetworkPkg/Mtftp6Dxe/Mtftp6Driver.h
index 30e6c8a3e1ab..86e8c6a77151 100644
--- a/NetworkPkg/Mtftp6Dxe/Mtftp6Driver.h
+++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Driver.h
@@ -108,7 +108,7 @@ Mtftp6DriverBindingStop (
then a new handle is created. If it is a pointer to an existing
UEFI handle, then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval Others The child handle was not created.
@@ -130,7 +130,7 @@ Mtftp6ServiceBindingCreateChild (
@param[in] This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param[in] ChildHandle Handle of the child to destroy.
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval Others The child handle was not destroyed
diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Impl.h b/NetworkPkg/Mtftp6Dxe/Mtftp6Impl.h
index 2c557b1928f6..321fbc1d5202 100644
--- a/NetworkPkg/Mtftp6Dxe/Mtftp6Impl.h
+++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Impl.h
@@ -179,11 +179,11 @@ EfiMtftp6GetModeData (
- This is NULL.
- MtftpConfigData.StationIp is neither zero nor one
of the configured IP addresses in the underlying IPv6 driver.
- - MtftpCofigData.ServerIp is not a valid IPv6 unicast address.
+ - MtftpConfigData.ServerIp is not a valid IPv6 unicast address.
Note: It does not match the UEFI 2.3 Specification.
@retval EFI_ACCESS_DENIED - The configuration could not be changed at this time because there
is some MTFTP background operation in progress.
- - MtftpCofigData.LocalPort is already in use.
+ - MtftpConfigData.LocalPort is already in use.
Note: It does not match the UEFI 2.3 Specification.
@retval EFI_NO_MAPPING The underlying IPv6 driver was responsible for choosing a source
address for this instance, but no source address was available for use.
diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Option.h b/NetworkPkg/Mtftp6Dxe/Mtftp6Option.h
index 6dab4b1e71f6..ad12a7e4d0e2 100644
--- a/NetworkPkg/Mtftp6Dxe/Mtftp6Option.h
+++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Option.h
@@ -66,7 +66,7 @@ Mtftp6ParseMcastOption (
/**
- Parse the MTFTP6 extesion options.
+ Parse the MTFTP6 extension options.
@param[in] Options The pointer to the extension options list.
@param[in] Count The num of the extension options.
diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Support.h b/NetworkPkg/Mtftp6Dxe/Mtftp6Support.h
index 5712601fc388..2b8a58f9de50 100644
--- a/NetworkPkg/Mtftp6Dxe/Mtftp6Support.h
+++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Support.h
@@ -334,7 +334,7 @@ Mtftp6RrqInput (
/**
Start the Mtftp6 instance to download. It first initializes some
- of the internal states then builds and sends an RRQ reqeuest packet.
+ of the internal states then builds and sends an RRQ request packet.
Finally, it starts receive for the downloading.
@param[in] Instance The pointer to the Mtftp6 instance.
diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Driver.c b/NetworkPkg/Mtftp6Dxe/Mtftp6Driver.c
index 18cdcddbe917..a19a67a1ce7e 100644
--- a/NetworkPkg/Mtftp6Dxe/Mtftp6Driver.c
+++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Driver.c
@@ -538,7 +538,7 @@ Mtftp6DriverBindingStop (
then a new handle is created. If it is a pointer to an existing
UEFI handle, then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval Others The child handle was not created.
@@ -637,7 +637,7 @@ ON_ERROR:
@param[in] This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param[in] ChildHandle Handle of the child to destroy.
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval Others The child handle was not destroyed
diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Impl.c b/NetworkPkg/Mtftp6Dxe/Mtftp6Impl.c
index 92c9d5cb392f..067b1f53ba06 100644
--- a/NetworkPkg/Mtftp6Dxe/Mtftp6Impl.c
+++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Impl.c
@@ -109,11 +109,11 @@ EfiMtftp6GetModeData (
- This is NULL.
- MtftpConfigData.StationIp is neither zero nor one
of the configured IP addresses in the underlying IPv6 driver.
- - MtftpCofigData.ServerIp is not a valid IPv6 unicast address.
+ - MtftpConfigData.ServerIp is not a valid IPv6 unicast address.
Note: It does not match the UEFI 2.3 Specification.
@retval EFI_ACCESS_DENIED - The configuration could not be changed at this time because there
is some MTFTP background operation in progress.
- - MtftpCofigData.LocalPort is already in use.
+ - MtftpConfigData.LocalPort is already in use.
Note: It does not match the UEFI 2.3 Specification.
@retval EFI_NO_MAPPING The underlying IPv6 driver was responsible for choosing a source
address for this instance, but no source address was available for use.
diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Option.c b/NetworkPkg/Mtftp6Dxe/Mtftp6Option.c
index 2a83af9878d5..16e622c65a7e 100644
--- a/NetworkPkg/Mtftp6Dxe/Mtftp6Option.c
+++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Option.c
@@ -42,7 +42,7 @@ Mtftp6ParseMcastOption (
CHAR8 *TempStr;
//
- // The multicast option is formated like "addr,port,mc"
+ // The multicast option is formatted like "addr,port,mc"
// The server can also omit the ip and port, use ",,1"
//
if (*Str == ',') {
@@ -135,7 +135,7 @@ Mtftp6ParseMcastOption (
/**
- Parse the MTFTP6 extesion options.
+ Parse the MTFTP6 extension options.
@param[in] Options The pointer to the extension options list.
@param[in] Count The num of the extension options.
diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c b/NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c
index a830d432916c..4935933f2312 100644
--- a/NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c
+++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c
@@ -742,7 +742,7 @@ Mtftp6RrqInput (
//
// For the subsequent exchange of requests, reconfigure the udpio as
// (serverip, serverport, localip, localport).
- // Ususally, the client set serverport as 0 to receive and reset it
+ // Usually, the client set serverport as 0 to receive and reset
+ it
// once the first packet arrives to send ack.
//
Instance->ServerDataPort = UdpEpt->RemotePort; @@ -851,7 +851,7 @@ Mtftp6RrqInput (
default:
//
- // Drop and return eror if received error message.
+ // Drop and return error if received error message.
//
Status = EFI_TFTP_ERROR;
break;
@@ -896,7 +896,7 @@ ON_EXIT:
/**
Start the Mtftp6 instance to download. It first initializes some
- of the internal states, then builds and sends an RRQ reqeuest packet.
+ of the internal states, then builds and sends an RRQ request packet.
Finally, it starts receive for the downloading.
@param[in] Instance The pointer to the Mtftp6 instance.
@@ -917,7 +917,7 @@ Mtftp6RrqStart (
//
// The valid block number range are [1, 0xffff]. For example:
// the client sends an RRQ request to the server, the server
- // transfers the DATA1 block. If option negoitation is ongoing,
+ // transfers the DATA1 block. If option negotiation is ongoing,
// the server will send back an OACK, then client will send ACK0.
//
Status = Mtftp6InitBlockRange (&Instance->BlkList, 1, 0xffff); diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Support.c b/NetworkPkg/Mtftp6Dxe/Mtftp6Support.c
index 5b10da52c389..1157a6065cac 100644
--- a/NetworkPkg/Mtftp6Dxe/Mtftp6Support.c
+++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Support.c
@@ -46,7 +46,7 @@ Mtftp6AllocateRange (
Initialize the block range for either RRQ or WRQ. RRQ and WRQ have
different requirements for Start and End. For example, during startup,
WRQ initializes its whole valid block range to [0, 0xffff]. This
- is bacause the server will send an ACK0 to inform the user to start the
+ is because the server will send an ACK0 to inform the user to start
+ the
upload. When the client receives an ACK0, it will remove 0 from the range,
get the next block number, which is 1, then upload the BLOCK1. For RRQ
without option negotiation, the server will directly send the BLOCK1 @@ -197,7 +197,7 @@ Mtftp6RemoveBlockNum (
// 3. (Start < Num) && (End >= Num):
// if End == Num, only need to decrease the End by one because
// we have (Start < Num) && (Num == End), so (Start <= End - 1).
- // if (End > Num), the hold is splited into two holes, with
+ // if (End > Num), the hold is split into two holes, with
// [Start, Num - 1] and [Num + 1, End].
//
if (Range->Start > Num) {
@@ -991,7 +991,7 @@ Mtftp6OperationClean (
write file, and read directory.
@param[in] This The MTFTP session.
- @param[in] Token The token than encapsues the user's request.
+ @param[in] Token The token than encapsules the user's request.
@param[in] OpCode The operation to perform.
@retval EFI_INVALID_PARAMETER Some of the parameters are invalid.
@@ -1227,7 +1227,7 @@ Mtftp6OnTimerTick (
}
//
- // Retransmit the packet if haven't reach the maxmium retry count,
+ // Retransmit the packet if haven't reach the maximum retry count,
// otherwise exit the transfer.
//
if (Instance->CurRetry < Instance->MaxRetry) { diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c b/NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c
index ce3315cc2c26..1ccdc6e32b62 100644
--- a/NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c
+++ b/NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c
@@ -174,7 +174,7 @@ Mtftp6WrqHandleAck (
if (Expected < 0) {
//
- // The block range is empty. It may either because the the last
+ // The block range is empty. It may either because the last
// block has been ACKed, or the sequence number just looped back,
// that is, there is more than 0xffff blocks.
//
--
2.21.0
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
^ permalink raw reply related [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-46-philmd@redhat.com>]
* Re: [PATCH 45/79] NetworkPkg/MnpDxe: Fix various typos
[not found] ` <20191203161602.15969-46-philmd@redhat.com>
@ 2019-12-06 16:05 ` Rabeda, Maciej
0 siblings, 0 replies; 122+ messages in thread
From: Rabeda, Maciej @ 2019-12-06 16:05 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Wu, Jiaxin, Fu, Siyuan
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
Thanks!
Maciej
-----Original Message-----
From: Philippe Mathieu-Daude <philmd@redhat.com>
Sent: Tuesday, December 3, 2019 17:15
To: devel@edk2.groups.io
Cc: Antoine Coeur <coeur@gmx.fr>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
Subject: [PATCH 45/79] NetworkPkg/MnpDxe: Fix various typos
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in documentation, comments and debug strings.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/MnpDxe/MnpDxe.inf | 2 +-
NetworkPkg/MnpDxe/MnpDriver.h | 6 +++---
NetworkPkg/MnpDxe/MnpImpl.h | 14 +++++++-------
NetworkPkg/MnpDxe/MnpConfig.c | 14 +++++++------- NetworkPkg/MnpDxe/MnpDriver.c | 10 +++++-----
NetworkPkg/MnpDxe/MnpIo.c | 8 ++++----
NetworkPkg/MnpDxe/MnpMain.c | 6 +++---
NetworkPkg/MnpDxe/MnpDxe.uni | 4 ++--
8 files changed, 32 insertions(+), 32 deletions(-)
diff --git a/NetworkPkg/MnpDxe/MnpDxe.inf b/NetworkPkg/MnpDxe/MnpDxe.inf index 7280060dded1..608e52aa51d8 100644
--- a/NetworkPkg/MnpDxe/MnpDxe.inf
+++ b/NetworkPkg/MnpDxe/MnpDxe.inf
@@ -1,5 +1,5 @@
## @file
-# This module produces EFI MNP Protocol, EFI MNP Servie Binding Protocol and EFI VLAN Protocol.
+# This module produces EFI MNP Protocol, EFI MNP Service Binding Protocol and EFI VLAN Protocol.
#
# This module produces EFI Managed Network Protocol upon EFI Simple Network Protocol, # to provide raw asynchronous network I/O services. It also produces EFI VLAN Protocol diff --git a/NetworkPkg/MnpDxe/MnpDriver.h b/NetworkPkg/MnpDxe/MnpDriver.h index 150d21e9ec16..4837cd0534b2 100644
--- a/NetworkPkg/MnpDxe/MnpDriver.h
+++ b/NetworkPkg/MnpDxe/MnpDriver.h
@@ -1,5 +1,5 @@
/** @file
- Declaration of strctures and functions for MnpDxe driver.
+ Declaration of structures and functions for MnpDxe driver.
Copyright (c) 2005 - 2016, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -223,7 +223,7 @@ MnpDriverBindingStop (
it is not NULL, then the I/O services are added
to the existing child handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to
create the child.
@@ -248,7 +248,7 @@ MnpServiceBindingCreateChild (
instance.
@param[in] ChildHandle Handle of the child to destroy.
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that
is being removed.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
diff --git a/NetworkPkg/MnpDxe/MnpImpl.h b/NetworkPkg/MnpDxe/MnpImpl.h index 7d5424034659..e91408c6c9bd 100644
--- a/NetworkPkg/MnpDxe/MnpImpl.h
+++ b/NetworkPkg/MnpDxe/MnpImpl.h
@@ -284,7 +284,7 @@ MnpFlushRcvdDataQueue (
@param[in, out] Instance Pointer to the mnp instance context data.
@param[in] ConfigData Pointer to the configuration data used to configure
- the isntance.
+ the instance.
@retval EFI_SUCCESS The Instance is configured.
@retval EFI_UNSUPPORTED EnableReceiveTimestamps is on and the
@@ -361,12 +361,12 @@ MnpBuildTxPacket (
/**
Synchronously send out the packet.
- This functon places the packet buffer to SNP driver's tansmit queue. The packet
- can be considered successfully sent out once SNP acccetp the packet, while the
+ This function places the packet buffer to SNP driver's tansmit queue.
+ The packet can be considered successfully sent out once SNP accept
+ the packet, while the
packet buffer recycle is deferred for better performance.
@param[in] MnpServiceData Pointer to the mnp service context data.
- @param[in] Packet Pointer to the pakcet buffer.
+ @param[in] Packet Pointer to the packet buffer.
@param[in] Length The length of the packet.
@param[in, out] Token Pointer to the token the packet generated from.
@@ -404,7 +404,7 @@ MnpInstanceDeliverPacket (
packet.
@param[in] Event The event this notify function registered to.
- @param[in] Context Pointer to the context data registerd to the Event.
+ @param[in] Context Pointer to the context data registered to the Event.
**/
VOID
@@ -480,8 +480,8 @@ MnpAllocTxBuf (
@param[in, out] MnpDeviceData Pointer to the mnp device context data.
- @retval EFI_SUCCESS Successed to recyclethe transmitted buffer address.
- @retval Others Failed to recyclethe transmitted buffer address.
+ @retval EFI_SUCCESS Successed to recycle the transmitted buffer address.
+ @retval Others Failed to recycle the transmitted buffer address.
**/
EFI_STATUS
diff --git a/NetworkPkg/MnpDxe/MnpConfig.c b/NetworkPkg/MnpDxe/MnpConfig.c index 5906ad546fb2..416be0bbb65a 100644
--- a/NetworkPkg/MnpDxe/MnpConfig.c
+++ b/NetworkPkg/MnpDxe/MnpConfig.c
@@ -707,7 +707,7 @@ MnpCreateServiceData (
//
MnpServiceData = AllocateZeroPool (sizeof (MNP_SERVICE_DATA));
if (MnpServiceData == NULL) {
- DEBUG ((EFI_D_ERROR, "MnpCreateServiceData: Faild to allocate memory for the new Mnp Service Data.\n"));
+ DEBUG ((EFI_D_ERROR, "MnpCreateServiceData: Failed to allocate
+ memory for the new Mnp Service Data.\n"));
return NULL;
}
@@ -742,7 +742,7 @@ MnpCreateServiceData (
&MnpServiceData->DevicePath
);
if (MnpServiceHandle == NULL) {
- DEBUG ((EFI_D_ERROR, "MnpCreateServiceData: Faild to create child handle.\n"));
+ DEBUG ((EFI_D_ERROR, "MnpCreateServiceData: Failed to create
+ child handle.\n"));
return NULL;
}
@@ -1325,7 +1325,7 @@ MnpStop (
if (MnpDeviceData->ConfiguredChildrenNumber > 0) {
//
- // If there are other configured chilren, return and keep the timers and
+ // If there are other configured children, return and keep the
+ timers and
// simple network unchanged.
//
return EFI_SUCCESS;
@@ -1402,7 +1402,7 @@ MnpFlushRcvdDataQueue (
@param[in, out] Instance Pointer to the mnp instance context data.
@param[in] ConfigData Pointer to the configuration data used to configure
- the isntance.
+ the instance.
@retval EFI_SUCCESS The Instance is configured.
@retval EFI_UNSUPPORTED EnableReceiveTimestamps is on and the
@@ -1605,7 +1605,7 @@ MnpConfigReceiveFilters (
EnableFilterBits |= EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST;
//
- // Allocate pool for the mulicast addresses.
+ // Allocate pool for the multicast addresses.
//
MCastFilterCnt = MnpDeviceData->GroupAddressCount;
MCastFilter = AllocatePool (sizeof (EFI_MAC_ADDRESS) * MCastFilterCnt);
@@ -1696,7 +1696,7 @@ MnpConfigReceiveFilters (
@param[in, out] Instance Pointer to the mnp instance context data.
@param[in, out] CtrlBlk Pointer to the group address control block.
- @param[in, out] GroupAddress Pointer to the group adress.
+ @param[in, out] GroupAddress Pointer to the group address.
@param[in] MacAddress Pointer to the mac address.
@param[in] HwAddressSize The hardware address size.
@@ -1851,7 +1851,7 @@ MnpGroupOp (
if (JoinFlag) {
//
- // A new gropu address is to be added.
+ // A new group address is to be added.
//
GroupAddress = NULL;
AddressExist = FALSE;
diff --git a/NetworkPkg/MnpDxe/MnpDriver.c b/NetworkPkg/MnpDxe/MnpDriver.c index e99e7c5a6166..e27dcf940b7f 100644
--- a/NetworkPkg/MnpDxe/MnpDriver.c
+++ b/NetworkPkg/MnpDxe/MnpDriver.c
@@ -110,7 +110,7 @@ MnpDriverBindingSupported (
}
//
- // Close the openned SNP protocol.
+ // Close the opened SNP protocol.
//
gBS->CloseProtocol (
ControllerHandle,
@@ -419,7 +419,7 @@ MnpDriverBindingStop (
it is not NULL, then the I/O services are added
to the existing child handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to
create the child.
@@ -450,7 +450,7 @@ MnpServiceBindingCreateChild (
//
Instance = AllocateZeroPool (sizeof (MNP_INSTANCE_DATA));
if (Instance == NULL) {
- DEBUG ((EFI_D_ERROR, "MnpServiceBindingCreateChild: Faild to allocate memory for the new instance.\n"));
+ DEBUG ((EFI_D_ERROR, "MnpServiceBindingCreateChild: Failed to
+ allocate memory for the new instance.\n"));
return EFI_OUT_OF_RESOURCES;
}
@@ -535,7 +535,7 @@ ErrorExit:
instance.
@param[in] ChildHandle Handle of the child to destroy.
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that
is being removed.
@retval EFI_INVALID_PARAMETER ChildHandle is NULL.
@@ -660,7 +660,7 @@ MnpServiceBindingDestroyChild (
@param[in] ImageHandle The image handle of the driver.
@param[in] SystemTable The system table.
- @retval EFI_SUCCES The driver binding and component name protocols are
+ @retval EFI_SUCCESS The driver binding and component name protocols are
successfully installed.
@retval Others Other errors as indicated.
diff --git a/NetworkPkg/MnpDxe/MnpIo.c b/NetworkPkg/MnpDxe/MnpIo.c index 56405d62b5e0..ae4a18fd81ac 100644
--- a/NetworkPkg/MnpDxe/MnpIo.c
+++ b/NetworkPkg/MnpDxe/MnpIo.c
@@ -190,12 +190,12 @@ MnpBuildTxPacket (
/**
Synchronously send out the packet.
- This functon places the packet buffer to SNP driver's tansmit queue. The packet
- can be considered successfully sent out once SNP acccetp the packet, while the
+ This function places the packet buffer to SNP driver's tansmit queue.
+ The packet can be considered successfully sent out once SNP accept
+ the packet, while the
packet buffer recycle is deferred for better performance.
@param[in] MnpServiceData Pointer to the mnp service context data.
- @param[in] Packet Pointer to the pakcet buffer.
+ @param[in] Packet Pointer to the packet buffer.
@param[in] Length The length of the packet.
@param[in, out] Token Pointer to the token the packet generated from.
@@ -422,7 +422,7 @@ MnpDeliverPacket (
packet.
@param[in] Event The event this notify function registered to.
- @param[in] Context Pointer to the context data registerd to the Event.
+ @param[in] Context Pointer to the context data registered to the Event.
**/
VOID
diff --git a/NetworkPkg/MnpDxe/MnpMain.c b/NetworkPkg/MnpDxe/MnpMain.c index d96178a1d994..ff7e89de103e 100644
--- a/NetworkPkg/MnpDxe/MnpMain.c
+++ b/NetworkPkg/MnpDxe/MnpMain.c
@@ -376,8 +376,8 @@ MnpGroups (
if ((!Instance->ConfigData.EnableMulticastReceive) ||
((MacAddress != NULL) && !NET_MAC_IS_MULTICAST (MacAddress, &SnpMode->BroadcastAddress, SnpMode->HwAddressSize))) {
//
- // The instance isn't configured to do mulitcast receive. OR
- // the passed in MacAddress is not a mutlticast mac address.
+ // The instance isn't configured to do multicast receive. OR
+ // the passed in MacAddress is not a multicast mac address.
//
Status = EFI_INVALID_PARAMETER;
goto ON_EXIT;
@@ -713,7 +713,7 @@ MnpCancel (
}
//
- // Dispatch the DPC queued by the NotifyFunction of the cancled token's events.
+ // Dispatch the DPC queued by the NotifyFunction of the canceled token's events.
//
DispatchDpc ();
diff --git a/NetworkPkg/MnpDxe/MnpDxe.uni b/NetworkPkg/MnpDxe/MnpDxe.uni index 04be3cd7fe5a..481e791499fe 100644
--- a/NetworkPkg/MnpDxe/MnpDxe.uni
+++ b/NetworkPkg/MnpDxe/MnpDxe.uni
@@ -1,5 +1,5 @@
// /** @file
-// This module produces EFI MNP Protocol, EFI MNP Servie Binding Protocol and EFI VLAN Protocol.
+// This module produces EFI MNP Protocol, EFI MNP Service Binding Protocol and EFI VLAN Protocol.
//
// This module produces EFI Managed Network Protocol upon EFI Simple Network Protocol, // to provide raw asynchronous network I/O services. It also produces EFI VLAN Protocol @@ -12,7 +12,7 @@ // **/
-#string STR_MODULE_ABSTRACT #language en-US "Produces EFI MNP Protocol, EFI MNP Servie Binding Protocol and EFI VLAN Protocol"
+#string STR_MODULE_ABSTRACT #language en-US "Produces EFI MNP Protocol, EFI MNP Service Binding Protocol and EFI VLAN Protocol"
#string STR_MODULE_DESCRIPTION #language en-US "This module produces EFI Managed Network Protocol upon EFI Simple Network Protocol to provide raw asynchronous network I/O services. It also produces EFI VLAN Protocol to provide manageability interface for VLAN configuration."
--
2.21.0
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
^ permalink raw reply [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-41-philmd@redhat.com>]
* Re: [PATCH 40/79] NetworkPkg/HttpDxe: Fix various typos
[not found] ` <20191203161602.15969-41-philmd@redhat.com>
@ 2019-12-06 16:05 ` Rabeda, Maciej
0 siblings, 0 replies; 122+ messages in thread
From: Rabeda, Maciej @ 2019-12-06 16:05 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Wu, Jiaxin, Fu, Siyuan
Reviewed-by: Maciej Rabeda <maciej.rabeda@intel.com>
Thanks!
Maciej
-----Original Message-----
From: Philippe Mathieu-Daude <philmd@redhat.com>
Sent: Tuesday, December 3, 2019 17:15
To: devel@edk2.groups.io
Cc: Antoine Coeur <coeur@gmx.fr>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
Subject: [PATCH 40/79] NetworkPkg/HttpDxe: Fix various typos
From: Antoine Coeur <coeur@gmx.fr>
Fix various typos in comments and documentation.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/HttpDxe/HttpDriver.h | 8 +++----
NetworkPkg/HttpDxe/HttpProto.h | 16 +++++++-------
NetworkPkg/HttpDxe/HttpsSupport.h | 2 +-
NetworkPkg/HttpDxe/HttpDriver.c | 12 +++++------
NetworkPkg/HttpDxe/HttpImpl.c | 10 ++++-----
NetworkPkg/HttpDxe/HttpProto.c | 22 ++++++++++----------
NetworkPkg/HttpDxe/HttpsSupport.c | 2 +-
7 files changed, 36 insertions(+), 36 deletions(-)
diff --git a/NetworkPkg/HttpDxe/HttpDriver.h b/NetworkPkg/HttpDxe/HttpDriver.h index bd6f658f3c24..5fe8c5b5e9b9 100644
--- a/NetworkPkg/HttpDxe/HttpDriver.h
+++ b/NetworkPkg/HttpDxe/HttpDriver.h
@@ -172,7 +172,7 @@ HttpDxeIp4DriverBindingSupported (
@retval EFI_SUCCESS The device was started.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -301,7 +301,7 @@ HttpDxeIp6DriverBindingSupported (
@retval EFI_ALREADY_STARTED This device is already running on ControllerHandle.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -359,7 +359,7 @@ HttpDxeIp6DriverBindingStop (
then a new handle is created. If it is a pointer to an existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER This is NULL, or ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child.
@@ -383,7 +383,7 @@ HttpServiceBindingCreateChild (
@param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param ChildHandle Handle of the child to destroy
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval other The child handle was not destroyed
diff --git a/NetworkPkg/HttpDxe/HttpProto.h b/NetworkPkg/HttpDxe/HttpProto.h index 34308e016d3e..00ba26aca49a 100644
--- a/NetworkPkg/HttpDxe/HttpProto.h
+++ b/NetworkPkg/HttpDxe/HttpProto.h
@@ -308,7 +308,7 @@ HttpCloseTcpRxEvent (
);
/**
- Intiialize the HTTP_PROTOCOL structure to the unconfigured state.
+ Initialize the HTTP_PROTOCOL structure to the unconfigured state.
@param[in, out] HttpInstance Pointer to HTTP_PROTOCOL structure.
@param[in] IpVersion Indicate us TCP4 protocol or TCP6 protocol.
@@ -453,7 +453,7 @@ HttpTransmitTcp (
@param[in] Map The container of either user's transmit or receive
token.
@param[in] Item Current item to check against.
- @param[in] Context The Token to check againist.
+ @param[in] Context The Token to check against.
@retval EFI_ACCESS_DENIED The token or event has already been enqueued in IP
@retval EFI_SUCCESS The current item isn't the same token/event as the
@@ -473,7 +473,7 @@ HttpTokenExist (
@param[in] Map The container of TxToken.
@param[in] Item Current item to check against.
- @param[in] Context The Token to check againist.
+ @param[in] Context The Token to check against.
@retval EFI_NOT_READY The HTTP message is still queued in the list.
@retval EFI_SUCCESS The HTTP message has been sent out.
@@ -508,11 +508,11 @@ HttpInitSession (
);
/**
- Transmit the HTTP or HTTPS mssage by processing the associated HTTP token.
+ Transmit the HTTP or HTTPS message by processing the associated HTTP token.
@param[in] Map The container of TxToken or Tx6Token.
@param[in] Item Current item to check against.
- @param[in] Context The Token to check againist.
+ @param[in] Context The Token to check against.
@retval EFI_OUT_OF_RESOURCES Failed to allocate resources.
@retval EFI_SUCCESS The HTTP message is queued into TCP transmit
@@ -532,7 +532,7 @@ HttpTcpTransmit (
@param[in] Map The container of Rx4Token or Rx6Token.
@param[in] Item Current item to check against.
- @param[in] Context The Token to check againist.
+ @param[in] Context The Token to check against.
@retval EFI_SUCCESS The HTTP response is queued into TCP receive
queue.
@@ -552,7 +552,7 @@ HttpTcpReceive (
@param[in] HttpInstance The HTTP instance private data.
@param[in, out] SizeofHeaders The HTTP header length.
- @param[in, out] BufferSize The size of buffer to cacahe the header message.
+ @param[in, out] BufferSize The size of buffer to cache the header message.
@param[in] Timeout The time to wait for receiving the header packet.
@retval EFI_SUCCESS The HTTP header is received.
@@ -600,7 +600,7 @@ HttpTcpTokenCleanup (
@param[in] Wrap Pointer to HTTP token's wrap data.
@retval EFI_SUCCESS Allocation succeeded.
- @retval EFI_OUT_OF_RESOURCES Failed to complete the opration due to lack of resources.
+ @retval EFI_OUT_OF_RESOURCES Failed to complete the operation due to lack of resources.
@retval EFI_NOT_READY Can't find a corresponding TxToken.
**/
diff --git a/NetworkPkg/HttpDxe/HttpsSupport.h b/NetworkPkg/HttpDxe/HttpsSupport.h
index 0e16968cd680..6851ceea75a5 100644
--- a/NetworkPkg/HttpDxe/HttpsSupport.h
+++ b/NetworkPkg/HttpDxe/HttpsSupport.h
@@ -149,7 +149,7 @@ TlsCommonReceive (
);
/**
- Receive one TLS PDU. An TLS PDU contains an TLS record header and it's
+ Receive one TLS PDU. An TLS PDU contains an TLS record header and its
corresponding record data. These two parts will be put into two blocks of buffers in the
net buffer.
diff --git a/NetworkPkg/HttpDxe/HttpDriver.c b/NetworkPkg/HttpDxe/HttpDriver.c index 7c64d4215119..a9f5c0949ffe 100644
--- a/NetworkPkg/HttpDxe/HttpDriver.c
+++ b/NetworkPkg/HttpDxe/HttpDriver.c
@@ -78,7 +78,7 @@ HttpCreateService (
@param[in] HttpService The HTTP private instance.
@param[in] UsingIpv6 Indicate use TCP4 protocol or TCP6 protocol.
if TRUE, use Tcp6 protocol.
- if FALSE, use Tcp4 protocl.
+ if FALSE, use Tcp4 protocol.
**/
VOID
HttpCleanService (
@@ -152,7 +152,7 @@ HttpUtilitiesInstalledCallback (
);
//
- // Close the event if Http utilities protocol is loacted.
+ // Close the event if Http utilities protocol is located.
//
if (mHttpUtilities != NULL && Event != NULL) {
gBS->CloseEvent (Event);
@@ -668,7 +668,7 @@ HttpDxeIp4DriverBindingSupported (
@retval EFI_ALREADY_STARTED This device is already running on ControllerHandle.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -823,7 +823,7 @@ HttpDxeIp6DriverBindingSupported (
@retval EFI_ALREADY_STARTED This device is already running on ControllerHandle.
@retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources.
- @retval Others The driver failded to start the device.
+ @retval Others The driver failed to start the device.
**/
EFI_STATUS
@@ -897,7 +897,7 @@ HttpDxeIp6DriverBindingStop (
then a new handle is created. If it is a pointer to an existing UEFI handle,
then the protocol is added to the existing UEFI handle.
- @retval EFI_SUCCES The protocol was added to ChildHandle.
+ @retval EFI_SUCCESS The protocol was added to ChildHandle.
@retval EFI_INVALID_PARAMETER This is NULL, or ChildHandle is NULL.
@retval EFI_OUT_OF_RESOURCES There are not enough resources available to create
the child.
@@ -981,7 +981,7 @@ ON_ERROR:
@param This Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.
@param ChildHandle Handle of the child to destroy
- @retval EFI_SUCCES The protocol was removed from ChildHandle.
+ @retval EFI_SUCCESS The protocol was removed from ChildHandle.
@retval EFI_UNSUPPORTED ChildHandle does not support the protocol that is being removed.
@retval EFI_INVALID_PARAMETER Child handle is NULL.
@retval other The child handle was not destroyed
diff --git a/NetworkPkg/HttpDxe/HttpImpl.c b/NetworkPkg/HttpDxe/HttpImpl.c index 6b877314bd57..aa77696f0d0d 100644
--- a/NetworkPkg/HttpDxe/HttpImpl.c
+++ b/NetworkPkg/HttpDxe/HttpImpl.c
@@ -188,7 +188,7 @@ EfiHttpConfigure (
} else {
//
- // Reset all the resources related to HttpInsance.
+ // Reset all the resources related to HttpInstance.
//
HttpCleanProtocol (HttpInstance);
HttpInstance->State = HTTP_STATE_UNCONFIGED; @@ -756,7 +756,7 @@ HttpCancelTokens (
if (!HttpInstance->LocalAddressIsIPv6) {
if (Wrap->TcpWrap.Rx4Token.CompletionToken.Event != NULL) {
//
- // Cancle the Token before close its Event.
+ // Cancel the Token before close its Event.
//
HttpInstance->Tcp4->Cancel (HttpInstance->Tcp4, &Wrap->TcpWrap.Rx4Token.CompletionToken);
@@ -768,7 +768,7 @@ HttpCancelTokens (
} else {
if (Wrap->TcpWrap.Rx6Token.CompletionToken.Event != NULL) {
//
- // Cancle the Token before close its Event.
+ // Cancel the Token before close its Event.
//
HttpInstance->Tcp6->Cancel (HttpInstance->Tcp6, &Wrap->TcpWrap.Rx6Token.CompletionToken);
@@ -956,7 +956,7 @@ HttpBodyParserCallback (
@param[in] Wrap Pointer to HTTP token's wrap data.
@retval EFI_SUCCESS Allocation succeeded.
- @retval EFI_OUT_OF_RESOURCES Failed to complete the opration due to lack of resources.
+ @retval EFI_OUT_OF_RESOURCES Failed to complete the operation due to lack of resources.
@retval EFI_NOT_READY Can't find a corresponding Tx4Token/Tx6Token or
the EFI_HTTP_UTILITIES_PROTOCOL is not available.
@@ -1284,7 +1284,7 @@ HttpResponseWorker (
}
}
//
- // Return since we aready received required data.
+ // Return since we already received required data.
//
Status = EFI_SUCCESS;
goto Exit;
diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpProto.c index bacfbc995847..3c7c6ff9f0ce 100644
--- a/NetworkPkg/HttpDxe/HttpProto.c
+++ b/NetworkPkg/HttpDxe/HttpProto.c
@@ -301,7 +301,7 @@ HttpCreateTcpConnCloseEvent (
if (!HttpInstance->LocalAddressIsIPv6) {
//
- // Create events for variuos asynchronous operations.
+ // Create events for various asynchronous operations.
//
Status = gBS->CreateEvent (
EVT_NOTIFY_SIGNAL,
@@ -330,7 +330,7 @@ HttpCreateTcpConnCloseEvent (
} else {
//
- // Create events for variuos asynchronous operations.
+ // Create events for various asynchronous operations.
//
Status = gBS->CreateEvent (
EVT_NOTIFY_SIGNAL,
@@ -618,7 +618,7 @@ HttpCloseTcpRxEvent ( }
/**
- Intiialize the HTTP_PROTOCOL structure to the unconfigured state.
+ Initialize the HTTP_PROTOCOL structure to the unconfigured state.
@param[in, out] HttpInstance Pointer to HTTP_PROTOCOL structure.
@param[in] IpVersion Indicate us TCP4 protocol or TCP6 protocol.
@@ -1636,7 +1636,7 @@ ON_ERROR:
@param[in] Map The container of either user's transmit or receive
token.
@param[in] Item Current item to check against.
- @param[in] Context The Token to check againist.
+ @param[in] Context The Token to check against.
@retval EFI_ACCESS_DENIED The token or event has already been enqueued in IP
@retval EFI_SUCCESS The current item isn't the same token/event as the
@@ -1669,7 +1669,7 @@ HttpTokenExist (
@param[in] Map The container of Tx4Token or Tx6Token.
@param[in] Item Current item to check against.
- @param[in] Context The Token to check againist.
+ @param[in] Context The Token to check against.
@retval EFI_NOT_READY The HTTP message is still queued in the list.
@retval EFI_SUCCESS The HTTP message has been sent out.
@@ -1695,11 +1695,11 @@ HttpTcpNotReady ( }
/**
- Transmit the HTTP or HTTPS mssage by processing the associated HTTP token.
+ Transmit the HTTP or HTTPS message by processing the associated HTTP token.
@param[in] Map The container of Tx4Token or Tx6Token.
@param[in] Item Current item to check against.
- @param[in] Context The Token to check againist.
+ @param[in] Context The Token to check against.
@retval EFI_OUT_OF_RESOURCES Failed to allocate resources.
@retval EFI_SUCCESS The HTTP message is queued into TCP transmit
@@ -1774,7 +1774,7 @@ HttpTcpTransmit (
@param[in] Map The container of Rx4Token or Rx6Token.
@param[in] Item Current item to check against.
- @param[in] Context The Token to check againist.
+ @param[in] Context The Token to check against.
@retval EFI_SUCCESS The HTTP response is queued into TCP receive
queue.
@@ -1800,7 +1800,7 @@ HttpTcpReceive (
@param[in] HttpInstance The HTTP instance private data.
@param[in, out] SizeofHeaders The HTTP header length.
- @param[in, out] BufferSize The size of buffer to cacahe the header message.
+ @param[in, out] BufferSize The size of buffer to cache the header message.
@param[in] Timeout The time to wait for receiving the header packet.
@retval EFI_SUCCESS The HTTP header is received.
@@ -1880,7 +1880,7 @@ HttpTcpReceiveHeader (
if (!HttpInstance->IsRxDone) {
//
- // Cancle the Token before close its Event.
+ // Cancel the Token before close its Event.
//
Tcp4->Cancel (HttpInstance->Tcp4, &Rx4Token->CompletionToken);
gBS->CloseEvent (Rx4Token->CompletionToken.Event);
@@ -1980,7 +1980,7 @@ HttpTcpReceiveHeader (
if (!HttpInstance->IsRxDone) {
//
- // Cancle the Token before close its Event.
+ // Cancel the Token before close its Event.
//
Tcp6->Cancel (HttpInstance->Tcp6, &Rx6Token->CompletionToken);
gBS->CloseEvent (Rx6Token->CompletionToken.Event);
diff --git a/NetworkPkg/HttpDxe/HttpsSupport.c b/NetworkPkg/HttpDxe/HttpsSupport.c
index 5dfb13bd6021..7e0bf85c3c42 100644
--- a/NetworkPkg/HttpDxe/HttpsSupport.c
+++ b/NetworkPkg/HttpDxe/HttpsSupport.c
@@ -971,7 +971,7 @@ ON_EXIT:
}
/**
- Receive one TLS PDU. An TLS PDU contains an TLS record header and it's
+ Receive one TLS PDU. An TLS PDU contains an TLS record header and its
corresponding record data. These two parts will be put into two blocks of buffers in the
net buffer.
--
2.21.0
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
^ permalink raw reply related [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-49-philmd@redhat.com>]
* Re: [PATCH 48/79] NetworkPkg/SnpDxe: Fix few typos
[not found] ` <20191203161602.15969-49-philmd@redhat.com>
@ 2019-12-06 16:09 ` Rabeda, Maciej
2019-12-06 16:38 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 122+ messages in thread
From: Rabeda, Maciej @ 2019-12-06 16:09 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Antoine Coeur, Wu, Jiaxin, Fu, Siyuan
Philippe,
I was so keen to give you the green light but typo in Callback.c has not been fixed here.
ususlly -> ususally
If you could address this, that would be great :)
Thanks!
Maciej
-----Original Message-----
From: Philippe Mathieu-Daude <philmd@redhat.com>
Sent: Tuesday, December 3, 2019 17:16
To: devel@edk2.groups.io
Cc: Antoine Coeur <coeur@gmx.fr>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
Subject: [PATCH 48/79] NetworkPkg/SnpDxe: Fix few typos
From: Antoine Coeur <coeur@gmx.fr>
Fix few typos in comments and documentation.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/SnpDxe/Snp.h | 8 ++++----
NetworkPkg/SnpDxe/Callback.c | 2 +-
NetworkPkg/SnpDxe/Shutdown.c | 2 +-
NetworkPkg/SnpDxe/Snp.c | 6 +++---
NetworkPkg/SnpDxe/WaitForPacket.c | 2 +-
5 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/NetworkPkg/SnpDxe/Snp.h b/NetworkPkg/SnpDxe/Snp.h index 9e4b7d6f86a0..66b5f948e27c 100644
--- a/NetworkPkg/SnpDxe/Snp.h
+++ b/NetworkPkg/SnpDxe/Snp.h
@@ -1,5 +1,5 @@
/** @file
- Declaration of strctures and functions for SnpDxe driver.
+ Declaration of structures and functions for SnpDxe driver.
Copyright (c) 2004 - 2019, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -289,7 +289,7 @@ SnpUndi32CallbackBlock (
@param UniqueId This was supplied to UNDI at Undi_Start, SNP uses this to
store Undi interface context (Undi does not read or write
this variable)
- @param MicroSeconds number of micro seconds to pause, ususlly multiple of 10.
+ @param MicroSeconds number of micro seconds to pause, usually multiple of 10.
**/
VOID
EFIAPI
@@ -378,7 +378,7 @@ SnpUndi32CallbackUnmap (
need to synchronize their contents whenever it writes to/reads from the buffer
using either the cpu address or the device address.
- EFI does not provide a sync call, since virt=physical, we sould just do
+ EFI does not provide a sync call, since virt=physical, we should just
+ do
the synchronization ourself here!
@param UniqueId This was supplied to UNDI at Undi_Start, SNP uses this to store
@@ -1015,7 +1015,7 @@ SnpUndi32Receive (
);
/**
- Nofication call back function for WaitForPacket event.
+ Notification call back function for WaitForPacket event.
@param Event EFI Event.
@param SnpPtr Pointer to SNP_DRIVER structure.
diff --git a/NetworkPkg/SnpDxe/Callback.c b/NetworkPkg/SnpDxe/Callback.c index 6387dbdb35ef..babfca7d76c7 100644
--- a/NetworkPkg/SnpDxe/Callback.c
+++ b/NetworkPkg/SnpDxe/Callback.c
@@ -53,7 +53,7 @@ SnpUndi32CallbackBlock (
@param UniqueId This was supplied to UNDI at Undi_Start, SNP uses this to
store Undi interface context (Undi does not read or write
this variable).
- @param MicroSeconds Number of micro seconds to pause, ususlly multiple of 10.
+ @param MicroSeconds Number of micro seconds to pause, ususally multiple of 10.
**/
VOID
diff --git a/NetworkPkg/SnpDxe/Shutdown.c b/NetworkPkg/SnpDxe/Shutdown.c index aad0fe8493a8..ae823fd35243 100644
--- a/NetworkPkg/SnpDxe/Shutdown.c
+++ b/NetworkPkg/SnpDxe/Shutdown.c
@@ -1,5 +1,5 @@
/** @file
- Implementation of shuting down a network adapter.
+ Implementation of shutting down a network adapter.
Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent diff --git a/NetworkPkg/SnpDxe/Snp.c b/NetworkPkg/SnpDxe/Snp.c index 1099dbfa6a28..078b27cf5edd 100644
--- a/NetworkPkg/SnpDxe/Snp.c
+++ b/NetworkPkg/SnpDxe/Snp.c
@@ -782,7 +782,7 @@ SimpleNetworkDriverStop (
if (PcdGetBool (PcdSnpCreateExitBootServicesEvent)) {
//
- // Close EXIT_BOOT_SERIVES Event
+ // Close EXIT_BOOT_SERVICES Event
//
gBS->CloseEvent (Snp->ExitBootServicesEvent);
}
@@ -840,9 +840,9 @@ EFI_DRIVER_BINDING_PROTOCOL gSimpleNetworkDriverBinding = {
@param ImageHandle The driver image handle.
@param SystemTable The system table.
- @retval EFI_SUCEESS Initialization routine has found UNDI hardware,
+ @retval EFI_SUCCESS Initialization routine has found UNDI hardware,
loaded it's ROM, and installed a notify event for
- the Network Indentifier Interface Protocol
+ the Network Identifier Interface Protocol
successfully.
@retval Other Return value from HandleProtocol for
DeviceIoProtocol or LoadedImageProtocol diff --git a/NetworkPkg/SnpDxe/WaitForPacket.c b/NetworkPkg/SnpDxe/WaitForPacket.c
index 866a1e8c0e8c..c337e69290f9 100644
--- a/NetworkPkg/SnpDxe/WaitForPacket.c
+++ b/NetworkPkg/SnpDxe/WaitForPacket.c
@@ -10,7 +10,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
/**
- Nofication call back function for WaitForPacket event.
+ Notification call back function for WaitForPacket event.
@param Event EFI Event.
@param SnpPtr Pointer to SNP_DRIVER structure.
--
2.21.0
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
^ permalink raw reply related [flat|nested] 122+ messages in thread* Re: [PATCH 48/79] NetworkPkg/SnpDxe: Fix few typos
2019-12-06 16:09 ` [PATCH 48/79] NetworkPkg/SnpDxe: Fix few typos Rabeda, Maciej
@ 2019-12-06 16:38 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 122+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-06 16:38 UTC (permalink / raw)
To: Rabeda, Maciej, devel@edk2.groups.io
Cc: Antoine Coeur, Wu, Jiaxin, Fu, Siyuan
On 12/6/19 5:09 PM, Rabeda, Maciej wrote:
> Philippe,
>
> I was so keen to give you the green light but typo in Callback.c has not been fixed here.
> ususlly -> ususally
Nice catch!
> If you could address this, that would be great :)
Certainly, will do.
> Thanks!
> Maciej
>
> -----Original Message-----
> From: Philippe Mathieu-Daude <philmd@redhat.com>
> Sent: Tuesday, December 3, 2019 17:16
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
> Subject: [PATCH 48/79] NetworkPkg/SnpDxe: Fix few typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix few typos in comments and documentation.
>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> NetworkPkg/SnpDxe/Snp.h | 8 ++++----
> NetworkPkg/SnpDxe/Callback.c | 2 +-
> NetworkPkg/SnpDxe/Shutdown.c | 2 +-
> NetworkPkg/SnpDxe/Snp.c | 6 +++---
> NetworkPkg/SnpDxe/WaitForPacket.c | 2 +-
> 5 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/NetworkPkg/SnpDxe/Snp.h b/NetworkPkg/SnpDxe/Snp.h index 9e4b7d6f86a0..66b5f948e27c 100644
> --- a/NetworkPkg/SnpDxe/Snp.h
> +++ b/NetworkPkg/SnpDxe/Snp.h
> @@ -1,5 +1,5 @@
> /** @file
> - Declaration of strctures and functions for SnpDxe driver.
> + Declaration of structures and functions for SnpDxe driver.
>
> Copyright (c) 2004 - 2019, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent @@ -289,7 +289,7 @@ SnpUndi32CallbackBlock (
> @param UniqueId This was supplied to UNDI at Undi_Start, SNP uses this to
> store Undi interface context (Undi does not read or write
> this variable)
> - @param MicroSeconds number of micro seconds to pause, ususlly multiple of 10.
> + @param MicroSeconds number of micro seconds to pause, usually multiple of 10.
> **/
> VOID
> EFIAPI
> @@ -378,7 +378,7 @@ SnpUndi32CallbackUnmap (
> need to synchronize their contents whenever it writes to/reads from the buffer
> using either the cpu address or the device address.
>
> - EFI does not provide a sync call, since virt=physical, we sould just do
> + EFI does not provide a sync call, since virt=physical, we should just
> + do
> the synchronization ourself here!
>
> @param UniqueId This was supplied to UNDI at Undi_Start, SNP uses this to store
> @@ -1015,7 +1015,7 @@ SnpUndi32Receive (
> );
>
> /**
> - Nofication call back function for WaitForPacket event.
> + Notification call back function for WaitForPacket event.
>
> @param Event EFI Event.
> @param SnpPtr Pointer to SNP_DRIVER structure.
> diff --git a/NetworkPkg/SnpDxe/Callback.c b/NetworkPkg/SnpDxe/Callback.c index 6387dbdb35ef..babfca7d76c7 100644
> --- a/NetworkPkg/SnpDxe/Callback.c
> +++ b/NetworkPkg/SnpDxe/Callback.c
> @@ -53,7 +53,7 @@ SnpUndi32CallbackBlock (
> @param UniqueId This was supplied to UNDI at Undi_Start, SNP uses this to
> store Undi interface context (Undi does not read or write
> this variable).
> - @param MicroSeconds Number of micro seconds to pause, ususlly multiple of 10.
> + @param MicroSeconds Number of micro seconds to pause, ususally multiple of 10.
>
> **/
> VOID
> diff --git a/NetworkPkg/SnpDxe/Shutdown.c b/NetworkPkg/SnpDxe/Shutdown.c index aad0fe8493a8..ae823fd35243 100644
> --- a/NetworkPkg/SnpDxe/Shutdown.c
> +++ b/NetworkPkg/SnpDxe/Shutdown.c
> @@ -1,5 +1,5 @@
> /** @file
> - Implementation of shuting down a network adapter.
> + Implementation of shutting down a network adapter.
>
> Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent diff --git a/NetworkPkg/SnpDxe/Snp.c b/NetworkPkg/SnpDxe/Snp.c index 1099dbfa6a28..078b27cf5edd 100644
> --- a/NetworkPkg/SnpDxe/Snp.c
> +++ b/NetworkPkg/SnpDxe/Snp.c
> @@ -782,7 +782,7 @@ SimpleNetworkDriverStop (
>
> if (PcdGetBool (PcdSnpCreateExitBootServicesEvent)) {
> //
> - // Close EXIT_BOOT_SERIVES Event
> + // Close EXIT_BOOT_SERVICES Event
> //
> gBS->CloseEvent (Snp->ExitBootServicesEvent);
> }
> @@ -840,9 +840,9 @@ EFI_DRIVER_BINDING_PROTOCOL gSimpleNetworkDriverBinding = {
> @param ImageHandle The driver image handle.
> @param SystemTable The system table.
>
> - @retval EFI_SUCEESS Initialization routine has found UNDI hardware,
> + @retval EFI_SUCCESS Initialization routine has found UNDI hardware,
> loaded it's ROM, and installed a notify event for
> - the Network Indentifier Interface Protocol
> + the Network Identifier Interface Protocol
> successfully.
> @retval Other Return value from HandleProtocol for
> DeviceIoProtocol or LoadedImageProtocol diff --git a/NetworkPkg/SnpDxe/WaitForPacket.c b/NetworkPkg/SnpDxe/WaitForPacket.c
> index 866a1e8c0e8c..c337e69290f9 100644
> --- a/NetworkPkg/SnpDxe/WaitForPacket.c
> +++ b/NetworkPkg/SnpDxe/WaitForPacket.c
> @@ -10,7 +10,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>
>
> /**
> - Nofication call back function for WaitForPacket event.
> + Notification call back function for WaitForPacket event.
>
> @param Event EFI Event.
> @param SnpPtr Pointer to SNP_DRIVER structure.
> --
> 2.21.0
>
> --------------------------------------------------------------------
>
> Intel Technology Poland sp. z o.o.
> ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
>
> Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
> przegladanie lub rozpowszechnianie jest zabronione.
> This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
> others is strictly prohibited.
>
^ permalink raw reply [flat|nested] 122+ messages in thread
* Re: [PATCH 00/79] Fix a bunch of typos (part 1)
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
` (69 preceding siblings ...)
[not found] ` <20191203161602.15969-49-philmd@redhat.com>
@ 2019-12-10 7:21 ` Cœur
[not found] ` <20191203161602.15969-70-philmd@redhat.com>
[not found] ` <20191203161602.15969-69-philmd@redhat.com>
72 siblings, 0 replies; 122+ messages in thread
From: Cœur @ 2019-12-10 7:21 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel, Achin Gupta, Andrew Fish,
Anthony Perard, Ard Biesheuvel, Chao Zhang, Chasel Chiu,
Eric Dong, Hao A Wu, Jian J Wang, Jiaxin Wu, Jiewen Yao,
Jordan Justen, Julien Grall, Laszlo Ersek, Leif Lindholm,
Liming Gao, Maciej Rabeda, Michael D Kinney, Nate DeSimone,
Ray Ni, Siyuan Fu, Star Zeng, Supreeth Venkatesh, Xiaoyu Lu,
Zhichao Gao
for all my patches until now:
Signed-off-by: Antoine Coeur<coeur@gmx.fr>
(see the discussion on [PATCH 61/79] OvmfPkg/Xen: Fix various typos)
Regards,
Antoine Cœur
Le 04/12/2019 à 00:14, Philippe Mathieu-Daude a écrit :
> Around February of this year, Antoine posted various patches fixing
> a huge quantity of typos, over 8000+ lines (such [1]).
>
> The community merged the smaller patches, and told him his patches
> were too big, and he should split them.
> Around June, Antoine opened a GitHub pull request [2], due to the
> size of his patchset. We told him the project doesn't accept GitHub
> PR.
>
> Since I find his cleanup work very valuable for the project, I
> spent few hours trying to salvage a chunk of it, splitting per
> maintainer areas, each patch not to big to avoid reviewers burning
> out. I expect each maintainer to take his patches.
>
> I wanted to split Antoine work in 3 parts, but I'm about at 80
> patches, for only 1854 lines changed, so enough for a first round.
>
> Oh, and it is easier to review the patches using '--word-diff=color'
> git option :)
>
> Regards,
>
> Phil.
>
> P.D.: I think the project is really failing at getting new
> contributors involved, and keeping them. But that is another topic.
>
> [1] https://edk2.groups.io/g/devel/message/43043
> [2] https://edk2.groups.io/g/devel/message/42941
>
> Antoine Coeur (72):
> CryptoPkg/OpensslLib: Fix few typos
> EmbeddedPkg/FdtLib: Fix a typo
> EmbeddedPkg/VirtualKeyboard: Fix few typos
> EmulatorPkg/Sec: Fix various typos
> EmulatorPkg/Unix: Fix various typos
> EmulatorPkg/Win: Fix various typos
> FatPkg/EnhancedFatDxe: Fix various typos
> FatPkg/FatPei: Fix few typos
> IntelFsp2WrapperPkg: Fix various typos
> MdeModulePkg/Application: Improve French translation
> MdeModulePkg/Application: Fix various typos
> MdeModulePkg/Bus/Ata: Fix various typos
> MdeModulePkg/Bus/I2c: Fix few typos
> MdeModulePkg/Bus/Isa: Fix various typos
> MdeModulePkg/Bus/Scsi: Fix various typos
> MdeModulePkg/Bus/Sd: Fix various typos
> MdeModulePkg/Core/Pei: Fix various typos
> MdeModulePkg/Core/PiSmmCore: Fix various typos
> MdeModulePkg/UsbMass: Fix various typos
> MdeModulePkg/UsbMouse: Fix few typos
> MdeModulePkg/UsbBus: Fix various typos
> MdeModulePkg/Usb: Fix various typos
> MdePkg/IndustryStandard: Fix various typos
> MdePkg/Library/Dxe: Fix various typos
> MdePkg/Library/Pci: Fix various typos
> MdePkg/Library/Smm: Fix various typos
> MdePkg/Ppi: Fix various typos
> MdePkg/Register: Fix various typos
> NetworkPkg/ArpDxe: Fix various typos
> NetworkPkg/Dhcp4Dxe: Fix various typos
> NetworkPkg/Dhcp6Dxe: Fix various typos
> NetworkPkg/DnsDxe: Fix various typos
> NetworkPkg/DpcDxe: Fix few typos
> NetworkPkg/HttpBootDxe: Fix various typos
> NetworkPkg/HttpDxe: Fix various typos
> NetworkPkg/Ip4Dxe: Fix various typos
> NetworkPkg/Ip6Dxe: Fix various typos
> NetworkPkg/IScsiDxe: Fix various typos
> NetworkPkg/Library: Fix various typos
> NetworkPkg/MnpDxe: Fix various typos
> NetworkPkg/Mtftp4Dxe: Fix various typos
> NetworkPkg/Mtftp6Dxe: Fix various typos
> NetworkPkg/SnpDxe: Fix few typos
> NetworkPkg/TcpDxe/Sock: Fix few typos
> NetworkPkg/TcpDxe/Tcp: Fix various typos
> NetworkPkg/Tls: Fix few typos
> NetworkPkg/Udp4Dxe: Fix various typos
> NetworkPkg/Udp6Dxe: Fix various typos
> NetworkPkg/UefiPxeBcDxe: Fix various typos
> NetworkPkg/VlanConfigDxe: Fix few typos
> OvmfPkg/Acpi: Fix few typos
> OvmfPkg/Csm: Fix various typos
> OvmfPkg/Qemu: Fix various typos
> OvmfPkg/Virtio: Fix few typos
> OvmfPkg/Xen: Fix various typos
> PcAtChipsetPkg: Fix few typos
> SecurityPkg: Fix few typos
> SecurityPkg/Hash2DxeCrypto: Fix few typos
> SecurityPkg/Library/Tpm: Fix various typos
> SecurityPkg/Tcg: Fix various typos
> SecurityPkg/VariableAuthenticated: Fix few typos
> ShellPkg/Application: Fix various typos
> ShellPkg/DynamicCommand: Fix various typos
> SignedCapsulePkg: Fix various typos
> SignedCapsulePkg/Universal: Fix various typos
> SourceLevelDebugPkg/DebugAgent: Fix various typos
> SourceLevelDebugPkg/DebugCommunicationLib: Fix various typos
> SourceLevelDebugPkg: Fix few typos
> StandaloneMmPkg: Fix few typos
> UefiCpuPkg/CpuDxe: Fix few typos
> UefiCpuPkg/PiSmm: Fix various typos
> UefiCpuPkg/Smm: Fix various typos
>
> Philippe Mathieu-Daude (7):
> EmbeddedPkg/VirtualKeyboard: Fix a typo in EFI_INVALID_PARAMETER
> MdeModulePkg/UsbBusDxe: Fix a typo
> NetworkPkg: Fix a typo
> NetworkPkg/DnsDxe: Fix a typo
> NetworkPkg/HttpBootDxe: Fix a typo in variable name
> OvmfPkg/Xen: Fix a typo
> StandaloneMmPkg: Fix a typo
>
> SignedCapsulePkg/SignedCapsulePkg.dec | 4 +-
> MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf | 2 +-
> MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf | 2 +-
> MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf | 10 ++--
> MdePkg/Library/DxePcdLib/DxePcdLib.inf | 2 +-
> NetworkPkg/MnpDxe/MnpDxe.inf | 2 +-
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf | 2 +-
> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf | 4 +-
> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf | 4 +-
> SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf | 2 +-
> SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf | 2 +-
> SecurityPkg/Tcg/TcgSmm/TcgSmm.inf | 2 +-
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.inf | 2 +-
> StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf | 2 +-
> EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h | 36 +++++++-------
> EmbeddedPkg/Include/libfdt.h | 2 +-
> EmulatorPkg/Sec/Sec.h | 4 +-
> EmulatorPkg/Win/Host/WinGop.h | 2 +-
> EmulatorPkg/Win/Host/WinHost.h | 2 +-
> FatPkg/EnhancedFatDxe/Fat.h | 6 +--
> FatPkg/FatPei/FatLitePeim.h | 2 +-
> IntelFsp2WrapperPkg/Include/Library/FspWrapperApiLib.h | 2 +-
> IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformLib.h | 4 +-
> MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.h | 2 +-
> MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.h | 2 +-
> MdeModulePkg/Bus/Ata/AhciPei/AhciPei.h | 4 +-
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h | 4 +-
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.h | 4 +-
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.h | 2 +-
> MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h | 12 ++---
> MdeModulePkg/Bus/I2c/I2cDxe/I2cDxe.h | 4 +-
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 14 +++---
> MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.h | 2 +-
> MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.h | 2 +-
> MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.h | 4 +-
> MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 10 ++--
> MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.h | 2 +-
> MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h | 6 +--
> MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.h | 2 +-
> MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.h | 6 +--
> MdeModulePkg/Bus/Sd/SdDxe/SdDxe.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.h | 14 +++---
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h | 10 ++--
> MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h | 4 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.h | 4 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.h | 2 +-
> MdeModulePkg/Core/Pei/PeiMain.h | 20 ++++----
> MdeModulePkg/Core/PiSmmCore/HeapGuard.h | 2 +-
> MdeModulePkg/Core/PiSmmCore/PiSmmCore.h | 12 ++---
> MdeModulePkg/Core/PiSmmCore/PiSmmCorePrivateData.h | 6 +--
> MdePkg/Include/IndustryStandard/Acpi10.h | 4 +-
> MdePkg/Include/IndustryStandard/Acpi20.h | 4 +-
> MdePkg/Include/IndustryStandard/Acpi30.h | 4 +-
> MdePkg/Include/IndustryStandard/Acpi40.h | 2 +-
> MdePkg/Include/IndustryStandard/Acpi50.h | 6 +--
> MdePkg/Include/IndustryStandard/Acpi51.h | 4 +-
> MdePkg/Include/IndustryStandard/Acpi60.h | 4 +-
> MdePkg/Include/IndustryStandard/Acpi61.h | 4 +-
> MdePkg/Include/IndustryStandard/Acpi62.h | 8 +--
> MdePkg/Include/IndustryStandard/Atapi.h | 40 +++++++--------
> MdePkg/Include/IndustryStandard/ElTorito.h | 4 +-
> MdePkg/Include/IndustryStandard/Emmc.h | 2 +-
> MdePkg/Include/IndustryStandard/IpmiNetFnBridge.h | 4 +-
> MdePkg/Include/IndustryStandard/Nvme.h | 10 ++--
> MdePkg/Include/IndustryStandard/Pci22.h | 20 ++++----
> MdePkg/Include/IndustryStandard/PeImage.h | 2 +-
> MdePkg/Include/IndustryStandard/Scsi.h | 2 +-
> MdePkg/Include/IndustryStandard/SmBus.h | 2 +-
> MdePkg/Include/IndustryStandard/Tpm12.h | 2 +-
> MdePkg/Include/Library/DxeServicesLib.h | 2 +-
> MdePkg/Include/Library/PciCf8Lib.h | 4 +-
> MdePkg/Include/Library/PciExpressLib.h | 4 +-
> MdePkg/Include/Library/PciLib.h | 4 +-
> MdePkg/Include/Library/PciSegmentLib.h | 4 +-
> MdePkg/Include/Library/SmmLib.h | 4 +-
> MdePkg/Include/Library/SmmMemLib.h | 4 +-
> MdePkg/Include/Library/SmmPeriodicSmiLib.h | 6 +--
> MdePkg/Include/Ppi/BlockIo.h | 4 +-
> MdePkg/Include/Ppi/BlockIo2.h | 2 +-
> MdePkg/Include/Ppi/Capsule.h | 2 +-
> MdePkg/Include/Ppi/Decompress.h | 2 +-
> MdePkg/Include/Ppi/DeviceRecoveryModule.h | 2 +-
> MdePkg/Include/Ppi/IsaHc.h | 2 +-
> MdePkg/Include/Ppi/MpServices.h | 2 +-
> MdePkg/Include/Ppi/Pcd.h | 4 +-
> MdePkg/Include/Ppi/RecoveryModule.h | 2 +-
> MdePkg/Include/Ppi/TemporaryRamDone.h | 2 +-
> MdePkg/Include/Ppi/VectorHandoffInfo.h | 2 +-
> MdePkg/Include/Register/Amd/Cpuid.h | 8 +--
> MdePkg/Include/Register/Amd/Fam17Msr.h | 2 +-
> MdePkg/Include/Register/Amd/Msr.h | 2 +-
> MdePkg/Include/Register/Intel/Msr/GoldmontPlusMsr.h | 2 +-
> MdePkg/Include/Register/Intel/Msr/SkylakeMsr.h | 2 +-
> MdePkg/Include/Register/Intel/StmResourceDescriptor.h | 2 +-
> NetworkPkg/ArpDxe/ArpDriver.h | 10 ++--
> NetworkPkg/ArpDxe/ArpImpl.h | 14 +++---
> NetworkPkg/Dhcp4Dxe/Dhcp4Driver.h | 4 +-
> NetworkPkg/Dhcp4Dxe/Dhcp4Io.h | 2 +-
> NetworkPkg/Dhcp4Dxe/Dhcp4Option.h | 18 +++----
> NetworkPkg/Dhcp6Dxe/Dhcp6Driver.h | 4 +-
> NetworkPkg/Dhcp6Dxe/Dhcp6Utility.h | 12 ++---
> NetworkPkg/DnsDxe/DnsDriver.h | 12 ++---
> NetworkPkg/DnsDxe/DnsImpl.h | 28 +++++------
> NetworkPkg/DpcDxe/Dpc.h | 2 +-
> NetworkPkg/HttpBootDxe/HttpBootConfig.h | 2 +-
> NetworkPkg/HttpBootDxe/HttpBootDhcp4.h | 2 +-
> NetworkPkg/HttpBootDxe/HttpBootDhcp6.h | 4 +-
> NetworkPkg/HttpBootDxe/HttpBootDxe.h | 6 +--
> NetworkPkg/HttpBootDxe/HttpBootSupport.h | 10 ++--
> NetworkPkg/HttpDxe/HttpDriver.h | 8 +--
> NetworkPkg/HttpDxe/HttpProto.h | 16 +++---
> NetworkPkg/HttpDxe/HttpsSupport.h | 2 +-
> NetworkPkg/IScsiDxe/IScsiMisc.h | 8 +--
> NetworkPkg/IScsiDxe/IScsiProto.h | 10 ++--
> NetworkPkg/Include/Library/HttpLib.h | 2 +-
> NetworkPkg/Include/Library/IpIoLib.h | 4 +-
> NetworkPkg/Include/Library/NetLib.h | 2 +-
> NetworkPkg/Include/Library/TcpIoLib.h | 6 +--
> NetworkPkg/Include/Library/UdpIoLib.h | 6 +--
> NetworkPkg/Include/Protocol/Dpc.h | 2 +-
> NetworkPkg/Ip4Dxe/Ip4Common.h | 14 +++---
> NetworkPkg/Ip4Dxe/Ip4Config2Impl.h | 2 +-
> NetworkPkg/Ip4Dxe/Ip4Driver.h | 6 +--
> NetworkPkg/Ip4Dxe/Ip4Icmp.h | 10 ++--
> NetworkPkg/Ip4Dxe/Ip4If.h | 4 +-
> NetworkPkg/Ip4Dxe/Ip4Igmp.h | 4 +-
> NetworkPkg/Ip4Dxe/Ip4Impl.h | 8 +--
> NetworkPkg/Ip4Dxe/Ip4Input.h | 6 +--
> NetworkPkg/Ip4Dxe/Ip4Option.h | 4 +-
> NetworkPkg/Ip4Dxe/Ip4Output.h | 4 +-
> NetworkPkg/Ip4Dxe/Ip4Route.h | 12 ++---
> NetworkPkg/Ip6Dxe/Ip6ConfigImpl.h | 4 +-
> NetworkPkg/Ip6Dxe/Ip6Driver.h | 8 +--
> NetworkPkg/Ip6Dxe/Ip6Icmp.h | 4 +-
> NetworkPkg/Ip6Dxe/Ip6If.h | 4 +-
> NetworkPkg/Ip6Dxe/Ip6Impl.h | 8 +--
> NetworkPkg/Ip6Dxe/Ip6Input.h | 6 +--
> NetworkPkg/Ip6Dxe/Ip6Mld.h | 2 +-
> NetworkPkg/Ip6Dxe/Ip6Nd.h | 4 +-
> NetworkPkg/Ip6Dxe/Ip6Route.h | 10 ++--
> NetworkPkg/MnpDxe/MnpDriver.h | 6 +--
> NetworkPkg/MnpDxe/MnpImpl.h | 14 +++---
> NetworkPkg/Mtftp4Dxe/Mtftp4Driver.h | 2 +-
> NetworkPkg/Mtftp4Dxe/Mtftp4Impl.h | 2 +-
> NetworkPkg/Mtftp4Dxe/Mtftp4Option.h | 6 +--
> NetworkPkg/Mtftp4Dxe/Mtftp4Support.h | 2 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Driver.h | 4 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Impl.h | 4 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Option.h | 2 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Support.h | 2 +-
> NetworkPkg/SnpDxe/Snp.h | 8 +--
> NetworkPkg/TcpDxe/SockImpl.h | 2 +-
> NetworkPkg/TcpDxe/Socket.h | 36 +++++++-------
> NetworkPkg/TcpDxe/TcpDriver.h | 8 +--
> NetworkPkg/TcpDxe/TcpFunc.h | 4 +-
> NetworkPkg/TcpDxe/TcpMain.h | 4 +-
> NetworkPkg/TcpDxe/TcpOption.h | 6 +--
> NetworkPkg/TcpDxe/TcpProto.h | 14 +++---
> NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.h | 2 +-
> NetworkPkg/TlsDxe/TlsDriver.h | 4 +-
> NetworkPkg/Udp4Dxe/Udp4Driver.h | 4 +-
> NetworkPkg/Udp4Dxe/Udp4Impl.h | 4 +-
> NetworkPkg/Udp6Dxe/Udp6Driver.h | 6 +--
> NetworkPkg/Udp6Dxe/Udp6Impl.h | 12 ++---
> NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.h | 2 +-
> NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h | 8 +--
> NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h | 4 +-
> NetworkPkg/UefiPxeBcDxe/PxeBcSupport.h | 16 +++---
> NetworkPkg/VlanConfigDxe/VlanConfigImpl.h | 6 +--
> OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h | 10 ++--
> OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h | 8 +--
> OvmfPkg/Csm/Include/Framework/BootScript.h | 2 +-
> OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h | 2 +-
> OvmfPkg/Csm/Include/Protocol/IsaAcpi.h | 2 +-
> OvmfPkg/Csm/Include/Protocol/IsaIo.h | 2 +-
> OvmfPkg/Csm/Include/Protocol/LegacyBios.h | 6 +--
> OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h | 4 +-
> OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h | 2 +-
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h | 8 +--
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h | 4 +-
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h | 2 +-
> OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h | 2 +-
> OvmfPkg/Include/IndustryStandard/Xen/grant_table.h | 4 +-
> OvmfPkg/Include/IndustryStandard/Xen/io/blkif.h | 2 +-
> OvmfPkg/Include/Library/VirtioLib.h | 2 +-
> OvmfPkg/Include/Protocol/XenBus.h | 4 +-
> OvmfPkg/Include/Protocol/XenIo.h | 2 +-
> OvmfPkg/XenBusDxe/DriverBinding.h | 2 +-
> OvmfPkg/XenBusDxe/EventChannel.h | 2 +-
> OvmfPkg/XenBusDxe/GrantTable.h | 4 +-
> OvmfPkg/XenPvBlkDxe/BlockIo.h | 6 +--
> OvmfPkg/XenPvBlkDxe/DriverBinding.h | 2 +-
> SecurityPkg/Include/Library/TcgStorageCoreLib.h | 4 +-
> SecurityPkg/Include/Library/TpmCommLib.h | 4 +-
> SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h | 6 +--
> ShellPkg/Application/Shell/ConsoleLogger.h | 4 +-
> ShellPkg/Application/Shell/FileHandleWrappers.h | 6 +--
> ShellPkg/Application/Shell/Shell.h | 2 +-
> ShellPkg/Application/Shell/ShellEnvVar.h | 36 +++++++-------
> ShellPkg/Application/Shell/ShellManParser.h | 10 ++--
> ShellPkg/Application/Shell/ShellParametersProtocol.h | 20 ++++----
> ShellPkg/Application/Shell/ShellProtocol.h | 12 ++---
> ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h | 2 +-
> ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.h | 2 +-
> SignedCapsulePkg/Include/Guid/EdkiiSystemFmpCapsule.h | 4 +-
> SignedCapsulePkg/Include/Library/IniParsingLib.h | 14 +++---
> SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h | 2 +-
> SourceLevelDebugPkg/Include/Ia32/ProcessorContext.h | 2 +-
> SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h | 2 +-
> SourceLevelDebugPkg/Include/TransferProtocol.h | 6 +--
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h | 6 +--
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/ArchDebugSupport.h | 2 +-
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/DebugException.h | 2 +-
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/ArchDebugSupport.h | 2 +-
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/DebugException.h | 2 +-
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Internal.h | 4 +-
> UefiCpuPkg/CpuDxe/CpuDxe.h | 2 +-
> UefiCpuPkg/CpuDxe/CpuGdt.h | 2 +-
> UefiCpuPkg/CpuDxe/CpuMp.h | 4 +-
> UefiCpuPkg/CpuDxe/CpuPageTable.h | 2 +-
> UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h | 4 +-
> UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.h | 4 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 12 ++---
> NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigVfr.vfr | 6 +--
> CryptoPkg/Library/OpensslLib/rand_pool.c | 8 +--
> CryptoPkg/Library/OpensslLib/rand_pool_noise.c | 2 +-
> EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c | 16 +++---
> EmulatorPkg/Sec/Sec.c | 5 +-
> EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 2 +-
> EmulatorPkg/Unix/Host/BlockIo.c | 12 ++---
> EmulatorPkg/Unix/Host/EmuThunk.c | 2 +-
> EmulatorPkg/Unix/Host/Host.c | 26 +++++-----
> EmulatorPkg/Unix/Host/LinuxPacketFilter.c | 2 +-
> EmulatorPkg/Unix/Host/Pthreads.c | 2 +-
> EmulatorPkg/Win/Host/WinBlockIo.c | 4 +-
> EmulatorPkg/Win/Host/WinFileSystem.c | 2 +-
> EmulatorPkg/Win/Host/WinGopInput.c | 4 +-
> EmulatorPkg/Win/Host/WinGopScreen.c | 14 +++---
> EmulatorPkg/Win/Host/WinHost.c | 10 ++--
> FatPkg/EnhancedFatDxe/Delete.c | 2 +-
> FatPkg/EnhancedFatDxe/DirectoryManage.c | 2 +-
> FatPkg/EnhancedFatDxe/Fat.c | 2 +-
> FatPkg/EnhancedFatDxe/FileName.c | 2 +-
> FatPkg/EnhancedFatDxe/FileSpace.c | 6 +--
> FatPkg/EnhancedFatDxe/Flush.c | 4 +-
> FatPkg/FatPei/FatLiteApi.c | 2 +-
> FatPkg/FatPei/Mbr.c | 2 +-
> IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 2 +-
> IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/FspWrapperPlatformLibSample.c | 4 +-
> IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/FspWrapperHobProcessLibSample.c | 4 +-
> MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 2 +-
> MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 4 +-
> MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c | 2 +-
> MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c | 2 +-
> MdeModulePkg/Bus/Ata/AhciPei/AhciMode.c | 8 +--
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 14 +++---
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c | 8 +--
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c | 16 +++---
> MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c | 10 ++--
> MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c | 4 +-
> MdeModulePkg/Bus/I2c/I2cDxe/I2cBus.c | 4 +-
> MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c | 2 +-
> MdeModulePkg/Bus/Isa/IsaBusDxe/IsaBusDxe.c | 6 +--
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 16 +++---
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c | 20 ++++----
> MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c | 4 +-
> MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.c | 2 +-
> MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.c | 4 +-
> MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 6 +--
> MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 32 ++++++------
> MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c | 2 +-
> MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c | 12 ++---
> MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c | 12 ++---
> MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.c | 2 +-
> MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c | 2 +-
> MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHci.c | 6 +--
> MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 10 ++--
> MdeModulePkg/Bus/Sd/SdDxe/SdDxe.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbBotPei/BotPeim.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c | 12 ++---
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c | 4 +-
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c | 8 +--
> MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusPei/UsbIoPeim.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c | 8 +--
> MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c | 6 +--
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c | 4 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBot.c | 4 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassCbi.c | 4 +-
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c | 4 +-
> MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/MouseHid.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbMouseAbsolutePointerDxe/UsbMouseAbsolutePointer.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c | 2 +-
> MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c | 2 +-
> MdeModulePkg/Core/Pei/Dependency/Dependency.c | 4 +-
> MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 28 +++++------
> MdeModulePkg/Core/Pei/FwVol/FwVol.c | 8 +--
> MdeModulePkg/Core/Pei/Hob/Hob.c | 2 +-
> MdeModulePkg/Core/Pei/Image/Image.c | 8 +--
> MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 10 ++--
> MdeModulePkg/Core/Pei/PeiMain/PeiMain.c | 4 +-
> MdeModulePkg/Core/Pei/Ppi/Ppi.c | 2 +-
> MdeModulePkg/Core/Pei/Security/Security.c | 2 +-
> MdeModulePkg/Core/PiSmmCore/Dependency.c | 4 +-
> MdeModulePkg/Core/PiSmmCore/Dispatcher.c | 24 ++++-----
> MdeModulePkg/Core/PiSmmCore/HeapGuard.c | 4 +-
> MdeModulePkg/Core/PiSmmCore/Locate.c | 8 +--
> MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c | 8 +--
> MdeModulePkg/Core/PiSmmCore/Page.c | 4 +-
> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 10 ++--
> MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 8 +--
> MdeModulePkg/Core/PiSmmCore/Smi.c | 2 +-
> MdeModulePkg/Core/PiSmmCore/SmramProfileRecord.c | 4 +-
> MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.c | 10 ++--
> MdePkg/Library/DxeHobLib/HobLib.c | 2 +-
> MdePkg/Library/DxeIoLibCpuIo2/IoLib.c | 2 +-
> MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.c | 6 +--
> MdePkg/Library/DxeServicesLib/DxeServicesLib.c | 12 ++---
> MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.c | 2 +-
> MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c | 2 +-
> MdePkg/Library/PciSegmentLibSegmentInfo/DxeRuntimePciSegmentLib.c | 2 +-
> MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c | 4 +-
> MdePkg/Library/SmmMemLib/SmmMemLib.c | 4 +-
> MdePkg/Library/SmmPciExpressLib/PciExpressLib.c | 4 +-
> MdePkg/Library/SmmPciLibPciRootBridgeIo/PciLib.c | 6 +--
> MdePkg/Library/SmmPeriodicSmiLib/SmmPeriodicSmiLib.c | 42 ++++++++--------
> MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.c | 2 +-
> NetworkPkg/ArpDxe/ArpDriver.c | 14 +++---
> NetworkPkg/ArpDxe/ArpImpl.c | 16 +++---
> NetworkPkg/ArpDxe/ArpMain.c | 10 ++--
> NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c | 8 +--
> NetworkPkg/Dhcp4Dxe/Dhcp4Impl.c | 6 +--
> NetworkPkg/Dhcp4Dxe/Dhcp4Io.c | 12 ++---
> NetworkPkg/Dhcp4Dxe/Dhcp4Option.c | 26 +++++-----
> NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c | 12 ++---
> NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c | 12 ++---
> NetworkPkg/Dhcp6Dxe/Dhcp6Io.c | 26 +++++-----
> NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c | 16 +++---
> NetworkPkg/DnsDxe/DnsDriver.c | 12 ++---
> NetworkPkg/DnsDxe/DnsImpl.c | 28 +++++------
> NetworkPkg/DnsDxe/DnsProtocol.c | 16 +++---
> NetworkPkg/DpcDxe/Dpc.c | 6 +--
> NetworkPkg/HttpBootDxe/HttpBootConfig.c | 4 +-
> NetworkPkg/HttpBootDxe/HttpBootDhcp4.c | 2 +-
> NetworkPkg/HttpBootDxe/HttpBootDhcp6.c | 10 ++--
> NetworkPkg/HttpBootDxe/HttpBootDxe.c | 8 +--
> NetworkPkg/HttpBootDxe/HttpBootImpl.c | 2 +-
> NetworkPkg/HttpBootDxe/HttpBootSupport.c | 12 ++---
> NetworkPkg/HttpDxe/HttpDriver.c | 12 ++---
> NetworkPkg/HttpDxe/HttpImpl.c | 10 ++--
> NetworkPkg/HttpDxe/HttpProto.c | 22 ++++-----
> NetworkPkg/HttpDxe/HttpsSupport.c | 2 +-
> NetworkPkg/IScsiDxe/ComponentName.c | 2 +-
> NetworkPkg/IScsiDxe/IScsiCHAP.c | 4 +-
> NetworkPkg/IScsiDxe/IScsiConfig.c | 6 +--
> NetworkPkg/IScsiDxe/IScsiDhcp.c | 4 +-
> NetworkPkg/IScsiDxe/IScsiDriver.c | 10 ++--
> NetworkPkg/IScsiDxe/IScsiMisc.c | 6 +--
> NetworkPkg/IScsiDxe/IScsiProto.c | 40 +++++++--------
> NetworkPkg/Ip4Dxe/Ip4Common.c | 10 ++--
> NetworkPkg/Ip4Dxe/Ip4Config2Impl.c | 10 ++--
> NetworkPkg/Ip4Dxe/Ip4Config2Nv.c | 4 +-
> NetworkPkg/Ip4Dxe/Ip4Driver.c | 10 ++--
> NetworkPkg/Ip4Dxe/Ip4Icmp.c | 2 +-
> NetworkPkg/Ip4Dxe/Ip4If.c | 14 +++---
> NetworkPkg/Ip4Dxe/Ip4Igmp.c | 8 +--
> NetworkPkg/Ip4Dxe/Ip4Impl.c | 14 +++---
> NetworkPkg/Ip4Dxe/Ip4Input.c | 28 +++++------
> NetworkPkg/Ip4Dxe/Ip4Option.c | 4 +-
> NetworkPkg/Ip4Dxe/Ip4Output.c | 12 ++---
> NetworkPkg/Ip4Dxe/Ip4Route.c | 14 +++---
> NetworkPkg/Ip6Dxe/Ip6Common.c | 2 +-
> NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c | 10 ++--
> NetworkPkg/Ip6Dxe/Ip6ConfigNv.c | 6 +--
> NetworkPkg/Ip6Dxe/Ip6Driver.c | 12 ++---
> NetworkPkg/Ip6Dxe/Ip6Icmp.c | 6 +--
> NetworkPkg/Ip6Dxe/Ip6If.c | 10 ++--
> NetworkPkg/Ip6Dxe/Ip6Impl.c | 10 ++--
> NetworkPkg/Ip6Dxe/Ip6Input.c | 20 ++++----
> NetworkPkg/Ip6Dxe/Ip6Mld.c | 8 +--
> NetworkPkg/Ip6Dxe/Ip6Nd.c | 12 ++---
> NetworkPkg/Ip6Dxe/Ip6Output.c | 2 +-
> NetworkPkg/Ip6Dxe/Ip6Route.c | 6 +--
> NetworkPkg/Library/DxeHttpLib/DxeHttpLib.c | 4 +-
> NetworkPkg/Library/DxeIpIoLib/DxeIpIoLib.c | 16 +++---
> NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 26 +++++-----
> NetworkPkg/Library/DxeNetLib/NetBuffer.c | 4 +-
> NetworkPkg/Library/DxeTcpIoLib/DxeTcpIoLib.c | 10 ++--
> NetworkPkg/Library/DxeUdpIoLib/DxeUdpIoLib.c | 10 ++--
> NetworkPkg/MnpDxe/MnpConfig.c | 14 +++---
> NetworkPkg/MnpDxe/MnpDriver.c | 10 ++--
> NetworkPkg/MnpDxe/MnpIo.c | 8 +--
> NetworkPkg/MnpDxe/MnpMain.c | 6 +--
> NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c | 4 +-
> NetworkPkg/Mtftp4Dxe/Mtftp4Impl.c | 10 ++--
> NetworkPkg/Mtftp4Dxe/Mtftp4Option.c | 20 ++++----
> NetworkPkg/Mtftp4Dxe/Mtftp4Rrq.c | 10 ++--
> NetworkPkg/Mtftp4Dxe/Mtftp4Support.c | 6 +--
> NetworkPkg/Mtftp4Dxe/Mtftp4Wrq.c | 8 +--
> NetworkPkg/Mtftp6Dxe/Mtftp6Driver.c | 4 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Impl.c | 4 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Option.c | 4 +-
> NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c | 10 ++--
> NetworkPkg/Mtftp6Dxe/Mtftp6Support.c | 8 +--
> NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c | 4 +-
> NetworkPkg/SnpDxe/Callback.c | 2 +-
> NetworkPkg/SnpDxe/Shutdown.c | 2 +-
> NetworkPkg/SnpDxe/Snp.c | 6 +--
> NetworkPkg/SnpDxe/WaitForPacket.c | 2 +-
> NetworkPkg/TcpDxe/SockImpl.c | 4 +-
> NetworkPkg/TcpDxe/SockInterface.c | 10 ++--
> NetworkPkg/TcpDxe/TcpDispatcher.c | 6 +--
> NetworkPkg/TcpDxe/TcpDriver.c | 10 ++--
> NetworkPkg/TcpDxe/TcpInput.c | 8 +--
> NetworkPkg/TcpDxe/TcpMain.c | 4 +-
> NetworkPkg/TcpDxe/TcpMisc.c | 2 +-
> NetworkPkg/TcpDxe/TcpOption.c | 2 +-
> NetworkPkg/TcpDxe/TcpOutput.c | 4 +-
> NetworkPkg/TcpDxe/TcpTimer.c | 2 +-
> NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 6 +--
> NetworkPkg/TlsDxe/TlsDriver.c | 4 +-
> NetworkPkg/Udp4Dxe/Udp4Driver.c | 4 +-
> NetworkPkg/Udp4Dxe/Udp4Impl.c | 12 ++---
> NetworkPkg/Udp4Dxe/Udp4Main.c | 4 +-
> NetworkPkg/Udp6Dxe/Udp6Driver.c | 8 +--
> NetworkPkg/Udp6Dxe/Udp6Impl.c | 18 +++----
> NetworkPkg/Udp6Dxe/Udp6Main.c | 12 ++---
> NetworkPkg/UefiPxeBcDxe/PxeBcBoot.c | 4 +-
> NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c | 10 ++--
> NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c | 18 +++----
> NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c | 4 +-
> NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c | 10 ++--
> NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c | 12 ++---
> NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c | 8 +--
> NetworkPkg/VlanConfigDxe/VlanConfigDriver.c | 8 +--
> OvmfPkg/AcpiPlatformDxe/BootScript.c | 2 +-
> OvmfPkg/AcpiPlatformDxe/Qemu.c | 4 +-
> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 2 +-
> OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c | 4 +-
> OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c | 6 +--
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 6 +--
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c | 4 +-
> OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c | 8 +--
> OvmfPkg/Csm/LegacyBiosDxe/Thunk.c | 4 +-
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c | 14 +++---
> OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c | 18 +++----
> OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c | 4 +-
> OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 4 +-
> OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c | 2 +-
> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c | 2 +-
> OvmfPkg/Library/VirtioLib/VirtioLib.c | 2 +-
> OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c | 6 +--
> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbInfo.c | 4 +-
> OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c | 8 +--
> OvmfPkg/QemuVideoDxe/Driver.c | 2 +-
> OvmfPkg/VirtioNetDxe/DriverBinding.c | 2 +-
> OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c | 2 +-
> OvmfPkg/VirtioRngDxe/VirtioRng.c | 2 +-
> OvmfPkg/VirtioScsiDxe/VirtioScsi.c | 2 +-
> OvmfPkg/XenBusDxe/XenBus.c | 2 +-
> OvmfPkg/XenBusDxe/XenBusDxe.c | 6 +--
> OvmfPkg/XenBusDxe/XenStore.c | 4 +-
> OvmfPkg/XenPvBlkDxe/BlockFront.c | 2 +-
> OvmfPkg/XenPvBlkDxe/BlockIo.c | 8 +--
> OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.c | 2 +-
> PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c | 2 +-
> PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c | 6 +--
> SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c | 2 +-
> SecurityPkg/Library/DxeTcgPhysicalPresenceLib/DxeTcgPhysicalPresenceLib.c | 2 +-
> SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c | 2 +-
> SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c | 2 +-
> SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.c | 2 +-
> SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c | 2 +-
> SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c | 2 +-
> SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c | 2 +-
> SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c | 4 +-
> SecurityPkg/Library/Tpm2CommandLib/Tpm2Miscellaneous.c | 2 +-
> SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 4 +-
> SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c | 6 +--
> SecurityPkg/Library/TpmCommLib/TisPc.c | 2 +-
> SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c | 2 +-
> SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.c | 2 +-
> SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c | 10 ++--
> SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 2 +-
> SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c | 8 +--
> SecurityPkg/Tcg/PhysicalPresencePei/PhysicalPresencePei.c | 2 +-
> SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c | 2 +-
> SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 +-
> SecurityPkg/Tcg/TcgPei/TcgPei.c | 8 +--
> SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigFileExplorer.c | 2 +-
> SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c | 2 +-
> ShellPkg/Application/Shell/ConsoleLogger.c | 12 ++---
> ShellPkg/Application/Shell/ConsoleWrappers.c | 2 +-
> ShellPkg/Application/Shell/FileHandleWrappers.c | 8 +--
> ShellPkg/Application/Shell/Shell.c | 8 +--
> ShellPkg/Application/Shell/ShellEnvVar.c | 8 +--
> ShellPkg/Application/Shell/ShellManParser.c | 20 ++++----
> ShellPkg/Application/Shell/ShellParametersProtocol.c | 26 +++++-----
> ShellPkg/Application/Shell/ShellProtocol.c | 36 +++++++-------
> ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 4 +-
> ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.c | 2 +-
> ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.c | 4 +-
> ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c | 4 +-
> ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 8 +--
> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.c | 2 +-
> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.c | 4 +-
> SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c | 26 +++++-----
> SignedCapsulePkg/Universal/RecoveryModuleLoadPei/ParseConfigProfile.c | 2 +-
> SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.c | 14 +++---
> SignedCapsulePkg/Universal/SystemFirmwareUpdate/ParseConfigProfile.c | 2 +-
> SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c | 4 +-
> SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.c | 8 +--
> SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c | 4 +-
> SourceLevelDebugPkg/DebugAgentDxe/DebugAgentDxe.c | 2 +-
> SourceLevelDebugPkg/DebugAgentPei/DebugAgentPei.c | 2 +-
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c | 52 ++++++++++----------
> SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/DxeDebugAgentLib.c | 2 +-
> SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c | 6 +--
> SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c | 10 ++--
> SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebugAgentLib.c | 10 ++--
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.c | 2 +-
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Common.c | 2 +-
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Dxe.c | 2 +-
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Transfer.c | 4 +-
> StandaloneMmPkg/Core/Dependency.c | 2 +-
> StandaloneMmPkg/Core/Dispatcher.c | 2 +-
> StandaloneMmPkg/Core/FwVol.c | 2 +-
> StandaloneMmPkg/Core/StandaloneMmCore.c | 2 +-
> UefiCpuPkg/CpuDxe/CpuDxe.c | 8 +--
> UefiCpuPkg/CpuDxe/CpuGdt.c | 2 +-
> UefiCpuPkg/CpuDxe/CpuMp.c | 4 +-
> UefiCpuPkg/CpuDxe/CpuPageTable.c | 6 +--
> UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c | 4 +-
> UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c | 2 +-
> UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 4 +-
> UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c | 4 +-
> UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c | 2 +-
> UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.c | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 4 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 4 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 6 +--
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c | 2 +-
> EmulatorPkg/Sec/Ia32/SwitchRam.S | 18 +++----
> EmulatorPkg/Sec/Ia32/SwitchRam.asm | 20 ++++----
> EmulatorPkg/Sec/X64/SwitchRam.S | 2 +-
> EmulatorPkg/Sec/X64/SwitchRam.asm | 2 +-
> EmulatorPkg/Unix/GdbRun.sh | 4 +-
> EmulatorPkg/Unix/Host/X64/Gasket.S | 4 +-
> EmulatorPkg/Unix/Host/X64/SwitchStack.S | 2 +-
> EmulatorPkg/Unix/lldbefi.py | 14 +++---
> IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Thunk64To32.nasm | 6 +--
> IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/SecEntry.nasm | 2 +-
> IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/Ia32/Stack.nasm | 2 +-
> MdeModulePkg/Application/UiApp/FrontPageStrings.uni | 6 +--
> MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.uni | 2 +-
> MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.uni | 2 +-
> MdePkg/Library/DxePcdLib/DxePcdLib.uni | 2 +-
> NetworkPkg/MnpDxe/MnpDxe.uni | 4 +-
> OvmfPkg/AcpiTables/Facp.aslc | 8 +--
> OvmfPkg/AcpiTables/Facs.aslc | 4 +-
> OvmfPkg/AcpiTables/Madt.aslc | 2 +-
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni | 8 +--
> OvmfPkg/QemuVideoDxe/VbeShim.asm | 14 +++---
> SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.uni | 4 +-
> SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.uni | 2 +-
> SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.uni | 2 +-
> SecurityPkg/Tcg/TcgSmm/TcgSmm.uni | 2 +-
> ShellPkg/Application/ShellCTestApp/README.txt | 2 +-
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/AsmFuncs.nasm | 4 +-
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.uni | 2 +-
> UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm | 2 +-
> 587 files changed, 1853 insertions(+), 1854 deletions(-)
>
^ permalink raw reply [flat|nested] 122+ messages in thread[parent not found: <20191203161602.15969-70-philmd@redhat.com>]
* Re: [PATCH 69/79] ShellPkg/DynamicCommand: Fix various typos
[not found] ` <20191203161602.15969-70-philmd@redhat.com>
@ 2019-12-13 2:33 ` Gao, Zhichao
0 siblings, 0 replies; 122+ messages in thread
From: Gao, Zhichao @ 2019-12-13 2:33 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io; +Cc: Antoine Coeur, Ni, Ray
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
> -----Original Message-----
> From: Philippe Mathieu-Daude [mailto:philmd@redhat.com]
> Sent: Wednesday, December 4, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Ni, Ray <ray.ni@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>; Philippe Mathieu-Daude
> <philmd@redhat.com>
> Subject: [PATCH 69/79] ShellPkg/DynamicCommand: Fix various typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h | 2 +-
> ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.h | 2 +-
> ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 4 ++--
> ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.c | 2 +-
> ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.c
> | 4 ++--
> ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c | 4 ++--
> ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 8 ++++--
> --
> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.c | 2 +-
>
> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.
> c | 4 ++--
> 9 files changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h
> b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h
> index e446cccde923..84fe0b502f46 100644
> --- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h
> +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h
> @@ -127,7 +127,7 @@ RunDp (
> );
>
> /**
> - Retrive HII package list from ImageHandle and publish to HII database.
> + Retrieve HII package list from ImageHandle and publish to HII database.
>
> @param ImageHandle The image handle of the process.
>
> diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.h
> b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.h
> index 4cd778436813..c46a0d5b0c3b 100644
> --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.h
> +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.h
> @@ -56,7 +56,7 @@ RunTftp (
> );
>
> /**
> - Retrive HII package list from ImageHandle and publish to HII database.
> + Retrieve HII package list from ImageHandle and publish to HII database.
>
> @param ImageHandle The image handle of the process.
>
> diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
> b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
> index 4ec4c18348bd..f7f3676bc91a 100644
> --- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
> +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
> @@ -154,7 +154,7 @@ GetHandleFormModuleGuid (
> *Handle = NULL;
> }
> //
> - // Try to get the Handle form the caached array.
> + // Try to get the Handle from the cached array.
> //
> for (Index = 0; Index < mCachePairCount; Index++) {
> if (CompareGuid (ModuleGuid,
> &mCacheHandleGuidTable[Index].ModuleGuid)) { @@ -918,7 +918,7 @@
> Done:
>
>
> /**
> - Retrive HII package list from ImageHandle and publish to HII database.
> + Retrieve HII package list from ImageHandle and publish to HII database.
>
> @param ImageHandle The image handle of the process.
>
> diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.c
> b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.c
> index a7cecdfe0ade..b4b242a41158 100644
> --- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.c
> +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.c
> @@ -24,7 +24,7 @@ GLOBAL_REMOVE_IF_UNREFERENCED EFI_STRING_ID
> mStringHelpTokenId = STRING_TOKEN (S
> @param ImageHandle The image handle of the process.
> @param SystemTable The EFI System Table pointer.
>
> - @retval EFI_SUCCESS Tftp command is executed sucessfully.
> + @retval EFI_SUCCESS Tftp command is executed successfully.
> @retval EFI_ABORTED HII package was failed to initialize.
> @retval others Other errors when executing tftp command.
> **/
> diff --git
> a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.
> c
> b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.
> c
> index d7dd85666c50..50fcc6e74616 100644
> ---
> a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.
> c
> +++
> b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.
> c
> @@ -19,7 +19,7 @@
> @param[in] Shell The instance of the shell protocol used in the
> context
> of processing this command.
>
> - @return EFI_SUCCESS the operation was sucessful
> + @return EFI_SUCCESS the operation was successful
> @return other the operation failed.
> **/
> SHELL_STATUS
> @@ -70,7 +70,7 @@ EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL
> mDpDynamicCommand = {
> @param ImageHandle The image handle of the process.
> @param SystemTable The EFI System Table pointer.
>
> - @retval EFI_SUCCESS Tftp command is executed sucessfully.
> + @retval EFI_SUCCESS Tftp command is executed successfully.
> @retval EFI_ABORTED HII package was failed to initialize.
> @retval others Other errors when executing tftp command.
> **/
> diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c
> b/ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c
> index f64c5ccf58f9..1a247d4bd492 100644
> --- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c
> +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpTrace.c
> @@ -85,7 +85,7 @@ GetPerformanceMeasurementRecord (
> @post The SummaryData and CumData structures contain statistics for the
> current performance logs.
>
> - @param[in, out] CustomCumulativeData A pointer to the cumtom
> cumulative data.
> + @param[in, out] CustomCumulativeData A pointer to the custom
> cumulative data.
>
> **/
> VOID
> @@ -830,7 +830,7 @@ ProcessGlobal(
> - Update the instance count and the total, minimum, and maximum
> durations.
> Finally, print the gathered cumulative statistics.
>
> - @param[in] CustomCumulativeData A pointer to the cumtom cumulative
> data.
> + @param[in] CustomCumulativeData A pointer to the custom cumulative
> data.
>
> **/
> VOID
> diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> index f28da9af723c..4e296c495b2d 100644
> --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c
> @@ -15,7 +15,7 @@ EFI_HII_HANDLE mTftpHiiHandle;
>
> /*
> Constant strings and definitions related to the message indicating the
> amount of
> - progress in the dowloading of a TFTP file.
> + progress in the downloading of a TFTP file.
> */
>
> // Frame for the progression slider
> @@ -48,7 +48,7 @@ CONST CHAR16 *mLocalFilePath;
> @param[out] Value UINT16 value
>
> @return TRUE The value was returned.
> - @return FALSE A parsing error occured.
> + @return FALSE A parsing error occurred.
> **/
> STATIC
> BOOLEAN
> @@ -585,7 +585,7 @@ RunTftp (
> @param[out] Value UINT16 value
>
> @return TRUE The value was returned.
> - @return FALSE A parsing error occured.
> + @return FALSE A parsing error occurred.
> **/
> STATIC
> BOOLEAN
> @@ -1081,7 +1081,7 @@ CheckPacket (
> }
>
> /**
> - Retrive HII package list from ImageHandle and publish to HII database.
> + Retrieve HII package list from ImageHandle and publish to HII database.
>
> @param ImageHandle The image handle of the process.
>
> diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.c
> b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.c
> index 34466eda4b87..0972454c2863 100644
> --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.c
> +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.c
> @@ -25,7 +25,7 @@ GLOBAL_REMOVE_IF_UNREFERENCED EFI_STRING_ID
> mStringHelpTokenId = STRING_TOKEN (S
> @param ImageHandle The image handle of the process.
> @param SystemTable The EFI System Table pointer.
>
> - @retval EFI_SUCCESS Tftp command is executed sucessfully.
> + @retval EFI_SUCCESS Tftp command is executed successfully.
> @retval EFI_ABORTED HII package was failed to initialize.
> @retval others Other errors when executing tftp command.
> **/
> diff --git
> a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> d.c
> b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> d.c
> index 4022e0ec7886..8e5df7b2d160 100644
> ---
> a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> d.c
> +++
> b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> d.c
> @@ -20,7 +20,7 @@
> @param[in] Shell The instance of the shell protocol used in the
> context
> of processing this command.
>
> - @return EFI_SUCCESS the operation was sucessful
> + @return EFI_SUCCESS the operation was successful
> @return other the operation failed.
> **/
> SHELL_STATUS
> @@ -71,7 +71,7 @@ EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL
> mTftpDynamicCommand = {
> @param ImageHandle The image handle of the process.
> @param SystemTable The EFI System Table pointer.
>
> - @retval EFI_SUCCESS Tftp command is executed sucessfully.
> + @retval EFI_SUCCESS Tftp command is executed successfully.
> @retval EFI_ABORTED HII package was failed to initialize.
> @retval others Other errors when executing tftp command.
> **/
> --
> 2.21.0
^ permalink raw reply [flat|nested] 122+ messages in thread
[parent not found: <20191203161602.15969-69-philmd@redhat.com>]
* Re: [PATCH 68/79] ShellPkg/Application: Fix various typos
[not found] ` <20191203161602.15969-69-philmd@redhat.com>
@ 2019-12-13 2:33 ` Gao, Zhichao
0 siblings, 0 replies; 122+ messages in thread
From: Gao, Zhichao @ 2019-12-13 2:33 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io; +Cc: Antoine Coeur, Ni, Ray
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
> -----Original Message-----
> From: Philippe Mathieu-Daude [mailto:philmd@redhat.com]
> Sent: Wednesday, December 4, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Ni, Ray <ray.ni@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>; Philippe Mathieu-Daude
> <philmd@redhat.com>
> Subject: [PATCH 68/79] ShellPkg/Application: Fix various typos
>
> From: Antoine Coeur <coeur@gmx.fr>
>
> Fix various typos in comments and documentation.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> ShellPkg/Application/Shell/ConsoleLogger.h | 4 +--
> ShellPkg/Application/Shell/FileHandleWrappers.h | 6 ++--
> ShellPkg/Application/Shell/Shell.h | 2 +-
> ShellPkg/Application/Shell/ShellEnvVar.h | 36 ++++++++++----------
> ShellPkg/Application/Shell/ShellManParser.h | 10 +++---
> ShellPkg/Application/Shell/ShellParametersProtocol.h | 20 +++++------
> ShellPkg/Application/Shell/ShellProtocol.h | 12 +++----
> ShellPkg/Application/Shell/ConsoleLogger.c | 12 +++----
> ShellPkg/Application/Shell/ConsoleWrappers.c | 2 +-
> ShellPkg/Application/Shell/FileHandleWrappers.c | 8 ++---
> ShellPkg/Application/Shell/Shell.c | 8 ++---
> ShellPkg/Application/Shell/ShellEnvVar.c | 8 ++---
> ShellPkg/Application/Shell/ShellManParser.c | 20 +++++------
> ShellPkg/Application/Shell/ShellParametersProtocol.c | 26 +++++++-------
> ShellPkg/Application/Shell/ShellProtocol.c | 36 ++++++++++----------
> ShellPkg/Application/ShellCTestApp/README.txt | 2 +-
> 16 files changed, 106 insertions(+), 106 deletions(-)
>
> diff --git a/ShellPkg/Application/Shell/ConsoleLogger.h
> b/ShellPkg/Application/Shell/ConsoleLogger.h
> index c2d5a9dcd4e0..0a01bc2ca201 100644
> --- a/ShellPkg/Application/Shell/ConsoleLogger.h
> +++ b/ShellPkg/Application/Shell/ConsoleLogger.h
> @@ -117,7 +117,7 @@ UpdateDisplayFromHistory(
> );
>
> /**
> - Reset the text output device hardware and optionaly run diagnostics
> + Reset the text output device hardware and optionally run diagnostics
>
> @param This Pointer to EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL
> @param ExtendedVerification Indicates that a more extensive test may be
> performed @@ -305,7 +305,7 @@ ConsoleLoggerEnableCursor (
>
> @param[in] ConsoleInfo The pointer to the instance of the console logger
> information.
>
> - This will be used when a mode has changed or a reset ocurred to verify all
> + This will be used when a mode has changed or a reset occurred to
> + verify all
> history buffers.
> **/
> EFI_STATUS
> diff --git a/ShellPkg/Application/Shell/FileHandleWrappers.h
> b/ShellPkg/Application/Shell/FileHandleWrappers.h
> index 3398285d52f8..5d58bfb2f45c 100644
> --- a/ShellPkg/Application/Shell/FileHandleWrappers.h
> +++ b/ShellPkg/Application/Shell/FileHandleWrappers.h
> @@ -20,17 +20,17 @@ typedef struct {
> } SHELL_LINE_LOG;
>
> ///
> -/// FILE sytle interfaces for StdIn.
> +/// FILE styte interfaces for StdIn.
> ///
> extern EFI_FILE_PROTOCOL FileInterfaceStdIn;
>
> ///
> -/// FILE sytle interfaces for StdOut.
> +/// FILE styte interfaces for StdOut.
> ///
> extern EFI_FILE_PROTOCOL FileInterfaceStdOut;
>
> ///
> -/// FILE sytle interfaces for StdErr.
> +/// FILE styte interfaces for StdErr.
> ///
> extern EFI_FILE_PROTOCOL FileInterfaceStdErr;
>
> diff --git a/ShellPkg/Application/Shell/Shell.h
> b/ShellPkg/Application/Shell/Shell.h
> index 1227adc1eb63..e6eb150f57a5 100644
> --- a/ShellPkg/Application/Shell/Shell.h
> +++ b/ShellPkg/Application/Shell/Shell.h
> @@ -135,7 +135,7 @@ typedef struct {
> extern SHELL_INFO ShellInfoObject;
>
> /**
> - Converts the command line to it's post-processed form. this replaces
> variables and alias' per UEFI Shell spec.
> + Converts the command line to its post-processed form. this replaces
> variables and alias' per UEFI Shell spec.
>
> @param[in,out] CmdLine pointer to the command line to update
>
> diff --git a/ShellPkg/Application/Shell/ShellEnvVar.h
> b/ShellPkg/Application/Shell/ShellEnvVar.h
> index 854a71ad9709..6c8552ee6437 100644
> --- a/ShellPkg/Application/Shell/ShellEnvVar.h
> +++ b/ShellPkg/Application/Shell/ShellEnvVar.h
> @@ -43,14 +43,14 @@ IsVolatileEnv (
> );
>
> /**
> - Delete a Non-Violatile environment variable.
> + Delete a Non-Volatile environment variable.
>
> - This will use the Runtime Services call SetVariable to remove a non-violatile
> variable.
> + This will use the Runtime Services call SetVariable to remove a non-volatile
> variable.
>
> @param EnvVarName The name of the environment variable in
> question
>
> - @retval EFI_SUCCESS The variable was deleted sucessfully
> - @retval other An error ocurred
> + @retval EFI_SUCCESS The variable was deleted successfully
> + @retval other An error occurred
> @sa SetVariable
> **/
> #define SHELL_DELETE_ENVIRONMENT_VARIABLE(EnvVarName) \ @@ -
> 61,16 +61,16 @@ IsVolatileEnv (
> NULL))
>
> /**
> - Set a Non-Violatile environment variable.
> + Set a Non-Volatile environment variable.
>
> - This will use the Runtime Services call SetVariable to set a non-violatile
> variable.
> + This will use the Runtime Services call SetVariable to set a non-volatile
> variable.
>
> @param EnvVarName The name of the environment variable in
> question
> @param BufferSize UINTN size of Buffer
> @param Buffer Pointer to value to set variable to
>
> - @retval EFI_SUCCESS The variable was changed sucessfully
> - @retval other An error ocurred
> + @retval EFI_SUCCESS The variable was changed successfully
> + @retval other An error occurred
> @sa SetVariable
> **/
> #define
> SHELL_SET_ENVIRONMENT_VARIABLE_NV(EnvVarName,BufferSize,Buffer)
> \ @@ -89,8 +89,8 @@ IsVolatileEnv (
> @param BufferSize Pointer to the UINTN size of Buffer
> @param Buffer Pointer buffer to get variable value into
>
> - @retval EFI_SUCCESS The variable's value was retrieved sucessfully
> - @retval other An error ocurred
> + @retval EFI_SUCCESS The variable's value was retrieved successfully
> + @retval other An error occurred
> @sa SetVariable
> **/
> #define
> SHELL_GET_ENVIRONMENT_VARIABLE(EnvVarName,BufferSize,Buffer) \
> @@ -110,8 +110,8 @@ IsVolatileEnv (
> @param BufferSize Pointer to the UINTN size of Buffer
> @param Buffer Pointer buffer to get variable value into
>
> - @retval EFI_SUCCESS The variable's value was retrieved sucessfully
> - @retval other An error ocurred
> + @retval EFI_SUCCESS The variable's value was retrieved successfully
> + @retval other An error occurred
> @sa SetVariable
> **/
> #define
> SHELL_GET_ENVIRONMENT_VARIABLE_AND_ATTRIBUTES(EnvVarName,Atts
> ,BufferSize,Buffer) \
> @@ -122,16 +122,16 @@ IsVolatileEnv (
> Buffer))
>
> /**
> - Set a Violatile environment variable.
> + Set a Volatile environment variable.
>
> - This will use the Runtime Services call SetVariable to set a violatile variable.
> + This will use the Runtime Services call SetVariable to set a volatile variable.
>
> @param EnvVarName The name of the environment variable in
> question
> @param BufferSize UINTN size of Buffer
> @param Buffer Pointer to value to set variable to
>
> - @retval EFI_SUCCESS The variable was changed sucessfully
> - @retval other An error ocurred
> + @retval EFI_SUCCESS The variable was changed successfully
> + @retval other An error occurred
> @sa SetVariable
> **/
> #define
> SHELL_SET_ENVIRONMENT_VARIABLE_V(EnvVarName,BufferSize,Buffer) \
> @@ -147,7 +147,7 @@ IsVolatileEnv (
> @param[in, out] List The pointer to pointer to LIST_ENTRY object for
> storing this list.
>
> - @retval EFI_SUCCESS the list was created sucessfully.
> + @retval EFI_SUCCESS the list was created successfully.
> **/
> EFI_STATUS
> GetEnvironmentVariableList(
> @@ -164,7 +164,7 @@ GetEnvironmentVariableList(
> @param[in] List The pointer to LIST_ENTRY from
> GetShellEnvVarList().
>
> - @retval EFI_SUCCESS The list was Set sucessfully.
> + @retval EFI_SUCCESS The list was Set successfully.
> **/
> EFI_STATUS
> SetEnvironmentVariableList(
> diff --git a/ShellPkg/Application/Shell/ShellManParser.h
> b/ShellPkg/Application/Shell/ShellManParser.h
> index 6fbad3aaaaec..04031e007fe9 100644
> --- a/ShellPkg/Application/Shell/ShellManParser.h
> +++ b/ShellPkg/Application/Shell/ShellManParser.h
> @@ -19,7 +19,7 @@
> information will be returned. If Sections is NULL, then all help text
> information
> available will be returned.
>
> - if BriefDesc is NULL, then the breif description will not be savedd seperatly,
> + if BriefDesc is NULL, then the breif description will not be savedd
> + separately,
> but placed first in the main HelpText.
>
> @param[in] ManFileName Points to the NULL-terminated UEFI Shell
> MAN file name.
> @@ -49,11 +49,11 @@ ProcessManFile(
>
> /**
> parses through the MAN file specified by SHELL_FILE_HANDLE and returns
> the
> - detailed help for any sub section specified in the comma seperated list of
> + detailed help for any sub section specified in the comma separated
> + list of
> sections provided. If the end of the file or a .TH section is found then
> return.
>
> - Upon a sucessful return the caller is responsible to free the memory in
> *HelpText
> + Upon a successful return the caller is responsible to free the memory
> + in *HelpText
>
> @param[in] Handle FileHandle to read from
> @param[in] Sections name of command's sub sections to find
> @@ -62,8 +62,8 @@ ProcessManFile(
> @param[in] Ascii TRUE if the file is ASCII, FALSE otherwise.
>
> @retval EFI_OUT_OF_RESOURCES a memory allocation failed.
> - @retval EFI_SUCCESS the section was found and its description sotred
> in
> - an alloceted buffer.
> + @retval EFI_SUCCESS the section was found and its description stored
> in
> + an allocated buffer.
> **/
> EFI_STATUS
> ManFileFindSections(
> diff --git a/ShellPkg/Application/Shell/ShellParametersProtocol.h
> b/ShellPkg/Application/Shell/ShellParametersProtocol.h
> index df0316a03091..398147c8bd4c 100644
> --- a/ShellPkg/Application/Shell/ShellParametersProtocol.h
> +++ b/ShellPkg/Application/Shell/ShellParametersProtocol.h
> @@ -43,7 +43,7 @@ CreatePopulateInstallShellParametersProtocol (
> );
>
> /**
> - frees all memory used by createion and installation of shell parameters
> protocol
> + frees all memory used by creation and installation of shell
> + parameters protocol
> and if there was an old version installed it will restore that one.
>
> @param NewShellParameters the interface of
> EFI_SHELL_PARAMETERS_PROTOCOL that is @@ -60,7 +60,7 @@
> CleanUpShellParametersProtocol (
> );
>
> /**
> - Funcion will replace the current Argc and Argv in the ShellParameters
> protocol
> + Function will replace the current Argc and Argv in the
> + ShellParameters protocol
> structure by parsing NewCommandLine. The current values are returned to
> the
> user.
>
> @@ -70,7 +70,7 @@ CleanUpShellParametersProtocol (
> @param[out] OldArgv pointer to old list of parameters
> @param[out] OldArgc pointer to old number of items in Argv list
>
> - @retval EFI_SUCCESS operation was sucessful, Argv and Argc are
> valid
> + @retval EFI_SUCCESS operation was successful, Argv and Argc are
> valid
> @retval EFI_OUT_OF_RESOURCES a memory allocation failed.
> **/
> EFI_STATUS
> @@ -83,7 +83,7 @@ UpdateArgcArgv(
> );
>
> /**
> - Funcion will replace the current Argc and Argv in the ShellParameters
> protocol
> + Function will replace the current Argc and Argv in the
> + ShellParameters protocol
> structure with Argv and Argc. The current values are de-allocated and the
> OldArgv must not be deallocated by the caller.
>
> @@ -108,7 +108,7 @@ typedef struct {
> } SYSTEM_TABLE_INFO;
>
> /**
> - Funcion will replace the current StdIn and StdOut in the ShellParameters
> protocol
> + Function will replace the current StdIn and StdOut in the
> + ShellParameters protocol
> structure by parsing NewCommandLine. The current values are returned to
> the
> user.
>
> @@ -121,7 +121,7 @@ typedef struct {
> @param[out] OldStdErr Pointer to old StdErr.
> @param[out] SystemTableInfo Pointer to old system table
> information.
>
> - @retval EFI_SUCCESS Operation was sucessful, Argv and Argc are
> valid.
> + @retval EFI_SUCCESS Operation was successful, Argv and Argc are
> valid.
> @retval EFI_OUT_OF_RESOURCES A memory allocation failed.
> **/
> EFI_STATUS
> @@ -135,7 +135,7 @@ UpdateStdInStdOutStdErr(
> );
>
> /**
> - Funcion will replace the current StdIn and StdOut in the ShellParameters
> protocol
> + Function will replace the current StdIn and StdOut in the
> + ShellParameters protocol
> structure with StdIn and StdOut. The current values are de-allocated.
>
> @param[in, out] ShellParameters Pointer to parameter structure to
> modify.
> @@ -166,7 +166,7 @@ RestoreStdInStdOutStdErr (
> @param[in, out] Argv pointer to array of strings; one for each
> parameter
> @param[in, out] Argc pointer to number of strings in Argv array
>
> - @return EFI_SUCCESS the operation was sucessful
> + @return EFI_SUCCESS the operation was successful
> @return EFI_OUT_OF_RESOURCES a memory allocation failed.
> **/
> EFI_STATUS
> @@ -188,13 +188,13 @@ ParseCommandLineToArgs(
> function.
>
> @param[in, out] Walker pointer to string of command line. Adjusted
> to
> - reminaing command line on return
> + remaining command line on return
> @param[in, out] TempParameter pointer to string of command line item
> extracted.
> @param[in] Length Length of (*TempParameter) in bytes
> @param[in] StripQuotation if TRUE then strip the quotation marks
> surrounding
> the parameters.
>
> - @return EFI_INALID_PARAMETER A required parameter was NULL or
> pointed to a NULL or empty string.
> + @return EFI_INVALID_PARAMETER A required parameter was NULL or
> pointed to a NULL or empty string.
> @return EFI_NOT_FOUND A closing " could not be found on the
> specified string
> **/
> EFI_STATUS
> diff --git a/ShellPkg/Application/Shell/ShellProtocol.h
> b/ShellPkg/Application/Shell/ShellProtocol.h
> index dcef16e43748..472d98dba2e7 100644
> --- a/ShellPkg/Application/Shell/ShellProtocol.h
> +++ b/ShellPkg/Application/Shell/ShellProtocol.h
> @@ -283,8 +283,8 @@ EfiShellBatchIsActive (
> @param Attributes the File Attributes to use when creating a new
> file
>
> @retval EFI_SUCCESS the file is open and FileHandle is valid
> - @retval EFI_UNSUPPORTED the device path cotained non-path
> elements
> - @retval other an error ocurred.
> + @retval EFI_UNSUPPORTED the device path contained non-path
> elements
> + @retval other an error occurred.
> **/
> EFI_STATUS
> InternalOpenFileDevicePath(
> @@ -309,7 +309,7 @@ InternalOpenFileDevicePath(
> already exists and is non-volatile then EFI_INVALID_PARAMETER is
> returned.
>
> @param FileName Pointer to NULL-terminated file path
> - @param FileAttribs The new file's attrbiutes. the different attributes
> are
> + @param FileAttribs The new file's attributes. the different attributes
> are
> described in EFI_FILE_PROTOCOL.Open().
> @param FileHandle On return, points to the created file handle or
> directory's handle
>
> @@ -734,7 +734,7 @@ EfiShellGetCurDir(
> directory is changed.
> @param Dir Points to the NULL-terminated directory on the
> device specified by FileSystem.
>
> - @retval EFI_SUCCESS The operation was sucessful
> + @retval EFI_SUCCESS The operation was successful
> **/
> EFI_STATUS
> EFIAPI
> @@ -818,7 +818,7 @@ EfiShellIsRootShell(
> If Alias is NULL, ReturnedData points to a ';'
> delimited list of alias (e.g.
> ReturnedData = "dir;del;copy;mfp") that is NULL-terminated.
> - @retval NULL an error ocurred
> + @retval NULL an error occurred
> @retval NULL Alias was not a valid Alias
> **/
> CONST CHAR16 *
> @@ -915,7 +915,7 @@ InternalEfiShellSetEnv(
> feature's enabled state was not known when the shell initially launched.
>
> @retval EFI_SUCCESS The feature is enabled.
> - @retval EFI_OUT_OF_RESOURCES There is not enough mnemory
> available.
> + @retval EFI_OUT_OF_RESOURCES There is not enough memory available.
> **/
> EFI_STATUS
> InernalEfiShellStartMonitor(
> diff --git a/ShellPkg/Application/Shell/ConsoleLogger.c
> b/ShellPkg/Application/Shell/ConsoleLogger.c
> index 6c4e26265407..36ba3ac2254c 100644
> --- a/ShellPkg/Application/Shell/ConsoleLogger.c
> +++ b/ShellPkg/Application/Shell/ConsoleLogger.c
> @@ -310,9 +310,9 @@ UpdateDisplayFromHistory(
> StringSegment = &Screen[Column];
>
> //
> - // Find the first char with a different arrribute and make that temporarily
> NULL
> + // Find the first char with a different attribute and make that
> + temporarily NULL
> // so we can do fewer printout statements. (later) restore that one and
> we will
> - // start at that collumn on the next loop.
> + // start at that column on the next loop.
> //
> StringSegmentEndChar = CHAR_NULL;
> for ( StringSegmentEnd = StringSegment @@ -395,7 +395,7 @@
> UpdateDisplayFromHistory( }
>
> /**
> - Reset the text output device hardware and optionaly run diagnostics
> + Reset the text output device hardware and optionally run diagnostics
>
> @param This pointer to EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL
> @param ExtendedVerification Indicates that a more extensive test may be
> performed @@ -723,7 +723,7 @@ ConsoleLoggerPrintWithPageBreak(
> ConsoleLoggerOutputStringSplit (LineStart, ConsoleInfo);
>
> //
> - // restore the temp NULL terminator to it's original character
> + // restore the temp NULL terminator to its original character
> //
> *((CHAR16*)(Walker+1)) = TempChar;
>
> @@ -770,7 +770,7 @@ ConsoleLoggerPrintWithPageBreak(
> ConsoleLoggerOutputStringSplit (LineStart, ConsoleInfo);
>
> //
> - // restore the temp NULL terminator to it's original character
> + // restore the temp NULL terminator to its original character
> //
> *((CHAR16*)(Walker+1)) = TempChar;
>
> @@ -1189,7 +1189,7 @@ ConsoleLoggerEnableCursor (
>
> @param[in] ConsoleInfo The pointer to the instance of the console logger
> information.
>
> - This will be used when a mode has changed or a reset ocurred to verify all
> + This will be used when a mode has changed or a reset occurred to
> + verify all
> history buffers.
> **/
> EFI_STATUS
> diff --git a/ShellPkg/Application/Shell/ConsoleWrappers.c
> b/ShellPkg/Application/Shell/ConsoleWrappers.c
> index b573b53cf4f3..ec340de4e128 100644
> --- a/ShellPkg/Application/Shell/ConsoleWrappers.c
> +++ b/ShellPkg/Application/Shell/ConsoleWrappers.c
> @@ -220,7 +220,7 @@ CloseSimpleTextInOnFile( }
>
> /**
> - Reset the text output device hardware and optionaly run diagnostics.
> + Reset the text output device hardware and optionally run diagnostics.
>
> @param This pointer to EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL
> @param ExtendedVerification Indicates that a more extensive test may be
> performed diff --git a/ShellPkg/Application/Shell/FileHandleWrappers.c
> b/ShellPkg/Application/Shell/FileHandleWrappers.c
> index 2d7bd7bec67e..a622a763f85e 100644
> --- a/ShellPkg/Application/Shell/FileHandleWrappers.c
> +++ b/ShellPkg/Application/Shell/FileHandleWrappers.c
> @@ -517,7 +517,7 @@ FileInterfaceStdInRead(
> gST->ConOut->QueryMode (gST->ConOut, gST->ConOut->Mode->Mode,
> &TotalColumn, &TotalRow);
>
> //
> - // Limit the line length to the buffer size or the minimun size of the
> + // Limit the line length to the buffer size or the minimum size of
> + the
> // screen. (The smaller takes effect)
> //
> MaxStr = TotalColumn * (TotalRow - 1) - StartColumn; @@ -865,7 +865,7
> @@ FileInterfaceStdInRead(
> //
> if (Key.UnicodeChar != CHAR_BACKSPACE && !(Key.UnicodeChar == 0 &&
> Key.ScanCode == SCAN_DELETE)) {
> //
> - // Calulate row and column of the tail of current string
> + // Calculate row and column of the tail of current string
> //
> TailRow = Row + (StringLen - StringCurPos + Column + OutputLength) /
> TotalColumn;
> TailColumn = (StringLen - StringCurPos + Column + OutputLength) %
> TotalColumn; @@ -932,7 +932,7 @@ FileInterfaceStdInRead( }
>
> //
> -// FILE sytle interfaces for StdIn/StdOut/StdErr
> +// FILE style interfaces for StdIn/StdOut/StdErr
> //
> EFI_FILE_PROTOCOL FileInterfaceStdIn = {
> EFI_FILE_REVISION,
> @@ -1069,7 +1069,7 @@ FileInterfaceEnvClose(
> ) {
> ((CHAR16*)NewBuffer)[TotalSize / sizeof (CHAR16) - 3] = CHAR_NULL;
> //
> - // If the NewBuffer end with \r\n\0, We will repace '\r' by '\0' and then
> update TotalSize.
> + // If the NewBuffer end with \r\n\0, We will replace '\r' by '\0' and then
> update TotalSize.
> //
> TotalSize -= sizeof(CHAR16) * 2;
> }
> diff --git a/ShellPkg/Application/Shell/Shell.c
> b/ShellPkg/Application/Shell/Shell.c
> index d16adae0ea30..a5563070972e 100644
> --- a/ShellPkg/Application/Shell/Shell.c
> +++ b/ShellPkg/Application/Shell/Shell.c
> @@ -1081,7 +1081,7 @@ ProcessCommandLine(
> }
> }
> //
> - // If an argumnent contains a space, then add double quotes before the
> argument
> + // If an argument contains a space, then add double quotes
> + before the argument
> //
> if (StrStr (gEfiShellParametersProtocol->Argv[LoopVar], L" ") != NULL) {
> StrnCatGrow(&ShellInfoObject.ShellInitSettings.FileOptions,
> @@ -1102,7 +1102,7 @@ ProcessCommandLine(
> return (EFI_OUT_OF_RESOURCES);
> }
> //
> - // If an argumnent contains a space, then add double quotes after the
> argument
> + // If an argument contains a space, then add double quotes
> + after the argument
> //
> if (StrStr (gEfiShellParametersProtocol->Argv[LoopVar], L" ") != NULL) {
> StrnCatGrow(&ShellInfoObject.ShellInitSettings.FileOptions,
> @@ -1176,7 +1176,7 @@ LocateStartupScript (
> }
>
> //
> - // Try to find 'Startup.nsh' in the execution path defined by the
> envrionment variable PATH.
> + // Try to find 'Startup.nsh' in the execution path defined by the
> environment variable PATH.
> //
> if ((StartupScriptPath == NULL) || EFI_ERROR (ShellIsFile
> (StartupScriptPath))) {
> SHELL_FREE_NON_NULL (StartupScriptPath); @@ -2251,7 +2251,7 @@
> SetLastError( }
>
> /**
> - Converts the command line to it's post-processed form. this replaces
> variables and alias' per UEFI Shell spec.
> + Converts the command line to its post-processed form. this replaces
> variables and alias' per UEFI Shell spec.
>
> @param[in,out] CmdLine pointer to the command line to update
>
> diff --git a/ShellPkg/Application/Shell/ShellEnvVar.c
> b/ShellPkg/Application/Shell/ShellEnvVar.c
> index dbeb8216986a..04fed3bf9141 100644
> --- a/ShellPkg/Application/Shell/ShellEnvVar.c
> +++ b/ShellPkg/Application/Shell/ShellEnvVar.c
> @@ -118,7 +118,7 @@ FreeEnvironmentVariableList(
> @param[in, out] ListHead The pointer to pointer to LIST ENTRY object for
> storing this list.
>
> - @retval EFI_SUCCESS the list was created sucessfully.
> + @retval EFI_SUCCESS the list was created successfully.
> **/
> EFI_STATUS
> GetEnvironmentVariableList(
> @@ -233,7 +233,7 @@ GetEnvironmentVariableList(
> @param[in] ListHead The pointer to LIST_ENTRY from
> GetShellEnvVarList().
>
> - @retval EFI_SUCCESS the list was Set sucessfully.
> + @retval EFI_SUCCESS the list was Set successfully.
> **/
> EFI_STATUS
> SetEnvironmentVariableList(
> @@ -266,7 +266,7 @@ SetEnvironmentVariableList(
> FreeEnvironmentVariableList(&VarList.Link);
>
> //
> - // set all the variables fron the list
> + // set all the variables from the list
> //
> for ( Node = (ENV_VAR_LIST*)GetFirstNode(ListHead)
> ; !IsNull(ListHead, &Node->Link)
> @@ -479,7 +479,7 @@ ShellAddEnvVarToList (
> }
>
> //
> - // If the environment varialbe key doesn't exist in list just insert
> + // If the environment variable key doesn't exist in list just insert
> // a new node.
> //
> LocalKey = AllocateCopyPool (StrSize(Key), Key); diff --git
> a/ShellPkg/Application/Shell/ShellManParser.c
> b/ShellPkg/Application/Shell/ShellManParser.c
> index 4d5a5668aa15..d5a85cb8cc3f 100644
> --- a/ShellPkg/Application/Shell/ShellManParser.c
> +++ b/ShellPkg/Application/Shell/ShellManParser.c
> @@ -179,12 +179,12 @@ SearchPathForFile( }
>
> /**
> - parses through the MAN file specified by SHELL_FILE_HANDLE and returns
> the
> - detailed help for any sub section specified in the comma seperated list of
> + Parses through the MAN file specified by SHELL_FILE_HANDLE and
> + returns the detailed help for any sub section specified in the comma
> + separated list of
> sections provided. If the end of the file or a .TH section is found then
> return.
>
> - Upon a sucessful return the caller is responsible to free the memory in
> *HelpText
> + Upon a successful return the caller is responsible to free the memory
> + in *HelpText
>
> @param[in] Handle FileHandle to read from
> @param[in] Sections name of command's sub sections to find
> @@ -193,8 +193,8 @@ SearchPathForFile(
> @param[in] Ascii TRUE if the file is ASCII, FALSE otherwise.
>
> @retval EFI_OUT_OF_RESOURCES a memory allocation failed.
> - @retval EFI_SUCCESS the section was found and its description sotred
> in
> - an alloceted buffer.
> + @retval EFI_SUCCESS the section was found and its description stored
> in
> + an allocated buffer.
> **/
> EFI_STATUS
> ManFileFindSections(
> @@ -296,11 +296,11 @@ ManFileFindSections(
> /**
> Parses a line from a MAN file to see if it is the Title Header. If it is, then
> if the "Brief Description" is desired, allocate a buffer for it and return a
> - copy. Upon a sucessful return the caller is responsible to free the memory
> in
> + copy. Upon a successful return the caller is responsible to free the
> + memory in
> *BriefDesc
>
> Uses a simple state machine that allows "unlimited" whitespace before and
> after the
> - ".TH", compares Command and the MAN file commnd name without
> respect to case, and
> + ".TH", compares Command and the MAN file command name without
> respect
> + to case, and
> allows "unlimited" whitespace and '0' and '1' characters before the Short
> Description.
> The PCRE regex describing this functionality is:
> ^\s*\.TH\s+(\S)\s[\s01]*(.*)$
> where group 1 is the Command Name and group 2 is the Short Description.
> @@ -421,11 +421,11 @@ IsTitleHeader(
> }
>
> /**
> - parses through the MAN file specified by SHELL_FILE_HANDLE and returns
> the
> + Parses through the MAN file specified by SHELL_FILE_HANDLE and
> + returns the
> "Brief Description" for the .TH section as specified by Command. If the
> command section is not found return EFI_NOT_FOUND.
>
> - Upon a sucessful return the caller is responsible to free the memory in
> *BriefDesc
> + Upon a successful return the caller is responsible to free the memory
> + in *BriefDesc
>
> @param[in] Handle FileHandle to read from
> @param[in] Command name of command's section to find as entered
> on the
> @@ -512,7 +512,7 @@ ManFileFindTitleSection(
> information will be returned. If Sections is NULL, then all help text
> information
> available will be returned.
>
> - if BriefDesc is NULL, then the breif description will not be savedd seperatly,
> + if BriefDesc is NULL, then the breif description will not be saved
> + separately,
> but placed first in the main HelpText.
>
> @param[in] ManFileName Points to the NULL-terminated UEFI Shell
> MAN file name.
> diff --git a/ShellPkg/Application/Shell/ShellParametersProtocol.c
> b/ShellPkg/Application/Shell/ShellParametersProtocol.c
> index bcd8f0ae2112..ef3966d3b08f 100644
> --- a/ShellPkg/Application/Shell/ShellParametersProtocol.c
> +++ b/ShellPkg/Application/Shell/ShellParametersProtocol.c
> @@ -69,13 +69,13 @@ FindEndOfParameter(
> This will also remove all remaining ^ characters after processing.
>
> @param[in, out] Walker pointer to string of command line. Adjusted
> to
> - reminaing command line on return
> + remaining command line on return
> @param[in, out] TempParameter pointer to string of command line item
> extracted.
> @param[in] Length buffer size of TempParameter.
> @param[in] StripQuotation if TRUE then strip the quotation marks
> surrounding
> the parameters.
>
> - @return EFI_INALID_PARAMETER A required parameter was NULL or
> pointed to a NULL or empty string.
> + @return EFI_INVALID_PARAMETER A required parameter was NULL or
> pointed to a NULL or empty string.
> @return EFI_NOT_FOUND A closing " could not be found on the
> specified string
> **/
> EFI_STATUS
> @@ -126,7 +126,7 @@ DEBUG_CODE_END();
> StrnCpyS(*TempParameter, Length / sizeof(CHAR16), (*Walker),
> NextDelim - *Walker);
>
> //
> - // Add a CHAR_NULL if we didnt get one via the copy
> + // Add a CHAR_NULL if we didn't get one via the copy
> //
> if (*NextDelim != CHAR_NULL) {
> (*TempParameter)[NextDelim - *Walker] = CHAR_NULL; @@ -184,7
> +184,7 @@ DEBUG_CODE_END();
> @param[in, out] Argv pointer to array of strings; one for each
> parameter
> @param[in, out] Argc pointer to number of strings in Argv array
>
> - @return EFI_SUCCESS the operation was sucessful
> + @return EFI_SUCCESS the operation was successful
> @return EFI_OUT_OF_RESOURCES a memory allocation failed.
> **/
> EFI_STATUS
> @@ -416,7 +416,7 @@ CreatePopulateInstallShellParametersProtocol ( }
>
> /**
> - frees all memory used by createion and installation of shell parameters
> protocol
> + frees all memory used by creation and installation of shell
> + parameters protocol
> and if there was an old version installed it will restore that one.
>
> @param NewShellParameters the interface of
> EFI_SHELL_PARAMETERS_PROTOCOL that is @@ -466,7 +466,7 @@
> CleanUpShellParametersProtocol ( }
>
> /**
> - Determin if a file name represents a unicode file.
> + Determine if a file name represents a unicode file.
>
> @param[in] FileName Pointer to the filename to open.
>
> @@ -526,7 +526,7 @@ StripQuotes (
> }
>
> /**
> - Calcualte the 32-bit CRC in a EFI table using the service provided by the
> + Calculate the 32-bit CRC in a EFI table using the service provided by
> + the
> gRuntime service.
>
> @param Hdr Pointer to an EFI standard header
> @@ -651,7 +651,7 @@ WriteFileTag (
>
>
> /**
> - Funcion will replace the current StdIn and StdOut in the ShellParameters
> protocol
> + Function will replace the current StdIn and StdOut in the
> + ShellParameters protocol
> structure by parsing NewCommandLine. The current values are returned to
> the
> user.
>
> @@ -664,7 +664,7 @@ WriteFileTag (
> @param[out] OldStdErr Pointer to old StdErr.
> @param[out] SystemTableInfo Pointer to old system table
> information.
>
> - @retval EFI_SUCCESS Operation was sucessful, Argv and Argc are
> valid.
> + @retval EFI_SUCCESS Operation was successful, Argv and Argc are
> valid.
> @retval EFI_OUT_OF_RESOURCES A memory allocation failed.
> **/
> EFI_STATUS
> @@ -1257,7 +1257,7 @@ UpdateStdInStdOutStdErr( }
>
> /**
> - Funcion will replace the current StdIn and StdOut in the ShellParameters
> protocol
> + Function will replace the current StdIn and StdOut in the
> + ShellParameters protocol
> structure with StdIn and StdOut. The current values are de-allocated.
>
> @param[in, out] ShellParameters Pointer to parameter structure to
> modify.
> @@ -1327,7 +1327,7 @@ RestoreStdInStdOutStdErr (
> return (EFI_SUCCESS);
> }
> /**
> - Funcion will replace the current Argc and Argv in the ShellParameters
> protocol
> + Function will replace the current Argc and Argv in the
> + ShellParameters protocol
> structure by parsing NewCommandLine. The current values are returned to
> the
> user.
>
> @@ -1339,7 +1339,7 @@ RestoreStdInStdOutStdErr (
> @param[out] OldArgv Pointer to old list of parameters.
> @param[out] OldArgc Pointer to old number of items in Argv list.
>
> - @retval EFI_SUCCESS Operation was sucessful, Argv and Argc are
> valid.
> + @retval EFI_SUCCESS Operation was successful, Argv and Argc are
> valid.
> @retval EFI_OUT_OF_RESOURCES A memory allocation failed.
> **/
> EFI_STATUS
> @@ -1375,7 +1375,7 @@ UpdateArgcArgv(
> }
>
> /**
> - Funcion will replace the current Argc and Argv in the ShellParameters
> protocol
> + Function will replace the current Argc and Argv in the
> + ShellParameters protocol
> structure with Argv and Argc. The current values are de-allocated and the
> OldArgv must not be deallocated by the caller.
>
> diff --git a/ShellPkg/Application/Shell/ShellProtocol.c
> b/ShellPkg/Application/Shell/ShellProtocol.c
> index 5e529b6568a9..9a25e703f628 100644
> --- a/ShellPkg/Application/Shell/ShellProtocol.c
> +++ b/ShellPkg/Application/Shell/ShellProtocol.c
> @@ -96,7 +96,7 @@ InternalShellProtocolIsSimpleFileSystemPresent(
> /**
> This function creates a mapping for a device path.
>
> - If both DeviecPath and Mapping are NULL, this will reset the mapping to
> default values.
> + If both DevicePath and Mapping are NULL, this will reset the mapping to
> default values.
>
> @param DevicePath Points to the device path. If this is NULL and
> Mapping points to a valid mapping,
> then the mapping will be deleted.
> @@ -152,7 +152,7 @@ EfiShellSetMap(
> } // for loop
>
> //
> - // We didnt find one to delete
> + // We didn't find one to delete
> //
> return (EFI_NOT_FOUND);
> }
> @@ -232,7 +232,7 @@ EfiShellGetDevicePathFromMap(
> device path. If there is an exact match, the mapping is returned and
> *DevicePath
> points to the end-of-device-path node.
>
> - If there are multiple map names they will be semi-colon seperated in the
> + If there are multiple map names they will be semi-colon separated in
> + the
> NULL-terminated string.
>
> @param DevicePath On entry, points to a device path pointer. On
> @@ -910,8 +910,8 @@ EfiShellBatchIsActive (
> @param Attributes the File Attributes to use when creating a new
> file.
>
> @retval EFI_SUCCESS the file is open and FileHandle is valid
> - @retval EFI_UNSUPPORTED the device path cotained non-path
> elements
> - @retval other an error ocurred.
> + @retval EFI_UNSUPPORTED the device path contained non-path
> elements
> + @retval other an error occurred.
> **/
> EFI_STATUS
> InternalOpenFileDevicePath(
> @@ -946,7 +946,7 @@ InternalOpenFileDevicePath(
> Handle1 = ConvertShellHandleToEfiFileProtocol(ShellHandle);
> if (Handle1 != NULL) {
> //
> - // chop off the begining part before the file system part...
> + // chop off the beginning part before the file system part...
> //
> ///@todo BlockIo?
> Status = gBS->LocateDevicePath(&gEfiSimpleFileSystemProtocolGuid,
> @@ -1064,14 +1064,14 @@ InternalOpenFileDevicePath(
> already exists and is non-volatile then EFI_INVALID_PARAMETER is
> returned.
>
> @param FileName Pointer to NULL-terminated file path
> - @param FileAttribs The new file's attrbiutes. the different attributes
> are
> + @param FileAttribs The new file's attributes. the different attributes
> are
> described in EFI_FILE_PROTOCOL.Open().
> @param FileHandle On return, points to the created file handle or
> directory's handle
>
> @retval EFI_SUCCESS The file was opened. FileHandle points to the new
> file's handle.
> @retval EFI_INVALID_PARAMETER One of the parameters has an invalid
> value.
> @retval EFI_UNSUPPORTED could not open the file path
> - @retval EFI_NOT_FOUND the specified file could not be found on the
> devide, or could not
> + @retval EFI_NOT_FOUND the specified file could not be found on the
> device, or could not
> file the file system on the device.
> @retval EFI_NO_MEDIA the device has no medium.
> @retval EFI_MEDIA_CHANGED The device has a different medium in it or
> the medium is no @@ -1905,7 +1905,7 @@ typedef struct {
> @param[in] Node The node to copy from.
> @param[in] Save TRUE to set Node->Handle to NULL, FALSE otherwise.
>
> - @retval NULL a memory allocation error ocurred
> + @retval NULL a memory allocation error occurred
> @return != NULL a pointer to the new node
> **/
> EFI_SHELL_FILE_INFO*
> @@ -1957,7 +1957,7 @@ InternalDuplicateShellFileInfo(
> @param[in] Handle Handle member initial value.
> @param[in] Info Info struct to copy.
>
> - @retval NULL An error ocurred.
> + @retval NULL An error occurred.
> @return a pointer to the newly allocated structure.
> **/
> EFI_SHELL_FILE_INFO *
> @@ -2117,7 +2117,7 @@ EfiShellFindFilesInDir(
> //
> ShellFileListItem = CreateAndPopulateShellFileInfo(
> BasePath,
> - EFI_SUCCESS, // success since we didnt fail to open it...
> + EFI_SUCCESS, // success since we didn't fail to open it...
> FileInfo->FileName,
> NULL, // no handle since not open
> FileInfo);
> @@ -2703,7 +2703,7 @@ EfiShellGetEnvEx(
> Status =
> SHELL_GET_ENVIRONMENT_VARIABLE_AND_ATTRIBUTES(Name,
> Attributes, &Size, Buffer);
> }
> //
> - // we didnt get it (might not exist)
> + // we didn't get it (might not exist)
> // free the memory if we allocated any and return NULL
> //
> if (EFI_ERROR(Status)) {
> @@ -2924,7 +2924,7 @@ EfiShellGetCurDir(
> directory is changed.
> @param Dir Points to the NULL-terminated directory on the
> device specified by FileSystem.
>
> - @retval EFI_SUCCESS The operation was sucessful
> + @retval EFI_SUCCESS The operation was successful
> @retval EFI_NOT_FOUND The file system could not be found
> **/
> EFI_STATUS
> @@ -3176,12 +3176,12 @@ EfiShellIsRootShell( }
>
> /**
> - function to return a semi-colon delimeted list of all alias' in the current shell
> + function to return a semi-colon delimited list of all alias' in the
> + current shell
>
> up to caller to free the memory.
>
> @retval NULL No alias' were found
> - @retval NULL An error ocurred getting alias'
> + @retval NULL An error occurred getting alias'
> @return !NULL a list of all alias'
> **/
> CHAR16 *
> @@ -3284,7 +3284,7 @@ ToLower (
> If Alias is NULL, ReturnedData points to a ';'
> delimited list of alias (e.g.
> ReturnedData = "dir;del;copy;mfp") that is NULL-terminated.
> - @retval NULL an error ocurred
> + @retval NULL an error occurred
> @retval NULL Alias was not a valid Alias
> **/
> CONST CHAR16 *
> @@ -3609,7 +3609,7 @@ CreatePopulateInstallShellProtocol (
> (VOID*)(&mShellProtocol));
> if (!EFI_ERROR(Status)) {
> //
> - // we reinstalled sucessfully. log this so we can reverse it later.
> + // we reinstalled successfully. log this so we can reverse it later.
> //
>
> //
> @@ -3756,7 +3756,7 @@ NotificationFunction(
> feature's enabled state was not known when the shell initially launched.
>
> @retval EFI_SUCCESS The feature is enabled.
> - @retval EFI_OUT_OF_RESOURCES There is not enough mnemory
> available.
> + @retval EFI_OUT_OF_RESOURCES There is not enough memory available.
> **/
> EFI_STATUS
> InernalEfiShellStartMonitor(
> diff --git a/ShellPkg/Application/ShellCTestApp/README.txt
> b/ShellPkg/Application/ShellCTestApp/README.txt
> index 02594e0d1208..d788d3ef62a9 100644
> --- a/ShellPkg/Application/ShellCTestApp/README.txt
> +++ b/ShellPkg/Application/ShellCTestApp/README.txt
> @@ -1,5 +1,5 @@
> TestArgv.nsh is a very simple shell script to test how the interpreter parses
> the parameters. It uses ShellCTestApp.efi to dump the parameters passed
> from the -intepreter.
> +interpreter.
>
> TestArgv.log is the desired output created using "TestArgv.nsh >
> TestArgv.log".
> --
> 2.21.0
^ permalink raw reply [flat|nested] 122+ messages in thread