From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web09.8422.1578493594774454171 for ; Wed, 08 Jan 2020 06:26:34 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KLoEw4U8; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578493593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BG6xRgdzox0huKofKq39PpEZ7LXDoYuJPTjyZmv5Zfw=; b=KLoEw4U87Hv2FdRdkmQnV6L1QRbHAbzdRrBSnuYv88RIPiUm3TDmJoSg0JdhY8fSoQLujj lxgNdranBvYm05iF/gprMFT0YWfinxMQgHZbLll4RgKucZroq3twNlD/tFMqwEB4Pt3RI1 2my0DhDCEzZBFr1EEmJ0G6FYU3TXNHo= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-377-1u7JZPy1O6emHpkgL8wFXw-1; Wed, 08 Jan 2020 09:26:32 -0500 Received: by mail-wr1-f71.google.com with SMTP id r2so1504452wrp.7 for ; Wed, 08 Jan 2020 06:26:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BG6xRgdzox0huKofKq39PpEZ7LXDoYuJPTjyZmv5Zfw=; b=A3B1L+ba/62luD2JR1n/Jg+0ygMo4Xa79rtHCVdBgDQpJPCxq1+1E+cbHEr/cLC/Q8 MlLnLvNGbGWn+D5WRHEqmpRf0AkXjrESu/cl18nnSOtozHoGR9q+gyvnRmoTeF9o6UDp S/QqASdlNxoFuMgIVcpI9un087awvn/+L5vWFSN5pl+9dPFgOCVVwcgjnxxNOOMWSp3D gBLyT4uhVLJSylwCEPhUH0WUm0kCr+GalhAcjOP33ilrx0Yrow4J3S+76QkK+yKY+Xaq WNmGeRqofhBOLQ0GtOJk7yPH802rDDMIstYi5BA0C91tZeQFCPl5v0yJl5YGCVW5Iv30 cnSA== X-Gm-Message-State: APjAAAXt6DoREBdoNuXTDjjK8ffy/KWkonzHZwtErLAmJOSAPmC3ClbU BmKCRgDtwQwFmgGdx9g3/Lt3QAtU8sliFNR1o3pE6KKm9r4wuvQ4Keov6qbc+wfOp2ZLY+z9Xxg 6mOKuqgl5jxVwqg== X-Received: by 2002:a05:600c:2301:: with SMTP id 1mr4435897wmo.147.1578493591310; Wed, 08 Jan 2020 06:26:31 -0800 (PST) X-Google-Smtp-Source: APXvYqxNi+TF9Zn2Q6/StYGFN1GGuomcnhsXzz77ZSobbQLWbbEkyp7ahtVQWdYox7Dq2t5t2E2w8w== X-Received: by 2002:a05:600c:2301:: with SMTP id 1mr4435863wmo.147.1578493591027; Wed, 08 Jan 2020 06:26:31 -0800 (PST) Return-Path: Received: from [192.168.1.35] (34.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.34]) by smtp.gmail.com with ESMTPSA id r5sm4361292wrt.43.2020.01.08.06.26.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2020 06:26:30 -0800 (PST) Subject: Re: [PATCH v2 03/78] EmbeddedPkg/VirtualKeyboard: Fix few typos To: Ard Biesheuvel Cc: edk2-devel-groups-io , Antoine Coeur , Leif Lindholm References: <20200103090812.10592-1-philmd@redhat.com> <20200103090812.10592-4-philmd@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <2b0fab2d-20b9-0789-06fc-167944756a00@redhat.com> Date: Wed, 8 Jan 2020 15:26:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: X-MC-Unique: 1u7JZPy1O6emHpkgL8wFXw-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 1/8/20 1:42 PM, Ard Biesheuvel wrote: > On Fri, 3 Jan 2020 at 10:08, Philippe Mathieu-Daude wrote: >> >> From: Antoine Coeur >> >> Fix few typos in the documentation. >> >> Cc: Leif Lindholm >> Cc: Ard Biesheuvel >> Signed-off-by: Antoine Coeur >> Reviewed-by: Philippe Mathieu-Daude >> Signed-off-by: Philippe Mathieu-Daude > > Reviewed-by: Ard Biesheuvel > > Nit below > >> --- >> .../Drivers/VirtualKeyboardDxe/VirtualKeyboard.h | 14 +++++++------- >> .../Drivers/VirtualKeyboardDxe/VirtualKeyboard.c | 16 ++++++++-------- >> 2 files changed, 15 insertions(+), 15 deletions(-) >> >> diff --git a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h >> index 29bc7a06fb16..026449046653 100644 >> --- a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h >> +++ b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h >> @@ -323,7 +323,7 @@ VirtualKeyboardReset ( >> ); >> >> /** >> - Reset the input device and optionaly run diagnostics >> + Reset the input device and optionally run diagnostics >> >> @param This Protocol instance pointer. >> @param ExtendedVerification Driver may perform diagnostics on reset. >> @@ -373,7 +373,7 @@ VirtualKeyboardSetState ( >> >> >> @retval EFI_SUCCESS The notification function was registered successfully. >> - @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necesssary data structures. >> + @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necessary data structures. >> @retval EFI_INVALID_PARAMETER KeyData or NotifyHandle is NULL. >> >> **/ >> @@ -429,7 +429,7 @@ VirtualKeyboardFreeNotifyList ( >> state data for the key that was pressed. >> >> @retval TRUE Key be pressed matches a registered key. >> - @retval FLASE Match failed. >> + @retval FALSE Match failed. >> >> **/ >> BOOLEAN >> @@ -441,7 +441,7 @@ IsKeyRegistered ( >> /** >> Waiting on the keyboard event, if there's any key pressed by the user, signal the event >> >> - @param Event The event that be siganlled when any key has been stroked. >> + @param Event The event that be signalled when any key has been stroked. > > stroked -> struck? Nice, I fixed this and other occurrence below, thanks! > >> @param Context Pointer of the protocol EFI_SIMPLE_TEXT_INPUT_PROTOCOL. >> >> **/ >> @@ -455,7 +455,7 @@ VirtualKeyboardWaitForKey ( >> /** >> Waiting on the keyboard event, if there's any key pressed by the user, signal the event >> >> - @param Event The event that be siganlled when any key has been stroked. >> + @param Event The event that be signalled when any key has been stroked. >> @param Context Pointer of the protocol EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL. >> >> **/ >> @@ -514,14 +514,14 @@ VirtualKeyboardReadKeyStroke ( >> >> /** >> Reads the next keystroke from the input device. The WaitForKey Event can >> - be used to test for existance of a keystroke via WaitForEvent () call. >> + be used to test for existence of a keystroke via WaitForEvent () call. >> >> @param This Protocol instance pointer. >> @param KeyData A pointer to a buffer that is filled in with the keystroke >> state data for the key that was pressed. >> >> @retval EFI_SUCCESS The keystroke information was returned. >> - @retval EFI_NOT_READY There was no keystroke data availiable. >> + @retval EFI_NOT_READY There was no keystroke data available. >> @retval EFI_DEVICE_ERROR The keystroke information was not returned due to >> hardware errors. >> @retval EFI_INVALID_PARAMETER KeyData is NULL. >> diff --git a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c >> index 750371a06723..e9d0b72ee6c3 100644 >> --- a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c >> +++ b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c >> @@ -437,7 +437,7 @@ VirtualKeyboardFreeNotifyList ( >> pressed. >> >> @retval TRUE Key be pressed matches a registered key. >> - @retval FLASE Match failed. >> + @retval FALSE Match failed. >> >> **/ >> BOOLEAN >> @@ -476,7 +476,7 @@ IsKeyRegistered ( >> Signal the event if there is key available >> >> @param Event the event object >> - @param Context waitting context >> + @param Context waiting context >> >> **/ >> VOID >> @@ -580,7 +580,7 @@ VirtualKeyboardReset ( >> } >> >> /** >> - Reset the input device and optionaly run diagnostics >> + Reset the input device and optionally run diagnostics >> >> @param This Protocol instance pointer. >> @param ExtendedVerification Driver may perform diagnostics on reset. >> @@ -621,7 +621,7 @@ VirtualKeyboardResetEx ( >> >> /** >> Reads the next keystroke from the input device. The WaitForKey Event can >> - be used to test for existance of a keystroke via WaitForEvent () call. >> + be used to test for existence of a keystroke via WaitForEvent () call. >> >> @param VirtualKeyboardPrivate Virtualkeyboard driver private structure. >> @param KeyData A pointer to a buffer that is filled in >> @@ -629,7 +629,7 @@ VirtualKeyboardResetEx ( >> that was pressed. >> >> @retval EFI_SUCCESS The keystroke information was returned. >> - @retval EFI_NOT_READY There was no keystroke data availiable. >> + @retval EFI_NOT_READY There was no keystroke data available. >> @retval EFI_DEVICE_ERROR The keystroke information was not returned >> due to hardware errors. >> @retval EFI_INVALID_PARAMETER KeyData is NULL. >> @@ -731,14 +731,14 @@ VirtualKeyboardReadKeyStroke ( >> >> /** >> Reads the next keystroke from the input device. The WaitForKey Event can >> - be used to test for existance of a keystroke via WaitForEvent () call. >> + be used to test for existence of a keystroke via WaitForEvent () call. >> >> @param This Protocol instance pointer. >> @param KeyData A pointer to a buffer that is filled in with the >> keystroke state data for the key that was pressed. >> >> @retval EFI_SUCCESS The keystroke information was returned. >> - @retval EFI_NOT_READY There was no keystroke data availiable. >> + @retval EFI_NOT_READY There was no keystroke data available. >> @retval EFI_DEVICE_ERROR The keystroke information was not returned >> due to hardware errors. >> @retval EFI_INVALID_PARAMETER KeyData is NULL. >> @@ -808,7 +808,7 @@ VirtualKeyboardSetState ( >> >> @retval EFI_SUCCESS The notification function was registered >> successfully. >> - @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necesssary >> + @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necessary >> data structures. >> @retval EFI_INVALID_PARAMETER KeyData or NotifyHandle is NULL. >> >> -- >> 2.21.0 >> >