From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9F7B1D8062F for ; Tue, 24 Oct 2023 20:35:35 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZlXIBhxOhZfbfJ1zwxbY2pD1RrzHfBOE31EP/MJR2aQ=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698179734; v=1; b=pLLojM/uHIq8WWrO5Iqk2g0SpamT15beXnsy+rOD2d/th9jEgtFLOUdX8YtU/CcUq0JLV5GW 54f0toAXXzPaIQDXvgOyhpBFS54slSpmSd5nSQYOJwUoRJeK41gew0NULzwD329DphGm3qQFz7J DHTSlimFdLIiSH8eyUbjlHHA= X-Received: by 127.0.0.2 with SMTP id XFB9YY7687511xBkczUh4MCs; Tue, 24 Oct 2023 13:35:34 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.158464.1698179733654707800 for ; Tue, 24 Oct 2023 13:35:33 -0700 X-Received: from [10.137.195.59] (unknown [131.107.1.251]) by linux.microsoft.com (Postfix) with ESMTPSA id 2E64020B74C0; Tue, 24 Oct 2023 13:35:33 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2E64020B74C0 Message-ID: <2b422d69-f37a-410b-abfa-2766db1a74c6@linux.microsoft.com> Date: Tue, 24 Oct 2023 13:34:59 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update From: "VivianNK" To: devel@edk2.groups.io, michael.d.kinney@intel.com References: <20230816211523.12-1-vnowkakeane@linux.microsoft.com> In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,vnowkakeane@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: pLsB1RVbmjbddiYyCqf0yaeux7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="pLLojM/u"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none) Hi, following up to see if there's any update on this. Thanks for your help, - Vivian On 9/27/2023 12:43 PM, Vivian Nowka-Keane wrote: > Hi Mike, > > Can you help merge this? Looks like it has all of the reviews. > > Thank you! > - Vivian > > On 9/12/2023 7:42 AM, Michael D Kinney wrote: >> Series Reviewed-by: Michael D Kinney >> >>> -----Original Message----- >>> From:devel@edk2.groups.io=C2=A0 =C2=A0 On Behalf = Of=20 >>> VivianNK >>> Sent: Wednesday, August 16, 2023 2:15 PM >>> To:devel@edk2.groups.io >>> Subject: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update >>> >>> v1 -> v2: >>> =C2=A0 - Update commit message to explain the audit only mode change is >>> =C2=A0=C2=A0=C2=A0 temporary to prevent intermediate CI failures. >>> =C2=A0 - Format patch Cc's correctly >>> >>> v1 archive:https://edk2.groups.io/g/devel/message/107665 >>> >>> VivianNK (7): >>> =C2=A0=C2=A0 .pytool: Set uncrustify check to audit only (temporary) >>> =C2=A0=C2=A0 .pytool: Add cpp support to uncrustify plugin >>> =C2=A0=C2=A0 MdeModulePkg: Apply uncrustify formatting to relevant file= s. >>> =C2=A0=C2=A0 MdePkg: Apply uncrustify formatting to relevant files >>> =C2=A0=C2=A0 SecurityPkg: Apply uncrustify formatting to relevant files >>> =C2=A0=C2=A0 UnitTestFrameworkPkg: Apply uncrustify formatting to relev= ant files >>> =C2=A0=C2=A0 .pytool: Undo uncrustify check change >>> >>> =C2=A0 .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py >>> |=C2=A0=C2=A0 2 +- >>> =C2=A0 .pytool/Plugin/UncrustifyCheck/uncrustify.cfg >>> |=C2=A0=C2=A0 4 +- >>> MdeModulePkg/Library/UefiSortLib/GoogleTest/UefiSortLibGoogleTest.cpp >>> |=C2=A0 37 +- >>> MdeModulePkg/Test/Mock/Include/GoogleTest/Library/MockPciHostBridgeLib.= h=20 >>> >>> |=C2=A0=C2=A0 4 +- >>> >>> MdeModulePkg/Test/Mock/Library/GoogleTest/MockPciHostBridgeLib/MockPciH= ostBri=20 >>> >>> dgeLib.cpp=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 8 +- >>> >>> MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTe= sts32.=20 >>> >>> cpp=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | = 114 ++-- >>> >>> MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTe= sts64.=20 >>> >>> cpp=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | = 114 ++-- >>> MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/TestBaseSafeIntLib.cpp >>> | 563 ++++++++++---------- >>> =C2=A0 MdePkg/Test/Mock/Include/GoogleTest/Library/MockHobLib.h >>> |=C2=A0=C2=A0 6 +- >>> MdePkg/Test/Mock/Include/GoogleTest/Library/MockPeiServicesLib.h >>> |=C2=A0=C2=A0 6 +- >>> =C2=A0 MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiLib.h >>> |=C2=A0=C2=A0 4 +- >>> >>> MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiRuntimeServicesTabl= eLib.h=20 >>> >>> |=C2=A0=C2=A0 4 +- >>> MdePkg/Test/Mock/Library/GoogleTest/MockHobLib/MockHobLib.cpp >>> |=C2=A0 40 +- >>> >>> MdePkg/Test/Mock/Library/GoogleTest/MockPeiServicesLib/MockPeiServicesL= ib.cpp=20 >>> >>> |=C2=A0 52 +- >>> MdePkg/Test/Mock/Library/GoogleTest/MockUefiLib/MockUefiLib.cpp >>> |=C2=A0=C2=A0 6 +- >>> >>> MdePkg/Test/Mock/Library/GoogleTest/MockUefiRuntimeServicesTableLib/Moc= kUefiR=20 >>> >>> untimeServicesTableLib.cpp |=C2=A0 12 +- >>> >>> SecurityPkg/Library/SecureBootVariableLib/GoogleTest/SecureBootVariable= LibGoo=20 >>> >>> gleTest.cpp=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 205 ++++--- >>> >>> SecurityPkg/Test/Mock/Include/GoogleTest/Library/MockPlatformPKProtecti= onLib.=20 >>> >>> h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 |=C2=A0=C2=A0 4 +- >>> >>> SecurityPkg/Test/Mock/Library/GoogleTest/MockPlatformPKProtectionLib/Mo= ckPlat=20 >>> >>> formPKProtectionLib.cpp=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 4 +- >>> =C2=A0 UnitTestFrameworkPkg/Include/Library/GoogleTestLib.h >>> |=C2=A0=C2=A0 2 +- >>> >>> UnitTestFrameworkPkg/Test/GoogleTest/Sample/SampleGoogleTest/SampleGoog= leTest=20 >>> >>> .cpp=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 = 76 +-- >>> =C2=A0 21 files changed, 664 insertions(+), 603 deletions(-) >>> >>> --=20 >>> 2.41.0.windows.3 >>> >>> >>> >>> -=3D-=3D-=3D-=3D-=3D-=3D >>> Groups.io Links: You receive all messages sent to this group. >>> View/Reply Online=20 >>> (#107809):https://edk2.groups.io/g/devel/message/107809 >>> Mute This Topic:https://groups.io/mt/100788665/1643496 >>> Group Owner:devel+owner@edk2.groups.io >>> Unsubscribe:https://edk2.groups.io/g/devel/unsub >>> [michael.d.kinney@intel.com] >>> -=3D-=3D-=3D-=3D-=3D-=3D >>> >>=20 >> -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110011): https://edk2.groups.io/g/devel/message/110011 Mute This Topic: https://groups.io/mt/100788665/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-