From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.60]) by mx.groups.io with SMTP id smtpd.web10.8207.1639758640253068923 for ; Fri, 17 Dec 2021 08:30:41 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=hfTZkOgh; spf=pass (domain: arm.com, ip: 40.107.6.60, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8ZSbjv0bIRXuKJcFheVc/fY/yXMZZP6XrweikIYAUQ8=; b=hfTZkOghXBWraTwvYVIbyBhqy/cIu5gGjdWoBiaBYIRO797aaIf3j+oR0a6p6OHRFqtAtjAGaVqYc6T8oGXvuUnufQnLrVa3h3jc+ElK+OlsN9jI1flbBKOCuJ4SObP66+5Pul7VSxUsGqFNiSNTjkxV9lD9BKVmrnhWI9fMwVg= Received: from AM5PR0601CA0064.eurprd06.prod.outlook.com (2603:10a6:206::29) by AM4PR0802MB2372.eurprd08.prod.outlook.com (2603:10a6:200:60::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Fri, 17 Dec 2021 16:30:36 +0000 Received: from VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:0:cafe::72) by AM5PR0601CA0064.outlook.office365.com (2603:10a6:206::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend Transport; Fri, 17 Dec 2021 16:30:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT054.mail.protection.outlook.com (10.152.19.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend Transport; Fri, 17 Dec 2021 16:30:36 +0000 Received: ("Tessian outbound dbb52aec1fa6:v110"); Fri, 17 Dec 2021 16:30:35 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: efe2c104acbd3def X-CR-MTA-TID: 64aa7808 Received: from b7bab752070d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 51F86E11-2FA4-42A2-85AB-7BA96B0D034B.1; Fri, 17 Dec 2021 16:30:23 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b7bab752070d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 17 Dec 2021 16:30:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=THoajTDYHGWMgRzkb7ZH+9l2x5gCZzWV51Wv8m8fu2fFoWjHD7XvxsnAdc3Rc9RybZKCmHLxVt1WefatNeVyLLhfjhgPiOgLZEp9yEA8Rsgwhcv+00Whg09cUCXDW0eEgTIQTaNATMfoWeBuq4FDbLYTB4qaP5ckvVKBdX8krPH2KPMtNPfmKrVh54CdPABmBdKCp8E4YLRtjX4foR9FuqGwPam1EiroSsz0ywMD4FA6liBXpUJopV8Lm4tkbARhiAtsIDmJldeTyYpLxGRAPe+7WS7c5R9iOrVYjzZv1f/EHeCafktX+qirJD3Y4Y1X4fEZofZT0M9caU+LkJNz0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8ZSbjv0bIRXuKJcFheVc/fY/yXMZZP6XrweikIYAUQ8=; b=ZJ2tt+oS0fu9cg5qiVxu1PFcqF0PEPPYJojaTvtQMA1bxuKQKcDv3gYR2EZ56h37NnTW1GbPSMNTTcEUePgw6lh3Rb6J7kBL2tFNOs27b3vx8FEfP5EYPhWVAhAGAdAco5zCFe6QNis72WzJQhUhIBpY6TSzfdB6a3keFGAwinqQwtbnL8D/HgAX1ZIyemcef5E50ic4RRBp5dOUv2OePO5C17kFOkJEQDO8fzOWe6zBDpnm1U6xcH54XpTHRQE2p9EuCTBrFRLSw65OVCqikg9klrHHKVOEL8gKZtS4qHcPwTntatWC1+twOJAvkkoE6yWGjZUyiGlwxt7yZ4qYQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8ZSbjv0bIRXuKJcFheVc/fY/yXMZZP6XrweikIYAUQ8=; b=hfTZkOghXBWraTwvYVIbyBhqy/cIu5gGjdWoBiaBYIRO797aaIf3j+oR0a6p6OHRFqtAtjAGaVqYc6T8oGXvuUnufQnLrVa3h3jc+ElK+OlsN9jI1flbBKOCuJ4SObP66+5Pul7VSxUsGqFNiSNTjkxV9lD9BKVmrnhWI9fMwVg= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB3032.eurprd08.prod.outlook.com (2603:10a6:209:43::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Fri, 17 Dec 2021 16:30:21 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac%6]) with mapi id 15.20.4755.021; Fri, 17 Dec 2021 16:30:21 +0000 Subject: Re: [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec To: Pierre Gondois , devel@edk2.groups.io, nd , Leif Lindholm , Ard Biesheuvel , xiewenyi2@huawei.com References: <20211124162330.236813-1-Pierre.Gondois@arm.com> <20211124162330.236813-4-Pierre.Gondois@arm.com> <1d258442-24c4-c155-36f9-f8f42edbefa0@arm.com> From: "Sami Mujawar" Message-ID: <2b637dc0-b36e-abf7-c514-c0bf568ce735@arm.com> Date: Fri, 17 Dec 2021 16:30:26 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: X-ClientProxiedBy: LO4P123CA0221.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::10) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.50) by LO4P123CA0221.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::10) with Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport; Fri, 17 Dec 2021 16:30:20 +0000 X-MS-Office365-Filtering-Correlation-Id: 2bafd7af-3c79-4e1f-ff33-08d9c17a8df9 X-MS-TrafficTypeDiagnostic: AM6PR08MB3032:EE_|VE1EUR03FT054:EE_|AM4PR0802MB2372:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: d1kS8HWmfeTp6OsJOPU5wzuQ+cmN/qD0rYZw1hDKGkT58wiZFqLiZ5fdDzJXbBGyGp2NkP4/eeIpHhJM5sqhcGWp7IDPZCQuMTDdLcAfMapGMTx/PjCi+vZhixFrkTxwkDrSeSAXO8h0nNpphUC1M9RlZwU0/N72rQzC1Nf5vUwvqqKzhCi1y7C5GXBXc2XNOq7Mc5Pf9dMmHx0wZ7ma1hWqdP7beVdnPOxMu2dtXo5Ar+Ia0zmVOrZkxK40VbzQrmxWyGJ7QL1OEPl95us4nuTvXnBxhf97l7ZLPX3BpsrbG/ApPiNHSzdj/urYl/FYPKlDWrIzstOuaE9V3P891vs2ZAzIm95tI5xNPknN8SjeEh+FOOgm5uE3HPrrglg1R31zHYoqk1sxQaHkNtnqL2pt3sm5L0Nrx8uH7Tfz3Ao8F/+I4bq7vScvr8X2azKNPIYeVkYIfGxDPBlb1KXnFJYYXIIGuaHgfROx6fLwNSTjsLqMjalmkr6771mVvSZa/TBG7LGsKTxGNwIuy3L1uk4lEulMGqfNlQ6x3SvNzt6A6efs9YiVND4zhTcTtIBw06YCc2TfLdUSwj6lCmdHs7P85dsvRFRjxIIKGfApbQzASzDzZY9QYc/4/bibh00+VSwMqmds6Ft8KTyw074jVYi4wBq4Tci+gysG3nYpqnCN/TAtaDWiCcYtBTT0e3Pj0JKBEPei3rD9JGMBJgvMOxC1IJRXeT2UhI5vXEm0xloCTZ3PFqjHxL9Io/HtZzJUHf7yg3sDuvA/w/tBcOS4dwZPURlos0Pcb3Cw+cRMJ9E= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(36756003)(66476007)(5660300002)(66556008)(38350700002)(52116002)(508600001)(38100700002)(31696002)(16576012)(66946007)(26005)(316002)(2906002)(186003)(6486002)(2616005)(44832011)(956004)(83380400001)(8936002)(110136005)(31686004)(8676002)(53546011)(86362001)(145603002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3032 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 62f1c565-f31a-45c6-709a-08d9c17a84fd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g5lLl8ecZFi39bZI0QGB0SerCcpCDTD+IQON5ICNmLtUhEwLBoIayJNOQzswcUAINni7fbn2C/hlL8MNFfmR/o6AcbJiiLaCeEKRYx9eriDjiLw0AWxuE8FKoQiFWByw/fq5S/vfZlxcelwds7LlEg2sKK0R+mBNIFkEf/iOQv5/MK+loGaFAYEp/Y7j+BSqm/sBADN21QkzOk+I9HLpKBI+c2XDuCZvzZ5RB6jxIYWG1PpMbWhgZSLqaloyTXvGRdxzYZ495BNWImWim3Nvwm4PAo0GwmWoTUNuIKO5+GCcMA739Tf8D8MX9oKGjodbhkqshW83c1b4B6Vvvh9tnh0AW01fm7f63sg79NgLZItFIdMG5Hlwn/Mcdnj8puI10KDGlEJWu5DuPNi6LrWbkLBqTvkEpfBd8BDA42FG82AFLuyhzfZGX/BpSwt2j6rmNAILPXM+5IZoyPJ5o+HapJHF8WKfRImM8KH7hg/AfkKZPqu+mJJMbya/85pVSJSEL6YBU/PYwlnQHxVQaJFIkN+BE0zzRfc0TGXHcfq36lOXySj+722YbXsgbkazNytc/pJhoKekLXybPLmxvzTLRQ04ryJeVnAl3GEEtsVcknivGVP55jEspMFxjfjo8ykUifU0bA722Le94BT/cV3eOghdf4zdN1E5pey6gzDUTAeIQ0I2iV9h6vcxjXN1dqj/HJWUNQprNvMeJYIhVhgcZ39mmfLV/MqLqOWW1kb7JuyMSs03DmQ470mNC17YRLvisAh53IGC0xo5Quye6wmd4T4hH90ZNBxynw/c+Co52UY4DcwEYU1Yv1Cpqv0BM8CeAwL4k6bG+cZ8TbVl04ghrQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(47076005)(8936002)(31686004)(6486002)(2616005)(956004)(16576012)(316002)(8676002)(26005)(86362001)(31696002)(70206006)(186003)(508600001)(336012)(70586007)(36860700001)(5660300002)(36756003)(2906002)(110136005)(44832011)(83380400001)(40460700001)(53546011)(356005)(81166007)(82310400004)(145603002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 16:30:36.0684 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2bafd7af-3c79-4e1f-ff33-08d9c17a8df9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2372 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB Hi Leif, Ard, Wenyi, Is it possible to review and provde feedback for this change, please? Regards, Sami Mujawar On 17/12/2021 02:15 PM, Pierre Gondois wrote: > Hi Sami, > > You are correct, as stated in Silicon/Hisilicon/Library/ArmPlatformLibHis= ilicon/ArmPlatformLibSec.inf: > > "Based on the files under ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpre= ssLibRTSM/" > > Thanks for updating the commit, > > Regards, > > Pierre > > > > On 12/17/21 2:59 PM, Sami Mujawar wrote: >> Hi Pierre, >> >> Please find my response inline marked [SAMI]. >> >> Regards, >> >> Sami Mujawar >> >> >> On 24/11/2021 04:23 PM, Pierre.Gondois@arm.com wrote: >>> From: Pierre Gondois >>> >>> The two following modules have the same GUID: >>> - Platform/ARM/VExpressPkg/Library/ >>> ArmVExpressLibRTSM/ArmVExpressLibSec.inf >>> - Silicon/Hisilicon/Library/ >>> ArmPlatformLibHisilicon/ArmPlatformLibSec.inf >>> >>> The inf file in the Platform/ARM/ folder is based >>> on the one in Silicon/Hisilicon/. Modify the one >> [SAMI] I believe you want to say the inf file in Silicon/Hisilicon/is ba= sed on the one in Platform/ARM and therefore you are modifying the inf file= in Silicon/Hisilicon. >> Please let me know if this is correct, and I will update this in the com= mit message before merging the change. >> [/SAMI] >>> in the Silicon/Hisilicon/. >>> >>> Signed-off-by: Pierre Gondois >>> --- >>> .../Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf | 2 = +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatf= ormLibSec.inf b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatfo= rmLibSec.inf >>> index ac587deedfd8..7fd7b5183e5b 100644 >>> --- a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLibS= ec.inf >>> +++ b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLibS= ec.inf >>> @@ -12,7 +12,7 @@ >>> [Defines] >>> INF_VERSION =3D 0x00010005 >>> BASE_NAME =3D ArmPlatformLibSec >>> - FILE_GUID =3D a79eed97-4b98-4974-9690-37b32d6a5= b56 >>> + FILE_GUID =3D ABF3B82B-892F-438F-901F-F148C2DF8= 9E6 >>> MODULE_TYPE =3D BASE >>> VERSION_STRING =3D 1.0 >>> LIBRARY_CLASS =3D ArmPlatformLib >>> -- >>> 2.25.1 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.