From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web10.9492.1595500684611809876 for ; Thu, 23 Jul 2020 03:38:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IsuPYwA5; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595500683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TARdydoNQjM1/rlFH9pZPqCdtWve05g014uuU1nNEuA=; b=IsuPYwA58A0HMNXv4r5U5+AsnPF2WXbFnXjVvFwmhRrD4uFw5db949HuykqAkA4gKu9qPr ltJp+KzO+i/6DoPjePVJs4vF10kubNR1bu9clpPTUyMdxYUEBdvGepB3M+nXLXaKtaxWFU mkpIY2RxUxRjKv++E4zZnqjQumH/k5g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-251-NDRSEcLDME-jBSDUDWqpGw-1; Thu, 23 Jul 2020 06:37:57 -0400 X-MC-Unique: NDRSEcLDME-jBSDUDWqpGw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E504E8015FB; Thu, 23 Jul 2020 10:37:55 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-52.ams2.redhat.com [10.36.114.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E19B87B0D; Thu, 23 Jul 2020 10:37:54 +0000 (UTC) Subject: Re: [PATCH 2/2] OvmfPkg: enable HttpDynamicCommand To: Vladimir Olovyannikov , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm References: <20200721172305.9011-1-vladimir.olovyannikov@broadcom.com> <20200721172305.9011-3-vladimir.olovyannikov@broadcom.com> <4767b4be3123d81816ad90be93e67f1b@mail.gmail.com> From: "Laszlo Ersek" Message-ID: <2b6ebe53-57b1-7fc2-2f42-8add262fc9c4@redhat.com> Date: Thu, 23 Jul 2020 12:37:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4767b4be3123d81816ad90be93e67f1b@mail.gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 07/22/20 22:02, Vladimir Olovyannikov wrote: > Hi Laszlo, > > Thank you for reviewing the patchset. Thank *you* for submitting the set, at my request! :) >> -----Original Message----- >> From: Laszlo Ersek >> Sent: Wednesday, July 22, 2020 12:52 PM >> To: Vladimir Olovyannikov ; >> devel@edk2.groups.io >> Cc: Ard Biesheuvel ; Leif Lindholm >> >> Subject: Re: [PATCH 2/2] OvmfPkg: enable HttpDynamicCommand >> >> On 07/21/20 19:23, Vladimir Olovyannikov wrote: >>> Enable HttpDynamicCommand (Shell command "http") for OvmfPkg >> platforms >>> >>> Signed-off-by: Vladimir Olovyannikov >>> >>> --- >>> OvmfPkg/OvmfPkgIa32.dsc | 6 ++++++ >>> OvmfPkg/OvmfPkgIa32X64.dsc | 6 ++++++ >>> OvmfPkg/OvmfPkgX64.dsc | 6 ++++++ >>> OvmfPkg/OvmfXen.dsc | 6 ++++++ >>> 4 files changed, 24 insertions(+) >>> >>> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc index >>> 9178ffeb71cb..aed3a73c0172 100644 >>> --- a/OvmfPkg/OvmfPkgIa32.dsc >>> +++ b/OvmfPkg/OvmfPkgIa32.dsc >>> @@ -883,6 +883,12 @@ [Components] >>> >>> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE >>> } >>> + >>> + >> ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand >> .inf { >>> + >>> + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE >>> + } >>> + >>> >> OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellComma >> nd.inf { >>> >>> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE >>> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc >> b/OvmfPkg/OvmfPkgIa32X64.dsc >>> index a665f78f0dc7..6c07326cc0fe 100644 >>> --- a/OvmfPkg/OvmfPkgIa32X64.dsc >>> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc >>> @@ -897,6 +897,12 @@ [Components.X64] >>> >>> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE >>> } >>> + >>> + >> ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand >> .inf { >>> + >>> + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE >>> + } >>> + >>> >> OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellComma >> nd.inf { >>> >>> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE >>> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index >>> 17f345acf4ee..d5e5bcf8e66c 100644 >>> --- a/OvmfPkg/OvmfPkgX64.dsc >>> +++ b/OvmfPkg/OvmfPkgX64.dsc >>> @@ -893,6 +893,12 @@ [Components] >>> >>> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE >>> } >>> + >>> + >> ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand >> .inf { >>> + >>> + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE >>> + } >>> + >>> >> OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellComma >> nd.inf { >>> >>> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE >>> diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc index >>> 782803cb2787..fe549502863a 100644 >>> --- a/OvmfPkg/OvmfXen.dsc >>> +++ b/OvmfPkg/OvmfXen.dsc >>> @@ -675,6 +675,12 @@ [Components] >>> >>> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE >>> } >>> + >>> + >> ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand >> .inf { >>> + >>> + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE >>> + } >>> + >>> >> OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellComma >> nd.inf { >>> >>> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE >>> >> >> Basically same comments as under the ArmVirtPkg patch: >> >> (1) Please mention >> in the commit message. > OK, will do. For future contributions related to a BZ ticket - does it mean > that mentioning of BZ id in the cover letter is not enough? Referencing the BZ in the cover letter only is indeed not ideal; the cover letter does not get captured in the git history. When submitting a series for a BZ, it's best to mention the BZ in every patch in the series. One frequently used format is """ Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2857 """ placed near the end of the commit message (just above the Signed-off-by and similar tags). But other formats are fine too. >> >> (2) Please don't introduce the extra whitespace in the DSC files. >> >> (3) Please also add the new module to the following (FDF) files: >> >> - OvmfPkgIa32.fdf >> - OvmfPkgIa32X64.fdf >> - OvmfPkgX64.fdf >> - OvmfXen.fdf > OK, will do, thanks. >> >> Once you post v2 of this series, with the above points fixed (especially >> the >> FDF files), I'd like to test the new command (with both ArmVirtQemu and >> OVMF). > Sure, that would be great. Thanks! Laszlo