From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by mx.groups.io with SMTP id smtpd.web10.13097.1670240924757798829 for ; Mon, 05 Dec 2022 03:48:44 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=W1IWVtn6; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 199.106.114.38, mailfrom: quic_rcran@quicinc.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1670240924; x=1701776924; h=from:message-id:date:mime-version:subject:to:references: in-reply-to:content-transfer-encoding; bh=0RrYOBq4w7js1TLvmo8tBmBDZZ0vbv74j5kvnY8Vtuo=; b=W1IWVtn60SNd3fRbaZ+t8o0Bll0f95TrzlzD3uttIwdYbEHXKIoxm5hI r92jqHLk5GN0HbBcvft+T5mhYygbcqwr3JCpbHUENpsP00musVBAZvY1S CZJ9+FAEaIp6+qmZd/n8WUybcVYCGewvUVM2uqWuoP28olci5qVDSO+q5 8=; Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144]) by alexa-out-sd-01.qualcomm.com with ESMTP; 05 Dec 2022 03:48:44 -0800 From: "Rebecca Cran" X-QCInternal: smtphost Received: from nasanex01b.na.qualcomm.com ([10.46.141.250]) by ironmsg04-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2022 03:48:44 -0800 Received: from [10.110.8.230] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 5 Dec 2022 03:48:43 -0800 Message-ID: <2b79d2f4-15cc-f1f2-bd0f-8fa8ae91cde4@quicinc.com> Date: Mon, 5 Dec 2022 04:48:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [edk2-devel] [PATCH edk2-platforms 2/3] Platform/ARM/JunoPkg: Override PcdTimerPeriod to be 10000 To: Pierre Gondois , , , Ard Biesheuvel , "Thomas Abraham" , Sami Mujawar References: <20221129135358.136555-1-rebecca@quicinc.com> <20221129135358.136555-3-rebecca@quicinc.com> In-Reply-To: Return-Path: rebecca@quicinc.com X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit On 12/5/22 02:22, Pierre Gondois wrote: > The default value of PcdTimerPeriod in EmbeddedPkg/EmbeddedPkg.dec > seems to be 100000 (100ns), so 10ms, and other Arm platforms have > set the value to 1000 (100ns), so 100us. I was wondering where you > found the 1ms value ? Sorry, I misread a comment in TimerDxe.c. This patch should be dropped. // mTimerTicks = TimerPeriod in 1ms unit * Frequency.10^-3 -- Rebecca Cran > > Otherwise the other patches look good to me. > > Regards, > Pierre > > > On 11/29/22 14:53, Rebecca Cran via groups.io wrote: >> The PCD PcdTimerPeriod is used in TimerDxe to calculate how many ticks >> to wait between timer interrupts. The default value of 100000 results >> in waiting 10 ms, while the driver wants interrupts to occur every 1ms. >> >> Override the value of PcdTimerPeriod in ArmJuno.dsc to be 10000. >> >> Signed-off-by: Rebecca Cran >> --- >>   Platform/ARM/JunoPkg/ArmJuno.dsc | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc >> b/Platform/ARM/JunoPkg/ArmJuno.dsc >> index 9cde4c862651..9b63a8914f03 100644 >> --- a/Platform/ARM/JunoPkg/ArmJuno.dsc >> +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc >> @@ -189,6 +189,7 @@ [PcdsFixedAtBuild.common] >>     # ARM Architectural Timer Frequency >>     # >>     gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|50000000 >> +  gEmbeddedTokenSpaceGuid.PcdTimerPeriod|10000 >> >> gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE