Re: [edk2-devel] [PATCH] DynamicTablesPkg/SSDT: Remove incorrect root node check

["PierreGondois" <pierre.gondois@arm.com>]

Hello Jeshua,

On 1/9/24 17:55, Jeshua Smith wrote:
>>> Two physical packages are on a multi-chip module and share resources on
>> the module. The module then plugs into the baseboard/motherboard.
>>
>> Is it possible to elaborate on the resource being shared ?
> 
> In our specific case the problem is related to the PPTT's "Identical Implementation" flag. We need a top level node above the physical package nodes to be able to set the "Identical Implementation" flag to indicate that all of the procs in all of the child packages are the same identical implementation. Without this (ie. forcing each physical package to be its own root node) Linux will fail to load the SPE driver when there are multiple identical packages because it detects that some of the procs have a different root node than other procs, implying that the packages don't have identical implementations.
> 

Ok understood.

Would it then be possible to re-format the check instead of removing it ?
It should be possible to add a parameter to CreateAmlCpuTopologyTree()
to recursively check there was a node with the
EFI_ACPI_6_3_PPTT_PACKAGE_PHYSICAL bit set in the parents of
all the processor nodes,

Regards,
Pierre



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113818): https://edk2.groups.io/g/devel/message/113818
Mute This Topic: https://groups.io/mt/103603398/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-