From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fb.mail.gandi.net (spool8.mail.gandi.net [217.70.178.217]) by nmboxes7-ms7.sd4.0x35.net (Postfix) with ESMTPS id 018EE61930 for ; Tue, 16 Jan 2024 06:27:59 +0000 (UTC) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by fb.mail.gandi.net (Postfix) with ESMTPS id 8572360342 for ; Tue, 16 Jan 2024 06:27:59 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=o7VftD7AlPRnHWzVuqj2thtAlDhTYpfSlDRHZLZIcbw=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705386478; v=1; b=OqRhxlx7gkwsH+b7q2QQspjZwdPt+gt5WmLejVUI9TaS1bP9HVeYFx9XeaymTGZxksKyzrkI /vPe//wHTBWDTEFGiiJu2kb1+uMyIxlAv1CnOEF2T58oGcs4mMO1n6G/DLIEXxun6h1ybECznmK uSWwg24MmiZL62DSqTCPfFGw= X-Received: by 127.0.0.2 with SMTP id kZLjYY7687511xMVDa5HtMQA; Mon, 15 Jan 2024 22:27:58 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.77331.1705318877702448203 for ; Mon, 15 Jan 2024 03:41:18 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D73DE2F4; Mon, 15 Jan 2024 03:42:03 -0800 (PST) X-Received: from [10.34.100.129] (e126645.nice.arm.com [10.34.100.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 429713F5A1; Mon, 15 Jan 2024 03:41:16 -0800 (PST) Message-ID: <2bb665ac-671a-4969-bf32-5ca2461cb4f0@arm.com> Date: Mon, 15 Jan 2024 12:41:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg/SSDT: Remove incorrect root node check To: Jeshua Smith , "devel@edk2.groups.io" Cc: "ardb+tianocore@kernel.org" , "quic_llindhol@quicinc.com" , "Sami.Mujawar@arm.com" , Shanker Donthineni , Vikram Sethi , Ashish Singhal References: From: "PierreGondois" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: MA922Lef7otOCSN8qmoPElNwx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: fb.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=OqRhxlx7; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (fb.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hello Jeshua, On 1/9/24 17:55, Jeshua Smith wrote: >>> Two physical packages are on a multi-chip module and share resources on >> the module. The module then plugs into the baseboard/motherboard. >> >> Is it possible to elaborate on the resource being shared ? >=20 > In our specific case the problem is related to the PPTT's "Identical Impl= ementation" flag. We need a top level node above the physical package nodes= to be able to set the "Identical Implementation" flag to indicate that all= of the procs in all of the child packages are the same identical implement= ation. Without this (ie. forcing each physical package to be its own root n= ode) Linux will fail to load the SPE driver when there are multiple identic= al packages because it detects that some of the procs have a different root= node than other procs, implying that the packages don't have identical imp= lementations. >=20 Ok understood. Would it then be possible to re-format the check instead of removing it ? It should be possible to add a parameter to CreateAmlCpuTopologyTree() to recursively check there was a node with the EFI_ACPI_6_3_PPTT_PACKAGE_PHYSICAL bit set in the parents of all the processor nodes, Regards, Pierre -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113818): https://edk2.groups.io/g/devel/message/113818 Mute This Topic: https://groups.io/mt/103603398/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-