Re: [PATCH v3 1/3] OvmfPkg: make PlatformDebugLibIoPort a proper BASE library

[Laszlo Ersek <lersek@redhat.com>]

On 11/16/17 21:30, Paolo Bonzini wrote:
> Remove Uefi.h, which includes UefiSpec.h, and change the
> return value to match the RETURN_STATUS type.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Tested-by: Laszlo Ersek <lersek@redhat.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen (Intel address) <jordan.l.justen@intel.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
> index 5435767c1c..74f4d9c2d6 100644
> --- a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
> +++ b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
> @@ -15,7 +15,6 @@
>  **/
>  
>  #include <Base.h>
> -#include <Uefi.h>
>  #include <Library/DebugLib.h>
>  #include <Library/BaseLib.h>
>  #include <Library/IoLib.h>
> @@ -32,7 +31,7 @@
>  /**
>    This constructor function does not have to do anything.
>  
> -  @retval EFI_SUCCESS   The constructor always returns RETURN_SUCCESS.
> +  @retval RETURN_SUCCESS   The constructor always returns RETURN_SUCCESS.
>  
>  **/
>  RETURN_STATUS
> @@ -41,7 +40,7 @@ PlatformDebugLibIoPortConstructor (
>    VOID
>    )
>  {
> -  return EFI_SUCCESS;
> +  return RETURN_SUCCESS;
>  }
>  
>  /**
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>