From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id D902E202E5E60
 for <edk2-devel@lists.01.org>; Fri, 17 Nov 2017 09:17:33 -0800 (PST)
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com
 [10.5.11.11])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 4938519D4C9;
 Fri, 17 Nov 2017 17:21:44 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-124-49.rdu2.redhat.com
 [10.10.124.49])
 by smtp.corp.redhat.com (Postfix) with ESMTP id ACB8F7E980;
 Fri, 17 Nov 2017 17:21:42 +0000 (UTC)
To: Paolo Bonzini <pbonzini@redhat.com>, edk2-devel@lists.01.org
Cc: Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>
References: <20171116203100.28085-1-pbonzini@redhat.com>
 <20171116203100.28085-2-pbonzini@redhat.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <2bcf2774-54da-63b9-67ec-792e97345792@redhat.com>
Date: Fri, 17 Nov 2017 18:21:41 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171116203100.28085-2-pbonzini@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.29]); Fri, 17 Nov 2017 17:21:44 +0000 (UTC)
Subject: Re: [PATCH v3 1/3] OvmfPkg: make PlatformDebugLibIoPort a proper BASE library
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Nov 2017 17:17:34 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 11/16/17 21:30, Paolo Bonzini wrote:
> Remove Uefi.h, which includes UefiSpec.h, and change the
> return value to match the RETURN_STATUS type.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Tested-by: Laszlo Ersek <lersek@redhat.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen (Intel address) <jordan.l.justen@intel.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
> index 5435767c1c..74f4d9c2d6 100644
> --- a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
> +++ b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
> @@ -15,7 +15,6 @@
>  **/
>  
>  #include <Base.h>
> -#include <Uefi.h>
>  #include <Library/DebugLib.h>
>  #include <Library/BaseLib.h>
>  #include <Library/IoLib.h>
> @@ -32,7 +31,7 @@
>  /**
>    This constructor function does not have to do anything.
>  
> -  @retval EFI_SUCCESS   The constructor always returns RETURN_SUCCESS.
> +  @retval RETURN_SUCCESS   The constructor always returns RETURN_SUCCESS.
>  
>  **/
>  RETURN_STATUS
> @@ -41,7 +40,7 @@ PlatformDebugLibIoPortConstructor (
>    VOID
>    )
>  {
> -  return EFI_SUCCESS;
> +  return RETURN_SUCCESS;
>  }
>  
>  /**
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>