From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web12.45069.1622472786616416529 for ; Mon, 31 May 2021 07:53:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BKrcZkBi; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622472785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VO/58m72vUg06GKayBxH2YaHqsIMjFlprd7Rku4ZQcs=; b=BKrcZkBiMoFOjpsVm1R3s6RVHJKWM+4sEse0EOV8Ibm+r/7i06dzSMkFUtXMA5MvbevP/m uMTfBjkWvRXJtMiDlscNWdAN2AFPMev5VMjKYYxQOuOARoxL3IIYcEGsWOoj50pJlCvHxO 3Unxkjd9Ga5Q8ewZDuKiMKtMnUmtHw8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-504-RysMftqvN0qjPukvRIFz-w-1; Mon, 31 May 2021 10:53:01 -0400 X-MC-Unique: RysMftqvN0qjPukvRIFz-w-1 Received: by mail-wr1-f72.google.com with SMTP id q15-20020adfc50f0000b0290111f48b865cso4066033wrf.4 for ; Mon, 31 May 2021 07:53:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VO/58m72vUg06GKayBxH2YaHqsIMjFlprd7Rku4ZQcs=; b=LdGsS3aj9hWAjLaAp1/Psq/zihsqsRsP6fbsdd0fZaETAT/pUh62CgLNj5lfIImU6w FHEK1CwuH/00usJR89v6pubkdVEVs4YzjgLUp5P+dJowb7Lq26BRk3JtJp3c3aLfLJ2z PQCRVx8BkAt1pDamJsbIefrz6ktC+Jot4TxJY+umA3Xc9vZR0kTCKMzXRL6ux84bwg0m d/ruo5uwThQ6TJicJhH3TkIrodXJpqfJJQH3YkTBgpY48ta+doytsGWzF4ysCUwZgzdF y+nL0ICAx35m4i1Ag5HMosGfgKVaq5BazGZ0tJDpqcwwr2WGMqbWcNK3rsWesDn4Q3ej sAEg== X-Gm-Message-State: AOAM5324nYr9ALlhCxV1cTj8IWv3oGOLqhOR1QDhEkCxZya/4c+cEkK4 hzJGn/aU7DYg9R4OqKglrc1X6IKSo+wA5KQ05/dm5LYvEtdC0dVJevuLOvDAjljUo4BuhyuqAcn iQgbxJn2hBjKGSQ== X-Received: by 2002:a05:600c:35cc:: with SMTP id r12mr21266665wmq.157.1622472780823; Mon, 31 May 2021 07:53:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0GoLur4HmhdssmqOZmHK1ub1OaUM7Gci7uUhERr5CJM4YCY3O1leNbHGvHEiWjkJShdi2UQ== X-Received: by 2002:a05:600c:35cc:: with SMTP id r12mr21266647wmq.157.1622472780635; Mon, 31 May 2021 07:53:00 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id c23sm11029237wme.37.2021.05.31.07.52.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 May 2021 07:52:59 -0700 (PDT) Subject: Re: [PATCH 29/43] OvmfPkg/PciHostBridgeLibScan: create from PciHostBridgeLib To: Laszlo Ersek , devel@edk2.groups.io Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall , Peter Grehan , Rebecca Cran References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-30-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <2bda29b1-c2dd-3138-5f88-aa969e397cbe@redhat.com> Date: Mon, 31 May 2021 16:52:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-30-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > Create an almost verbatim copy of the > "OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf" library instance. > > The new PciHostBridgeLibScan instance will ultimately duplicate a > negligible amount of code from the original, and will be used by the Bhyve > and OvmfXen platforms. > > List the new driver in "Maintainers.txt", in the "OvmfPkg: bhyve-related > modules" and "OvmfPkg: Xen-related modules" sections. > > This patch should be reviewed with "git show --find-copies-harder". Thanks for the tip :) Reviewed-by: Philippe Mathieu-Daude > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Peter Grehan > Cc: Philippe Mathieu-Daudé > Cc: Rebecca Cran > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/Library/{PciHostBridgeLib/PciHostBridgeLib.inf => PciHostBridgeLibScan/PciHostBridgeLibScan.inf} | 6 +++--- > Maintainers.txt | 2 ++ > OvmfPkg/Library/{PciHostBridgeLib => PciHostBridgeLibScan}/PciHostBridge.h | 1 + > OvmfPkg/Library/{PciHostBridgeLib => PciHostBridgeLibScan}/PciHostBridgeLib.c | 2 +- > OvmfPkg/Library/{PciHostBridgeLib => PciHostBridgeLibScan}/XenSupport.c | 1 + > 5 files changed, 8 insertions(+), 4 deletions(-)