From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::543; helo=mail-pg1-x543.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CD1F2210FCF66 for ; Thu, 23 Aug 2018 01:38:06 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id b129-v6so2214858pga.13 for ; Thu, 23 Aug 2018 01:38:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VAbeA09JmCOrYcC8hLp22nmeFYsXA4YHR2SNcfOIiEo=; b=M/LDi6YbiLJ44xjGWUci/B0HY+gsrqFNHmqKTImULahIEjgHsPhOpm/D5lhpASCN1b JnEPB3rQJ75kGJq0Y0PV3U0MKYxPbgVe5g6lX2iJCfKtiizqVMPTY8sG0V5rUMa7JMxA 63WFKffPKlQSkGaiW4EM8wh2ZMQKA/ETSHaHY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VAbeA09JmCOrYcC8hLp22nmeFYsXA4YHR2SNcfOIiEo=; b=iH4778X4oCOo2FlD5X5TsTNBYN6m+V34W59VkJhHxTKslIzlHBn1tMZ+h0A/eGqQDs vQ8GiIvu912BZimylHxTy3vRmtkhP52VwFYqjsjF6wwrNm9cstzDOq8TeFX5yOle/gOb 5Nq28lkNCwpupMHEVcGXKnXHyiPuEqRIgur69kPZzgynErFsQFuHLwxcDsG75nEnpEMV HLCu/4e0DA0C4xBBLorAUpiwAKOw3LcRPDcwa/yLbECaVf1Rf0YDcwS4MxnrANtk1s7P 18LdPjRIgWyvJ4pDjUdV2NmnaTv5JbzPZk3JaeeALgz843wrY+74G7NtCqo+HcX6UvQ6 sG8w== X-Gm-Message-State: AOUpUlH3y7whF2ANW6m5+NKE9yFc5sWg+JuWkyxolPe9C8q0t1zLyRLE pABQwMywvrhtq8BBL4m2JInwRw== X-Google-Smtp-Source: AA+uWPwgTL/e7asgkYVXZyqrXoAs1qMi49ms5/oUNBgI/TCrYoIzEqeVo/6zcGqPHtnQmUUSps7R+A== X-Received: by 2002:a63:a919:: with SMTP id u25-v6mr55962207pge.211.1535013486245; Thu, 23 Aug 2018 01:38:06 -0700 (PDT) Received: from [10.84.0.214] ([64.64.108.140]) by smtp.gmail.com with ESMTPSA id e64-v6sm2391794pfk.87.2018.08.23.01.37.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Aug 2018 01:38:05 -0700 (PDT) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org References: <20180814080903.50466-1-ming.huang@linaro.org> <20180814080903.50466-43-ming.huang@linaro.org> <20180822184810.qyrnecgl7fq7tj5f@bivouac.eciton.net> From: Ming Message-ID: <2be027cc-cd68-b6f6-a3ef-f11c7d699009@linaro.org> Date: Thu, 23 Aug 2018 16:37:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180822184810.qyrnecgl7fq7tj5f@bivouac.eciton.net> Subject: Re: [PATCH edk2-platforms v2 42/43] Hisilicon/D06: Add edk2-non-osi Shell components X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2018 08:38:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 8/23/2018 2:48 AM, Leif Lindholm wrote: > So, on the whole, I am really not happy for any of these commands to > go into 18.08. I understand they may be handy for development, but I > do not understand why they make sense to upstream. As Oem Shell commands is useless for ERP, I will drop this patch and on-osi related components. > > On Tue, Aug 14, 2018 at 04:09:02PM +0800, Ming Huang wrote: >> Add Hisilicon Oem Shell libraries for some commands,such as >> biosupdate, getmac, setmac, provision, acpistartos, brdinfo, >> sfpinfo. >> >> biosupdate example: >> ifconfig -s eth2 static 192.168.2.68 255.255.255.0 192.168.2.1 >> biosupdate serverIp -u user -p password -f D06.fd -m master >> >> acpistartos example: >> ifconfig -s eth2 static 192.168.2.69 255.255.255.0 192.168.2.1 >> provision serverIp -u user -p password -f os\Image -a 0x80000 >> 2 >> provision serverIp -u user -p password -f os\minifs.cpio.gz -a 0x07000000 >> 2 >> acpistartos >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ming Huang >> --- >> Silicon/Hisilicon/HisiPkg.dec | 4 ++++ >> Platform/Hisilicon/D06/D06.dsc | 2 ++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/Silicon/Hisilicon/HisiPkg.dec b/Silicon/Hisilicon/HisiPkg.dec >> index 858b840a57..010d501914 100644 >> --- a/Silicon/Hisilicon/HisiPkg.dec >> +++ b/Silicon/Hisilicon/HisiPkg.dec >> @@ -39,6 +39,7 @@ >> gPlatformSasProtocolGuid = {0x40e9829f, 0x3a2c, 0x479a, {0x9a, 0x93, 0x45, 0x7d, 0x13, 0x50, 0x96, 0x5d}} >> gHisiPlatformSasProtocolGuid = {0x20e9829f, 0x3a2c, 0x479a, {0x9a, 0x93, 0x45, 0x7d, 0x13, 0x50, 0x96, 0x6d}} >> gHisiSnpPlatformProtocolGuid = {0x81321f27, 0xff58, 0x4a1d, {0x99, 0x97, 0xd, 0xcc, 0xfa, 0x82, 0xf4, 0x6f}} >> + gOemNicProtocolGuid = {0xb5903955, 0x31e9, 0x4aaf, {0xb2, 0x83, 0x7, 0x9f, 0x3c, 0xc4, 0x71, 0x66}} >> >> [Guids] >> gHisiTokenSpaceGuid = {0xc8bc553e, 0x12bf, 0x11e6, {0x97, 0x4f, 0x87, 0xf7, 0x7c, 0xfd, 0x52, 0x1d}} >> @@ -49,6 +50,8 @@ >> gHisiOemVariableGuid = {0xac62b9a5, 0x9939, 0x41d3, {0xff, 0x5c, 0xc5, 0x80, 0x32, 0x7d, 0x9b, 0x29}} >> gOemBootVariableGuid = {0xb7784577, 0x5aaf, 0x4557, {0xa1, 0x99, 0xd4, 0xa4, 0x2f, 0x45, 0x06, 0xf8}} >> gEfiHisiSocControllerGuid = {0xee369cc3, 0xa743, 0x5382, {0x75, 0x64, 0x53, 0xe4, 0x31, 0x19, 0x38, 0x35}} >> + HisiShellSampleHiiGuid = { 0x43859314, 0x82c1, 0x4592, { 0x8f, 0xf7, 0xc1, 0xbd, 0xf3, 0xb2, 0x0e, 0xd5 }} >> + HisiPlatformShellSampleHiiGuid = { 0x7924a5de, 0xc600, 0x40d5, { 0x91, 0x10, 0xf9, 0xc3, 0xe7, 0x25, 0x4d, 0x33 }} > > Why do we need all these different GUIDs? > > Also, why "Sample"? > > / > Leif > >> >> [LibraryClasses] >> PlatformSysCtrlLib|Include/Library/PlatformSysCtrlLib.h >> @@ -101,6 +104,7 @@ >> gHisiTokenSpaceGuid.PcdSlotPerChannelNum|0x0|UINT32|0x40000004 >> >> gHisiTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }|VOID*|0x30006554 >> + gHisiTokenSpaceGuid.PcdStartOsParameter|L""|VOID*|0x5000000 >> >> #FDT File Address >> gHisiTokenSpaceGuid.FdtFileAddress|0x0|UINT64|0x40000005 >> diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc >> index 053ea894d5..544039e450 100644 >> --- a/Platform/Hisilicon/D06/D06.dsc >> +++ b/Platform/Hisilicon/D06/D06.dsc >> @@ -473,6 +473,8 @@ >> !if $(INCLUDE_DP) == TRUE >> NULL|ShellPkg/Library/UefiDpLib/UefiDpLib.inf >> !endif #$(INCLUDE_DP) >> + NULL|Silicon/Hisilicon/Library/HisiShellCmdLib/HisiShellCmdLib.inf >> + NULL|Silicon/Hisilicon/Hi1620/Library/HisiD06ShellCmdLib/HisiD06ShellCmdLib.inf >> >> >> gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0xFF >> -- >> 2.17.0 >>