From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web11.29717.1669853144551419836
 for <devel@edk2.groups.io>;
 Wed, 30 Nov 2022 16:05:44 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=DuFj/4fz;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.8.94])
	by linux.microsoft.com (Postfix) with ESMTPSA id D5F9120B83C2;
	Wed, 30 Nov 2022 16:05:41 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D5F9120B83C2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1669853144;
	bh=s1dJUJJ866EWQRxgLoO0A8VlDGIA9HD8JOPF/szywsk=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=DuFj/4fzYlT+aBJf5EfMdAv3RcH+ykq2wA1pvszLEWdiu2wj+lFnhnpjTsW1inq5I
	 gfysnAfJ42MNxdQawKAktEsf+t4bMcRqExSWg2lu8Mh8Gu1XaYdEdVpXLqdd03iM2Q
	 lPxJiJXGshKNBEzHJh147WIXrBr3FFT/bkswWiYk=
Message-ID: <2be8ad9d-8be2-20a3-357f-5082aba06fdc@linux.microsoft.com>
Date: Wed, 30 Nov 2022 19:05:40 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [edk2-devel] [PATCH v9 05/12] CI: Allow running in a container.
To: devel@edk2.groups.io, osteffen@redhat.com
Cc: Andrew Fish <afish@apple.com>, Ard Biesheuvel
 <ardb+tianocore@kernel.org>, Bob Feng <bob.c.feng@intel.com>,
 Daniel Schaefer <git@danielschaefer.me>, Gerd Hoffmann <kraxel@redhat.com>,
 Jiewen Yao <jiewen.yao@intel.com>, Jordan Justen
 <jordan.l.justen@intel.com>, Leif Lindholm <quic_llindhol@quicinc.com>,
 Liming Gao <gaoliming@byosoft.com.cn>,
 Michael D Kinney <michael.d.kinney@intel.com>, Ray Ni <ray.ni@intel.com>,
 Sami Mujawar <sami.mujawar@arm.com>, Sean Brogan
 <sean.brogan@microsoft.com>, Sunil V L <sunilvl@ventanamicro.com>,
 Yuwei Chen <yuwei.chen@intel.com>, Zhiguang Liu <zhiguang.liu@intel.com>,
 Pawel Polawski <ppolawsk@redhat.com>, Chris Fernald <chfernal@microsoft.com>
References: <20221130220125.1112760-1-osteffen@redhat.com>
 <CA+bRGFqnKvcU-ECyvYi6KP+v6rDEvF74YV6OFWoLTMjMEsDifg@mail.gmail.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <CA+bRGFqnKvcU-ECyvYi6KP+v6rDEvF74YV6OFWoLTMjMEsDifg@mail.gmail.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 11/30/2022 5:01 PM, Oliver Steffen wrote:
> Add a parameter of the pr-gate-build-job template to specify a
> container image URL.  If the value is not '' (default), then the
> jobs will be run inside a container based on that image.
> 
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---
>   .azurepipelines/templates/pr-gate-build-job.yml | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> b/.azurepipelines/templates/pr-gate-build-job.yml
> index f0ef1142da49..5ffcaca7b591 100644
> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> @@ -12,6 +12,7 @@ parameters:
>     tool_chain_tag: ''
>     vm_image: ''
>     arch_list: ''
> +  container: ''
>     usePythonVersion: ''
> 
>   # Build step
> @@ -71,6 +72,9 @@ jobs:
>     pool:
>       vmImage: ${{ parameters.vm_image }}
> 
> +  ${{ if not(eq(parameters.container, '')) }}:
> +    container: ${{ parameters.container }}
> +
>     steps:
>     - template: pr-gate-steps.yml
>       parameters: