Re: [PATCH] CryptoPkg: Fix various typos

[Ryszard Knop <ryszard.knop@linux.intel.com>]

Hi Philippe, Antoine,

On Wed, 2019-02-06 at 23:30 +0100, Philippe Mathieu-Daudé wrote:
> Hi Antoine,
> 
> On 2/6/19 6:24 PM, Antoine Coeur wrote:
> > Fix various typos in CryptoPkg.
> > 
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Coeur <coeur@gmx.fr>
> > ---
> >  CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c         | 2 +-
> >  CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 4 ++--
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> > b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> > index d63c23df09..540c5715cb 100644
> > --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> > +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c
> > @@ -142,7 +142,7 @@ IMPLEMENT_ASN1_FUNCTIONS (TS_TST_INFO)
> >    @param[in]  Asn1Time         Pointer to the ASN.1
> > GeneralizedTime to be converted.
> >    @param[out] SigningTime      Return the corresponding EFI Time.
> >  
> > -  @retval  TRUE   The time convertion succeeds.
> > +  @retval  TRUE   The time conversion succeeds.
> 
> The typos are indeed fixed, so:
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> 
> However reading this description makes me suspicious, I'd have
> written
> "The time convertion succeeded.", but I'm not native English speaker
> so
> I'll let someone with more insurance opinate.

I'm not a native speaker either, but I'd write "conversion" as well.
(Like revert -> reversion, subvert -> subversion, avert -> aversion,
and so on.)

> 
> Regards,
> 
> Phil.
> 
> >    @retval  FALSE  Invalid parameters.
> >  
> >  **/
> > diff --git a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
> > b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
> > index 9510a4a383..929e3fcd1e 100644
> > --- a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
> > +++ b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
> > @@ -84,14 +84,14 @@ QuickSortWorker (
> >      }
> >    }
> >    //
> > -  // Swap pivot to it's final position (NextSwapLocaiton)
> > +  // Swap pivot to it's final position (NextSwapLocation)
> >    //
> >    CopyMem (Buffer, Pivot, ElementSize);
> >    CopyMem (Pivot, (UINT8 *)BufferToSort + (NextSwapLocation *
> > ElementSize), ElementSize);
> >    CopyMem ((UINT8 *)BufferToSort + (NextSwapLocation *
> > ElementSize), Buffer, ElementSize);
> >  
> >    //
> > -  // Now recurse on 2 paritial lists.  Neither of these will have
> > the 'pivot' element.
> > +  // Now recurse on 2 partial lists.  Neither of these will have
> > the 'pivot' element.
> >    // IE list is sorted left half, pivot element, sorted right
> > half...
> >    //
> >    QuickSortWorker (
> > 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel