From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=ryszard.knop@linux.intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0A127211CA2DA for ; Thu, 7 Feb 2019 05:04:07 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Feb 2019 05:04:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,344,1544515200"; d="scan'208";a="297954512" Received: from linux.intel.com ([10.54.29.200]) by orsmga005.jf.intel.com with ESMTP; 07 Feb 2019 05:04:07 -0800 Received: from torii (torii.igk.intel.com [10.102.24.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id D01BA5802E1; Thu, 7 Feb 2019 05:04:05 -0800 (PST) Message-ID: <2bf54b577aeef2a5529b3880d4d74e361f8a2089.camel@linux.intel.com> From: Ryszard Knop To: edk2-devel@lists.01.org, Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= Cc: Antoine Coeur , Laszlo Ersek Date: Thu, 07 Feb 2019 14:04:03 +0100 In-Reply-To: <280bb5d0-e01c-022e-6a02-6b744f61f28d@redhat.com> References: <280bb5d0-e01c-022e-6a02-6b744f61f28d@redhat.com> Organization: Intel Corporation User-Agent: Evolution 3.30.5 MIME-Version: 1.0 Subject: Re: [PATCH] CryptoPkg: Fix various typos X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 13:04:08 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hi Philippe, Antoine, On Wed, 2019-02-06 at 23:30 +0100, Philippe Mathieu-Daudé wrote: > Hi Antoine, > > On 2/6/19 6:24 PM, Antoine Coeur wrote: > > Fix various typos in CryptoPkg. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Coeur > > --- > > CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +- > > CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 4 ++-- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c > > b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c > > index d63c23df09..540c5715cb 100644 > > --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c > > +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c > > @@ -142,7 +142,7 @@ IMPLEMENT_ASN1_FUNCTIONS (TS_TST_INFO) > > @param[in] Asn1Time Pointer to the ASN.1 > > GeneralizedTime to be converted. > > @param[out] SigningTime Return the corresponding EFI Time. > > > > - @retval TRUE The time convertion succeeds. > > + @retval TRUE The time conversion succeeds. > > The typos are indeed fixed, so: > Reviewed-by: Philippe Mathieu-Daude > > However reading this description makes me suspicious, I'd have > written > "The time convertion succeeded.", but I'm not native English speaker > so > I'll let someone with more insurance opinate. I'm not a native speaker either, but I'd write "conversion" as well. (Like revert -> reversion, subvert -> subversion, avert -> aversion, and so on.) > > Regards, > > Phil. > > > @retval FALSE Invalid parameters. > > > > **/ > > diff --git a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > > b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > > index 9510a4a383..929e3fcd1e 100644 > > --- a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > > +++ b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > > @@ -84,14 +84,14 @@ QuickSortWorker ( > > } > > } > > // > > - // Swap pivot to it's final position (NextSwapLocaiton) > > + // Swap pivot to it's final position (NextSwapLocation) > > // > > CopyMem (Buffer, Pivot, ElementSize); > > CopyMem (Pivot, (UINT8 *)BufferToSort + (NextSwapLocation * > > ElementSize), ElementSize); > > CopyMem ((UINT8 *)BufferToSort + (NextSwapLocation * > > ElementSize), Buffer, ElementSize); > > > > // > > - // Now recurse on 2 paritial lists. Neither of these will have > > the 'pivot' element. > > + // Now recurse on 2 partial lists. Neither of these will have > > the 'pivot' element. > > // IE list is sorted left half, pivot element, sorted right > > half... > > // > > QuickSortWorker ( > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel