From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179])
 by mx.groups.io with SMTP id smtpd.web12.179.1610493768194052496
 for <devel@edk2.groups.io>;
 Tue, 12 Jan 2021 15:22:48 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=JjBWWPew;
 spf=pass (domain: nuviainc.com, ip: 209.85.215.179, mailfrom: rebecca@nuviainc.com)
Received: by mail-pg1-f179.google.com with SMTP id 30so219705pgr.6
        for <devel@edk2.groups.io>; Tue, 12 Jan 2021 15:22:48 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=nuviainc-com.20150623.gappssmtp.com; s=20150623;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=Ho2KDODimdRQizcv5lz/8VOXlBGV+SFMes0vVSSARBs=;
        b=JjBWWPewBz9QbvIPnumnRWgCKdw+Kt7lZ6Y4z2lHcjwN6mVU8pLiu0E26YVSxAiY8z
         FBRSJwX1vCOkgstvVI067HhMSalEl8yYSCoGAjWvCJHa4ak+xIF5sr3Gh6wpca2yzstq
         8Uf3sjjjf9dysfZDyyckg5KT1/u20MkYUwZ7g27NjvdtFwrdX8EMh/w6aCNermsATcoF
         6mIWUzl2jczQHrDRqXdvGfNYh+M5YkS82exwb3zU40tpM/XhurjTOBi+P0TwHhRIAb55
         OArTf7TY45gx9R1Hcgo9eoPq6ZxvBHoXiQkPWLBPJ5fHy7vouwo+yIBkPX3Jbf+UY7RD
         5A2w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=Ho2KDODimdRQizcv5lz/8VOXlBGV+SFMes0vVSSARBs=;
        b=OkA1GF/103RUGuaLsBMteHzpwa5SprkTSQe7l/I5hG3Tc5cWM08f7nQq2aBqVQxF0E
         EcwN3yVNQq8gOkgidzBwdGFtLHqM6FpS8mvcUzFku+cFvEljPmi+ijJ7nCBUn0U7Zcjm
         920YVfl39C0HvYeTBxWUxv3kiT4zaHemd4/Td9i+EtWutpkIPRJpkW6AD5fjsvvrCJ+R
         tgY1qFW5k4p/++1XGe0vn4iacL4AbLaXDcQJVm6NM55E6eyfMUhXLzo3AQQduTLto7xP
         2xMcUxSgceRP8nhazbg2qcWR+HdvK/X/vYzed7I1qT0QEI3/RRwMQFyIiIbJeZj5UdK/
         HnCw==
X-Gm-Message-State: AOAM533uK4JrK7J8d0aZot8TiA6lZKjncOHNHbjY3u1y7bO1G9fDqKQC
	3lWFpFArpBakYX59aGOhYSHF1A==
X-Google-Smtp-Source: ABdhPJz/qPMt4bXUfiOEFDayf6Ity75yK38y/fS7T44h2iwU54qimT7fxuMNJCOfLFI57fpVkRG6NA==
X-Received: by 2002:a63:2b42:: with SMTP id r63mr1389311pgr.316.1610493767772;
        Tue, 12 Jan 2021 15:22:47 -0800 (PST)
Return-Path: <rebecca@nuviainc.com>
Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57])
        by smtp.gmail.com with ESMTPSA id x21sm23350pgi.75.2021.01.12.15.22.46
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Tue, 12 Jan 2021 15:22:47 -0800 (PST)
Subject: Re: [PATCH v5 18/23] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe
To: Leif Lindholm <leif@nuviainc.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ard.biesheuvel@arm.com>,
 "nd @ arm . com . Sami Mujawar" <Sami.Mujawar@arm.com>,
 Liming Gao <gaoliming@byosoft.com.cn>,
 Michael D Kinney <michael.d.kinney@intel.com>,
 Zhiguang Liu <zhiguang.liu@intel.com>
References: <20210104225830.12606-1-rebecca@nuviainc.com>
 <20210104225830.12606-19-rebecca@nuviainc.com> <20210110020349.GD1664@vanye>
From: "Rebecca Cran" <rebecca@nuviainc.com>
Message-ID: <2c20aed2-a476-8467-5cc4-16e2955eb6cf@nuviainc.com>
Date: Tue, 12 Jan 2021 16:22:45 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <20210110020349.GD1664@vanye>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 1/9/21 7:03 PM, Leif Lindholm wrote:
> On Mon, Jan 04, 2021 at 15:58:25 -0700, Rebecca Cran wrote:

>> +//
>> +// Data Table Array Entries
>> +//
>> +extern UINTN   mSmbiosMiscDataTableEntries;
>> +extern UINT8   SmbiosMiscDxeStrings[];
> 
> Also needs m prefix.

This identifier comes from the file name, so I don't think it's 
something I can change.

-- 
Rebecca Cran