From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120])
 by mx.groups.io with SMTP id smtpd.web11.1561.1591113108349465590
 for <devel@edk2.groups.io>;
 Tue, 02 Jun 2020 08:51:48 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XSEx4eg8;
 spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1591113107;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8Mk3vYcO+oLXBdqG0aXInH6DCO0fvTG6DiR294vtPOI=;
	b=XSEx4eg81lnySy1SbL8m+s4KUA71gCl+0O8QOLwVhCV+pPUgNp/x2MNiJ9QVgTHL8aiema
	+tHaYJg+I+JxZRFI0GvwhULNulaT5G4E2jNJyeR9VAX5Vbf4EMXDvlykEpZCmouBzWe50q
	/X8zokSdQtmMhQqjPUa1E2KnNS/WMBY=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-287-N5w_3QasNyWnMPmEi3q-9g-1; Tue, 02 Jun 2020 11:51:43 -0400
X-MC-Unique: N5w_3QasNyWnMPmEi3q-9g-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E584D872FE1;
	Tue,  2 Jun 2020 15:51:41 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-66.ams2.redhat.com [10.36.115.66])
	by smtp.corp.redhat.com (Postfix) with ESMTP id D2CFA10013C1;
	Tue,  2 Jun 2020 15:51:40 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v4 07/14] ArmVirtPkg: Add VariablePolicy engine to ArmVirtPkg platform
To: devel@edk2.groups.io, bret@corthon.com
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>, Leif Lindholm <leif@nuviainc.com>
References: <20200601163310.1718-1-brbarkel@microsoft.com>
 <20200601163310.1718-8-brbarkel@microsoft.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <2c2c2c5e-22ff-976e-f837-f3b6726f62e7@redhat.com>
Date: Tue, 2 Jun 2020 17:51:39 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200601163310.1718-8-brbarkel@microsoft.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 06/01/20 18:33, Bret Barkelew wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2522
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Bret Barkelew <brbarkel@microsoft.com>
> Signed-off-by: Bret Barkelew <brbarkel@microsoft.com>
> ---
>  ArmVirtPkg/ArmVirt.dsc.inc | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index cf44fc73890b..0af6d839cf11 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -2,6 +2,7 @@
>  #  Copyright (c) 2011-2015, ARM Limited. All rights reserved.
>  #  Copyright (c) 2014, Linaro Limited. All rights reserved.
>  #  Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.
> +#  Copyright (c) Microsoft Corporation.
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -173,6 +174,8 @@ [LibraryClasses.common]
>    AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>  !endif
>    VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
> +  VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
> +  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>    UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
>  
>    ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseReportStatusCodeLibNull.inf
> @@ -246,6 +249,7 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER]
>  !if $(TARGET) != RELEASE
>    DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
>  !endif
> +  VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
>  
>  !if $(SECURE_BOOT_ENABLE) == TRUE
>    BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks,
Laszlo