public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Dandan Bi <dandan.bi@intel.com>, edk2-devel@ml01.01.org
Cc: Jordan Justen <jordan.l.justen@intel.com>,
	Liming Gao <liming.gao@intel.com>
Subject: Re: [PATCH v2] OvmfPkg: Fix VS toolchain build failure
Date: Thu, 22 Sep 2016 03:37:32 +0200	[thread overview]
Message-ID: <2c418c23-61e9-6d02-dfac-5df5da8e81cd@redhat.com> (raw)
In-Reply-To: <1474507298-106676-1-git-send-email-dandan.bi@intel.com>

On 09/22/16 03:21, Dandan Bi wrote:
> V2: add the assert codes.
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  OvmfPkg/VirtioGpuDxe/Commands.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/VirtioGpuDxe/Commands.c b/OvmfPkg/VirtioGpuDxe/Commands.c
> index b369dc3..962087c 100644
> --- a/OvmfPkg/VirtioGpuDxe/Commands.c
> +++ b/OvmfPkg/VirtioGpuDxe/Commands.c
> @@ -282,16 +282,17 @@ VirtioGpuSendCommand (
>    }
>    Header->CtxId     = 0;
>    Header->Padding   = 0;
>  
>    ASSERT (RequestSize >= sizeof *Header);
> +  ASSERT (RequestSize <= MAX_UINT32);
>  
>    //
>    // Compose the descriptor chain.
>    //
>    VirtioPrepare (&VgpuDev->Ring, &Indices);
> -  VirtioAppendDesc (&VgpuDev->Ring, (UINTN)Header, RequestSize,
> +  VirtioAppendDesc (&VgpuDev->Ring, (UINTN)Header, (UINT32)RequestSize,
>      VRING_DESC_F_NEXT, &Indices);
>    VirtioAppendDesc (&VgpuDev->Ring, (UINTN)&Response, sizeof Response,
>      VRING_DESC_F_WRITE, &Indices);
>  
>    //
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


  reply	other threads:[~2016-09-22  1:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-22  1:21 [PATCH v2] OvmfPkg: Fix VS toolchain build failure Dandan Bi
2016-09-22  1:37 ` Laszlo Ersek [this message]
2016-09-22  1:38   ` Laszlo Ersek
2016-09-22  2:33     ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c418c23-61e9-6d02-dfac-5df5da8e81cd@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox