Re: [edk2-devel] Fixing edk2-basetools CI

["Rebecca Cran via groups.io" <rebecca=os.amperecomputing.com@groups.io>]

On 2/12/2024 9:08 AM, Joey Vagedes via groups.io wrote:
> Hello. It can be simplified - You can view the pyproject.toml for edk2-pytool-library and edk2-pytool-extensions:
> 
> https://github.com/tianocore/edk2-pytool-library/blob/master/pyproject.toml
> 
> Also, Why disable flake8 rather than fix the changes? I also suggest switching to ruff, as it does the same thing but better, and with way more rules / configuration options.

Thanks. I'm not sure that looks so much simpler than my pyproject.toml 
but I'll update it to follow the same layout. Also, pyproject.toml says 
it's using the setuptools build backend but you don't have a setup.py: 
how does that work?

I decided to disable flake8 for now because the BaseTools Python code is 
very non-compliant: the log file has over 41,000 lines. In most places 
it looks like people have been trying to write it as C code.

A few of the lines:

.\edk2basetools\Common\TargetTxtClassObject.py:44:80: E203 whitespace 
before ':'
.\edk2basetools\Common\TargetTxtClassObject.py:61:14: E111 indentation 
is not a multiple of 4
.\edk2basetools\Common\TargetTxtClassObject.py:61:14: E117 over-indented
.\edk2basetools\Common\TargetTxtClassObject.py:63:50: F405 
'FILE_NOT_FOUND' may be undefined, or defined from star imports: 
.BuildToolError
.\edk2basetools\Common\TargetTxtClassObject.py:73:121: E501 line too 
long (123 > 120 characters)
.\edk2basetools\Common\TargetTxtClassObject.py:84:38: F405 
'FILE_OPEN_FAILURE' may be undefined, or defined from star imports: 
.BuildToolError
.\edk2basetools\Common\TargetTxtClassObject.py:100:108: E502 the 
backslash is redundant between brackets
.\edk2basetools\Common\TargetTxtClassObject.py:108:121: E501 line too 
long (139 > 120 characters)
.\edk2basetools\Common\TargetTxtClassObject.py:118:121: E501 line too 
long (140 > 120 characters)
.\edk2basetools\Common\TargetTxtClassObject.py:123:97: E502 the 
backslash is redundant between brackets
.\edk2basetools\Common\TargetTxtClassObject.py:128:21: F841 local 
variable 'V' is assigned to but never used


-- 
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115360): https://edk2.groups.io/g/devel/message/115360
Mute This Topic: https://groups.io/mt/104306226/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-