From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D75047803E0 for ; Mon, 12 Feb 2024 16:42:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=8PutwSla7asKEVZObZ9+cb7PVoxSZYNj2WCjZAochqo=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707756145; v=1; b=xN/3R3cORUjvKazNNXkBHKa5VKMCtU7gQ5I1SjMv+4IXQLt7gxEzb8wLIHIrbc8TdVZylrgB hhf+fQOIJG2Wi7cdcM+ys+flMYYtvsjcHFdDkvAwWN61WSyt4k8kgHbJQF38Eufs09oKAiamC/l ycNXaiqPTdVuPMNJ07roiKKk= X-Received: by 127.0.0.2 with SMTP id vxwhYY7687511xq1CCOEpbKb; Mon, 12 Feb 2024 08:42:25 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.100]) by mx.groups.io with SMTP id smtpd.web11.11176.1707756144838726150 for ; Mon, 12 Feb 2024 08:42:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hz3gGNubQ6Pt4KnDE/mrFVf7wZkUIJhwJ+VaxtRFhWCKWklLDQL7/WvH9q1rm8TIeJJy37JZ60rWrO8+PQznFxoz7Fus9YfhlIPo1aN7GYHryTcshR33RbMLa4l5ipQwvs+ZvAAKMj3IXD0iQiTzu5KT1JI5mA6DM+M9OPkXFqoowbUYwM1rxTL7Y7DHzerl6Oc/t4HtjaXxDA6z6IIoBmeWvQxAB1hfNZFZ+VAN3xxxmJswm7gRjXFxAA9PZ4pBdWf1PmOHClvTYZnvDTUaWA8gN1OUY80L7Qw5+TFWTiWkQBDJymjeAJgC7bxOv5JUiSQBcdC6wtK0QYlewzYZ9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pia2XT17yOYFDIvtolpoEryXvPoooFPwhcF+xcALoYA=; b=ljLUqMp5oHdLM4GYrL9nyjT/kIH6M0aUCWFD5clCAoSAqLT7yHFqes+nZsYIa+Ww29XNTmjg2DGLUk6DZ4trOgc8lLANDiKMtvpu6UykomU/CVw7bxATjln4iQz6dBEJcTV8mYBYVdpdr9at9Kd7mhh0SFyPENfAdMAH8d719H2549X+4HYOfAsNc7NIh0T/kdvRHV5teWzjjw+9ZiTVxzKE3Q8h9N3jW0EEmBQj7MxXUvf7zuDJqRsCF4RMviw0xCZDdb2l7zMGWm5tyHpGhSCbgUL4CJcz9scB63EUE78IFfb265p3Il1IGDONMC7EMZBN8+lsAmRJ9fwrMDCgOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) by SA0PR01MB6171.prod.exchangelabs.com (2603:10b6:806:e5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.38; Mon, 12 Feb 2024 16:42:22 +0000 X-Received: from LV3PR01MB8464.prod.exchangelabs.com ([fe80::7748:d4a3:bcd9:14c1]) by LV3PR01MB8464.prod.exchangelabs.com ([fe80::7748:d4a3:bcd9:14c1%6]) with mapi id 15.20.7270.033; Mon, 12 Feb 2024 16:42:22 +0000 Message-ID: <2c52fbac-dbe1-423a-a9d7-0bbe473cd9e9@os.amperecomputing.com> Date: Mon, 12 Feb 2024 09:42:18 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] Fixing edk2-basetools CI To: devel@edk2.groups.io, joeyvagedes@microsoft.com, Rebecca Cran , "Kinney, Michael D" , Sean , Michael Kubacki References: <2fe83108-e19b-4c95-8c45-08f43594e8cd@bsdio.com> From: "Rebecca Cran via groups.io" In-Reply-To: X-ClientProxiedBy: CH2PR11CA0023.namprd11.prod.outlook.com (2603:10b6:610:54::33) To LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR01MB8464:EE_|SA0PR01MB6171:EE_ X-MS-Office365-Filtering-Correlation-Id: 6a30d624-1a75-4749-242b-08dc2be995b3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: VrnTbhaNuP03nKP+Gm7ZVCXO3wkIlTEPybbX/tec0cHUaYu00ybSLduG8mDXZ6N3kUe1+ROVxC5k/FmWk1DPwRRERu5QwcZ6/FWSTLHSMY9aXPdSVAv4S+In745Wbqih709z1in8t7tRy+Og39c6hvobmx7YIT2D9LOpppDwBMt7mn+FXWWA2aZ3ja00y19XqcgudF1o88ZaArW//8PodpjNvmH07zSZvShSn9NFzFNPqqwVEtO2pEpR05lU3VBoUcQzRIeTHt42e/QeaePFXIGSkTb9qvMo5H420DY6Px0Rn0CL/t+Ojk6XSOviv3Gfbok9LWpJ/6W2rqpSdIqJ9hTQ9FmqGivfGygYWOWpkbN/lyEbvVIrTcfAKFCBG2UV8deZJbAwsZYMrrdsN8/UButF3v/oDcX9Ffnu9iGGE1D/rn3kQuQLgK3EhUN5JAF3IMtsuHKZY1zEKSav7KSKYDvt0QD/4YtebVbHHf2Jl/IU8Scq0hXwOpCLiDoUlSwhsTzOlYoMArv1PuAiBAYQBl0PqEXZ7E3r7CZXxzvQJW0= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjVEdTcxUDI2aFZ4UzdGdnY4VlRQQzNkTjNCd3dBdC9GdDJBeHBrK1pldlBl?= =?utf-8?B?Snd3TVNXU2NLSThDaS9tek9BcWw4ZjdyQlpHbVNpdCtTNG1sbEpBa3NCeTR6?= =?utf-8?B?SlBmNXpRWEYrU2hYc3RJRDI4L2xybU4wZTFaWVZCeG9Vb201Q3NYb0RUSDQw?= =?utf-8?B?YjY0ckxnejB6aDhlQ2J5UElJRndxNE1IK1I5Y0dKQXB1WFRPSG1VYzdMYmdV?= =?utf-8?B?QXZrbmVJN3A3TlRDbUxHb00vMEdEYmdyd05GcGNpVTlhakZKekl1dUErbTV5?= =?utf-8?B?L0xHOENzUDRMVllKeDZoN1Bud0lrRTExdjRvcHhuaDlNaVlHbGZKeXdnQ29S?= =?utf-8?B?Wmg5QnZYQXNPWERGQ2k5V3lLb3N5ejRDTXRHNndsczFQR0lJRGUvc3dJL3hM?= =?utf-8?B?U3l2dDVtaXRKZ2xRWmd1UFUvNlpHaGE3THRQM2E0Vjc5cnlHTDFaRmdpb1BH?= =?utf-8?B?SlVvS2xUaUxUYkRyb3IzRjhrOFdwMXFuWWF1RmFkamNFYTUyR1c1NjVqR0lE?= =?utf-8?B?bFg4RXNNVWhsUWl3dmpkcFJSUk5kYktubjF0dWRIVkEwNTlmNGg3eUpPY2lO?= =?utf-8?B?L21tMkYrMFFibHUyZWsxck00T3RZVjRvd09ySkljeDRhN3NyOFloNGVXZ0ZQ?= =?utf-8?B?UmJHRCtWRFJyMUZZbCtVdG4yU0VEem5UbkkzRWRFZFRMNkNwVzJOM3BXWVAw?= =?utf-8?B?ZktPdU9kMW1wRSsyNnREVFNsa2pIZUd3MG5SbXVVVVNPRHA5TUVpekhNY0s0?= =?utf-8?B?S0hIb0dndlorWlpONnpzSzlXQUUxRk1TOHhHejZVTlNHK1RZWllpbDVnWllo?= =?utf-8?B?YksrOHV6eE8yVGgrZ3lGVTJtQkFSMWZtZGlVVnUzL1JGaTdGSlJlT1hpTE5T?= =?utf-8?B?VXFPc2Z0SWNoOGRjTGw5YmNwaEtJQnN2eVZZTVdVN2xvSXYxUUQxTjFNS08x?= =?utf-8?B?QlNYYmJNMFNHd3FDZi90VWlNQktNbXg2MEVVV09SUUM3L1NaKzdQOVhXbC92?= =?utf-8?B?OEJqU3NqejlIeW50dnhwKzlMQ3haUVJhL0pQbjdwSmdkaUJsNXgwK1RiYWhO?= =?utf-8?B?ckJmTm1RWlhFWm5nODh1RFU5eW12QWRJWjZzU0dNN3FmYUpMdTBPcWFUQzlS?= =?utf-8?B?aVpXNFh6TnBLeDVtblNTVDZDNEdjd3hjNUQ3d2JvRVlBa1BOTEFGa09sR3dM?= =?utf-8?B?ZU1EeDk5NnFYYkMwWHgzOGxhR2x1c1BPNE0rdmNIZnVFclowSEhBOHhHbzBJ?= =?utf-8?B?UW1FNDZmeVAxNDk0ZHVZYlFxY01ObklKM3hJUUlXb251Q3VQVHQ4QlA0cS80?= =?utf-8?B?SkJoeG0vbFB2cFJmZHY2UkluRnJacE9kK2ZaUWxvQnc4VW52WTZVWktmNmNR?= =?utf-8?B?V0pscDBueWdtS3dmUWtway9ZSDR2ZzlQWG1iczFJODArRVBlY2ZiTk02bXVS?= =?utf-8?B?V2c0TW5WVGw4Z2ZLOWxiTWNUSVV1RlRrMWlTaWpMemlhY3VFVXhXTEVpSlBh?= =?utf-8?B?cXkxZ1FRQkhRQ3NXRWNxWHIxemoyN2ZiS0kyTDNUd0xnRSs0RzBqVmE3SUVG?= =?utf-8?B?Z1ZCOE9id2dPM0ZwMVFMcWNNalpZdS9URCtRUHp2aVAxRFpyVXdGQzRkcE13?= =?utf-8?B?anZ6UFpKaVNLTXlaV1lYbFVWeWNPN1RoLzMzTkQ5YS8zYXpaYkx0TWc1S2pj?= =?utf-8?B?Q0dSbGc5a3R5S2dZMFljZ1h5UWUvbldza1prZW9aTjNwd0pwY1Z5bFZaK0da?= =?utf-8?B?LzdHSWR4RHB6OWpuQWhaWGZWWTlaZWdIaDV4aEhuZU9MN2p1WUFWb0VTTWJX?= =?utf-8?B?bnA0Q29rNFZaNGpsZHBsQnhQYlFTdkFibEQ5elE2VURaeWk2eWJKN1ZSNEU1?= =?utf-8?B?RnpibWpsbk45TGZSL1lJV2tOT0V6VHRwSEVZbVM5Ky82TE5aSUUycDk1cUlJ?= =?utf-8?B?N0kweXBkOGRXVjlvNlJjTEFtU0pISGRjWjcxbnJ0NXJmUU9Iamo3emh6S0V0?= =?utf-8?B?dkYyWlZic3ZGVzE5bU0zVmQ5NnM3QnRvM0xXQ3NHaXVUZURNcExhNStGUXcw?= =?utf-8?B?WERqeVlVU3JhRW1ucGR4aDdWQVl5cW1SOWwxbUlUK0YxUXRGYXY3bGR6NGtp?= =?utf-8?B?eVVFN0lRdUJjajEwQm9idzFoMmFOdWwvRlMvVmg5cTVNdFYxWFNLcXhDQXZI?= =?utf-8?Q?X6jKSTjnFp91kSYOpJqFedc=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a30d624-1a75-4749-242b-08dc2be995b3 X-MS-Exchange-CrossTenant-AuthSource: LV3PR01MB8464.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2024 16:42:22.0128 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l/3+IKPw8U6Le+/NgpGwmgxlxrTPQv8TdEjYk+3tLq9jwb8TK9tEXIeqVr8y4whmqyc8SdlJ9GOdEc+SdpWNDihEy13nYjmm5OTlYg8yPfqewNIqj8IoTdoySLGgU3+a X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR01MB6171 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: QPBgdO4ZHrgv36rRmCb7nex0x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="xN/3R3cO"; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2/12/2024 9:08 AM, Joey Vagedes via groups.io wrote: > Hello. It can be simplified - You can view the pyproject.toml for edk2-py= tool-library and edk2-pytool-extensions: >=20 > https://github.com/tianocore/edk2-pytool-library/blob/master/pyproject.to= ml >=20 > Also, Why disable flake8 rather than fix the changes? I also suggest swit= ching to ruff, as it does the same thing but better, and with way more rule= s / configuration options. Thanks. I'm not sure that looks so much simpler than my pyproject.toml=20 but I'll update it to follow the same layout. Also, pyproject.toml says=20 it's using the setuptools build backend but you don't have a setup.py:=20 how does that work? I decided to disable flake8 for now because the BaseTools Python code is=20 very non-compliant: the log file has over 41,000 lines. In most places=20 it looks like people have been trying to write it as C code. A few of the lines: .\edk2basetools\Common\TargetTxtClassObject.py:44:80: E203 whitespace=20 before ':' .\edk2basetools\Common\TargetTxtClassObject.py:61:14: E111 indentation=20 is not a multiple of 4 .\edk2basetools\Common\TargetTxtClassObject.py:61:14: E117 over-indented .\edk2basetools\Common\TargetTxtClassObject.py:63:50: F405=20 'FILE_NOT_FOUND' may be undefined, or defined from star imports:=20 .BuildToolError .\edk2basetools\Common\TargetTxtClassObject.py:73:121: E501 line too=20 long (123 > 120 characters) .\edk2basetools\Common\TargetTxtClassObject.py:84:38: F405=20 'FILE_OPEN_FAILURE' may be undefined, or defined from star imports:=20 .BuildToolError .\edk2basetools\Common\TargetTxtClassObject.py:100:108: E502 the=20 backslash is redundant between brackets .\edk2basetools\Common\TargetTxtClassObject.py:108:121: E501 line too=20 long (139 > 120 characters) .\edk2basetools\Common\TargetTxtClassObject.py:118:121: E501 line too=20 long (140 > 120 characters) .\edk2basetools\Common\TargetTxtClassObject.py:123:97: E502 the=20 backslash is redundant between brackets .\edk2basetools\Common\TargetTxtClassObject.py:128:21: F841 local=20 variable 'V' is assigned to but never used --=20 Rebecca Cran -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115360): https://edk2.groups.io/g/devel/message/115360 Mute This Topic: https://groups.io/mt/104306226/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-