[edk2-devel][PATCH v2 0/3] Fix Runtime Granularity Issues

[edk2-devel][PATCH v2 0/3] Fix Runtime Granularity Issues

[Oliver Smith-Denny]

This patch series is the second version of
MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations​.
The subject line has been updated because this went from a one commit
patch with no cover letter to a multi-commit patch.

The commit messages cover the vast amount of detail here, but this
patchset fixes three issues:
- a UEFI spec violation for which memory types require runtime page
allocation granularity alignment
- An incompatibility of the heap guard system to guard these regions
that require runtime page allocation granularities greater than
the EFI_PAGE_SIZE.
- A CodeQL error that fails CI when updating the Page.c code

v2:
- Add commit to fix UEFI spec violation
- Add commit to fix newly flagged CodeQL error
- Update guard commit message, comments, and static assert to use
the correct types

Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>

Oliver Smith-Denny (3):
  MdeModulePkg: DxeCore: Fix CodeQL Error in FreePages
  MdeModulePkg: DxeCore: Correct Runtime Granularity Memory Type
  MdeModulePkg: DxeCore: Do Not Apply Guards to Unsupported Types

 MdeModulePkg/MdeModulePkg.dec                 | 10 +++++++++
 MdeModulePkg/Core/Dxe/Mem/HeapGuard.h         | 14 +++++++++++++
 MdeModulePkg/Core/Dxe/Mem/Page.c              | 22 +++++++++++++++++---
 MdeModulePkg/Core/Dxe/Mem/Pool.c              | 15 +++++++++++--
 MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c |  4 ++--
 MdeModulePkg/Core/Pei/Memory/MemoryServices.c |  2 +-
 6 files changed, 59 insertions(+), 8 deletions(-)

-- 
2.40.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115560): https://edk2.groups.io/g/devel/message/115560
Mute This Topic: https://groups.io/mt/104405577/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel][PATCH v2 0/3] Fix Runtime Granularity Issues

[Ard Biesheuvel]

On Sat, 17 Feb 2024 at 02:27, Oliver Smith-Denny
<osde@linux.microsoft.com> wrote:
>
> This patch series is the second version of
> MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations.
> The subject line has been updated because this went from a one commit
> patch with no cover letter to a multi-commit patch.
>
> The commit messages cover the vast amount of detail here, but this
> patchset fixes three issues:
> - a UEFI spec violation for which memory types require runtime page
> allocation granularity alignment
> - An incompatibility of the heap guard system to guard these regions
> that require runtime page allocation granularities greater than
> the EFI_PAGE_SIZE.
> - A CodeQL error that fails CI when updating the Page.c code
>
> v2:
> - Add commit to fix UEFI spec violation
> - Add commit to fix newly flagged CodeQL error
> - Update guard commit message, comments, and static assert to use
> the correct types
>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>
> Oliver Smith-Denny (3):
>   MdeModulePkg: DxeCore: Fix CodeQL Error in FreePages
>   MdeModulePkg: DxeCore: Correct Runtime Granularity Memory Type
>   MdeModulePkg: DxeCore: Do Not Apply Guards to Unsupported Types
>

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115727): https://edk2.groups.io/g/devel/message/115727
Mute This Topic: https://groups.io/mt/104405577/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel][PATCH v2 0/3] Fix Runtime Granularity Issues

[Oliver Smith-Denny]

Hi Liming,

Now that the stable tag is finished, can you review this MdeModulePkg patch?

Thanks,
Oliver

On 2/16/2024 5:27 PM, Oliver Smith-Denny wrote:
> This patch series is the second version of
> MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations​.
> The subject line has been updated because this went from a one commit
> patch with no cover letter to a multi-commit patch.
> 
> The commit messages cover the vast amount of detail here, but this
> patchset fixes three issues:
> - a UEFI spec violation for which memory types require runtime page
> allocation granularity alignment
> - An incompatibility of the heap guard system to guard these regions
> that require runtime page allocation granularities greater than
> the EFI_PAGE_SIZE.
> - A CodeQL error that fails CI when updating the Page.c code
> 
> v2:
> - Add commit to fix UEFI spec violation
> - Add commit to fix newly flagged CodeQL error
> - Update guard commit message, comments, and static assert to use
> the correct types
> 
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> 
> Oliver Smith-Denny (3):
>    MdeModulePkg: DxeCore: Fix CodeQL Error in FreePages
>    MdeModulePkg: DxeCore: Correct Runtime Granularity Memory Type
>    MdeModulePkg: DxeCore: Do Not Apply Guards to Unsupported Types
> 
>   MdeModulePkg/MdeModulePkg.dec                 | 10 +++++++++
>   MdeModulePkg/Core/Dxe/Mem/HeapGuard.h         | 14 +++++++++++++
>   MdeModulePkg/Core/Dxe/Mem/Page.c              | 22 +++++++++++++++++---
>   MdeModulePkg/Core/Dxe/Mem/Pool.c              | 15 +++++++++++--
>   MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c |  4 ++--
>   MdeModulePkg/Core/Pei/Memory/MemoryServices.c |  2 +-
>   6 files changed, 59 insertions(+), 8 deletions(-)
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115975): https://edk2.groups.io/g/devel/message/115975
Mute This Topic: https://groups.io/mt/104405577/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel][PATCH v2 0/3] Fix Runtime Granularity Issues

[Oliver Smith-Denny]

Hi Liming,

Friendly ping again, can you please review this? It fixes a UEFI
spec violation.

Thanks,
Oliver

On 2/26/2024 8:46 AM, Oliver Smith-Denny wrote:
> Hi Liming,
> 
> Now that the stable tag is finished, can you review this MdeModulePkg 
> patch?
> 
> Thanks,
> Oliver
> 
> On 2/16/2024 5:27 PM, Oliver Smith-Denny wrote:
>> This patch series is the second version of
>> MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity 
>> Allocations​.
>> The subject line has been updated because this went from a one commit
>> patch with no cover letter to a multi-commit patch.
>>
>> The commit messages cover the vast amount of detail here, but this
>> patchset fixes three issues:
>> - a UEFI spec violation for which memory types require runtime page
>> allocation granularity alignment
>> - An incompatibility of the heap guard system to guard these regions
>> that require runtime page allocation granularities greater than
>> the EFI_PAGE_SIZE.
>> - A CodeQL error that fails CI when updating the Page.c code
>>
>> v2:
>> - Add commit to fix UEFI spec violation
>> - Add commit to fix newly flagged CodeQL error
>> - Update guard commit message, comments, and static assert to use
>> the correct types
>>
>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>
>> Oliver Smith-Denny (3):
>>    MdeModulePkg: DxeCore: Fix CodeQL Error in FreePages
>>    MdeModulePkg: DxeCore: Correct Runtime Granularity Memory Type
>>    MdeModulePkg: DxeCore: Do Not Apply Guards to Unsupported Types
>>
>>   MdeModulePkg/MdeModulePkg.dec                 | 10 +++++++++
>>   MdeModulePkg/Core/Dxe/Mem/HeapGuard.h         | 14 +++++++++++++
>>   MdeModulePkg/Core/Dxe/Mem/Page.c              | 22 +++++++++++++++++---
>>   MdeModulePkg/Core/Dxe/Mem/Pool.c              | 15 +++++++++++--
>>   MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c |  4 ++--
>>   MdeModulePkg/Core/Pei/Memory/MemoryServices.c |  2 +-
>>   6 files changed, 59 insertions(+), 8 deletions(-)
>>
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116452): https://edk2.groups.io/g/devel/message/116452
Mute This Topic: https://groups.io/mt/104405577/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-