From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8A1D4D8002E for ; Mon, 26 Feb 2024 16:46:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=OKd17jZ6zFUpf8jdrEcw7IZWqYN2CFnb9iF/ldoEUVc=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708965984; v=1; b=qLGhHZ2GOE3gaTsTnaGWwcrX9Lbm9p5BfhAWHUcROFgqZ6oveRkPkPtpN51aZbCFzKDV2f0u A0u30di0FL6pvuWvOF6rv9cD7zCiOCj9SZ20LZkp/xd0Qukjhwakqdm9b2xuRDIGUxbhDc/lhdY PFWnfo/6DVjKX9n2gQxhFGqo= X-Received: by 127.0.0.2 with SMTP id sW6IYY7687511x2j1JeGwdO7; Mon, 26 Feb 2024 08:46:24 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.28889.1708965983427007883 for ; Mon, 26 Feb 2024 08:46:23 -0800 X-Received: from [10.137.194.171] (unknown [131.107.160.171]) by linux.microsoft.com (Postfix) with ESMTPSA id D6EEE20B74C0; Mon, 26 Feb 2024 08:46:22 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D6EEE20B74C0 Message-ID: <2c5f92c0-c7bd-4575-859e-43f2617befc2@linux.microsoft.com> Date: Mon, 26 Feb 2024 08:46:22 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel][PATCH v2 0/3] Fix Runtime Granularity Issues From: "Oliver Smith-Denny" To: devel@edk2.groups.io, Liming Gao Cc: Leif Lindholm , Ard Biesheuvel , Sami Mujawar , Liming Gao Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com References: <17B4822428B54117.28679@groups.io> In-Reply-To: <17B4822428B54117.28679@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4sk6TlFsZnH41oEqWZPxawDcx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=qLGhHZ2G; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none) Hi Liming, Now that the stable tag is finished, can you review this MdeModulePkg patch= ? Thanks, Oliver On 2/16/2024 5:27 PM, Oliver Smith-Denny wrote: > This patch series is the second version of > MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations= =E2=80=8B. > The subject line has been updated because this went from a one commit > patch with no cover letter to a multi-commit patch. >=20 > The commit messages cover the vast amount of detail here, but this > patchset fixes three issues: > - a UEFI spec violation for which memory types require runtime page > allocation granularity alignment > - An incompatibility of the heap guard system to guard these regions > that require runtime page allocation granularities greater than > the EFI_PAGE_SIZE. > - A CodeQL error that fails CI when updating the Page.c code >=20 > v2: > - Add commit to fix UEFI spec violation > - Add commit to fix newly flagged CodeQL error > - Update guard commit message, comments, and static assert to use > the correct types >=20 > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Liming Gao >=20 > Oliver Smith-Denny (3): > MdeModulePkg: DxeCore: Fix CodeQL Error in FreePages > MdeModulePkg: DxeCore: Correct Runtime Granularity Memory Type > MdeModulePkg: DxeCore: Do Not Apply Guards to Unsupported Types >=20 > MdeModulePkg/MdeModulePkg.dec | 10 +++++++++ > MdeModulePkg/Core/Dxe/Mem/HeapGuard.h | 14 +++++++++++++ > MdeModulePkg/Core/Dxe/Mem/Page.c | 22 +++++++++++++++++--- > MdeModulePkg/Core/Dxe/Mem/Pool.c | 15 +++++++++++-- > MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 4 ++-- > MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 2 +- > 6 files changed, 59 insertions(+), 8 deletions(-) >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115975): https://edk2.groups.io/g/devel/message/115975 Mute This Topic: https://groups.io/mt/104405577/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-