Re: [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Clean up useless parameter.

["Laszlo Ersek" <lersek@redhat.com>]

On 08/08/19 15:24, Eric Dong wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2060
> 
> Remove the useless parameter.
> 
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> ---
>  UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c
> index d20bc4aae6..d8c6b19ead 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c
> @@ -35,7 +35,6 @@ typedef struct {
>  // Flags used when program the register.
>  //
>  typedef struct {
> -  volatile UINTN           ConsoleLogLock;          // Spinlock used to control console.
>    volatile UINTN           MemoryMappedLock;        // Spinlock used to program mmio
>    volatile UINT32          *CoreSemaphoreCount;     // Semaphore container used to program
>                                                      // core level semaphore.
> @@ -1028,7 +1027,6 @@ GetAcpiCpuData (
>      ASSERT (mCpuFlags.PackageSemaphoreCount != NULL);
>    }
>    InitializeSpinLock((SPIN_LOCK*) &mCpuFlags.MemoryMappedLock);
> -  InitializeSpinLock((SPIN_LOCK*) &mCpuFlags.ConsoleLogLock);
>  }
>  
>  /**
> 

Same comment as for patch #1. With that fixed:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo