From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 08 Aug 2019 13:15:45 -0700 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3602C7BDDA; Thu, 8 Aug 2019 20:15:45 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-122.ams2.redhat.com [10.36.117.122]) by smtp.corp.redhat.com (Postfix) with ESMTP id 690E219C69; Thu, 8 Aug 2019 20:15:44 +0000 (UTC) Subject: Re: [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Clean up useless parameter. To: Eric Dong , devel@edk2.groups.io Cc: Ray Ni References: <20190808132442.33936-1-eric.dong@intel.com> <20190808132442.33936-3-eric.dong@intel.com> From: "Laszlo Ersek" Message-ID: <2c6eb330-e3cd-8463-a236-ae1d93d0a938@redhat.com> Date: Thu, 8 Aug 2019 22:15:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190808132442.33936-3-eric.dong@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 08 Aug 2019 20:15:45 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/08/19 15:24, Eric Dong wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2060 > > Remove the useless parameter. > > Signed-off-by: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > --- > UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c > index d20bc4aae6..d8c6b19ead 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c > @@ -35,7 +35,6 @@ typedef struct { > // Flags used when program the register. > // > typedef struct { > - volatile UINTN ConsoleLogLock; // Spinlock used to control console. > volatile UINTN MemoryMappedLock; // Spinlock used to program mmio > volatile UINT32 *CoreSemaphoreCount; // Semaphore container used to program > // core level semaphore. > @@ -1028,7 +1027,6 @@ GetAcpiCpuData ( > ASSERT (mCpuFlags.PackageSemaphoreCount != NULL); > } > InitializeSpinLock((SPIN_LOCK*) &mCpuFlags.MemoryMappedLock); > - InitializeSpinLock((SPIN_LOCK*) &mCpuFlags.ConsoleLogLock); > } > > /** > Same comment as for patch #1. With that fixed: Reviewed-by: Laszlo Ersek Thanks! Laszlo