From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 10F8CD80A07 for ; Tue, 16 Apr 2024 07:38:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=XEtPrqZ9o/IM1PRljPCArvWyxukTwOEXfNPnkumqjSA=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:Organization:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713253137; v=1; b=kCNbh5gBwFjdeOzxqipZBw5EVT8/74QwzKnmA6AI/RE60oitkMIrWNfOSwbl0jZ4jg8c2ljy ioxyE2MTPmap7BhgAQSpb8UX72KUFcXVxoEgKqXGGCPTexOoJeBnLZ9uNvCryAZn816zHO20kQC G9DGOavS1GwKkcWRSN6FCJ1SNuHwuAzoBhjStgn8Qf39ydqEYteN/FgumOp2+U2jjHlZm/R3d/S PrkfwIbaS1e6gciZtc5oOBRMigdufiV2+b5qLhTAhTDkpAu19OtVQ2EA8oxHspn8kWkrOPHdwRI GNdj2gCVIEdRQVBXCPC09wuFZzQ1XDGvLe4407oe1Zy6g== X-Received: by 127.0.0.2 with SMTP id qheIYY7687511xE3oXDWO7x3; Tue, 16 Apr 2024 00:38:57 -0700 X-Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by mx.groups.io with SMTP id smtpd.web11.14752.1713253136803732273 for ; Tue, 16 Apr 2024 00:38:57 -0700 X-Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2d82713f473so72127231fa.3 for ; Tue, 16 Apr 2024 00:38:56 -0700 (PDT) X-Gm-Message-State: u5H8LD26Yt3OcxTAqGjJk63Xx7686176AA= X-Google-Smtp-Source: AGHT+IHWmMxCZcfSPQUwpmPW/atLKgL38M/M4veHJ1x/vkIwBSb7bgSCHXIG0n8ylcTxJatb/tFMZg== X-Received: by 2002:a2e:97d4:0:b0:2d8:41c5:ad64 with SMTP id m20-20020a2e97d4000000b002d841c5ad64mr8363183ljj.13.1713253134167; Tue, 16 Apr 2024 00:38:54 -0700 (PDT) X-Received: from [192.168.200.106] (83.11.0.31.ipv4.supernova.orange.pl. [83.11.0.31]) by smtp.gmail.com with ESMTPSA id wn5-20020a170907068500b00a4df061728fsm6459788ejb.83.2024.04.16.00.38.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Apr 2024 00:38:53 -0700 (PDT) Message-ID: <2c74b069-e815-4304-a98e-0d02cba7974e@linaro.org> Date: Tue, 16 Apr 2024 09:38:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] ACPI table generators and ConfigurationManagerProtocol To: devel@edk2.groups.io References: <178C31CFE9B284CD.5378@groups.io> <17C588EF15E93250.19773@groups.io> From: "Marcin Juszkiewicz" Organization: Linaro In-Reply-To: <17C588EF15E93250.19773@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 16 Apr 2024 00:38:57 -0700 Resent-From: marcin.juszkiewicz@linaro.org Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: pl-PL, en-GB, en-HK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=kCNbh5gB; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none) W dniu 12.04.2024 o 14:43, Marcin Juszkiewicz via groups.io pisze: > W dniu 8.10.2023 o 19:25, Marcin Juszkiewicz via groups.io pisze: > > I hate replying to myself after half a year of not seeing any answer. So > added some people from repo to Cc: > >> Can someone point me to documentation on how to use ACPI table >> generators and ConfigurationManagerProtocol? > > https://github.com/tianocore/edk2/blob/master/DynamicTablesPkg/Readme.md > tells the story and points to presentation from 2018 with some pictures > in it. > > Looks like the only documentation is the code itself. Is checkout of > some old tree and looking change by change how it was done on some > platform the easiest way to find out how to use it? > The more I look at */ConfigurationManager.[ch] the more I do not like > the amount of static structures there. All those > EDKII_PLATFORM_REPOSITORY_INFO covering 1000 lines looks like "how the > hell I will find what to change in other piece of code". > > Any doc pointers? Recommendations (other than "change your job")? I have spent two days on trying ConfigurationManager and finally gave up. The idea behind may look interesting but implementation of it is terrible. And there is no documentation for it. Edk2_Platform_Repo_Info struct full of other structs can be one thousand lines long. Then are functions to query those structs - which can take almost another thousand lines. For hardware where amount of system components is known and does not change it may be tempting. For those like sbsa-ref/QemuSbsa it means extra code to fill struct of structs with hardware details (cpu nodes, gic nodes, cpu topology/hierarchy/cache info etc). So I am going back to how "my" platform is done. Probably will learn AmlLib to create DSDT from C code. And if someone considers using ConfigurationManager for their platform: please reconsider it as it may not be worth your time. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117856): https://edk2.groups.io/g/devel/message/117856 Mute This Topic: https://groups.io/mt/105481311/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-