Re: [PATCH v2 0/2] ShellPkg: Document the use of EFI_INVALID_PARAMETER by two functions

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

Hi Zhichao,

On 1/7/20 8:37 AM, Gao, Zhichao wrote:
>> -----Original Message-----
>> From: Philippe Mathieu-Daudé [mailto:philmd@redhat.com]
>> Sent: Tuesday, January 7, 2020 3:10 PM
>> To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
>> Cc: Ni, Ray <ray.ni@intel.com>
>> Subject: Re: [PATCH v2 0/2] ShellPkg: Document the use of
>> EFI_INVALID_PARAMETER by two functions
>>
>> On 1/7/20 8:01 AM, Gao, Zhichao wrote:
>>>> -----Original Message-----
>>>> From: Philippe Mathieu-Daude <philmd@redhat.com>
>>>> Sent: Thursday, December 19, 2019 10:10 PM
>>>> To: devel@edk2.groups.io
>>>> Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
>>>> Philippe Mathieu-Daude <philmd@redhat.com>
>>>> Subject: [PATCH v2 0/2] ShellPkg: Document the use of
>>>> EFI_INVALID_PARAMETER by two functions
>>>>
>>>> Complete the list of values the functios ParseCommandLineToArgs() and
>>>> UpdateArgcArgv() can return.
>>>>
>>>> The documentation was found to be incomplete while reviewing BZ#2395:
>>>> https://edk2.groups.io/g/devel/message/51512
>>>>
>>>> v2:
>>>> - Shortened patch #1 subject to fit 72 chars
>>>
>>> The subject should be less than 72 chars (do not include 72 chars).
>>
>> What is the rationale for this restriction? Some tool limitation?
> 
> Yes. There is a patch check tool in BaseTools\Scripts\ PatchCheck.py. And the patch #1 can't pass the check.

Since the patch "BaseTools/PatchCheck.py: Ignore CR and LF characters in 
subject length" got merged as commit 2649a735b24, can you retry to merge 
this patch?

Thanks,

Phil.