From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web09.10074.1579605872333860778 for ; Tue, 21 Jan 2020 03:24:32 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LkT1InVT; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579605871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1m/0IXFr73Gz6ksQR2jQT89LA3glraYOfzFkeAUpfnc=; b=LkT1InVTFmWkHb1KhF0rLuxU7fxH1VctzO3M50ag2oa1rZ2KJsLEEcOc4GbQCTRfKwf3Yu msdb/Z+7B13Ew5o12MKBGf2x3TuriW1JHIp6VqaQJsxExnJDIMPcAt3k+eJ0pVBnhnqDQn p1rdpB74Vs+ByoQnNQw2YFupBa8Oams= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-161-ChXgckDfOQyFVqcGPirjKw-1; Tue, 21 Jan 2020 06:24:29 -0500 Received: by mail-wm1-f71.google.com with SMTP id m133so328898wmf.2 for ; Tue, 21 Jan 2020 03:24:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=r0PnPn7A8r6Ar1SfskQIz5EXrwDQhge5PlBfd5BwoG4=; b=XUmFGBFlnJrr41jRgcK76boE/95CMCqcFeqTDe1YgBNrLjEzS/r5x6oIdRVcwgZwz/ ngsFk9RsRCGG/R2ZYQT0+ZDScrcJr/iaMi3nzchJVI4ErX4zWE1tj5JKxFd1GLeel2v3 LL8VZYDN+azaIikmauBuxdCPMfBxCIprfYvARGyVOmYZv9nifkr5yB7G4qd2fZUibeHp gGOAJmPWV0Ioiok/MqF1RM7gjBBT6iRIh+57Vj2xamQXyHf8NS5GVG5a47erV4Bek8zH Tm9x7S9OMebemIWU9ZLoyit3kQu8cXQCvJOJNUVICrauK+cSUsZuh8NMqb3LpCoOu0d6 +mnw== X-Gm-Message-State: APjAAAVqIO6AKLcmNWl4qKSCboXfXPdi6wpNaGEQ9iHVxzldr+dB7KDh VaV0D4WAi9KzYghkuc/qazf4MvQvwpF25DrSkf/XxnzDTGLyGGGAEfnLj8oKlCFSH1m0Yw4qQxH 8iHEr+cZLW49+lA== X-Received: by 2002:a7b:c114:: with SMTP id w20mr4003676wmi.151.1579605868272; Tue, 21 Jan 2020 03:24:28 -0800 (PST) X-Google-Smtp-Source: APXvYqysFbFAQI3NLXSEjBdcA7F0BBqeXRkccV5OKNE4s/wpvAo0Xum94wwASbpcEN9CIeeNkKH2OQ== X-Received: by 2002:a7b:c114:: with SMTP id w20mr4003653wmi.151.1579605867973; Tue, 21 Jan 2020 03:24:27 -0800 (PST) Return-Path: Received: from [192.168.1.35] (113.red-83-57-172.dynamicip.rima-tde.net. [83.57.172.113]) by smtp.gmail.com with ESMTPSA id h2sm55754351wrt.45.2020.01.21.03.24.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jan 2020 03:24:27 -0800 (PST) Subject: Re: [PATCH v2 0/2] ShellPkg: Document the use of EFI_INVALID_PARAMETER by two functions To: "Gao, Zhichao" , "devel@edk2.groups.io" Cc: "Ni, Ray" References: <20191219140932.25428-1-philmd@redhat.com> <3CE959C139B4C44DBEA1810E3AA6F9000B8BF8A5@SHSMSX101.ccr.corp.intel.com> <692bf71f-dd33-d8db-914c-2867845434ac@redhat.com> <3CE959C139B4C44DBEA1810E3AA6F9000B8BF8E2@SHSMSX101.ccr.corp.intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <2c83fb1c-3080-bd31-6408-fb29cb51de75@redhat.com> Date: Tue, 21 Jan 2020 12:24:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B8BF8E2@SHSMSX101.ccr.corp.intel.com> X-MC-Unique: ChXgckDfOQyFVqcGPirjKw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Zhichao, On 1/7/20 8:37 AM, Gao, Zhichao wrote: >> -----Original Message----- >> From: Philippe Mathieu-Daud=C3=A9 [mailto:philmd@redhat.com] >> Sent: Tuesday, January 7, 2020 3:10 PM >> To: Gao, Zhichao ; devel@edk2.groups.io >> Cc: Ni, Ray >> Subject: Re: [PATCH v2 0/2] ShellPkg: Document the use of >> EFI_INVALID_PARAMETER by two functions >> >> On 1/7/20 8:01 AM, Gao, Zhichao wrote: >>>> -----Original Message----- >>>> From: Philippe Mathieu-Daude >>>> Sent: Thursday, December 19, 2019 10:10 PM >>>> To: devel@edk2.groups.io >>>> Cc: Ni, Ray ; Gao, Zhichao ; >>>> Philippe Mathieu-Daude >>>> Subject: [PATCH v2 0/2] ShellPkg: Document the use of >>>> EFI_INVALID_PARAMETER by two functions >>>> >>>> Complete the list of values the functios ParseCommandLineToArgs() and >>>> UpdateArgcArgv() can return. >>>> >>>> The documentation was found to be incomplete while reviewing BZ#2395: >>>> https://edk2.groups.io/g/devel/message/51512 >>>> >>>> v2: >>>> - Shortened patch #1 subject to fit 72 chars >>> >>> The subject should be less than 72 chars (do not include 72 chars). >> >> What is the rationale for this restriction? Some tool limitation? >=20 > Yes. There is a patch check tool in BaseTools\Scripts\ PatchCheck.py. And= the patch #1 can't pass the check. Since the patch "BaseTools/PatchCheck.py: Ignore CR and LF characters in=20 subject length" got merged as commit 2649a735b24, can you retry to merge=20 this patch? Thanks, Phil.