From: "Laszlo Ersek" <lersek@redhat.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Sean Brogan <sean.brogan@microsoft.com>,
Andrew Fish <afish@apple.com>
Subject: Re: [Patch v3 02/22] .gitignore: Ignore python compiled files, extdeps, and vscode
Date: Thu, 31 Oct 2019 10:02:02 +0100 [thread overview]
Message-ID: <2cc7ef74-771d-0a71-bb94-094b8b1b5b86@redhat.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9DF8CA5@ORSMSX113.amr.corp.intel.com>
On 10/31/19 05:43, Kinney, Michael D wrote:
> Leif,
>
> Thanks. I agree. I will split it out.
I would further suggest alphabetical sorting for the .gitignore lines.
Thanks!
Laszlo
>
> Mike
>
>> -----Original Message-----
>> From: Leif Lindholm <leif.lindholm@linaro.org>
>> Sent: Tuesday, October 29, 2019 7:30 PM
>> To: Kinney, Michael D <michael.d.kinney@intel.com>
>> Cc: devel@edk2.groups.io; Sean Brogan
>> <sean.brogan@microsoft.com>; Andrew Fish
>> <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>
>> Subject: Re: [Patch v3 02/22] .gitignore: Ignore python
>> compiled files, extdeps, and vscode
>>
>> On Tue, Oct 29, 2019 at 12:54:57PM -0700, Michael D
>> Kinney wrote:
>>> From: Sean Brogan <sean.brogan@microsoft.com>
>>>
>>> https://bugzilla.tianocore.org/show_bug.cgi?id=2315
>>>
>>> Update .gitignore to ignore .pyc files and __pycache__
>> directories.
>>> Python based plugins can be added to any package or
>> platform, so these
>>> files and directories may be present outside of
>> BaseTools.
>>>
>>> Ignore _extdep directories that are generated by the
>> pytool external
>>> dependency feature.
>>>
>>> Ignore .vscode directories generated by the VS Code
>> editor.
>>>
>>> Cc: Andrew Fish <afish@apple.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>>> Signed-off-by: Kinney <michael.d.kinney@intel.com>
>>
>> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>>
>> (This one could be merged independently of rest of set,
>> it's useful on its own.)
>>
>>> ---
>>> .gitignore | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/.gitignore b/.gitignore
>>> index 97f22c348c..71679478ac 100644
>>> --- a/.gitignore
>>> +++ b/.gitignore
>>> @@ -1,3 +1,8 @@
>>> Build/
>>> tags/
>>> .DS_Store
>>> +*.pyc
>>> +__pycache__/
>>> +*_extdep/
>>> +
>>> +.vscode/
>>> --
>>> 2.21.0.windows.1
>>>
next prev parent reply other threads:[~2019-10-31 9:02 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 19:54 [Patch v3 00/22] Enable Phase 1 of EDK II CI Michael D Kinney
2019-10-29 19:54 ` [Patch v3 01/22] Maintainers.txt: Add continuous integration(CI) directories Michael D Kinney
2019-10-30 2:34 ` Leif Lindholm
2019-10-31 9:03 ` Laszlo Ersek
2019-10-29 19:54 ` [Patch v3 02/22] .gitignore: Ignore python compiled files, extdeps, and vscode Michael D Kinney
2019-10-30 2:29 ` Leif Lindholm
2019-10-31 4:43 ` Michael D Kinney
2019-10-31 9:02 ` Laszlo Ersek [this message]
2019-11-04 16:02 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-10-29 19:54 ` [Patch v3 03/22] requirements.txt: Add python pip requirements file Michael D Kinney
2019-10-30 2:27 ` Leif Lindholm
2019-10-30 2:52 ` [edk2-devel] " Sean
2019-10-30 3:03 ` Leif Lindholm
2019-10-31 4:39 ` Michael D Kinney
2019-10-31 4:58 ` Leif Lindholm
2019-10-31 7:18 ` Sean
2019-10-31 8:59 ` Laszlo Ersek
2019-10-29 19:54 ` [Patch v3 04/22] BaseTools/tools_def.template: Add RC_PATH define Michael D Kinney
2019-11-05 8:18 ` Liming Gao
2019-11-07 0:32 ` Michael D Kinney
2019-10-29 19:55 ` [Patch v3 05/22] BaseTools: Add YAML files with path env and tool extdeps Michael D Kinney
2019-10-29 19:55 ` [Patch v3 06/22] BaseTools: Add BaseTools plugins to support CI Michael D Kinney
2019-10-29 19:55 ` [Patch v3 07/22] .pytool/Plugin: Add CI plugins Michael D Kinney
2019-10-29 19:55 ` [Patch v3 08/22] CryptoPkg: Add YAML file for CI builds Michael D Kinney
2019-10-29 19:55 ` [Patch v3 09/22] FatPkg: " Michael D Kinney
2019-10-29 19:55 ` [Patch v3 10/22] FmpDevicePkg: " Michael D Kinney
2019-10-29 19:55 ` [Patch v3 11/22] MdeModulePkg: " Michael D Kinney
2019-10-29 19:55 ` [Patch v3 12/22] MdePkg: " Michael D Kinney
2019-11-05 8:22 ` Liming Gao
2019-11-05 17:04 ` Michael D Kinney
2019-11-06 0:20 ` Liming Gao
2019-11-06 0:29 ` Michael D Kinney
2019-10-29 19:55 ` [Patch v3 13/22] NetworkPkg: " Michael D Kinney
2019-10-29 19:55 ` [Patch v3 14/22] PcAtChipsetPkg: Add YAML files " Michael D Kinney
2019-10-29 19:55 ` [Patch v3 15/22] SecurityPkg: " Michael D Kinney
2019-10-29 19:55 ` [Patch v3 16/22] ShellPkg: Add YAML file " Michael D Kinney
2019-11-05 2:19 ` Gao, Zhichao
2019-10-29 19:55 ` [Patch v3 17/22] UefiCpuPkg: " Michael D Kinney
2019-10-31 8:55 ` Laszlo Ersek
2019-10-29 19:55 ` [Patch v3 18/22] SignedCapsulePkg: Use BaseCryptLibNull to reduce package CI time Michael D Kinney
2019-11-05 8:23 ` [edk2-devel] " Liming Gao
2019-11-05 17:05 ` Michael D Kinney
2019-10-29 19:55 ` [Patch v3 19/22] .pytool: Add CISettings.py and Readme.md Michael D Kinney
2019-10-29 19:55 ` [Patch v3 20/22] .azurepipelines: Add Azure Pipelines YML configuration files Michael D Kinney
2019-10-29 19:55 ` [Patch v3 21/22] .merify: Add Megify YML pull request rules configuration file Michael D Kinney
2019-10-29 19:55 ` [Patch v3 22/22] Readme.md: Add CI build status badges Michael D Kinney
2019-10-30 2:58 ` Leif Lindholm
2019-10-31 4:42 ` Michael D Kinney
2019-11-06 0:21 ` [edk2-devel] " Liming Gao
2019-11-06 0:34 ` Michael D Kinney
2019-10-31 9:54 ` [edk2-devel] [Patch v3 00/22] Enable Phase 1 of EDK II CI Laszlo Ersek
2019-11-01 5:03 ` Michael D Kinney
2019-11-01 22:39 ` Laszlo Ersek
2019-11-01 23:22 ` Laszlo Ersek
2019-11-02 0:32 ` Michael D Kinney
2019-11-02 10:49 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cc7ef74-771d-0a71-bb94-094b8b1b5b86@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox