From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web11.3463.1572512531503641183 for ; Thu, 31 Oct 2019 02:02:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PmpTj3pD; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572512530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z5WXI/JF23B5jqMd011/ck+AG97GA49HvzlY6k1G+bw=; b=PmpTj3pD/klPmh0X78LBxP9z1lLrBhUARrdThw7nEghF4Scw4ylhd55xZpyOsJMiDsx8M3 b3gQfYaL/J6WFfAvBtneoXCs2i6zbTjnmIyvTCvGxggR4dNhRXJcqLMvu7kq99Tv+72Epl OKp7lCXB/7+P/OsC66NkoHTjbMc9Oyg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-99-hWLmA7dLMi-J_3IsSAms6A-1; Thu, 31 Oct 2019 05:02:06 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 191AE81A334; Thu, 31 Oct 2019 09:02:05 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-6.ams2.redhat.com [10.36.117.6]) by smtp.corp.redhat.com (Postfix) with ESMTP id B3E4319C5B; Thu, 31 Oct 2019 09:02:03 +0000 (UTC) Subject: Re: [Patch v3 02/22] .gitignore: Ignore python compiled files, extdeps, and vscode To: "Kinney, Michael D" , Leif Lindholm Cc: "devel@edk2.groups.io" , Sean Brogan , Andrew Fish References: <20191029195517.20028-1-michael.d.kinney@intel.com> <20191029195517.20028-3-michael.d.kinney@intel.com> <20191030022939.GT16820@bivouac.eciton.net> From: "Laszlo Ersek" Message-ID: <2cc7ef74-771d-0a71-bb94-094b8b1b5b86@redhat.com> Date: Thu, 31 Oct 2019 10:02:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: hWLmA7dLMi-J_3IsSAms6A-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/31/19 05:43, Kinney, Michael D wrote: > Leif, >=20 > Thanks. I agree. I will split it out. I would further suggest alphabetical sorting for the .gitignore lines. Thanks! Laszlo >=20 > Mike >=20 >> -----Original Message----- >> From: Leif Lindholm >> Sent: Tuesday, October 29, 2019 7:30 PM >> To: Kinney, Michael D >> Cc: devel@edk2.groups.io; Sean Brogan >> ; Andrew Fish >> ; Laszlo Ersek >> Subject: Re: [Patch v3 02/22] .gitignore: Ignore python >> compiled files, extdeps, and vscode >> >> On Tue, Oct 29, 2019 at 12:54:57PM -0700, Michael D >> Kinney wrote: >>> From: Sean Brogan >>> >>> https://bugzilla.tianocore.org/show_bug.cgi?id=3D2315 >>> >>> Update .gitignore to ignore .pyc files and __pycache__ >> directories. >>> Python based plugins can be added to any package or >> platform, so these >>> files and directories may be present outside of >> BaseTools. >>> >>> Ignore _extdep directories that are generated by the >> pytool external >>> dependency feature. >>> >>> Ignore .vscode directories generated by the VS Code >> editor. >>> >>> Cc: Andrew Fish >>> Cc: Laszlo Ersek >>> Cc: Leif Lindholm >>> Signed-off-by: Kinney >> >> Reviewed-by: Leif Lindholm >> >> (This one could be merged independently of rest of set, >> it's useful on its own.) >> >>> --- >>> .gitignore | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/.gitignore b/.gitignore >>> index 97f22c348c..71679478ac 100644 >>> --- a/.gitignore >>> +++ b/.gitignore >>> @@ -1,3 +1,8 @@ >>> Build/ >>> tags/ >>> .DS_Store >>> +*.pyc >>> +__pycache__/ >>> +*_extdep/ >>> + >>> +.vscode/ >>> -- >>> 2.21.0.windows.1 >>>