From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 37D211A1E43 for ; Thu, 27 Oct 2016 02:12:16 -0700 (PDT) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B59F580E4A; Thu, 27 Oct 2016 09:12:15 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-24.phx2.redhat.com [10.3.116.24]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9R9CEYl032560; Thu, 27 Oct 2016 05:12:15 -0400 To: "Ni, Ruiyu" , edk2-devel-01 References: <20161026190504.9888-1-lersek@redhat.com> <20161026190504.9888-12-lersek@redhat.com> <5951cde3-a91d-7374-9ff6-e19e9fd0b965@redhat.com> <734D49CCEBEEF84792F5B80ED585239D58E43EEA@SHSMSX104.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <2cc81e87-1942-3a9f-8375-4d013e357cdc@redhat.com> Date: Thu, 27 Oct 2016 11:12:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D58E43EEA@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 27 Oct 2016 09:12:15 +0000 (UTC) Subject: Re: [PATCH 11/47] DuetPkg/DuetBdsLib: rebase to ARRAY_SIZE() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2016 09:12:16 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 10/27/16 11:04, Ni, Ruiyu wrote: > Reviewed-by: Ruiyu Ni Thanks! Laszlo > Regards, > Ray > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek > Sent: Thursday, October 27, 2016 4:17 PM > To: edk2-devel-01 ; Ni, Ruiyu > Subject: Re: [edk2] [PATCH 11/47] DuetPkg/DuetBdsLib: rebase to ARRAY_SIZE() > > Ray, > > On 10/26/16 21:04, Laszlo Ersek wrote: >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Laszlo Ersek > >> --- >> DuetPkg/Library/DuetBdsLib/BdsPlatform.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/DuetPkg/Library/DuetBdsLib/BdsPlatform.c b/DuetPkg/Library/DuetBdsLib/BdsPlatform.c >> index 1875dc963680..a4b2aa947322 100644 >> --- a/DuetPkg/Library/DuetBdsLib/BdsPlatform.c >> +++ b/DuetPkg/Library/DuetBdsLib/BdsPlatform.c >> @@ -64,7 +64,7 @@ Returns: >> // >> // Iteratively add ACPI Table, SMBIOS Table, MPS Table to EFI System Table >> // >> - for (Index = 0; Index < sizeof (gTableGuidArray) / sizeof (*gTableGuidArray); ++Index) { >> + for (Index = 0; Index < ARRAY_SIZE (gTableGuidArray); ++Index) { >> GuidHob.Raw = GetNextGuidHob (gTableGuidArray[Index], HobStart.Raw); >> if (GuidHob.Raw != NULL) { >> Table = GET_GUID_HOB_DATA (GuidHob.Guid); >> > > I'm very sorry, I forgot to CC you on this patch originally. Can you > please review it? > > Thank you! > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >