From: Laszlo Ersek <lersek@redhat.com>
To: Udit Kumar <udit.kumar@nxp.com>,
Leif Lindholm <leif.lindholm@linaro.org>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib
Date: Tue, 17 Apr 2018 11:42:08 +0200 [thread overview]
Message-ID: <2ceaae52-2061-a412-638c-7ebf73f6e5ff@redhat.com> (raw)
In-Reply-To: <AM6PR0402MB3334A9C1314164B9D9345D8F91B70@AM6PR0402MB3334.eurprd04.prod.outlook.com>
On 04/17/18 10:15, Udit Kumar wrote:
> Hi Laszlo,
>
> Considering all possible option is best to have in code 😊
> But IMO, We are running UEFI on LE CPU only, Not sure someone is running on BE. AFAIK even specs says LE.
>
>> (c) assuming we introduce a CPU with BE byte order, the same driver
>> source will work (for both LE and BE devices), only the lib
>> instances will have to be switched around. (This might even happen
>> dynamically, via function pointers.)
>
> I assume , when we say CPU in BE , this means we are talking here new CPU architecture
> and new SOC. So I expect some changes in hardware IP as well.
> If not then, I see still this working with patch of Leif
>
> Like
> CPU (LE,) Driver (LE) Uses Mmio
> CPU (LE,) Driver (BE) Uses BeMmio (Mmio with swap)
>
> CPU (BE,) Driver (LE) Uses Mmio (Does read and Swap) <-- This will be new Mmio Lib for particular architecture
> CPU (BE,) Driver (BE) Uses BeMmio (Mmio with swap) <-- Swap of swap will make same value
>
> With this, I see driver code is same irrespective of CPU arch
>
> thoughts ?
Apparently I've needlessly complicated things already. Feel free to
proceed as you see fit.
Laszlo
next prev parent reply other threads:[~2018-04-17 9:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 17:42 [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib Leif Lindholm
2018-04-13 19:24 ` Kinney, Michael D
2018-04-13 19:31 ` Leif Lindholm
2018-04-13 23:32 ` Kinney, Michael D
2018-04-16 10:07 ` Leif Lindholm
2018-04-16 14:10 ` Kinney, Michael D
2018-04-16 14:34 ` Michael Brown
2018-04-16 20:42 ` Laszlo Ersek
2018-04-16 22:14 ` Michael Brown
2018-04-17 8:01 ` Laszlo Ersek
2018-04-17 8:24 ` Michael Brown
2018-04-17 9:57 ` Laszlo Ersek
2018-04-17 13:26 ` Leif Lindholm
2018-04-17 15:20 ` Kinney, Michael D
2018-04-17 6:57 ` Udit Kumar
2018-04-16 19:32 ` Laszlo Ersek
2018-04-17 8:15 ` Udit Kumar
2018-04-17 9:42 ` Laszlo Ersek [this message]
2018-04-17 10:32 ` Udit Kumar
2018-04-17 13:55 ` (spawning off more style discussion) Leif Lindholm
2018-04-18 8:51 ` Laszlo Ersek
2018-04-16 4:39 ` [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib Udit Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ceaae52-2061-a412-638c-7ebf73f6e5ff@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox