From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E91A8AC1B7A for ; Tue, 28 Nov 2023 17:15:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=EvZjqtgFnOPLoi29504ftP0zrqCM02gojhQ38nZXNuk=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701191731; v=1; b=l+ZnH0RKaIedhdT7DI4TG8+trGcRn+S7KFq7rJ++Tnpia53oGY2p14rzcyj3buPg80Z+ffX3 P2WBAx8vOkdAFJE5adPptmmrvSowu4CeBnN9/6Q6VDr37M0VqugRVsM+mQ4D87L0q7l9Pp/iH0S 7cxbT8OadCjSXzBUeW75hhbc= X-Received: by 127.0.0.2 with SMTP id QVz6YY7687511xQJlyiyHKWZ; Tue, 28 Nov 2023 09:15:31 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.39470.1701191731090113176 for ; Tue, 28 Nov 2023 09:15:31 -0800 X-Received: from [192.168.4.22] (unknown [47.201.241.198]) by linux.microsoft.com (Postfix) with ESMTPSA id 1CCE220B74C0; Tue, 28 Nov 2023 09:15:30 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1CCE220B74C0 Message-ID: <2d1b5213-faed-48fe-ab0a-3d08cd43675d@linux.microsoft.com> Date: Tue, 28 Nov 2023 12:15:28 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 0/2] ArmPkg/CpuDxe: Use upper and lower attributes To: devel@edk2.groups.io, ardb@kernel.org Cc: Leif Lindholm , Ard Biesheuvel , Sami Mujawar References: <20231128001500.1107-1-mikuback@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: lKuoXSNU5hDlxIvcqfdSzCIBx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=l+ZnH0RK; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/28/2023 4:51 AM, Ard Biesheuvel wrote: > On Tue, 28 Nov 2023 at 01:15, wrote: >> >> From: Michael Kubacki >> >> This series contains two changes: >> >> 1. To fix a compiler warning with the current state of code. >> 2. To update the code to pass the integer width needed for a >> comparison to set EFI_MEMORY_XP in the GCD attribute returned >> for a given page attribute. >> >> Cc: Leif Lindholm >> Cc: Ard Biesheuvel >> Cc: Sami Mujawar >> >> Michael Kubacki (2): >> ArmPkg/Drivers/CpuDxe: Explicitly cast table entry >> ArmPkg/Drivers/CpuDxe: Use lower and upper attributes >> >=20 > Thanks for the fixes. This code is in a rather poor state, unfortunately. >=20 > I don't quite get the motivation for fixing this using two different > patches: the implicit UINT32 cast obviously loses some attributes (the > ones in the 12 upper bits, notably UXN and PXN), so making it explicit > removes the warning but preserves the bug. (If GCC had better > diagnostics, we'd spotted this problem years ago) >=20 > Maybe it is sufficient to simply squash the two patches together? >=20 I wanted to leave that open to discussion and maintainer discretion. I=20 think a squash is fine and sent a v2 with it done. >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111816): https://edk2.groups.io/g/devel/message/111816 Mute This Topic: https://groups.io/mt/102841999/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-