Re: [edk2-devel] [PATCH v8 24/37] ArmVirtPkg: Move two PCD variables into OvmfPkg

["Chao Li" <lichao@loongson.cn>]

[-- Attachment #1: Type: text/plain, Size: 1886 bytes --]

OK, I got it, thank you for carefully reviewing my patch set, thank you 
very mach!


Thanks,
Chao
On 2024/1/31 00:45, Laszlo Ersek wrote:
> On 1/30/24 02:24, Chao Li wrote:
>> On 2024/1/30 03:49, Laszlo Ersek wrote:
>>> I suggest adding the following to your edk2 git config:
>>>
>>> [core]
>>>          attributesFile = BaseTools/Conf/gitattributes
>>>
>>> [diff "ini"]
>>>          xfuncname = ^\\[[A-Za-z0-9_., ]+]
>> Next time I will add these two configures in my git config file, it will
>> be reflected in V9 if it needed to commit.
> Thanks -- yes, that was what I meant. Certainly no need to repost the
> series just because of that; it's just that getting these settings in
> place "eventually" is good.
>
>> Ha, yes, patch 18 is added a new type, and I just add them under this
>> new type and it worked. Do you recommend these two PCDs keep the type
>> with PcdsFixedAtBuild only? If yes, in V9 I would move them under
>> PcdsFixedAtBuild.
> No, I think you did the right thing. The original permitted storage type
> list was [PcdsFixedAtBuild, PcdsPatchableInModule], and IIRC at least
> the ArmVirtQemuKernel platform relies on patchable PCDs. So restricting
> the storage type list to just [PcdsFixedAtBuild] across the move could
> cause a regression, at least in theory -- so it's best not to disturb
> that. Indeed, thus far we've not needed PcdsPatchableInModule in OVMF,
> but now that OvmfPkg accommodates more widely used artifacts, we do!
>
> Thanks!
> Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114841): https://edk2.groups.io/g/devel/message/114841
Mute This Topic: https://groups.io/mt/103971670/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 3591 bytes --]